3 files changed, 24 insertions, 33 deletions

diff --git a/drivers/misc/asus-laptop.c b/drivers/misc/asus-laptop.c
index e4e2b707a353..295e931c0dfb 100644
--- a/drivers/misc/asus-laptop.c
+++ b/drivers/misc/asus-laptop.c
@@ -195,11 +195,9 @@ static struct backlight_device *asus_backlight_device;
  */
 static int read_brightness(struct backlight_device *bd);
 static int update_bl_status(struct backlight_device *bd);
-static struct backlight_properties asusbl_data = {
-        .owner = THIS_MODULE,
+static struct backlight_ops asusbl_ops = {
         .get_brightness = read_brightness,
         .update_status = update_bl_status,
-        .max_brightness = 15,
 };
 
 /* These functions actually update the LED's, and are called from a
@@ -349,13 +347,8 @@ static void lcd_blank(int blank)
         struct backlight_device *bd = asus_backlight_device;
 
         if (bd) {
-                down(&bd->sem);
-                if (likely(bd->props)) {
-                        bd->props->power = blank;
-                        if (likely(bd->props->update_status))
-                                bd->props->update_status(bd);
-                }
-                up(&bd->sem);
+                bd->props.power = blank;
+                backlight_update_status(bd);
         }
 }
 
@@ -387,13 +380,13 @@ static int set_brightness(struct backlight_device *bd, int value)
 static int update_bl_status(struct backlight_device *bd)
 {
         int rv;
-        int value = bd->props->brightness;
+        int value = bd->props.brightness;
 
         rv = set_brightness(bd, value);
         if (rv)
                 return rv;
 
-        value = (bd->props->power == FB_BLANK_UNBLANK) ? 1 : 0;
+        value = (bd->props.power == FB_BLANK_UNBLANK) ? 1 : 0;
         return set_lcd_state(value);
 }
 
@@ -1019,7 +1012,7 @@ static int asus_backlight_init(struct device *dev)
 
         if (brightness_set_handle && lcd_switch_handle) {
                 bd = backlight_device_register(ASUS_HOTK_FILE, dev,
-                                               NULL, &asusbl_data);
+                                               NULL, &asusbl_ops);
                 if (IS_ERR(bd)) {
                         printk(ASUS_ERR
                                "Could not register asus backlight device\n");
@@ -1029,14 +1022,10 @@ static int asus_backlight_init(struct device *dev)
 
                 asus_backlight_device = bd;
 
-                down(&bd->sem);
-                if (likely(bd->props)) {
-                        bd->props->brightness = read_brightness(NULL);
-                        bd->props->power = FB_BLANK_UNBLANK;
-                        if (likely(bd->props->update_status))
-                                bd->props->update_status(bd);
-                }
-                up(&bd->sem);
+                bd->props.max_brightness = 15;
+                bd->props.brightness = read_brightness(NULL);
+                bd->props.power = FB_BLANK_UNBLANK;
+                backlight_update_status(bd);
         }
         return 0;
 }
diff --git a/drivers/misc/msi-laptop.c b/drivers/misc/msi-laptop.c
index 8e5e07e4c1cf..68c4b58525ba 100644
--- a/drivers/misc/msi-laptop.c
+++ b/drivers/misc/msi-laptop.c
@@ -157,14 +157,12 @@ static int bl_get_brightness(struct backlight_device *b)
 
 static int bl_update_status(struct backlight_device *b)
 {
-        return set_lcd_level(b->props->brightness);
+        return set_lcd_level(b->props.brightness);
 }
 
-static struct backlight_properties msibl_props = {
-        .owner          = THIS_MODULE,
+static struct backlight_ops msibl_ops = {
         .get_brightness = bl_get_brightness,
         .update_status  = bl_update_status,
-        .max_brightness = MSI_LCD_LEVEL_MAX-1,
 };
 
 static struct backlight_device *msibl_device;
@@ -318,10 +316,12 @@ static int __init msi_init(void)
         /* Register backlight stuff */
 
         msibl_device = backlight_device_register("msi-laptop-bl", NULL, NULL,
-                                                &msibl_props);
+                                                &msibl_ops);
         if (IS_ERR(msibl_device))
                 return PTR_ERR(msibl_device);
 
+        msibl_device->props.max_brightness = MSI_LCD_LEVEL_MAX-1,
+
         ret = platform_driver_register(&msipf_driver);
         if (ret)
                 goto fail_backlight;
diff --git a/drivers/misc/sony-laptop.c b/drivers/misc/sony-laptop.c
index cabbed0015e4..2ebe240dd537 100644
--- a/drivers/misc/sony-laptop.c
+++ b/drivers/misc/sony-laptop.c
@@ -384,7 +384,7 @@ static void sony_snc_pf_remove(void)
 static int sony_backlight_update_status(struct backlight_device *bd)
 {
         return acpi_callsetfunc(sony_acpi_handle, "SBRT",
-                                bd->props->brightness + 1, NULL);
+                                bd->props.brightness + 1, NULL);
 }
 
 static int sony_backlight_get_brightness(struct backlight_device *bd)
@@ -398,11 +398,9 @@ static int sony_backlight_get_brightness(struct backlight_device *bd)
 }
 
 static struct backlight_device *sony_backlight_device;
-static struct backlight_properties sony_backlight_properties = {
-        .owner = THIS_MODULE,
+static struct backlight_ops sony_backlight_ops = {
         .update_status = sony_backlight_update_status,
         .get_brightness = sony_backlight_get_brightness,
-        .max_brightness = SONY_MAX_BRIGHTNESS - 1,
 };
 
 /*
@@ -484,15 +482,19 @@ static int sony_acpi_add(struct acpi_device *device)
         if (ACPI_SUCCESS(acpi_get_handle(sony_acpi_handle, "GBRT", &handle))) {
                 sony_backlight_device = backlight_device_register("sony", NULL,
                                                                   NULL,
-                                                                  &sony_backlight_properties);
+                                                                  &sony_backlight_ops);
 
                 if (IS_ERR(sony_backlight_device)) {
                         printk(LOG_PFX "unable to register backlight device\n");
                         sony_backlight_device = NULL;
-                } else
-                        sony_backlight_properties.brightness =
+                } else {
+                        sony_backlight_device->props.brightness =
                             sony_backlight_get_brightness
                             (sony_backlight_device);
+                        sony_backlight_device->props.max_brightness = 
+                            SONY_MAX_BRIGHTNESS - 1;
+                }
+
         }
 
         if (sony_snc_pf_add())