diff options
Diffstat (limited to 'drivers/misc/pti.c')
-rw-r--r-- | drivers/misc/pti.c | 11 |
1 files changed, 7 insertions, 4 deletions
diff --git a/drivers/misc/pti.c b/drivers/misc/pti.c index bb6f9255c17c..374dfcfccd07 100644 --- a/drivers/misc/pti.c +++ b/drivers/misc/pti.c | |||
@@ -317,7 +317,8 @@ EXPORT_SYMBOL_GPL(pti_request_masterchannel); | |||
317 | * a master, channel ID address | 317 | * a master, channel ID address |
318 | * used to write to PTI HW. | 318 | * used to write to PTI HW. |
319 | * | 319 | * |
320 | * @mc: master, channel apeture ID address to be released. | 320 | * @mc: master, channel apeture ID address to be released. This |
321 | * will de-allocate the structure via kfree(). | ||
321 | */ | 322 | */ |
322 | void pti_release_masterchannel(struct pti_masterchannel *mc) | 323 | void pti_release_masterchannel(struct pti_masterchannel *mc) |
323 | { | 324 | { |
@@ -475,8 +476,10 @@ static int pti_tty_install(struct tty_driver *driver, struct tty_struct *tty) | |||
475 | else | 476 | else |
476 | pti_tty_data->mc = pti_request_masterchannel(2); | 477 | pti_tty_data->mc = pti_request_masterchannel(2); |
477 | 478 | ||
478 | if (pti_tty_data->mc == NULL) | 479 | if (pti_tty_data->mc == NULL) { |
480 | kfree(pti_tty_data); | ||
479 | return -ENXIO; | 481 | return -ENXIO; |
482 | } | ||
480 | tty->driver_data = pti_tty_data; | 483 | tty->driver_data = pti_tty_data; |
481 | } | 484 | } |
482 | 485 | ||
@@ -495,7 +498,7 @@ static void pti_tty_cleanup(struct tty_struct *tty) | |||
495 | if (pti_tty_data == NULL) | 498 | if (pti_tty_data == NULL) |
496 | return; | 499 | return; |
497 | pti_release_masterchannel(pti_tty_data->mc); | 500 | pti_release_masterchannel(pti_tty_data->mc); |
498 | kfree(tty->driver_data); | 501 | kfree(pti_tty_data); |
499 | tty->driver_data = NULL; | 502 | tty->driver_data = NULL; |
500 | } | 503 | } |
501 | 504 | ||
@@ -581,7 +584,7 @@ static int pti_char_open(struct inode *inode, struct file *filp) | |||
581 | static int pti_char_release(struct inode *inode, struct file *filp) | 584 | static int pti_char_release(struct inode *inode, struct file *filp) |
582 | { | 585 | { |
583 | pti_release_masterchannel(filp->private_data); | 586 | pti_release_masterchannel(filp->private_data); |
584 | kfree(filp->private_data); | 587 | filp->private_data = NULL; |
585 | return 0; | 588 | return 0; |
586 | } | 589 | } |
587 | 590 | ||