1 files changed, 45 insertions, 13 deletions

diff --git a/drivers/mfd/s5m-core.c b/drivers/mfd/s5m-core.c
index caadabeed8e9..48949d998d10 100644
--- a/drivers/mfd/s5m-core.c
+++ b/drivers/mfd/s5m-core.c
@@ -26,7 +26,27 @@
 #include <linux/mfd/s5m87xx/s5m-rtc.h>
 #include <linux/regmap.h>
 
-static struct mfd_cell s5m87xx_devs[] = {
+static struct mfd_cell s5m8751_devs[] = {
+        {
+                .name = "s5m8751-pmic",
+        }, {
+                .name = "s5m-charger",
+        }, {
+                .name = "s5m8751-codec",
+        },
+};
+
+static struct mfd_cell s5m8763_devs[] = {
+        {
+                .name = "s5m8763-pmic",
+        }, {
+                .name = "s5m-rtc",
+        }, {
+                .name = "s5m-charger",
+        },
+};
+
+static struct mfd_cell s5m8767_devs[] = {
         {
                 .name = "s5m8767-pmic",
         }, {
@@ -42,7 +62,7 @@ EXPORT_SYMBOL_GPL(s5m_reg_read);
 
 int s5m_bulk_read(struct s5m87xx_dev *s5m87xx, u8 reg, int count, u8 *buf)
 {
-        return regmap_bulk_read(s5m87xx->regmap, reg, buf, count);;
+        return regmap_bulk_read(s5m87xx->regmap, reg, buf, count);
 }
 EXPORT_SYMBOL_GPL(s5m_bulk_read);
 
@@ -54,7 +74,7 @@ EXPORT_SYMBOL_GPL(s5m_reg_write);
 
 int s5m_bulk_write(struct s5m87xx_dev *s5m87xx, u8 reg, int count, u8 *buf)
 {
-        return regmap_raw_write(s5m87xx->regmap, reg, buf, count * sizeof(u16));
+        return regmap_raw_write(s5m87xx->regmap, reg, buf, count);
 }
 EXPORT_SYMBOL_GPL(s5m_bulk_write);
 
@@ -74,10 +94,10 @@ static int s5m87xx_i2c_probe(struct i2c_client *i2c,
 {
         struct s5m_platform_data *pdata = i2c->dev.platform_data;
         struct s5m87xx_dev *s5m87xx;
-        int ret = 0;
-        int error;
+        int ret;
 
-        s5m87xx = kzalloc(sizeof(struct s5m87xx_dev), GFP_KERNEL);
+        s5m87xx = devm_kzalloc(&i2c->dev, sizeof(struct s5m87xx_dev),
+                                GFP_KERNEL);
         if (s5m87xx == NULL)
                 return -ENOMEM;
 
@@ -96,9 +116,9 @@ static int s5m87xx_i2c_probe(struct i2c_client *i2c,
 
         s5m87xx->regmap = regmap_init_i2c(i2c, &s5m_regmap_config);
         if (IS_ERR(s5m87xx->regmap)) {
-                error = PTR_ERR(s5m87xx->regmap);
+                ret = PTR_ERR(s5m87xx->regmap);
                 dev_err(&i2c->dev, "Failed to allocate register map: %d\n",
-                        error);
+                        ret);
                 goto err;
         }
 
@@ -112,9 +132,23 @@ static int s5m87xx_i2c_probe(struct i2c_client *i2c,
 
         pm_runtime_set_active(s5m87xx->dev);
 
-        ret = mfd_add_devices(s5m87xx->dev, -1,
-                                s5m87xx_devs, ARRAY_SIZE(s5m87xx_devs),
-                                NULL, 0);
+        switch (s5m87xx->device_type) {
+        case S5M8751X:
+                ret = mfd_add_devices(s5m87xx->dev, -1, s5m8751_devs,
+                                        ARRAY_SIZE(s5m8751_devs), NULL, 0);
+                break;
+        case S5M8763X:
+                ret = mfd_add_devices(s5m87xx->dev, -1, s5m8763_devs,
+                                        ARRAY_SIZE(s5m8763_devs), NULL, 0);
+                break;
+        case S5M8767X:
+                ret = mfd_add_devices(s5m87xx->dev, -1, s5m8767_devs,
+                                        ARRAY_SIZE(s5m8767_devs), NULL, 0);
+                break;
+        default:
+                /* If this happens the probe function is problem */
+                BUG();
+        }
 
         if (ret < 0)
                 goto err;
@@ -126,7 +160,6 @@ err:
         s5m_irq_exit(s5m87xx);
         i2c_unregister_device(s5m87xx->rtc);
         regmap_exit(s5m87xx->regmap);
-        kfree(s5m87xx);
         return ret;
 }
 
@@ -138,7 +171,6 @@ static int s5m87xx_i2c_remove(struct i2c_client *i2c)
         s5m_irq_exit(s5m87xx);
         i2c_unregister_device(s5m87xx->rtc);
         regmap_exit(s5m87xx->regmap);
-        kfree(s5m87xx);
         return 0;
 }