1 files changed, 29 insertions, 30 deletions

diff --git a/drivers/media/video/video-buf.c b/drivers/media/video/video-buf.c
index 9ef477523d27..87e937581d5a 100644
--- a/drivers/media/video/video-buf.c
+++ b/drivers/media/video/video-buf.c
@@ -59,8 +59,7 @@ videobuf_vmalloc_to_sg(unsigned char *virt, int nr_pages)
                 pg = vmalloc_to_page(virt);
                 if (NULL == pg)
                         goto err;
-                if (PageHighMem(pg))
-                        BUG();
+                BUG_ON(PageHighMem(pg));
                 sglist[i].page   = pg;
                 sglist[i].length = PAGE_SIZE;
         }
@@ -385,7 +384,7 @@ void videobuf_queue_init(struct videobuf_queue* q,
         q->ops     = ops;
         q->priv_data = priv;
 
-        init_MUTEX(&q->lock);
+        mutex_init(&q->lock);
         INIT_LIST_HEAD(&q->stream);
 }
 
@@ -428,7 +427,7 @@ videobuf_queue_is_busy(struct videobuf_queue *q)
 void
 videobuf_queue_cancel(struct videobuf_queue *q)
 {
-        unsigned long flags;
+        unsigned long flags=0;
         int i;
 
         /* remove queued buffers from list */
@@ -549,7 +548,7 @@ videobuf_reqbufs(struct videobuf_queue *q,
         if (!list_empty(&q->stream))
                 return -EBUSY;
 
-        down(&q->lock);
+        mutex_lock(&q->lock);
         count = req->count;
         if (count > VIDEO_MAX_FRAME)
                 count = VIDEO_MAX_FRAME;
@@ -566,7 +565,7 @@ videobuf_reqbufs(struct videobuf_queue *q,
         req->count = count;
 
  done:
-        up(&q->lock);
+        mutex_unlock(&q->lock);
         return retval;
 }
 
@@ -589,10 +588,10 @@ videobuf_qbuf(struct videobuf_queue *q,
 {
         struct videobuf_buffer *buf;
         enum v4l2_field field;
-        unsigned long flags;
+        unsigned long flags=0;
         int retval;
 
-        down(&q->lock);
+        mutex_lock(&q->lock);
         retval = -EBUSY;
         if (q->reading)
                 goto done;
@@ -652,7 +651,7 @@ videobuf_qbuf(struct videobuf_queue *q,
         retval = 0;
 
  done:
-        up(&q->lock);
+        mutex_unlock(&q->lock);
         return retval;
 }
 
@@ -663,7 +662,7 @@ videobuf_dqbuf(struct videobuf_queue *q,
         struct videobuf_buffer *buf;
         int retval;
 
-        down(&q->lock);
+        mutex_lock(&q->lock);
         retval = -EBUSY;
         if (q->reading)
                 goto done;
@@ -693,7 +692,7 @@ videobuf_dqbuf(struct videobuf_queue *q,
         videobuf_status(b,buf,q->type);
 
  done:
-        up(&q->lock);
+        mutex_unlock(&q->lock);
         return retval;
 }
 
@@ -701,10 +700,10 @@ int videobuf_streamon(struct videobuf_queue *q)
 {
         struct videobuf_buffer *buf;
         struct list_head *list;
-        unsigned long flags;
+        unsigned long flags=0;
         int retval;
 
-        down(&q->lock);
+        mutex_lock(&q->lock);
         retval = -EBUSY;
         if (q->reading)
                 goto done;
@@ -721,7 +720,7 @@ int videobuf_streamon(struct videobuf_queue *q)
         spin_unlock_irqrestore(q->irqlock,flags);
 
  done:
-        up(&q->lock);
+        mutex_unlock(&q->lock);
         return retval;
 }
 
@@ -729,7 +728,7 @@ int videobuf_streamoff(struct videobuf_queue *q)
 {
         int retval = -EINVAL;
 
-        down(&q->lock);
+        mutex_lock(&q->lock);
         if (!q->streaming)
                 goto done;
         videobuf_queue_cancel(q);
@@ -737,7 +736,7 @@ int videobuf_streamoff(struct videobuf_queue *q)
         retval = 0;
 
  done:
-        up(&q->lock);
+        mutex_unlock(&q->lock);
         return retval;
 }
 
@@ -746,7 +745,7 @@ videobuf_read_zerocopy(struct videobuf_queue *q, char __user *data,
                        size_t count, loff_t *ppos)
 {
         enum v4l2_field field;
-        unsigned long flags;
+        unsigned long flags=0;
         int retval;
 
         /* setup stuff */
@@ -788,11 +787,11 @@ ssize_t videobuf_read_one(struct videobuf_queue *q,
                           int nonblocking)
 {
         enum v4l2_field field;
-        unsigned long flags;
+        unsigned long flags=0;
         unsigned size, nbufs, bytes;
         int retval;
 
-        down(&q->lock);
+        mutex_lock(&q->lock);
 
         nbufs = 1; size = 0;
         q->ops->buf_setup(q,&nbufs,&size);
@@ -860,14 +859,14 @@ ssize_t videobuf_read_one(struct videobuf_queue *q,
         }
 
  done:
-        up(&q->lock);
+        mutex_unlock(&q->lock);
         return retval;
 }
 
 int videobuf_read_start(struct videobuf_queue *q)
 {
         enum v4l2_field field;
-        unsigned long flags;
+        unsigned long flags=0;
         int count = 0, size = 0;
         int err, i;
 
@@ -919,10 +918,10 @@ ssize_t videobuf_read_stream(struct videobuf_queue *q,
 {
         unsigned int *fc, bytes;
         int err, retval;
-        unsigned long flags;
+        unsigned long flags=0;
 
         dprintk(2,"%s\n",__FUNCTION__);
-        down(&q->lock);
+        mutex_lock(&q->lock);
         retval = -EBUSY;
         if (q->streaming)
                 goto done;
@@ -996,7 +995,7 @@ ssize_t videobuf_read_stream(struct videobuf_queue *q,
         }
 
  done:
-        up(&q->lock);
+        mutex_unlock(&q->lock);
         return retval;
 }
 
@@ -1007,7 +1006,7 @@ unsigned int videobuf_poll_stream(struct file *file,
         struct videobuf_buffer *buf = NULL;
         unsigned int rc = 0;
 
-        down(&q->lock);
+        mutex_lock(&q->lock);
         if (q->streaming) {
                 if (!list_empty(&q->stream))
                         buf = list_entry(q->stream.next,
@@ -1035,7 +1034,7 @@ unsigned int videobuf_poll_stream(struct file *file,
                     buf->state == STATE_ERROR)
                         rc = POLLIN|POLLRDNORM;
         }
-        up(&q->lock);
+        mutex_unlock(&q->lock);
         return rc;
 }
 
@@ -1064,7 +1063,7 @@ videobuf_vm_close(struct vm_area_struct *vma)
         map->count--;
         if (0 == map->count) {
                 dprintk(1,"munmap %p q=%p\n",map,q);
-                down(&q->lock);
+                mutex_lock(&q->lock);
                 for (i = 0; i < VIDEO_MAX_FRAME; i++) {
                         if (NULL == q->bufs[i])
                                 continue;
@@ -1076,7 +1075,7 @@ videobuf_vm_close(struct vm_area_struct *vma)
                         q->bufs[i]->baddr = 0;
                         q->ops->buf_release(q,q->bufs[i]);
                 }
-                up(&q->lock);
+                mutex_unlock(&q->lock);
                 kfree(map);
         }
         return;
@@ -1170,7 +1169,7 @@ int videobuf_mmap_mapper(struct videobuf_queue *q,
         unsigned int first,last,size,i;
         int retval;
 
-        down(&q->lock);
+        mutex_lock(&q->lock);
         retval = -EINVAL;
         if (!(vma->vm_flags & VM_WRITE)) {
                 dprintk(1,"mmap app bug: PROT_WRITE please\n");
@@ -1238,7 +1237,7 @@ int videobuf_mmap_mapper(struct videobuf_queue *q,
         retval = 0;
 
  done:
-        up(&q->lock);
+        mutex_unlock(&q->lock);
         return retval;
 }