diff options
Diffstat (limited to 'drivers/media/video/saa7164/saa7164-fw.c')
-rw-r--r-- | drivers/media/video/saa7164/saa7164-fw.c | 12 |
1 files changed, 5 insertions, 7 deletions
diff --git a/drivers/media/video/saa7164/saa7164-fw.c b/drivers/media/video/saa7164/saa7164-fw.c index 484533c32bb1..ebed6f786a23 100644 --- a/drivers/media/video/saa7164/saa7164-fw.c +++ b/drivers/media/video/saa7164/saa7164-fw.c | |||
@@ -178,7 +178,7 @@ int saa7164_downloadimage(struct saa7164_dev *dev, u8 *src, u32 srcsize, | |||
178 | goto out; | 178 | goto out; |
179 | } | 179 | } |
180 | 180 | ||
181 | msleep(10); | 181 | msleep(10); /* Checkpatch throws a < 20ms warning */ |
182 | if (timeout++ > 60) | 182 | if (timeout++ > 60) |
183 | break; | 183 | break; |
184 | } | 184 | } |
@@ -235,7 +235,7 @@ int saa7164_downloadfirmware(struct saa7164_dev *dev) | |||
235 | while (err_flags != SAA_DEVICE_IMAGE_BOOTING) { | 235 | while (err_flags != SAA_DEVICE_IMAGE_BOOTING) { |
236 | dprintk(DBGLVL_FW, "%s() err_flags = %x\n", | 236 | dprintk(DBGLVL_FW, "%s() err_flags = %x\n", |
237 | __func__, err_flags); | 237 | __func__, err_flags); |
238 | msleep(10); | 238 | msleep(10); /* Checkpatch throws a < 20ms warning */ |
239 | 239 | ||
240 | if (err_flags & SAA_DEVICE_IMAGE_CORRUPT) { | 240 | if (err_flags & SAA_DEVICE_IMAGE_CORRUPT) { |
241 | printk(KERN_ERR "%s() firmware corrupt\n", | 241 | printk(KERN_ERR "%s() firmware corrupt\n", |
@@ -294,7 +294,7 @@ int saa7164_downloadfirmware(struct saa7164_dev *dev) | |||
294 | while (err_flags != SAA_DEVICE_IMAGE_BOOTING) { | 294 | while (err_flags != SAA_DEVICE_IMAGE_BOOTING) { |
295 | dprintk(DBGLVL_FW, "%s() err_flags2 = %x\n", | 295 | dprintk(DBGLVL_FW, "%s() err_flags2 = %x\n", |
296 | __func__, err_flags); | 296 | __func__, err_flags); |
297 | msleep(10); | 297 | msleep(10); /* Checkpatch throws a < 20ms warning */ |
298 | 298 | ||
299 | if (err_flags & SAA_DEVICE_IMAGE_CORRUPT) { | 299 | if (err_flags & SAA_DEVICE_IMAGE_CORRUPT) { |
300 | printk(KERN_ERR | 300 | printk(KERN_ERR |
@@ -365,7 +365,7 @@ int saa7164_downloadfirmware(struct saa7164_dev *dev) | |||
365 | 365 | ||
366 | first_timeout = SAA_DEVICE_TIMEOUT; | 366 | first_timeout = SAA_DEVICE_TIMEOUT; |
367 | while (first_timeout) { | 367 | while (first_timeout) { |
368 | msleep(10); | 368 | msleep(10); /* Checkpatch throws a < 20ms warning */ |
369 | 369 | ||
370 | version = | 370 | version = |
371 | saa7164_getcurrentfirmwareversion(dev); | 371 | saa7164_getcurrentfirmwareversion(dev); |
@@ -608,8 +608,6 @@ int saa7164_downloadfirmware(struct saa7164_dev *dev) | |||
608 | ret = 0; | 608 | ret = 0; |
609 | 609 | ||
610 | out: | 610 | out: |
611 | if (fw) | 611 | release_firmware(fw); |
612 | release_firmware(fw); | ||
613 | |||
614 | return ret; | 612 | return ret; |
615 | } | 613 | } |