1 files changed, 47 insertions, 8 deletions

diff --git a/drivers/media/video/ivtv/ivtv-yuv.c b/drivers/media/video/ivtv/ivtv-yuv.c
index bcea09542e5a..e2288f224ab6 100644
--- a/drivers/media/video/ivtv/ivtv-yuv.c
+++ b/drivers/media/video/ivtv/ivtv-yuv.c
@@ -19,11 +19,16 @@
  */
 
 #include "ivtv-driver.h"
-#include "ivtv-queue.h"
 #include "ivtv-udma.h"
-#include "ivtv-irq.h"
 #include "ivtv-yuv.h"
 
+const u32 yuv_offset[4] = {
+        IVTV_YUV_BUFFER_OFFSET,
+        IVTV_YUV_BUFFER_OFFSET_1,
+        IVTV_YUV_BUFFER_OFFSET_2,
+        IVTV_YUV_BUFFER_OFFSET_3
+};
+
 static int ivtv_yuv_prep_user_dma(struct ivtv *itv, struct ivtv_user_dma *dma,
                                  struct ivtv_dma_frame *args)
 {
@@ -37,7 +42,7 @@ static int ivtv_yuv_prep_user_dma(struct ivtv *itv, struct ivtv_user_dma *dma,
         int y_decode_height, uv_decode_height, y_size;
         int frame = atomic_read(&itv->yuv_info.next_fill_frame);
 
-        y_buffer_offset = IVTV_DEC_MEM_START + yuv_offset[frame];
+        y_buffer_offset = IVTV_DECODER_OFFSET + yuv_offset[frame];
         uv_buffer_offset = y_buffer_offset + IVTV_YUV_BUFFER_UV_OFFSET;
 
         y_decode_height = uv_decode_height = args->src.height + args->src.top;
@@ -83,7 +88,14 @@ static int ivtv_yuv_prep_user_dma(struct ivtv *itv, struct ivtv_user_dma *dma,
         }
 
         /* Fill & map SG List */
-        ivtv_udma_fill_sg_list (dma, &uv_dma, ivtv_udma_fill_sg_list (dma, &y_dma, 0));
+        if (ivtv_udma_fill_sg_list (dma, &uv_dma, ivtv_udma_fill_sg_list (dma, &y_dma, 0)) < 0) {
+                IVTV_DEBUG_WARN("could not allocate bounce buffers for highmem userspace buffers\n");
+                for (i = 0; i < dma->page_count; i++) {
+                        put_page(dma->map[i]);
+                }
+                dma->page_count = 0;
+                return -ENOMEM;
+        }
         dma->SG_length = pci_map_sg(itv->dev, dma->SGlist, dma->page_count, PCI_DMA_TODEVICE);
 
         /* Fill SG Array with new values */
@@ -94,7 +106,7 @@ static int ivtv_yuv_prep_user_dma(struct ivtv *itv, struct ivtv_user_dma *dma,
                 if (itv->yuv_info.blanking_dmaptr) {
                         dma->SGarray[dma->SG_length].size = cpu_to_le32(720*16);
                         dma->SGarray[dma->SG_length].src = cpu_to_le32(itv->yuv_info.blanking_dmaptr);
-                        dma->SGarray[dma->SG_length].dst = cpu_to_le32(IVTV_DEC_MEM_START + yuv_offset[frame]);
+                        dma->SGarray[dma->SG_length].dst = cpu_to_le32(IVTV_DECODER_OFFSET + yuv_offset[frame]);
                         dma->SG_length++;
                 }
         }
@@ -612,7 +624,6 @@ static void ivtv_yuv_handle_vertical(struct ivtv *itv, struct yuv_frame_info *wi
                 itv->yuv_info.v_filter_2 = v_filter_2;
         }
 
-        itv->yuv_info.frame_interlaced_last = itv->yuv_info.frame_interlaced;
 }
 
 /* Modify the supplied coordinate information to fit the visible osd area */
@@ -799,6 +810,7 @@ static u32 ivtv_yuv_window_setup (struct ivtv *itv, struct yuv_frame_info *windo
             (itv->yuv_info.old_frame_info.src_y != window->src_y) ||
             (itv->yuv_info.old_frame_info.pan_y != window->pan_y) ||
             (itv->yuv_info.old_frame_info.vis_h != window->vis_h) ||
+            (itv->yuv_info.old_frame_info.lace_mode != window->lace_mode) ||
             (itv->yuv_info.old_frame_info.interlaced_y != window->interlaced_y) ||
             (itv->yuv_info.old_frame_info.interlaced_uv != window->interlaced_uv)) {
                 yuv_update |= IVTV_YUV_UPDATE_VERTICAL;
@@ -898,8 +910,21 @@ static void ivtv_yuv_init (struct ivtv *itv)
                 itv->yuv_info.decode_height = 480;
 
         /* If no visible size set, assume full size */
-        if (!itv->yuv_info.osd_vis_w) itv->yuv_info.osd_vis_w = 720 - itv->yuv_info.osd_x_offset;
-        if (!itv->yuv_info.osd_vis_h) itv->yuv_info.osd_vis_h = itv->yuv_info.decode_height - itv->yuv_info.osd_y_offset;
+        if (!itv->yuv_info.osd_vis_w)
+                itv->yuv_info.osd_vis_w = 720 - itv->yuv_info.osd_x_offset;
+
+        if (!itv->yuv_info.osd_vis_h) {
+                itv->yuv_info.osd_vis_h = itv->yuv_info.decode_height - itv->yuv_info.osd_y_offset;
+        } else {
+                /* If output video standard has changed, requested height may
+                not be legal */
+                if (itv->yuv_info.osd_vis_h + itv->yuv_info.osd_y_offset > itv->yuv_info.decode_height) {
+                        IVTV_DEBUG_WARN("Clipping yuv output - fb size (%d) exceeds video standard limit (%d)\n",
+                                        itv->yuv_info.osd_vis_h + itv->yuv_info.osd_y_offset,
+                                        itv->yuv_info.decode_height);
+                        itv->yuv_info.osd_vis_h = itv->yuv_info.decode_height - itv->yuv_info.osd_y_offset;
+                }
+        }
 
         /* We need a buffer for blanking when Y plane is offset - non-fatal if we can't get one */
         itv->yuv_info.blanking_ptr = kzalloc(720*16,GFP_KERNEL);
@@ -927,6 +952,7 @@ int ivtv_yuv_prep_frame(struct ivtv *itv, struct ivtv_dma_frame *args)
         int rc = 0;
         int got_sig = 0;
         int frame, next_fill_frame, last_fill_frame;
+        int register_update = 0;
 
         IVTV_DEBUG_INFO("yuv_prep_frame\n");
 
@@ -940,6 +966,7 @@ int ivtv_yuv_prep_frame(struct ivtv *itv, struct ivtv_dma_frame *args)
                 /* Buffers are full - Overwrite the last frame */
                 next_fill_frame = frame;
                 frame = (frame - 1) & 3;
+                register_update = itv->yuv_info.new_frame_info[frame].update;
         }
 
         /* Take a snapshot of the yuv coordinate information */
@@ -955,6 +982,9 @@ int ivtv_yuv_prep_frame(struct ivtv *itv, struct ivtv_dma_frame *args)
         itv->yuv_info.new_frame_info[frame].tru_w = args->src_width;
         itv->yuv_info.new_frame_info[frame].tru_h = args->src_height;
 
+        /* Snapshot field order */
+        itv->yuv_info.sync_field[frame] = itv->yuv_info.lace_sync_field;
+
         /* Are we going to offset the Y plane */
         if (args->src.height + args->src.top < 512-16)
                 itv->yuv_info.new_frame_info[frame].offset_y = 1;
@@ -970,6 +1000,7 @@ int ivtv_yuv_prep_frame(struct ivtv *itv, struct ivtv_dma_frame *args)
         itv->yuv_info.new_frame_info[frame].update = 0;
         itv->yuv_info.new_frame_info[frame].interlaced_y = 0;
         itv->yuv_info.new_frame_info[frame].interlaced_uv = 0;
+        itv->yuv_info.new_frame_info[frame].lace_mode = itv->yuv_info.lace_mode;
 
         if (memcmp (&itv->yuv_info.old_frame_info_args, &itv->yuv_info.new_frame_info[frame],
             sizeof (itv->yuv_info.new_frame_info[frame]))) {
@@ -978,6 +1009,14 @@ int ivtv_yuv_prep_frame(struct ivtv *itv, struct ivtv_dma_frame *args)
 /*              IVTV_DEBUG_YUV ("Requesting register update for frame %d\n",frame); */
         }
 
+        itv->yuv_info.new_frame_info[frame].update |= register_update;
+
+        /* Should this frame be delayed ? */
+        if (itv->yuv_info.sync_field[frame] != itv->yuv_info.sync_field[(frame - 1) & 3])
+                itv->yuv_info.field_delay[frame] = 1;
+        else
+                itv->yuv_info.field_delay[frame] = 0;
+
         /* DMA the frame */
         mutex_lock(&itv->udma.lock);