1 files changed, 1 insertions, 5 deletions

diff --git a/drivers/media/video/em28xx/em28xx-video.c b/drivers/media/video/em28xx/em28xx-video.c
index 40307f3f6fe3..b8d5327c438d 100644
--- a/drivers/media/video/em28xx/em28xx-video.c
+++ b/drivers/media/video/em28xx/em28xx-video.c
@@ -252,10 +252,8 @@ static int em28xx_v4l2_open(struct inode *inode, struct file *filp)
         int minor = iminor(inode);
         int errCode = 0;
         struct em28xx *h,*dev = NULL;
-        struct list_head *list;
 
-        list_for_each(list,&em28xx_devlist) {
-                h = list_entry(list, struct em28xx, devlist);
+        list_for_each_entry(h, &em28xx_devlist, devlist) {
                 if (h->vdev->minor == minor) {
                         dev  = h;
                         dev->type = V4L2_BUF_TYPE_VIDEO_CAPTURE;
@@ -268,8 +266,6 @@ static int em28xx_v4l2_open(struct inode *inode, struct file *filp)
         if (NULL == dev)
                 return -ENODEV;
 
-        filp->private_data=dev;
-
         em28xx_videodbg("open minor=%d type=%s users=%d\n",
                                 minor,v4l2_type_names[dev->type],dev->users);