1 files changed, 25 insertions, 11 deletions

diff --git a/drivers/media/video/bt8xx/bttv-driver.c b/drivers/media/video/bt8xx/bttv-driver.c
index fcf8f2d208a8..2ca3e9cfb2bb 100644
--- a/drivers/media/video/bt8xx/bttv-driver.c
+++ b/drivers/media/video/bt8xx/bttv-driver.c
@@ -2372,7 +2372,7 @@ static int setup_window(struct bttv_fh *fh, struct bttv *btv,
         if (check_btres(fh, RESOURCE_OVERLAY)) {
                 struct bttv_buffer *new;
 
-                new = videobuf_pci_alloc(sizeof(*new));
+                new = videobuf_sg_alloc(sizeof(*new));
                 new->crop = btv->crop[!!fh->do_crop].rect;
                 bttv_overlay_risc(btv, &fh->ov, fh->ovfmt, new);
                 retval = bttv_switch_overlay(btv,fh,new);
@@ -2760,7 +2760,7 @@ static int bttv_overlay(struct file *file, void *f, unsigned int on)
         mutex_lock(&fh->cap.vb_lock);
         if (on) {
                 fh->ov.tvnorm = btv->tvnorm;
-                new = videobuf_pci_alloc(sizeof(*new));
+                new = videobuf_sg_alloc(sizeof(*new));
                 new->crop = btv->crop[!!fh->do_crop].rect;
                 bttv_overlay_risc(btv, &fh->ov, fh->ovfmt, new);
         } else {
@@ -2834,7 +2834,7 @@ static int bttv_s_fbuf(struct file *file, void *f,
                 if (check_btres(fh, RESOURCE_OVERLAY)) {
                         struct bttv_buffer *new;
 
-                        new = videobuf_pci_alloc(sizeof(*new));
+                        new = videobuf_sg_alloc(sizeof(*new));
                         new->crop = btv->crop[!!fh->do_crop].rect;
                         bttv_overlay_risc(btv, &fh->ov, fh->ovfmt, new);
                         retval = bttv_switch_overlay(btv, fh, new);
@@ -3117,12 +3117,18 @@ static int bttv_s_crop(struct file *file, void *f, struct v4l2_crop *crop)
 
 static int bttv_g_audio(struct file *file, void *priv, struct v4l2_audio *a)
 {
+        if (unlikely(a->index))
+                return -EINVAL;
+
         strcpy(a->name, "audio");
         return 0;
 }
 
 static int bttv_s_audio(struct file *file, void *priv, struct v4l2_audio *a)
 {
+        if (unlikely(a->index))
+                return -EINVAL;
+
         return 0;
 }
 
@@ -3184,7 +3190,7 @@ static unsigned int bttv_poll(struct file *file, poll_table *wait)
                         /* need to capture a new frame */
                         if (locked_btres(fh->btv,RESOURCE_VIDEO_STREAM))
                                 goto err;
-                        fh->cap.read_buf = videobuf_pci_alloc(fh->cap.msize);
+                        fh->cap.read_buf = videobuf_sg_alloc(fh->cap.msize);
                         if (NULL == fh->cap.read_buf)
                                 goto err;
                         fh->cap.read_buf->memory = V4L2_MEMORY_USERPTR;
@@ -3251,14 +3257,14 @@ static int bttv_open(struct inode *inode, struct file *file)
         fh->ov.setup_ok = 0;
         v4l2_prio_open(&btv->prio,&fh->prio);
 
-        videobuf_queue_pci_init(&fh->cap, &bttv_video_qops,
-                            btv->c.pci, &btv->s_lock,
+        videobuf_queue_sg_init(&fh->cap, &bttv_video_qops,
+                            &btv->c.pci->dev, &btv->s_lock,
                             V4L2_BUF_TYPE_VIDEO_CAPTURE,
                             V4L2_FIELD_INTERLACED,
                             sizeof(struct bttv_buffer),
                             fh);
-        videobuf_queue_pci_init(&fh->vbi, &bttv_vbi_qops,
-                            btv->c.pci, &btv->s_lock,
+        videobuf_queue_sg_init(&fh->vbi, &bttv_vbi_qops,
+                            &btv->c.pci->dev, &btv->s_lock,
                             V4L2_BUF_TYPE_VBI_CAPTURE,
                             V4L2_FIELD_SEQ_TB,
                             sizeof(struct bttv_buffer),
@@ -3457,6 +3463,9 @@ static int radio_release(struct inode *inode, struct file *file)
         struct bttv *btv = fh->btv;
         struct rds_command cmd;
 
+        file->private_data = NULL;
+        kfree(fh);
+
         btv->radio_user--;
 
         bttv_call_i2c_clients(btv, RDS_CMD_CLOSE, &cmd);
@@ -3510,7 +3519,7 @@ static int radio_enum_input(struct file *file, void *priv,
                 return -EINVAL;
 
         strcpy(i->name, "Radio");
-         i->type = V4L2_INPUT_TYPE_TUNER;
+        i->type = V4L2_INPUT_TYPE_TUNER;
 
         return 0;
 }
@@ -3518,10 +3527,9 @@ static int radio_enum_input(struct file *file, void *priv,
 static int radio_g_audio(struct file *file, void *priv,
                                         struct v4l2_audio *a)
 {
-        if (a->index != 0)
+        if (unlikely(a->index))
                 return -EINVAL;
 
-        memset(a, 0, sizeof(*a));
         strcpy(a->name, "Radio");
 
         return 0;
@@ -3543,11 +3551,17 @@ static int radio_s_tuner(struct file *file, void *priv,
 static int radio_s_audio(struct file *file, void *priv,
                                         struct v4l2_audio *a)
 {
+        if (unlikely(a->index))
+                return -EINVAL;
+
         return 0;
 }
 
 static int radio_s_input(struct file *filp, void *priv, unsigned int i)
 {
+        if (unlikely(i))
+                return -EINVAL;
+
         return 0;
 }