1 files changed, 217 insertions, 137 deletions

diff --git a/drivers/media/radio/radio-maxiradio.c b/drivers/media/radio/radio-maxiradio.c
index 6beeb74004b1..8e184cfc1c94 100644
--- a/drivers/media/radio/radio-maxiradio.c
+++ b/drivers/media/radio/radio-maxiradio.c
@@ -27,7 +27,9 @@
  * BUGS:
  *   - card unmutes if you change frequency
  *
- * Converted to V4L2 API by Mauro Carvalho Chehab <mchehab@infradead.org>
+ * (c) 2006, 2007 by Mauro Carvalho Chehab <mchehab@infradead.org>:
+ *      - Conversion to V4L2 API
+ *      - Uses video_ioctl2 for parsing and to add debug support
  */
 
 
@@ -43,10 +45,18 @@
 #include <linux/videodev2.h>
 #include <media/v4l2-common.h>
 
-#define DRIVER_VERSION  "0.76"
+#define DRIVER_VERSION  "0.77"
 
 #include <linux/version.h>      /* for KERNEL_VERSION MACRO     */
-#define RADIO_VERSION KERNEL_VERSION(0,7,6)
+#define RADIO_VERSION KERNEL_VERSION(0,7,7)
+
+static struct video_device maxiradio_radio;
+
+#define dprintk(num, fmt, arg...)                                          \
+        do {                                                               \
+                if (maxiradio_radio.debug >= num)                          \
+                        printk(KERN_DEBUG "%s: " fmt,                      \
+                                maxiradio_radio.name, ## arg); } while (0)
 
 static struct v4l2_queryctrl radio_qctrl[] = {
         {
@@ -81,30 +91,21 @@ module_param(radio_nr, int, 0);
 #define FREQ_IF         171200 /* 10.7*16000   */
 #define FREQ_STEP       200    /* 12.5*16      */
 
-#define FREQ2BITS(x)    ((( (unsigned int)(x)+FREQ_IF+(FREQ_STEP<<1))\
-                        /(FREQ_STEP<<2))<<2) /* (x==fmhz*16*1000) -> bits */
+/* (x==fmhz*16*1000) -> bits */
+#define FREQ2BITS(x)    ((( (unsigned int)(x)+FREQ_IF+(FREQ_STEP<<1)) \
+                        /(FREQ_STEP<<2))<<2)
 
 #define BITS2FREQ(x)    ((x) * FREQ_STEP - FREQ_IF)
 
 
-static int radio_ioctl(struct inode *inode, struct file *file,
-                       unsigned int cmd, unsigned long arg);
-
 static const struct file_operations maxiradio_fops = {
         .owner          = THIS_MODULE,
         .open           = video_exclusive_open,
         .release        = video_exclusive_release,
-        .ioctl          = radio_ioctl,
+        .ioctl          = video_ioctl2,
         .compat_ioctl   = v4l_compat_ioctl32,
         .llseek         = no_llseek,
 };
-static struct video_device maxiradio_radio =
-{
-        .owner          = THIS_MODULE,
-        .name           = "Maxi Radio FM2000 radio",
-        .type           = VID_TYPE_TUNER,
-        .fops           = &maxiradio_fops,
-};
 
 static struct radio_device
 {
@@ -116,12 +117,14 @@ static struct radio_device
         unsigned long freq;
 
         struct mutex lock;
-} radio_unit = {0, 0, 0, 0, };
-
+} radio_unit = {
+        .muted =1,
+        .freq = FREQ_LO,
+};
 
 static void outbit(unsigned long bit, __u16 io)
 {
-        if(bit != 0)
+        if (bit != 0)
                 {
                         outb(  power|wren|data     ,io); udelay(4);
                         outb(  power|wren|data|clk ,io); udelay(4);
@@ -137,14 +140,20 @@ static void outbit(unsigned long bit, __u16 io)
 
 static void turn_power(__u16 io, int p)
 {
-        if(p != 0) outb(power, io); else outb(0,io);
+        if (p != 0) {
+                dprintk(1, "Radio powered on\n");
+                outb(power, io);
+        } else {
+                dprintk(1, "Radio powered off\n");
+                outb(0,io);
+        }
 }
 
-
-static void set_freq(__u16 io, __u32 data)
+static void set_freq(__u16 io, __u32 freq)
 {
         unsigned long int si;
         int bl;
+        int data = FREQ2BITS(freq);
 
         /* TEA5757 shift register bits (see pdf) */
 
@@ -163,161 +172,225 @@ static void set_freq(__u16 io, __u32 data)
         outbit(0,io); // 16  search level
 
         si = 0x8000;
-        for(bl = 1; bl <= 16 ; bl++) { outbit(data & si,io); si >>=1; }
+        for (bl = 1; bl <= 16 ; bl++) {
+                outbit(data & si,io);
+                si >>=1;
+        }
 
-        outb(power,io);
+        dprintk(1, "Radio freq set to %d.%02d MHz\n",
+                                freq / 16000,
+                                freq % 16000 * 100 / 16000);
+
+        turn_power(io, 1);
 }
 
 static int get_stereo(__u16 io)
 {
-        outb(power,io); udelay(4);
+        outb(power,io);
+        udelay(4);
+
         return !(inb(io) & mo_st);
 }
 
 static int get_tune(__u16 io)
 {
-        outb(power+clk,io); udelay(4);
+        outb(power+clk,io);
+        udelay(4);
+
         return !(inb(io) & mo_st);
 }
 
 
-static inline int radio_function(struct inode *inode, struct file *file,
-                                 unsigned int cmd, void *arg)
+static int vidioc_querycap (struct file *file, void  *priv,
+                            struct v4l2_capability *v)
+{
+        strlcpy(v->driver, "radio-maxiradio", sizeof (v->driver));
+        strlcpy(v->card, "Maxi Radio FM2000 radio", sizeof (v->card));
+        sprintf(v->bus_info,"ISA");
+        v->version = RADIO_VERSION;
+        v->capabilities = V4L2_CAP_TUNER;
+
+        return 0;
+}
+
+static int vidioc_g_tuner (struct file *file, void *priv,
+                           struct v4l2_tuner *v)
 {
         struct video_device *dev = video_devdata(file);
         struct radio_device *card=dev->priv;
 
-        switch(cmd) {
-                case VIDIOC_QUERYCAP:
-                {
-                        struct v4l2_capability *v = arg;
-                        memset(v,0,sizeof(*v));
-                        strlcpy(v->driver, "radio-maxiradio", sizeof (v->driver));
-                        strlcpy(v->card, "Maxi Radio FM2000 radio", sizeof (v->card));
-                        sprintf(v->bus_info,"ISA");
-                        v->version = RADIO_VERSION;
-                        v->capabilities = V4L2_CAP_TUNER;
+        if (v->index > 0)
+                return -EINVAL;
 
-                        return 0;
-                }
-                case VIDIOC_G_TUNER:
-                {
-                        struct v4l2_tuner *v = arg;
+        memset(v,0,sizeof(*v));
+        strcpy(v->name, "FM");
+        v->type = V4L2_TUNER_RADIO;
 
-                        if (v->index > 0)
-                                return -EINVAL;
+        v->rangelow=FREQ_LO;
+        v->rangehigh=FREQ_HI;
+        v->rxsubchans =V4L2_TUNER_SUB_MONO|V4L2_TUNER_SUB_STEREO;
+        v->capability=V4L2_TUNER_CAP_LOW;
+        if(get_stereo(card->io))
+                v->audmode = V4L2_TUNER_MODE_STEREO;
+        else
+                v->audmode = V4L2_TUNER_MODE_MONO;
+        v->signal=0xffff*get_tune(card->io);
 
-                        memset(v,0,sizeof(*v));
-                        strcpy(v->name, "FM");
-                        v->type = V4L2_TUNER_RADIO;
+        return 0;
+}
 
-                        v->rangelow=FREQ_LO;
-                        v->rangehigh=FREQ_HI;
-                        v->rxsubchans =V4L2_TUNER_SUB_MONO|V4L2_TUNER_SUB_STEREO;
-                        v->capability=V4L2_TUNER_CAP_LOW;
-                        if(get_stereo(card->io))
-                                v->audmode = V4L2_TUNER_MODE_STEREO;
-                        else
-                                v->audmode = V4L2_TUNER_MODE_MONO;
-                        v->signal=0xffff*get_tune(card->io);
+static int vidioc_s_tuner (struct file *file, void *priv,
+                           struct v4l2_tuner *v)
+{
+        if (v->index > 0)
+                return -EINVAL;
 
-                        return 0;
-                }
-                case VIDIOC_S_TUNER:
-                {
-                        struct v4l2_tuner *v = arg;
+        return 0;
+}
 
-                        if (v->index > 0)
-                                return -EINVAL;
+static int vidioc_g_audio (struct file *file, void *priv,
+                           struct v4l2_audio *a)
+{
+        if (a->index > 1)
+                return -EINVAL;
 
-                        return 0;
-                }
-                case VIDIOC_S_FREQUENCY:
-                {
-                        struct v4l2_frequency *f = arg;
+        strcpy(a->name, "FM");
+        a->capability = V4L2_AUDCAP_STEREO;
+        return 0;
+}
 
-                        if (f->frequency < FREQ_LO || f->frequency > FREQ_HI)
-                                return -EINVAL;
+static int vidioc_g_input(struct file *filp, void *priv, unsigned int *i)
+{
+        *i = 0;
 
-                        card->freq = f->frequency;
-                        set_freq(card->io, FREQ2BITS(card->freq));
-                        msleep(125);
-                        return 0;
-                }
-                case VIDIOC_G_FREQUENCY:
-                {
-                        struct v4l2_frequency *f = arg;
+        return 0;
+}
 
-                        f->type = V4L2_TUNER_RADIO;
-                        f->frequency = card->freq;
+static int vidioc_s_input(struct file *filp, void *priv, unsigned int i)
+{
+        if (i != 0)
+                return -EINVAL;
 
-                        return 0;
-                }
-                case VIDIOC_QUERYCTRL:
-                {
-                        struct v4l2_queryctrl *qc = arg;
-                        int i;
-
-                        for (i = 0; i < ARRAY_SIZE(radio_qctrl); i++) {
-                                if (qc->id && qc->id == radio_qctrl[i].id) {
-                                        memcpy(qc, &(radio_qctrl[i]),
-                                                                sizeof(*qc));
-                                        return (0);
-                                }
-                        }
-                        return -EINVAL;
-                }
-                case VIDIOC_G_CTRL:
-                {
-                        struct v4l2_control *ctrl= arg;
-
-                        switch (ctrl->id) {
-                                case V4L2_CID_AUDIO_MUTE:
-                                        ctrl->value=card->muted;
-                                        return (0);
-                        }
-                        return -EINVAL;
-                }
-                case VIDIOC_S_CTRL:
-                {
-                        struct v4l2_control *ctrl= arg;
-
-                        switch (ctrl->id) {
-                                case V4L2_CID_AUDIO_MUTE:
-                                        card->muted = ctrl->value;
-                                        if(card->muted)
-                                                turn_power(card->io, 0);
-                                        else
-                                                set_freq(card->io, FREQ2BITS(card->freq));
-                                        return 0;
-                        }
-                        return -EINVAL;
-                }
+        return 0;
+}
+
+
+static int vidioc_s_audio (struct file *file, void *priv,
+                           struct v4l2_audio *a)
+{
+        if (a->index != 0)
+                return -EINVAL;
+
+        return 0;
+}
+
+static int vidioc_s_frequency (struct file *file, void *priv,
+                               struct v4l2_frequency *f)
+{
+        struct video_device *dev = video_devdata(file);
+        struct radio_device *card=dev->priv;
 
-                default:
-                        return v4l_compat_translate_ioctl(inode,file,cmd,arg,
-                                                          radio_function);
+        if (f->frequency < FREQ_LO || f->frequency > FREQ_HI) {
+                dprintk(1, "radio freq (%d.%02d MHz) out of range (%d-%d)\n",
+                                        f->frequency / 16000,
+                                        f->frequency % 16000 * 100 / 16000,
+                                        FREQ_LO / 16000, FREQ_HI / 16000);
 
+                return -EINVAL;
         }
+
+        card->freq = f->frequency;
+        set_freq(card->io, card->freq);
+        msleep(125);
+
+        return 0;
 }
 
-static int radio_ioctl(struct inode *inode, struct file *file,
-                       unsigned int cmd, unsigned long arg)
+static int vidioc_g_frequency (struct file *file, void *priv,
+                               struct v4l2_frequency *f)
 {
         struct video_device *dev = video_devdata(file);
         struct radio_device *card=dev->priv;
-        int ret;
 
-        mutex_lock(&card->lock);
-        ret = video_usercopy(inode, file, cmd, arg, radio_function);
-        mutex_unlock(&card->lock);
-        return ret;
+        f->type = V4L2_TUNER_RADIO;
+        f->frequency = card->freq;
+
+        dprintk(4, "radio freq is %d.%02d MHz",
+                                f->frequency / 16000,
+                                f->frequency % 16000 * 100 / 16000);
+
+        return 0;
 }
 
-MODULE_AUTHOR("Dimitromanolakis Apostolos, apdim@grecian.net");
-MODULE_DESCRIPTION("Radio driver for the Guillemot Maxi Radio FM2000 radio.");
-MODULE_LICENSE("GPL");
+static int vidioc_queryctrl (struct file *file, void *priv,
+                             struct v4l2_queryctrl *qc)
+{
+        int i;
 
+        for (i = 0; i < ARRAY_SIZE(radio_qctrl); i++) {
+                if (qc->id && qc->id == radio_qctrl[i].id) {
+                        memcpy(qc, &(radio_qctrl[i]), sizeof(*qc));
+                        return (0);
+                }
+        }
+
+        return -EINVAL;
+}
+
+static int vidioc_g_ctrl (struct file *file, void *priv,
+                            struct v4l2_control *ctrl)
+{
+        struct video_device *dev = video_devdata(file);
+        struct radio_device *card=dev->priv;
+
+        switch (ctrl->id) {
+                case V4L2_CID_AUDIO_MUTE:
+                        ctrl->value=card->muted;
+                        return (0);
+        }
+
+        return -EINVAL;
+}
+
+static int vidioc_s_ctrl (struct file *file, void *priv,
+                          struct v4l2_control *ctrl)
+{
+        struct video_device *dev = video_devdata(file);
+        struct radio_device *card=dev->priv;
+
+        switch (ctrl->id) {
+                case V4L2_CID_AUDIO_MUTE:
+                        card->muted = ctrl->value;
+                        if(card->muted)
+                                turn_power(card->io, 0);
+                        else
+                                set_freq(card->io, card->freq);
+                        return 0;
+        }
+
+        return -EINVAL;
+}
+
+static struct video_device maxiradio_radio =
+{
+        .owner              = THIS_MODULE,
+        .name               = "Maxi Radio FM2000 radio",
+        .type               = VID_TYPE_TUNER,
+        .fops               = &maxiradio_fops,
+
+        .vidioc_querycap    = vidioc_querycap,
+        .vidioc_g_tuner     = vidioc_g_tuner,
+        .vidioc_s_tuner     = vidioc_s_tuner,
+        .vidioc_g_audio     = vidioc_g_audio,
+        .vidioc_s_audio     = vidioc_s_audio,
+        .vidioc_g_input     = vidioc_g_input,
+        .vidioc_s_input     = vidioc_s_input,
+        .vidioc_g_frequency = vidioc_g_frequency,
+        .vidioc_s_frequency = vidioc_s_frequency,
+        .vidioc_queryctrl   = vidioc_queryctrl,
+        .vidioc_g_ctrl      = vidioc_g_ctrl,
+        .vidioc_s_ctrl      = vidioc_s_ctrl,
+};
 
 static int __devinit maxiradio_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
 {
@@ -334,7 +407,7 @@ static int __devinit maxiradio_init_one(struct pci_dev *pdev, const struct pci_d
         mutex_init(&radio_unit.lock);
         maxiradio_radio.priv = &radio_unit;
 
-        if(video_register_device(&maxiradio_radio, VFL_TYPE_RADIO, radio_nr)==-1) {
+        if (video_register_device(&maxiradio_radio, VFL_TYPE_RADIO, radio_nr)==-1) {
                 printk("radio-maxiradio: can't register device!");
                 goto err_out_free_region;
         }
@@ -389,3 +462,10 @@ static void __exit maxiradio_radio_exit(void)
 
 module_init(maxiradio_radio_init);
 module_exit(maxiradio_radio_exit);
+
+MODULE_AUTHOR("Dimitromanolakis Apostolos, apdim@grecian.net");
+MODULE_DESCRIPTION("Radio driver for the Guillemot Maxi Radio FM2000 radio.");
+MODULE_LICENSE("GPL");
+
+module_param_named(debug,maxiradio_radio.debug, int, 0644);
+MODULE_PARM_DESC(debug,"activates debug info");