1 files changed, 20 insertions, 15 deletions

diff --git a/drivers/md/dm-raid1.c b/drivers/md/dm-raid1.c
index d09ff15490a5..31123d4a6b9c 100644
--- a/drivers/md/dm-raid1.c
+++ b/drivers/md/dm-raid1.c
@@ -19,6 +19,7 @@
 #include <linux/time.h>
 #include <linux/vmalloc.h>
 #include <linux/workqueue.h>
+#include <linux/log2.h>
 
 #define DM_MSG_PREFIX "raid1"
 #define DM_IO_PAGES 64
@@ -113,6 +114,7 @@ struct region {
  * Mirror set structures.
  *---------------------------------------------------------------*/
 struct mirror {
+        struct mirror_set *ms;
         atomic_t error_count;
         struct dm_dev *dev;
         sector_t offset;
@@ -974,6 +976,7 @@ static struct mirror_set *alloc_context(unsigned int nr_mirrors,
 
         if (rh_init(&ms->rh, ms, dl, region_size, ms->nr_regions)) {
                 ti->error = "Error creating dirty region hash";
+                dm_io_client_destroy(ms->io_client);
                 kfree(ms);
                 return NULL;
         }
@@ -994,7 +997,7 @@ static void free_context(struct mirror_set *ms, struct dm_target *ti,
 
 static inline int _check_region_size(struct dm_target *ti, uint32_t size)
 {
-        return !(size % (PAGE_SIZE >> 9) || (size & (size - 1)) ||
+        return !(size % (PAGE_SIZE >> 9) || !is_power_of_2(size) ||
                  size > ti->len);
 }
 
@@ -1015,6 +1018,7 @@ static int get_mirror(struct mirror_set *ms, struct dm_target *ti,
                 return -ENXIO;
         }
 
+        ms->mirror[mirror].ms = ms;
         ms->mirror[mirror].offset = offset;
 
         return 0;
@@ -1163,16 +1167,14 @@ static int mirror_ctr(struct dm_target *ti, unsigned int argc, char **argv)
         ms->kmirrord_wq = create_singlethread_workqueue("kmirrord");
         if (!ms->kmirrord_wq) {
                 DMERR("couldn't start kmirrord");
-                free_context(ms, ti, m);
-                return -ENOMEM;
+                r = -ENOMEM;
+                goto err_free_context;
         }
         INIT_WORK(&ms->kmirrord_work, do_mirror);
 
         r = parse_features(ms, argc, argv, &args_used);
-        if (r) {
-                free_context(ms, ti, ms->nr_mirrors);
-                return r;
-        }
+        if (r)
+                goto err_destroy_wq;
 
         argv += args_used;
         argc -= args_used;
@@ -1188,19 +1190,22 @@ static int mirror_ctr(struct dm_target *ti, unsigned int argc, char **argv)
 
         if (argc) {
                 ti->error = "Too many mirror arguments";
-                free_context(ms, ti, ms->nr_mirrors);
-                return -EINVAL;
+                r = -EINVAL;
+                goto err_destroy_wq;
         }
 
         r = kcopyd_client_create(DM_IO_PAGES, &ms->kcopyd_client);
-        if (r) {
-                destroy_workqueue(ms->kmirrord_wq);
-                free_context(ms, ti, ms->nr_mirrors);
-                return r;
-        }
+        if (r)
+                goto err_destroy_wq;
 
         wake(ms);
         return 0;
+
+err_destroy_wq:
+        destroy_workqueue(ms->kmirrord_wq);
+err_free_context:
+        free_context(ms, ti, ms->nr_mirrors);
+        return r;
 }
 
 static void mirror_dtr(struct dm_target *ti)
@@ -1302,7 +1307,7 @@ static void mirror_postsuspend(struct dm_target *ti)
         wait_event(_kmirrord_recovery_stopped,
                    !atomic_read(&ms->rh.recovery_in_flight));
 
-        if (log->type->suspend && log->type->suspend(log))
+        if (log->type->postsuspend && log->type->postsuspend(log))
                 /* FIXME: need better error handling */
                 DMWARN("log suspend failed");
 }