diff options
Diffstat (limited to 'drivers/md/dm-cache-target.c')
-rw-r--r-- | drivers/md/dm-cache-target.c | 37 |
1 files changed, 3 insertions, 34 deletions
diff --git a/drivers/md/dm-cache-target.c b/drivers/md/dm-cache-target.c index 074b9c8e4cf0..bccb7ae34e61 100644 --- a/drivers/md/dm-cache-target.c +++ b/drivers/md/dm-cache-target.c | |||
@@ -239,7 +239,7 @@ struct cache { | |||
239 | */ | 239 | */ |
240 | dm_dblock_t discard_nr_blocks; | 240 | dm_dblock_t discard_nr_blocks; |
241 | unsigned long *discard_bitset; | 241 | unsigned long *discard_bitset; |
242 | uint32_t discard_block_size; /* a power of 2 times sectors per block */ | 242 | uint32_t discard_block_size; |
243 | 243 | ||
244 | /* | 244 | /* |
245 | * Rather than reconstructing the table line for the status we just | 245 | * Rather than reconstructing the table line for the status we just |
@@ -2171,35 +2171,6 @@ static int create_cache_policy(struct cache *cache, struct cache_args *ca, | |||
2171 | return 0; | 2171 | return 0; |
2172 | } | 2172 | } |
2173 | 2173 | ||
2174 | /* | ||
2175 | * We want the discard block size to be a power of two, at least the size | ||
2176 | * of the cache block size, and have no more than 2^14 discard blocks | ||
2177 | * across the origin. | ||
2178 | */ | ||
2179 | #define MAX_DISCARD_BLOCKS (1 << 14) | ||
2180 | |||
2181 | static bool too_many_discard_blocks(sector_t discard_block_size, | ||
2182 | sector_t origin_size) | ||
2183 | { | ||
2184 | (void) sector_div(origin_size, discard_block_size); | ||
2185 | |||
2186 | return origin_size > MAX_DISCARD_BLOCKS; | ||
2187 | } | ||
2188 | |||
2189 | static sector_t calculate_discard_block_size(sector_t cache_block_size, | ||
2190 | sector_t origin_size) | ||
2191 | { | ||
2192 | sector_t discard_block_size; | ||
2193 | |||
2194 | discard_block_size = roundup_pow_of_two(cache_block_size); | ||
2195 | |||
2196 | if (origin_size) | ||
2197 | while (too_many_discard_blocks(discard_block_size, origin_size)) | ||
2198 | discard_block_size *= 2; | ||
2199 | |||
2200 | return discard_block_size; | ||
2201 | } | ||
2202 | |||
2203 | #define DEFAULT_MIGRATION_THRESHOLD 2048 | 2174 | #define DEFAULT_MIGRATION_THRESHOLD 2048 |
2204 | 2175 | ||
2205 | static int cache_create(struct cache_args *ca, struct cache **result) | 2176 | static int cache_create(struct cache_args *ca, struct cache **result) |
@@ -2321,9 +2292,7 @@ static int cache_create(struct cache_args *ca, struct cache **result) | |||
2321 | } | 2292 | } |
2322 | clear_bitset(cache->dirty_bitset, from_cblock(cache->cache_size)); | 2293 | clear_bitset(cache->dirty_bitset, from_cblock(cache->cache_size)); |
2323 | 2294 | ||
2324 | cache->discard_block_size = | 2295 | cache->discard_block_size = cache->sectors_per_block; |
2325 | calculate_discard_block_size(cache->sectors_per_block, | ||
2326 | cache->origin_sectors); | ||
2327 | cache->discard_nr_blocks = oblock_to_dblock(cache, cache->origin_blocks); | 2296 | cache->discard_nr_blocks = oblock_to_dblock(cache, cache->origin_blocks); |
2328 | cache->discard_bitset = alloc_bitset(from_dblock(cache->discard_nr_blocks)); | 2297 | cache->discard_bitset = alloc_bitset(from_dblock(cache->discard_nr_blocks)); |
2329 | if (!cache->discard_bitset) { | 2298 | if (!cache->discard_bitset) { |
@@ -3120,7 +3089,7 @@ static void set_discard_limits(struct cache *cache, struct queue_limits *limits) | |||
3120 | /* | 3089 | /* |
3121 | * FIXME: these limits may be incompatible with the cache device | 3090 | * FIXME: these limits may be incompatible with the cache device |
3122 | */ | 3091 | */ |
3123 | limits->max_discard_sectors = cache->discard_block_size * 1024; | 3092 | limits->max_discard_sectors = cache->discard_block_size; |
3124 | limits->discard_granularity = cache->discard_block_size << SECTOR_SHIFT; | 3093 | limits->discard_granularity = cache->discard_block_size << SECTOR_SHIFT; |
3125 | } | 3094 | } |
3126 | 3095 | ||