7 files changed, 27 insertions, 18 deletions

diff --git a/drivers/macintosh/adb-iop.c b/drivers/macintosh/adb-iop.c
index 17ef5d3c01b4..444696625171 100644
--- a/drivers/macintosh/adb-iop.c
+++ b/drivers/macintosh/adb-iop.c
@@ -19,7 +19,6 @@
 #include <linux/init.h>
 #include <linux/proc_fs.h>
 
-#include <asm/bootinfo.h> 
 #include <asm/macintosh.h> 
 #include <asm/macints.h> 
 #include <asm/mac_iop.h>
diff --git a/drivers/macintosh/adbhid.c b/drivers/macintosh/adbhid.c
index b46817f699f1..48d17bf6c927 100644
--- a/drivers/macintosh/adbhid.c
+++ b/drivers/macintosh/adbhid.c
@@ -70,7 +70,7 @@ static struct notifier_block adbhid_adb_notifier = {
 #define ADB_KEY_POWER_OLD       0x7e
 #define ADB_KEY_POWER           0x7f
 
-u8 adb_to_linux_keycodes[128] = {
+u16 adb_to_linux_keycodes[128] = {
         /* 0x00 */ KEY_A,               /*  30 */
         /* 0x01 */ KEY_S,               /*  31 */
         /* 0x02 */ KEY_D,               /*  32 */
@@ -134,7 +134,7 @@ u8 adb_to_linux_keycodes[128] = {
         /* 0x3c */ KEY_RIGHT,           /* 106 */
         /* 0x3d */ KEY_DOWN,            /* 108 */
         /* 0x3e */ KEY_UP,              /* 103 */
-        /* 0x3f */ 0,
+        /* 0x3f */ KEY_FN,              /* 0x1d0 */
         /* 0x40 */ 0,
         /* 0x41 */ KEY_KPDOT,           /*  83 */
         /* 0x42 */ 0,
@@ -208,7 +208,7 @@ struct adbhid {
         int original_handler_id;
         int current_handler_id;
         int mouse_kind;
-        unsigned char *keycode;
+        u16 *keycode;
         char name[64];
         char phys[32];
         int flags;
@@ -275,7 +275,7 @@ static void
 adbhid_input_keycode(int id, int keycode, int repeat)
 {
         struct adbhid *ahid = adbhid[id];
-        int up_flag;
+        int up_flag, key;
 
         up_flag = (keycode & 0x80);
         keycode &= 0x7f;
@@ -321,8 +321,7 @@ adbhid_input_keycode(int id, int keycode, int repeat)
                         }
                 } else
                         ahid->flags |= FLAG_FN_KEY_PRESSED;
-                /* Swallow the key press */
-                return;
+                break;
         case ADB_KEY_DEL:
                 /* Emulate Fn+delete = forward delete */
                 if (ahid->flags & FLAG_FN_KEY_PRESSED) {
@@ -336,9 +335,9 @@ adbhid_input_keycode(int id, int keycode, int repeat)
 #endif /* CONFIG_PPC_PMAC */
         }
 
-        if (adbhid[id]->keycode[keycode]) {
-                input_report_key(adbhid[id]->input,
-                                 adbhid[id]->keycode[keycode], !up_flag);
+        key = adbhid[id]->keycode[keycode];
+        if (key) {
+                input_report_key(adbhid[id]->input, key, !up_flag);
                 input_sync(adbhid[id]->input);
         } else
                 printk(KERN_INFO "Unhandled ADB key (scancode %#02x) %s.\n", keycode,
@@ -757,8 +756,8 @@ adbhid_input_register(int id, int default_id, int original_handler_id,
                 input_dev->evbit[0] = BIT(EV_KEY) | BIT(EV_LED) | BIT(EV_REP);
                 input_dev->ledbit[0] = BIT(LED_SCROLLL) | BIT(LED_CAPSL) | BIT(LED_NUML);
                 input_dev->event = adbhid_kbd_event;
-                input_dev->keycodemax = 127;
-                input_dev->keycodesize = 1;
+                input_dev->keycodemax = KEY_FN;
+                input_dev->keycodesize = sizeof(hid->keycode[0]);
                 break;
 
         case ADB_MOUSE:
diff --git a/drivers/macintosh/ans-lcd.c b/drivers/macintosh/ans-lcd.c
index e54c4d9f6365..73c50bc02095 100644
--- a/drivers/macintosh/ans-lcd.c
+++ b/drivers/macintosh/ans-lcd.c
@@ -14,9 +14,10 @@
 #include <asm/uaccess.h>
 #include <asm/sections.h>
 #include <asm/prom.h>
-#include <asm/ans-lcd.h>
 #include <asm/io.h>
 
+#include "ans-lcd.h"
+
 #define ANSLCD_ADDR             0xf301c000
 #define ANSLCD_CTRL_IX 0x00
 #define ANSLCD_DATA_IX 0x10
diff --git a/drivers/macintosh/ans-lcd.h b/drivers/macintosh/ans-lcd.h
new file mode 100644
index 000000000000..d795b9fd2db6
--- /dev/null
+++ b/drivers/macintosh/ans-lcd.h
@@ -0,0 +1,11 @@
+#ifndef _PPC_ANS_LCD_H
+#define _PPC_ANS_LCD_H
+
+#define ANSLCD_MINOR            156
+
+#define ANSLCD_CLEAR            0x01
+#define ANSLCD_SENDCTRL         0x02
+#define ANSLCD_SETSHORTDELAY    0x03
+#define ANSLCD_SETLONGDELAY     0x04
+
+#endif
diff --git a/drivers/macintosh/therm_adt746x.c b/drivers/macintosh/therm_adt746x.c
index f25685b9b7cf..276945d51513 100644
--- a/drivers/macintosh/therm_adt746x.c
+++ b/drivers/macintosh/therm_adt746x.c
@@ -379,13 +379,10 @@ static int attach_one_thermostat(struct i2c_adapter *adapter, int addr,
         if (thermostat)
                 return 0;
 
-        th = (struct thermostat *)
-                kmalloc(sizeof(struct thermostat), GFP_KERNEL);
-
+        th = kzalloc(sizeof(struct thermostat), GFP_KERNEL);
         if (!th)
                 return -ENOMEM;
 
-        memset(th, 0, sizeof(*th));
         th->clt.addr = addr;
         th->clt.adapter = adapter;
         th->clt.driver = &thermostat_driver;
diff --git a/drivers/macintosh/via-pmu.c b/drivers/macintosh/via-pmu.c
index 04f3973e3874..f7c509b7a8ea 100644
--- a/drivers/macintosh/via-pmu.c
+++ b/drivers/macintosh/via-pmu.c
@@ -410,7 +410,7 @@ static int __init via_pmu_start(void)
 
         irq = irq_of_parse_and_map(vias, 0);
         if (irq == NO_IRQ) {
-                printk(KERN_ERR "via-pmu: can't map interruptn");
+                printk(KERN_ERR "via-pmu: can't map interrupt\n");
                 return -ENODEV;
         }
         if (request_irq(irq, via_pmu_interrupt, 0, "VIA-PMU", (void *)0)) {
diff --git a/drivers/macintosh/windfarm_smu_sat.c b/drivers/macintosh/windfarm_smu_sat.c
index 351982bcec1b..f449d775cdf4 100644
--- a/drivers/macintosh/windfarm_smu_sat.c
+++ b/drivers/macintosh/windfarm_smu_sat.c
@@ -380,10 +380,12 @@ static int __init sat_sensors_init(void)
         return i2c_add_driver(&wf_sat_driver);
 }
 
+#if 0   /* uncomment when module_exit() below is uncommented */
 static void __exit sat_sensors_exit(void)
 {
         i2c_del_driver(&wf_sat_driver);
 }
+#endif
 
 module_init(sat_sensors_init);
 /*module_exit(sat_sensors_exit); Uncomment when cleanup is implemented */