148 files changed, 8266 insertions, 2947 deletions

diff --git a/drivers/input/Kconfig b/drivers/input/Kconfig
index cd50c00ab20f..07c2cd43109c 100644
--- a/drivers/input/Kconfig
+++ b/drivers/input/Kconfig
@@ -8,7 +8,7 @@ menu "Input device support"
 config INPUT
         tristate "Generic input layer (needed for keyboard, mouse, ...)" if EMBEDDED
         default y
-        ---help---
+        help
           Say Y here if you have any input device (mouse, keyboard, tablet,
           joystick, steering wheel ...) connected to your system and want
           it to be available to applications. This includes standard PS/2
@@ -27,8 +27,7 @@ if INPUT
 
 config INPUT_FF_MEMLESS
         tristate "Support for memoryless force-feedback devices"
-        default n
-        ---help---
+        help
           Say Y here if you have memoryless force-feedback input device
           such as Logitech WingMan Force 3D, ThrustMaster FireStorm Dual
           Power 2, or similar. You will also need to enable hardware-specific
@@ -52,12 +51,25 @@ config INPUT_POLLDEV
           To compile this driver as a module, choose M here: the
           module will be called input-polldev.
 
+config INPUT_SPARSEKMAP
+        tristate "Sparse keymap support library"
+        help
+          Say Y here if you are using a driver for an input
+          device that uses sparse keymap. This option is only
+          useful for out-of-tree drivers since in-tree drivers
+          select it automatically.
+
+          If unsure, say N.
+
+          To compile this driver as a module, choose M here: the
+          module will be called sparse-keymap.
+
 comment "Userland interfaces"
 
 config INPUT_MOUSEDEV
         tristate "Mouse interface" if EMBEDDED
         default y
-        ---help---
+        help
           Say Y here if you want your mouse to be accessible as char devices
           13:32+ - /dev/input/mouseX and 13:63 - /dev/input/mice as an
           emulated IntelliMouse Explorer PS/2 mouse. That way, all user space
@@ -73,7 +85,7 @@ config INPUT_MOUSEDEV_PSAUX
         bool "Provide legacy /dev/psaux device"
         default y
         depends on INPUT_MOUSEDEV
-        ---help---
+        help
           Say Y here if you want your mouse also be accessible as char device
           10:1 - /dev/psaux. The data available through /dev/psaux is exactly
           the same as the data from /dev/input/mice.
@@ -103,7 +115,7 @@ config INPUT_MOUSEDEV_SCREEN_Y
 
 config INPUT_JOYDEV
         tristate "Joystick interface"
-        ---help---
+        help
           Say Y here if you want your joystick or gamepad to be
           accessible as char device 13:0+ - /dev/input/jsX device.
 
@@ -125,7 +137,7 @@ config INPUT_EVDEV
 
 config INPUT_EVBUG
         tristate "Event debugging"
-        ---help---
+        help
           Say Y here if you have a problem with the input subsystem and
           want all events (keypresses, mouse movements), to be output to
           the system log. While this is useful for debugging, it's also
@@ -140,7 +152,7 @@ config INPUT_EVBUG
 config INPUT_APMPOWER
         tristate "Input Power Event -> APM Bridge" if EMBEDDED
         depends on INPUT && APM_EMULATION
-        ---help---
+        help
           Say Y here if you want suspend key events to trigger a user
           requested suspend through APM. This is useful on embedded
           systems where such behaviour is desired without userspace
@@ -153,6 +165,7 @@ config XEN_KBDDEV_FRONTEND
         tristate "Xen virtual keyboard and mouse support"
         depends on XEN_FBDEV_FRONTEND
         default y
+        select XEN_XENBUS_FRONTEND
         help
           This driver implements the front-end of the Xen virtual
           keyboard and mouse device driver.  It communicates with a back-end
diff --git a/drivers/input/Makefile b/drivers/input/Makefile
index 4c9c745a7020..7ad212d31f99 100644
--- a/drivers/input/Makefile
+++ b/drivers/input/Makefile
@@ -9,6 +9,7 @@ input-core-objs := input.o input-compat.o ff-core.o
 
 obj-$(CONFIG_INPUT_FF_MEMLESS)  += ff-memless.o
 obj-$(CONFIG_INPUT_POLLDEV)     += input-polldev.o
+obj-$(CONFIG_INPUT_SPARSEKMAP)  += sparse-keymap.o
 
 obj-$(CONFIG_INPUT_MOUSEDEV)    += mousedev.o
 obj-$(CONFIG_INPUT_JOYDEV)      += joydev.o
diff --git a/drivers/input/evdev.c b/drivers/input/evdev.c
index dee6706038aa..2ee6c7a68bdc 100644
--- a/drivers/input/evdev.c
+++ b/drivers/input/evdev.c
@@ -59,7 +59,8 @@ static void evdev_pass_event(struct evdev_client *client,
         client->head &= EVDEV_BUFFER_SIZE - 1;
         spin_unlock(&client->buffer_lock);
 
-        kill_fasync(&client->fasync, SIGIO, POLL_IN);
+        if (event->type == EV_SYN)
+                kill_fasync(&client->fasync, SIGIO, POLL_IN);
 }
 
 /*
@@ -277,6 +278,8 @@ static int evdev_open(struct inode *inode, struct file *file)
                 goto err_free_client;
 
         file->private_data = client;
+        nonseekable_open(inode, file);
+
         return 0;
 
  err_free_client:
@@ -512,7 +515,7 @@ static long evdev_do_ioctl(struct file *file, unsigned int cmd,
         struct input_absinfo abs;
         struct ff_effect effect;
         int __user *ip = (int __user *)p;
-        int i, t, u, v;
+        unsigned int i, t, u, v;
         int error;
 
         switch (cmd) {
diff --git a/drivers/input/ff-core.c b/drivers/input/ff-core.c
index 38df81fcdc3a..03078c08309a 100644
--- a/drivers/input/ff-core.c
+++ b/drivers/input/ff-core.c
@@ -29,6 +29,7 @@
 #include <linux/module.h>
 #include <linux/mutex.h>
 #include <linux/sched.h>
+#include <linux/slab.h>
 
 /*
  * Check that the effect_id is a valid effect and whether the user
@@ -353,7 +354,7 @@ int input_ff_create(struct input_dev *dev, int max_effects)
 EXPORT_SYMBOL_GPL(input_ff_create);
 
 /**
- * input_ff_free() - frees force feedback portion of input device
+ * input_ff_destroy() - frees force feedback portion of input device
  * @dev: input device supporting force feedback
  *
  * This function is only needed in error path as input core will
@@ -369,6 +370,7 @@ void input_ff_destroy(struct input_dev *dev)
                 if (ff->destroy)
                         ff->destroy(ff);
                 kfree(ff->private);
+                kfree(ff->effects);
                 kfree(ff);
                 dev->ff = NULL;
         }
diff --git a/drivers/input/ff-memless.c b/drivers/input/ff-memless.c
index b483b2995fa9..1d881c96ba8f 100644
--- a/drivers/input/ff-memless.c
+++ b/drivers/input/ff-memless.c
@@ -25,6 +25,7 @@
 
 #define debug(format, arg...) pr_debug("ff-memless: " format "\n", ## arg)
 
+#include <linux/slab.h>
 #include <linux/input.h>
 #include <linux/module.h>
 #include <linux/mutex.h>
@@ -221,11 +222,27 @@ static int get_compatible_type(struct ff_device *ff, int effect_type)
 }
 
 /*
+ * Only left/right direction should be used (under/over 0x8000) for
+ * forward/reverse motor direction (to keep calculation fast & simple).
+ */
+static u16 ml_calculate_direction(u16 direction, u16 force,
+                                  u16 new_direction, u16 new_force)
+{
+        if (!force)
+                return new_direction;
+        if (!new_force)
+                return direction;
+        return (((u32)(direction >> 1) * force +
+                 (new_direction >> 1) * new_force) /
+                (force + new_force)) << 1;
+}
+
+/*
  * Combine two effects and apply gain.
  */
 static void ml_combine_effects(struct ff_effect *effect,
                                struct ml_effect_state *state,
-                               unsigned int gain)
+                               int gain)
 {
         struct ff_effect *new = state->effect;
         unsigned int strong, weak, i;
@@ -252,8 +269,21 @@ static void ml_combine_effects(struct ff_effect *effect,
                 break;
 
         case FF_RUMBLE:
-                strong = new->u.rumble.strong_magnitude * gain / 0xffff;
-                weak = new->u.rumble.weak_magnitude * gain / 0xffff;
+                strong = (u32)new->u.rumble.strong_magnitude * gain / 0xffff;
+                weak = (u32)new->u.rumble.weak_magnitude * gain / 0xffff;
+
+                if (effect->u.rumble.strong_magnitude + strong)
+                        effect->direction = ml_calculate_direction(
+                                effect->direction,
+                                effect->u.rumble.strong_magnitude,
+                                new->direction, strong);
+                else if (effect->u.rumble.weak_magnitude + weak)
+                        effect->direction = ml_calculate_direction(
+                                effect->direction,
+                                effect->u.rumble.weak_magnitude,
+                                new->direction, weak);
+                else
+                        effect->direction = 0;
                 effect->u.rumble.strong_magnitude =
                         min(strong + effect->u.rumble.strong_magnitude,
                             0xffffU);
@@ -268,6 +298,13 @@ static void ml_combine_effects(struct ff_effect *effect,
                 /* here we also scale it 0x7fff => 0xffff */
                 i = i * gain / 0x7fff;
 
+                if (effect->u.rumble.strong_magnitude + i)
+                        effect->direction = ml_calculate_direction(
+                                effect->direction,
+                                effect->u.rumble.strong_magnitude,
+                                new->direction, i);
+                else
+                        effect->direction = 0;
                 effect->u.rumble.strong_magnitude =
                         min(i + effect->u.rumble.strong_magnitude, 0xffffU);
                 effect->u.rumble.weak_magnitude =
@@ -411,8 +448,6 @@ static int ml_ff_playback(struct input_dev *dev, int effect_id, int value)
                                  msecs_to_jiffies(state->effect->replay.length);
                 state->adj_at = state->play_at;
 
-                ml_schedule_timer(ml);
-
         } else {
                 debug("initiated stop");
 
@@ -420,10 +455,10 @@ static int ml_ff_playback(struct input_dev *dev, int effect_id, int value)
                         __set_bit(FF_EFFECT_ABORTING, &state->flags);
                 else
                         __clear_bit(FF_EFFECT_STARTED, &state->flags);
-
-                ml_play_effects(ml);
         }
 
+        ml_play_effects(ml);
+
         return 0;
 }
 
diff --git a/drivers/input/gameport/emu10k1-gp.c b/drivers/input/gameport/emu10k1-gp.c
index b04930f7ea7d..7392992da424 100644
--- a/drivers/input/gameport/emu10k1-gp.c
+++ b/drivers/input/gameport/emu10k1-gp.c
@@ -46,7 +46,7 @@ struct emu {
         int size;
 };
 
-static struct pci_device_id emu_tbl[] = {
+static const struct pci_device_id emu_tbl[] = {
 
         { 0x1102, 0x7002, PCI_ANY_ID, PCI_ANY_ID }, /* SB Live gameport */
         { 0x1102, 0x7003, PCI_ANY_ID, PCI_ANY_ID }, /* Audigy gameport */
diff --git a/drivers/input/gameport/fm801-gp.c b/drivers/input/gameport/fm801-gp.c
index 8a1810f88b9e..14d3f3e208a2 100644
--- a/drivers/input/gameport/fm801-gp.c
+++ b/drivers/input/gameport/fm801-gp.c
@@ -140,7 +140,7 @@ static void __devexit fm801_gp_remove(struct pci_dev *pci)
         }
 }
 
-static struct pci_device_id fm801_gp_id_table[] = {
+static const struct pci_device_id fm801_gp_id_table[] = {
         { PCI_VENDOR_ID_FORTEMEDIA, PCI_DEVICE_ID_FM801_GP, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0  },
         { 0 }
 };
diff --git a/drivers/input/gameport/gameport.c b/drivers/input/gameport/gameport.c
index ac11be08585e..7e18bcf05a66 100644
--- a/drivers/input/gameport/gameport.c
+++ b/drivers/input/gameport/gameport.c
@@ -11,6 +11,8 @@
  * the Free Software Foundation.
  */
 
+#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
+
 #include <linux/stddef.h>
 #include <linux/module.h>
 #include <linux/ioport.h>
@@ -190,9 +192,8 @@ static int gameport_bind_driver(struct gameport *gameport, struct gameport_drive
 
         error = device_bind_driver(&gameport->dev);
         if (error) {
-                printk(KERN_WARNING
-                        "gameport: device_bind_driver() failed "
-                        "for %s (%s) and %s, error: %d\n",
+                dev_warn(&gameport->dev,
+                         "device_bind_driver() failed for %s (%s) and %s, error: %d\n",
                         gameport->phys, gameport->name,
                         drv->description, error);
                 drv->disconnect(gameport);
@@ -209,9 +210,9 @@ static void gameport_find_driver(struct gameport *gameport)
 
         error = device_attach(&gameport->dev);
         if (error < 0)
-                printk(KERN_WARNING
-                        "gameport: device_attach() failed for %s (%s), error: %d\n",
-                        gameport->phys, gameport->name, error);
+                dev_warn(&gameport->dev,
+                         "device_attach() failed for %s (%s), error: %d\n",
+                         gameport->phys, gameport->name, error);
 }
 
 
@@ -262,17 +263,14 @@ static int gameport_queue_event(void *object, struct module *owner,
 
         event = kmalloc(sizeof(struct gameport_event), GFP_ATOMIC);
         if (!event) {
-                printk(KERN_ERR
-                        "gameport: Not enough memory to queue event %d\n",
-                        event_type);
+                pr_err("Not enough memory to queue event %d\n", event_type);
                 retval = -ENOMEM;
                 goto out;
         }
 
         if (!try_module_get(owner)) {
-                printk(KERN_WARNING
-                        "gameport: Can't get module reference, dropping event %d\n",
-                        event_type);
+                pr_warning("Can't get module reference, dropping event %d\n",
+                           event_type);
                 kfree(event);
                 retval = -EINVAL;
                 goto out;
@@ -298,14 +296,12 @@ static void gameport_free_event(struct gameport_event *event)
 
 static void gameport_remove_duplicate_events(struct gameport_event *event)
 {
-        struct list_head *node, *next;
-        struct gameport_event *e;
+        struct gameport_event *e, *next;
         unsigned long flags;
 
         spin_lock_irqsave(&gameport_event_lock, flags);
 
-        list_for_each_safe(node, next, &gameport_event_list) {
-                e = list_entry(node, struct gameport_event, node);
+        list_for_each_entry_safe(e, next, &gameport_event_list, node) {
                 if (event->object == e->object) {
                         /*
                          * If this event is of different type we should not
@@ -315,7 +311,7 @@ static void gameport_remove_duplicate_events(struct gameport_event *event)
                         if (event->type != e->type)
                                 break;
 
-                        list_del_init(node);
+                        list_del_init(&e->node);
                         gameport_free_event(e);
                 }
         }
@@ -325,23 +321,18 @@ static void gameport_remove_duplicate_events(struct gameport_event *event)
 
 static struct gameport_event *gameport_get_event(void)
 {
-        struct gameport_event *event;
-        struct list_head *node;
+        struct gameport_event *event = NULL;
         unsigned long flags;
 
         spin_lock_irqsave(&gameport_event_lock, flags);
 
-        if (list_empty(&gameport_event_list)) {
-                spin_unlock_irqrestore(&gameport_event_lock, flags);
-                return NULL;
+        if (!list_empty(&gameport_event_list)) {
+                event = list_first_entry(&gameport_event_list,
+                                         struct gameport_event, node);
+                list_del_init(&event->node);
         }
 
-        node = gameport_event_list.next;
-        event = list_entry(node, struct gameport_event, node);
-        list_del_init(node);
-
         spin_unlock_irqrestore(&gameport_event_lock, flags);
-
         return event;
 }
 
@@ -360,16 +351,14 @@ static void gameport_handle_event(void)
         if ((event = gameport_get_event())) {
 
                 switch (event->type) {
-                        case GAMEPORT_REGISTER_PORT:
-                                gameport_add_port(event->object);
-                                break;
 
-                        case GAMEPORT_ATTACH_DRIVER:
-                                gameport_attach_driver(event->object);
-                                break;
+                case GAMEPORT_REGISTER_PORT:
+                        gameport_add_port(event->object);
+                        break;
 
-                        default:
-                                break;
+                case GAMEPORT_ATTACH_DRIVER:
+                        gameport_attach_driver(event->object);
+                        break;
                 }
 
                 gameport_remove_duplicate_events(event);
@@ -385,16 +374,14 @@ static void gameport_handle_event(void)
  */
 static void gameport_remove_pending_events(void *object)
 {
-        struct list_head *node, *next;
-        struct gameport_event *event;
+        struct gameport_event *event, *next;
         unsigned long flags;
 
         spin_lock_irqsave(&gameport_event_lock, flags);
 
-        list_for_each_safe(node, next, &gameport_event_list) {
-                event = list_entry(node, struct gameport_event, node);
+        list_for_each_entry_safe(event, next, &gameport_event_list, node) {
                 if (event->object == object) {
-                        list_del_init(node);
+                        list_del_init(&event->node);
                         gameport_free_event(event);
                 }
         }
@@ -441,7 +428,6 @@ static int gameport_thread(void *nothing)
                         kthread_should_stop() || !list_empty(&gameport_event_list));
         } while (!kthread_should_stop());
 
-        printk(KERN_DEBUG "gameport: kgameportd exiting\n");
         return 0;
 }
 
@@ -453,6 +439,7 @@ static int gameport_thread(void *nothing)
 static ssize_t gameport_show_description(struct device *dev, struct device_attribute *attr, char *buf)
 {
         struct gameport *gameport = to_gameport_port(dev);
+
         return sprintf(buf, "%s\n", gameport->name);
 }
 
@@ -521,7 +508,8 @@ static void gameport_init_port(struct gameport *gameport)
 
         mutex_init(&gameport->drv_mutex);
         device_initialize(&gameport->dev);
-        dev_set_name(&gameport->dev, "gameport%lu", (unsigned long)atomic_inc_return(&gameport_no) - 1);
+        dev_set_name(&gameport->dev, "gameport%lu",
+                        (unsigned long)atomic_inc_return(&gameport_no) - 1);
         gameport->dev.bus = &gameport_bus;
         gameport->dev.release = gameport_release_port;
         if (gameport->parent)
@@ -550,19 +538,17 @@ static void gameport_add_port(struct gameport *gameport)
         list_add_tail(&gameport->node, &gameport_list);
 
         if (gameport->io)
-                printk(KERN_INFO "gameport: %s is %s, io %#x, speed %dkHz\n",
-                        gameport->name, gameport->phys, gameport->io, gameport->speed);
+                dev_info(&gameport->dev, "%s is %s, io %#x, speed %dkHz\n",
+                         gameport->name, gameport->phys, gameport->io, gameport->speed);
         else
-                printk(KERN_INFO "gameport: %s is %s, speed %dkHz\n",
+                dev_info(&gameport->dev, "%s is %s, speed %dkHz\n",
                         gameport->name, gameport->phys, gameport->speed);
 
         error = device_add(&gameport->dev);
         if (error)
-                printk(KERN_ERR
-                        "gameport: device_add() failed for %s (%s), error: %d\n",
+                dev_err(&gameport->dev,
+                        "device_add() failed for %s (%s), error: %d\n",
                         gameport->phys, gameport->name, error);
-        else
-                gameport->registered = 1;
 }
 
 /*
@@ -584,10 +570,8 @@ static void gameport_destroy_port(struct gameport *gameport)
                 gameport->parent = NULL;
         }
 
-        if (gameport->registered) {
+        if (device_is_registered(&gameport->dev))
                 device_del(&gameport->dev);
-                gameport->registered = 0;
-        }
 
         list_del_init(&gameport->node);
 
@@ -705,8 +689,7 @@ static void gameport_attach_driver(struct gameport_driver *drv)
 
         error = driver_attach(&drv->driver);
         if (error)
-                printk(KERN_ERR
-                        "gameport: driver_attach() failed for %s, error: %d\n",
+                pr_err("driver_attach() failed for %s, error: %d\n",
                         drv->driver.name, error);
 }
 
@@ -727,8 +710,7 @@ int __gameport_register_driver(struct gameport_driver *drv, struct module *owner
 
         error = driver_register(&drv->driver);
         if (error) {
-                printk(KERN_ERR
-                        "gameport: driver_register() failed for %s, error: %d\n",
+                pr_err("driver_register() failed for %s, error: %d\n",
                         drv->driver.name, error);
                 return error;
         }
@@ -828,7 +810,7 @@ static int __init gameport_init(void)
 
         error = bus_register(&gameport_bus);
         if (error) {
-                printk(KERN_ERR "gameport: failed to register gameport bus, error: %d\n", error);
+                pr_err("failed to register gameport bus, error: %d\n", error);
                 return error;
         }
 
@@ -836,7 +818,7 @@ static int __init gameport_init(void)
         if (IS_ERR(gameport_task)) {
                 bus_unregister(&gameport_bus);
                 error = PTR_ERR(gameport_task);
-                printk(KERN_ERR "gameport: Failed to start kgameportd, error: %d\n", error);
+                pr_err("Failed to start kgameportd, error: %d\n", error);
                 return error;
         }
 
diff --git a/drivers/input/gameport/lightning.c b/drivers/input/gameport/lightning.c
index 06ad36ed3483..85d6ee09f11f 100644
--- a/drivers/input/gameport/lightning.c
+++ b/drivers/input/gameport/lightning.c
@@ -34,7 +34,6 @@
 #include <linux/module.h>
 #include <linux/init.h>
 #include <linux/gameport.h>
-#include <linux/slab.h>
 
 #define L4_PORT                 0x201
 #define L4_SELECT_ANALOG        0xa4
diff --git a/drivers/input/gameport/ns558.c b/drivers/input/gameport/ns558.c
index db556b71ddda..7c217848613e 100644
--- a/drivers/input/gameport/ns558.c
+++ b/drivers/input/gameport/ns558.c
@@ -166,7 +166,7 @@ static int ns558_isa_probe(int io)
 
 #ifdef CONFIG_PNP
 
-static struct pnp_device_id pnp_devids[] = {
+static const struct pnp_device_id pnp_devids[] = {
         { .id = "@P@0001", .driver_data = 0 }, /* ALS 100 */
         { .id = "@P@0020", .driver_data = 0 }, /* ALS 200 */
         { .id = "@P@1001", .driver_data = 0 }, /* ALS 100+ */
diff --git a/drivers/input/input-compat.h b/drivers/input/input-compat.h
index 47cd9eaee66a..4d8ea32e8a00 100644
--- a/drivers/input/input-compat.h
+++ b/drivers/input/input-compat.h
@@ -21,8 +21,6 @@
    you why the ifdefs are needed? Think about it again. -AK */
 #ifdef CONFIG_X86_64
 #  define INPUT_COMPAT_TEST is_compat_task()
-#elif defined(CONFIG_IA64)
-#  define INPUT_COMPAT_TEST IS_IA32_PROCESS(task_pt_regs(current))
 #elif defined(CONFIG_S390)
 #  define INPUT_COMPAT_TEST test_thread_flag(TIF_31BIT)
 #elif defined(CONFIG_MIPS)
diff --git a/drivers/input/input-polldev.c b/drivers/input/input-polldev.c
index 0d3ce7a50fb1..10c9b0a845f0 100644
--- a/drivers/input/input-polldev.c
+++ b/drivers/input/input-polldev.c
@@ -9,6 +9,7 @@
  */
 
 #include <linux/jiffies.h>
+#include <linux/slab.h>
 #include <linux/mutex.h>
 #include <linux/input-polldev.h>
 
@@ -56,14 +57,10 @@ static void input_polldev_stop_workqueue(void)
         mutex_unlock(&polldev_mutex);
 }
 
-static void input_polled_device_work(struct work_struct *work)
+static void input_polldev_queue_work(struct input_polled_dev *dev)
 {
-        struct input_polled_dev *dev =
-                container_of(work, struct input_polled_dev, work.work);
         unsigned long delay;
 
-        dev->poll(dev);
-
         delay = msecs_to_jiffies(dev->poll_interval);
         if (delay >= HZ)
                 delay = round_jiffies_relative(delay);
@@ -71,6 +68,15 @@ static void input_polled_device_work(struct work_struct *work)
         queue_delayed_work(polldev_wq, &dev->work, delay);
 }
 
+static void input_polled_device_work(struct work_struct *work)
+{
+        struct input_polled_dev *dev =
+                container_of(work, struct input_polled_dev, work.work);
+
+        dev->poll(dev);
+        input_polldev_queue_work(dev);
+}
+
 static int input_open_polled_device(struct input_dev *input)
 {
         struct input_polled_dev *dev = input_get_drvdata(input);
@@ -80,11 +86,12 @@ static int input_open_polled_device(struct input_dev *input)
         if (error)
                 return error;
 
-        if (dev->flush)
-                dev->flush(dev);
+        if (dev->open)
+                dev->open(dev);
 
-        queue_delayed_work(polldev_wq, &dev->work,
-                           msecs_to_jiffies(dev->poll_interval));
+        /* Only start polling if polling is enabled */
+        if (dev->poll_interval > 0)
+                queue_delayed_work(polldev_wq, &dev->work, 0);
 
         return 0;
 }
@@ -94,9 +101,95 @@ static void input_close_polled_device(struct input_dev *input)
         struct input_polled_dev *dev = input_get_drvdata(input);
 
         cancel_delayed_work_sync(&dev->work);
+        /*
+         * Clean up work struct to remove references to the workqueue.
+         * It may be destroyed by the next call. This causes problems
+         * at next device open-close in case of poll_interval == 0.
+         */
+        INIT_DELAYED_WORK(&dev->work, dev->work.work.func);
         input_polldev_stop_workqueue();
+
+        if (dev->close)
+                dev->close(dev);
 }
 
+/* SYSFS interface */
+
+static ssize_t input_polldev_get_poll(struct device *dev,
+                                      struct device_attribute *attr, char *buf)
+{
+        struct input_polled_dev *polldev = dev_get_drvdata(dev);
+
+        return sprintf(buf, "%d\n", polldev->poll_interval);
+}
+
+static ssize_t input_polldev_set_poll(struct device *dev,
+                                struct device_attribute *attr, const char *buf,
+                                size_t count)
+{
+        struct input_polled_dev *polldev = dev_get_drvdata(dev);
+        struct input_dev *input = polldev->input;
+        unsigned long interval;
+
+        if (strict_strtoul(buf, 0, &interval))
+                return -EINVAL;
+
+        if (interval < polldev->poll_interval_min)
+                return -EINVAL;
+
+        if (interval > polldev->poll_interval_max)
+                return -EINVAL;
+
+        mutex_lock(&input->mutex);
+
+        polldev->poll_interval = interval;
+
+        if (input->users) {
+                cancel_delayed_work_sync(&polldev->work);
+                if (polldev->poll_interval > 0)
+                        input_polldev_queue_work(polldev);
+        }
+
+        mutex_unlock(&input->mutex);
+
+        return count;
+}
+
+static DEVICE_ATTR(poll, S_IRUGO | S_IWUSR, input_polldev_get_poll,
+                                            input_polldev_set_poll);
+
+
+static ssize_t input_polldev_get_max(struct device *dev,
+                                     struct device_attribute *attr, char *buf)
+{
+        struct input_polled_dev *polldev = dev_get_drvdata(dev);
+
+        return sprintf(buf, "%d\n", polldev->poll_interval_max);
+}
+
+static DEVICE_ATTR(max, S_IRUGO, input_polldev_get_max, NULL);
+
+static ssize_t input_polldev_get_min(struct device *dev,
+                                     struct device_attribute *attr, char *buf)
+{
+        struct input_polled_dev *polldev = dev_get_drvdata(dev);
+
+        return sprintf(buf, "%d\n", polldev->poll_interval_min);
+}
+
+static DEVICE_ATTR(min, S_IRUGO, input_polldev_get_min, NULL);
+
+static struct attribute *sysfs_attrs[] = {
+        &dev_attr_poll.attr,
+        &dev_attr_max.attr,
+        &dev_attr_min.attr,
+        NULL
+};
+
+static struct attribute_group input_polldev_attribute_group = {
+        .attrs = sysfs_attrs
+};
+
 /**
  * input_allocate_polled_device - allocated memory polled device
  *
@@ -126,7 +219,7 @@ EXPORT_SYMBOL(input_allocate_polled_device);
  * @dev: device to free
  *
  * The function frees memory allocated for polling device and drops
- * reference to the associated input device (if present).
+ * reference to the associated input device.
  */
 void input_free_polled_device(struct input_polled_dev *dev)
 {
@@ -150,15 +243,38 @@ EXPORT_SYMBOL(input_free_polled_device);
 int input_register_polled_device(struct input_polled_dev *dev)
 {
         struct input_dev *input = dev->input;
+        int error;
 
         input_set_drvdata(input, dev);
         INIT_DELAYED_WORK(&dev->work, input_polled_device_work);
         if (!dev->poll_interval)
                 dev->poll_interval = 500;
+        if (!dev->poll_interval_max)
+                dev->poll_interval_max = dev->poll_interval;
         input->open = input_open_polled_device;
         input->close = input_close_polled_device;
 
-        return input_register_device(input);
+        error = input_register_device(input);
+        if (error)
+                return error;
+
+        error = sysfs_create_group(&input->dev.kobj,
+                                   &input_polldev_attribute_group);
+        if (error) {
+                input_unregister_device(input);
+                return error;
+        }
+
+        /*
+         * Take extra reference to the underlying input device so
+         * that it survives call to input_unregister_polled_device()
+         * and is deleted only after input_free_polled_device()
+         * has been invoked. This is needed to ease task of freeing
+         * sparse keymaps.
+         */
+        input_get_device(input);
+
+        return 0;
 }
 EXPORT_SYMBOL(input_register_polled_device);
 
@@ -169,13 +285,13 @@ EXPORT_SYMBOL(input_register_polled_device);
  * The function unregisters previously registered polled input
  * device from input layer. Polling is stopped and device is
  * ready to be freed with call to input_free_polled_device().
- * Callers should not attempt to access dev->input pointer
- * after calling this function.
  */
 void input_unregister_polled_device(struct input_polled_dev *dev)
 {
+        sysfs_remove_group(&dev->input->dev.kobj,
+                           &input_polldev_attribute_group);
+
         input_unregister_device(dev->input);
-        dev->input = NULL;
 }
 EXPORT_SYMBOL(input_unregister_polled_device);
 
diff --git a/drivers/input/input.c b/drivers/input/input.c
index 2266ecbfbc01..afd4e2b7658c 100644
--- a/drivers/input/input.c
+++ b/drivers/input/input.c
@@ -14,6 +14,7 @@
 #include <linux/types.h>
 #include <linux/input.h>
 #include <linux/module.h>
+#include <linux/slab.h>
 #include <linux/random.h>
 #include <linux/major.h>
 #include <linux/proc_fs.h>
@@ -24,6 +25,7 @@
 #include <linux/mutex.h>
 #include <linux/rcupdate.h>
 #include <linux/smp_lock.h>
+#include "input-compat.h"
 
 MODULE_AUTHOR("Vojtech Pavlik <vojtech@suse.cz>");
 MODULE_DESCRIPTION("Input core");
@@ -45,6 +47,7 @@ static unsigned int input_abs_bypass_init_data[] __initdata = {
         ABS_MT_TOOL_TYPE,
         ABS_MT_BLOB_ID,
         ABS_MT_TRACKING_ID,
+        ABS_MT_PRESSURE,
         0
 };
 static unsigned long input_abs_bypass[BITS_TO_LONGS(ABS_CNT)];
@@ -85,12 +88,14 @@ static int input_defuzz_abs_event(int value, int old_val, int fuzz)
 }
 
 /*
- * Pass event through all open handles. This function is called with
+ * Pass event first through all filters and then, if event has not been
+ * filtered out, through all open handles. This function is called with
  * dev->event_lock held and interrupts disabled.
  */
 static void input_pass_event(struct input_dev *dev,
                              unsigned int type, unsigned int code, int value)
 {
+        struct input_handler *handler;
         struct input_handle *handle;
 
         rcu_read_lock();
@@ -98,11 +103,25 @@ static void input_pass_event(struct input_dev *dev,
         handle = rcu_dereference(dev->grab);
         if (handle)
                 handle->handler->event(handle, type, code, value);
-        else
-                list_for_each_entry_rcu(handle, &dev->h_list, d_node)
-                        if (handle->open)
-                                handle->handler->event(handle,
-                                                        type, code, value);
+        else {
+                bool filtered = false;
+
+                list_for_each_entry_rcu(handle, &dev->h_list, d_node) {
+                        if (!handle->open)
+                                continue;
+
+                        handler = handle->handler;
+                        if (!handler->filter) {
+                                if (filtered)
+                                        break;
+
+                                handler->event(handle, type, code, value);
+
+                        } else if (handler->filter(handle, type, code, value))
+                                filtered = true;
+                }
+        }
+
         rcu_read_unlock();
 }
 
@@ -296,9 +315,15 @@ static void input_handle_event(struct input_dev *dev,
  * @value: value of the event
  *
  * This function should be used by drivers implementing various input
- * devices. See also input_inject_event().
+ * devices to report input events. See also input_inject_event().
+ *
+ * NOTE: input_event() may be safely used right after input device was
+ * allocated with input_allocate_device(), even before it is registered
+ * with input_register_device(), but the event will not reach any of the
+ * input handlers. Such early invocation of input_event() may be used
+ * to 'seed' initial state of a switch or initial position of absolute
+ * axis, etc.
  */
-
 void input_event(struct input_dev *dev,
                  unsigned int type, unsigned int code, int value)
 {
@@ -558,7 +583,8 @@ static int input_fetch_keycode(struct input_dev *dev, int scancode)
 }
 
 static int input_default_getkeycode(struct input_dev *dev,
-                                    int scancode, int *keycode)
+                                    unsigned int scancode,
+                                    unsigned int *keycode)
 {
         if (!dev->keycodesize)
                 return -EINVAL;
@@ -572,7 +598,8 @@ static int input_default_getkeycode(struct input_dev *dev,
 }
 
 static int input_default_setkeycode(struct input_dev *dev,
-                                    int scancode, int keycode)
+                                    unsigned int scancode,
+                                    unsigned int keycode)
 {
         int old_keycode;
         int i;
@@ -607,12 +634,12 @@ static int input_default_setkeycode(struct input_dev *dev,
                 }
         }
 
-        clear_bit(old_keycode, dev->keybit);
-        set_bit(keycode, dev->keybit);
+        __clear_bit(old_keycode, dev->keybit);
+        __set_bit(keycode, dev->keybit);
 
         for (i = 0; i < dev->keycodemax; i++) {
                 if (input_fetch_keycode(dev, i) == old_keycode) {
-                        set_bit(old_keycode, dev->keybit);
+                        __set_bit(old_keycode, dev->keybit);
                         break; /* Setting the bit twice is useless, so break */
                 }
         }
@@ -630,11 +657,9 @@ static int input_default_setkeycode(struct input_dev *dev,
  * This function should be called by anyone interested in retrieving current
  * keymap. Presently keyboard and evdev handlers use it.
  */
-int input_get_keycode(struct input_dev *dev, int scancode, int *keycode)
+int input_get_keycode(struct input_dev *dev,
+                      unsigned int scancode, unsigned int *keycode)
 {
-        if (scancode < 0)
-                return -EINVAL;
-
         return dev->getkeycode(dev, scancode, keycode);
 }
 EXPORT_SYMBOL(input_get_keycode);
@@ -648,16 +673,14 @@ EXPORT_SYMBOL(input_get_keycode);
  * This function should be called by anyone needing to update current
  * keymap. Presently keyboard and evdev handlers use it.
  */
-int input_set_keycode(struct input_dev *dev, int scancode, int keycode)
+int input_set_keycode(struct input_dev *dev,
+                      unsigned int scancode, unsigned int keycode)
 {
         unsigned long flags;
         int old_keycode;
         int retval;
 
-        if (scancode < 0)
-                return -EINVAL;
-
-        if (keycode < 0 || keycode > KEY_MAX)
+        if (keycode > KEY_MAX)
                 return -EINVAL;
 
         spin_lock_irqsave(&dev->event_lock, flags);
@@ -670,6 +693,9 @@ int input_set_keycode(struct input_dev *dev, int scancode, int keycode)
         if (retval)
                 goto out;
 
+        /* Make sure KEY_RESERVED did not get enabled. */
+        __clear_bit(KEY_RESERVED, dev->keybit);
+
         /*
          * Simulate keyup event if keycode is not present
          * in the keymap anymore
@@ -697,12 +723,13 @@ EXPORT_SYMBOL(input_set_keycode);
                 if (i != BITS_TO_LONGS(max)) \
                         continue;
 
-static const struct input_device_id *input_match_device(const struct input_device_id *id,
+static const struct input_device_id *input_match_device(struct input_handler *handler,
                                                         struct input_dev *dev)
 {
+        const struct input_device_id *id;
         int i;
 
-        for (; id->flags || id->driver_info; id++) {
+        for (id = handler->id_table; id->flags || id->driver_info; id++) {
 
                 if (id->flags & INPUT_DEVICE_ID_MATCH_BUS)
                         if (id->bustype != dev->id.bustype)
@@ -730,7 +757,8 @@ static const struct input_device_id *input_match_device(const struct input_devic
                 MATCH_BIT(ffbit,  FF_MAX);
                 MATCH_BIT(swbit,  SW_MAX);
 
-                return id;
+                if (!handler->match || handler->match(handler, dev))
+                        return id;
         }
 
         return NULL;
@@ -741,10 +769,7 @@ static int input_attach_handler(struct input_dev *dev, struct input_handler *han
         const struct input_device_id *id;
         int error;
 
-        if (handler->blacklist && input_match_device(handler->blacklist, dev))
-                return -ENODEV;
-
-        id = input_match_device(handler->id_table, dev);
+        id = input_match_device(handler, dev);
         if (!id)
                 return -ENODEV;
 
@@ -758,6 +783,40 @@ static int input_attach_handler(struct input_dev *dev, struct input_handler *han
         return error;
 }
 
+#ifdef CONFIG_COMPAT
+
+static int input_bits_to_string(char *buf, int buf_size,
+                                unsigned long bits, bool skip_empty)
+{
+        int len = 0;
+
+        if (INPUT_COMPAT_TEST) {
+                u32 dword = bits >> 32;
+                if (dword || !skip_empty)
+                        len += snprintf(buf, buf_size, "%x ", dword);
+
+                dword = bits & 0xffffffffUL;
+                if (dword || !skip_empty || len)
+                        len += snprintf(buf + len, max(buf_size - len, 0),
+                                        "%x", dword);
+        } else {
+                if (bits || !skip_empty)
+                        len += snprintf(buf, buf_size, "%lx", bits);
+        }
+
+        return len;
+}
+
+#else /* !CONFIG_COMPAT */
+
+static int input_bits_to_string(char *buf, int buf_size,
+                                unsigned long bits, bool skip_empty)
+{
+        return bits || !skip_empty ?
+                snprintf(buf, buf_size, "%lx", bits) : 0;
+}
+
+#endif
 
 #ifdef CONFIG_PROC_FS
 
@@ -826,14 +885,25 @@ static void input_seq_print_bitmap(struct seq_file *seq, const char *name,
                                    unsigned long *bitmap, int max)
 {
         int i;
-
-        for (i = BITS_TO_LONGS(max) - 1; i > 0; i--)
-                if (bitmap[i])
-                        break;
+        bool skip_empty = true;
+        char buf[18];
 
         seq_printf(seq, "B: %s=", name);
-        for (; i >= 0; i--)
-                seq_printf(seq, "%lx%s", bitmap[i], i > 0 ? " " : "");
+
+        for (i = BITS_TO_LONGS(max) - 1; i >= 0; i--) {
+                if (input_bits_to_string(buf, sizeof(buf),
+                                         bitmap[i], skip_empty)) {
+                        skip_empty = false;
+                        seq_printf(seq, "%s%s", buf, i > 0 ? " " : "");
+                }
+        }
+
+        /*
+         * If no output was produced print a single 0.
+         */
+        if (skip_empty)
+                seq_puts(seq, "0");
+
         seq_putc(seq, '\n');
 }
 
@@ -935,6 +1005,8 @@ static int input_handlers_seq_show(struct seq_file *seq, void *v)
         union input_seq_state *state = (union input_seq_state *)&seq->private;
 
         seq_printf(seq, "N: Number=%u Name=%s", state->pos, handler->name);
+        if (handler->filter)
+                seq_puts(seq, " (filter)");
         if (handler->fops)
                 seq_printf(seq, " Minor=%d", handler->minor);
         seq_putc(seq, '\n');
@@ -1122,14 +1194,23 @@ static int input_print_bitmap(char *buf, int buf_size, unsigned long *bitmap,
 {
         int i;
         int len = 0;
+        bool skip_empty = true;
+
+        for (i = BITS_TO_LONGS(max) - 1; i >= 0; i--) {
+                len += input_bits_to_string(buf + len, max(buf_size - len, 0),
+                                            bitmap[i], skip_empty);
+                if (len) {
+                        skip_empty = false;
+                        if (i > 0)
+                                len += snprintf(buf + len, max(buf_size - len, 0), " ");
+                }
+        }
 
-        for (i = BITS_TO_LONGS(max) - 1; i > 0; i--)
-                if (bitmap[i])
-                        break;
-
-        for (; i >= 0; i--)
-                len += snprintf(buf + len, max(buf_size - len, 0),
-                                "%lx%s", bitmap[i], i > 0 ? " " : "");
+        /*
+         * If no output was produced print a single 0.
+         */
+        if (len == 0)
+                len = snprintf(buf, buf_size, "%d", 0);
 
         if (add_cr)
                 len += snprintf(buf + len, max(buf_size - len, 0), "\n");
@@ -1144,7 +1225,8 @@ static ssize_t input_dev_show_cap_##bm(struct device *dev,		\
 {                                                                       \
         struct input_dev *input_dev = to_input_dev(dev);                \
         int len = input_print_bitmap(buf, PAGE_SIZE,                    \
-                                     input_dev->bm##bit, ev##_MAX, 1);  \
+                                     input_dev->bm##bit, ev##_MAX,      \
+                                     true);                             \
         return min_t(int, len, PAGE_SIZE);                              \
 }                                                                       \
 static DEVICE_ATTR(bm, S_IRUGO, input_dev_show_cap_##bm, NULL)
@@ -1208,7 +1290,7 @@ static int input_add_uevent_bm_var(struct kobj_uevent_env *env,
 
         len = input_print_bitmap(&env->buf[env->buflen - 1],
                                  sizeof(env->buf) - env->buflen,
-                                 bitmap, max, 0);
+                                 bitmap, max, false);
         if (len >= (sizeof(env->buf) - env->buflen))
                 return -ENOMEM;
 
@@ -1488,6 +1570,25 @@ void input_set_capability(struct input_dev *dev, unsigned int type, unsigned int
 }
 EXPORT_SYMBOL(input_set_capability);
 
+#define INPUT_CLEANSE_BITMASK(dev, type, bits)                          \
+        do {                                                            \
+                if (!test_bit(EV_##type, dev->evbit))                   \
+                        memset(dev->bits##bit, 0,                       \
+                                sizeof(dev->bits##bit));                \
+        } while (0)
+
+static void input_cleanse_bitmasks(struct input_dev *dev)
+{
+        INPUT_CLEANSE_BITMASK(dev, KEY, key);
+        INPUT_CLEANSE_BITMASK(dev, REL, rel);
+        INPUT_CLEANSE_BITMASK(dev, ABS, abs);
+        INPUT_CLEANSE_BITMASK(dev, MSC, msc);
+        INPUT_CLEANSE_BITMASK(dev, LED, led);
+        INPUT_CLEANSE_BITMASK(dev, SND, snd);
+        INPUT_CLEANSE_BITMASK(dev, FF, ff);
+        INPUT_CLEANSE_BITMASK(dev, SW, sw);
+}
+
 /**
  * input_register_device - register device with input core
  * @dev: device to be registered
@@ -1507,13 +1608,19 @@ int input_register_device(struct input_dev *dev)
         const char *path;
         int error;
 
+        /* Every input device generates EV_SYN/SYN_REPORT events. */
         __set_bit(EV_SYN, dev->evbit);
 
+        /* KEY_RESERVED is not supposed to be transmitted to userspace. */
+        __clear_bit(KEY_RESERVED, dev->keybit);
+
+        /* Make sure that bitmasks not mentioned in dev->evbit are clean. */
+        input_cleanse_bitmasks(dev);
+
         /*
          * If delay and period are pre-set by the driver, then autorepeating
          * is handled by the driver itself and we don't do it in input.c.
          */
-
         init_timer(&dev->timer);
         if (!dev->rep[REP_DELAY] && !dev->rep[REP_PERIOD]) {
                 dev->timer.data = (long) dev;
@@ -1658,6 +1765,38 @@ void input_unregister_handler(struct input_handler *handler)
 EXPORT_SYMBOL(input_unregister_handler);
 
 /**
+ * input_handler_for_each_handle - handle iterator
+ * @handler: input handler to iterate
+ * @data: data for the callback
+ * @fn: function to be called for each handle
+ *
+ * Iterate over @bus's list of devices, and call @fn for each, passing
+ * it @data and stop when @fn returns a non-zero value. The function is
+ * using RCU to traverse the list and therefore may be usind in atonic
+ * contexts. The @fn callback is invoked from RCU critical section and
+ * thus must not sleep.
+ */
+int input_handler_for_each_handle(struct input_handler *handler, void *data,
+                                  int (*fn)(struct input_handle *, void *))
+{
+        struct input_handle *handle;
+        int retval = 0;
+
+        rcu_read_lock();
+
+        list_for_each_entry_rcu(handle, &handler->h_list, h_node) {
+                retval = fn(handle, data);
+                if (retval)
+                        break;
+        }
+
+        rcu_read_unlock();
+
+        return retval;
+}
+EXPORT_SYMBOL(input_handler_for_each_handle);
+
+/**
  * input_register_handle - register a new input handle
  * @handle: handle to register
  *
@@ -1681,7 +1820,16 @@ int input_register_handle(struct input_handle *handle)
         error = mutex_lock_interruptible(&dev->mutex);
         if (error)
                 return error;
-        list_add_tail_rcu(&handle->d_node, &dev->h_list);
+
+        /*
+         * Filters go to the head of the list, normal handlers
+         * to the tail.
+         */
+        if (handler->filter)
+                list_add_rcu(&handle->d_node, &dev->h_list);
+        else
+                list_add_tail_rcu(&handle->d_node, &dev->h_list);
+
         mutex_unlock(&dev->mutex);
 
         /*
@@ -1690,7 +1838,7 @@ int input_register_handle(struct input_handle *handle)
          * we can't be racing with input_unregister_handle()
          * and so separate lock is not needed here.
          */
-        list_add_tail(&handle->h_node, &handler->h_list);
+        list_add_tail_rcu(&handle->h_node, &handler->h_list);
 
         if (handler->start)
                 handler->start(handle);
@@ -1713,7 +1861,7 @@ void input_unregister_handle(struct input_handle *handle)
 {
         struct input_dev *dev = handle->dev;
 
-        list_del_init(&handle->h_node);
+        list_del_rcu(&handle->h_node);
 
         /*
          * Take dev->mutex to prevent race with input_release_device().
@@ -1721,6 +1869,7 @@ void input_unregister_handle(struct input_handle *handle)
         mutex_lock(&dev->mutex);
         list_del_rcu(&handle->d_node);
         mutex_unlock(&dev->mutex);
+
         synchronize_rcu();
 }
 EXPORT_SYMBOL(input_unregister_handle);
@@ -1731,35 +1880,37 @@ static int input_open_file(struct inode *inode, struct file *file)
         const struct file_operations *old_fops, *new_fops = NULL;
         int err;
 
-        lock_kernel();
+        err = mutex_lock_interruptible(&input_mutex);
+        if (err)
+                return err;
+
         /* No load-on-demand here? */
         handler = input_table[iminor(inode) >> 5];
-        if (!handler || !(new_fops = fops_get(handler->fops))) {
-                err = -ENODEV;
-                goto out;
-        }
+        if (handler)
+                new_fops = fops_get(handler->fops);
+
+        mutex_unlock(&input_mutex);
 
         /*
          * That's _really_ odd. Usually NULL ->open means "nothing special",
          * not "no device". Oh, well...
          */
-        if (!new_fops->open) {
+        if (!new_fops || !new_fops->open) {
                 fops_put(new_fops);
                 err = -ENODEV;
                 goto out;
         }
+
         old_fops = file->f_op;
         file->f_op = new_fops;
 
         err = new_fops->open(inode, file);
-
         if (err) {
                 fops_put(file->f_op);
                 file->f_op = fops_get(old_fops);
         }
         fops_put(old_fops);
 out:
-        unlock_kernel();
         return err;
 }
 
diff --git a/drivers/input/joydev.c b/drivers/input/joydev.c
index b1bd6dd32286..c52bec4d0530 100644
--- a/drivers/input/joydev.c
+++ b/drivers/input/joydev.c
@@ -286,6 +286,8 @@ static int joydev_open(struct inode *inode, struct file *file)
                 goto err_free_client;
 
         file->private_data = client;
+        nonseekable_open(inode, file);
+
         return 0;
 
  err_free_client:
@@ -775,6 +777,20 @@ static void joydev_cleanup(struct joydev *joydev)
                 input_close_device(handle);
 }
 
+
+static bool joydev_match(struct input_handler *handler, struct input_dev *dev)
+{
+        /* Avoid touchpads and touchscreens */
+        if (test_bit(EV_KEY, dev->evbit) && test_bit(BTN_TOUCH, dev->keybit))
+                return false;
+
+        /* Avoid tablets, digitisers and similar devices */
+        if (test_bit(EV_KEY, dev->evbit) && test_bit(BTN_DIGI, dev->keybit))
+                return false;
+
+        return true;
+}
+
 static int joydev_connect(struct input_handler *handler, struct input_dev *dev,
                           const struct input_device_id *id)
 {
@@ -894,22 +910,6 @@ static void joydev_disconnect(struct input_handle *handle)
         put_device(&joydev->dev);
 }
 
-static const struct input_device_id joydev_blacklist[] = {
-        {
-                .flags = INPUT_DEVICE_ID_MATCH_EVBIT |
-                                INPUT_DEVICE_ID_MATCH_KEYBIT,
-                .evbit = { BIT_MASK(EV_KEY) },
-                .keybit = { [BIT_WORD(BTN_TOUCH)] = BIT_MASK(BTN_TOUCH) },
-        },      /* Avoid itouchpads and touchscreens */
-        {
-                .flags = INPUT_DEVICE_ID_MATCH_EVBIT |
-                                INPUT_DEVICE_ID_MATCH_KEYBIT,
-                .evbit = { BIT_MASK(EV_KEY) },
-                .keybit = { [BIT_WORD(BTN_DIGI)] = BIT_MASK(BTN_DIGI) },
-        },      /* Avoid tablets, digitisers and similar devices */
-        { }     /* Terminating entry */
-};
-
 static const struct input_device_id joydev_ids[] = {
         {
                 .flags = INPUT_DEVICE_ID_MATCH_EVBIT |
@@ -936,13 +936,13 @@ MODULE_DEVICE_TABLE(input, joydev_ids);
 
 static struct input_handler joydev_handler = {
         .event          = joydev_event,
+        .match          = joydev_match,
         .connect        = joydev_connect,
         .disconnect     = joydev_disconnect,
         .fops           = &joydev_fops,
         .minor          = JOYDEV_MINOR_BASE,
         .name           = "joydev",
         .id_table       = joydev_ids,
-        .blacklist      = joydev_blacklist,
 };
 
 static int __init joydev_init(void)
diff --git a/drivers/input/joystick/Kconfig b/drivers/input/joystick/Kconfig
index b11419590cfe..5b596165b571 100644
--- a/drivers/input/joystick/Kconfig
+++ b/drivers/input/joystick/Kconfig
@@ -221,6 +221,7 @@ config JOYSTICK_DB9
 config JOYSTICK_GAMECON
         tristate "Multisystem, NES, SNES, N64, PSX joysticks and gamepads"
         depends on PARPORT
+        select INPUT_FF_MEMLESS
         ---help---
           Say Y here if you have a Nintendo Entertainment System gamepad,
           Super Nintendo Entertainment System gamepad, Nintendo 64 gamepad,
diff --git a/drivers/input/joystick/db9.c b/drivers/input/joystick/db9.c
index 523959484753..8e7de5c7754f 100644
--- a/drivers/input/joystick/db9.c
+++ b/drivers/input/joystick/db9.c
@@ -36,6 +36,7 @@
 #include <linux/parport.h>
 #include <linux/input.h>
 #include <linux/mutex.h>
+#include <linux/slab.h>
 
 MODULE_AUTHOR("Vojtech Pavlik <vojtech@ucw.cz>");
 MODULE_DESCRIPTION("Atari, Amstrad, Commodore, Amiga, Sega, etc. joystick driver");
diff --git a/drivers/input/joystick/gamecon.c b/drivers/input/joystick/gamecon.c
index 07a32aff5a31..fbd62abb66f9 100644
--- a/drivers/input/joystick/gamecon.c
+++ b/drivers/input/joystick/gamecon.c
@@ -30,6 +30,8 @@
  * Vojtech Pavlik, Simunkova 1594, Prague 8, 182 00 Czech Republic
  */
 
+#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
+
 #include <linux/kernel.h>
 #include <linux/delay.h>
 #include <linux/module.h>
@@ -37,6 +39,7 @@
 #include <linux/parport.h>
 #include <linux/input.h>
 #include <linux/mutex.h>
+#include <linux/slab.h>
 
 MODULE_AUTHOR("Vojtech Pavlik <vojtech@ucw.cz>");
 MODULE_DESCRIPTION("NES, SNES, N64, MultiSystem, PSX gamepad driver");
@@ -61,48 +64,73 @@ MODULE_PARM_DESC(map3, "Describes third set of devices");
 
 /* see also gs_psx_delay parameter in PSX support section */
 
-#define GC_SNES         1
-#define GC_NES          2
-#define GC_NES4         3
-#define GC_MULTI        4
-#define GC_MULTI2       5
-#define GC_N64          6
-#define GC_PSX          7
-#define GC_DDR          8
-#define GC_SNESMOUSE    9
-
-#define GC_MAX          9
+enum gc_type {
+        GC_NONE = 0,
+        GC_SNES,
+        GC_NES,
+        GC_NES4,
+        GC_MULTI,
+        GC_MULTI2,
+        GC_N64,
+        GC_PSX,
+        GC_DDR,
+        GC_SNESMOUSE,
+        GC_MAX
+};
 
 #define GC_REFRESH_TIME HZ/100
 
+struct gc_pad {
+        struct input_dev *dev;
+        enum gc_type type;
+        char phys[32];
+};
+
 struct gc {
         struct pardevice *pd;
+        struct gc_pad pads[GC_MAX_DEVICES];
         struct input_dev *dev[GC_MAX_DEVICES];
         struct timer_list timer;
-        unsigned char pads[GC_MAX + 1];
+        int pad_count[GC_MAX];
         int used;
         struct mutex mutex;
-        char phys[GC_MAX_DEVICES][32];
+};
+
+struct gc_subdev {
+        unsigned int idx;
 };
 
 static struct gc *gc_base[3];
 
-static int gc_status_bit[] = { 0x40, 0x80, 0x20, 0x10, 0x08 };
+static const int gc_status_bit[] = { 0x40, 0x80, 0x20, 0x10, 0x08 };
+
+static const char *gc_names[] = {
+        NULL, "SNES pad", "NES pad", "NES FourPort", "Multisystem joystick",
+        "Multisystem 2-button joystick", "N64 controller", "PSX controller",
+        "PSX DDR controller", "SNES mouse"
+};
 
-static char *gc_names[] = { NULL, "SNES pad", "NES pad", "NES FourPort", "Multisystem joystick",
-                                "Multisystem 2-button joystick", "N64 controller", "PSX controller",
-                                "PSX DDR controller", "SNES mouse" };
 /*
  * N64 support.
  */
 
-static unsigned char gc_n64_bytes[] = { 0, 1, 13, 15, 14, 12, 10, 11, 2, 3 };
-static short gc_n64_btn[] = { BTN_A, BTN_B, BTN_C, BTN_X, BTN_Y, BTN_Z, BTN_TL, BTN_TR, BTN_TRIGGER, BTN_START };
+static const unsigned char gc_n64_bytes[] = { 0, 1, 13, 15, 14, 12, 10, 11, 2, 3 };
+static const short gc_n64_btn[] = {
+        BTN_A, BTN_B, BTN_C, BTN_X, BTN_Y, BTN_Z,
+        BTN_TL, BTN_TR, BTN_TRIGGER, BTN_START
+};
 
 #define GC_N64_LENGTH           32              /* N64 bit length, not including stop bit */
-#define GC_N64_REQUEST_LENGTH   37              /* transmit request sequence is 9 bits long */
+#define GC_N64_STOP_LENGTH      5               /* Length of encoded stop bit */
+#define GC_N64_CMD_00           0x11111111UL
+#define GC_N64_CMD_01           0xd1111111UL
+#define GC_N64_CMD_03           0xdd111111UL
+#define GC_N64_CMD_1b           0xdd1dd111UL
+#define GC_N64_CMD_c0           0x111111ddUL
+#define GC_N64_CMD_80           0x1111111dUL
+#define GC_N64_STOP_BIT         0x1d            /* Encoded stop bit */
+#define GC_N64_REQUEST_DATA     GC_N64_CMD_01   /* the request data command */
 #define GC_N64_DELAY            133             /* delay between transmit request, and response ready (us) */
-#define GC_N64_REQUEST          0x1dd1111111ULL /* the request data command (encoded for 000000011) */
 #define GC_N64_DWS              3               /* delay between write segments (required for sound playback because of ISA DMA) */
                                                 /* GC_N64_DWS > 24 is known to fail */
 #define GC_N64_POWER_W          0xe2            /* power during write (transmit request) */
@@ -114,8 +142,40 @@ static short gc_n64_btn[] = { BTN_A, BTN_B, BTN_C, BTN_X, BTN_Y, BTN_Z, BTN_TL,
 #define GC_N64_CLOCK            0x02            /* clock bits for read */
 
 /*
+ * Used for rumble code.
+ */
+
+/* Send encoded command */
+static void gc_n64_send_command(struct gc *gc, unsigned long cmd,
+                                unsigned char target)
+{
+        struct parport *port = gc->pd->port;
+        int i;
+
+        for (i = 0; i < GC_N64_LENGTH; i++) {
+                unsigned char data = (cmd >> i) & 1 ? target : 0;
+                parport_write_data(port, GC_N64_POWER_W | data);
+                udelay(GC_N64_DWS);
+        }
+}
+
+/* Send stop bit */
+static void gc_n64_send_stop_bit(struct gc *gc, unsigned char target)
+{
+        struct parport *port = gc->pd->port;
+        int i;
+
+        for (i = 0; i < GC_N64_STOP_LENGTH; i++) {
+                unsigned char data = (GC_N64_STOP_BIT >> i) & 1 ? target : 0;
+                parport_write_data(port, GC_N64_POWER_W | data);
+                udelay(GC_N64_DWS);
+        }
+}
+
+/*
  * gc_n64_read_packet() reads an N64 packet.
- * Each pad uses one bit per byte. So all pads connected to this port are read in parallel.
+ * Each pad uses one bit per byte. So all pads connected to this port
+ * are read in parallel.
  */
 
 static void gc_n64_read_packet(struct gc *gc, unsigned char *data)
@@ -128,14 +188,13 @@ static void gc_n64_read_packet(struct gc *gc, unsigned char *data)
  */
 
         local_irq_save(flags);
-        for (i = 0; i < GC_N64_REQUEST_LENGTH; i++) {
-                parport_write_data(gc->pd->port, GC_N64_POWER_W | ((GC_N64_REQUEST >> i) & 1 ? GC_N64_OUT : 0));
-                udelay(GC_N64_DWS);
-        }
+        gc_n64_send_command(gc, GC_N64_REQUEST_DATA, GC_N64_OUT);
+        gc_n64_send_stop_bit(gc, GC_N64_OUT);
         local_irq_restore(flags);
 
 /*
- * Wait for the pad response to be loaded into the 33-bit register of the adapter
+ * Wait for the pad response to be loaded into the 33-bit register
+ * of the adapter.
  */
 
         udelay(GC_N64_DELAY);
@@ -146,13 +205,15 @@ static void gc_n64_read_packet(struct gc *gc, unsigned char *data)
 
         for (i = 0; i < GC_N64_LENGTH; i++) {
                 parport_write_data(gc->pd->port, GC_N64_POWER_R);
+                udelay(2);
                 data[i] = parport_read_status(gc->pd->port);
                 parport_write_data(gc->pd->port, GC_N64_POWER_R | GC_N64_CLOCK);
          }
 
 /*
- * We must wait 200 ms here for the controller to reinitialize before the next read request.
- * No worries as long as gc_read is polled less frequently than this.
+ * We must wait 200 ms here for the controller to reinitialize before
+ * the next read request. No worries as long as gc_read is polled less
+ * frequently than this.
  */
 
 }
@@ -160,45 +221,112 @@ static void gc_n64_read_packet(struct gc *gc, unsigned char *data)
 static void gc_n64_process_packet(struct gc *gc)
 {
         unsigned char data[GC_N64_LENGTH];
-        signed char axes[2];
         struct input_dev *dev;
         int i, j, s;
+        signed char x, y;
 
         gc_n64_read_packet(gc, data);
 
         for (i = 0; i < GC_MAX_DEVICES; i++) {
 
-                dev = gc->dev[i];
-                if (!dev)
+                if (gc->pads[i].type != GC_N64)
                         continue;
 
+                dev = gc->pads[i].dev;
                 s = gc_status_bit[i];
 
-                if (s & gc->pads[GC_N64] & ~(data[8] | data[9])) {
+                if (s & ~(data[8] | data[9])) {
 
-                        axes[0] = axes[1] = 0;
+                        x = y = 0;
 
                         for (j = 0; j < 8; j++) {
                                 if (data[23 - j] & s)
-                                        axes[0] |= 1 << j;
+                                        x |= 1 << j;
                                 if (data[31 - j] & s)
-                                        axes[1] |= 1 << j;
+                                        y |= 1 << j;
                         }
 
-                        input_report_abs(dev, ABS_X,  axes[0]);
-                        input_report_abs(dev, ABS_Y, -axes[1]);
+                        input_report_abs(dev, ABS_X,  x);
+                        input_report_abs(dev, ABS_Y, -y);
 
-                        input_report_abs(dev, ABS_HAT0X, !(s & data[6]) - !(s & data[7]));
-                        input_report_abs(dev, ABS_HAT0Y, !(s & data[4]) - !(s & data[5]));
+                        input_report_abs(dev, ABS_HAT0X,
+                                         !(s & data[6]) - !(s & data[7]));
+                        input_report_abs(dev, ABS_HAT0Y,
+                                         !(s & data[4]) - !(s & data[5]));
 
                         for (j = 0; j < 10; j++)
-                                input_report_key(dev, gc_n64_btn[j], s & data[gc_n64_bytes[j]]);
+                                input_report_key(dev, gc_n64_btn[j],
+                                                 s & data[gc_n64_bytes[j]]);
 
                         input_sync(dev);
                 }
         }
 }
 
+static int gc_n64_play_effect(struct input_dev *dev, void *data,
+                              struct ff_effect *effect)
+{
+        int i;
+        unsigned long flags;
+        struct gc *gc = input_get_drvdata(dev);
+        struct gc_subdev *sdev = data;
+        unsigned char target = 1 << sdev->idx; /* select desired pin */
+
+        if (effect->type == FF_RUMBLE) {
+                struct ff_rumble_effect *rumble = &effect->u.rumble;
+                unsigned int cmd =
+                        rumble->strong_magnitude || rumble->weak_magnitude ?
+                        GC_N64_CMD_01 : GC_N64_CMD_00;
+
+                local_irq_save(flags);
+
+                /* Init Rumble - 0x03, 0x80, 0x01, (34)0x80 */
+                gc_n64_send_command(gc, GC_N64_CMD_03, target);
+                gc_n64_send_command(gc, GC_N64_CMD_80, target);
+                gc_n64_send_command(gc, GC_N64_CMD_01, target);
+                for (i = 0; i < 32; i++)
+                        gc_n64_send_command(gc, GC_N64_CMD_80, target);
+                gc_n64_send_stop_bit(gc, target);
+
+                udelay(GC_N64_DELAY);
+
+                /* Now start or stop it - 0x03, 0xc0, 0zx1b, (32)0x01/0x00 */
+                gc_n64_send_command(gc, GC_N64_CMD_03, target);
+                gc_n64_send_command(gc, GC_N64_CMD_c0, target);
+                gc_n64_send_command(gc, GC_N64_CMD_1b, target);
+                for (i = 0; i < 32; i++)
+                        gc_n64_send_command(gc, cmd, target);
+                gc_n64_send_stop_bit(gc, target);
+
+                local_irq_restore(flags);
+
+        }
+
+        return 0;
+}
+
+static int __init gc_n64_init_ff(struct input_dev *dev, int i)
+{
+        struct gc_subdev *sdev;
+        int err;
+
+        sdev = kmalloc(sizeof(*sdev), GFP_KERNEL);
+        if (!sdev)
+                return -ENOMEM;
+
+        sdev->idx = i;
+
+        input_set_capability(dev, EV_FF, FF_RUMBLE);
+
+        err = input_ff_create_memless(dev, sdev, gc_n64_play_effect);
+        if (err) {
+                kfree(sdev);
+                return err;
+        }
+
+        return 0;
+}
+
 /*
  * NES/SNES support.
  */
@@ -214,9 +342,11 @@ static void gc_n64_process_packet(struct gc *gc)
 #define GC_NES_CLOCK    0x01
 #define GC_NES_LATCH    0x02
 
-static unsigned char gc_nes_bytes[] = { 0, 1, 2, 3 };
-static unsigned char gc_snes_bytes[] = { 8, 0, 2, 3, 9, 1, 10, 11 };
-static short gc_snes_btn[] = { BTN_A, BTN_B, BTN_SELECT, BTN_START, BTN_X, BTN_Y, BTN_TL, BTN_TR };
+static const unsigned char gc_nes_bytes[] = { 0, 1, 2, 3 };
+static const unsigned char gc_snes_bytes[] = { 8, 0, 2, 3, 9, 1, 10, 11 };
+static const short gc_snes_btn[] = {
+        BTN_A, BTN_B, BTN_SELECT, BTN_START, BTN_X, BTN_Y, BTN_TL, BTN_TR
+};
 
 /*
  * gc_nes_read_packet() reads a NES/SNES packet.
@@ -244,40 +374,51 @@ static void gc_nes_read_packet(struct gc *gc, int length, unsigned char *data)
 static void gc_nes_process_packet(struct gc *gc)
 {
         unsigned char data[GC_SNESMOUSE_LENGTH];
+        struct gc_pad *pad;
         struct input_dev *dev;
         int i, j, s, len;
         char x_rel, y_rel;
 
-        len = gc->pads[GC_SNESMOUSE] ? GC_SNESMOUSE_LENGTH :
-                        (gc->pads[GC_SNES] ? GC_SNES_LENGTH : GC_NES_LENGTH);
+        len = gc->pad_count[GC_SNESMOUSE] ? GC_SNESMOUSE_LENGTH :
+                        (gc->pad_count[GC_SNES] ? GC_SNES_LENGTH : GC_NES_LENGTH);
 
         gc_nes_read_packet(gc, len, data);
 
         for (i = 0; i < GC_MAX_DEVICES; i++) {
 
+                pad = &gc->pads[i];
                 dev = gc->dev[i];
-                if (!dev)
-                        continue;
-
                 s = gc_status_bit[i];
 
-                if (s & (gc->pads[GC_NES] | gc->pads[GC_SNES])) {
+                switch (pad->type) {
+
+                case GC_NES:
+
                         input_report_abs(dev, ABS_X, !(s & data[6]) - !(s & data[7]));
                         input_report_abs(dev, ABS_Y, !(s & data[4]) - !(s & data[5]));
-                }
 
-                if (s & gc->pads[GC_NES])
                         for (j = 0; j < 4; j++)
-                                input_report_key(dev, gc_snes_btn[j], s & data[gc_nes_bytes[j]]);
+                                input_report_key(dev, gc_snes_btn[j],
+                                                 s & data[gc_nes_bytes[j]]);
+                        input_sync(dev);
+                        break;
+
+                case GC_SNES:
+
+                        input_report_abs(dev, ABS_X, !(s & data[6]) - !(s & data[7]));
+                        input_report_abs(dev, ABS_Y, !(s & data[4]) - !(s & data[5]));
 
-                if (s & gc->pads[GC_SNES])
                         for (j = 0; j < 8; j++)
-                                input_report_key(dev, gc_snes_btn[j], s & data[gc_snes_bytes[j]]);
+                                input_report_key(dev, gc_snes_btn[j],
+                                                 s & data[gc_snes_bytes[j]]);
+                        input_sync(dev);
+                        break;
 
-                if (s & gc->pads[GC_SNESMOUSE]) {
+                case GC_SNESMOUSE:
                         /*
-                         * The 4 unused bits from SNES controllers appear to be ID bits
-                         * so use them to make sure iwe are dealing with a mouse.
+                         * The 4 unused bits from SNES controllers appear
+                         * to be ID bits so use them to make sure we are
+                         * dealing with a mouse.
                          * gamepad is connected. This is important since
                          * my SNES gamepad sends 1's for bits 16-31, which
                          * cause the mouse pointer to quickly move to the
@@ -310,9 +451,14 @@ static void gc_nes_process_packet(struct gc *gc)
                                                 y_rel = -y_rel;
                                         input_report_rel(dev, REL_Y, y_rel);
                                 }
+
+                                input_sync(dev);
                         }
+                        break;
+
+                default:
+                        break;
                 }
-                input_sync(dev);
         }
 }
 
@@ -340,29 +486,35 @@ static void gc_multi_read_packet(struct gc *gc, int length, unsigned char *data)
 static void gc_multi_process_packet(struct gc *gc)
 {
         unsigned char data[GC_MULTI2_LENGTH];
+        int data_len = gc->pad_count[GC_MULTI2] ? GC_MULTI2_LENGTH : GC_MULTI_LENGTH;
+        struct gc_pad *pad;
         struct input_dev *dev;
         int i, s;
 
-        gc_multi_read_packet(gc, gc->pads[GC_MULTI2] ? GC_MULTI2_LENGTH : GC_MULTI_LENGTH, data);
+        gc_multi_read_packet(gc, data_len, data);
 
         for (i = 0; i < GC_MAX_DEVICES; i++) {
-
-                dev = gc->dev[i];
-                if (!dev)
-                        continue;
-
+                pad = &gc->pads[i];
+                dev = pad->dev;
                 s = gc_status_bit[i];
 
-                if (s & (gc->pads[GC_MULTI] | gc->pads[GC_MULTI2])) {
-                        input_report_abs(dev, ABS_X,  !(s & data[2]) - !(s & data[3]));
-                        input_report_abs(dev, ABS_Y,  !(s & data[0]) - !(s & data[1]));
-                        input_report_key(dev, BTN_TRIGGER, s & data[4]);
-                }
-
-                if (s & gc->pads[GC_MULTI2])
+                switch (pad->type) {
+                case GC_MULTI2:
                         input_report_key(dev, BTN_THUMB, s & data[5]);
+                        /* fall through */
 
-                input_sync(dev);
+                case GC_MULTI:
+                        input_report_abs(dev, ABS_X,
+                                         !(s & data[2]) - !(s & data[3]));
+                        input_report_abs(dev, ABS_Y,
+                                         !(s & data[0]) - !(s & data[1]));
+                        input_report_key(dev, BTN_TRIGGER, s & data[4]);
+                        input_sync(dev);
+                        break;
+
+                default:
+                        break;
+                }
         }
 }
 
@@ -398,30 +550,41 @@ static int gc_psx_delay = GC_PSX_DELAY;
 module_param_named(psx_delay, gc_psx_delay, uint, 0);
 MODULE_PARM_DESC(psx_delay, "Delay when accessing Sony PSX controller (usecs)");
 
-static short gc_psx_abs[] = { ABS_X, ABS_Y, ABS_RX, ABS_RY, ABS_HAT0X, ABS_HAT0Y };
-static short gc_psx_btn[] = { BTN_TL, BTN_TR, BTN_TL2, BTN_TR2, BTN_A, BTN_B, BTN_X, BTN_Y,
-                                BTN_START, BTN_SELECT, BTN_THUMBL, BTN_THUMBR };
-static short gc_psx_ddr_btn[] = { BTN_0, BTN_1, BTN_2, BTN_3 };
+static const short gc_psx_abs[] = {
+        ABS_X, ABS_Y, ABS_RX, ABS_RY, ABS_HAT0X, ABS_HAT0Y
+};
+static const short gc_psx_btn[] = {
+        BTN_TL, BTN_TR, BTN_TL2, BTN_TR2, BTN_A, BTN_B, BTN_X, BTN_Y,
+        BTN_START, BTN_SELECT, BTN_THUMBL, BTN_THUMBR
+};
+static const short gc_psx_ddr_btn[] = { BTN_0, BTN_1, BTN_2, BTN_3 };
 
 /*
  * gc_psx_command() writes 8bit command and reads 8bit data from
  * the psx pad.
  */
 
-static void gc_psx_command(struct gc *gc, int b, unsigned char data[GC_MAX_DEVICES])
+static void gc_psx_command(struct gc *gc, int b, unsigned char *data)
 {
+        struct parport *port = gc->pd->port;
         int i, j, cmd, read;
 
-        for (i = 0; i < GC_MAX_DEVICES; i++)
-                data[i] = 0;
+        memset(data, 0, GC_MAX_DEVICES);
 
         for (i = 0; i < GC_PSX_LENGTH; i++, b >>= 1) {
                 cmd = (b & 1) ? GC_PSX_COMMAND : 0;
-                parport_write_data(gc->pd->port, cmd | GC_PSX_POWER);
+                parport_write_data(port, cmd | GC_PSX_POWER);
                 udelay(gc_psx_delay);
-                read = parport_read_status(gc->pd->port) ^ 0x80;
-                for (j = 0; j < GC_MAX_DEVICES; j++)
-                        data[j] |= (read & gc_status_bit[j] & (gc->pads[GC_PSX] | gc->pads[GC_DDR])) ? (1 << i) : 0;
+
+                read = parport_read_status(port) ^ 0x80;
+
+                for (j = 0; j < GC_MAX_DEVICES; j++) {
+                        struct gc_pad *pad = &gc->pads[i];
+
+                        if (pad->type == GC_PSX || pad->type == GC_DDR)
+                                data[j] |= (read & gc_status_bit[j]) ? (1 << i) : 0;
+                }
+
                 parport_write_data(gc->pd->port, cmd | GC_PSX_CLOCK | GC_PSX_POWER);
                 udelay(gc_psx_delay);
         }
@@ -432,31 +595,40 @@ static void gc_psx_command(struct gc *gc, int b, unsigned char data[GC_MAX_DEVIC
  * device identifier code.
  */
 
-static void gc_psx_read_packet(struct gc *gc, unsigned char data[GC_MAX_DEVICES][GC_PSX_BYTES],
+static void gc_psx_read_packet(struct gc *gc,
+                               unsigned char data[GC_MAX_DEVICES][GC_PSX_BYTES],
                                unsigned char id[GC_MAX_DEVICES])
 {
         int i, j, max_len = 0;
         unsigned long flags;
         unsigned char data2[GC_MAX_DEVICES];
 
-        parport_write_data(gc->pd->port, GC_PSX_CLOCK | GC_PSX_SELECT | GC_PSX_POWER);  /* Select pad */
+        /* Select pad */
+        parport_write_data(gc->pd->port, GC_PSX_CLOCK | GC_PSX_SELECT | GC_PSX_POWER);
         udelay(gc_psx_delay);
-        parport_write_data(gc->pd->port, GC_PSX_CLOCK | GC_PSX_POWER);                  /* Deselect, begin command */
+        /* Deselect, begin command */
+        parport_write_data(gc->pd->port, GC_PSX_CLOCK | GC_PSX_POWER);
         udelay(gc_psx_delay);
 
         local_irq_save(flags);
 
-        gc_psx_command(gc, 0x01, data2);                                                /* Access pad */
-        gc_psx_command(gc, 0x42, id);                                                   /* Get device ids */
-        gc_psx_command(gc, 0, data2);                                                   /* Dump status */
+        gc_psx_command(gc, 0x01, data2);        /* Access pad */
+        gc_psx_command(gc, 0x42, id);           /* Get device ids */
+        gc_psx_command(gc, 0, data2);           /* Dump status */
+
+        /* Find the longest pad */
+        for (i = 0; i < GC_MAX_DEVICES; i++) {
+                struct gc_pad *pad = &gc->pads[i];
 
-        for (i =0; i < GC_MAX_DEVICES; i++)                                                             /* Find the longest pad */
-                if((gc_status_bit[i] & (gc->pads[GC_PSX] | gc->pads[GC_DDR]))
-                        && (GC_PSX_LEN(id[i]) > max_len)
-                        && (GC_PSX_LEN(id[i]) <= GC_PSX_BYTES))
+                if ((pad->type == GC_PSX || pad->type == GC_DDR) &&
+                    GC_PSX_LEN(id[i]) > max_len &&
+                    GC_PSX_LEN(id[i]) <= GC_PSX_BYTES) {
                         max_len = GC_PSX_LEN(id[i]);
+                }
+        }
 
-        for (i = 0; i < max_len; i++) {                                         /* Read in all the data */
+        /* Read in all the data */
+        for (i = 0; i < max_len; i++) {
                 gc_psx_command(gc, 0, data2);
                 for (j = 0; j < GC_MAX_DEVICES; j++)
                         data[j][i] = data2[j];
@@ -466,86 +638,104 @@ static void gc_psx_read_packet(struct gc *gc, unsigned char data[GC_MAX_DEVICES]
 
         parport_write_data(gc->pd->port, GC_PSX_CLOCK | GC_PSX_SELECT | GC_PSX_POWER);
 
-        for(i = 0; i < GC_MAX_DEVICES; i++)                                                             /* Set id's to the real value */
+        /* Set id's to the real value */
+        for (i = 0; i < GC_MAX_DEVICES; i++)
                 id[i] = GC_PSX_ID(id[i]);
 }
 
-static void gc_psx_process_packet(struct gc *gc)
+static void gc_psx_report_one(struct gc_pad *pad, unsigned char psx_type,
+                              unsigned char *data)
 {
-        unsigned char data[GC_MAX_DEVICES][GC_PSX_BYTES];
-        unsigned char id[GC_MAX_DEVICES];
-        struct input_dev *dev;
-        int i, j;
+        struct input_dev *dev = pad->dev;
+        int i;
 
-        gc_psx_read_packet(gc, data, id);
+        switch (psx_type) {
 
-        for (i = 0; i < GC_MAX_DEVICES; i++) {
+        case GC_PSX_RUMBLE:
 
-                dev = gc->dev[i];
-                if (!dev)
-                        continue;
+                input_report_key(dev, BTN_THUMBL, ~data[0] & 0x04);
+                input_report_key(dev, BTN_THUMBR, ~data[0] & 0x02);
 
-                switch (id[i]) {
+        case GC_PSX_NEGCON:
+        case GC_PSX_ANALOG:
 
-                        case GC_PSX_RUMBLE:
+                if (pad->type == GC_DDR) {
+                        for (i = 0; i < 4; i++)
+                                input_report_key(dev, gc_psx_ddr_btn[i],
+                                                 ~data[0] & (0x10 << i));
+                } else {
+                        for (i = 0; i < 4; i++)
+                                input_report_abs(dev, gc_psx_abs[i + 2],
+                                                 data[i + 2]);
 
-                                input_report_key(dev, BTN_THUMBL, ~data[i][0] & 0x04);
-                                input_report_key(dev, BTN_THUMBR, ~data[i][0] & 0x02);
+                        input_report_abs(dev, ABS_X,
+                                !!(data[0] & 0x80) * 128 + !(data[0] & 0x20) * 127);
+                        input_report_abs(dev, ABS_Y,
+                                !!(data[0] & 0x10) * 128 + !(data[0] & 0x40) * 127);
+                }
 
-                        case GC_PSX_NEGCON:
-                        case GC_PSX_ANALOG:
+                for (i = 0; i < 8; i++)
+                        input_report_key(dev, gc_psx_btn[i], ~data[1] & (1 << i));
 
-                                if (gc->pads[GC_DDR] & gc_status_bit[i]) {
-                                        for(j = 0; j < 4; j++)
-                                                input_report_key(dev, gc_psx_ddr_btn[j], ~data[i][0] & (0x10 << j));
-                                } else {
-                                        for (j = 0; j < 4; j++)
-                                                input_report_abs(dev, gc_psx_abs[j + 2], data[i][j + 2]);
+                input_report_key(dev, BTN_START,  ~data[0] & 0x08);
+                input_report_key(dev, BTN_SELECT, ~data[0] & 0x01);
 
-                                        input_report_abs(dev, ABS_X, 128 + !(data[i][0] & 0x20) * 127 - !(data[i][0] & 0x80) * 128);
-                                        input_report_abs(dev, ABS_Y, 128 + !(data[i][0] & 0x40) * 127 - !(data[i][0] & 0x10) * 128);
-                                }
+                input_sync(dev);
 
-                                for (j = 0; j < 8; j++)
-                                        input_report_key(dev, gc_psx_btn[j], ~data[i][1] & (1 << j));
+                break;
 
-                                input_report_key(dev, BTN_START,  ~data[i][0] & 0x08);
-                                input_report_key(dev, BTN_SELECT, ~data[i][0] & 0x01);
+        case GC_PSX_NORMAL:
 
-                                input_sync(dev);
+                if (pad->type == GC_DDR) {
+                        for (i = 0; i < 4; i++)
+                                input_report_key(dev, gc_psx_ddr_btn[i],
+                                                 ~data[0] & (0x10 << i));
+                } else {
+                        input_report_abs(dev, ABS_X,
+                                !!(data[0] & 0x80) * 128 + !(data[0] & 0x20) * 127);
+                        input_report_abs(dev, ABS_Y,
+                                !!(data[0] & 0x10) * 128 + !(data[0] & 0x40) * 127);
 
-                                break;
-
-                        case GC_PSX_NORMAL:
-                                if (gc->pads[GC_DDR] & gc_status_bit[i]) {
-                                        for(j = 0; j < 4; j++)
-                                                input_report_key(dev, gc_psx_ddr_btn[j], ~data[i][0] & (0x10 << j));
-                                } else {
-                                        input_report_abs(dev, ABS_X, 128 + !(data[i][0] & 0x20) * 127 - !(data[i][0] & 0x80) * 128);
-                                        input_report_abs(dev, ABS_Y, 128 + !(data[i][0] & 0x40) * 127 - !(data[i][0] & 0x10) * 128);
-
-                                        /* for some reason if the extra axes are left unset they drift */
-                                        /* for (j = 0; j < 4; j++)
-                                                input_report_abs(dev, gc_psx_abs[j + 2], 128);
-                                         * This needs to be debugged properly,
-                                         * maybe fuzz processing needs to be done in input_sync()
-                                         *                               --vojtech
-                                         */
-                                }
+                        /*
+                         * For some reason if the extra axes are left unset
+                         * they drift.
+                         * for (i = 0; i < 4; i++)
+                                input_report_abs(dev, gc_psx_abs[i + 2], 128);
+                         * This needs to be debugged properly,
+                         * maybe fuzz processing needs to be done
+                         * in input_sync()
+                         *                               --vojtech
+                         */
+                }
 
-                                for (j = 0; j < 8; j++)
-                                        input_report_key(dev, gc_psx_btn[j], ~data[i][1] & (1 << j));
+                for (i = 0; i < 8; i++)
+                        input_report_key(dev, gc_psx_btn[i], ~data[1] & (1 << i));
 
-                                input_report_key(dev, BTN_START,  ~data[i][0] & 0x08);
-                                input_report_key(dev, BTN_SELECT, ~data[i][0] & 0x01);
+                input_report_key(dev, BTN_START,  ~data[0] & 0x08);
+                input_report_key(dev, BTN_SELECT, ~data[0] & 0x01);
 
-                                input_sync(dev);
+                input_sync(dev);
 
-                                break;
+                break;
 
-                        case 0: /* not a pad, ignore */
-                                break;
-                }
+        default: /* not a pad, ignore */
+                break;
+        }
+}
+
+static void gc_psx_process_packet(struct gc *gc)
+{
+        unsigned char data[GC_MAX_DEVICES][GC_PSX_BYTES];
+        unsigned char id[GC_MAX_DEVICES];
+        struct gc_pad *pad;
+        int i;
+
+        gc_psx_read_packet(gc, data, id);
+
+        for (i = 0; i < GC_MAX_DEVICES; i++) {
+                pad = &gc->pads[i];
+                if (pad->type == GC_PSX || pad->type == GC_DDR)
+                        gc_psx_report_one(pad, id[i], data[i]);
         }
 }
 
@@ -561,28 +751,31 @@ static void gc_timer(unsigned long private)
  * N64 pads - must be read first, any read confuses them for 200 us
  */
 
-        if (gc->pads[GC_N64])
+        if (gc->pad_count[GC_N64])
                 gc_n64_process_packet(gc);
 
 /*
  * NES and SNES pads or mouse
  */
 
-        if (gc->pads[GC_NES] || gc->pads[GC_SNES] || gc->pads[GC_SNESMOUSE])
+        if (gc->pad_count[GC_NES] ||
+            gc->pad_count[GC_SNES] ||
+            gc->pad_count[GC_SNESMOUSE]) {
                 gc_nes_process_packet(gc);
+        }
 
 /*
  * Multi and Multi2 joysticks
  */
 
-        if (gc->pads[GC_MULTI] || gc->pads[GC_MULTI2])
+        if (gc->pad_count[GC_MULTI] || gc->pad_count[GC_MULTI2])
                 gc_multi_process_packet(gc);
 
 /*
  * PSX controllers
  */
 
-        if (gc->pads[GC_PSX] || gc->pads[GC_DDR])
+        if (gc->pad_count[GC_PSX] || gc->pad_count[GC_DDR])
                 gc_psx_process_packet(gc);
 
         mod_timer(&gc->timer, jiffies + GC_REFRESH_TIME);
@@ -622,25 +815,29 @@ static void gc_close(struct input_dev *dev)
 
 static int __init gc_setup_pad(struct gc *gc, int idx, int pad_type)
 {
+        struct gc_pad *pad = &gc->pads[idx];
         struct input_dev *input_dev;
         int i;
+        int err;
 
-        if (!pad_type)
-                return 0;
-
-        if (pad_type < 1 || pad_type > GC_MAX) {
-                printk(KERN_WARNING "gamecon.c: Pad type %d unknown\n", pad_type);
+        if (pad_type < 1 || pad_type >= GC_MAX) {
+                pr_err("Pad type %d unknown\n", pad_type);
                 return -EINVAL;
         }
 
-        gc->dev[idx] = input_dev = input_allocate_device();
+        pad->dev = input_dev = input_allocate_device();
         if (!input_dev) {
-                printk(KERN_ERR "gamecon.c: Not enough memory for input device\n");
+                pr_err("Not enough memory for input device\n");
                 return -ENOMEM;
         }
 
+        pad->type = pad_type;
+
+        snprintf(pad->phys, sizeof(pad->phys),
+                 "%s/input%d", gc->pd->port->name, idx);
+
         input_dev->name = gc_names[pad_type];
-        input_dev->phys = gc->phys[idx];
+        input_dev->phys = pad->phys;
         input_dev->id.bustype = BUS_PARPORT;
         input_dev->id.vendor = 0x0001;
         input_dev->id.product = pad_type;
@@ -659,61 +856,76 @@ static int __init gc_setup_pad(struct gc *gc, int idx, int pad_type)
         } else
                 input_dev->evbit[0] = BIT_MASK(EV_KEY) | BIT_MASK(EV_REL);
 
-        gc->pads[0] |= gc_status_bit[idx];
-        gc->pads[pad_type] |= gc_status_bit[idx];
+        gc->pad_count[pad_type]++;
 
         switch (pad_type) {
 
-                case GC_N64:
-                        for (i = 0; i < 10; i++)
-                                set_bit(gc_n64_btn[i], input_dev->keybit);
-
-                        for (i = 0; i < 2; i++) {
-                                input_set_abs_params(input_dev, ABS_X + i, -127, 126, 0, 2);
-                                input_set_abs_params(input_dev, ABS_HAT0X + i, -1, 1, 0, 0);
-                        }
-
-                        break;
-
-                case GC_SNESMOUSE:
-                        set_bit(BTN_LEFT, input_dev->keybit);
-                        set_bit(BTN_RIGHT, input_dev->keybit);
-                        set_bit(REL_X, input_dev->relbit);
-                        set_bit(REL_Y, input_dev->relbit);
-                        break;
-
-                case GC_SNES:
-                        for (i = 4; i < 8; i++)
-                                set_bit(gc_snes_btn[i], input_dev->keybit);
-                case GC_NES:
-                        for (i = 0; i < 4; i++)
-                                set_bit(gc_snes_btn[i], input_dev->keybit);
-                        break;
-
-                case GC_MULTI2:
-                        set_bit(BTN_THUMB, input_dev->keybit);
-                case GC_MULTI:
-                        set_bit(BTN_TRIGGER, input_dev->keybit);
-                        break;
-
-                case GC_PSX:
-                        for (i = 0; i < 6; i++)
-                                input_set_abs_params(input_dev, gc_psx_abs[i], 4, 252, 0, 2);
-                        for (i = 0; i < 12; i++)
-                                set_bit(gc_psx_btn[i], input_dev->keybit);
+        case GC_N64:
+                for (i = 0; i < 10; i++)
+                        __set_bit(gc_n64_btn[i], input_dev->keybit);
 
-                        break;
+                for (i = 0; i < 2; i++) {
+                        input_set_abs_params(input_dev, ABS_X + i, -127, 126, 0, 2);
+                        input_set_abs_params(input_dev, ABS_HAT0X + i, -1, 1, 0, 0);
+                }
 
-                case GC_DDR:
-                        for (i = 0; i < 4; i++)
-                                set_bit(gc_psx_ddr_btn[i], input_dev->keybit);
-                        for (i = 0; i < 12; i++)
-                                set_bit(gc_psx_btn[i], input_dev->keybit);
+                err = gc_n64_init_ff(input_dev, idx);
+                if (err) {
+                        pr_warning("Failed to initiate rumble for N64 device %d\n", idx);
+                        goto err_free_dev;
+                }
 
-                        break;
+                break;
+
+        case GC_SNESMOUSE:
+                __set_bit(BTN_LEFT, input_dev->keybit);
+                __set_bit(BTN_RIGHT, input_dev->keybit);
+                __set_bit(REL_X, input_dev->relbit);
+                __set_bit(REL_Y, input_dev->relbit);
+                break;
+
+        case GC_SNES:
+                for (i = 4; i < 8; i++)
+                        __set_bit(gc_snes_btn[i], input_dev->keybit);
+        case GC_NES:
+                for (i = 0; i < 4; i++)
+                        __set_bit(gc_snes_btn[i], input_dev->keybit);
+                break;
+
+        case GC_MULTI2:
+                __set_bit(BTN_THUMB, input_dev->keybit);
+        case GC_MULTI:
+                __set_bit(BTN_TRIGGER, input_dev->keybit);
+                break;
+
+        case GC_PSX:
+                for (i = 0; i < 6; i++)
+                        input_set_abs_params(input_dev,
+                                             gc_psx_abs[i], 4, 252, 0, 2);
+                for (i = 0; i < 12; i++)
+                        __set_bit(gc_psx_btn[i], input_dev->keybit);
+
+                break;
+
+        case GC_DDR:
+                for (i = 0; i < 4; i++)
+                        __set_bit(gc_psx_ddr_btn[i], input_dev->keybit);
+                for (i = 0; i < 12; i++)
+                        __set_bit(gc_psx_btn[i], input_dev->keybit);
+
+                break;
         }
 
+        err = input_register_device(pad->dev);
+        if (err)
+                goto err_free_dev;
+
         return 0;
+
+err_free_dev:
+        input_free_device(pad->dev);
+        pad->dev = NULL;
+        return err;
 }
 
 static struct gc __init *gc_probe(int parport, int *pads, int n_pads)
@@ -722,52 +934,47 @@ static struct gc __init *gc_probe(int parport, int *pads, int n_pads)
         struct parport *pp;
         struct pardevice *pd;
         int i;
+        int count = 0;
         int err;
 
         pp = parport_find_number(parport);
         if (!pp) {
-                printk(KERN_ERR "gamecon.c: no such parport\n");
+                pr_err("no such parport %d\n", parport);
                 err = -EINVAL;
                 goto err_out;
         }
 
         pd = parport_register_device(pp, "gamecon", NULL, NULL, NULL, PARPORT_DEV_EXCL, NULL);
         if (!pd) {
-                printk(KERN_ERR "gamecon.c: parport busy already - lp.o loaded?\n");
+                pr_err("parport busy already - lp.o loaded?\n");
                 err = -EBUSY;
                 goto err_put_pp;
         }
 
         gc = kzalloc(sizeof(struct gc), GFP_KERNEL);
         if (!gc) {
-                printk(KERN_ERR "gamecon.c: Not enough memory\n");
+                pr_err("Not enough memory\n");
                 err = -ENOMEM;
                 goto err_unreg_pardev;
         }
 
         mutex_init(&gc->mutex);
         gc->pd = pd;
-        init_timer(&gc->timer);
-        gc->timer.data = (long) gc;
-        gc->timer.function = gc_timer;
+        setup_timer(&gc->timer, gc_timer, (long) gc);
 
         for (i = 0; i < n_pads && i < GC_MAX_DEVICES; i++) {
                 if (!pads[i])
                         continue;
 
-                snprintf(gc->phys[i], sizeof(gc->phys[i]),
-                         "%s/input%d", gc->pd->port->name, i);
                 err = gc_setup_pad(gc, i, pads[i]);
                 if (err)
                         goto err_unreg_devs;
 
-                err = input_register_device(gc->dev[i]);
-                if (err)
-                        goto err_free_dev;
+                count++;
         }
 
-        if (!gc->pads[0]) {
-                printk(KERN_ERR "gamecon.c: No valid devices specified\n");
+        if (count == 0) {
+                pr_err("No valid devices specified\n");
                 err = -EINVAL;
                 goto err_free_gc;
         }
@@ -775,12 +982,10 @@ static struct gc __init *gc_probe(int parport, int *pads, int n_pads)
         parport_put_port(pp);
         return gc;
 
- err_free_dev:
-        input_free_device(gc->dev[i]);
  err_unreg_devs:
         while (--i >= 0)
-                if (gc->dev[i])
-                        input_unregister_device(gc->dev[i]);
+                if (gc->pads[i].dev)
+                        input_unregister_device(gc->pads[i].dev);
  err_free_gc:
         kfree(gc);
  err_unreg_pardev:
@@ -796,8 +1001,8 @@ static void gc_remove(struct gc *gc)
         int i;
 
         for (i = 0; i < GC_MAX_DEVICES; i++)
-                if (gc->dev[i])
-                        input_unregister_device(gc->dev[i]);
+                if (gc->pads[i].dev)
+                        input_unregister_device(gc->pads[i].dev);
         parport_unregister_device(gc->pd);
         kfree(gc);
 }
@@ -813,7 +1018,7 @@ static int __init gc_init(void)
                         continue;
 
                 if (gc_cfg[i].nargs < 2) {
-                        printk(KERN_ERR "gamecon.c: at least one device must be specified\n");
+                        pr_err("at least one device must be specified\n");
                         err = -EINVAL;
                         break;
                 }
diff --git a/drivers/input/joystick/gf2k.c b/drivers/input/joystick/gf2k.c
index 67c207f5b1a1..45ac70eae0aa 100644
--- a/drivers/input/joystick/gf2k.c
+++ b/drivers/input/joystick/gf2k.c
@@ -277,7 +277,7 @@ static int gf2k_connect(struct gameport *gameport, struct gameport_driver *drv)
         }
 
 #ifdef RESET_WORKS
-        if ((gf2k->id != (GB(19,2,0) | GB(15,3,2) | GB(12,3,5))) ||
+        if ((gf2k->id != (GB(19,2,0) | GB(15,3,2) | GB(12,3,5))) &&
             (gf2k->id != (GB(31,2,0) | GB(27,3,2) | GB(24,3,5)))) {
                 err = -ENODEV;
                 goto fail2;
diff --git a/drivers/input/joystick/iforce/iforce-main.c b/drivers/input/joystick/iforce/iforce-main.c
index f6c688cae334..b1edd778639c 100644
--- a/drivers/input/joystick/iforce/iforce-main.c
+++ b/drivers/input/joystick/iforce/iforce-main.c
@@ -210,7 +210,7 @@ static int iforce_open(struct input_dev *dev)
         return 0;
 }
 
-static void iforce_release(struct input_dev *dev)
+static void iforce_close(struct input_dev *dev)
 {
         struct iforce *iforce = input_get_drvdata(dev);
         int i;
@@ -228,30 +228,17 @@ static void iforce_release(struct input_dev *dev)
 
                 /* Disable force feedback playback */
                 iforce_send_packet(iforce, FF_CMD_ENABLE, "\001");
+                /* Wait for the command to complete */
+                wait_event_interruptible(iforce->wait,
+                        !test_bit(IFORCE_XMIT_RUNNING, iforce->xmit_flags));
         }
 
         switch (iforce->bus) {
 #ifdef CONFIG_JOYSTICK_IFORCE_USB
-                case IFORCE_USB:
-                        usb_kill_urb(iforce->irq);
-
-                        /* The device was unplugged before the file
-                         * was released */
-                        if (iforce->usbdev == NULL) {
-                                iforce_delete_device(iforce);
-                                kfree(iforce);
-                        }
-                break;
-#endif
-        }
-}
-
-void iforce_delete_device(struct iforce *iforce)
-{
-        switch (iforce->bus) {
-#ifdef CONFIG_JOYSTICK_IFORCE_USB
         case IFORCE_USB:
-                iforce_usb_delete(iforce);
+                usb_kill_urb(iforce->irq);
+                usb_kill_urb(iforce->out);
+                usb_kill_urb(iforce->ctrl);
                 break;
 #endif
 #ifdef CONFIG_JOYSTICK_IFORCE_232
@@ -303,7 +290,7 @@ int iforce_init_device(struct iforce *iforce)
 
         input_dev->name = "Unknown I-Force device";
         input_dev->open = iforce_open;
-        input_dev->close = iforce_release;
+        input_dev->close = iforce_close;
 
 /*
  * On-device memory allocation.
diff --git a/drivers/input/joystick/iforce/iforce-usb.c b/drivers/input/joystick/iforce/iforce-usb.c
index 9f289d8f52c6..b41303d3ec54 100644
--- a/drivers/input/joystick/iforce/iforce-usb.c
+++ b/drivers/input/joystick/iforce/iforce-usb.c
@@ -109,6 +109,7 @@ static void iforce_usb_out(struct urb *urb)
         struct iforce *iforce = urb->context;
 
         if (urb->status) {
+                clear_bit(IFORCE_XMIT_RUNNING, iforce->xmit_flags);
                 dbg("urb->status %d, exiting", urb->status);
                 return;
         }
@@ -186,33 +187,19 @@ fail:
         return err;
 }
 
-/* Called by iforce_delete() */
-void iforce_usb_delete(struct iforce* iforce)
-{
-        usb_kill_urb(iforce->irq);
-        usb_kill_urb(iforce->out);
-        usb_kill_urb(iforce->ctrl);
-
-        usb_free_urb(iforce->irq);
-        usb_free_urb(iforce->out);
-        usb_free_urb(iforce->ctrl);
-}
-
 static void iforce_usb_disconnect(struct usb_interface *intf)
 {
         struct iforce *iforce = usb_get_intfdata(intf);
-        int open = 0; /* FIXME! iforce->dev.handle->open; */
 
         usb_set_intfdata(intf, NULL);
-        if (iforce) {
-                iforce->usbdev = NULL;
-                input_unregister_device(iforce->dev);
 
-                if (!open) {
-                        iforce_delete_device(iforce);
-                        kfree(iforce);
-                }
-        }
+        input_unregister_device(iforce->dev);
+
+        usb_free_urb(iforce->irq);
+        usb_free_urb(iforce->out);
+        usb_free_urb(iforce->ctrl);
+
+        kfree(iforce);
 }
 
 static struct usb_device_id iforce_usb_ids [] = {
diff --git a/drivers/input/joystick/iforce/iforce.h b/drivers/input/joystick/iforce/iforce.h
index f2d91f4028ca..9f494b75848a 100644
--- a/drivers/input/joystick/iforce/iforce.h
+++ b/drivers/input/joystick/iforce/iforce.h
@@ -150,11 +150,9 @@ void iforce_serial_xmit(struct iforce *iforce);
 
 /* iforce-usb.c */
 void iforce_usb_xmit(struct iforce *iforce);
-void iforce_usb_delete(struct iforce *iforce);
 
 /* iforce-main.c */
 int iforce_init_device(struct iforce *iforce);
-void iforce_delete_device(struct iforce *iforce);
 
 /* iforce-packets.c */
 int iforce_control_playback(struct iforce*, u16 id, unsigned int);
diff --git a/drivers/input/joystick/turbografx.c b/drivers/input/joystick/turbografx.c
index b6f859869540..d53b9e900234 100644
--- a/drivers/input/joystick/turbografx.c
+++ b/drivers/input/joystick/turbografx.c
@@ -35,6 +35,7 @@
 #include <linux/module.h>
 #include <linux/init.h>
 #include <linux/mutex.h>
+#include <linux/slab.h>
 
 MODULE_AUTHOR("Vojtech Pavlik <vojtech@ucw.cz>");
 MODULE_DESCRIPTION("TurboGraFX parallel port interface driver");
diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c
index 79e3edcced1a..9b3353b404da 100644
--- a/drivers/input/joystick/xpad.c
+++ b/drivers/input/joystick/xpad.c
@@ -86,9 +86,8 @@
 
 /* xbox d-pads should map to buttons, as is required for DDR pads
    but we map them to axes when possible to simplify things */
-#define MAP_DPAD_TO_BUTTONS    0
-#define MAP_DPAD_TO_AXES       1
-#define MAP_DPAD_UNKNOWN       2
+#define MAP_DPAD_TO_BUTTONS             (1 << 0)
+#define MAP_TRIGGERS_TO_BUTTONS         (1 << 1)
 
 #define XTYPE_XBOX        0
 #define XTYPE_XBOX360     1
@@ -99,55 +98,61 @@ static int dpad_to_buttons;
 module_param(dpad_to_buttons, bool, S_IRUGO);
 MODULE_PARM_DESC(dpad_to_buttons, "Map D-PAD to buttons rather than axes for unknown pads");
 
+static int triggers_to_buttons;
+module_param(triggers_to_buttons, bool, S_IRUGO);
+MODULE_PARM_DESC(triggers_to_buttons, "Map triggers to buttons rather than axes for unknown pads");
+
 static const struct xpad_device {
         u16 idVendor;
         u16 idProduct;
         char *name;
-        u8 dpad_mapping;
+        u8 mapping;
         u8 xtype;
 } xpad_device[] = {
-        { 0x045e, 0x0202, "Microsoft X-Box pad v1 (US)", MAP_DPAD_TO_AXES, XTYPE_XBOX },
-        { 0x045e, 0x0289, "Microsoft X-Box pad v2 (US)", MAP_DPAD_TO_AXES, XTYPE_XBOX },
-        { 0x045e, 0x0285, "Microsoft X-Box pad (Japan)", MAP_DPAD_TO_AXES, XTYPE_XBOX },
-        { 0x045e, 0x0287, "Microsoft Xbox Controller S", MAP_DPAD_TO_AXES, XTYPE_XBOX },
+        { 0x045e, 0x0202, "Microsoft X-Box pad v1 (US)", 0, XTYPE_XBOX },
+        { 0x045e, 0x0289, "Microsoft X-Box pad v2 (US)", 0, XTYPE_XBOX },
+        { 0x045e, 0x0285, "Microsoft X-Box pad (Japan)", 0, XTYPE_XBOX },
+        { 0x045e, 0x0287, "Microsoft Xbox Controller S", 0, XTYPE_XBOX },
         { 0x045e, 0x0719, "Xbox 360 Wireless Receiver", MAP_DPAD_TO_BUTTONS, XTYPE_XBOX360W },
         { 0x0c12, 0x8809, "RedOctane Xbox Dance Pad", MAP_DPAD_TO_BUTTONS, XTYPE_XBOX },
-        { 0x044f, 0x0f07, "Thrustmaster, Inc. Controller", MAP_DPAD_TO_AXES, XTYPE_XBOX },
-        { 0x046d, 0xc242, "Logitech Chillstream Controller", MAP_DPAD_TO_AXES, XTYPE_XBOX360 },
-        { 0x046d, 0xca84, "Logitech Xbox Cordless Controller", MAP_DPAD_TO_AXES, XTYPE_XBOX },
-        { 0x046d, 0xca88, "Logitech Compact Controller for Xbox", MAP_DPAD_TO_AXES, XTYPE_XBOX },
-        { 0x05fd, 0x1007, "Mad Catz Controller (unverified)", MAP_DPAD_TO_AXES, XTYPE_XBOX },
-        { 0x05fd, 0x107a, "InterAct 'PowerPad Pro' X-Box pad (Germany)", MAP_DPAD_TO_AXES, XTYPE_XBOX },
-        { 0x0738, 0x4516, "Mad Catz Control Pad", MAP_DPAD_TO_AXES, XTYPE_XBOX },
-        { 0x0738, 0x4522, "Mad Catz LumiCON", MAP_DPAD_TO_AXES, XTYPE_XBOX },
-        { 0x0738, 0x4526, "Mad Catz Control Pad Pro", MAP_DPAD_TO_AXES, XTYPE_XBOX },
-        { 0x0738, 0x4536, "Mad Catz MicroCON", MAP_DPAD_TO_AXES, XTYPE_XBOX },
+        { 0x044f, 0x0f07, "Thrustmaster, Inc. Controller", 0, XTYPE_XBOX },
+        { 0x046d, 0xc242, "Logitech Chillstream Controller", 0, XTYPE_XBOX360 },
+        { 0x046d, 0xca84, "Logitech Xbox Cordless Controller", 0, XTYPE_XBOX },
+        { 0x046d, 0xca88, "Logitech Compact Controller for Xbox", 0, XTYPE_XBOX },
+        { 0x05fd, 0x1007, "Mad Catz Controller (unverified)", 0, XTYPE_XBOX },
+        { 0x05fd, 0x107a, "InterAct 'PowerPad Pro' X-Box pad (Germany)", 0, XTYPE_XBOX },
+        { 0x0738, 0x4516, "Mad Catz Control Pad", 0, XTYPE_XBOX },
+        { 0x0738, 0x4522, "Mad Catz LumiCON", 0, XTYPE_XBOX },
+        { 0x0738, 0x4526, "Mad Catz Control Pad Pro", 0, XTYPE_XBOX },
+        { 0x0738, 0x4536, "Mad Catz MicroCON", 0, XTYPE_XBOX },
         { 0x0738, 0x4540, "Mad Catz Beat Pad", MAP_DPAD_TO_BUTTONS, XTYPE_XBOX },
-        { 0x0738, 0x4556, "Mad Catz Lynx Wireless Controller", MAP_DPAD_TO_AXES, XTYPE_XBOX },
-        { 0x0738, 0x4716, "Mad Catz Wired Xbox 360 Controller", MAP_DPAD_TO_AXES, XTYPE_XBOX360 },
+        { 0x0738, 0x4556, "Mad Catz Lynx Wireless Controller", 0, XTYPE_XBOX },
+        { 0x0738, 0x4716, "Mad Catz Wired Xbox 360 Controller", 0, XTYPE_XBOX360 },
+        { 0x0738, 0x4738, "Mad Catz Wired Xbox 360 Controller (SFIV)", MAP_TRIGGERS_TO_BUTTONS, XTYPE_XBOX360 },
         { 0x0738, 0x6040, "Mad Catz Beat Pad Pro", MAP_DPAD_TO_BUTTONS, XTYPE_XBOX },
-        { 0x0c12, 0x8802, "Zeroplus Xbox Controller", MAP_DPAD_TO_AXES, XTYPE_XBOX },
-        { 0x0c12, 0x880a, "Pelican Eclipse PL-2023", MAP_DPAD_TO_AXES, XTYPE_XBOX },
-        { 0x0c12, 0x8810, "Zeroplus Xbox Controller", MAP_DPAD_TO_AXES, XTYPE_XBOX },
-        { 0x0c12, 0x9902, "HAMA VibraX - *FAULTY HARDWARE*", MAP_DPAD_TO_AXES, XTYPE_XBOX },
-        { 0x0e4c, 0x1097, "Radica Gamester Controller", MAP_DPAD_TO_AXES, XTYPE_XBOX },
-        { 0x0e4c, 0x2390, "Radica Games Jtech Controller", MAP_DPAD_TO_AXES, XTYPE_XBOX },
-        { 0x0e6f, 0x0003, "Logic3 Freebird wireless Controller", MAP_DPAD_TO_AXES, XTYPE_XBOX },
-        { 0x0e6f, 0x0005, "Eclipse wireless Controller", MAP_DPAD_TO_AXES, XTYPE_XBOX },
-        { 0x0e6f, 0x0006, "Edge wireless Controller", MAP_DPAD_TO_AXES, XTYPE_XBOX },
-        { 0x0e6f, 0x0006, "Pelican 'TSZ' Wired Xbox 360 Controller", MAP_DPAD_TO_AXES, XTYPE_XBOX360 },
-        { 0x0e8f, 0x0201, "SmartJoy Frag Xpad/PS2 adaptor", MAP_DPAD_TO_AXES, XTYPE_XBOX },
-        { 0x0f30, 0x0202, "Joytech Advanced Controller", MAP_DPAD_TO_AXES, XTYPE_XBOX },
-        { 0x0f30, 0x8888, "BigBen XBMiniPad Controller", MAP_DPAD_TO_AXES, XTYPE_XBOX },
-        { 0x102c, 0xff0c, "Joytech Wireless Advanced Controller", MAP_DPAD_TO_AXES, XTYPE_XBOX },
+        { 0x0c12, 0x8802, "Zeroplus Xbox Controller", 0, XTYPE_XBOX },
+        { 0x0c12, 0x880a, "Pelican Eclipse PL-2023", 0, XTYPE_XBOX },
+        { 0x0c12, 0x8810, "Zeroplus Xbox Controller", 0, XTYPE_XBOX },
+        { 0x0c12, 0x9902, "HAMA VibraX - *FAULTY HARDWARE*", 0, XTYPE_XBOX },
+        { 0x0e4c, 0x1097, "Radica Gamester Controller", 0, XTYPE_XBOX },
+        { 0x0e4c, 0x2390, "Radica Games Jtech Controller", 0, XTYPE_XBOX },
+        { 0x0e6f, 0x0003, "Logic3 Freebird wireless Controller", 0, XTYPE_XBOX },
+        { 0x0e6f, 0x0005, "Eclipse wireless Controller", 0, XTYPE_XBOX },
+        { 0x0e6f, 0x0006, "Edge wireless Controller", 0, XTYPE_XBOX },
+        { 0x0e6f, 0x0006, "Pelican 'TSZ' Wired Xbox 360 Controller", 0, XTYPE_XBOX360 },
+        { 0x0e8f, 0x0201, "SmartJoy Frag Xpad/PS2 adaptor", 0, XTYPE_XBOX },
+        { 0x0f30, 0x0202, "Joytech Advanced Controller", 0, XTYPE_XBOX },
+        { 0x0f30, 0x8888, "BigBen XBMiniPad Controller", 0, XTYPE_XBOX },
+        { 0x102c, 0xff0c, "Joytech Wireless Advanced Controller", 0, XTYPE_XBOX },
         { 0x12ab, 0x8809, "Xbox DDR dancepad", MAP_DPAD_TO_BUTTONS, XTYPE_XBOX },
-        { 0x1430, 0x4748, "RedOctane Guitar Hero X-plorer", MAP_DPAD_TO_AXES, XTYPE_XBOX360 },
+        { 0x1430, 0x4748, "RedOctane Guitar Hero X-plorer", 0, XTYPE_XBOX360 },
         { 0x1430, 0x8888, "TX6500+ Dance Pad (first generation)", MAP_DPAD_TO_BUTTONS, XTYPE_XBOX },
-        { 0x146b, 0x0601, "BigBen Interactive XBOX 360 Controller", MAP_DPAD_TO_AXES, XTYPE_XBOX360 },
-        { 0x045e, 0x028e, "Microsoft X-Box 360 pad", MAP_DPAD_TO_AXES, XTYPE_XBOX360 },
+        { 0x146b, 0x0601, "BigBen Interactive XBOX 360 Controller", 0, XTYPE_XBOX360 },
+        { 0x045e, 0x028e, "Microsoft X-Box 360 pad", 0, XTYPE_XBOX360 },
         { 0x1bad, 0x0003, "Harmonix Rock Band Drumkit", MAP_DPAD_TO_BUTTONS, XTYPE_XBOX360 },
-        { 0xffff, 0xffff, "Chinese-made Xbox Controller", MAP_DPAD_TO_AXES, XTYPE_XBOX },
-        { 0x0000, 0x0000, "Generic X-Box pad", MAP_DPAD_UNKNOWN, XTYPE_UNKNOWN }
+        { 0x0f0d, 0x0016, "Hori Real Arcade Pro.EX", MAP_TRIGGERS_TO_BUTTONS, XTYPE_XBOX360 },
+        { 0xffff, 0xffff, "Chinese-made Xbox Controller", 0, XTYPE_XBOX },
+        { 0x0000, 0x0000, "Generic X-Box pad", 0, XTYPE_UNKNOWN }
 };
 
 /* buttons shared with xbox and xbox360 */
@@ -163,13 +168,20 @@ static const signed short xpad_btn[] = {
         -1                      /* terminating entry */
 };
 
-/* only used if MAP_DPAD_TO_BUTTONS */
+/* used when dpad is mapped to nuttons */
 static const signed short xpad_btn_pad[] = {
         BTN_LEFT, BTN_RIGHT,            /* d-pad left, right */
         BTN_0, BTN_1,                   /* d-pad up, down (XXX names??) */
         -1                              /* terminating entry */
 };
 
+/* used when triggers are mapped to buttons */
+static const signed short xpad_btn_triggers[] = {
+        BTN_TL2, BTN_TR2,               /* triggers left/right */
+        -1
+};
+
+
 static const signed short xpad360_btn[] = {  /* buttons for x360 controller */
         BTN_TL, BTN_TR,         /* Button LB/RB */
         BTN_MODE,               /* The big X button */
@@ -179,16 +191,21 @@ static const signed short xpad360_btn[] = {  /* buttons for x360 controller */
 static const signed short xpad_abs[] = {
         ABS_X, ABS_Y,           /* left stick */
         ABS_RX, ABS_RY,         /* right stick */
-        ABS_Z, ABS_RZ,          /* triggers left/right */
         -1                      /* terminating entry */
 };
 
-/* only used if MAP_DPAD_TO_AXES */
+/* used when dpad is mapped to axes */
 static const signed short xpad_abs_pad[] = {
         ABS_HAT0X, ABS_HAT0Y,   /* d-pad axes */
         -1                      /* terminating entry */
 };
 
+/* used when triggers are mapped to axes */
+static const signed short xpad_abs_triggers[] = {
+        ABS_Z, ABS_RZ,          /* triggers left/right */
+        -1
+};
+
 /* Xbox 360 has a vendor-specific class, so we cannot match it with only
  * USB_INTERFACE_INFO (also specifically refused by USB subsystem), so we
  * match against vendor id as well. Wired Xbox 360 devices have protocol 1,
@@ -212,6 +229,7 @@ static struct usb_device_id xpad_table [] = {
         XPAD_XBOX360_VENDOR(0x1430),            /* RedOctane X-Box 360 controllers */
         XPAD_XBOX360_VENDOR(0x146b),            /* BigBen Interactive Controllers */
         XPAD_XBOX360_VENDOR(0x1bad),            /* Rock Band Drums */
+        XPAD_XBOX360_VENDOR(0x0f0d),            /* Hori Controllers */
         { }
 };
 
@@ -243,7 +261,7 @@ struct usb_xpad {
 
         char phys[64];                  /* physical device path */
 
-        int dpad_mapping;               /* map d-pad to buttons or to axes */
+        int mapping;                    /* map d-pad to buttons or to axes */
         int xtype;                      /* type of xbox device */
 };
 
@@ -274,20 +292,25 @@ static void xpad_process_packet(struct usb_xpad *xpad, u16 cmd, unsigned char *d
                          ~(__s16) le16_to_cpup((__le16 *)(data + 18)));
 
         /* triggers left/right */
-        input_report_abs(dev, ABS_Z, data[10]);
-        input_report_abs(dev, ABS_RZ, data[11]);
+        if (xpad->mapping & MAP_TRIGGERS_TO_BUTTONS) {
+                input_report_key(dev, BTN_TL2, data[10]);
+                input_report_key(dev, BTN_TR2, data[11]);
+        } else {
+                input_report_abs(dev, ABS_Z, data[10]);
+                input_report_abs(dev, ABS_RZ, data[11]);
+        }
 
         /* digital pad */
-        if (xpad->dpad_mapping == MAP_DPAD_TO_AXES) {
-                input_report_abs(dev, ABS_HAT0X,
-                                 !!(data[2] & 0x08) - !!(data[2] & 0x04));
-                input_report_abs(dev, ABS_HAT0Y,
-                                 !!(data[2] & 0x02) - !!(data[2] & 0x01));
-        } else /* xpad->dpad_mapping == MAP_DPAD_TO_BUTTONS */ {
+        if (xpad->mapping & MAP_DPAD_TO_BUTTONS) {
                 input_report_key(dev, BTN_LEFT,  data[2] & 0x04);
                 input_report_key(dev, BTN_RIGHT, data[2] & 0x08);
                 input_report_key(dev, BTN_0,     data[2] & 0x01); /* up */
                 input_report_key(dev, BTN_1,     data[2] & 0x02); /* down */
+        } else {
+                input_report_abs(dev, ABS_HAT0X,
+                                 !!(data[2] & 0x08) - !!(data[2] & 0x04));
+                input_report_abs(dev, ABS_HAT0Y,
+                                 !!(data[2] & 0x02) - !!(data[2] & 0x01));
         }
 
         /* start/back buttons and stick press left/right */
@@ -325,17 +348,17 @@ static void xpad360_process_packet(struct usb_xpad *xpad,
         struct input_dev *dev = xpad->dev;
 
         /* digital pad */
-        if (xpad->dpad_mapping == MAP_DPAD_TO_AXES) {
-                input_report_abs(dev, ABS_HAT0X,
-                                 !!(data[2] & 0x08) - !!(data[2] & 0x04));
-                input_report_abs(dev, ABS_HAT0Y,
-                                 !!(data[2] & 0x02) - !!(data[2] & 0x01));
-        } else if (xpad->dpad_mapping == MAP_DPAD_TO_BUTTONS) {
+        if (xpad->mapping & MAP_DPAD_TO_BUTTONS) {
                 /* dpad as buttons (right, left, down, up) */
                 input_report_key(dev, BTN_LEFT, data[2] & 0x04);
                 input_report_key(dev, BTN_RIGHT, data[2] & 0x08);
                 input_report_key(dev, BTN_0, data[2] & 0x01);   /* up */
                 input_report_key(dev, BTN_1, data[2] & 0x02);   /* down */
+        } else {
+                input_report_abs(dev, ABS_HAT0X,
+                                 !!(data[2] & 0x08) - !!(data[2] & 0x04));
+                input_report_abs(dev, ABS_HAT0Y,
+                                 !!(data[2] & 0x02) - !!(data[2] & 0x01));
         }
 
         /* start/back buttons */
@@ -368,8 +391,13 @@ static void xpad360_process_packet(struct usb_xpad *xpad,
                          ~(__s16) le16_to_cpup((__le16 *)(data + 12)));
 
         /* triggers left/right */
-        input_report_abs(dev, ABS_Z, data[4]);
-        input_report_abs(dev, ABS_RZ, data[5]);
+        if (xpad->mapping & MAP_TRIGGERS_TO_BUTTONS) {
+                input_report_key(dev, BTN_TL2, data[4]);
+                input_report_key(dev, BTN_TR2, data[5]);
+        } else {
+                input_report_abs(dev, ABS_Z, data[4]);
+                input_report_abs(dev, ABS_RZ, data[5]);
+        }
 
         input_sync(dev);
 }
@@ -443,7 +471,7 @@ static void xpad_irq_in(struct urb *urb)
         }
 
 exit:
-        retval = usb_submit_urb (urb, GFP_ATOMIC);
+        retval = usb_submit_urb(urb, GFP_ATOMIC);
         if (retval)
                 err ("%s - usb_submit_urb failed with result %d",
                      __func__, retval);
@@ -502,7 +530,7 @@ static int xpad_init_output(struct usb_interface *intf, struct usb_xpad *xpad)
         struct usb_endpoint_descriptor *ep_irq_out;
         int error = -ENOMEM;
 
-        if (xpad->xtype != XTYPE_XBOX360)
+        if (xpad->xtype != XTYPE_XBOX360 && xpad->xtype != XTYPE_XBOX)
                 return 0;
 
         xpad->odata = usb_buffer_alloc(xpad->udev, XPAD_PKT_LEN,
@@ -532,13 +560,13 @@ static int xpad_init_output(struct usb_interface *intf, struct usb_xpad *xpad)
 
 static void xpad_stop_output(struct usb_xpad *xpad)
 {
-        if (xpad->xtype == XTYPE_XBOX360)
+        if (xpad->xtype == XTYPE_XBOX360 || xpad->xtype == XTYPE_XBOX)
                 usb_kill_urb(xpad->irq_out);
 }
 
 static void xpad_deinit_output(struct usb_xpad *xpad)
 {
-        if (xpad->xtype == XTYPE_XBOX360) {
+        if (xpad->xtype == XTYPE_XBOX360 || xpad->xtype == XTYPE_XBOX) {
                 usb_free_urb(xpad->irq_out);
                 usb_buffer_free(xpad->udev, XPAD_PKT_LEN,
                                 xpad->odata, xpad->odata_dma);
@@ -551,24 +579,45 @@ static void xpad_stop_output(struct usb_xpad *xpad) {}
 #endif
 
 #ifdef CONFIG_JOYSTICK_XPAD_FF
-static int xpad_play_effect(struct input_dev *dev, void *data,
-                            struct ff_effect *effect)
+static int xpad_play_effect(struct input_dev *dev, void *data, struct ff_effect *effect)
 {
         struct usb_xpad *xpad = input_get_drvdata(dev);
 
         if (effect->type == FF_RUMBLE) {
                 __u16 strong = effect->u.rumble.strong_magnitude;
                 __u16 weak = effect->u.rumble.weak_magnitude;
-                xpad->odata[0] = 0x00;
-                xpad->odata[1] = 0x08;
-                xpad->odata[2] = 0x00;
-                xpad->odata[3] = strong / 256;
-                xpad->odata[4] = weak / 256;
-                xpad->odata[5] = 0x00;
-                xpad->odata[6] = 0x00;
-                xpad->odata[7] = 0x00;
-                xpad->irq_out->transfer_buffer_length = 8;
-                usb_submit_urb(xpad->irq_out, GFP_KERNEL);
+
+                switch (xpad->xtype) {
+
+                case XTYPE_XBOX:
+                        xpad->odata[0] = 0x00;
+                        xpad->odata[1] = 0x06;
+                        xpad->odata[2] = 0x00;
+                        xpad->odata[3] = strong / 256;  /* left actuator */
+                        xpad->odata[4] = 0x00;
+                        xpad->odata[5] = weak / 256;    /* right actuator */
+                        xpad->irq_out->transfer_buffer_length = 6;
+
+                        return usb_submit_urb(xpad->irq_out, GFP_ATOMIC);
+
+                case XTYPE_XBOX360:
+                        xpad->odata[0] = 0x00;
+                        xpad->odata[1] = 0x08;
+                        xpad->odata[2] = 0x00;
+                        xpad->odata[3] = strong / 256;  /* left actuator? */
+                        xpad->odata[4] = weak / 256;    /* right actuator? */
+                        xpad->odata[5] = 0x00;
+                        xpad->odata[6] = 0x00;
+                        xpad->odata[7] = 0x00;
+                        xpad->irq_out->transfer_buffer_length = 8;
+
+                        return usb_submit_urb(xpad->irq_out, GFP_ATOMIC);
+
+                default:
+                        dbg("%s - rumble command sent to unsupported xpad type: %d",
+                                __func__, xpad->xtype);
+                        return -1;
+                }
         }
 
         return 0;
@@ -576,7 +625,7 @@ static int xpad_play_effect(struct input_dev *dev, void *data,
 
 static int xpad_init_ff(struct usb_xpad *xpad)
 {
-        if (xpad->xtype != XTYPE_XBOX360)
+        if (xpad->xtype != XTYPE_XBOX360 && xpad->xtype != XTYPE_XBOX)
                 return 0;
 
         input_set_capability(xpad->dev, EV_FF, FF_RUMBLE);
@@ -709,11 +758,11 @@ static void xpad_set_up_abs(struct input_dev *input_dev, signed short abs)
                 input_set_abs_params(input_dev, abs, -32768, 32767, 16, 128);
                 break;
         case ABS_Z:
-        case ABS_RZ:    /* the triggers */
+        case ABS_RZ:    /* the triggers (if mapped to axes) */
                 input_set_abs_params(input_dev, abs, 0, 255, 0, 0);
                 break;
         case ABS_HAT0X:
-        case ABS_HAT0Y: /* the d-pad (only if MAP_DPAD_TO_AXES) */
+        case ABS_HAT0Y: /* the d-pad (only if dpad is mapped to axes */
                 input_set_abs_params(input_dev, abs, -1, 1, 0, 0);
                 break;
         }
@@ -749,10 +798,9 @@ static int xpad_probe(struct usb_interface *intf, const struct usb_device_id *id
                 goto fail2;
 
         xpad->udev = udev;
-        xpad->dpad_mapping = xpad_device[i].dpad_mapping;
+        xpad->mapping = xpad_device[i].mapping;
         xpad->xtype = xpad_device[i].xtype;
-        if (xpad->dpad_mapping == MAP_DPAD_UNKNOWN)
-                xpad->dpad_mapping = !dpad_to_buttons;
+
         if (xpad->xtype == XTYPE_UNKNOWN) {
                 if (intf->cur_altsetting->desc.bInterfaceClass == USB_CLASS_VENDOR_SPEC) {
                         if (intf->cur_altsetting->desc.bInterfaceProtocol == 129)
@@ -761,7 +809,13 @@ static int xpad_probe(struct usb_interface *intf, const struct usb_device_id *id
                                 xpad->xtype = XTYPE_XBOX360;
                 } else
                         xpad->xtype = XTYPE_XBOX;
+
+                if (dpad_to_buttons)
+                        xpad->mapping |= MAP_DPAD_TO_BUTTONS;
+                if (triggers_to_buttons)
+                        xpad->mapping |= MAP_TRIGGERS_TO_BUTTONS;
         }
+
         xpad->dev = input_dev;
         usb_make_path(udev, xpad->phys, sizeof(xpad->phys));
         strlcat(xpad->phys, "/input0", sizeof(xpad->phys));
@@ -778,25 +832,37 @@ static int xpad_probe(struct usb_interface *intf, const struct usb_device_id *id
 
         input_dev->evbit[0] = BIT_MASK(EV_KEY) | BIT_MASK(EV_ABS);
 
-        /* set up buttons */
+        /* set up standard buttons and axes */
         for (i = 0; xpad_common_btn[i] >= 0; i++)
-                set_bit(xpad_common_btn[i], input_dev->keybit);
-        if ((xpad->xtype == XTYPE_XBOX360) || (xpad->xtype == XTYPE_XBOX360W))
-                for (i = 0; xpad360_btn[i] >= 0; i++)
-                        set_bit(xpad360_btn[i], input_dev->keybit);
-        else
-                for (i = 0; xpad_btn[i] >= 0; i++)
-                        set_bit(xpad_btn[i], input_dev->keybit);
-        if (xpad->dpad_mapping == MAP_DPAD_TO_BUTTONS)
-                for (i = 0; xpad_btn_pad[i] >= 0; i++)
-                        set_bit(xpad_btn_pad[i], input_dev->keybit);
+                __set_bit(xpad_common_btn[i], input_dev->keybit);
 
-        /* set up axes */
         for (i = 0; xpad_abs[i] >= 0; i++)
                 xpad_set_up_abs(input_dev, xpad_abs[i]);
-        if (xpad->dpad_mapping == MAP_DPAD_TO_AXES)
+
+        /* Now set up model-specific ones */
+        if (xpad->xtype == XTYPE_XBOX360 || xpad->xtype == XTYPE_XBOX360W) {
+                for (i = 0; xpad360_btn[i] >= 0; i++)
+                        __set_bit(xpad360_btn[i], input_dev->keybit);
+        } else {
+                for (i = 0; xpad_btn[i] >= 0; i++)
+                        __set_bit(xpad_btn[i], input_dev->keybit);
+        }
+
+        if (xpad->mapping & MAP_DPAD_TO_BUTTONS) {
+                for (i = 0; xpad_btn_pad[i] >= 0; i++)
+                        __set_bit(xpad_btn_pad[i], input_dev->keybit);
+        } else {
                 for (i = 0; xpad_abs_pad[i] >= 0; i++)
                     xpad_set_up_abs(input_dev, xpad_abs_pad[i]);
+        }
+
+        if (xpad->mapping & MAP_TRIGGERS_TO_BUTTONS) {
+                for (i = 0; xpad_btn_triggers[i] >= 0; i++)
+                        __set_bit(xpad_btn_triggers[i], input_dev->keybit);
+        } else {
+                for (i = 0; xpad_abs_triggers[i] >= 0; i++)
+                        xpad_set_up_abs(input_dev, xpad_abs_triggers[i]);
+        }
 
         error = xpad_init_output(intf, xpad);
         if (error)
diff --git a/drivers/input/keyboard/Kconfig b/drivers/input/keyboard/Kconfig
index ee98b1bc5d89..64c102355f53 100644
--- a/drivers/input/keyboard/Kconfig
+++ b/drivers/input/keyboard/Kconfig
@@ -24,11 +24,21 @@ config KEYBOARD_AAED2000
           To compile this driver as a module, choose M here: the
           module will be called aaed2000_kbd.
 
+config KEYBOARD_ADP5520
+        tristate "Keypad Support for ADP5520 PMIC"
+        depends on PMIC_ADP5520
+        help
+          This option enables support for the keypad scan matrix
+          on Analog Devices ADP5520 PMICs.
+
+          To compile this driver as a module, choose M here: the module will
+          be called adp5520-keys.
+
 config KEYBOARD_ADP5588
-        tristate "ADP5588 I2C QWERTY Keypad and IO Expander"
+        tristate "ADP5588/87 I2C QWERTY Keypad and IO Expander"
         depends on I2C
         help
-          Say Y here if you want to use a ADP5588 attached to your
+          Say Y here if you want to use a ADP5588/87 attached to your
           system I2C bus.
 
           To compile this driver as a module, choose M here: the
@@ -134,13 +144,15 @@ config KEYBOARD_BFIN
           module will be called bf54x-keys.
 
 config KEYBOARD_CORGI
-        tristate "Corgi keyboard"
+        tristate "Corgi keyboard (deprecated)"
         depends on PXA_SHARPSL
-        default y
         help
           Say Y here to enable the keyboard on the Sharp Zaurus SL-C7xx
           series of PDAs.
 
+          This driver is now deprecated, use generic GPIO based matrix
+          keyboard driver instead.
+
           To compile this driver as a module, choose M here: the
           module will be called corgikbd.
 
@@ -282,6 +294,15 @@ config KEYBOARD_MAX7359
           To compile this driver as a module, choose M here: the
           module will be called max7359_keypad.
 
+config KEYBOARD_IMX
+        tristate "IMX keypad support"
+        depends on ARCH_MXC
+        help
+          Enable support for IMX keypad port.
+
+          To compile this driver as a module, choose M here: the
+          module will be called imx_keypad.
+
 config KEYBOARD_NEWTON
         tristate "Newton keyboard"
         select SERIO
@@ -319,13 +340,15 @@ config KEYBOARD_PXA930_ROTARY
           module will be called pxa930_rotary.
 
 config KEYBOARD_SPITZ
-        tristate "Spitz keyboard"
+        tristate "Spitz keyboard (deprecated)"
         depends on PXA_SHARPSL
-        default y
         help
           Say Y here to enable the keyboard on the Sharp Zaurus SL-C1000,
           SL-C3000 and Sl-C3100 series of PDAs.
 
+          This driver is now deprecated, use generic GPIO based matrix
+          keyboard driver instead.
+
           To compile this driver as a module, choose M here: the
           module will be called spitzkbd.
 
@@ -353,7 +376,7 @@ config KEYBOARD_SUNKBD
 
 config KEYBOARD_SH_KEYSC
         tristate "SuperH KEYSC keypad support"
-        depends on SUPERH
+        depends on SUPERH || ARCH_SHMOBILE
         help
           Say Y here if you want to use a keypad attached to the KEYSC block
           on SuperH processors such as sh7722 and sh7343.
@@ -361,6 +384,16 @@ config KEYBOARD_SH_KEYSC
           To compile this driver as a module, choose M here: the
           module will be called sh_keysc.
 
+config KEYBOARD_DAVINCI
+        tristate "TI DaVinci Key Scan"
+        depends on ARCH_DAVINCI_DM365
+        help
+          Say Y to enable keypad module support for the TI DaVinci
+          platforms (DM365).
+
+          To compile this driver as a module, choose M here: the
+          module will be called davinci_keyscan.
+
 config KEYBOARD_OMAP
         tristate "TI OMAP keypad support"
         depends on (ARCH_OMAP1 || ARCH_OMAP2)
@@ -382,12 +415,14 @@ config KEYBOARD_TWL4030
           module will be called twl4030_keypad.
 
 config KEYBOARD_TOSA
-        tristate "Tosa keyboard"
+        tristate "Tosa keyboard (deprecated)"
         depends on MACH_TOSA
-        default y
         help
           Say Y here to enable the keyboard on the Sharp Zaurus SL-6000x (Tosa)
 
+          This driver is now deprecated, use generic GPIO based matrix
+          keyboard driver instead.
+
           To compile this driver as a module, choose M here: the
           module will be called tosakbd.
 
diff --git a/drivers/input/keyboard/Makefile b/drivers/input/keyboard/Makefile
index babad5e58b77..706c6b5ed5f4 100644
--- a/drivers/input/keyboard/Makefile
+++ b/drivers/input/keyboard/Makefile
@@ -5,16 +5,19 @@
 # Each configuration option enables a list of files.
 
 obj-$(CONFIG_KEYBOARD_AAED2000)         += aaed2000_kbd.o
+obj-$(CONFIG_KEYBOARD_ADP5520)          += adp5520-keys.o
 obj-$(CONFIG_KEYBOARD_ADP5588)          += adp5588-keys.o
 obj-$(CONFIG_KEYBOARD_AMIGA)            += amikbd.o
 obj-$(CONFIG_KEYBOARD_ATARI)            += atakbd.o
 obj-$(CONFIG_KEYBOARD_ATKBD)            += atkbd.o
 obj-$(CONFIG_KEYBOARD_BFIN)             += bf54x-keys.o
 obj-$(CONFIG_KEYBOARD_CORGI)            += corgikbd.o
+obj-$(CONFIG_KEYBOARD_DAVINCI)          += davinci_keyscan.o
 obj-$(CONFIG_KEYBOARD_EP93XX)           += ep93xx_keypad.o
 obj-$(CONFIG_KEYBOARD_GPIO)             += gpio_keys.o
 obj-$(CONFIG_KEYBOARD_HIL)              += hil_kbd.o
 obj-$(CONFIG_KEYBOARD_HIL_OLD)          += hilkbd.o
+obj-$(CONFIG_KEYBOARD_IMX)              += imx_keypad.o
 obj-$(CONFIG_KEYBOARD_HP6XX)            += jornada680_kbd.o
 obj-$(CONFIG_KEYBOARD_HP7XX)            += jornada720_kbd.o
 obj-$(CONFIG_KEYBOARD_LKKBD)            += lkkbd.o
diff --git a/drivers/input/keyboard/adp5520-keys.c b/drivers/input/keyboard/adp5520-keys.c
new file mode 100644
index 000000000000..3db8006dac3a
--- /dev/null
+++ b/drivers/input/keyboard/adp5520-keys.c
@@ -0,0 +1,221 @@
+/*
+ * Keypad driver for Analog Devices ADP5520 MFD PMICs
+ *
+ * Copyright 2009 Analog Devices Inc.
+ *
+ * Licensed under the GPL-2 or later.
+ */
+
+#include <linux/module.h>
+#include <linux/kernel.h>
+#include <linux/init.h>
+#include <linux/platform_device.h>
+#include <linux/input.h>
+#include <linux/mfd/adp5520.h>
+#include <linux/slab.h>
+
+struct adp5520_keys {
+        struct input_dev *input;
+        struct notifier_block notifier;
+        struct device *master;
+        unsigned short keycode[ADP5520_KEYMAPSIZE];
+};
+
+static void adp5520_keys_report_event(struct adp5520_keys *dev,
+                                        unsigned short keymask, int value)
+{
+        int i;
+
+        for (i = 0; i < ADP5520_MAXKEYS; i++)
+                if (keymask & (1 << i))
+                        input_report_key(dev->input, dev->keycode[i], value);
+
+        input_sync(dev->input);
+}
+
+static int adp5520_keys_notifier(struct notifier_block *nb,
+                                 unsigned long event, void *data)
+{
+        struct adp5520_keys *dev;
+        uint8_t reg_val_lo, reg_val_hi;
+        unsigned short keymask;
+
+        dev = container_of(nb, struct adp5520_keys, notifier);
+
+        if (event & ADP5520_KP_INT) {
+                adp5520_read(dev->master, ADP5520_KP_INT_STAT_1, &reg_val_lo);
+                adp5520_read(dev->master, ADP5520_KP_INT_STAT_2, &reg_val_hi);
+
+                keymask = (reg_val_hi << 8) | reg_val_lo;
+                /* Read twice to clear */
+                adp5520_read(dev->master, ADP5520_KP_INT_STAT_1, &reg_val_lo);
+                adp5520_read(dev->master, ADP5520_KP_INT_STAT_2, &reg_val_hi);
+                keymask |= (reg_val_hi << 8) | reg_val_lo;
+                adp5520_keys_report_event(dev, keymask, 1);
+        }
+
+        if (event & ADP5520_KR_INT) {
+                adp5520_read(dev->master, ADP5520_KR_INT_STAT_1, &reg_val_lo);
+                adp5520_read(dev->master, ADP5520_KR_INT_STAT_2, &reg_val_hi);
+
+                keymask = (reg_val_hi << 8) | reg_val_lo;
+                /* Read twice to clear */
+                adp5520_read(dev->master, ADP5520_KR_INT_STAT_1, &reg_val_lo);
+                adp5520_read(dev->master, ADP5520_KR_INT_STAT_2, &reg_val_hi);
+                keymask |= (reg_val_hi << 8) | reg_val_lo;
+                adp5520_keys_report_event(dev, keymask, 0);
+        }
+
+        return 0;
+}
+
+static int __devinit adp5520_keys_probe(struct platform_device *pdev)
+{
+        struct adp5520_keys_platform_data *pdata = pdev->dev.platform_data;
+        struct input_dev *input;
+        struct adp5520_keys *dev;
+        int ret, i;
+        unsigned char en_mask, ctl_mask = 0;
+
+        if (pdev->id != ID_ADP5520) {
+                dev_err(&pdev->dev, "only ADP5520 supports Keypad\n");
+                return -EINVAL;
+        }
+
+        if (pdata == NULL) {
+                dev_err(&pdev->dev, "missing platform data\n");
+                return -EINVAL;
+        }
+
+        if (!(pdata->rows_en_mask && pdata->cols_en_mask))
+                return -EINVAL;
+
+        dev = kzalloc(sizeof(*dev), GFP_KERNEL);
+        if (dev == NULL) {
+                dev_err(&pdev->dev, "failed to alloc memory\n");
+                return -ENOMEM;
+        }
+
+        input = input_allocate_device();
+        if (!input) {
+                ret = -ENOMEM;
+                goto err;
+        }
+
+        dev->master = pdev->dev.parent;
+        dev->input = input;
+
+        input->name = pdev->name;
+        input->phys = "adp5520-keys/input0";
+        input->dev.parent = &pdev->dev;
+
+        input_set_drvdata(input, dev);
+
+        input->id.bustype = BUS_I2C;
+        input->id.vendor = 0x0001;
+        input->id.product = 0x5520;
+        input->id.version = 0x0001;
+
+        input->keycodesize = sizeof(dev->keycode[0]);
+        input->keycodemax = pdata->keymapsize;
+        input->keycode = dev->keycode;
+
+        memcpy(dev->keycode, pdata->keymap,
+                pdata->keymapsize * input->keycodesize);
+
+        /* setup input device */
+        __set_bit(EV_KEY, input->evbit);
+
+        if (pdata->repeat)
+                __set_bit(EV_REP, input->evbit);
+
+        for (i = 0; i < input->keycodemax; i++)
+                __set_bit(dev->keycode[i], input->keybit);
+        __clear_bit(KEY_RESERVED, input->keybit);
+
+        ret = input_register_device(input);
+        if (ret) {
+                dev_err(&pdev->dev, "unable to register input device\n");
+                goto err;
+        }
+
+        en_mask = pdata->rows_en_mask | pdata->cols_en_mask;
+
+        ret = adp5520_set_bits(dev->master, ADP5520_GPIO_CFG_1, en_mask);
+
+        if (en_mask & ADP5520_COL_C3)
+                ctl_mask |= ADP5520_C3_MODE;
+
+        if (en_mask & ADP5520_ROW_R3)
+                ctl_mask |= ADP5520_R3_MODE;
+
+        if (ctl_mask)
+                ret |= adp5520_set_bits(dev->master, ADP5520_LED_CONTROL,
+                        ctl_mask);
+
+        ret |= adp5520_set_bits(dev->master, ADP5520_GPIO_PULLUP,
+                pdata->rows_en_mask);
+
+        if (ret) {
+                dev_err(&pdev->dev, "failed to write\n");
+                ret = -EIO;
+                goto err1;
+        }
+
+        dev->notifier.notifier_call = adp5520_keys_notifier;
+        ret = adp5520_register_notifier(dev->master, &dev->notifier,
+                        ADP5520_KP_IEN | ADP5520_KR_IEN);
+        if (ret) {
+                dev_err(&pdev->dev, "failed to register notifier\n");
+                goto err1;
+        }
+
+        platform_set_drvdata(pdev, dev);
+        return 0;
+
+err1:
+        input_unregister_device(input);
+        input = NULL;
+err:
+        input_free_device(input);
+        kfree(dev);
+        return ret;
+}
+
+static int __devexit adp5520_keys_remove(struct platform_device *pdev)
+{
+        struct adp5520_keys *dev = platform_get_drvdata(pdev);
+
+        adp5520_unregister_notifier(dev->master, &dev->notifier,
+                                ADP5520_KP_IEN | ADP5520_KR_IEN);
+
+        input_unregister_device(dev->input);
+        kfree(dev);
+        return 0;
+}
+
+static struct platform_driver adp5520_keys_driver = {
+        .driver = {
+                .name   = "adp5520-keys",
+                .owner  = THIS_MODULE,
+        },
+        .probe          = adp5520_keys_probe,
+        .remove         = __devexit_p(adp5520_keys_remove),
+};
+
+static int __init adp5520_keys_init(void)
+{
+        return platform_driver_register(&adp5520_keys_driver);
+}
+module_init(adp5520_keys_init);
+
+static void __exit adp5520_keys_exit(void)
+{
+        platform_driver_unregister(&adp5520_keys_driver);
+}
+module_exit(adp5520_keys_exit);
+
+MODULE_AUTHOR("Michael Hennerich <hennerich@blackfin.uclinux.org>");
+MODULE_DESCRIPTION("Keys ADP5520 Driver");
+MODULE_LICENSE("GPL");
+MODULE_ALIAS("platform:adp5520-keys");
diff --git a/drivers/input/keyboard/adp5588-keys.c b/drivers/input/keyboard/adp5588-keys.c
index d48c808d5928..4771ab172b59 100644
--- a/drivers/input/keyboard/adp5588-keys.c
+++ b/drivers/input/keyboard/adp5588-keys.c
@@ -1,6 +1,7 @@
 /*
  * File: drivers/input/keyboard/adp5588_keys.c
- * Description:  keypad driver for ADP5588 I2C QWERTY Keypad and IO Expander
+ * Description:  keypad driver for ADP5588 and ADP5587
+ *               I2C QWERTY Keypad and IO Expander
  * Bugs: Enter bugs at http://blackfin.uclinux.org/
  *
  * Copyright (C) 2008-2009 Analog Devices Inc.
@@ -18,6 +19,7 @@
 #include <linux/platform_device.h>
 #include <linux/input.h>
 #include <linux/i2c.h>
+#include <linux/slab.h>
 
 #include <linux/i2c/adp5588.h>
 
@@ -319,7 +321,7 @@ static int adp5588_resume(struct device *dev)
         return 0;
 }
 
-static struct dev_pm_ops adp5588_dev_pm_ops = {
+static const struct dev_pm_ops adp5588_dev_pm_ops = {
         .suspend = adp5588_suspend,
         .resume  = adp5588_resume,
 };
@@ -327,6 +329,7 @@ static struct dev_pm_ops adp5588_dev_pm_ops = {
 
 static const struct i2c_device_id adp5588_id[] = {
         { KBUILD_MODNAME, 0 },
+        { "adp5587-keys", 0 },
         { }
 };
 MODULE_DEVICE_TABLE(i2c, adp5588_id);
@@ -357,5 +360,5 @@ module_exit(adp5588_exit);
 
 MODULE_LICENSE("GPL");
 MODULE_AUTHOR("Michael Hennerich <hennerich@blackfin.uclinux.org>");
-MODULE_DESCRIPTION("ADP5588 Keypad driver");
+MODULE_DESCRIPTION("ADP5588/87 Keypad driver");
 MODULE_ALIAS("platform:adp5588-keys");
diff --git a/drivers/input/keyboard/atkbd.c b/drivers/input/keyboard/atkbd.c
index 28e6110d1ff8..d358ef8623f4 100644
--- a/drivers/input/keyboard/atkbd.c
+++ b/drivers/input/keyboard/atkbd.c
@@ -40,26 +40,26 @@ module_param_named(set, atkbd_set, int, 0);
 MODULE_PARM_DESC(set, "Select keyboard code set (2 = default, 3 = PS/2 native)");
 
 #if defined(__i386__) || defined(__x86_64__) || defined(__hppa__)
-static int atkbd_reset;
+static bool atkbd_reset;
 #else
-static int atkbd_reset = 1;
+static bool atkbd_reset = true;
 #endif
 module_param_named(reset, atkbd_reset, bool, 0);
 MODULE_PARM_DESC(reset, "Reset keyboard during initialization");
 
-static int atkbd_softrepeat;
+static bool atkbd_softrepeat;
 module_param_named(softrepeat, atkbd_softrepeat, bool, 0);
 MODULE_PARM_DESC(softrepeat, "Use software keyboard repeat");
 
-static int atkbd_softraw = 1;
+static bool atkbd_softraw = true;
 module_param_named(softraw, atkbd_softraw, bool, 0);
 MODULE_PARM_DESC(softraw, "Use software generated rawmode");
 
-static int atkbd_scroll;
+static bool atkbd_scroll;
 module_param_named(scroll, atkbd_scroll, bool, 0);
 MODULE_PARM_DESC(scroll, "Enable scroll-wheel on MS Office and similar keyboards");
 
-static int atkbd_extra;
+static bool atkbd_extra;
 module_param_named(extra, atkbd_extra, bool, 0);
 MODULE_PARM_DESC(extra, "Enable extra LEDs and keys on IBM RapidAcces, EzKey and similar keyboards");
 
@@ -134,7 +134,8 @@ static const unsigned short atkbd_unxlate_table[128] = {
 #define ATKBD_CMD_GETID         0x02f2
 #define ATKBD_CMD_SETREP        0x10f3
 #define ATKBD_CMD_ENABLE        0x00f4
-#define ATKBD_CMD_RESET_DIS     0x00f5
+#define ATKBD_CMD_RESET_DIS     0x00f5  /* Reset to defaults and disable */
+#define ATKBD_CMD_RESET_DEF     0x00f6  /* Reset to defaults */
 #define ATKBD_CMD_SETALL_MBR    0x00fa
 #define ATKBD_CMD_RESET_BAT     0x02ff
 #define ATKBD_CMD_RESEND        0x00fe
@@ -152,16 +153,16 @@ static const unsigned short atkbd_unxlate_table[128] = {
 #define ATKBD_RET_HANGEUL       0xf2
 #define ATKBD_RET_ERR           0xff
 
-#define ATKBD_KEY_UNKNOWN         0
+#define ATKBD_KEY_UNKNOWN       0
 #define ATKBD_KEY_NULL          255
 
-#define ATKBD_SCR_1             254
-#define ATKBD_SCR_2             253
-#define ATKBD_SCR_4             252
-#define ATKBD_SCR_8             251
-#define ATKBD_SCR_CLICK         250
-#define ATKBD_SCR_LEFT          249
-#define ATKBD_SCR_RIGHT         248
+#define ATKBD_SCR_1             0xfffe
+#define ATKBD_SCR_2             0xfffd
+#define ATKBD_SCR_4             0xfffc
+#define ATKBD_SCR_8             0xfffb
+#define ATKBD_SCR_CLICK         0xfffa
+#define ATKBD_SCR_LEFT          0xfff9
+#define ATKBD_SCR_RIGHT         0xfff8
 
 #define ATKBD_SPECIAL           ATKBD_SCR_RIGHT
 
@@ -176,7 +177,7 @@ static const unsigned short atkbd_unxlate_table[128] = {
 #define ATKBD_XL_HANJA          0x20
 
 static const struct {
-        unsigned char keycode;
+        unsigned short keycode;
         unsigned char set2;
 } atkbd_scroll_keys[] = {
         { ATKBD_SCR_1,     0xc5 },
@@ -205,18 +206,18 @@ struct atkbd {
         unsigned short keycode[ATKBD_KEYMAP_SIZE];
         DECLARE_BITMAP(force_release_mask, ATKBD_KEYMAP_SIZE);
         unsigned char set;
-        unsigned char translated;
-        unsigned char extra;
-        unsigned char write;
-        unsigned char softrepeat;
-        unsigned char softraw;
-        unsigned char scroll;
-        unsigned char enabled;
+        bool translated;
+        bool extra;
+        bool write;
+        bool softrepeat;
+        bool softraw;
+        bool scroll;
+        bool enabled;
 
         /* Accessed only from interrupt */
         unsigned char emul;
-        unsigned char resend;
-        unsigned char release;
+        bool resend;
+        bool release;
         unsigned long xl_bit;
         unsigned int last;
         unsigned long time;
@@ -224,8 +225,10 @@ struct atkbd {
 
         struct delayed_work event_work;
         unsigned long event_jiffies;
-        struct mutex event_mutex;
         unsigned long event_mask;
+
+        /* Serializes reconnect(), attr->set() and event work */
+        struct mutex mutex;
 };
 
 /*
@@ -298,18 +301,18 @@ static const unsigned int xl_table[] = {
  * Checks if we should mangle the scancode to extract 'release' bit
  * in translated mode.
  */
-static int atkbd_need_xlate(unsigned long xl_bit, unsigned char code)
+static bool atkbd_need_xlate(unsigned long xl_bit, unsigned char code)
 {
         int i;
 
         if (code == ATKBD_RET_EMUL0 || code == ATKBD_RET_EMUL1)
-                return 0;
+                return false;
 
         for (i = 0; i < ARRAY_SIZE(xl_table); i++)
                 if (code == xl_table[i])
                         return test_bit(i, &xl_bit);
 
-        return 1;
+        return true;
 }
 
 /*
@@ -356,7 +359,7 @@ static unsigned int atkbd_compat_scancode(struct atkbd *atkbd, unsigned int code
  */
 
 static irqreturn_t atkbd_interrupt(struct serio *serio, unsigned char data,
-                        unsigned int flags)
+                                   unsigned int flags)
 {
         struct atkbd *atkbd = serio_get_drvdata(serio);
         struct input_dev *dev = atkbd->dev;
@@ -365,20 +368,18 @@ static irqreturn_t atkbd_interrupt(struct serio *serio, unsigned char data,
         int value;
         unsigned short keycode;
 
-#ifdef ATKBD_DEBUG
-        printk(KERN_DEBUG "atkbd.c: Received %02x flags %02x\n", data, flags);
-#endif
+        dev_dbg(&serio->dev, "Received %02x flags %02x\n", data, flags);
 
 #if !defined(__i386__) && !defined (__x86_64__)
         if ((flags & (SERIO_FRAME | SERIO_PARITY)) && (~flags & SERIO_TIMEOUT) && !atkbd->resend && atkbd->write) {
-                printk(KERN_WARNING "atkbd.c: frame/parity error: %02x\n", flags);
+                dev_warn(&serio->dev, "Frame/parity error: %02x\n", flags);
                 serio_write(serio, ATKBD_CMD_RESEND);
-                atkbd->resend = 1;
+                atkbd->resend = true;
                 goto out;
         }
 
         if (!flags && data == ATKBD_RET_ACK)
-                atkbd->resend = 0;
+                atkbd->resend = false;
 #endif
 
         if (unlikely(atkbd->ps2dev.flags & PS2_FLAG_ACK))
@@ -409,32 +410,32 @@ static irqreturn_t atkbd_interrupt(struct serio *serio, unsigned char data,
         }
 
         switch (code) {
-                case ATKBD_RET_BAT:
-                        atkbd->enabled = 0;
-                        serio_reconnect(atkbd->ps2dev.serio);
-                        goto out;
-                case ATKBD_RET_EMUL0:
-                        atkbd->emul = 1;
-                        goto out;
-                case ATKBD_RET_EMUL1:
-                        atkbd->emul = 2;
-                        goto out;
-                case ATKBD_RET_RELEASE:
-                        atkbd->release = 1;
-                        goto out;
-                case ATKBD_RET_ACK:
-                case ATKBD_RET_NAK:
-                        if (printk_ratelimit())
-                                printk(KERN_WARNING "atkbd.c: Spurious %s on %s. "
-                                       "Some program might be trying access hardware directly.\n",
-                                       data == ATKBD_RET_ACK ? "ACK" : "NAK", serio->phys);
-                        goto out;
-                case ATKBD_RET_ERR:
-                        atkbd->err_count++;
-#ifdef ATKBD_DEBUG
-                        printk(KERN_DEBUG "atkbd.c: Keyboard on %s reports too many keys pressed.\n", serio->phys);
-#endif
-                        goto out;
+        case ATKBD_RET_BAT:
+                atkbd->enabled = false;
+                serio_reconnect(atkbd->ps2dev.serio);
+                goto out;
+        case ATKBD_RET_EMUL0:
+                atkbd->emul = 1;
+                goto out;
+        case ATKBD_RET_EMUL1:
+                atkbd->emul = 2;
+                goto out;
+        case ATKBD_RET_RELEASE:
+                atkbd->release = true;
+                goto out;
+        case ATKBD_RET_ACK:
+        case ATKBD_RET_NAK:
+                if (printk_ratelimit())
+                        dev_warn(&serio->dev,
+                                 "Spurious %s on %s. "
+                                 "Some program might be trying access hardware directly.\n",
+                                 data == ATKBD_RET_ACK ? "ACK" : "NAK", serio->phys);
+                goto out;
+        case ATKBD_RET_ERR:
+                atkbd->err_count++;
+                dev_dbg(&serio->dev, "Keyboard on %s reports too many keys pressed.\n",
+                        serio->phys);
+                goto out;
         }
 
         code = atkbd_compat_scancode(atkbd, code);
@@ -448,71 +449,72 @@ static irqreturn_t atkbd_interrupt(struct serio *serio, unsigned char data,
                 input_event(dev, EV_MSC, MSC_SCAN, code);
 
         switch (keycode) {
-                case ATKBD_KEY_NULL:
-                        break;
-                case ATKBD_KEY_UNKNOWN:
-                        printk(KERN_WARNING
-                               "atkbd.c: Unknown key %s (%s set %d, code %#x on %s).\n",
-                               atkbd->release ? "released" : "pressed",
-                               atkbd->translated ? "translated" : "raw",
-                               atkbd->set, code, serio->phys);
-                        printk(KERN_WARNING
-                               "atkbd.c: Use 'setkeycodes %s%02x <keycode>' to make it known.\n",
-                               code & 0x80 ? "e0" : "", code & 0x7f);
-                        input_sync(dev);
-                        break;
-                case ATKBD_SCR_1:
-                        scroll = 1 - atkbd->release * 2;
-                        break;
-                case ATKBD_SCR_2:
-                        scroll = 2 - atkbd->release * 4;
-                        break;
-                case ATKBD_SCR_4:
-                        scroll = 4 - atkbd->release * 8;
-                        break;
-                case ATKBD_SCR_8:
-                        scroll = 8 - atkbd->release * 16;
-                        break;
-                case ATKBD_SCR_CLICK:
-                        click = !atkbd->release;
-                        break;
-                case ATKBD_SCR_LEFT:
-                        hscroll = -1;
-                        break;
-                case ATKBD_SCR_RIGHT:
-                        hscroll = 1;
-                        break;
-                default:
-                        if (atkbd->release) {
-                                value = 0;
-                                atkbd->last = 0;
-                        } else if (!atkbd->softrepeat && test_bit(keycode, dev->key)) {
-                                /* Workaround Toshiba laptop multiple keypress */
-                                value = time_before(jiffies, atkbd->time) && atkbd->last == code ? 1 : 2;
-                        } else {
-                                value = 1;
-                                atkbd->last = code;
-                                atkbd->time = jiffies + msecs_to_jiffies(dev->rep[REP_DELAY]) / 2;
-                        }
-
-                        input_event(dev, EV_KEY, keycode, value);
-                        input_sync(dev);
+        case ATKBD_KEY_NULL:
+                break;
+        case ATKBD_KEY_UNKNOWN:
+                dev_warn(&serio->dev,
+                         "Unknown key %s (%s set %d, code %#x on %s).\n",
+                         atkbd->release ? "released" : "pressed",
+                         atkbd->translated ? "translated" : "raw",
+                         atkbd->set, code, serio->phys);
+                dev_warn(&serio->dev,
+                         "Use 'setkeycodes %s%02x <keycode>' to make it known.\n",
+                         code & 0x80 ? "e0" : "", code & 0x7f);
+                input_sync(dev);
+                break;
+        case ATKBD_SCR_1:
+                scroll = 1;
+                break;
+        case ATKBD_SCR_2:
+                scroll = 2;
+                break;
+        case ATKBD_SCR_4:
+                scroll = 4;
+                break;
+        case ATKBD_SCR_8:
+                scroll = 8;
+                break;
+        case ATKBD_SCR_CLICK:
+                click = !atkbd->release;
+                break;
+        case ATKBD_SCR_LEFT:
+                hscroll = -1;
+                break;
+        case ATKBD_SCR_RIGHT:
+                hscroll = 1;
+                break;
+        default:
+                if (atkbd->release) {
+                        value = 0;
+                        atkbd->last = 0;
+                } else if (!atkbd->softrepeat && test_bit(keycode, dev->key)) {
+                        /* Workaround Toshiba laptop multiple keypress */
+                        value = time_before(jiffies, atkbd->time) && atkbd->last == code ? 1 : 2;
+                } else {
+                        value = 1;
+                        atkbd->last = code;
+                        atkbd->time = jiffies + msecs_to_jiffies(dev->rep[REP_DELAY]) / 2;
+                }
+
+                input_event(dev, EV_KEY, keycode, value);
+                input_sync(dev);
 
-                        if (value && test_bit(code, atkbd->force_release_mask)) {
-                                input_report_key(dev, keycode, 0);
-                                input_sync(dev);
-                        }
+                if (value && test_bit(code, atkbd->force_release_mask)) {
+                        input_report_key(dev, keycode, 0);
+                        input_sync(dev);
+                }
         }
 
         if (atkbd->scroll) {
                 if (click != -1)
                         input_report_key(dev, BTN_MIDDLE, click);
-                input_report_rel(dev, REL_WHEEL, scroll);
+                input_report_rel(dev, REL_WHEEL,
+                                 atkbd->release ? -scroll : scroll);
                 input_report_rel(dev, REL_HWHEEL, hscroll);
                 input_sync(dev);
         }
 
-        atkbd->release = 0;
+        atkbd->release = false;
 out:
         return IRQ_HANDLED;
 }
@@ -576,7 +578,7 @@ static void atkbd_event_work(struct work_struct *work)
 {
         struct atkbd *atkbd = container_of(work, struct atkbd, event_work.work);
 
-        mutex_lock(&atkbd->event_mutex);
+        mutex_lock(&atkbd->mutex);
 
         if (!atkbd->enabled) {
                 /*
@@ -595,7 +597,7 @@ static void atkbd_event_work(struct work_struct *work)
                         atkbd_set_repeat_rate(atkbd);
         }
 
-        mutex_unlock(&atkbd->event_mutex);
+        mutex_unlock(&atkbd->mutex);
 }
 
 /*
@@ -611,7 +613,7 @@ static void atkbd_schedule_event_work(struct atkbd *atkbd, int event_bit)
 
         atkbd->event_jiffies = jiffies;
         set_bit(event_bit, &atkbd->event_mask);
-        wmb();
+        mb();
         schedule_delayed_work(&atkbd->event_work, delay);
 }
 
@@ -631,17 +633,18 @@ static int atkbd_event(struct input_dev *dev,
 
         switch (type) {
 
-                case EV_LED:
-                        atkbd_schedule_event_work(atkbd, ATKBD_LED_EVENT_BIT);
-                        return 0;
+        case EV_LED:
+                atkbd_schedule_event_work(atkbd, ATKBD_LED_EVENT_BIT);
+                return 0;
 
-                case EV_REP:
-                        if (!atkbd->softrepeat)
-                                atkbd_schedule_event_work(atkbd, ATKBD_REP_EVENT_BIT);
-                        return 0;
-        }
+        case EV_REP:
+                if (!atkbd->softrepeat)
+                        atkbd_schedule_event_work(atkbd, ATKBD_REP_EVENT_BIT);
+                return 0;
 
-        return -1;
+        default:
+                return -1;
+        }
 }
 
 /*
@@ -652,7 +655,7 @@ static int atkbd_event(struct input_dev *dev,
 static inline void atkbd_enable(struct atkbd *atkbd)
 {
         serio_pause_rx(atkbd->ps2dev.serio);
-        atkbd->enabled = 1;
+        atkbd->enabled = true;
         serio_continue_rx(atkbd->ps2dev.serio);
 }
 
@@ -664,7 +667,7 @@ static inline void atkbd_enable(struct atkbd *atkbd)
 static inline void atkbd_disable(struct atkbd *atkbd)
 {
         serio_pause_rx(atkbd->ps2dev.serio);
-        atkbd->enabled = 0;
+        atkbd->enabled = false;
         serio_continue_rx(atkbd->ps2dev.serio);
 }
 
@@ -685,7 +688,9 @@ static int atkbd_probe(struct atkbd *atkbd)
 
         if (atkbd_reset)
                 if (ps2_command(ps2dev, NULL, ATKBD_CMD_RESET_BAT))
-                        printk(KERN_WARNING "atkbd.c: keyboard reset failed on %s\n", ps2dev->serio->phys);
+                        dev_warn(&ps2dev->serio->dev,
+                                 "keyboard reset failed on %s\n",
+                                 ps2dev->serio->phys);
 
 /*
  * Then we check the keyboard ID. We should get 0xab83 under normal conditions.
@@ -715,8 +720,9 @@ static int atkbd_probe(struct atkbd *atkbd)
         atkbd->id = (param[0] << 8) | param[1];
 
         if (atkbd->id == 0xaca1 && atkbd->translated) {
-                printk(KERN_ERR "atkbd.c: NCD terminal keyboards are only supported on non-translating\n");
-                printk(KERN_ERR "atkbd.c: controllers. Use i8042.direct=1 to disable translation.\n");
+                dev_err(&ps2dev->serio->dev,
+                        "NCD terminal keyboards are only supported on non-translating controlelrs. "
+                        "Use i8042.direct=1 to disable translation.\n");
                 return -1;
         }
 
@@ -734,7 +740,7 @@ static int atkbd_select_set(struct atkbd *atkbd, int target_set, int allow_extra
         struct ps2dev *ps2dev = &atkbd->ps2dev;
         unsigned char param[2];
 
-        atkbd->extra = 0;
+        atkbd->extra = false;
 /*
  * For known special keyboards we can go ahead and set the correct set.
  * We check for NCD PS/2 Sun, NorthGate OmniKey 101 and
@@ -753,7 +759,7 @@ static int atkbd_select_set(struct atkbd *atkbd, int target_set, int allow_extra
         if (allow_extra) {
                 param[0] = 0x71;
                 if (!ps2_command(ps2dev, param, ATKBD_CMD_EX_ENABLE)) {
-                        atkbd->extra = 1;
+                        atkbd->extra = true;
                         return 2;
                 }
         }
@@ -818,7 +824,8 @@ static int atkbd_activate(struct atkbd *atkbd)
  */
 
         if (ps2_command(ps2dev, NULL, ATKBD_CMD_ENABLE)) {
-                printk(KERN_ERR "atkbd.c: Failed to enable keyboard on %s\n",
+                dev_err(&ps2dev->serio->dev,
+                        "Failed to enable keyboard on %s\n",
                         ps2dev->serio->phys);
                 return -1;
         }
@@ -836,7 +843,7 @@ static void atkbd_cleanup(struct serio *serio)
         struct atkbd *atkbd = serio_get_drvdata(serio);
 
         atkbd_disable(atkbd);
-        ps2_command(&atkbd->ps2dev, NULL, ATKBD_CMD_RESET_BAT);
+        ps2_command(&atkbd->ps2dev, NULL, ATKBD_CMD_RESET_DEF);
 }
 
 
@@ -848,13 +855,20 @@ static void atkbd_disconnect(struct serio *serio)
 {
         struct atkbd *atkbd = serio_get_drvdata(serio);
 
+        sysfs_remove_group(&serio->dev.kobj, &atkbd_attribute_group);
+
         atkbd_disable(atkbd);
 
-        /* make sure we don't have a command in flight */
+        input_unregister_device(atkbd->dev);
+
+        /*
+         * Make sure we don't have a command in flight.
+         * Note that since atkbd->enabled is false event work will keep
+         * rescheduling itself until it gets canceled and will not try
+         * accessing freed input device or serio port.
+         */
         cancel_delayed_work_sync(&atkbd->event_work);
 
-        sysfs_remove_group(&serio->dev.kobj, &atkbd_attribute_group);
-        input_unregister_device(atkbd->dev);
         serio_close(serio);
         serio_set_drvdata(serio, NULL);
         kfree(atkbd);
@@ -1060,9 +1074,13 @@ static void atkbd_set_device_attrs(struct atkbd *atkbd)
         input_dev->keycodesize = sizeof(unsigned short);
         input_dev->keycodemax = ARRAY_SIZE(atkbd_set2_keycode);
 
-        for (i = 0; i < ATKBD_KEYMAP_SIZE; i++)
-                if (atkbd->keycode[i] && atkbd->keycode[i] < ATKBD_SPECIAL)
+        for (i = 0; i < ATKBD_KEYMAP_SIZE; i++) {
+                if (atkbd->keycode[i] != KEY_RESERVED &&
+                    atkbd->keycode[i] != ATKBD_KEY_NULL &&
+                    atkbd->keycode[i] < ATKBD_SPECIAL) {
                         __set_bit(atkbd->keycode[i], input_dev->keybit);
+                }
+        }
 }
 
 /*
@@ -1086,16 +1104,18 @@ static int atkbd_connect(struct serio *serio, struct serio_driver *drv)
         atkbd->dev = dev;
         ps2_init(&atkbd->ps2dev, serio);
         INIT_DELAYED_WORK(&atkbd->event_work, atkbd_event_work);
-        mutex_init(&atkbd->event_mutex);
+        mutex_init(&atkbd->mutex);
 
         switch (serio->id.type) {
 
-                case SERIO_8042_XL:
-                        atkbd->translated = 1;
-                case SERIO_8042:
-                        if (serio->write)
-                                atkbd->write = 1;
-                        break;
+        case SERIO_8042_XL:
+                atkbd->translated = true;
+                /* Fall through */
+
+        case SERIO_8042:
+                if (serio->write)
+                        atkbd->write = true;
+                break;
         }
 
         atkbd->softraw = atkbd_softraw;
@@ -1103,7 +1123,7 @@ static int atkbd_connect(struct serio *serio, struct serio_driver *drv)
         atkbd->scroll = atkbd_scroll;
 
         if (atkbd->softrepeat)
-                atkbd->softraw = 1;
+                atkbd->softraw = true;
 
         serio_set_drvdata(serio, atkbd);
 
@@ -1159,19 +1179,24 @@ static int atkbd_reconnect(struct serio *serio)
 {
         struct atkbd *atkbd = serio_get_drvdata(serio);
         struct serio_driver *drv = serio->drv;
+        int retval = -1;
 
         if (!atkbd || !drv) {
-                printk(KERN_DEBUG "atkbd: reconnect request, but serio is disconnected, ignoring...\n");
+                dev_dbg(&serio->dev,
+                        "reconnect request, but serio is disconnected, ignoring...\n");
                 return -1;
         }
 
+        mutex_lock(&atkbd->mutex);
+
         atkbd_disable(atkbd);
 
         if (atkbd->write) {
                 if (atkbd_probe(atkbd))
-                        return -1;
+                        goto out;
+
                 if (atkbd->set != atkbd_select_set(atkbd, atkbd->set, atkbd->extra))
-                        return -1;
+                        goto out;
 
                 atkbd_activate(atkbd);
 
@@ -1189,8 +1214,11 @@ static int atkbd_reconnect(struct serio *serio)
         }
 
         atkbd_enable(atkbd);
+        retval = 0;
 
-        return 0;
+ out:
+        mutex_unlock(&atkbd->mutex);
+        return retval;
 }
 
 static struct serio_device_id atkbd_serio_ids[] = {
@@ -1234,47 +1262,28 @@ static ssize_t atkbd_attr_show_helper(struct device *dev, char *buf,
                                 ssize_t (*handler)(struct atkbd *, char *))
 {
         struct serio *serio = to_serio_port(dev);
-        int retval;
-
-        retval = serio_pin_driver(serio);
-        if (retval)
-                return retval;
-
-        if (serio->drv != &atkbd_drv) {
-                retval = -ENODEV;
-                goto out;
-        }
-
-        retval = handler((struct atkbd *)serio_get_drvdata(serio), buf);
+        struct atkbd *atkbd = serio_get_drvdata(serio);
 
-out:
-        serio_unpin_driver(serio);
-        return retval;
+        return handler(atkbd, buf);
 }
 
 static ssize_t atkbd_attr_set_helper(struct device *dev, const char *buf, size_t count,
                                 ssize_t (*handler)(struct atkbd *, const char *, size_t))
 {
         struct serio *serio = to_serio_port(dev);
-        struct atkbd *atkbd;
+        struct atkbd *atkbd = serio_get_drvdata(serio);
         int retval;
 
-        retval = serio_pin_driver(serio);
+        retval = mutex_lock_interruptible(&atkbd->mutex);
         if (retval)
                 return retval;
 
-        if (serio->drv != &atkbd_drv) {
-                retval = -ENODEV;
-                goto out;
-        }
-
-        atkbd = serio_get_drvdata(serio);
         atkbd_disable(atkbd);
         retval = handler(atkbd, buf, count);
         atkbd_enable(atkbd);
 
-out:
-        serio_unpin_driver(serio);
+        mutex_unlock(&atkbd->mutex);
+
         return retval;
 }
 
@@ -1288,7 +1297,8 @@ static ssize_t atkbd_set_extra(struct atkbd *atkbd, const char *buf, size_t coun
         struct input_dev *old_dev, *new_dev;
         unsigned long value;
         int err;
-        unsigned char old_extra, old_set;
+        bool old_extra;
+        unsigned char old_set;
 
         if (!atkbd->write)
                 return -EIO;
@@ -1371,7 +1381,7 @@ static ssize_t atkbd_set_scroll(struct atkbd *atkbd, const char *buf, size_t cou
         struct input_dev *old_dev, *new_dev;
         unsigned long value;
         int err;
-        unsigned char old_scroll;
+        bool old_scroll;
 
         if (strict_strtoul(buf, 10, &value) || value > 1)
                 return -EINVAL;
@@ -1415,7 +1425,8 @@ static ssize_t atkbd_set_set(struct atkbd *atkbd, const char *buf, size_t count)
         struct input_dev *old_dev, *new_dev;
         unsigned long value;
         int err;
-        unsigned char old_set, old_extra;
+        unsigned char old_set;
+        bool old_extra;
 
         if (!atkbd->write)
                 return -EIO;
@@ -1465,7 +1476,7 @@ static ssize_t atkbd_set_softrepeat(struct atkbd *atkbd, const char *buf, size_t
         struct input_dev *old_dev, *new_dev;
         unsigned long value;
         int err;
-        unsigned char old_softrepeat, old_softraw;
+        bool old_softrepeat, old_softraw;
 
         if (!atkbd->write)
                 return -EIO;
@@ -1485,7 +1496,7 @@ static ssize_t atkbd_set_softrepeat(struct atkbd *atkbd, const char *buf, size_t
                 atkbd->dev = new_dev;
                 atkbd->softrepeat = value;
                 if (atkbd->softrepeat)
-                        atkbd->softraw = 1;
+                        atkbd->softraw = true;
                 atkbd_set_device_attrs(atkbd);
 
                 err = input_register_device(atkbd->dev);
@@ -1515,7 +1526,7 @@ static ssize_t atkbd_set_softraw(struct atkbd *atkbd, const char *buf, size_t co
         struct input_dev *old_dev, *new_dev;
         unsigned long value;
         int err;
-        unsigned char old_softraw;
+        bool old_softraw;
 
         if (strict_strtoul(buf, 10, &value) || value > 1)
                 return -EINVAL;
@@ -1567,9 +1578,8 @@ static int __init atkbd_setup_scancode_fixup(const struct dmi_system_id *id)
         return 0;
 }
 
-static struct dmi_system_id atkbd_dmi_quirk_table[] __initdata = {
+static const struct dmi_system_id atkbd_dmi_quirk_table[] __initconst = {
         {
-                .ident = "Dell Laptop",
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
                         DMI_MATCH(DMI_CHASSIS_TYPE, "8"), /* Portable */
@@ -1578,7 +1588,6 @@ static struct dmi_system_id atkbd_dmi_quirk_table[] __initdata = {
                 .driver_data = atkbd_dell_laptop_forced_release_keys,
         },
         {
-                .ident = "Dell Laptop",
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "Dell Computer Corporation"),
                         DMI_MATCH(DMI_CHASSIS_TYPE, "8"), /* Portable */
@@ -1587,7 +1596,6 @@ static struct dmi_system_id atkbd_dmi_quirk_table[] __initdata = {
                 .driver_data = atkbd_dell_laptop_forced_release_keys,
         },
         {
-                .ident = "HP 2133",
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"),
                         DMI_MATCH(DMI_PRODUCT_NAME, "HP 2133"),
@@ -1596,7 +1604,6 @@ static struct dmi_system_id atkbd_dmi_quirk_table[] __initdata = {
                 .driver_data = atkbd_hp_forced_release_keys,
         },
         {
-                .ident = "HP Pavilion ZV6100",
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"),
                         DMI_MATCH(DMI_PRODUCT_NAME, "Pavilion ZV6100"),
@@ -1605,7 +1612,6 @@ static struct dmi_system_id atkbd_dmi_quirk_table[] __initdata = {
                 .driver_data = atkbd_volume_forced_release_keys,
         },
         {
-                .ident = "HP Presario R4000",
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"),
                         DMI_MATCH(DMI_PRODUCT_NAME, "Presario R4000"),
@@ -1614,7 +1620,6 @@ static struct dmi_system_id atkbd_dmi_quirk_table[] __initdata = {
                 .driver_data = atkbd_volume_forced_release_keys,
         },
         {
-                .ident = "HP Presario R4100",
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"),
                         DMI_MATCH(DMI_PRODUCT_NAME, "Presario R4100"),
@@ -1623,7 +1628,6 @@ static struct dmi_system_id atkbd_dmi_quirk_table[] __initdata = {
                 .driver_data = atkbd_volume_forced_release_keys,
         },
         {
-                .ident = "HP Presario R4200",
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"),
                         DMI_MATCH(DMI_PRODUCT_NAME, "Presario R4200"),
@@ -1632,7 +1636,7 @@ static struct dmi_system_id atkbd_dmi_quirk_table[] __initdata = {
                 .driver_data = atkbd_volume_forced_release_keys,
         },
         {
-                .ident = "Inventec Symphony",
+                /* Inventec Symphony */
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "INVENTEC"),
                         DMI_MATCH(DMI_PRODUCT_NAME, "SYMPHONY 6.0/7.0"),
@@ -1641,7 +1645,7 @@ static struct dmi_system_id atkbd_dmi_quirk_table[] __initdata = {
                 .driver_data = atkbd_volume_forced_release_keys,
         },
         {
-                .ident = "Samsung NC10",
+                /* Samsung NC10 */
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "SAMSUNG ELECTRONICS CO., LTD."),
                         DMI_MATCH(DMI_PRODUCT_NAME, "NC10"),
@@ -1650,7 +1654,7 @@ static struct dmi_system_id atkbd_dmi_quirk_table[] __initdata = {
                 .driver_data = atkbd_samsung_forced_release_keys,
         },
         {
-                .ident = "Samsung NC20",
+                /* Samsung NC20 */
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "SAMSUNG ELECTRONICS CO., LTD."),
                         DMI_MATCH(DMI_PRODUCT_NAME, "NC20"),
@@ -1659,7 +1663,7 @@ static struct dmi_system_id atkbd_dmi_quirk_table[] __initdata = {
                 .driver_data = atkbd_samsung_forced_release_keys,
         },
         {
-                .ident = "Samsung SQ45S70S",
+                /* Samsung SQ45S70S */
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "SAMSUNG ELECTRONICS CO., LTD."),
                         DMI_MATCH(DMI_PRODUCT_NAME, "SQ45S70S"),
@@ -1668,7 +1672,7 @@ static struct dmi_system_id atkbd_dmi_quirk_table[] __initdata = {
                 .driver_data = atkbd_samsung_forced_release_keys,
         },
         {
-                .ident = "Fujitsu Amilo PA 1510",
+                /* Fujitsu Amilo PA 1510 */
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "FUJITSU SIEMENS"),
                         DMI_MATCH(DMI_PRODUCT_NAME, "AMILO Pa 1510"),
@@ -1677,7 +1681,7 @@ static struct dmi_system_id atkbd_dmi_quirk_table[] __initdata = {
                 .driver_data = atkbd_volume_forced_release_keys,
         },
         {
-                .ident = "Fujitsu Amilo Pi 3525",
+                /* Fujitsu Amilo Pi 3525 */
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "FUJITSU SIEMENS"),
                         DMI_MATCH(DMI_PRODUCT_NAME, "AMILO Pi 3525"),
@@ -1686,7 +1690,7 @@ static struct dmi_system_id atkbd_dmi_quirk_table[] __initdata = {
                 .driver_data = atkbd_amilo_pi3525_forced_release_keys,
         },
         {
-                .ident = "Fujitsu Amilo Xi 3650",
+                /* Fujitsu Amilo Xi 3650 */
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "FUJITSU SIEMENS"),
                         DMI_MATCH(DMI_PRODUCT_NAME, "AMILO Xi 3650"),
@@ -1695,7 +1699,6 @@ static struct dmi_system_id atkbd_dmi_quirk_table[] __initdata = {
                 .driver_data = atkbd_amilo_xi3650_forced_release_keys,
         },
         {
-                .ident = "Soltech Corporation TA12",
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "Soltech Corporation"),
                         DMI_MATCH(DMI_PRODUCT_NAME, "TA12"),
@@ -1704,7 +1707,7 @@ static struct dmi_system_id atkbd_dmi_quirk_table[] __initdata = {
                 .driver_data = atkdb_soltech_ta12_forced_release_keys,
         },
         {
-                .ident = "OQO Model 01+",
+                /* OQO Model 01+ */
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "OQO"),
                         DMI_MATCH(DMI_PRODUCT_NAME, "ZEPTO"),
diff --git a/drivers/input/keyboard/bf54x-keys.c b/drivers/input/keyboard/bf54x-keys.c
index fe376a27fe57..7d989603f875 100644
--- a/drivers/input/keyboard/bf54x-keys.c
+++ b/drivers/input/keyboard/bf54x-keys.c
@@ -34,6 +34,7 @@
 #include <linux/fs.h>
 #include <linux/interrupt.h>
 #include <linux/irq.h>
+#include <linux/slab.h>
 #include <linux/sched.h>
 #include <linux/pm.h>
 #include <linux/sysctl.h>
@@ -162,7 +163,7 @@ static irqreturn_t bfin_kpad_isr(int irq, void *dev_id)
         input_sync(input);
 
         if (bfin_kpad_get_keypressed(bf54x_kpad)) {
-                disable_irq(bf54x_kpad->irq);
+                disable_irq_nosync(bf54x_kpad->irq);
                 bf54x_kpad->lastkey = key;
                 mod_timer(&bf54x_kpad->timer,
                           jiffies + bf54x_kpad->keyup_test_jiffies);
diff --git a/drivers/input/keyboard/davinci_keyscan.c b/drivers/input/keyboard/davinci_keyscan.c
new file mode 100644
index 000000000000..a91ee941b5c1
--- /dev/null
+++ b/drivers/input/keyboard/davinci_keyscan.c
@@ -0,0 +1,346 @@
+/*
+ * DaVinci Key Scan Driver for TI platforms
+ *
+ * Copyright (C) 2009 Texas Instruments, Inc
+ *
+ * Author: Miguel Aguilar <miguel.aguilar@ridgerun.com>
+ *
+ * Intial Code: Sandeep Paulraj <s-paulraj@ti.com>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
+ */
+#include <linux/module.h>
+#include <linux/init.h>
+#include <linux/interrupt.h>
+#include <linux/types.h>
+#include <linux/input.h>
+#include <linux/kernel.h>
+#include <linux/delay.h>
+#include <linux/platform_device.h>
+#include <linux/errno.h>
+#include <linux/slab.h>
+
+#include <asm/irq.h>
+
+#include <mach/hardware.h>
+#include <mach/irqs.h>
+#include <mach/keyscan.h>
+
+/* Key scan registers */
+#define DAVINCI_KEYSCAN_KEYCTRL         0x0000
+#define DAVINCI_KEYSCAN_INTENA          0x0004
+#define DAVINCI_KEYSCAN_INTFLAG         0x0008
+#define DAVINCI_KEYSCAN_INTCLR          0x000c
+#define DAVINCI_KEYSCAN_STRBWIDTH       0x0010
+#define DAVINCI_KEYSCAN_INTERVAL        0x0014
+#define DAVINCI_KEYSCAN_CONTTIME        0x0018
+#define DAVINCI_KEYSCAN_CURRENTST       0x001c
+#define DAVINCI_KEYSCAN_PREVSTATE       0x0020
+#define DAVINCI_KEYSCAN_EMUCTRL         0x0024
+#define DAVINCI_KEYSCAN_IODFTCTRL       0x002c
+
+/* Key Control Register (KEYCTRL) */
+#define DAVINCI_KEYSCAN_KEYEN           0x00000001
+#define DAVINCI_KEYSCAN_PREVMODE        0x00000002
+#define DAVINCI_KEYSCAN_CHATOFF         0x00000004
+#define DAVINCI_KEYSCAN_AUTODET         0x00000008
+#define DAVINCI_KEYSCAN_SCANMODE        0x00000010
+#define DAVINCI_KEYSCAN_OUTTYPE         0x00000020
+
+/* Masks for the interrupts */
+#define DAVINCI_KEYSCAN_INT_CONT        0x00000008
+#define DAVINCI_KEYSCAN_INT_OFF         0x00000004
+#define DAVINCI_KEYSCAN_INT_ON          0x00000002
+#define DAVINCI_KEYSCAN_INT_CHANGE      0x00000001
+#define DAVINCI_KEYSCAN_INT_ALL         0x0000000f
+
+struct davinci_ks {
+        struct input_dev                *input;
+        struct davinci_ks_platform_data *pdata;
+        int                             irq;
+        void __iomem                    *base;
+        resource_size_t                 pbase;
+        size_t                          base_size;
+        unsigned short                  keymap[];
+};
+
+/* Initializing the kp Module */
+static int __init davinci_ks_initialize(struct davinci_ks *davinci_ks)
+{
+        struct device *dev = &davinci_ks->input->dev;
+        struct davinci_ks_platform_data *pdata = davinci_ks->pdata;
+        u32 matrix_ctrl;
+
+        /* Enable all interrupts */
+        __raw_writel(DAVINCI_KEYSCAN_INT_ALL,
+                     davinci_ks->base + DAVINCI_KEYSCAN_INTENA);
+
+        /* Clear interrupts if any */
+        __raw_writel(DAVINCI_KEYSCAN_INT_ALL,
+                     davinci_ks->base + DAVINCI_KEYSCAN_INTCLR);
+
+        /* Setup the scan period = strobe + interval */
+        __raw_writel(pdata->strobe,
+                     davinci_ks->base + DAVINCI_KEYSCAN_STRBWIDTH);
+        __raw_writel(pdata->interval,
+                     davinci_ks->base + DAVINCI_KEYSCAN_INTERVAL);
+        __raw_writel(0x01,
+                     davinci_ks->base + DAVINCI_KEYSCAN_CONTTIME);
+
+        /* Define matrix type */
+        switch (pdata->matrix_type) {
+        case DAVINCI_KEYSCAN_MATRIX_4X4:
+                matrix_ctrl = 0;
+                break;
+        case DAVINCI_KEYSCAN_MATRIX_5X3:
+                matrix_ctrl = (1 << 6);
+                break;
+        default:
+                dev_err(dev->parent, "wrong matrix type\n");
+                return -EINVAL;
+        }
+
+        /* Enable key scan module and set matrix type */
+        __raw_writel(DAVINCI_KEYSCAN_AUTODET | DAVINCI_KEYSCAN_KEYEN |
+                     matrix_ctrl, davinci_ks->base + DAVINCI_KEYSCAN_KEYCTRL);
+
+        return 0;
+}
+
+static irqreturn_t davinci_ks_interrupt(int irq, void *dev_id)
+{
+        struct davinci_ks *davinci_ks = dev_id;
+        struct device *dev = &davinci_ks->input->dev;
+        unsigned short *keymap = davinci_ks->keymap;
+        int keymapsize = davinci_ks->pdata->keymapsize;
+        u32 prev_status, new_status, changed;
+        bool release;
+        int keycode = KEY_UNKNOWN;
+        int i;
+
+        /* Disable interrupt */
+        __raw_writel(0x0, davinci_ks->base + DAVINCI_KEYSCAN_INTENA);
+
+        /* Reading previous and new status of the key scan */
+        prev_status = __raw_readl(davinci_ks->base + DAVINCI_KEYSCAN_PREVSTATE);
+        new_status = __raw_readl(davinci_ks->base + DAVINCI_KEYSCAN_CURRENTST);
+
+        changed = prev_status ^ new_status;
+
+        if (changed) {
+                /*
+                 * It goes through all bits in 'changed' to ensure
+                 * that no key changes are being missed
+                 */
+                for (i = 0 ; i < keymapsize; i++) {
+                        if ((changed>>i) & 0x1) {
+                                keycode = keymap[i];
+                                release = (new_status >> i) & 0x1;
+                                dev_dbg(dev->parent, "key %d %s\n", keycode,
+                                        release ? "released" : "pressed");
+                                input_report_key(davinci_ks->input, keycode,
+                                                 !release);
+                                input_sync(davinci_ks->input);
+                        }
+                }
+                /* Clearing interrupt */
+                __raw_writel(DAVINCI_KEYSCAN_INT_ALL,
+                             davinci_ks->base + DAVINCI_KEYSCAN_INTCLR);
+        }
+
+        /* Enable interrupts */
+        __raw_writel(0x1, davinci_ks->base + DAVINCI_KEYSCAN_INTENA);
+
+        return IRQ_HANDLED;
+}
+
+static int __init davinci_ks_probe(struct platform_device *pdev)
+{
+        struct davinci_ks *davinci_ks;
+        struct input_dev *key_dev;
+        struct resource *res, *mem;
+        struct device *dev = &pdev->dev;
+        struct davinci_ks_platform_data *pdata = pdev->dev.platform_data;
+        int error, i;
+
+        if (pdata->device_enable) {
+                error = pdata->device_enable(dev);
+                if (error < 0) {
+                        dev_dbg(dev, "device enable function failed\n");
+                        return error;
+                }
+        }
+
+        if (!pdata->keymap) {
+                dev_dbg(dev, "no keymap from pdata\n");
+                return -EINVAL;
+        }
+
+        davinci_ks = kzalloc(sizeof(struct davinci_ks) +
+                sizeof(unsigned short) * pdata->keymapsize, GFP_KERNEL);
+        if (!davinci_ks) {
+                dev_dbg(dev, "could not allocate memory for private data\n");
+                return -ENOMEM;
+        }
+
+        memcpy(davinci_ks->keymap, pdata->keymap,
+                sizeof(unsigned short) * pdata->keymapsize);
+
+        key_dev = input_allocate_device();
+        if (!key_dev) {
+                dev_dbg(dev, "could not allocate input device\n");
+                error = -ENOMEM;
+                goto fail1;
+        }
+
+        davinci_ks->input = key_dev;
+
+        davinci_ks->irq = platform_get_irq(pdev, 0);
+        if (davinci_ks->irq < 0) {
+                dev_err(dev, "no key scan irq\n");
+                error = davinci_ks->irq;
+                goto fail2;
+        }
+
+        res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
+        if (!res) {
+                dev_err(dev, "no mem resource\n");
+                error = -EINVAL;
+                goto fail2;
+        }
+
+        davinci_ks->pbase = res->start;
+        davinci_ks->base_size = resource_size(res);
+
+        mem = request_mem_region(davinci_ks->pbase, davinci_ks->base_size,
+                                 pdev->name);
+        if (!mem) {
+                dev_err(dev, "key scan registers at %08x are not free\n",
+                        davinci_ks->pbase);
+                error = -EBUSY;
+                goto fail2;
+        }
+
+        davinci_ks->base = ioremap(davinci_ks->pbase, davinci_ks->base_size);
+        if (!davinci_ks->base) {
+                dev_err(dev, "can't ioremap MEM resource.\n");
+                error = -ENOMEM;
+                goto fail3;
+        }
+
+        /* Enable auto repeat feature of Linux input subsystem */
+        if (pdata->rep)
+                __set_bit(EV_REP, key_dev->evbit);
+
+        /* Setup input device */
+        __set_bit(EV_KEY, key_dev->evbit);
+
+        /* Setup the platform data */
+        davinci_ks->pdata = pdata;
+
+        for (i = 0; i < davinci_ks->pdata->keymapsize; i++)
+                __set_bit(davinci_ks->pdata->keymap[i], key_dev->keybit);
+
+        key_dev->name = "davinci_keyscan";
+        key_dev->phys = "davinci_keyscan/input0";
+        key_dev->dev.parent = &pdev->dev;
+        key_dev->id.bustype = BUS_HOST;
+        key_dev->id.vendor = 0x0001;
+        key_dev->id.product = 0x0001;
+        key_dev->id.version = 0x0001;
+        key_dev->keycode = davinci_ks->keymap;
+        key_dev->keycodesize = sizeof(davinci_ks->keymap[0]);
+        key_dev->keycodemax = davinci_ks->pdata->keymapsize;
+
+        error = input_register_device(davinci_ks->input);
+        if (error < 0) {
+                dev_err(dev, "unable to register davinci key scan device\n");
+                goto fail4;
+        }
+
+        error = request_irq(davinci_ks->irq, davinci_ks_interrupt,
+                          IRQF_DISABLED, pdev->name, davinci_ks);
+        if (error < 0) {
+                dev_err(dev, "unable to register davinci key scan interrupt\n");
+                goto fail5;
+        }
+
+        error = davinci_ks_initialize(davinci_ks);
+        if (error < 0) {
+                dev_err(dev, "unable to initialize davinci key scan device\n");
+                goto fail6;
+        }
+
+        platform_set_drvdata(pdev, davinci_ks);
+        return 0;
+
+fail6:
+        free_irq(davinci_ks->irq, davinci_ks);
+fail5:
+        input_unregister_device(davinci_ks->input);
+        key_dev = NULL;
+fail4:
+        iounmap(davinci_ks->base);
+fail3:
+        release_mem_region(davinci_ks->pbase, davinci_ks->base_size);
+fail2:
+        input_free_device(key_dev);
+fail1:
+        kfree(davinci_ks);
+
+        return error;
+}
+
+static int __devexit davinci_ks_remove(struct platform_device *pdev)
+{
+        struct davinci_ks *davinci_ks = platform_get_drvdata(pdev);
+
+        free_irq(davinci_ks->irq, davinci_ks);
+
+        input_unregister_device(davinci_ks->input);
+
+        iounmap(davinci_ks->base);
+        release_mem_region(davinci_ks->pbase, davinci_ks->base_size);
+
+        platform_set_drvdata(pdev, NULL);
+
+        kfree(davinci_ks);
+
+        return 0;
+}
+
+static struct platform_driver davinci_ks_driver = {
+        .driver = {
+                .name = "davinci_keyscan",
+                .owner = THIS_MODULE,
+        },
+        .remove = __devexit_p(davinci_ks_remove),
+};
+
+static int __init davinci_ks_init(void)
+{
+        return platform_driver_probe(&davinci_ks_driver, davinci_ks_probe);
+}
+module_init(davinci_ks_init);
+
+static void __exit davinci_ks_exit(void)
+{
+        platform_driver_unregister(&davinci_ks_driver);
+}
+module_exit(davinci_ks_exit);
+
+MODULE_AUTHOR("Miguel Aguilar");
+MODULE_DESCRIPTION("Texas Instruments DaVinci Key Scan Driver");
+MODULE_LICENSE("GPL");
diff --git a/drivers/input/keyboard/ep93xx_keypad.c b/drivers/input/keyboard/ep93xx_keypad.c
index 181d30e3018e..c8242dd190d0 100644
--- a/drivers/input/keyboard/ep93xx_keypad.c
+++ b/drivers/input/keyboard/ep93xx_keypad.c
@@ -22,11 +22,12 @@
 
 #include <linux/platform_device.h>
 #include <linux/interrupt.h>
-#include <linux/input.h>
 #include <linux/clk.h>
+#include <linux/io.h>
+#include <linux/input/matrix_keypad.h>
+#include <linux/slab.h>
 
 #include <mach/hardware.h>
-#include <mach/gpio.h>
 #include <mach/ep93xx_keypad.h>
 
 /*
@@ -60,56 +61,39 @@
 #define KEY_REG_KEY1_MASK       (0x0000003f)
 #define KEY_REG_KEY1_SHIFT      (0)
 
-#define keypad_readl(off)       __raw_readl(keypad->mmio_base + (off))
-#define keypad_writel(v, off)   __raw_writel((v), keypad->mmio_base + (off))
-
-#define MAX_MATRIX_KEY_NUM      (MAX_MATRIX_KEY_ROWS * MAX_MATRIX_KEY_COLS)
+#define EP93XX_MATRIX_SIZE      (EP93XX_MATRIX_ROWS * EP93XX_MATRIX_COLS)
 
 struct ep93xx_keypad {
         struct ep93xx_keypad_platform_data *pdata;
-
-        struct clk *clk;
         struct input_dev *input_dev;
+        struct clk *clk;
+
         void __iomem *mmio_base;
 
-        int irq;
-        int enabled;
+        unsigned short keycodes[EP93XX_MATRIX_SIZE];
 
         int key1;
         int key2;
 
-        unsigned int matrix_keycodes[MAX_MATRIX_KEY_NUM];
-};
-
-static void ep93xx_keypad_build_keycode(struct ep93xx_keypad *keypad)
-{
-        struct ep93xx_keypad_platform_data *pdata = keypad->pdata;
-        struct input_dev *input_dev = keypad->input_dev;
-        int i;
-
-        for (i = 0; i < pdata->matrix_key_map_size; i++) {
-                unsigned int key = pdata->matrix_key_map[i];
-                int row = (key >> 28) & 0xf;
-                int col = (key >> 24) & 0xf;
-                int code = key & 0xffffff;
+        int irq;
 
-                keypad->matrix_keycodes[(row << 3) + col] = code;
-                __set_bit(code, input_dev->keybit);
-        }
-}
+        bool enabled;
+};
 
 static irqreturn_t ep93xx_keypad_irq_handler(int irq, void *dev_id)
 {
         struct ep93xx_keypad *keypad = dev_id;
         struct input_dev *input_dev = keypad->input_dev;
-        unsigned int status = keypad_readl(KEY_REG);
+        unsigned int status;
         int keycode, key1, key2;
 
+        status = __raw_readl(keypad->mmio_base + KEY_REG);
+
         keycode = (status & KEY_REG_KEY1_MASK) >> KEY_REG_KEY1_SHIFT;
-        key1 = keypad->matrix_keycodes[keycode];
+        key1 = keypad->keycodes[keycode];
 
         keycode = (status & KEY_REG_KEY2_MASK) >> KEY_REG_KEY2_SHIFT;
-        key2 = keypad->matrix_keycodes[keycode];
+        key2 = keypad->keycodes[keycode];
 
         if (status & KEY_REG_2KEYS) {
                 if (keypad->key1 && key1 != keypad->key1 && key2 != keypad->key1)
@@ -152,7 +136,10 @@ static void ep93xx_keypad_config(struct ep93xx_keypad *keypad)
         struct ep93xx_keypad_platform_data *pdata = keypad->pdata;
         unsigned int val = 0;
 
-        clk_set_rate(keypad->clk, pdata->flags & EP93XX_KEYPAD_KDIV);
+        if (pdata->flags & EP93XX_KEYPAD_KDIV)
+                clk_set_rate(keypad->clk, EP93XX_KEYTCHCLK_DIV4);
+        else
+                clk_set_rate(keypad->clk, EP93XX_KEYTCHCLK_DIV16);
 
         if (pdata->flags & EP93XX_KEYPAD_DISABLE_3_KEY)
                 val |= KEY_INIT_DIS3KY;
@@ -167,7 +154,7 @@ static void ep93xx_keypad_config(struct ep93xx_keypad *keypad)
 
         val |= ((pdata->prescale << KEY_INIT_PRSCL_SHIFT) & KEY_INIT_PRSCL_MASK);
 
-        keypad_writel(val, KEY_INIT);
+        __raw_writel(val, keypad->mmio_base + KEY_INIT);
 }
 
 static int ep93xx_keypad_open(struct input_dev *pdev)
@@ -177,7 +164,7 @@ static int ep93xx_keypad_open(struct input_dev *pdev)
         if (!keypad->enabled) {
                 ep93xx_keypad_config(keypad);
                 clk_enable(keypad->clk);
-                keypad->enabled = 1;
+                keypad->enabled = true;
         }
 
         return 0;
@@ -189,7 +176,7 @@ static void ep93xx_keypad_close(struct input_dev *pdev)
 
         if (keypad->enabled) {
                 clk_disable(keypad->clk);
-                keypad->enabled = 0;
+                keypad->enabled = false;
         }
 }
 
@@ -211,7 +198,7 @@ static int ep93xx_keypad_suspend(struct platform_device *pdev,
 
         if (keypad->enabled) {
                 clk_disable(keypad->clk);
-                keypad->enabled = 0;
+                keypad->enabled = false;
         }
 
         mutex_unlock(&input_dev->mutex);
@@ -236,7 +223,7 @@ static int ep93xx_keypad_resume(struct platform_device *pdev)
                 if (!keypad->enabled) {
                         ep93xx_keypad_config(keypad);
                         clk_enable(keypad->clk);
-                        keypad->enabled = 1;
+                        keypad->enabled = true;
                 }
         }
 
@@ -252,88 +239,63 @@ static int ep93xx_keypad_resume(struct platform_device *pdev)
 static int __devinit ep93xx_keypad_probe(struct platform_device *pdev)
 {
         struct ep93xx_keypad *keypad;
-        struct ep93xx_keypad_platform_data *pdata = pdev->dev.platform_data;
+        const struct matrix_keymap_data *keymap_data;
         struct input_dev *input_dev;
         struct resource *res;
-        int irq, err, i, gpio;
-
-        if (!pdata ||
-            !pdata->matrix_key_rows ||
-            pdata->matrix_key_rows > MAX_MATRIX_KEY_ROWS ||
-            !pdata->matrix_key_cols ||
-            pdata->matrix_key_cols > MAX_MATRIX_KEY_COLS) {
-                dev_err(&pdev->dev, "invalid or missing platform data\n");
-                return -EINVAL;
-        }
+        int err;
 
         keypad = kzalloc(sizeof(struct ep93xx_keypad), GFP_KERNEL);
-        if (!keypad) {
-                dev_err(&pdev->dev, "failed to allocate driver data\n");
+        if (!keypad)
                 return -ENOMEM;
+
+        keypad->pdata = pdev->dev.platform_data;
+        if (!keypad->pdata) {
+                err = -EINVAL;
+                goto failed_free;
         }
 
-        keypad->pdata = pdata;
+        keymap_data = keypad->pdata->keymap_data;
+        if (!keymap_data) {
+                err = -EINVAL;
+                goto failed_free;
+        }
 
-        irq = platform_get_irq(pdev, 0);
-        if (irq < 0) {
-                dev_err(&pdev->dev, "failed to get keypad irq\n");
+        keypad->irq = platform_get_irq(pdev, 0);
+        if (!keypad->irq) {
                 err = -ENXIO;
                 goto failed_free;
         }
 
         res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
         if (!res) {
-                dev_err(&pdev->dev, "failed to get I/O memory\n");
                 err = -ENXIO;
                 goto failed_free;
         }
 
         res = request_mem_region(res->start, resource_size(res), pdev->name);
         if (!res) {
-                dev_err(&pdev->dev, "failed to request I/O memory\n");
                 err = -EBUSY;
                 goto failed_free;
         }
 
         keypad->mmio_base = ioremap(res->start, resource_size(res));
         if (keypad->mmio_base == NULL) {
-                dev_err(&pdev->dev, "failed to remap I/O memory\n");
                 err = -ENXIO;
                 goto failed_free_mem;
         }
 
-        /* Request the needed GPIO's */
-        gpio = EP93XX_GPIO_LINE_ROW0;
-        for (i = 0; i < keypad->pdata->matrix_key_rows; i++, gpio++) {
-                err = gpio_request(gpio, pdev->name);
-                if (err) {
-                        dev_err(&pdev->dev, "failed to request gpio-%d\n",
-                                gpio);
-                        goto failed_free_rows;
-                }
-        }
-
-        gpio = EP93XX_GPIO_LINE_COL0;
-        for (i = 0; i < keypad->pdata->matrix_key_cols; i++, gpio++) {
-                err = gpio_request(gpio, pdev->name);
-                if (err) {
-                        dev_err(&pdev->dev, "failed to request gpio-%d\n",
-                                gpio);
-                        goto failed_free_cols;
-                }
-        }
+        err = ep93xx_keypad_acquire_gpio(pdev);
+        if (err)
+                goto failed_free_io;
 
-        keypad->clk = clk_get(&pdev->dev, "key_clk");
+        keypad->clk = clk_get(&pdev->dev, NULL);
         if (IS_ERR(keypad->clk)) {
-                dev_err(&pdev->dev, "failed to get keypad clock\n");
                 err = PTR_ERR(keypad->clk);
-                goto failed_free_io;
+                goto failed_free_gpio;
         }
 
-        /* Create and register the input driver */
         input_dev = input_allocate_device();
         if (!input_dev) {
-                dev_err(&pdev->dev, "failed to allocate input device\n");
                 err = -ENOMEM;
                 goto failed_put_clk;
         }
@@ -345,9 +307,9 @@ static int __devinit ep93xx_keypad_probe(struct platform_device *pdev)
         input_dev->open = ep93xx_keypad_open;
         input_dev->close = ep93xx_keypad_close;
         input_dev->dev.parent = &pdev->dev;
-        input_dev->keycode = keypad->matrix_keycodes;
-        input_dev->keycodesize = sizeof(keypad->matrix_keycodes[0]);
-        input_dev->keycodemax = ARRAY_SIZE(keypad->matrix_keycodes);
+        input_dev->keycode = keypad->keycodes;
+        input_dev->keycodesize = sizeof(keypad->keycodes[0]);
+        input_dev->keycodemax = ARRAY_SIZE(keypad->keycodes);
 
         input_set_drvdata(input_dev, keypad);
 
@@ -355,47 +317,33 @@ static int __devinit ep93xx_keypad_probe(struct platform_device *pdev)
         if (keypad->pdata->flags & EP93XX_KEYPAD_AUTOREPEAT)
                 input_dev->evbit[0] |= BIT_MASK(EV_REP);
 
-        ep93xx_keypad_build_keycode(keypad);
+        matrix_keypad_build_keymap(keymap_data, 3,
+                                   input_dev->keycode, input_dev->keybit);
         platform_set_drvdata(pdev, keypad);
 
-        err = request_irq(irq, ep93xx_keypad_irq_handler, IRQF_DISABLED,
-                                pdev->name, keypad);
-        if (err) {
-                dev_err(&pdev->dev, "failed to request IRQ\n");
+        err = request_irq(keypad->irq, ep93xx_keypad_irq_handler,
+                          IRQF_DISABLED, pdev->name, keypad);
+        if (err)
                 goto failed_free_dev;
-        }
 
-        keypad->irq = irq;
-
-        /* Register the input device */
         err = input_register_device(input_dev);
-        if (err) {
-                dev_err(&pdev->dev, "failed to register input device\n");
+        if (err)
                 goto failed_free_irq;
-        }
 
         device_init_wakeup(&pdev->dev, 1);
 
         return 0;
 
 failed_free_irq:
-        free_irq(irq, pdev);
+        free_irq(keypad->irq, pdev);
         platform_set_drvdata(pdev, NULL);
 failed_free_dev:
         input_free_device(input_dev);
 failed_put_clk:
         clk_put(keypad->clk);
+failed_free_gpio:
+        ep93xx_keypad_release_gpio(pdev);
 failed_free_io:
-        i = keypad->pdata->matrix_key_cols - 1;
-        gpio = EP93XX_GPIO_LINE_COL0 + i;
-failed_free_cols:
-        for ( ; i >= 0; i--, gpio--)
-                gpio_free(gpio);
-        i = keypad->pdata->matrix_key_rows - 1;
-        gpio = EP93XX_GPIO_LINE_ROW0 + i;
-failed_free_rows:
-        for ( ; i >= 0; i--, gpio--)
-                gpio_free(gpio);
         iounmap(keypad->mmio_base);
 failed_free_mem:
         release_mem_region(res->start, resource_size(res));
@@ -408,7 +356,6 @@ static int __devexit ep93xx_keypad_remove(struct platform_device *pdev)
 {
         struct ep93xx_keypad *keypad = platform_get_drvdata(pdev);
         struct resource *res;
-        int i, gpio;
 
         free_irq(keypad->irq, pdev);
 
@@ -420,15 +367,7 @@ static int __devexit ep93xx_keypad_remove(struct platform_device *pdev)
 
         input_unregister_device(keypad->input_dev);
 
-        i = keypad->pdata->matrix_key_cols - 1;
-        gpio = EP93XX_GPIO_LINE_COL0 + i;
-        for ( ; i >= 0; i--, gpio--)
-                gpio_free(gpio);
-
-        i = keypad->pdata->matrix_key_rows - 1;
-        gpio = EP93XX_GPIO_LINE_ROW0 + i;
-        for ( ; i >= 0; i--, gpio--)
-                gpio_free(gpio);
+        ep93xx_keypad_release_gpio(pdev);
 
         iounmap(keypad->mmio_base);
 
diff --git a/drivers/input/keyboard/gpio_keys.c b/drivers/input/keyboard/gpio_keys.c
index 77d130914259..b8213fd13c3f 100644
--- a/drivers/input/keyboard/gpio_keys.c
+++ b/drivers/input/keyboard/gpio_keys.c
@@ -16,6 +16,7 @@
 #include <linux/irq.h>
 #include <linux/sched.h>
 #include <linux/pm.h>
+#include <linux/slab.h>
 #include <linux/sysctl.h>
 #include <linux/proc_fs.h>
 #include <linux/delay.h>
@@ -23,25 +24,298 @@
 #include <linux/input.h>
 #include <linux/gpio_keys.h>
 #include <linux/workqueue.h>
-
-#include <asm/gpio.h>
+#include <linux/gpio.h>
 
 struct gpio_button_data {
         struct gpio_keys_button *button;
         struct input_dev *input;
         struct timer_list timer;
         struct work_struct work;
+        bool disabled;
 };
 
 struct gpio_keys_drvdata {
         struct input_dev *input;
+        struct mutex disable_lock;
+        unsigned int n_buttons;
         struct gpio_button_data data[0];
 };
 
-static void gpio_keys_report_event(struct work_struct *work)
+/*
+ * SYSFS interface for enabling/disabling keys and switches:
+ *
+ * There are 4 attributes under /sys/devices/platform/gpio-keys/
+ *      keys [ro]              - bitmap of keys (EV_KEY) which can be
+ *                               disabled
+ *      switches [ro]          - bitmap of switches (EV_SW) which can be
+ *                               disabled
+ *      disabled_keys [rw]     - bitmap of keys currently disabled
+ *      disabled_switches [rw] - bitmap of switches currently disabled
+ *
+ * Userland can change these values and hence disable event generation
+ * for each key (or switch). Disabling a key means its interrupt line
+ * is disabled.
+ *
+ * For example, if we have following switches set up as gpio-keys:
+ *      SW_DOCK = 5
+ *      SW_CAMERA_LENS_COVER = 9
+ *      SW_KEYPAD_SLIDE = 10
+ *      SW_FRONT_PROXIMITY = 11
+ * This is read from switches:
+ *      11-9,5
+ * Next we want to disable proximity (11) and dock (5), we write:
+ *      11,5
+ * to file disabled_switches. Now proximity and dock IRQs are disabled.
+ * This can be verified by reading the file disabled_switches:
+ *      11,5
+ * If we now want to enable proximity (11) switch we write:
+ *      5
+ * to disabled_switches.
+ *
+ * We can disable only those keys which don't allow sharing the irq.
+ */
+
+/**
+ * get_n_events_by_type() - returns maximum number of events per @type
+ * @type: type of button (%EV_KEY, %EV_SW)
+ *
+ * Return value of this function can be used to allocate bitmap
+ * large enough to hold all bits for given type.
+ */
+static inline int get_n_events_by_type(int type)
+{
+        BUG_ON(type != EV_SW && type != EV_KEY);
+
+        return (type == EV_KEY) ? KEY_CNT : SW_CNT;
+}
+
+/**
+ * gpio_keys_disable_button() - disables given GPIO button
+ * @bdata: button data for button to be disabled
+ *
+ * Disables button pointed by @bdata. This is done by masking
+ * IRQ line. After this function is called, button won't generate
+ * input events anymore. Note that one can only disable buttons
+ * that don't share IRQs.
+ *
+ * Make sure that @bdata->disable_lock is locked when entering
+ * this function to avoid races when concurrent threads are
+ * disabling buttons at the same time.
+ */
+static void gpio_keys_disable_button(struct gpio_button_data *bdata)
+{
+        if (!bdata->disabled) {
+                /*
+                 * Disable IRQ and possible debouncing timer.
+                 */
+                disable_irq(gpio_to_irq(bdata->button->gpio));
+                if (bdata->button->debounce_interval)
+                        del_timer_sync(&bdata->timer);
+
+                bdata->disabled = true;
+        }
+}
+
+/**
+ * gpio_keys_enable_button() - enables given GPIO button
+ * @bdata: button data for button to be disabled
+ *
+ * Enables given button pointed by @bdata.
+ *
+ * Make sure that @bdata->disable_lock is locked when entering
+ * this function to avoid races with concurrent threads trying
+ * to enable the same button at the same time.
+ */
+static void gpio_keys_enable_button(struct gpio_button_data *bdata)
+{
+        if (bdata->disabled) {
+                enable_irq(gpio_to_irq(bdata->button->gpio));
+                bdata->disabled = false;
+        }
+}
+
+/**
+ * gpio_keys_attr_show_helper() - fill in stringified bitmap of buttons
+ * @ddata: pointer to drvdata
+ * @buf: buffer where stringified bitmap is written
+ * @type: button type (%EV_KEY, %EV_SW)
+ * @only_disabled: does caller want only those buttons that are
+ *                 currently disabled or all buttons that can be
+ *                 disabled
+ *
+ * This function writes buttons that can be disabled to @buf. If
+ * @only_disabled is true, then @buf contains only those buttons
+ * that are currently disabled. Returns 0 on success or negative
+ * errno on failure.
+ */
+static ssize_t gpio_keys_attr_show_helper(struct gpio_keys_drvdata *ddata,
+                                          char *buf, unsigned int type,
+                                          bool only_disabled)
+{
+        int n_events = get_n_events_by_type(type);
+        unsigned long *bits;
+        ssize_t ret;
+        int i;
+
+        bits = kcalloc(BITS_TO_LONGS(n_events), sizeof(*bits), GFP_KERNEL);
+        if (!bits)
+                return -ENOMEM;
+
+        for (i = 0; i < ddata->n_buttons; i++) {
+                struct gpio_button_data *bdata = &ddata->data[i];
+
+                if (bdata->button->type != type)
+                        continue;
+
+                if (only_disabled && !bdata->disabled)
+                        continue;
+
+                __set_bit(bdata->button->code, bits);
+        }
+
+        ret = bitmap_scnlistprintf(buf, PAGE_SIZE - 2, bits, n_events);
+        buf[ret++] = '\n';
+        buf[ret] = '\0';
+
+        kfree(bits);
+
+        return ret;
+}
+
+/**
+ * gpio_keys_attr_store_helper() - enable/disable buttons based on given bitmap
+ * @ddata: pointer to drvdata
+ * @buf: buffer from userspace that contains stringified bitmap
+ * @type: button type (%EV_KEY, %EV_SW)
+ *
+ * This function parses stringified bitmap from @buf and disables/enables
+ * GPIO buttons accordinly. Returns 0 on success and negative error
+ * on failure.
+ */
+static ssize_t gpio_keys_attr_store_helper(struct gpio_keys_drvdata *ddata,
+                                           const char *buf, unsigned int type)
+{
+        int n_events = get_n_events_by_type(type);
+        unsigned long *bits;
+        ssize_t error;
+        int i;
+
+        bits = kcalloc(BITS_TO_LONGS(n_events), sizeof(*bits), GFP_KERNEL);
+        if (!bits)
+                return -ENOMEM;
+
+        error = bitmap_parselist(buf, bits, n_events);
+        if (error)
+                goto out;
+
+        /* First validate */
+        for (i = 0; i < ddata->n_buttons; i++) {
+                struct gpio_button_data *bdata = &ddata->data[i];
+
+                if (bdata->button->type != type)
+                        continue;
+
+                if (test_bit(bdata->button->code, bits) &&
+                    !bdata->button->can_disable) {
+                        error = -EINVAL;
+                        goto out;
+                }
+        }
+
+        mutex_lock(&ddata->disable_lock);
+
+        for (i = 0; i < ddata->n_buttons; i++) {
+                struct gpio_button_data *bdata = &ddata->data[i];
+
+                if (bdata->button->type != type)
+                        continue;
+
+                if (test_bit(bdata->button->code, bits))
+                        gpio_keys_disable_button(bdata);
+                else
+                        gpio_keys_enable_button(bdata);
+        }
+
+        mutex_unlock(&ddata->disable_lock);
+
+out:
+        kfree(bits);
+        return error;
+}
+
+#define ATTR_SHOW_FN(name, type, only_disabled)                         \
+static ssize_t gpio_keys_show_##name(struct device *dev,                \
+                                     struct device_attribute *attr,     \
+                                     char *buf)                         \
+{                                                                       \
+        struct platform_device *pdev = to_platform_device(dev);         \
+        struct gpio_keys_drvdata *ddata = platform_get_drvdata(pdev);   \
+                                                                        \
+        return gpio_keys_attr_show_helper(ddata, buf,                   \
+                                          type, only_disabled);         \
+}
+
+ATTR_SHOW_FN(keys, EV_KEY, false);
+ATTR_SHOW_FN(switches, EV_SW, false);
+ATTR_SHOW_FN(disabled_keys, EV_KEY, true);
+ATTR_SHOW_FN(disabled_switches, EV_SW, true);
+
+/*
+ * ATTRIBUTES:
+ *
+ * /sys/devices/platform/gpio-keys/keys [ro]
+ * /sys/devices/platform/gpio-keys/switches [ro]
+ */
+static DEVICE_ATTR(keys, S_IRUGO, gpio_keys_show_keys, NULL);
+static DEVICE_ATTR(switches, S_IRUGO, gpio_keys_show_switches, NULL);
+
+#define ATTR_STORE_FN(name, type)                                       \
+static ssize_t gpio_keys_store_##name(struct device *dev,               \
+                                      struct device_attribute *attr,    \
+                                      const char *buf,                  \
+                                      size_t count)                     \
+{                                                                       \
+        struct platform_device *pdev = to_platform_device(dev);         \
+        struct gpio_keys_drvdata *ddata = platform_get_drvdata(pdev);   \
+        ssize_t error;                                                  \
+                                                                        \
+        error = gpio_keys_attr_store_helper(ddata, buf, type);          \
+        if (error)                                                      \
+                return error;                                           \
+                                                                        \
+        return count;                                                   \
+}
+
+ATTR_STORE_FN(disabled_keys, EV_KEY);
+ATTR_STORE_FN(disabled_switches, EV_SW);
+
+/*
+ * ATTRIBUTES:
+ *
+ * /sys/devices/platform/gpio-keys/disabled_keys [rw]
+ * /sys/devices/platform/gpio-keys/disables_switches [rw]
+ */
+static DEVICE_ATTR(disabled_keys, S_IWUSR | S_IRUGO,
+                   gpio_keys_show_disabled_keys,
+                   gpio_keys_store_disabled_keys);
+static DEVICE_ATTR(disabled_switches, S_IWUSR | S_IRUGO,
+                   gpio_keys_show_disabled_switches,
+                   gpio_keys_store_disabled_switches);
+
+static struct attribute *gpio_keys_attrs[] = {
+        &dev_attr_keys.attr,
+        &dev_attr_switches.attr,
+        &dev_attr_disabled_keys.attr,
+        &dev_attr_disabled_switches.attr,
+        NULL,
+};
+
+static struct attribute_group gpio_keys_attr_group = {
+        .attrs = gpio_keys_attrs,
+};
+
+static void gpio_keys_report_event(struct gpio_button_data *bdata)
 {
-        struct gpio_button_data *bdata =
-                container_of(work, struct gpio_button_data, work);
         struct gpio_keys_button *button = bdata->button;
         struct input_dev *input = bdata->input;
         unsigned int type = button->type ?: EV_KEY;
@@ -51,6 +325,14 @@ static void gpio_keys_report_event(struct work_struct *work)
         input_sync(input);
 }
 
+static void gpio_keys_work_func(struct work_struct *work)
+{
+        struct gpio_button_data *bdata =
+                container_of(work, struct gpio_button_data, work);
+
+        gpio_keys_report_event(bdata);
+}
+
 static void gpio_keys_timer(unsigned long _data)
 {
         struct gpio_button_data *data = (struct gpio_button_data *)_data;
@@ -74,10 +356,69 @@ static irqreturn_t gpio_keys_isr(int irq, void *dev_id)
         return IRQ_HANDLED;
 }
 
+static int __devinit gpio_keys_setup_key(struct platform_device *pdev,
+                                         struct gpio_button_data *bdata,
+                                         struct gpio_keys_button *button)
+{
+        char *desc = button->desc ? button->desc : "gpio_keys";
+        struct device *dev = &pdev->dev;
+        unsigned long irqflags;
+        int irq, error;
+
+        setup_timer(&bdata->timer, gpio_keys_timer, (unsigned long)bdata);
+        INIT_WORK(&bdata->work, gpio_keys_work_func);
+
+        error = gpio_request(button->gpio, desc);
+        if (error < 0) {
+                dev_err(dev, "failed to request GPIO %d, error %d\n",
+                        button->gpio, error);
+                goto fail2;
+        }
+
+        error = gpio_direction_input(button->gpio);
+        if (error < 0) {
+                dev_err(dev, "failed to configure"
+                        " direction for GPIO %d, error %d\n",
+                        button->gpio, error);
+                goto fail3;
+        }
+
+        irq = gpio_to_irq(button->gpio);
+        if (irq < 0) {
+                error = irq;
+                dev_err(dev, "Unable to get irq number for GPIO %d, error %d\n",
+                        button->gpio, error);
+                goto fail3;
+        }
+
+        irqflags = IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING;
+        /*
+         * If platform has specified that the button can be disabled,
+         * we don't want it to share the interrupt line.
+         */
+        if (!button->can_disable)
+                irqflags |= IRQF_SHARED;
+
+        error = request_irq(irq, gpio_keys_isr, irqflags, desc, bdata);
+        if (error) {
+                dev_err(dev, "Unable to claim irq %d; error %d\n",
+                        irq, error);
+                goto fail3;
+        }
+
+        return 0;
+
+fail3:
+        gpio_free(button->gpio);
+fail2:
+        return error;
+}
+
 static int __devinit gpio_keys_probe(struct platform_device *pdev)
 {
         struct gpio_keys_platform_data *pdata = pdev->dev.platform_data;
         struct gpio_keys_drvdata *ddata;
+        struct device *dev = &pdev->dev;
         struct input_dev *input;
         int i, error;
         int wakeup = 0;
@@ -87,10 +428,15 @@ static int __devinit gpio_keys_probe(struct platform_device *pdev)
                         GFP_KERNEL);
         input = input_allocate_device();
         if (!ddata || !input) {
+                dev_err(dev, "failed to allocate state\n");
                 error = -ENOMEM;
                 goto fail1;
         }
 
+        ddata->input = input;
+        ddata->n_buttons = pdata->nbuttons;
+        mutex_init(&ddata->disable_lock);
+
         platform_set_drvdata(pdev, ddata);
 
         input->name = pdev->name;
@@ -106,57 +452,17 @@ static int __devinit gpio_keys_probe(struct platform_device *pdev)
         if (pdata->rep)
                 __set_bit(EV_REP, input->evbit);
 
-        ddata->input = input;
-
         for (i = 0; i < pdata->nbuttons; i++) {
                 struct gpio_keys_button *button = &pdata->buttons[i];
                 struct gpio_button_data *bdata = &ddata->data[i];
-                int irq;
                 unsigned int type = button->type ?: EV_KEY;
 
                 bdata->input = input;
                 bdata->button = button;
-                setup_timer(&bdata->timer,
-                            gpio_keys_timer, (unsigned long)bdata);
-                INIT_WORK(&bdata->work, gpio_keys_report_event);
-
-                error = gpio_request(button->gpio, button->desc ?: "gpio_keys");
-                if (error < 0) {
-                        pr_err("gpio-keys: failed to request GPIO %d,"
-                                " error %d\n", button->gpio, error);
-                        goto fail2;
-                }
 
-                error = gpio_direction_input(button->gpio);
-                if (error < 0) {
-                        pr_err("gpio-keys: failed to configure input"
-                                " direction for GPIO %d, error %d\n",
-                                button->gpio, error);
-                        gpio_free(button->gpio);
+                error = gpio_keys_setup_key(pdev, bdata, button);
+                if (error)
                         goto fail2;
-                }
-
-                irq = gpio_to_irq(button->gpio);
-                if (irq < 0) {
-                        error = irq;
-                        pr_err("gpio-keys: Unable to get irq number"
-                                " for GPIO %d, error %d\n",
-                                button->gpio, error);
-                        gpio_free(button->gpio);
-                        goto fail2;
-                }
-
-                error = request_irq(irq, gpio_keys_isr,
-                                    IRQF_SHARED |
-                                    IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING,
-                                    button->desc ? button->desc : "gpio_keys",
-                                    bdata);
-                if (error) {
-                        pr_err("gpio-keys: Unable to claim irq %d; error %d\n",
-                                irq, error);
-                        gpio_free(button->gpio);
-                        goto fail2;
-                }
 
                 if (button->wakeup)
                         wakeup = 1;
@@ -164,17 +470,31 @@ static int __devinit gpio_keys_probe(struct platform_device *pdev)
                 input_set_capability(input, type, button->code);
         }
 
-        error = input_register_device(input);
+        error = sysfs_create_group(&pdev->dev.kobj, &gpio_keys_attr_group);
         if (error) {
-                pr_err("gpio-keys: Unable to register input device, "
-                        "error: %d\n", error);
+                dev_err(dev, "Unable to export keys/switches, error: %d\n",
+                        error);
                 goto fail2;
         }
 
+        error = input_register_device(input);
+        if (error) {
+                dev_err(dev, "Unable to register input device, error: %d\n",
+                        error);
+                goto fail3;
+        }
+
+        /* get current state of buttons */
+        for (i = 0; i < pdata->nbuttons; i++)
+                gpio_keys_report_event(&ddata->data[i]);
+        input_sync(input);
+
         device_init_wakeup(&pdev->dev, wakeup);
 
         return 0;
 
+ fail3:
+        sysfs_remove_group(&pdev->dev.kobj, &gpio_keys_attr_group);
  fail2:
         while (--i >= 0) {
                 free_irq(gpio_to_irq(pdata->buttons[i].gpio), &ddata->data[i]);
@@ -199,6 +519,8 @@ static int __devexit gpio_keys_remove(struct platform_device *pdev)
         struct input_dev *input = ddata->input;
         int i;
 
+        sysfs_remove_group(&pdev->dev.kobj, &gpio_keys_attr_group);
+
         device_init_wakeup(&pdev->dev, 0);
 
         for (i = 0; i < pdata->nbuttons; i++) {
@@ -239,18 +561,21 @@ static int gpio_keys_suspend(struct device *dev)
 static int gpio_keys_resume(struct device *dev)
 {
         struct platform_device *pdev = to_platform_device(dev);
+        struct gpio_keys_drvdata *ddata = platform_get_drvdata(pdev);
         struct gpio_keys_platform_data *pdata = pdev->dev.platform_data;
         int i;
 
-        if (device_may_wakeup(&pdev->dev)) {
-                for (i = 0; i < pdata->nbuttons; i++) {
-                        struct gpio_keys_button *button = &pdata->buttons[i];
-                        if (button->wakeup) {
-                                int irq = gpio_to_irq(button->gpio);
-                                disable_irq_wake(irq);
-                        }
+        for (i = 0; i < pdata->nbuttons; i++) {
+
+                struct gpio_keys_button *button = &pdata->buttons[i];
+                if (button->wakeup && device_may_wakeup(&pdev->dev)) {
+                        int irq = gpio_to_irq(button->gpio);
+                        disable_irq_wake(irq);
                 }
+
+                gpio_keys_report_event(&ddata->data[i]);
         }
+        input_sync(ddata->input);
 
         return 0;
 }
diff --git a/drivers/input/keyboard/imx_keypad.c b/drivers/input/keyboard/imx_keypad.c
new file mode 100644
index 000000000000..d92c15c39e68
--- /dev/null
+++ b/drivers/input/keyboard/imx_keypad.c
@@ -0,0 +1,595 @@
+/*
+ * Driver for the IMX keypad port.
+ * Copyright (C) 2009 Alberto Panizzo <maramaopercheseimorto@gmail.com>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ *
+ * <<Power management needs to be implemented>>.
+ */
+
+#include <linux/clk.h>
+#include <linux/delay.h>
+#include <linux/device.h>
+#include <linux/err.h>
+#include <linux/init.h>
+#include <linux/input/matrix_keypad.h>
+#include <linux/interrupt.h>
+#include <linux/io.h>
+#include <linux/jiffies.h>
+#include <linux/kernel.h>
+#include <linux/module.h>
+#include <linux/platform_device.h>
+#include <linux/slab.h>
+#include <linux/timer.h>
+
+/*
+ * Keypad Controller registers (halfword)
+ */
+#define KPCR            0x00 /* Keypad Control Register */
+
+#define KPSR            0x02 /* Keypad Status Register */
+#define KBD_STAT_KPKD   (0x1 << 0) /* Key Press Interrupt Status bit (w1c) */
+#define KBD_STAT_KPKR   (0x1 << 1) /* Key Release Interrupt Status bit (w1c) */
+#define KBD_STAT_KDSC   (0x1 << 2) /* Key Depress Synch Chain Status bit (w1c)*/
+#define KBD_STAT_KRSS   (0x1 << 3) /* Key Release Synch Status bit (w1c)*/
+#define KBD_STAT_KDIE   (0x1 << 8) /* Key Depress Interrupt Enable Status bit */
+#define KBD_STAT_KRIE   (0x1 << 9) /* Key Release Interrupt Enable */
+#define KBD_STAT_KPPEN  (0x1 << 10) /* Keypad Clock Enable */
+
+#define KDDR            0x04 /* Keypad Data Direction Register */
+#define KPDR            0x06 /* Keypad Data Register */
+
+#define MAX_MATRIX_KEY_ROWS     8
+#define MAX_MATRIX_KEY_COLS     8
+#define MATRIX_ROW_SHIFT        3
+
+#define MAX_MATRIX_KEY_NUM      (MAX_MATRIX_KEY_ROWS * MAX_MATRIX_KEY_COLS)
+
+struct imx_keypad {
+
+        struct clk *clk;
+        struct input_dev *input_dev;
+        void __iomem *mmio_base;
+
+        int                     irq;
+        struct timer_list       check_matrix_timer;
+
+        /*
+         * The matrix is stable only if no changes are detected after
+         * IMX_KEYPAD_SCANS_FOR_STABILITY scans
+         */
+#define IMX_KEYPAD_SCANS_FOR_STABILITY 3
+        int                     stable_count;
+
+        bool                    enabled;
+
+        /* Masks for enabled rows/cols */
+        unsigned short          rows_en_mask;
+        unsigned short          cols_en_mask;
+
+        unsigned short          keycodes[MAX_MATRIX_KEY_NUM];
+
+        /*
+         * Matrix states:
+         * -stable: achieved after a complete debounce process.
+         * -unstable: used in the debouncing process.
+         */
+        unsigned short          matrix_stable_state[MAX_MATRIX_KEY_COLS];
+        unsigned short          matrix_unstable_state[MAX_MATRIX_KEY_COLS];
+};
+
+/* Scan the matrix and return the new state in *matrix_volatile_state. */
+static void imx_keypad_scan_matrix(struct imx_keypad *keypad,
+                                  unsigned short *matrix_volatile_state)
+{
+        int col;
+        unsigned short reg_val;
+
+        for (col = 0; col < MAX_MATRIX_KEY_COLS; col++) {
+                if ((keypad->cols_en_mask & (1 << col)) == 0)
+                        continue;
+                /*
+                 * Discharge keypad capacitance:
+                 * 2. write 1s on column data.
+                 * 3. configure columns as totem-pole to discharge capacitance.
+                 * 4. configure columns as open-drain.
+                 */
+                reg_val = readw(keypad->mmio_base + KPDR);
+                reg_val |= 0xff00;
+                writew(reg_val, keypad->mmio_base + KPDR);
+
+                reg_val = readw(keypad->mmio_base + KPCR);
+                reg_val &= ~((keypad->cols_en_mask & 0xff) << 8);
+                writew(reg_val, keypad->mmio_base + KPCR);
+
+                udelay(2);
+
+                reg_val = readw(keypad->mmio_base + KPCR);
+                reg_val |= (keypad->cols_en_mask & 0xff) << 8;
+                writew(reg_val, keypad->mmio_base + KPCR);
+
+                /*
+                 * 5. Write a single column to 0, others to 1.
+                 * 6. Sample row inputs and save data.
+                 * 7. Repeat steps 2 - 6 for remaining columns.
+                 */
+                reg_val = readw(keypad->mmio_base + KPDR);
+                reg_val &= ~(1 << (8 + col));
+                writew(reg_val, keypad->mmio_base + KPDR);
+
+                /*
+                 * Delay added to avoid propagating the 0 from column to row
+                 * when scanning.
+                 */
+                udelay(5);
+
+                /*
+                 * 1s in matrix_volatile_state[col] means key pressures
+                 * throw data from non enabled rows.
+                 */
+                reg_val = readw(keypad->mmio_base + KPDR);
+                matrix_volatile_state[col] = (~reg_val) & keypad->rows_en_mask;
+        }
+
+        /*
+         * Return in standby mode:
+         * 9. write 0s to columns
+         */
+        reg_val = readw(keypad->mmio_base + KPDR);
+        reg_val &= 0x00ff;
+        writew(reg_val, keypad->mmio_base + KPDR);
+}
+
+/*
+ * Compare the new matrix state (volatile) with the stable one stored in
+ * keypad->matrix_stable_state and fire events if changes are detected.
+ */
+static void imx_keypad_fire_events(struct imx_keypad *keypad,
+                                   unsigned short *matrix_volatile_state)
+{
+        struct input_dev *input_dev = keypad->input_dev;
+        int row, col;
+
+        for (col = 0; col < MAX_MATRIX_KEY_COLS; col++) {
+                unsigned short bits_changed;
+                int code;
+
+                if ((keypad->cols_en_mask & (1 << col)) == 0)
+                        continue; /* Column is not enabled */
+
+                bits_changed = keypad->matrix_stable_state[col] ^
+                                                matrix_volatile_state[col];
+
+                if (bits_changed == 0)
+                        continue; /* Column does not contain changes */
+
+                for (row = 0; row < MAX_MATRIX_KEY_ROWS; row++) {
+                        if ((keypad->rows_en_mask & (1 << row)) == 0)
+                                continue; /* Row is not enabled */
+                        if ((bits_changed & (1 << row)) == 0)
+                                continue; /* Row does not contain changes */
+
+                        code = MATRIX_SCAN_CODE(row, col, MATRIX_ROW_SHIFT);
+                        input_event(input_dev, EV_MSC, MSC_SCAN, code);
+                        input_report_key(input_dev, keypad->keycodes[code],
+                                matrix_volatile_state[col] & (1 << row));
+                        dev_dbg(&input_dev->dev, "Event code: %d, val: %d",
+                                keypad->keycodes[code],
+                                matrix_volatile_state[col] & (1 << row));
+                }
+        }
+        input_sync(input_dev);
+}
+
+/*
+ * imx_keypad_check_for_events is the timer handler.
+ */
+static void imx_keypad_check_for_events(unsigned long data)
+{
+        struct imx_keypad *keypad = (struct imx_keypad *) data;
+        unsigned short matrix_volatile_state[MAX_MATRIX_KEY_COLS];
+        unsigned short reg_val;
+        bool state_changed, is_zero_matrix;
+        int i;
+
+        memset(matrix_volatile_state, 0, sizeof(matrix_volatile_state));
+
+        imx_keypad_scan_matrix(keypad, matrix_volatile_state);
+
+        state_changed = false;
+        for (i = 0; i < MAX_MATRIX_KEY_COLS; i++) {
+                if ((keypad->cols_en_mask & (1 << i)) == 0)
+                        continue;
+
+                if (keypad->matrix_unstable_state[i] ^ matrix_volatile_state[i]) {
+                        state_changed = true;
+                        break;
+                }
+        }
+
+        /*
+         * If the matrix state is changed from the previous scan
+         *   (Re)Begin the debouncing process, saving the new state in
+         *    keypad->matrix_unstable_state.
+         * else
+         *   Increase the count of number of scans with a stable state.
+         */
+        if (state_changed) {
+                memcpy(keypad->matrix_unstable_state, matrix_volatile_state,
+                        sizeof(matrix_volatile_state));
+                keypad->stable_count = 0;
+        } else
+                keypad->stable_count++;
+
+        /*
+         * If the matrix is not as stable as we want reschedule scan
+         * in the near future.
+         */
+        if (keypad->stable_count < IMX_KEYPAD_SCANS_FOR_STABILITY) {
+                mod_timer(&keypad->check_matrix_timer,
+                          jiffies + msecs_to_jiffies(10));
+                return;
+        }
+
+        /*
+         * If the matrix state is stable, fire the events and save the new
+         * stable state. Note, if the matrix is kept stable for longer
+         * (keypad->stable_count > IMX_KEYPAD_SCANS_FOR_STABILITY) all
+         * events have already been generated.
+         */
+        if (keypad->stable_count == IMX_KEYPAD_SCANS_FOR_STABILITY) {
+                imx_keypad_fire_events(keypad, matrix_volatile_state);
+
+                memcpy(keypad->matrix_stable_state, matrix_volatile_state,
+                        sizeof(matrix_volatile_state));
+        }
+
+        is_zero_matrix = true;
+        for (i = 0; i < MAX_MATRIX_KEY_COLS; i++) {
+                if (matrix_volatile_state[i] != 0) {
+                        is_zero_matrix = false;
+                        break;
+                }
+        }
+
+
+        if (is_zero_matrix) {
+                /*
+                 * All keys have been released. Enable only the KDI
+                 * interrupt for future key presses (clear the KDI
+                 * status bit and its sync chain before that).
+                 */
+                reg_val = readw(keypad->mmio_base + KPSR);
+                reg_val |= KBD_STAT_KPKD | KBD_STAT_KDSC;
+                writew(reg_val, keypad->mmio_base + KPSR);
+
+                reg_val = readw(keypad->mmio_base + KPSR);
+                reg_val |= KBD_STAT_KDIE;
+                reg_val &= ~KBD_STAT_KRIE;
+                writew(reg_val, keypad->mmio_base + KPSR);
+        } else {
+                /*
+                 * Some keys are still pressed. Schedule a rescan in
+                 * attempt to detect multiple key presses and enable
+                 * the KRI interrupt to react quickly to key release
+                 * event.
+                 */
+                mod_timer(&keypad->check_matrix_timer,
+                          jiffies + msecs_to_jiffies(60));
+
+                reg_val = readw(keypad->mmio_base + KPSR);
+                reg_val |= KBD_STAT_KPKR | KBD_STAT_KRSS;
+                writew(reg_val, keypad->mmio_base + KPSR);
+
+                reg_val = readw(keypad->mmio_base + KPSR);
+                reg_val |= KBD_STAT_KRIE;
+                reg_val &= ~KBD_STAT_KDIE;
+                writew(reg_val, keypad->mmio_base + KPSR);
+        }
+}
+
+static irqreturn_t imx_keypad_irq_handler(int irq, void *dev_id)
+{
+        struct imx_keypad *keypad = dev_id;
+        unsigned short reg_val;
+
+        reg_val = readw(keypad->mmio_base + KPSR);
+
+        /* Disable both interrupt types */
+        reg_val &= ~(KBD_STAT_KRIE | KBD_STAT_KDIE);
+        /* Clear interrupts status bits */
+        reg_val |= KBD_STAT_KPKR | KBD_STAT_KPKD;
+        writew(reg_val, keypad->mmio_base + KPSR);
+
+        if (keypad->enabled) {
+                /* The matrix is supposed to be changed */
+                keypad->stable_count = 0;
+
+                /* Schedule the scanning procedure near in the future */
+                mod_timer(&keypad->check_matrix_timer,
+                          jiffies + msecs_to_jiffies(2));
+        }
+
+        return IRQ_HANDLED;
+}
+
+static void imx_keypad_config(struct imx_keypad *keypad)
+{
+        unsigned short reg_val;
+
+        /*
+         * Include enabled rows in interrupt generation (KPCR[7:0])
+         * Configure keypad columns as open-drain (KPCR[15:8])
+         */
+        reg_val = readw(keypad->mmio_base + KPCR);
+        reg_val |= keypad->rows_en_mask & 0xff;         /* rows */
+        reg_val |= (keypad->cols_en_mask & 0xff) << 8;  /* cols */
+        writew(reg_val, keypad->mmio_base + KPCR);
+
+        /* Write 0's to KPDR[15:8] (Colums) */
+        reg_val = readw(keypad->mmio_base + KPDR);
+        reg_val &= 0x00ff;
+        writew(reg_val, keypad->mmio_base + KPDR);
+
+        /* Configure columns as output, rows as input (KDDR[15:0]) */
+        writew(0xff00, keypad->mmio_base + KDDR);
+
+        /*
+         * Clear Key Depress and Key Release status bit.
+         * Clear both synchronizer chain.
+         */
+        reg_val = readw(keypad->mmio_base + KPSR);
+        reg_val |= KBD_STAT_KPKR | KBD_STAT_KPKD |
+                   KBD_STAT_KDSC | KBD_STAT_KRSS;
+        writew(reg_val, keypad->mmio_base + KPSR);
+
+        /* Enable KDI and disable KRI (avoid false release events). */
+        reg_val |= KBD_STAT_KDIE;
+        reg_val &= ~KBD_STAT_KRIE;
+        writew(reg_val, keypad->mmio_base + KPSR);
+}
+
+static void imx_keypad_inhibit(struct imx_keypad *keypad)
+{
+        unsigned short reg_val;
+
+        /* Inhibit KDI and KRI interrupts. */
+        reg_val = readw(keypad->mmio_base + KPSR);
+        reg_val &= ~(KBD_STAT_KRIE | KBD_STAT_KDIE);
+        writew(reg_val, keypad->mmio_base + KPSR);
+
+        /* Colums as open drain and disable all rows */
+        writew(0xff00, keypad->mmio_base + KPCR);
+}
+
+static void imx_keypad_close(struct input_dev *dev)
+{
+        struct imx_keypad *keypad = input_get_drvdata(dev);
+
+        dev_dbg(&dev->dev, ">%s\n", __func__);
+
+        /* Mark keypad as being inactive */
+        keypad->enabled = false;
+        synchronize_irq(keypad->irq);
+        del_timer_sync(&keypad->check_matrix_timer);
+
+        imx_keypad_inhibit(keypad);
+
+        /* Disable clock unit */
+        clk_disable(keypad->clk);
+}
+
+static int imx_keypad_open(struct input_dev *dev)
+{
+        struct imx_keypad *keypad = input_get_drvdata(dev);
+
+        dev_dbg(&dev->dev, ">%s\n", __func__);
+
+        /* We became active from now */
+        keypad->enabled = true;
+
+        /* Enable the kpp clock */
+        clk_enable(keypad->clk);
+        imx_keypad_config(keypad);
+
+        /* Sanity control, not all the rows must be actived now. */
+        if ((readw(keypad->mmio_base + KPDR) & keypad->rows_en_mask) == 0) {
+                dev_err(&dev->dev,
+                        "too many keys pressed, control pins initialisation\n");
+                goto open_err;
+        }
+
+        return 0;
+
+open_err:
+        imx_keypad_close(dev);
+        return -EIO;
+}
+
+static int __devinit imx_keypad_probe(struct platform_device *pdev)
+{
+        const struct matrix_keymap_data *keymap_data = pdev->dev.platform_data;
+        struct imx_keypad *keypad;
+        struct input_dev *input_dev;
+        struct resource *res;
+        int irq, error, i;
+
+        if (keymap_data == NULL) {
+                dev_err(&pdev->dev, "no keymap defined\n");
+                return -EINVAL;
+        }
+
+        irq = platform_get_irq(pdev, 0);
+        if (irq < 0) {
+                dev_err(&pdev->dev, "no irq defined in platform data\n");
+                return -EINVAL;
+        }
+
+        res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
+        if (res == NULL) {
+                dev_err(&pdev->dev, "no I/O memory defined in platform data\n");
+                return -EINVAL;
+        }
+
+        res = request_mem_region(res->start, resource_size(res), pdev->name);
+        if (res == NULL) {
+                dev_err(&pdev->dev, "failed to request I/O memory\n");
+                return -EBUSY;
+        }
+
+        input_dev = input_allocate_device();
+        if (!input_dev) {
+                dev_err(&pdev->dev, "failed to allocate the input device\n");
+                error = -ENOMEM;
+                goto failed_rel_mem;
+        }
+
+        keypad = kzalloc(sizeof(struct imx_keypad), GFP_KERNEL);
+        if (!keypad) {
+                dev_err(&pdev->dev, "not enough memory for driver data\n");
+                error = -ENOMEM;
+                goto failed_free_input;
+        }
+
+        keypad->input_dev = input_dev;
+        keypad->irq = irq;
+        keypad->stable_count = 0;
+
+        setup_timer(&keypad->check_matrix_timer,
+                    imx_keypad_check_for_events, (unsigned long) keypad);
+
+        keypad->mmio_base = ioremap(res->start, resource_size(res));
+        if (keypad->mmio_base == NULL) {
+                dev_err(&pdev->dev, "failed to remap I/O memory\n");
+                error = -ENOMEM;
+                goto failed_free_priv;
+        }
+
+        keypad->clk = clk_get(&pdev->dev, "kpp");
+        if (IS_ERR(keypad->clk)) {
+                dev_err(&pdev->dev, "failed to get keypad clock\n");
+                error = PTR_ERR(keypad->clk);
+                goto failed_unmap;
+        }
+
+        /* Search for rows and cols enabled */
+        for (i = 0; i < keymap_data->keymap_size; i++) {
+                keypad->rows_en_mask |= 1 << KEY_ROW(keymap_data->keymap[i]);
+                keypad->cols_en_mask |= 1 << KEY_COL(keymap_data->keymap[i]);
+        }
+
+        if (keypad->rows_en_mask > ((1 << MAX_MATRIX_KEY_ROWS) - 1) ||
+           keypad->cols_en_mask > ((1 << MAX_MATRIX_KEY_COLS) - 1)) {
+                dev_err(&pdev->dev,
+                        "invalid key data (too many rows or colums)\n");
+                error = -EINVAL;
+                goto failed_clock_put;
+        }
+        dev_dbg(&pdev->dev, "enabled rows mask: %x\n", keypad->rows_en_mask);
+        dev_dbg(&pdev->dev, "enabled cols mask: %x\n", keypad->cols_en_mask);
+
+        /* Init the Input device */
+        input_dev->name = pdev->name;
+        input_dev->id.bustype = BUS_HOST;
+        input_dev->dev.parent = &pdev->dev;
+        input_dev->open = imx_keypad_open;
+        input_dev->close = imx_keypad_close;
+        input_dev->evbit[0] = BIT_MASK(EV_KEY) | BIT_MASK(EV_REP);
+        input_dev->keycode = keypad->keycodes;
+        input_dev->keycodesize = sizeof(keypad->keycodes[0]);
+        input_dev->keycodemax = ARRAY_SIZE(keypad->keycodes);
+
+        matrix_keypad_build_keymap(keymap_data, MATRIX_ROW_SHIFT,
+                                keypad->keycodes, input_dev->keybit);
+
+        input_set_capability(input_dev, EV_MSC, MSC_SCAN);
+        input_set_drvdata(input_dev, keypad);
+
+        /* Ensure that the keypad will stay dormant until opened */
+        imx_keypad_inhibit(keypad);
+
+        error = request_irq(irq, imx_keypad_irq_handler, IRQF_DISABLED,
+                            pdev->name, keypad);
+        if (error) {
+                dev_err(&pdev->dev, "failed to request IRQ\n");
+                goto failed_clock_put;
+        }
+
+        /* Register the input device */
+        error = input_register_device(input_dev);
+        if (error) {
+                dev_err(&pdev->dev, "failed to register input device\n");
+                goto failed_free_irq;
+        }
+
+        platform_set_drvdata(pdev, keypad);
+        device_init_wakeup(&pdev->dev, 1);
+
+        return 0;
+
+failed_free_irq:
+        free_irq(irq, pdev);
+failed_clock_put:
+        clk_put(keypad->clk);
+failed_unmap:
+        iounmap(keypad->mmio_base);
+failed_free_priv:
+        kfree(keypad);
+failed_free_input:
+        input_free_device(input_dev);
+failed_rel_mem:
+        release_mem_region(res->start, resource_size(res));
+        return error;
+}
+
+static int __devexit imx_keypad_remove(struct platform_device *pdev)
+{
+        struct imx_keypad *keypad = platform_get_drvdata(pdev);
+        struct resource *res;
+
+        dev_dbg(&pdev->dev, ">%s\n", __func__);
+
+        platform_set_drvdata(pdev, NULL);
+
+        input_unregister_device(keypad->input_dev);
+
+        free_irq(keypad->irq, keypad);
+        clk_put(keypad->clk);
+
+        iounmap(keypad->mmio_base);
+        res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
+        release_mem_region(res->start, resource_size(res));
+
+        kfree(keypad);
+
+        return 0;
+}
+
+static struct platform_driver imx_keypad_driver = {
+        .driver         = {
+                .name   = "imx-keypad",
+                .owner  = THIS_MODULE,
+        },
+        .probe          = imx_keypad_probe,
+        .remove         = __devexit_p(imx_keypad_remove),
+};
+
+static int __init imx_keypad_init(void)
+{
+        return platform_driver_register(&imx_keypad_driver);
+}
+
+static void __exit imx_keypad_exit(void)
+{
+        platform_driver_unregister(&imx_keypad_driver);
+}
+
+module_init(imx_keypad_init);
+module_exit(imx_keypad_exit);
+
+MODULE_AUTHOR("Alberto Panizzo <maramaopercheseimorto@gmail.com>");
+MODULE_DESCRIPTION("IMX Keypad Port Driver");
+MODULE_LICENSE("GPL v2");
+MODULE_ALIAS("platform:imx-keypad");
diff --git a/drivers/input/keyboard/jornada680_kbd.c b/drivers/input/keyboard/jornada680_kbd.c
index 781fc6102860..5fc976dbce0b 100644
--- a/drivers/input/keyboard/jornada680_kbd.c
+++ b/drivers/input/keyboard/jornada680_kbd.c
@@ -24,6 +24,7 @@
 #include <linux/kernel.h>
 #include <linux/module.h>
 #include <linux/platform_device.h>
+#include <linux/slab.h>
 
 #include <asm/delay.h>
 #include <asm/io.h>
diff --git a/drivers/input/keyboard/jornada720_kbd.c b/drivers/input/keyboard/jornada720_kbd.c
index 4e016d823069..2cd3e1d56ea4 100644
--- a/drivers/input/keyboard/jornada720_kbd.c
+++ b/drivers/input/keyboard/jornada720_kbd.c
@@ -23,6 +23,7 @@
 #include <linux/kernel.h>
 #include <linux/module.h>
 #include <linux/platform_device.h>
+#include <linux/slab.h>
 
 #include <mach/jornada720.h>
 #include <mach/hardware.h>
diff --git a/drivers/input/keyboard/lkkbd.c b/drivers/input/keyboard/lkkbd.c
index f9847e0fb553..fa9bb6d235e2 100644
--- a/drivers/input/keyboard/lkkbd.c
+++ b/drivers/input/keyboard/lkkbd.c
@@ -72,9 +72,9 @@
 
 #define DRIVER_DESC     "LK keyboard driver"
 
-MODULE_AUTHOR ("Jan-Benedict Glaw <jbglaw@lug-owl.de>");
-MODULE_DESCRIPTION (DRIVER_DESC);
-MODULE_LICENSE ("GPL");
+MODULE_AUTHOR("Jan-Benedict Glaw <jbglaw@lug-owl.de>");
+MODULE_DESCRIPTION(DRIVER_DESC);
+MODULE_LICENSE("GPL");
 
 /*
  * Known parameters:
@@ -85,27 +85,27 @@ MODULE_LICENSE ("GPL");
  * Please notice that there's not yet an API to set these at runtime.
  */
 static int bell_volume = 100; /* % */
-module_param (bell_volume, int, 0);
-MODULE_PARM_DESC (bell_volume, "Bell volume (in %). default is 100%");
+module_param(bell_volume, int, 0);
+MODULE_PARM_DESC(bell_volume, "Bell volume (in %). default is 100%");
 
 static int keyclick_volume = 100; /* % */
-module_param (keyclick_volume, int, 0);
-MODULE_PARM_DESC (keyclick_volume, "Keyclick volume (in %), default is 100%");
+module_param(keyclick_volume, int, 0);
+MODULE_PARM_DESC(keyclick_volume, "Keyclick volume (in %), default is 100%");
 
 static int ctrlclick_volume = 100; /* % */
-module_param (ctrlclick_volume, int, 0);
-MODULE_PARM_DESC (ctrlclick_volume, "Ctrlclick volume (in %), default is 100%");
+module_param(ctrlclick_volume, int, 0);
+MODULE_PARM_DESC(ctrlclick_volume, "Ctrlclick volume (in %), default is 100%");
 
 static int lk201_compose_is_alt;
-module_param (lk201_compose_is_alt, int, 0);
-MODULE_PARM_DESC (lk201_compose_is_alt, "If set non-zero, LK201' Compose key "
-                "will act as an Alt key");
+module_param(lk201_compose_is_alt, int, 0);
+MODULE_PARM_DESC(lk201_compose_is_alt,
+                 "If set non-zero, LK201' Compose key will act as an Alt key");
 
 
 
 #undef LKKBD_DEBUG
 #ifdef LKKBD_DEBUG
-#define DBG(x...) printk (x)
+#define DBG(x...) printk(x)
 #else
 #define DBG(x...) do {} while (0)
 #endif
@@ -122,7 +122,7 @@ MODULE_PARM_DESC (lk201_compose_is_alt, "If set non-zero, LK201' Compose key "
 #define LK_MODE_DOWN            0x80
 #define LK_MODE_AUTODOWN        0x82
 #define LK_MODE_UPDOWN          0x86
-#define LK_CMD_SET_MODE(mode,div)       ((mode) | ((div) << 3))
+#define LK_CMD_SET_MODE(mode, div)      ((mode) | ((div) << 3))
 
 /* Misc commands */
 #define LK_CMD_ENABLE_KEYCLICK  0x1b
@@ -152,11 +152,8 @@ MODULE_PARM_DESC (lk201_compose_is_alt, "If set non-zero, LK201' Compose key "
 
 #define LK_NUM_KEYCODES         256
 #define LK_NUM_IGNORE_BYTES     6
-typedef u_int16_t lk_keycode_t;
 
-
-
-static lk_keycode_t lkkbd_keycode[LK_NUM_KEYCODES] = {
+static unsigned short lkkbd_keycode[LK_NUM_KEYCODES] = {
         [0x56] = KEY_F1,
         [0x57] = KEY_F2,
         [0x58] = KEY_F3,
@@ -268,7 +265,7 @@ static lk_keycode_t lkkbd_keycode[LK_NUM_KEYCODES] = {
 };
 
 #define CHECK_LED(LK, VAR_ON, VAR_OFF, LED, BITS) do {          \
-        if (test_bit (LED, (LK)->dev->led))                     \
+        if (test_bit(LED, (LK)->dev->led))                      \
                 VAR_ON |= BITS;                                 \
         else                                                    \
                 VAR_OFF |= BITS;                                \
@@ -278,7 +275,7 @@ static lk_keycode_t lkkbd_keycode[LK_NUM_KEYCODES] = {
  * Per-keyboard data
  */
 struct lkkbd {
-        lk_keycode_t keycode[LK_NUM_KEYCODES];
+        unsigned short keycode[LK_NUM_KEYCODES];
         int ignore_bytes;
         unsigned char id[LK_NUM_IGNORE_BYTES];
         struct input_dev *dev;
@@ -301,26 +298,25 @@ static struct {
         unsigned char *name;
 } lk_response[] = {
 #define RESPONSE(x) { .value = (x), .name = #x, }
-        RESPONSE (LK_STUCK_KEY),
-        RESPONSE (LK_SELFTEST_FAILED),
-        RESPONSE (LK_ALL_KEYS_UP),
-        RESPONSE (LK_METRONOME),
-        RESPONSE (LK_OUTPUT_ERROR),
-        RESPONSE (LK_INPUT_ERROR),
-        RESPONSE (LK_KBD_LOCKED),
-        RESPONSE (LK_KBD_TEST_MODE_ACK),
-        RESPONSE (LK_PREFIX_KEY_DOWN),
-        RESPONSE (LK_MODE_CHANGE_ACK),
-        RESPONSE (LK_RESPONSE_RESERVED),
+        RESPONSE(LK_STUCK_KEY),
+        RESPONSE(LK_SELFTEST_FAILED),
+        RESPONSE(LK_ALL_KEYS_UP),
+        RESPONSE(LK_METRONOME),
+        RESPONSE(LK_OUTPUT_ERROR),
+        RESPONSE(LK_INPUT_ERROR),
+        RESPONSE(LK_KBD_LOCKED),
+        RESPONSE(LK_KBD_TEST_MODE_ACK),
+        RESPONSE(LK_PREFIX_KEY_DOWN),
+        RESPONSE(LK_MODE_CHANGE_ACK),
+        RESPONSE(LK_RESPONSE_RESERVED),
 #undef RESPONSE
 };
 
-static unsigned char *
-response_name (unsigned char value)
+static unsigned char *response_name(unsigned char value)
 {
         int i;
 
-        for (i = 0; i < ARRAY_SIZE (lk_response); i++)
+        for (i = 0; i < ARRAY_SIZE(lk_response); i++)
                 if (lk_response[i].value == value)
                         return lk_response[i].name;
 
@@ -331,8 +327,7 @@ response_name (unsigned char value)
 /*
  * Calculate volume parameter byte for a given volume.
  */
-static unsigned char
-volume_to_hw (int volume_percent)
+static unsigned char volume_to_hw(int volume_percent)
 {
         unsigned char ret = 0;
 
@@ -363,8 +358,7 @@ volume_to_hw (int volume_percent)
         return ret;
 }
 
-static void
-lkkbd_detection_done (struct lkkbd *lk)
+static void lkkbd_detection_done(struct lkkbd *lk)
 {
         int i;
 
@@ -377,190 +371,202 @@ lkkbd_detection_done (struct lkkbd *lk)
          * Print keyboard name and modify Compose=Alt on user's request.
          */
         switch (lk->id[4]) {
-                case 1:
-                        strlcpy (lk->name, "DEC LK201 keyboard",
-                                 sizeof (lk->name));
-
-                        if (lk201_compose_is_alt)
-                                lk->keycode[0xb1] = KEY_LEFTALT;
-                        break;
-
-                case 2:
-                        strlcpy (lk->name, "DEC LK401 keyboard",
-                                 sizeof (lk->name));
-                        break;
-
-                default:
-                        strlcpy (lk->name, "Unknown DEC keyboard",
-                                 sizeof (lk->name));
-                        printk (KERN_ERR "lkkbd: keyboard on %s is unknown, "
-                                        "please report to Jan-Benedict Glaw "
-                                        "<jbglaw@lug-owl.de>\n", lk->phys);
-                        printk (KERN_ERR "lkkbd: keyboard ID'ed as:");
-                        for (i = 0; i < LK_NUM_IGNORE_BYTES; i++)
-                                printk (" 0x%02x", lk->id[i]);
-                        printk ("\n");
-                        break;
+        case 1:
+                strlcpy(lk->name, "DEC LK201 keyboard", sizeof(lk->name));
+
+                if (lk201_compose_is_alt)
+                        lk->keycode[0xb1] = KEY_LEFTALT;
+                break;
+
+        case 2:
+                strlcpy(lk->name, "DEC LK401 keyboard", sizeof(lk->name));
+                break;
+
+        default:
+                strlcpy(lk->name, "Unknown DEC keyboard", sizeof(lk->name));
+                printk(KERN_ERR
+                        "lkkbd: keyboard on %s is unknown, please report to "
+                        "Jan-Benedict Glaw <jbglaw@lug-owl.de>\n", lk->phys);
+                printk(KERN_ERR "lkkbd: keyboard ID'ed as:");
+                for (i = 0; i < LK_NUM_IGNORE_BYTES; i++)
+                        printk(" 0x%02x", lk->id[i]);
+                printk("\n");
+                break;
         }
-        printk (KERN_INFO "lkkbd: keyboard on %s identified as: %s\n",
-                        lk->phys, lk->name);
+
+        printk(KERN_INFO "lkkbd: keyboard on %s identified as: %s\n",
+                lk->phys, lk->name);
 
         /*
          * Report errors during keyboard boot-up.
          */
         switch (lk->id[2]) {
-                case 0x00:
-                        /* All okay */
-                        break;
-
-                case LK_STUCK_KEY:
-                        printk (KERN_ERR "lkkbd: Stuck key on keyboard at "
-                                        "%s\n", lk->phys);
-                        break;
-
-                case LK_SELFTEST_FAILED:
-                        printk (KERN_ERR "lkkbd: Selftest failed on keyboard "
-                                        "at %s, keyboard may not work "
-                                        "properly\n", lk->phys);
-                        break;
-
-                default:
-                        printk (KERN_ERR "lkkbd: Unknown error %02x on "
-                                        "keyboard at %s\n", lk->id[2],
-                                        lk->phys);
-                        break;
+        case 0x00:
+                /* All okay */
+                break;
+
+        case LK_STUCK_KEY:
+                printk(KERN_ERR "lkkbd: Stuck key on keyboard at %s\n",
+                        lk->phys);
+                break;
+
+        case LK_SELFTEST_FAILED:
+                printk(KERN_ERR
+                        "lkkbd: Selftest failed on keyboard at %s, "
+                        "keyboard may not work properly\n", lk->phys);
+                break;
+
+        default:
+                printk(KERN_ERR
+                        "lkkbd: Unknown error %02x on keyboard at %s\n",
+                        lk->id[2], lk->phys);
+                break;
         }
 
         /*
          * Try to hint user if there's a stuck key.
          */
         if (lk->id[2] == LK_STUCK_KEY && lk->id[3] != 0)
-                printk (KERN_ERR "Scancode of stuck key is 0x%02x, keycode "
-                                "is 0x%04x\n", lk->id[3],
-                                lk->keycode[lk->id[3]]);
-
-        return;
+                printk(KERN_ERR
+                        "Scancode of stuck key is 0x%02x, keycode is 0x%04x\n",
+                        lk->id[3], lk->keycode[lk->id[3]]);
 }
 
 /*
  * lkkbd_interrupt() is called by the low level driver when a character
  * is received.
  */
-static irqreturn_t
-lkkbd_interrupt (struct serio *serio, unsigned char data, unsigned int flags)
+static irqreturn_t lkkbd_interrupt(struct serio *serio,
+                                   unsigned char data, unsigned int flags)
 {
-        struct lkkbd *lk = serio_get_drvdata (serio);
+        struct lkkbd *lk = serio_get_drvdata(serio);
+        struct input_dev *input_dev = lk->dev;
+        unsigned int keycode;
         int i;
 
-        DBG (KERN_INFO "Got byte 0x%02x\n", data);
+        DBG(KERN_INFO "Got byte 0x%02x\n", data);
 
         if (lk->ignore_bytes > 0) {
-                DBG (KERN_INFO "Ignoring a byte on %s\n", lk->name);
+                DBG(KERN_INFO "Ignoring a byte on %s\n", lk->name);
                 lk->id[LK_NUM_IGNORE_BYTES - lk->ignore_bytes--] = data;
 
                 if (lk->ignore_bytes == 0)
-                        lkkbd_detection_done (lk);
+                        lkkbd_detection_done(lk);
 
                 return IRQ_HANDLED;
         }
 
         switch (data) {
-                case LK_ALL_KEYS_UP:
-                        for (i = 0; i < ARRAY_SIZE (lkkbd_keycode); i++)
-                                if (lk->keycode[i] != KEY_RESERVED)
-                                        input_report_key (lk->dev, lk->keycode[i], 0);
-                        input_sync (lk->dev);
-                        break;
-
-                case 0x01:
-                        DBG (KERN_INFO "Got 0x01, scheduling re-initialization\n");
-                        lk->ignore_bytes = LK_NUM_IGNORE_BYTES;
-                        lk->id[LK_NUM_IGNORE_BYTES - lk->ignore_bytes--] = data;
-                        schedule_work (&lk->tq);
-                        break;
-
-                case LK_METRONOME:
-                case LK_OUTPUT_ERROR:
-                case LK_INPUT_ERROR:
-                case LK_KBD_LOCKED:
-                case LK_KBD_TEST_MODE_ACK:
-                case LK_PREFIX_KEY_DOWN:
-                case LK_MODE_CHANGE_ACK:
-                case LK_RESPONSE_RESERVED:
-                        DBG (KERN_INFO "Got %s and don't know how to handle...\n",
-                                        response_name (data));
-                        break;
-
-                default:
-                        if (lk->keycode[data] != KEY_RESERVED) {
-                                if (!test_bit (lk->keycode[data], lk->dev->key))
-                                        input_report_key (lk->dev, lk->keycode[data], 1);
-                                else
-                                        input_report_key (lk->dev, lk->keycode[data], 0);
-                                input_sync (lk->dev);
-                        } else
-                                printk (KERN_WARNING "%s: Unknown key with "
-                                                "scancode 0x%02x on %s.\n",
-                                                __FILE__, data, lk->name);
+        case LK_ALL_KEYS_UP:
+                for (i = 0; i < ARRAY_SIZE(lkkbd_keycode); i++)
+                        input_report_key(input_dev, lk->keycode[i], 0);
+                input_sync(input_dev);
+                break;
+
+        case 0x01:
+                DBG(KERN_INFO "Got 0x01, scheduling re-initialization\n");
+                lk->ignore_bytes = LK_NUM_IGNORE_BYTES;
+                lk->id[LK_NUM_IGNORE_BYTES - lk->ignore_bytes--] = data;
+                schedule_work(&lk->tq);
+                break;
+
+        case LK_METRONOME:
+        case LK_OUTPUT_ERROR:
+        case LK_INPUT_ERROR:
+        case LK_KBD_LOCKED:
+        case LK_KBD_TEST_MODE_ACK:
+        case LK_PREFIX_KEY_DOWN:
+        case LK_MODE_CHANGE_ACK:
+        case LK_RESPONSE_RESERVED:
+                DBG(KERN_INFO "Got %s and don't know how to handle...\n",
+                        response_name(data));
+                break;
+
+        default:
+                keycode = lk->keycode[data];
+                if (keycode != KEY_RESERVED) {
+                        input_report_key(input_dev, keycode,
+                                         !test_bit(keycode, input_dev->key));
+                        input_sync(input_dev);
+                } else {
+                        printk(KERN_WARNING
+                                "%s: Unknown key with scancode 0x%02x on %s.\n",
+                                __FILE__, data, lk->name);
+                }
         }
 
         return IRQ_HANDLED;
 }
 
+static void lkkbd_toggle_leds(struct lkkbd *lk)
+{
+        struct serio *serio = lk->serio;
+        unsigned char leds_on = 0;
+        unsigned char leds_off = 0;
+
+        CHECK_LED(lk, leds_on, leds_off, LED_CAPSL, LK_LED_SHIFTLOCK);
+        CHECK_LED(lk, leds_on, leds_off, LED_COMPOSE, LK_LED_COMPOSE);
+        CHECK_LED(lk, leds_on, leds_off, LED_SCROLLL, LK_LED_SCROLLLOCK);
+        CHECK_LED(lk, leds_on, leds_off, LED_SLEEP, LK_LED_WAIT);
+        if (leds_on != 0) {
+                serio_write(serio, LK_CMD_LED_ON);
+                serio_write(serio, leds_on);
+        }
+        if (leds_off != 0) {
+                serio_write(serio, LK_CMD_LED_OFF);
+                serio_write(serio, leds_off);
+        }
+}
+
+static void lkkbd_toggle_keyclick(struct lkkbd *lk, bool on)
+{
+        struct serio *serio = lk->serio;
+
+        if (on) {
+                DBG("%s: Activating key clicks\n", __func__);
+                serio_write(serio, LK_CMD_ENABLE_KEYCLICK);
+                serio_write(serio, volume_to_hw(lk->keyclick_volume));
+                serio_write(serio, LK_CMD_ENABLE_CTRCLICK);
+                serio_write(serio, volume_to_hw(lk->ctrlclick_volume));
+        } else {
+                DBG("%s: Deactivating key clicks\n", __func__);
+                serio_write(serio, LK_CMD_DISABLE_KEYCLICK);
+                serio_write(serio, LK_CMD_DISABLE_CTRCLICK);
+        }
+
+}
+
 /*
  * lkkbd_event() handles events from the input module.
  */
-static int
-lkkbd_event (struct input_dev *dev, unsigned int type, unsigned int code,
-                int value)
+static int lkkbd_event(struct input_dev *dev,
+                        unsigned int type, unsigned int code, int value)
 {
-        struct lkkbd *lk = input_get_drvdata (dev);
-        unsigned char leds_on = 0;
-        unsigned char leds_off = 0;
+        struct lkkbd *lk = input_get_drvdata(dev);
 
         switch (type) {
-                case EV_LED:
-                        CHECK_LED (lk, leds_on, leds_off, LED_CAPSL, LK_LED_SHIFTLOCK);
-                        CHECK_LED (lk, leds_on, leds_off, LED_COMPOSE, LK_LED_COMPOSE);
-                        CHECK_LED (lk, leds_on, leds_off, LED_SCROLLL, LK_LED_SCROLLLOCK);
-                        CHECK_LED (lk, leds_on, leds_off, LED_SLEEP, LK_LED_WAIT);
-                        if (leds_on != 0) {
-                                serio_write (lk->serio, LK_CMD_LED_ON);
-                                serio_write (lk->serio, leds_on);
-                        }
-                        if (leds_off != 0) {
-                                serio_write (lk->serio, LK_CMD_LED_OFF);
-                                serio_write (lk->serio, leds_off);
-                        }
+        case EV_LED:
+                lkkbd_toggle_leds(lk);
+                return 0;
+
+        case EV_SND:
+                switch (code) {
+                case SND_CLICK:
+                        lkkbd_toggle_keyclick(lk, value);
                         return 0;
 
-                case EV_SND:
-                        switch (code) {
-                                case SND_CLICK:
-                                        if (value == 0) {
-                                                DBG ("%s: Deactivating key clicks\n", __func__);
-                                                serio_write (lk->serio, LK_CMD_DISABLE_KEYCLICK);
-                                                serio_write (lk->serio, LK_CMD_DISABLE_CTRCLICK);
-                                        } else {
-                                                DBG ("%s: Activating key clicks\n", __func__);
-                                                serio_write (lk->serio, LK_CMD_ENABLE_KEYCLICK);
-                                                serio_write (lk->serio, volume_to_hw (lk->keyclick_volume));
-                                                serio_write (lk->serio, LK_CMD_ENABLE_CTRCLICK);
-                                                serio_write (lk->serio, volume_to_hw (lk->ctrlclick_volume));
-                                        }
-                                        return 0;
-
-                                case SND_BELL:
-                                        if (value != 0)
-                                                serio_write (lk->serio, LK_CMD_SOUND_BELL);
-
-                                        return 0;
-                        }
-                        break;
-
-                default:
-                        printk (KERN_ERR "%s (): Got unknown type %d, code %d, value %d\n",
-                                        __func__, type, code, value);
+                case SND_BELL:
+                        if (value != 0)
+                                serio_write(lk->serio, LK_CMD_SOUND_BELL);
+
+                        return 0;
+                }
+
+                break;
+
+        default:
+                printk(KERN_ERR "%s(): Got unknown type %d, code %d, value %d\n",
+                        __func__, type, code, value);
         }
 
         return -1;
@@ -570,79 +576,56 @@ lkkbd_event (struct input_dev *dev, unsigned int type, unsigned int code,
  * lkkbd_reinit() sets leds and beeps to a state the computer remembers they
  * were in.
  */
-static void
-lkkbd_reinit (struct work_struct *work)
+static void lkkbd_reinit(struct work_struct *work)
 {
         struct lkkbd *lk = container_of(work, struct lkkbd, tq);
         int division;
-        unsigned char leds_on = 0;
-        unsigned char leds_off = 0;
 
         /* Ask for ID */
-        serio_write (lk->serio, LK_CMD_REQUEST_ID);
+        serio_write(lk->serio, LK_CMD_REQUEST_ID);
 
         /* Reset parameters */
-        serio_write (lk->serio, LK_CMD_SET_DEFAULTS);
+        serio_write(lk->serio, LK_CMD_SET_DEFAULTS);
 
         /* Set LEDs */
-        CHECK_LED (lk, leds_on, leds_off, LED_CAPSL, LK_LED_SHIFTLOCK);
-        CHECK_LED (lk, leds_on, leds_off, LED_COMPOSE, LK_LED_COMPOSE);
-        CHECK_LED (lk, leds_on, leds_off, LED_SCROLLL, LK_LED_SCROLLLOCK);
-        CHECK_LED (lk, leds_on, leds_off, LED_SLEEP, LK_LED_WAIT);
-        if (leds_on != 0) {
-                serio_write (lk->serio, LK_CMD_LED_ON);
-                serio_write (lk->serio, leds_on);
-        }
-        if (leds_off != 0) {
-                serio_write (lk->serio, LK_CMD_LED_OFF);
-                serio_write (lk->serio, leds_off);
-        }
+        lkkbd_toggle_leds(lk);
 
         /*
          * Try to activate extended LK401 mode. This command will
          * only work with a LK401 keyboard and grants access to
          * LAlt, RAlt, RCompose and RShift.
          */
-        serio_write (lk->serio, LK_CMD_ENABLE_LK401);
+        serio_write(lk->serio, LK_CMD_ENABLE_LK401);
 
         /* Set all keys to UPDOWN mode */
         for (division = 1; division <= 14; division++)
-                serio_write (lk->serio, LK_CMD_SET_MODE (LK_MODE_UPDOWN,
-                                        division));
+                serio_write(lk->serio,
+                            LK_CMD_SET_MODE(LK_MODE_UPDOWN, division));
 
         /* Enable bell and set volume */
-        serio_write (lk->serio, LK_CMD_ENABLE_BELL);
-        serio_write (lk->serio, volume_to_hw (lk->bell_volume));
+        serio_write(lk->serio, LK_CMD_ENABLE_BELL);
+        serio_write(lk->serio, volume_to_hw(lk->bell_volume));
 
         /* Enable/disable keyclick (and possibly set volume) */
-        if (test_bit (SND_CLICK, lk->dev->snd)) {
-                serio_write (lk->serio, LK_CMD_ENABLE_KEYCLICK);
-                serio_write (lk->serio, volume_to_hw (lk->keyclick_volume));
-                serio_write (lk->serio, LK_CMD_ENABLE_CTRCLICK);
-                serio_write (lk->serio, volume_to_hw (lk->ctrlclick_volume));
-        } else {
-                serio_write (lk->serio, LK_CMD_DISABLE_KEYCLICK);
-                serio_write (lk->serio, LK_CMD_DISABLE_CTRCLICK);
-        }
+        lkkbd_toggle_keyclick(lk, test_bit(SND_CLICK, lk->dev->snd));
 
         /* Sound the bell if needed */
-        if (test_bit (SND_BELL, lk->dev->snd))
-                serio_write (lk->serio, LK_CMD_SOUND_BELL);
+        if (test_bit(SND_BELL, lk->dev->snd))
+                serio_write(lk->serio, LK_CMD_SOUND_BELL);
 }
 
 /*
  * lkkbd_connect() probes for a LK keyboard and fills the necessary structures.
  */
-static int
-lkkbd_connect (struct serio *serio, struct serio_driver *drv)
+static int lkkbd_connect(struct serio *serio, struct serio_driver *drv)
 {
         struct lkkbd *lk;
         struct input_dev *input_dev;
         int i;
         int err;
 
-        lk = kzalloc (sizeof (struct lkkbd), GFP_KERNEL);
-        input_dev = input_allocate_device ();
+        lk = kzalloc(sizeof(struct lkkbd), GFP_KERNEL);
+        input_dev = input_allocate_device();
         if (!lk || !input_dev) {
                 err = -ENOMEM;
                 goto fail1;
@@ -650,14 +633,14 @@ lkkbd_connect (struct serio *serio, struct serio_driver *drv)
 
         lk->serio = serio;
         lk->dev = input_dev;
-        INIT_WORK (&lk->tq, lkkbd_reinit);
+        INIT_WORK(&lk->tq, lkkbd_reinit);
         lk->bell_volume = bell_volume;
         lk->keyclick_volume = keyclick_volume;
         lk->ctrlclick_volume = ctrlclick_volume;
-        memcpy (lk->keycode, lkkbd_keycode, sizeof (lk_keycode_t) * LK_NUM_KEYCODES);
+        memcpy(lk->keycode, lkkbd_keycode, sizeof(lk->keycode));
 
-        strlcpy (lk->name, "DEC LK keyboard", sizeof(lk->name));
-        snprintf (lk->phys, sizeof(lk->phys), "%s/input0", serio->phys);
+        strlcpy(lk->name, "DEC LK keyboard", sizeof(lk->name));
+        snprintf(lk->phys, sizeof(lk->phys), "%s/input0", serio->phys);
 
         input_dev->name = lk->name;
         input_dev->phys = lk->phys;
@@ -668,62 +651,61 @@ lkkbd_connect (struct serio *serio, struct serio_driver *drv)
         input_dev->dev.parent = &serio->dev;
         input_dev->event = lkkbd_event;
 
-        input_set_drvdata (input_dev, lk);
+        input_set_drvdata(input_dev, lk);
 
-        set_bit (EV_KEY, input_dev->evbit);
-        set_bit (EV_LED, input_dev->evbit);
-        set_bit (EV_SND, input_dev->evbit);
-        set_bit (EV_REP, input_dev->evbit);
-        set_bit (LED_CAPSL, input_dev->ledbit);
-        set_bit (LED_SLEEP, input_dev->ledbit);
-        set_bit (LED_COMPOSE, input_dev->ledbit);
-        set_bit (LED_SCROLLL, input_dev->ledbit);
-        set_bit (SND_BELL, input_dev->sndbit);
-        set_bit (SND_CLICK, input_dev->sndbit);
+        __set_bit(EV_KEY, input_dev->evbit);
+        __set_bit(EV_LED, input_dev->evbit);
+        __set_bit(EV_SND, input_dev->evbit);
+        __set_bit(EV_REP, input_dev->evbit);
+        __set_bit(LED_CAPSL, input_dev->ledbit);
+        __set_bit(LED_SLEEP, input_dev->ledbit);
+        __set_bit(LED_COMPOSE, input_dev->ledbit);
+        __set_bit(LED_SCROLLL, input_dev->ledbit);
+        __set_bit(SND_BELL, input_dev->sndbit);
+        __set_bit(SND_CLICK, input_dev->sndbit);
 
         input_dev->keycode = lk->keycode;
-        input_dev->keycodesize = sizeof (lk_keycode_t);
-        input_dev->keycodemax = LK_NUM_KEYCODES;
+        input_dev->keycodesize = sizeof(lk->keycode[0]);
+        input_dev->keycodemax = ARRAY_SIZE(lk->keycode);
 
         for (i = 0; i < LK_NUM_KEYCODES; i++)
-                __set_bit (lk->keycode[i], input_dev->keybit);
+                __set_bit(lk->keycode[i], input_dev->keybit);
         __clear_bit(KEY_RESERVED, input_dev->keybit);
 
-        serio_set_drvdata (serio, lk);
+        serio_set_drvdata(serio, lk);
 
-        err = serio_open (serio, drv);
+        err = serio_open(serio, drv);
         if (err)
                 goto fail2;
 
-        err = input_register_device (lk->dev);
+        err = input_register_device(lk->dev);
         if (err)
                 goto fail3;
 
-        serio_write (lk->serio, LK_CMD_POWERCYCLE_RESET);
+        serio_write(lk->serio, LK_CMD_POWERCYCLE_RESET);
 
         return 0;
 
- fail3: serio_close (serio);
- fail2: serio_set_drvdata (serio, NULL);
- fail1: input_free_device (input_dev);
-        kfree (lk);
+ fail3: serio_close(serio);
+ fail2: serio_set_drvdata(serio, NULL);
+ fail1: input_free_device(input_dev);
+        kfree(lk);
         return err;
 }
 
 /*
  * lkkbd_disconnect() unregisters and closes behind us.
  */
-static void
-lkkbd_disconnect (struct serio *serio)
+static void lkkbd_disconnect(struct serio *serio)
 {
-        struct lkkbd *lk = serio_get_drvdata (serio);
-
-        input_get_device (lk->dev);
-        input_unregister_device (lk->dev);
-        serio_close (serio);
-        serio_set_drvdata (serio, NULL);
-        input_put_device (lk->dev);
-        kfree (lk);
+        struct lkkbd *lk = serio_get_drvdata(serio);
+
+        input_get_device(lk->dev);
+        input_unregister_device(lk->dev);
+        serio_close(serio);
+        serio_set_drvdata(serio, NULL);
+        input_put_device(lk->dev);
+        kfree(lk);
 }
 
 static struct serio_device_id lkkbd_serio_ids[] = {
@@ -752,18 +734,16 @@ static struct serio_driver lkkbd_drv = {
 /*
  * The functions for insering/removing us as a module.
  */
-static int __init
-lkkbd_init (void)
+static int __init lkkbd_init(void)
 {
         return serio_register_driver(&lkkbd_drv);
 }
 
-static void __exit
-lkkbd_exit (void)
+static void __exit lkkbd_exit(void)
 {
         serio_unregister_driver(&lkkbd_drv);
 }
 
-module_init (lkkbd_init);
-module_exit (lkkbd_exit);
+module_init(lkkbd_init);
+module_exit(lkkbd_exit);
 
diff --git a/drivers/input/keyboard/lm8323.c b/drivers/input/keyboard/lm8323.c
index 574eda2a4957..60ac4684f875 100644
--- a/drivers/input/keyboard/lm8323.c
+++ b/drivers/input/keyboard/lm8323.c
@@ -31,6 +31,7 @@
 #include <linux/input.h>
 #include <linux/leds.h>
 #include <linux/i2c/lm8323.h>
+#include <linux/slab.h>
 
 /* Commands to send to the chip. */
 #define LM8323_CMD_READ_ID              0x80 /* Read chip ID. */
diff --git a/drivers/input/keyboard/locomokbd.c b/drivers/input/keyboard/locomokbd.c
index 9caed30f3bbb..b1ab29861e1c 100644
--- a/drivers/input/keyboard/locomokbd.c
+++ b/drivers/input/keyboard/locomokbd.c
@@ -192,11 +192,18 @@ static void locomokbd_scankeyboard(struct locomokbd *locomokbd)
 static irqreturn_t locomokbd_interrupt(int irq, void *dev_id)
 {
         struct locomokbd *locomokbd = dev_id;
+        u16 r;
+
+        r = locomo_readl(locomokbd->base + LOCOMO_KIC);
+        if ((r & 0x0001) == 0)
+                return IRQ_HANDLED;
+
+        locomo_writel(r & ~0x0100, locomokbd->base + LOCOMO_KIC); /* Ack */
+
         /** wait chattering delay **/
         udelay(100);
 
         locomokbd_scankeyboard(locomokbd);
-
         return IRQ_HANDLED;
 }
 
@@ -210,6 +217,25 @@ static void locomokbd_timer_callback(unsigned long data)
         locomokbd_scankeyboard(locomokbd);
 }
 
+static int locomokbd_open(struct input_dev *dev)
+{
+        struct locomokbd *locomokbd = input_get_drvdata(dev);
+        u16 r;
+        
+        r = locomo_readl(locomokbd->base + LOCOMO_KIC) | 0x0010;
+        locomo_writel(r, locomokbd->base + LOCOMO_KIC);
+        return 0;
+}
+
+static void locomokbd_close(struct input_dev *dev)
+{
+        struct locomokbd *locomokbd = input_get_drvdata(dev);
+        u16 r;
+        
+        r = locomo_readl(locomokbd->base + LOCOMO_KIC) & ~0x0010;
+        locomo_writel(r, locomokbd->base + LOCOMO_KIC);
+}
+
 static int __devinit locomokbd_probe(struct locomo_dev *dev)
 {
         struct locomokbd *locomokbd;
@@ -253,6 +279,8 @@ static int __devinit locomokbd_probe(struct locomo_dev *dev)
         input_dev->id.vendor = 0x0001;
         input_dev->id.product = 0x0001;
         input_dev->id.version = 0x0100;
+        input_dev->open = locomokbd_open;
+        input_dev->close = locomokbd_close;
         input_dev->dev.parent = &dev->dev;
 
         input_dev->evbit[0] = BIT_MASK(EV_KEY) | BIT_MASK(EV_REP) |
@@ -261,6 +289,8 @@ static int __devinit locomokbd_probe(struct locomo_dev *dev)
         input_dev->keycodesize = sizeof(locomokbd_keycode[0]);
         input_dev->keycodemax = ARRAY_SIZE(locomokbd_keycode);
 
+        input_set_drvdata(input_dev, locomokbd);
+
         memcpy(locomokbd->keycode, locomokbd_keycode, sizeof(locomokbd->keycode));
         for (i = 0; i < LOCOMOKBD_NUMKEYS; i++)
                 set_bit(locomokbd->keycode[i], input_dev->keybit);
diff --git a/drivers/input/keyboard/matrix_keypad.c b/drivers/input/keyboard/matrix_keypad.c
index 91cfe5170265..ffc25cfcef7a 100644
--- a/drivers/input/keyboard/matrix_keypad.c
+++ b/drivers/input/keyboard/matrix_keypad.c
@@ -22,6 +22,7 @@
 #include <linux/module.h>
 #include <linux/gpio.h>
 #include <linux/input/matrix_keypad.h>
+#include <linux/slab.h>
 
 struct matrix_keypad {
         const struct matrix_keypad_platform_data *pdata;
@@ -29,11 +30,13 @@ struct matrix_keypad {
         unsigned short *keycodes;
         unsigned int row_shift;
 
+        DECLARE_BITMAP(disabled_gpios, MATRIX_MAX_ROWS);
+
         uint32_t last_key_state[MATRIX_MAX_COLS];
         struct delayed_work work;
+        spinlock_t lock;
         bool scan_pending;
         bool stopped;
-        spinlock_t lock;
 };
 
 /*
@@ -213,38 +216,53 @@ static void matrix_keypad_stop(struct input_dev *dev)
 }
 
 #ifdef CONFIG_PM
-static int matrix_keypad_suspend(struct platform_device *pdev, pm_message_t state)
+static int matrix_keypad_suspend(struct device *dev)
 {
+        struct platform_device *pdev = to_platform_device(dev);
         struct matrix_keypad *keypad = platform_get_drvdata(pdev);
         const struct matrix_keypad_platform_data *pdata = keypad->pdata;
         int i;
 
         matrix_keypad_stop(keypad->input_dev);
 
-        if (device_may_wakeup(&pdev->dev))
-                for (i = 0; i < pdata->num_row_gpios; i++)
-                        enable_irq_wake(gpio_to_irq(pdata->row_gpios[i]));
+        if (device_may_wakeup(&pdev->dev)) {
+                for (i = 0; i < pdata->num_row_gpios; i++) {
+                        if (!test_bit(i, keypad->disabled_gpios)) {
+                                unsigned int gpio = pdata->row_gpios[i];
+
+                                if (enable_irq_wake(gpio_to_irq(gpio)) == 0)
+                                        __set_bit(i, keypad->disabled_gpios);
+                        }
+                }
+        }
 
         return 0;
 }
 
-static int matrix_keypad_resume(struct platform_device *pdev)
+static int matrix_keypad_resume(struct device *dev)
 {
+        struct platform_device *pdev = to_platform_device(dev);
         struct matrix_keypad *keypad = platform_get_drvdata(pdev);
         const struct matrix_keypad_platform_data *pdata = keypad->pdata;
         int i;
 
-        if (device_may_wakeup(&pdev->dev))
-                for (i = 0; i < pdata->num_row_gpios; i++)
-                        disable_irq_wake(gpio_to_irq(pdata->row_gpios[i]));
+        if (device_may_wakeup(&pdev->dev)) {
+                for (i = 0; i < pdata->num_row_gpios; i++) {
+                        if (test_and_clear_bit(i, keypad->disabled_gpios)) {
+                                unsigned int gpio = pdata->row_gpios[i];
+
+                                disable_irq_wake(gpio_to_irq(gpio));
+                        }
+                }
+        }
 
         matrix_keypad_start(keypad->input_dev);
 
         return 0;
 }
-#else
-#define matrix_keypad_suspend   NULL
-#define matrix_keypad_resume    NULL
+
+static const SIMPLE_DEV_PM_OPS(matrix_keypad_pm_ops,
+                                matrix_keypad_suspend, matrix_keypad_resume);
 #endif
 
 static int __devinit init_matrix_gpio(struct platform_device *pdev,
@@ -417,11 +435,12 @@ static int __devexit matrix_keypad_remove(struct platform_device *pdev)
 static struct platform_driver matrix_keypad_driver = {
         .probe          = matrix_keypad_probe,
         .remove         = __devexit_p(matrix_keypad_remove),
-        .suspend        = matrix_keypad_suspend,
-        .resume         = matrix_keypad_resume,
         .driver         = {
                 .name   = "matrix-keypad",
                 .owner  = THIS_MODULE,
+#ifdef CONFIG_PM
+                .pm     = &matrix_keypad_pm_ops,
+#endif
         },
 };
 
diff --git a/drivers/input/keyboard/max7359_keypad.c b/drivers/input/keyboard/max7359_keypad.c
index 3b5b948eba39..7fc8185e5c1b 100644
--- a/drivers/input/keyboard/max7359_keypad.c
+++ b/drivers/input/keyboard/max7359_keypad.c
@@ -15,6 +15,7 @@
 
 #include <linux/module.h>
 #include <linux/i2c.h>
+#include <linux/slab.h>
 #include <linux/interrupt.h>
 #include <linux/input.h>
 #include <linux/input/matrix_keypad.h>
diff --git a/drivers/input/keyboard/omap-keypad.c b/drivers/input/keyboard/omap-keypad.c
index bba85add35a3..a72e61ddca91 100644
--- a/drivers/input/keyboard/omap-keypad.c
+++ b/drivers/input/keyboard/omap-keypad.c
@@ -34,13 +34,14 @@
 #include <linux/platform_device.h>
 #include <linux/mutex.h>
 #include <linux/errno.h>
+#include <linux/slab.h>
 #include <mach/gpio.h>
-#include <mach/keypad.h>
-#include <mach/menelaus.h>
+#include <plat/keypad.h>
+#include <plat/menelaus.h>
 #include <asm/irq.h>
 #include <mach/hardware.h>
 #include <asm/io.h>
-#include <mach/mux.h>
+#include <plat/mux.h>
 
 #undef NEW_BOARD_LEARNING_MODE
 
diff --git a/drivers/input/keyboard/opencores-kbd.c b/drivers/input/keyboard/opencores-kbd.c
index 78cccddbf551..1f1a5563f60a 100644
--- a/drivers/input/keyboard/opencores-kbd.c
+++ b/drivers/input/keyboard/opencores-kbd.c
@@ -14,6 +14,7 @@
 #include <linux/kernel.h>
 #include <linux/module.h>
 #include <linux/platform_device.h>
+#include <linux/slab.h>
 
 struct opencores_kbd {
         struct input_dev *input;
diff --git a/drivers/input/keyboard/pxa27x_keypad.c b/drivers/input/keyboard/pxa27x_keypad.c
index 79cd3e9fdf2e..0e53b3bc39af 100644
--- a/drivers/input/keyboard/pxa27x_keypad.c
+++ b/drivers/input/keyboard/pxa27x_keypad.c
@@ -26,6 +26,7 @@
 #include <linux/clk.h>
 #include <linux/err.h>
 #include <linux/input/matrix_keypad.h>
+#include <linux/slab.h>
 
 #include <asm/mach/arch.h>
 #include <asm/mach/map.h>
diff --git a/drivers/input/keyboard/pxa930_rotary.c b/drivers/input/keyboard/pxa930_rotary.c
index 95fbba470e65..b7123a44b6ec 100644
--- a/drivers/input/keyboard/pxa930_rotary.c
+++ b/drivers/input/keyboard/pxa930_rotary.c
@@ -13,6 +13,7 @@
 #include <linux/input.h>
 #include <linux/platform_device.h>
 #include <linux/io.h>
+#include <linux/slab.h>
 
 #include <mach/pxa930_rotary.h>
 
diff --git a/drivers/input/keyboard/qt2160.c b/drivers/input/keyboard/qt2160.c
index 191cc51d6cf8..31f30087b591 100644
--- a/drivers/input/keyboard/qt2160.c
+++ b/drivers/input/keyboard/qt2160.c
@@ -362,7 +362,7 @@ static int __devexit qt2160_remove(struct i2c_client *client)
         return 0;
 }
 
-static struct i2c_device_id qt2160_idtable[] = {
+static const struct i2c_device_id qt2160_idtable[] = {
         { "qt2160", 0, },
         { }
 };
diff --git a/drivers/input/keyboard/sh_keysc.c b/drivers/input/keyboard/sh_keysc.c
index 887af79b7bff..d7dafd9425b6 100644
--- a/drivers/input/keyboard/sh_keysc.c
+++ b/drivers/input/keyboard/sh_keysc.c
@@ -18,17 +18,11 @@
 #include <linux/delay.h>
 #include <linux/platform_device.h>
 #include <linux/input.h>
+#include <linux/input/sh_keysc.h>
+#include <linux/bitmap.h>
 #include <linux/clk.h>
 #include <linux/io.h>
-#include <asm/sh_keysc.h>
-
-#define KYCR1_OFFS   0x00
-#define KYCR2_OFFS   0x04
-#define KYINDR_OFFS  0x08
-#define KYOUTDR_OFFS 0x0c
-
-#define KYCR2_IRQ_LEVEL    0x10
-#define KYCR2_IRQ_DISABLED 0x00
+#include <linux/slab.h>
 
 static const struct {
         unsigned char kymd, keyout, keyin;
@@ -36,84 +30,131 @@ static const struct {
         [SH_KEYSC_MODE_1] = { 0, 6, 5 },
         [SH_KEYSC_MODE_2] = { 1, 5, 6 },
         [SH_KEYSC_MODE_3] = { 2, 4, 7 },
+        [SH_KEYSC_MODE_4] = { 3, 6, 6 },
+        [SH_KEYSC_MODE_5] = { 4, 6, 7 },
+        [SH_KEYSC_MODE_6] = { 5, 7, 7 },
 };
 
 struct sh_keysc_priv {
         void __iomem *iomem_base;
         struct clk *clk;
-        unsigned long last_keys;
+        DECLARE_BITMAP(last_keys, SH_KEYSC_MAXKEYS);
         struct input_dev *input;
         struct sh_keysc_info pdata;
 };
 
+#define KYCR1 0
+#define KYCR2 1
+#define KYINDR 2
+#define KYOUTDR 3
+
+#define KYCR2_IRQ_LEVEL    0x10
+#define KYCR2_IRQ_DISABLED 0x00
+
+static unsigned long sh_keysc_read(struct sh_keysc_priv *p, int reg_nr)
+{
+        return ioread16(p->iomem_base + (reg_nr << 2));
+}
+
+static void sh_keysc_write(struct sh_keysc_priv *p, int reg_nr,
+                           unsigned long value)
+{
+        iowrite16(value, p->iomem_base + (reg_nr << 2));
+}
+
+static void sh_keysc_level_mode(struct sh_keysc_priv *p,
+                                unsigned long keys_set)
+{
+        struct sh_keysc_info *pdata = &p->pdata;
+
+        sh_keysc_write(p, KYOUTDR, 0);
+        sh_keysc_write(p, KYCR2, KYCR2_IRQ_LEVEL | (keys_set << 8));
+
+        if (pdata->kycr2_delay)
+                udelay(pdata->kycr2_delay);
+}
+
+static void sh_keysc_map_dbg(struct device *dev, unsigned long *map,
+                             const char *str)
+{
+        int k;
+
+        for (k = 0; k < BITS_TO_LONGS(SH_KEYSC_MAXKEYS); k++)
+                dev_dbg(dev, "%s[%d] 0x%lx\n", str, k, map[k]);
+}
+
 static irqreturn_t sh_keysc_isr(int irq, void *dev_id)
 {
         struct platform_device *pdev = dev_id;
         struct sh_keysc_priv *priv = platform_get_drvdata(pdev);
         struct sh_keysc_info *pdata = &priv->pdata;
-        unsigned long keys, keys1, keys0, mask;
+        int keyout_nr = sh_keysc_mode[pdata->mode].keyout;
+        int keyin_nr = sh_keysc_mode[pdata->mode].keyin;
+        DECLARE_BITMAP(keys, SH_KEYSC_MAXKEYS);
+        DECLARE_BITMAP(keys0, SH_KEYSC_MAXKEYS);
+        DECLARE_BITMAP(keys1, SH_KEYSC_MAXKEYS);
         unsigned char keyin_set, tmp;
-        int i, k;
+        int i, k, n;
 
         dev_dbg(&pdev->dev, "isr!\n");
 
-        keys1 = ~0;
-        keys0 = 0;
+        bitmap_fill(keys1, SH_KEYSC_MAXKEYS);
+        bitmap_zero(keys0, SH_KEYSC_MAXKEYS);
 
         do {
-                keys = 0;
+                bitmap_zero(keys, SH_KEYSC_MAXKEYS);
                 keyin_set = 0;
 
-                iowrite16(KYCR2_IRQ_DISABLED, priv->iomem_base + KYCR2_OFFS);
+                sh_keysc_write(priv, KYCR2, KYCR2_IRQ_DISABLED);
+
+                for (i = 0; i < keyout_nr; i++) {
+                        n = keyin_nr * i;
 
-                for (i = 0; i < sh_keysc_mode[pdata->mode].keyout; i++) {
-                        iowrite16(0xfff ^ (3 << (i * 2)),
-                                  priv->iomem_base + KYOUTDR_OFFS);
+                        /* drive one KEYOUT pin low, read KEYIN pins */
+                        sh_keysc_write(priv, KYOUTDR, 0xffff ^ (3 << (i * 2)));
                         udelay(pdata->delay);
-                        tmp = ioread16(priv->iomem_base + KYINDR_OFFS);
-                        keys |= tmp << (sh_keysc_mode[pdata->mode].keyin * i);
-                        tmp ^= (1 << sh_keysc_mode[pdata->mode].keyin) - 1;
-                        keyin_set |= tmp;
-                }
+                        tmp = sh_keysc_read(priv, KYINDR);
 
-                iowrite16(0, priv->iomem_base + KYOUTDR_OFFS);
-                iowrite16(KYCR2_IRQ_LEVEL | (keyin_set << 8),
-                          priv->iomem_base + KYCR2_OFFS);
+                        /* set bit if key press has been detected */
+                        for (k = 0; k < keyin_nr; k++) {
+                                if (tmp & (1 << k))
+                                        __set_bit(n + k, keys);
+                        }
 
-                if (pdata->kycr2_delay)
-                        udelay(pdata->kycr2_delay);
+                        /* keep track of which KEYIN bits that have been set */
+                        keyin_set |= tmp ^ ((1 << keyin_nr) - 1);
+                }
 
-                keys ^= ~0;
-                keys &= (1 << (sh_keysc_mode[pdata->mode].keyin *
-                               sh_keysc_mode[pdata->mode].keyout)) - 1;
-                keys1 &= keys;
-                keys0 |= keys;
+                sh_keysc_level_mode(priv, keyin_set);
 
-                dev_dbg(&pdev->dev, "keys 0x%08lx\n", keys);
+                bitmap_complement(keys, keys, SH_KEYSC_MAXKEYS);
+                bitmap_and(keys1, keys1, keys, SH_KEYSC_MAXKEYS);
+                bitmap_or(keys0, keys0, keys, SH_KEYSC_MAXKEYS);
 
-        } while (ioread16(priv->iomem_base + KYCR2_OFFS) & 0x01);
+                sh_keysc_map_dbg(&pdev->dev, keys, "keys");
 
-        dev_dbg(&pdev->dev, "last_keys 0x%08lx keys0 0x%08lx keys1 0x%08lx\n",
-                priv->last_keys, keys0, keys1);
+        } while (sh_keysc_read(priv, KYCR2) & 0x01);
+
+        sh_keysc_map_dbg(&pdev->dev, priv->last_keys, "last_keys");
+        sh_keysc_map_dbg(&pdev->dev, keys0, "keys0");
+        sh_keysc_map_dbg(&pdev->dev, keys1, "keys1");
 
         for (i = 0; i < SH_KEYSC_MAXKEYS; i++) {
                 k = pdata->keycodes[i];
                 if (!k)
                         continue;
 
-                mask = 1 << i;
-
-                if (!((priv->last_keys ^ keys0) & mask))
+                if (test_bit(i, keys0) == test_bit(i, priv->last_keys))
                         continue;
 
-                if ((keys1 | keys0) & mask) {
+                if (test_bit(i, keys1) || test_bit(i, keys0)) {
                         input_event(priv->input, EV_KEY, k, 1);
-                        priv->last_keys |= mask;
+                        __set_bit(i, priv->last_keys);
                 }
 
-                if (!(keys1 & mask)) {
+                if (!test_bit(i, keys1)) {
                         input_event(priv->input, EV_KEY, k, 0);
-                        priv->last_keys &= ~mask;
+                        __clear_bit(i, priv->last_keys);
                 }
 
         }
@@ -122,8 +163,6 @@ static irqreturn_t sh_keysc_isr(int irq, void *dev_id)
         return IRQ_HANDLED;
 }
 
-#define res_size(res) ((res)->end - (res)->start + 1)
-
 static int __devinit sh_keysc_probe(struct platform_device *pdev)
 {
         struct sh_keysc_priv *priv;
@@ -164,7 +203,7 @@ static int __devinit sh_keysc_probe(struct platform_device *pdev)
         memcpy(&priv->pdata, pdev->dev.platform_data, sizeof(priv->pdata));
         pdata = &priv->pdata;
 
-        priv->iomem_base = ioremap_nocache(res->start, res_size(res));
+        priv->iomem_base = ioremap_nocache(res->start, resource_size(res));
         if (priv->iomem_base == NULL) {
                 dev_err(&pdev->dev, "failed to remap I/O memory\n");
                 error = -ENXIO;
@@ -220,10 +259,9 @@ static int __devinit sh_keysc_probe(struct platform_device *pdev)
 
         clk_enable(priv->clk);
 
-        iowrite16((sh_keysc_mode[pdata->mode].kymd << 8) |
-                  pdata->scan_timing, priv->iomem_base + KYCR1_OFFS);
-        iowrite16(0, priv->iomem_base + KYOUTDR_OFFS);
-        iowrite16(KYCR2_IRQ_LEVEL, priv->iomem_base + KYCR2_OFFS);
+        sh_keysc_write(priv, KYCR1, (sh_keysc_mode[pdata->mode].kymd << 8) |
+                       pdata->scan_timing);
+        sh_keysc_level_mode(priv, 0);
 
         device_init_wakeup(&pdev->dev, 1);
 
@@ -248,7 +286,7 @@ static int __devexit sh_keysc_remove(struct platform_device *pdev)
 {
         struct sh_keysc_priv *priv = platform_get_drvdata(pdev);
 
-        iowrite16(KYCR2_IRQ_DISABLED, priv->iomem_base + KYCR2_OFFS);
+        sh_keysc_write(priv, KYCR2, KYCR2_IRQ_DISABLED);
 
         input_unregister_device(priv->input);
         free_irq(platform_get_irq(pdev, 0), pdev);
@@ -270,7 +308,7 @@ static int sh_keysc_suspend(struct device *dev)
         int irq = platform_get_irq(pdev, 0);
         unsigned short value;
 
-        value = ioread16(priv->iomem_base + KYCR1_OFFS);
+        value = sh_keysc_read(priv, KYCR1);
 
         if (device_may_wakeup(dev)) {
                 value |= 0x80;
@@ -279,7 +317,7 @@ static int sh_keysc_suspend(struct device *dev)
                 value &= ~0x80;
         }
 
-        iowrite16(value, priv->iomem_base + KYCR1_OFFS);
+        sh_keysc_write(priv, KYCR1, value);
 
         return 0;
 }
@@ -295,7 +333,7 @@ static int sh_keysc_resume(struct device *dev)
         return 0;
 }
 
-static struct dev_pm_ops sh_keysc_dev_pm_ops = {
+static const struct dev_pm_ops sh_keysc_dev_pm_ops = {
         .suspend = sh_keysc_suspend,
         .resume = sh_keysc_resume,
 };
diff --git a/drivers/input/keyboard/tosakbd.c b/drivers/input/keyboard/tosakbd.c
index 42cb3faf7336..3910f269cfc8 100644
--- a/drivers/input/keyboard/tosakbd.c
+++ b/drivers/input/keyboard/tosakbd.c
@@ -18,6 +18,7 @@
 #include <linux/input.h>
 #include <linux/delay.h>
 #include <linux/interrupt.h>
+#include <linux/slab.h>
 
 #include <mach/gpio.h>
 #include <mach/tosa.h>
diff --git a/drivers/input/keyboard/twl4030_keypad.c b/drivers/input/keyboard/twl4030_keypad.c
index 9a2977c21696..7aa59e07b689 100644
--- a/drivers/input/keyboard/twl4030_keypad.c
+++ b/drivers/input/keyboard/twl4030_keypad.c
@@ -31,7 +31,8 @@
 #include <linux/interrupt.h>
 #include <linux/input.h>
 #include <linux/platform_device.h>
-#include <linux/i2c/twl4030.h>
+#include <linux/i2c/twl.h>
+#include <linux/slab.h>
 
 
 /*
@@ -133,7 +134,7 @@ struct twl4030_keypad {
 static int twl4030_kpread(struct twl4030_keypad *kp,
                 u8 *data, u32 reg, u8 num_bytes)
 {
-        int ret = twl4030_i2c_read(TWL4030_MODULE_KEYPAD, data, reg, num_bytes);
+        int ret = twl_i2c_read(TWL4030_MODULE_KEYPAD, data, reg, num_bytes);
 
         if (ret < 0)
                 dev_warn(kp->dbg_dev,
@@ -145,7 +146,7 @@ static int twl4030_kpread(struct twl4030_keypad *kp,
 
 static int twl4030_kpwrite_u8(struct twl4030_keypad *kp, u8 data, u32 reg)
 {
-        int ret = twl4030_i2c_write_u8(TWL4030_MODULE_KEYPAD, data, reg);
+        int ret = twl_i2c_write_u8(TWL4030_MODULE_KEYPAD, data, reg);
 
         if (ret < 0)
                 dev_warn(kp->dbg_dev,
@@ -253,14 +254,6 @@ static irqreturn_t do_kp_irq(int irq, void *_kp)
         u8 reg;
         int ret;
 
-#ifdef CONFIG_LOCKDEP
-        /* WORKAROUND for lockdep forcing IRQF_DISABLED on us, which
-         * we don't want and can't tolerate.  Although it might be
-         * friendlier not to borrow this thread context...
-         */
-        local_irq_enable();
-#endif
-
         /* Read & Clear TWL4030 pending interrupt */
         ret = twl4030_kpread(kp, &reg, KEYP_ISR1, 1);
 
@@ -403,7 +396,8 @@ static int __devinit twl4030_kp_probe(struct platform_device *pdev)
          *
          * NOTE:  we assume this host is wired to TWL4040 INT1, not INT2 ...
          */
-        error = request_irq(kp->irq, do_kp_irq, 0, pdev->name, kp);
+        error = request_threaded_irq(kp->irq, NULL, do_kp_irq,
+                        0, pdev->name, kp);
         if (error) {
                 dev_info(kp->dbg_dev, "request_irq failed for irq no=%d\n",
                         kp->irq);
diff --git a/drivers/input/keyboard/w90p910_keypad.c b/drivers/input/keyboard/w90p910_keypad.c
index 6032def03707..4ef764cc493c 100644
--- a/drivers/input/keyboard/w90p910_keypad.c
+++ b/drivers/input/keyboard/w90p910_keypad.c
@@ -19,6 +19,7 @@
 #include <linux/clk.h>
 #include <linux/err.h>
 #include <linux/io.h>
+#include <linux/slab.h>
 
 #include <mach/w90p910_keypad.h>
 
diff --git a/drivers/input/misc/88pm860x_onkey.c b/drivers/input/misc/88pm860x_onkey.c
new file mode 100644
index 000000000000..40dabd8487b5
--- /dev/null
+++ b/drivers/input/misc/88pm860x_onkey.c
@@ -0,0 +1,156 @@
+/*
+ * 88pm860x_onkey.c - Marvell 88PM860x ONKEY driver
+ *
+ * Copyright (C) 2009-2010 Marvell International Ltd.
+ *      Haojian Zhuang <haojian.zhuang@marvell.com>
+ *
+ * This file is subject to the terms and conditions of the GNU General
+ * Public License. See the file "COPYING" in the main directory of this
+ * archive for more details.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
+ */
+
+#include <linux/kernel.h>
+#include <linux/module.h>
+#include <linux/platform_device.h>
+#include <linux/i2c.h>
+#include <linux/input.h>
+#include <linux/interrupt.h>
+#include <linux/mfd/88pm860x.h>
+#include <linux/slab.h>
+
+#define PM8607_WAKEUP           0x0b
+
+#define LONG_ONKEY_EN           (1 << 1)
+#define ONKEY_STATUS            (1 << 0)
+
+struct pm860x_onkey_info {
+        struct input_dev        *idev;
+        struct pm860x_chip      *chip;
+        struct i2c_client       *i2c;
+        struct device           *dev;
+        int                     irq;
+};
+
+/* 88PM860x gives us an interrupt when ONKEY is held */
+static irqreturn_t pm860x_onkey_handler(int irq, void *data)
+{
+        struct pm860x_onkey_info *info = data;
+        int ret;
+
+        ret = pm860x_reg_read(info->i2c, PM8607_STATUS_2);
+        ret &= ONKEY_STATUS;
+        input_report_key(info->idev, KEY_POWER, ret);
+        input_sync(info->idev);
+
+        /* Enable 8-second long onkey detection */
+        pm860x_set_bits(info->i2c, PM8607_WAKEUP, 3, LONG_ONKEY_EN);
+        return IRQ_HANDLED;
+}
+
+static int __devinit pm860x_onkey_probe(struct platform_device *pdev)
+{
+        struct pm860x_chip *chip = dev_get_drvdata(pdev->dev.parent);
+        struct pm860x_onkey_info *info;
+        int irq, ret;
+
+        irq = platform_get_irq(pdev, 0);
+        if (irq < 0) {
+                dev_err(&pdev->dev, "No IRQ resource!\n");
+                return -EINVAL;
+        }
+
+        info = kzalloc(sizeof(struct pm860x_onkey_info), GFP_KERNEL);
+        if (!info)
+                return -ENOMEM;
+        info->chip = chip;
+        info->i2c = (chip->id == CHIP_PM8607) ? chip->client : chip->companion;
+        info->dev = &pdev->dev;
+        info->irq = irq + chip->irq_base;
+
+        info->idev = input_allocate_device();
+        if (!info->idev) {
+                dev_err(chip->dev, "Failed to allocate input dev\n");
+                ret = -ENOMEM;
+                goto out;
+        }
+
+        info->idev->name = "88pm860x_on";
+        info->idev->phys = "88pm860x_on/input0";
+        info->idev->id.bustype = BUS_I2C;
+        info->idev->dev.parent = &pdev->dev;
+        info->irq = irq;
+        info->idev->evbit[0] = BIT_MASK(EV_KEY);
+        info->idev->keybit[BIT_WORD(KEY_POWER)] = BIT_MASK(KEY_POWER);
+
+        ret = input_register_device(info->idev);
+        if (ret) {
+                dev_err(chip->dev, "Can't register input device: %d\n", ret);
+                goto out_reg;
+        }
+
+        ret = request_threaded_irq(info->irq, NULL, pm860x_onkey_handler,
+                                   IRQF_ONESHOT, "onkey", info);
+        if (ret < 0) {
+                dev_err(chip->dev, "Failed to request IRQ: #%d: %d\n",
+                        info->irq, ret);
+                goto out_irq;
+        }
+
+        platform_set_drvdata(pdev, info);
+        return 0;
+
+out_irq:
+        input_unregister_device(info->idev);
+        kfree(info);
+        return ret;
+
+out_reg:
+        input_free_device(info->idev);
+out:
+        kfree(info);
+        return ret;
+}
+
+static int __devexit pm860x_onkey_remove(struct platform_device *pdev)
+{
+        struct pm860x_onkey_info *info = platform_get_drvdata(pdev);
+
+        free_irq(info->irq, info);
+        input_unregister_device(info->idev);
+        kfree(info);
+        return 0;
+}
+
+static struct platform_driver pm860x_onkey_driver = {
+        .driver         = {
+                .name   = "88pm860x-onkey",
+                .owner  = THIS_MODULE,
+        },
+        .probe          = pm860x_onkey_probe,
+        .remove         = __devexit_p(pm860x_onkey_remove),
+};
+
+static int __init pm860x_onkey_init(void)
+{
+        return platform_driver_register(&pm860x_onkey_driver);
+}
+module_init(pm860x_onkey_init);
+
+static void __exit pm860x_onkey_exit(void)
+{
+        platform_driver_unregister(&pm860x_onkey_driver);
+}
+module_exit(pm860x_onkey_exit);
+
+MODULE_DESCRIPTION("Marvell 88PM860x ONKEY driver");
+MODULE_AUTHOR("Haojian Zhuang <haojian.zhuang@marvell.com>");
+MODULE_LICENSE("GPL");
diff --git a/drivers/input/misc/Kconfig b/drivers/input/misc/Kconfig
index a9bb2544b2de..23140a3bb8e0 100644
--- a/drivers/input/misc/Kconfig
+++ b/drivers/input/misc/Kconfig
@@ -12,6 +12,16 @@ menuconfig INPUT_MISC
 
 if INPUT_MISC
 
+config INPUT_88PM860X_ONKEY
+        tristate "88PM860x ONKEY support"
+        depends on MFD_88PM860X
+        help
+          Support the ONKEY of Marvell 88PM860x PMICs as an input device
+          reporting power button status.
+
+          To compile this driver as a module, choose M here: the module
+          will be called 88pm860x_onkey.
+
 config INPUT_PCSPKR
         tristate "PC Speaker support"
         depends on PCSPKR_PLATFORM
@@ -80,6 +90,7 @@ config INPUT_WISTRON_BTNS
         tristate "x86 Wistron laptop button interface"
         depends on X86 && !X86_64
         select INPUT_POLLDEV
+        select INPUT_SPARSEKMAP
         select NEW_LEDS
         select LEDS_CLASS
         select CHECK_SIGNATURE
@@ -203,6 +214,17 @@ config INPUT_TWL4030_PWRBUTTON
           To compile this driver as a module, choose M here. The module will
           be called twl4030_pwrbutton.
 
+config INPUT_TWL4030_VIBRA
+        tristate "Support for TWL4030 Vibrator"
+        depends on TWL4030_CORE
+        select TWL4030_CODEC
+        select INPUT_FF_MEMLESS
+        help
+          This option enables support for TWL4030 Vibrator Driver.
+
+          To compile this driver as a module, choose M here. The module will
+          be called twl4030_vibra.
+
 config INPUT_UINPUT
         tristate "User level driver support"
         help
@@ -281,6 +303,7 @@ config INPUT_RB532_BUTTON
 config INPUT_DM355EVM
         tristate "TI DaVinci DM355 EVM Keypad and IR Remote"
         depends on MFD_DM355EVM_MSP
+        select INPUT_SPARSEKMAP
         help
           Supports the pushbuttons and IR remote used with
           the DM355 EVM board.
diff --git a/drivers/input/misc/Makefile b/drivers/input/misc/Makefile
index a8b84854fb7b..7e95a5d474dc 100644
--- a/drivers/input/misc/Makefile
+++ b/drivers/input/misc/Makefile
@@ -4,6 +4,7 @@
 
 # Each configuration option enables a list of files.
 
+obj-$(CONFIG_INPUT_88PM860X_ONKEY)      += 88pm860x_onkey.o
 obj-$(CONFIG_INPUT_APANEL)              += apanel.o
 obj-$(CONFIG_INPUT_ATI_REMOTE)          += ati_remote.o
 obj-$(CONFIG_INPUT_ATI_REMOTE2)         += ati_remote2.o
@@ -25,6 +26,7 @@ obj-$(CONFIG_INPUT_GPIO_ROTARY_ENCODER)	+= rotary_encoder.o
 obj-$(CONFIG_INPUT_SGI_BTNS)            += sgi_btns.o
 obj-$(CONFIG_INPUT_SPARCSPKR)           += sparcspkr.o
 obj-$(CONFIG_INPUT_TWL4030_PWRBUTTON)   += twl4030-pwrbutton.o
+obj-$(CONFIG_INPUT_TWL4030_VIBRA)       += twl4030-vibra.o
 obj-$(CONFIG_INPUT_UINPUT)              += uinput.o
 obj-$(CONFIG_INPUT_WINBOND_CIR)         += winbond-cir.o
 obj-$(CONFIG_INPUT_WISTRON_BTNS)        += wistron_btns.o
diff --git a/drivers/input/misc/apanel.c b/drivers/input/misc/apanel.c
index 71b82434264d..a8d2b8db4e35 100644
--- a/drivers/input/misc/apanel.c
+++ b/drivers/input/misc/apanel.c
@@ -149,7 +149,7 @@ static void apanel_shutdown(struct i2c_client *client)
         apanel_remove(client);
 }
 
-static struct i2c_device_id apanel_id[] = {
+static const struct i2c_device_id apanel_id[] = {
         { "fujitsu_apanel", 0 },
         { }
 };
diff --git a/drivers/input/misc/ati_remote.c b/drivers/input/misc/ati_remote.c
index e290fde35e74..614b65d78fe9 100644
--- a/drivers/input/misc/ati_remote.c
+++ b/drivers/input/misc/ati_remote.c
@@ -766,7 +766,7 @@ static int ati_remote_probe(struct usb_interface *interface, const struct usb_de
         ati_remote->interface = interface;
 
         usb_make_path(udev, ati_remote->phys, sizeof(ati_remote->phys));
-        strlcpy(ati_remote->phys, "/input0", sizeof(ati_remote->phys));
+        strlcat(ati_remote->phys, "/input0", sizeof(ati_remote->phys));
 
         if (udev->manufacturer)
                 strlcpy(ati_remote->name, udev->manufacturer, sizeof(ati_remote->name));
diff --git a/drivers/input/misc/ati_remote2.c b/drivers/input/misc/ati_remote2.c
index 0501f0e65157..2124b99378bb 100644
--- a/drivers/input/misc/ati_remote2.c
+++ b/drivers/input/misc/ati_remote2.c
@@ -10,6 +10,7 @@
  */
 
 #include <linux/usb/input.h>
+#include <linux/slab.h>
 
 #define DRIVER_DESC    "ATI/Philips USB RF remote driver"
 #define DRIVER_VERSION "0.3"
@@ -474,10 +475,11 @@ static void ati_remote2_complete_key(struct urb *urb)
 }
 
 static int ati_remote2_getkeycode(struct input_dev *idev,
-                                  int scancode, int *keycode)
+                                  unsigned int scancode, unsigned int *keycode)
 {
         struct ati_remote2 *ar2 = input_get_drvdata(idev);
-        int index, mode;
+        unsigned int mode;
+        int index;
 
         mode = scancode >> 8;
         if (mode > ATI_REMOTE2_PC || !((1 << mode) & ar2->mode_mask))
@@ -491,10 +493,12 @@ static int ati_remote2_getkeycode(struct input_dev *idev,
         return 0;
 }
 
-static int ati_remote2_setkeycode(struct input_dev *idev, int scancode, int keycode)
+static int ati_remote2_setkeycode(struct input_dev *idev,
+                                  unsigned int scancode, unsigned int keycode)
 {
         struct ati_remote2 *ar2 = input_get_drvdata(idev);
-        int index, mode, old_keycode;
+        unsigned int mode, old_keycode;
+        int index;
 
         mode = scancode >> 8;
         if (mode > ATI_REMOTE2_PC || !((1 << mode) & ar2->mode_mask))
@@ -504,9 +508,6 @@ static int ati_remote2_setkeycode(struct input_dev *idev, int scancode, int keyc
         if (index < 0)
                 return -EINVAL;
 
-        if (keycode < KEY_RESERVED || keycode > KEY_MAX)
-                return -EINVAL;
-
         old_keycode = ar2->keycode[mode][index];
         ar2->keycode[mode][index] = keycode;
         __set_bit(keycode, idev->keybit);
diff --git a/drivers/input/misc/atlas_btns.c b/drivers/input/misc/atlas_btns.c
index 1b871917340a..dfaa9a045ed8 100644
--- a/drivers/input/misc/atlas_btns.c
+++ b/drivers/input/misc/atlas_btns.c
@@ -47,7 +47,7 @@ static acpi_status acpi_atlas_button_setup(acpi_handle region_handle,
 
 static acpi_status acpi_atlas_button_handler(u32 function,
                       acpi_physical_address address,
-                      u32 bit_width, acpi_integer *value,
+                      u32 bit_width, u64 *value,
                       void *handler_context, void *region_context)
 {
         acpi_status status;
diff --git a/drivers/input/misc/bfin_rotary.c b/drivers/input/misc/bfin_rotary.c
index 690f3fafa03b..4f72bdd69410 100644
--- a/drivers/input/misc/bfin_rotary.c
+++ b/drivers/input/misc/bfin_rotary.c
@@ -13,6 +13,7 @@
 #include <linux/pm.h>
 #include <linux/platform_device.h>
 #include <linux/input.h>
+#include <linux/slab.h>
 
 #include <asm/portmux.h>
 #include <asm/bfin_rotary.h>
@@ -247,7 +248,7 @@ static int bfin_rotary_resume(struct device *dev)
         return 0;
 }
 
-static struct dev_pm_ops bfin_rotary_pm_ops = {
+static const struct dev_pm_ops bfin_rotary_pm_ops = {
         .suspend        = bfin_rotary_suspend,
         .resume         = bfin_rotary_resume,
 };
diff --git a/drivers/input/misc/cobalt_btns.c b/drivers/input/misc/cobalt_btns.c
index ee73d7219c92..fd8407a29631 100644
--- a/drivers/input/misc/cobalt_btns.c
+++ b/drivers/input/misc/cobalt_btns.c
@@ -22,6 +22,7 @@
 #include <linux/ioport.h>
 #include <linux/module.h>
 #include <linux/platform_device.h>
+#include <linux/slab.h>
 
 #define BUTTONS_POLL_INTERVAL   30      /* msec */
 #define BUTTONS_COUNT_THRESHOLD 3
diff --git a/drivers/input/misc/dm355evm_keys.c b/drivers/input/misc/dm355evm_keys.c
index f2b67dc81d80..19af682c24fb 100644
--- a/drivers/input/misc/dm355evm_keys.c
+++ b/drivers/input/misc/dm355evm_keys.c
@@ -10,7 +10,9 @@
  */
 #include <linux/kernel.h>
 #include <linux/init.h>
+#include <linux/slab.h>
 #include <linux/input.h>
+#include <linux/input/sparse-keymap.h>
 #include <linux/platform_device.h>
 #include <linux/interrupt.h>
 
@@ -33,12 +35,8 @@ struct dm355evm_keys {
         int                     irq;
 };
 
-/* These initial keycodes can be remapped by dm355evm_setkeycode(). */
-static struct {
-        u16     event;
-        u16     keycode;
-} dm355evm_keys[] = {
-
+/* These initial keycodes can be remapped */
+static const struct key_entry dm355evm_keys[] = {
         /*
          * Pushbuttons on the EVM board ... note that the labels for these
          * are SW10/SW11/etc on the PC board.  The left/right orientation
@@ -47,11 +45,11 @@ static struct {
          * is to the right.  (That is, rotate the board counter-clockwise
          * by 90 degrees from the SW10/etc and "DM355 EVM" labels.)
          */
-        { 0x00d8, KEY_OK, },            /* SW12 */
-        { 0x00b8, KEY_UP, },            /* SW13 */
-        { 0x00e8, KEY_DOWN, },          /* SW11 */
-        { 0x0078, KEY_LEFT, },          /* SW14 */
-        { 0x00f0, KEY_RIGHT, },         /* SW10 */
+        { KE_KEY, 0x00d8, { KEY_OK } },         /* SW12 */
+        { KE_KEY, 0x00b8, { KEY_UP } },         /* SW13 */
+        { KE_KEY, 0x00e8, { KEY_DOWN } },       /* SW11 */
+        { KE_KEY, 0x0078, { KEY_LEFT } },       /* SW14 */
+        { KE_KEY, 0x00f0, { KEY_RIGHT } },      /* SW10 */
 
         /*
          * IR buttons ... codes assigned to match the universal remote
@@ -65,35 +63,35 @@ static struct {
          * RC5 codes are 14 bits, with two start bits (0x3 prefix)
          * and a toggle bit (masked out below).
          */
-        { 0x300c, KEY_POWER, },         /* NOTE: docs omit this */
-        { 0x3000, KEY_NUMERIC_0, },
-        { 0x3001, KEY_NUMERIC_1, },
-        { 0x3002, KEY_NUMERIC_2, },
-        { 0x3003, KEY_NUMERIC_3, },
-        { 0x3004, KEY_NUMERIC_4, },
-        { 0x3005, KEY_NUMERIC_5, },
-        { 0x3006, KEY_NUMERIC_6, },
-        { 0x3007, KEY_NUMERIC_7, },
-        { 0x3008, KEY_NUMERIC_8, },
-        { 0x3009, KEY_NUMERIC_9, },
-        { 0x3022, KEY_ENTER, },
-        { 0x30ec, KEY_MODE, },          /* "tv/vcr/..." */
-        { 0x300f, KEY_SELECT, },        /* "info" */
-        { 0x3020, KEY_CHANNELUP, },     /* "up" */
-        { 0x302e, KEY_MENU, },          /* "in/out" */
-        { 0x3011, KEY_VOLUMEDOWN, },    /* "left" */
-        { 0x300d, KEY_MUTE, },          /* "ok" */
-        { 0x3010, KEY_VOLUMEUP, },      /* "right" */
-        { 0x301e, KEY_SUBTITLE, },      /* "cc" */
-        { 0x3021, KEY_CHANNELDOWN, },   /* "down" */
-        { 0x3022, KEY_PREVIOUS, },
-        { 0x3026, KEY_SLEEP, },
-        { 0x3172, KEY_REWIND, },        /* NOTE: docs wrongly say 0x30ca */
-        { 0x3175, KEY_PLAY, },
-        { 0x3174, KEY_FASTFORWARD, },
-        { 0x3177, KEY_RECORD, },
-        { 0x3176, KEY_STOP, },
-        { 0x3169, KEY_PAUSE, },
+        { KE_KEY, 0x300c, { KEY_POWER } },      /* NOTE: docs omit this */
+        { KE_KEY, 0x3000, { KEY_NUMERIC_0 } },
+        { KE_KEY, 0x3001, { KEY_NUMERIC_1 } },
+        { KE_KEY, 0x3002, { KEY_NUMERIC_2 } },
+        { KE_KEY, 0x3003, { KEY_NUMERIC_3 } },
+        { KE_KEY, 0x3004, { KEY_NUMERIC_4 } },
+        { KE_KEY, 0x3005, { KEY_NUMERIC_5 } },
+        { KE_KEY, 0x3006, { KEY_NUMERIC_6 } },
+        { KE_KEY, 0x3007, { KEY_NUMERIC_7 } },
+        { KE_KEY, 0x3008, { KEY_NUMERIC_8 } },
+        { KE_KEY, 0x3009, { KEY_NUMERIC_9 } },
+        { KE_KEY, 0x3022, { KEY_ENTER } },
+        { KE_KEY, 0x30ec, { KEY_MODE } },       /* "tv/vcr/..." */
+        { KE_KEY, 0x300f, { KEY_SELECT } },     /* "info" */
+        { KE_KEY, 0x3020, { KEY_CHANNELUP } },  /* "up" */
+        { KE_KEY, 0x302e, { KEY_MENU } },       /* "in/out" */
+        { KE_KEY, 0x3011, { KEY_VOLUMEDOWN } }, /* "left" */
+        { KE_KEY, 0x300d, { KEY_MUTE } },       /* "ok" */
+        { KE_KEY, 0x3010, { KEY_VOLUMEUP } },   /* "right" */
+        { KE_KEY, 0x301e, { KEY_SUBTITLE } },   /* "cc" */
+        { KE_KEY, 0x3021, { KEY_CHANNELDOWN } },/* "down" */
+        { KE_KEY, 0x3022, { KEY_PREVIOUS } },
+        { KE_KEY, 0x3026, { KEY_SLEEP } },
+        { KE_KEY, 0x3172, { KEY_REWIND } },     /* NOTE: docs wrongly say 0x30ca */
+        { KE_KEY, 0x3175, { KEY_PLAY } },
+        { KE_KEY, 0x3174, { KEY_FASTFORWARD } },
+        { KE_KEY, 0x3177, { KEY_RECORD } },
+        { KE_KEY, 0x3176, { KEY_STOP } },
+        { KE_KEY, 0x3169, { KEY_PAUSE } },
 };
 
 /*
@@ -105,19 +103,18 @@ static struct {
  */
 static irqreturn_t dm355evm_keys_irq(int irq, void *_keys)
 {
-        struct dm355evm_keys    *keys = _keys;
-        int                     status;
+        static u16 last_event;
+        struct dm355evm_keys *keys = _keys;
+        const struct key_entry *ke;
+        unsigned int keycode;
+        int status;
+        u16 event;
 
         /* For simplicity we ignore INPUT_COUNT and just read
          * events until we get the "queue empty" indicator.
          * Reading INPUT_LOW decrements the count.
          */
         for (;;) {
-                static u16      last_event;
-                u16             event;
-                int             keycode;
-                int             i;
-
                 status = dm355evm_msp_read(DM355EVM_MSP_INPUT_HIGH);
                 if (status < 0) {
                         dev_dbg(keys->dev, "input high err %d\n",
@@ -156,14 +153,9 @@ static irqreturn_t dm355evm_keys_irq(int irq, void *_keys)
                 /* ignore the RC5 toggle bit */
                 event &= ~0x0800;
 
-                /* find the key, or leave it as unknown */
-                keycode = KEY_UNKNOWN;
-                for (i = 0; i < ARRAY_SIZE(dm355evm_keys); i++) {
-                        if (dm355evm_keys[i].event != event)
-                                continue;
-                        keycode = dm355evm_keys[i].keycode;
-                        break;
-                }
+                /* find the key, or report it as unknown */
+                ke = sparse_keymap_entry_from_scancode(keys->input, event);
+                keycode = ke ? ke->keycode : KEY_UNKNOWN;
                 dev_dbg(keys->dev,
                         "input event 0x%04x--> keycode %d\n",
                         event, keycode);
@@ -174,36 +166,8 @@ static irqreturn_t dm355evm_keys_irq(int irq, void *_keys)
                 input_report_key(keys->input, keycode, 0);
                 input_sync(keys->input);
         }
-        return IRQ_HANDLED;
-}
 
-static int dm355evm_setkeycode(struct input_dev *dev, int index, int keycode)
-{
-        u16             old_keycode;
-        unsigned        i;
-
-        if (((unsigned)index) >= ARRAY_SIZE(dm355evm_keys))
-                return -EINVAL;
-
-        old_keycode = dm355evm_keys[index].keycode;
-        dm355evm_keys[index].keycode = keycode;
-        set_bit(keycode, dev->keybit);
-
-        for (i = 0; i < ARRAY_SIZE(dm355evm_keys); i++) {
-                if (dm355evm_keys[index].keycode == old_keycode)
-                        goto done;
-        }
-        clear_bit(old_keycode, dev->keybit);
-done:
-        return 0;
-}
-
-static int dm355evm_getkeycode(struct input_dev *dev, int index, int *keycode)
-{
-        if (((unsigned)index) >= ARRAY_SIZE(dm355evm_keys))
-                return -EINVAL;
-
-        return dm355evm_keys[index].keycode;
+        return IRQ_HANDLED;
 }
 
 /*----------------------------------------------------------------------*/
@@ -213,7 +177,6 @@ static int __devinit dm355evm_keys_probe(struct platform_device *pdev)
         struct dm355evm_keys    *keys;
         struct input_dev        *input;
         int                     status;
-        int                     i;
 
         /* allocate instance struct and input dev */
         keys = kzalloc(sizeof *keys, GFP_KERNEL);
@@ -242,31 +205,30 @@ static int __devinit dm355evm_keys_probe(struct platform_device *pdev)
         input->id.product = 0x0355;
         input->id.version = dm355evm_msp_read(DM355EVM_MSP_FIRMREV);
 
-        input->evbit[0] = BIT(EV_KEY);
-        for (i = 0; i < ARRAY_SIZE(dm355evm_keys); i++)
-                __set_bit(dm355evm_keys[i].keycode, input->keybit);
-
-        input->setkeycode = dm355evm_setkeycode;
-        input->getkeycode = dm355evm_getkeycode;
+        status = sparse_keymap_setup(input, dm355evm_keys, NULL);
+        if (status)
+                goto fail1;
 
         /* REVISIT:  flush the event queue? */
 
         status = request_threaded_irq(keys->irq, NULL, dm355evm_keys_irq,
                         IRQF_TRIGGER_FALLING, dev_name(&pdev->dev), keys);
         if (status < 0)
-                goto fail1;
+                goto fail2;
 
         /* register */
         status = input_register_device(input);
         if (status < 0)
-                goto fail2;
+                goto fail3;
 
         platform_set_drvdata(pdev, keys);
 
         return 0;
 
-fail2:
+fail3:
         free_irq(keys->irq, keys);
+fail2:
+        sparse_keymap_free(input);
 fail1:
         input_free_device(input);
         kfree(keys);
@@ -280,6 +242,7 @@ static int __devexit dm355evm_keys_remove(struct platform_device *pdev)
         struct dm355evm_keys    *keys = platform_get_drvdata(pdev);
 
         free_irq(keys->irq, keys);
+        sparse_keymap_free(keys->input);
         input_unregister_device(keys->input);
         kfree(keys);
 
diff --git a/drivers/input/misc/hp_sdc_rtc.c b/drivers/input/misc/hp_sdc_rtc.c
index ea821b546969..ad730e15afc0 100644
--- a/drivers/input/misc/hp_sdc_rtc.c
+++ b/drivers/input/misc/hp_sdc_rtc.c
@@ -35,7 +35,6 @@
 
 #include <linux/hp_sdc.h>
 #include <linux/errno.h>
-#include <linux/smp_lock.h>
 #include <linux/types.h>
 #include <linux/init.h>
 #include <linux/module.h>
@@ -409,7 +408,6 @@ static unsigned int hp_sdc_rtc_poll(struct file *file, poll_table *wait)
 
 static int hp_sdc_rtc_open(struct inode *inode, struct file *file)
 {
-        cycle_kernel_lock();
         return 0;
 }
 
diff --git a/drivers/input/misc/pcap_keys.c b/drivers/input/misc/pcap_keys.c
index 7ea969347ca9..99335c286250 100644
--- a/drivers/input/misc/pcap_keys.c
+++ b/drivers/input/misc/pcap_keys.c
@@ -17,6 +17,7 @@
 #include <linux/platform_device.h>
 #include <linux/input.h>
 #include <linux/mfd/ezx-pcap.h>
+#include <linux/slab.h>
 
 struct pcap_keys {
         struct pcap_chip *pcap;
diff --git a/drivers/input/misc/pcf50633-input.c b/drivers/input/misc/pcf50633-input.c
index 039dcb00ebd9..95562735728d 100644
--- a/drivers/input/misc/pcf50633-input.c
+++ b/drivers/input/misc/pcf50633-input.c
@@ -20,6 +20,7 @@
 #include <linux/device.h>
 #include <linux/platform_device.h>
 #include <linux/input.h>
+#include <linux/slab.h>
 
 #include <linux/mfd/pcf50633/core.h>
 
@@ -55,7 +56,6 @@ pcf50633_input_irq(int irq, void *data)
 static int __devinit pcf50633_input_probe(struct platform_device *pdev)
 {
         struct pcf50633_input *input;
-        struct pcf50633_subdev_pdata *pdata = pdev->dev.platform_data;
         struct input_dev *input_dev;
         int ret;
 
@@ -71,7 +71,7 @@ static int __devinit pcf50633_input_probe(struct platform_device *pdev)
         }
 
         platform_set_drvdata(pdev, input);
-        input->pcf = pdata->pcf;
+        input->pcf = dev_to_pcf50633(pdev->dev.parent);
         input->input_dev = input_dev;
 
         input_dev->name = "PCF50633 PMU events";
@@ -85,9 +85,9 @@ static int __devinit pcf50633_input_probe(struct platform_device *pdev)
                 kfree(input);
                 return ret;
         }
-        pcf50633_register_irq(pdata->pcf, PCF50633_IRQ_ONKEYR,
+        pcf50633_register_irq(input->pcf, PCF50633_IRQ_ONKEYR,
                                 pcf50633_input_irq, input);
-        pcf50633_register_irq(pdata->pcf, PCF50633_IRQ_ONKEYF,
+        pcf50633_register_irq(input->pcf, PCF50633_IRQ_ONKEYF,
                                 pcf50633_input_irq, input);
 
         return 0;
diff --git a/drivers/input/misc/pcspkr.c b/drivers/input/misc/pcspkr.c
index 21cb755a54fb..ea4e1fd12651 100644
--- a/drivers/input/misc/pcspkr.c
+++ b/drivers/input/misc/pcspkr.c
@@ -127,7 +127,7 @@ static void pcspkr_shutdown(struct platform_device *dev)
         pcspkr_event(NULL, EV_SND, SND_BELL, 0);
 }
 
-static struct dev_pm_ops pcspkr_pm_ops = {
+static const struct dev_pm_ops pcspkr_pm_ops = {
         .suspend = pcspkr_suspend,
 };
 
diff --git a/drivers/input/misc/powermate.c b/drivers/input/misc/powermate.c
index a53c4885fbad..668913d12044 100644
--- a/drivers/input/misc/powermate.c
+++ b/drivers/input/misc/powermate.c
@@ -338,7 +338,7 @@ static int powermate_probe(struct usb_interface *intf, const struct usb_device_i
         pm->input = input_dev;
 
         usb_make_path(udev, pm->phys, sizeof(pm->phys));
-        strlcpy(pm->phys, "/input0", sizeof(pm->phys));
+        strlcat(pm->phys, "/input0", sizeof(pm->phys));
 
         spin_lock_init(&pm->lock);
 
diff --git a/drivers/input/misc/rotary_encoder.c b/drivers/input/misc/rotary_encoder.c
index 3b9f588fc747..1f8e0108962e 100644
--- a/drivers/input/misc/rotary_encoder.c
+++ b/drivers/input/misc/rotary_encoder.c
@@ -22,6 +22,7 @@
 #include <linux/platform_device.h>
 #include <linux/gpio.h>
 #include <linux/rotary_encoder.h>
+#include <linux/slab.h>
 
 #define DRV_NAME "rotary-encoder"
 
@@ -152,6 +153,13 @@ static int __devinit rotary_encoder_probe(struct platform_device *pdev)
                 goto exit_unregister_input;
         }
 
+        err = gpio_direction_input(pdata->gpio_a);
+        if (err) {
+                dev_err(&pdev->dev, "unable to set GPIO %d for input\n",
+                        pdata->gpio_a);
+                goto exit_unregister_input;
+        }
+
         err = gpio_request(pdata->gpio_b, DRV_NAME);
         if (err) {
                 dev_err(&pdev->dev, "unable to request GPIO %d\n",
@@ -159,6 +167,13 @@ static int __devinit rotary_encoder_probe(struct platform_device *pdev)
                 goto exit_free_gpio_a;
         }
 
+        err = gpio_direction_input(pdata->gpio_b);
+        if (err) {
+                dev_err(&pdev->dev, "unable to set GPIO %d for input\n",
+                        pdata->gpio_b);
+                goto exit_free_gpio_a;
+        }
+
         /* request the IRQs */
         err = request_irq(encoder->irq_a, &rotary_encoder_irq,
                           IORESOURCE_IRQ_HIGHEDGE | IORESOURCE_IRQ_LOWEDGE,
diff --git a/drivers/input/misc/sgi_btns.c b/drivers/input/misc/sgi_btns.c
index be3a15f5b25d..1a80c0dab83b 100644
--- a/drivers/input/misc/sgi_btns.c
+++ b/drivers/input/misc/sgi_btns.c
@@ -22,6 +22,7 @@
 #include <linux/ioport.h>
 #include <linux/module.h>
 #include <linux/platform_device.h>
+#include <linux/slab.h>
 
 #ifdef CONFIG_SGI_IP22
 #include <asm/sgi/ioc.h>
diff --git a/drivers/input/misc/sparcspkr.c b/drivers/input/misc/sparcspkr.c
index b064419b90a2..0d45422f8095 100644
--- a/drivers/input/misc/sparcspkr.c
+++ b/drivers/input/misc/sparcspkr.c
@@ -9,6 +9,7 @@
 #include <linux/init.h>
 #include <linux/input.h>
 #include <linux/of_device.h>
+#include <linux/slab.h>
 
 #include <asm/io.h>
 
diff --git a/drivers/input/misc/twl4030-pwrbutton.c b/drivers/input/misc/twl4030-pwrbutton.c
index f5fc9974a111..e9069b87fde2 100644
--- a/drivers/input/misc/twl4030-pwrbutton.c
+++ b/drivers/input/misc/twl4030-pwrbutton.c
@@ -27,7 +27,7 @@
 #include <linux/input.h>
 #include <linux/interrupt.h>
 #include <linux/platform_device.h>
-#include <linux/i2c/twl4030.h>
+#include <linux/i2c/twl.h>
 
 #define PWR_PWRON_IRQ (1 << 0)
 
@@ -39,18 +39,8 @@ static irqreturn_t powerbutton_irq(int irq, void *_pwr)
         int err;
         u8 value;
 
-#ifdef CONFIG_LOCKDEP
-        /* WORKAROUND for lockdep forcing IRQF_DISABLED on us, which
-         * we don't want and can't tolerate since this is a threaded
-         * IRQ and can sleep due to the i2c reads it has to issue.
-         * Although it might be friendlier not to borrow this thread
-         * context...
-         */
-        local_irq_enable();
-#endif
-
-        err = twl4030_i2c_read_u8(TWL4030_MODULE_PM_MASTER, &value,
-                                  STS_HW_CONDITIONS);
+        err = twl_i2c_read_u8(TWL4030_MODULE_PM_MASTER, &value,
+                                STS_HW_CONDITIONS);
         if (!err)  {
                 input_report_key(pwr, KEY_POWER, value & PWR_PWRON_IRQ);
                 input_sync(pwr);
@@ -80,7 +70,7 @@ static int __devinit twl4030_pwrbutton_probe(struct platform_device *pdev)
         pwr->phys = "twl4030_pwrbutton/input0";
         pwr->dev.parent = &pdev->dev;
 
-        err = request_irq(irq, powerbutton_irq,
+        err = request_threaded_irq(irq, NULL, powerbutton_irq,
                         IRQF_TRIGGER_FALLING | IRQF_TRIGGER_RISING,
                         "twl4030_pwrbutton", pwr);
         if (err < 0) {
diff --git a/drivers/input/misc/twl4030-vibra.c b/drivers/input/misc/twl4030-vibra.c
new file mode 100644
index 000000000000..fee9eac8e04a
--- /dev/null
+++ b/drivers/input/misc/twl4030-vibra.c
@@ -0,0 +1,298 @@
+/*
+ * twl4030-vibra.c - TWL4030 Vibrator driver
+ *
+ * Copyright (C) 2008-2010 Nokia Corporation
+ *
+ * Written by Henrik Saari <henrik.saari@nokia.com>
+ * Updates by Felipe Balbi <felipe.balbi@nokia.com>
+ * Input by Jari Vanhala <ext-jari.vanhala@nokia.com>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful, but
+ * WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA
+ * 02110-1301 USA
+ *
+ */
+
+#include <linux/module.h>
+#include <linux/jiffies.h>
+#include <linux/platform_device.h>
+#include <linux/workqueue.h>
+#include <linux/i2c/twl.h>
+#include <linux/mfd/twl4030-codec.h>
+#include <linux/input.h>
+#include <linux/slab.h>
+
+/* MODULE ID2 */
+#define LEDEN           0x00
+
+/* ForceFeedback */
+#define EFFECT_DIR_180_DEG      0x8000 /* range is 0 - 0xFFFF */
+
+struct vibra_info {
+        struct device           *dev;
+        struct input_dev        *input_dev;
+
+        struct workqueue_struct *workqueue;
+        struct work_struct      play_work;
+
+        bool                    enabled;
+        int                     speed;
+        int                     direction;
+
+        bool                    coexist;
+};
+
+static void vibra_disable_leds(void)
+{
+        u8 reg;
+
+        /* Disable LEDA & LEDB, cannot be used with vibra (PWM) */
+        twl_i2c_read_u8(TWL4030_MODULE_LED, &reg, LEDEN);
+        reg &= ~0x03;
+        twl_i2c_write_u8(TWL4030_MODULE_LED, LEDEN, reg);
+}
+
+/* Powers H-Bridge and enables audio clk */
+static void vibra_enable(struct vibra_info *info)
+{
+        u8 reg;
+
+        twl4030_codec_enable_resource(TWL4030_CODEC_RES_POWER);
+
+        /* turn H-Bridge on */
+        twl_i2c_read_u8(TWL4030_MODULE_AUDIO_VOICE,
+                        &reg, TWL4030_REG_VIBRA_CTL);
+        twl_i2c_write_u8(TWL4030_MODULE_AUDIO_VOICE,
+                         (reg | TWL4030_VIBRA_EN), TWL4030_REG_VIBRA_CTL);
+
+        twl4030_codec_enable_resource(TWL4030_CODEC_RES_APLL);
+
+        info->enabled = true;
+}
+
+static void vibra_disable(struct vibra_info *info)
+{
+        u8 reg;
+
+        /* Power down H-Bridge */
+        twl_i2c_read_u8(TWL4030_MODULE_AUDIO_VOICE,
+                        &reg, TWL4030_REG_VIBRA_CTL);
+        twl_i2c_write_u8(TWL4030_MODULE_AUDIO_VOICE,
+                         (reg & ~TWL4030_VIBRA_EN), TWL4030_REG_VIBRA_CTL);
+
+        twl4030_codec_disable_resource(TWL4030_CODEC_RES_POWER);
+        twl4030_codec_disable_resource(TWL4030_CODEC_RES_APLL);
+
+        info->enabled = false;
+}
+
+static void vibra_play_work(struct work_struct *work)
+{
+        struct vibra_info *info = container_of(work,
+                        struct vibra_info, play_work);
+        int dir;
+        int pwm;
+        u8 reg;
+
+        dir = info->direction;
+        pwm = info->speed;
+
+        twl_i2c_read_u8(TWL4030_MODULE_AUDIO_VOICE,
+                        &reg, TWL4030_REG_VIBRA_CTL);
+        if (pwm && (!info->coexist || !(reg & TWL4030_VIBRA_SEL))) {
+
+                if (!info->enabled)
+                        vibra_enable(info);
+
+                /* set vibra rotation direction */
+                twl_i2c_read_u8(TWL4030_MODULE_AUDIO_VOICE,
+                                &reg, TWL4030_REG_VIBRA_CTL);
+                reg = (dir) ? (reg | TWL4030_VIBRA_DIR) :
+                        (reg & ~TWL4030_VIBRA_DIR);
+                twl_i2c_write_u8(TWL4030_MODULE_AUDIO_VOICE,
+                                 reg, TWL4030_REG_VIBRA_CTL);
+
+                /* set PWM, 1 = max, 255 = min */
+                twl_i2c_write_u8(TWL4030_MODULE_AUDIO_VOICE,
+                                 256 - pwm, TWL4030_REG_VIBRA_SET);
+        } else {
+                if (info->enabled)
+                        vibra_disable(info);
+        }
+}
+
+/*** Input/ForceFeedback ***/
+
+static int vibra_play(struct input_dev *input, void *data,
+                      struct ff_effect *effect)
+{
+        struct vibra_info *info = input_get_drvdata(input);
+
+        info->speed = effect->u.rumble.strong_magnitude >> 8;
+        if (!info->speed)
+                info->speed = effect->u.rumble.weak_magnitude >> 9;
+        info->direction = effect->direction < EFFECT_DIR_180_DEG ? 0 : 1;
+        queue_work(info->workqueue, &info->play_work);
+        return 0;
+}
+
+static int twl4030_vibra_open(struct input_dev *input)
+{
+        struct vibra_info *info = input_get_drvdata(input);
+
+        info->workqueue = create_singlethread_workqueue("vibra");
+        if (info->workqueue == NULL) {
+                dev_err(&input->dev, "couldn't create workqueue\n");
+                return -ENOMEM;
+        }
+        return 0;
+}
+
+static void twl4030_vibra_close(struct input_dev *input)
+{
+        struct vibra_info *info = input_get_drvdata(input);
+
+        cancel_work_sync(&info->play_work);
+        INIT_WORK(&info->play_work, vibra_play_work); /* cleanup */
+        destroy_workqueue(info->workqueue);
+        info->workqueue = NULL;
+
+        if (info->enabled)
+                vibra_disable(info);
+}
+
+/*** Module ***/
+#if CONFIG_PM
+static int twl4030_vibra_suspend(struct device *dev)
+{
+        struct platform_device *pdev = to_platform_device(dev);
+        struct vibra_info *info = platform_get_drvdata(pdev);
+
+        if (info->enabled)
+                vibra_disable(info);
+
+        return 0;
+}
+
+static int twl4030_vibra_resume(struct device *dev)
+{
+        vibra_disable_leds();
+        return 0;
+}
+
+static SIMPLE_DEV_PM_OPS(twl4030_vibra_pm_ops,
+                         twl4030_vibra_suspend, twl4030_vibra_resume);
+#endif
+
+static int __devinit twl4030_vibra_probe(struct platform_device *pdev)
+{
+        struct twl4030_codec_vibra_data *pdata = pdev->dev.platform_data;
+        struct vibra_info *info;
+        int ret;
+
+        if (!pdata) {
+                dev_dbg(&pdev->dev, "platform_data not available\n");
+                return -EINVAL;
+        }
+
+        info = kzalloc(sizeof(*info), GFP_KERNEL);
+        if (!info)
+                return -ENOMEM;
+
+        info->dev = &pdev->dev;
+        info->coexist = pdata->coexist;
+        INIT_WORK(&info->play_work, vibra_play_work);
+
+        info->input_dev = input_allocate_device();
+        if (info->input_dev == NULL) {
+                dev_err(&pdev->dev, "couldn't allocate input device\n");
+                ret = -ENOMEM;
+                goto err_kzalloc;
+        }
+
+        input_set_drvdata(info->input_dev, info);
+
+        info->input_dev->name = "twl4030:vibrator";
+        info->input_dev->id.version = 1;
+        info->input_dev->dev.parent = pdev->dev.parent;
+        info->input_dev->open = twl4030_vibra_open;
+        info->input_dev->close = twl4030_vibra_close;
+        __set_bit(FF_RUMBLE, info->input_dev->ffbit);
+
+        ret = input_ff_create_memless(info->input_dev, NULL, vibra_play);
+        if (ret < 0) {
+                dev_dbg(&pdev->dev, "couldn't register vibrator to FF\n");
+                goto err_ialloc;
+        }
+
+        ret = input_register_device(info->input_dev);
+        if (ret < 0) {
+                dev_dbg(&pdev->dev, "couldn't register input device\n");
+                goto err_iff;
+        }
+
+        vibra_disable_leds();
+
+        platform_set_drvdata(pdev, info);
+        return 0;
+
+err_iff:
+        input_ff_destroy(info->input_dev);
+err_ialloc:
+        input_free_device(info->input_dev);
+err_kzalloc:
+        kfree(info);
+        return ret;
+}
+
+static int __devexit twl4030_vibra_remove(struct platform_device *pdev)
+{
+        struct vibra_info *info = platform_get_drvdata(pdev);
+
+        /* this also free ff-memless and calls close if needed */
+        input_unregister_device(info->input_dev);
+        kfree(info);
+        platform_set_drvdata(pdev, NULL);
+
+        return 0;
+}
+
+static struct platform_driver twl4030_vibra_driver = {
+        .probe          = twl4030_vibra_probe,
+        .remove         = __devexit_p(twl4030_vibra_remove),
+        .driver         = {
+                .name   = "twl4030_codec_vibra",
+                .owner  = THIS_MODULE,
+#ifdef CONFIG_PM
+                .pm     = &twl4030_vibra_pm_ops,
+#endif
+        },
+};
+
+static int __init twl4030_vibra_init(void)
+{
+        return platform_driver_register(&twl4030_vibra_driver);
+}
+module_init(twl4030_vibra_init);
+
+static void __exit twl4030_vibra_exit(void)
+{
+        platform_driver_unregister(&twl4030_vibra_driver);
+}
+module_exit(twl4030_vibra_exit);
+
+MODULE_ALIAS("platform:twl4030_codec_vibra");
+
+MODULE_DESCRIPTION("TWL4030 Vibra driver");
+MODULE_LICENSE("GPL");
+MODULE_AUTHOR("Nokia Corporation");
diff --git a/drivers/input/misc/uinput.c b/drivers/input/misc/uinput.c
index d3f57245420a..1477466076ad 100644
--- a/drivers/input/misc/uinput.c
+++ b/drivers/input/misc/uinput.c
@@ -34,7 +34,6 @@
 #include <linux/slab.h>
 #include <linux/module.h>
 #include <linux/init.h>
-#include <linux/smp_lock.h>
 #include <linux/fs.h>
 #include <linux/miscdevice.h>
 #include <linux/uinput.h>
@@ -284,7 +283,6 @@ static int uinput_open(struct inode *inode, struct file *file)
         if (!newdev)
                 return -ENOMEM;
 
-        lock_kernel();
         mutex_init(&newdev->mutex);
         spin_lock_init(&newdev->requests_lock);
         init_waitqueue_head(&newdev->requests_waitq);
@@ -292,7 +290,7 @@ static int uinput_open(struct inode *inode, struct file *file)
         newdev->state = UIST_NEW_DEVICE;
 
         file->private_data = newdev;
-        unlock_kernel();
+        nonseekable_open(inode, file);
 
         return 0;
 }
diff --git a/drivers/input/misc/winbond-cir.c b/drivers/input/misc/winbond-cir.c
index 33309fe44e20..64f1de7960c6 100644
--- a/drivers/input/misc/winbond-cir.c
+++ b/drivers/input/misc/winbond-cir.c
@@ -56,6 +56,7 @@
 #include <linux/io.h>
 #include <linux/bitrev.h>
 #include <linux/bitops.h>
+#include <linux/slab.h>
 
 #define DRVNAME "winbond-cir"
 
@@ -385,26 +386,24 @@ wbcir_do_getkeycode(struct wbcir_data *data, u32 scancode)
 }
 
 static int
-wbcir_getkeycode(struct input_dev *dev, int scancode, int *keycode)
+wbcir_getkeycode(struct input_dev *dev,
+                 unsigned int scancode, unsigned int *keycode)
 {
         struct wbcir_data *data = input_get_drvdata(dev);
 
-        *keycode = (int)wbcir_do_getkeycode(data, (u32)scancode);
+        *keycode = wbcir_do_getkeycode(data, scancode);
         return 0;
 }
 
 static int
-wbcir_setkeycode(struct input_dev *dev, int sscancode, int keycode)
+wbcir_setkeycode(struct input_dev *dev,
+                 unsigned int scancode, unsigned int keycode)
 {
         struct wbcir_data *data = input_get_drvdata(dev);
         struct wbcir_keyentry *keyentry;
         struct wbcir_keyentry *new_keyentry;
         unsigned long flags;
         unsigned int old_keycode = KEY_RESERVED;
-        u32 scancode = (u32)sscancode;
-
-        if (keycode < 0 || keycode > KEY_MAX)
-                return -EINVAL;
 
         new_keyentry = kmalloc(sizeof(*new_keyentry), GFP_KERNEL);
         if (!new_keyentry)
@@ -538,6 +537,7 @@ wbcir_reset_irdata(struct wbcir_data *data)
         data->irdata_count = 0;
         data->irdata_off = 0;
         data->irdata_error = 0;
+        data->idle_count = 0;
 }
 
 /* Adds one bit of irdata */
@@ -768,7 +768,7 @@ wbcir_parse_rc6(struct device *dev, struct wbcir_data *data)
                 return;
         }
 
-        dev_info(dev, "IR-RC6 ad 0x%02X cm 0x%02X cu 0x%04X "
+        dev_dbg(dev, "IR-RC6 ad 0x%02X cm 0x%02X cu 0x%04X "
                 "toggle %u mode %u scan 0x%08X\n",
                 address,
                 command,
@@ -1006,7 +1006,6 @@ wbcir_irq_handler(int irqno, void *cookie)
                 }
 
                 wbcir_reset_irdata(data);
-                data->idle_count = 0;
         }
 
 out:
@@ -1018,7 +1017,7 @@ out:
 
 /*****************************************************************************
  *
- * SUSPEND/RESUME FUNCTIONS
+ * SETUP/INIT/SUSPEND/RESUME FUNCTIONS
  *
  *****************************************************************************/
 
@@ -1197,7 +1196,16 @@ finish:
         }
 
         /* Disable interrupts */
+        wbcir_select_bank(data, WBCIR_BANK_0);
         outb(WBCIR_IRQ_NONE, data->sbase + WBCIR_REG_SP3_IER);
+
+        /*
+         * ACPI will set the HW disable bit for SP3 which means that the
+         * output signals are left in an undefined state which may cause
+         * spurious interrupts which we need to ignore until the hardware
+         * is reinitialized.
+         */
+        disable_irq(data->irq);
 }
 
 static int
@@ -1207,37 +1215,15 @@ wbcir_suspend(struct pnp_dev *device, pm_message_t state)
         return 0;
 }
 
-static int
-wbcir_resume(struct pnp_dev *device)
-{
-        struct wbcir_data *data = pnp_get_drvdata(device);
-
-        /* Clear BUFF_EN, Clear END_EN, Clear MATCH_EN */
-        wbcir_set_bits(data->wbase + WBCIR_REG_WCEIR_EV_EN, 0x00, 0x07);
-
-        /* Clear CEIR_EN */
-        wbcir_set_bits(data->wbase + WBCIR_REG_WCEIR_CTL, 0x00, 0x01);
-
-        /* Enable interrupts */
-        wbcir_reset_irdata(data);
-        outb(WBCIR_IRQ_RX | WBCIR_IRQ_ERR, data->sbase + WBCIR_REG_SP3_IER);
-
-        return 0;
-}
-
-
-
-/*****************************************************************************
- *
- * SETUP/INIT FUNCTIONS
- *
- *****************************************************************************/
-
 static void
-wbcir_cfg_ceir(struct wbcir_data *data)
+wbcir_init_hw(struct wbcir_data *data)
 {
         u8 tmp;
 
+        /* Disable interrupts */
+        wbcir_select_bank(data, WBCIR_BANK_0);
+        outb(WBCIR_IRQ_NONE, data->sbase + WBCIR_REG_SP3_IER);
+
         /* Set PROT_SEL, RX_INV, Clear CEIR_EN (needed for the led) */
         tmp = protocol << 4;
         if (invert)
@@ -1264,6 +1250,93 @@ wbcir_cfg_ceir(struct wbcir_data *data)
          * set SP3_IRRX_SW to binary 01, helpfully not documented
          */
         outb(0x10, data->ebase + WBCIR_REG_ECEIR_CTS);
+
+        /* Enable extended mode */
+        wbcir_select_bank(data, WBCIR_BANK_2);
+        outb(WBCIR_EXT_ENABLE, data->sbase + WBCIR_REG_SP3_EXCR1);
+
+        /*
+         * Configure baud generator, IR data will be sampled at
+         * a bitrate of: (24Mhz * prescaler) / (divisor * 16).
+         *
+         * The ECIR registers include a flag to change the
+         * 24Mhz clock freq to 48Mhz.
+         *
+         * It's not documented in the specs, but fifo levels
+         * other than 16 seems to be unsupported.
+         */
+
+        /* prescaler 1.0, tx/rx fifo lvl 16 */
+        outb(0x30, data->sbase + WBCIR_REG_SP3_EXCR2);
+
+        /* Set baud divisor to generate one byte per bit/cell */
+        switch (protocol) {
+        case IR_PROTOCOL_RC5:
+                outb(0xA7, data->sbase + WBCIR_REG_SP3_BGDL);
+                break;
+        case IR_PROTOCOL_RC6:
+                outb(0x53, data->sbase + WBCIR_REG_SP3_BGDL);
+                break;
+        case IR_PROTOCOL_NEC:
+                outb(0x69, data->sbase + WBCIR_REG_SP3_BGDL);
+                break;
+        }
+        outb(0x00, data->sbase + WBCIR_REG_SP3_BGDH);
+
+        /* Set CEIR mode */
+        wbcir_select_bank(data, WBCIR_BANK_0);
+        outb(0xC0, data->sbase + WBCIR_REG_SP3_MCR);
+        inb(data->sbase + WBCIR_REG_SP3_LSR); /* Clear LSR */
+        inb(data->sbase + WBCIR_REG_SP3_MSR); /* Clear MSR */
+
+        /* Disable RX demod, run-length encoding/decoding, set freq span */
+        wbcir_select_bank(data, WBCIR_BANK_7);
+        outb(0x10, data->sbase + WBCIR_REG_SP3_RCCFG);
+
+        /* Disable timer */
+        wbcir_select_bank(data, WBCIR_BANK_4);
+        outb(0x00, data->sbase + WBCIR_REG_SP3_IRCR1);
+
+        /* Enable MSR interrupt, Clear AUX_IRX */
+        wbcir_select_bank(data, WBCIR_BANK_5);
+        outb(0x00, data->sbase + WBCIR_REG_SP3_IRCR2);
+
+        /* Disable CRC */
+        wbcir_select_bank(data, WBCIR_BANK_6);
+        outb(0x20, data->sbase + WBCIR_REG_SP3_IRCR3);
+
+        /* Set RX/TX (de)modulation freq, not really used */
+        wbcir_select_bank(data, WBCIR_BANK_7);
+        outb(0xF2, data->sbase + WBCIR_REG_SP3_IRRXDC);
+        outb(0x69, data->sbase + WBCIR_REG_SP3_IRTXMC);
+
+        /* Set invert and pin direction */
+        if (invert)
+                outb(0x10, data->sbase + WBCIR_REG_SP3_IRCFG4);
+        else
+                outb(0x00, data->sbase + WBCIR_REG_SP3_IRCFG4);
+
+        /* Set FIFO thresholds (RX = 8, TX = 3), reset RX/TX */
+        wbcir_select_bank(data, WBCIR_BANK_0);
+        outb(0x97, data->sbase + WBCIR_REG_SP3_FCR);
+
+        /* Clear AUX status bits */
+        outb(0xE0, data->sbase + WBCIR_REG_SP3_ASCR);
+
+        /* Enable interrupts */
+        wbcir_reset_irdata(data);
+        outb(WBCIR_IRQ_RX | WBCIR_IRQ_ERR, data->sbase + WBCIR_REG_SP3_IER);
+}
+
+static int
+wbcir_resume(struct pnp_dev *device)
+{
+        struct wbcir_data *data = pnp_get_drvdata(device);
+
+        wbcir_init_hw(data);
+        enable_irq(data->irq);
+
+        return 0;
 }
 
 static int __devinit
@@ -1393,86 +1466,7 @@ wbcir_probe(struct pnp_dev *device, const struct pnp_device_id *dev_id)
 
         device_init_wakeup(&device->dev, 1);
 
-        wbcir_cfg_ceir(data);
-
-        /* Disable interrupts */
-        wbcir_select_bank(data, WBCIR_BANK_0);
-        outb(WBCIR_IRQ_NONE, data->sbase + WBCIR_REG_SP3_IER);
-
-        /* Enable extended mode */
-        wbcir_select_bank(data, WBCIR_BANK_2);
-        outb(WBCIR_EXT_ENABLE, data->sbase + WBCIR_REG_SP3_EXCR1);
-
-        /*
-         * Configure baud generator, IR data will be sampled at
-         * a bitrate of: (24Mhz * prescaler) / (divisor * 16).
-         *
-         * The ECIR registers include a flag to change the
-         * 24Mhz clock freq to 48Mhz.
-         *
-         * It's not documented in the specs, but fifo levels
-         * other than 16 seems to be unsupported.
-         */
-
-        /* prescaler 1.0, tx/rx fifo lvl 16 */
-        outb(0x30, data->sbase + WBCIR_REG_SP3_EXCR2);
-
-        /* Set baud divisor to generate one byte per bit/cell */
-        switch (protocol) {
-        case IR_PROTOCOL_RC5:
-                outb(0xA7, data->sbase + WBCIR_REG_SP3_BGDL);
-                break;
-        case IR_PROTOCOL_RC6:
-                outb(0x53, data->sbase + WBCIR_REG_SP3_BGDL);
-                break;
-        case IR_PROTOCOL_NEC:
-                outb(0x69, data->sbase + WBCIR_REG_SP3_BGDL);
-                break;
-        }
-        outb(0x00, data->sbase + WBCIR_REG_SP3_BGDH);
-
-        /* Set CEIR mode */
-        wbcir_select_bank(data, WBCIR_BANK_0);
-        outb(0xC0, data->sbase + WBCIR_REG_SP3_MCR);
-        inb(data->sbase + WBCIR_REG_SP3_LSR); /* Clear LSR */
-        inb(data->sbase + WBCIR_REG_SP3_MSR); /* Clear MSR */
-
-        /* Disable RX demod, run-length encoding/decoding, set freq span */
-        wbcir_select_bank(data, WBCIR_BANK_7);
-        outb(0x10, data->sbase + WBCIR_REG_SP3_RCCFG);
-
-        /* Disable timer */
-        wbcir_select_bank(data, WBCIR_BANK_4);
-        outb(0x00, data->sbase + WBCIR_REG_SP3_IRCR1);
-
-        /* Enable MSR interrupt, Clear AUX_IRX */
-        wbcir_select_bank(data, WBCIR_BANK_5);
-        outb(0x00, data->sbase + WBCIR_REG_SP3_IRCR2);
-
-        /* Disable CRC */
-        wbcir_select_bank(data, WBCIR_BANK_6);
-        outb(0x20, data->sbase + WBCIR_REG_SP3_IRCR3);
-
-        /* Set RX/TX (de)modulation freq, not really used */
-        wbcir_select_bank(data, WBCIR_BANK_7);
-        outb(0xF2, data->sbase + WBCIR_REG_SP3_IRRXDC);
-        outb(0x69, data->sbase + WBCIR_REG_SP3_IRTXMC);
-
-        /* Set invert and pin direction */
-        if (invert)
-                outb(0x10, data->sbase + WBCIR_REG_SP3_IRCFG4);
-        else
-                outb(0x00, data->sbase + WBCIR_REG_SP3_IRCFG4);
-
-        /* Set FIFO thresholds (RX = 8, TX = 3), reset RX/TX */
-        wbcir_select_bank(data, WBCIR_BANK_0);
-        outb(0x97, data->sbase + WBCIR_REG_SP3_FCR);
-
-        /* Clear AUX status bits */
-        outb(0xE0, data->sbase + WBCIR_REG_SP3_ASCR);
-
-        /* Enable interrupts */
-        outb(WBCIR_IRQ_RX | WBCIR_IRQ_ERR, data->sbase + WBCIR_REG_SP3_IER);
+        wbcir_init_hw(data);
 
         return 0;
 
diff --git a/drivers/input/misc/wistron_btns.c b/drivers/input/misc/wistron_btns.c
index a932179c4c9e..04d5a4a3181f 100644
--- a/drivers/input/misc/wistron_btns.c
+++ b/drivers/input/misc/wistron_btns.c
@@ -21,6 +21,7 @@
 #include <linux/dmi.h>
 #include <linux/init.h>
 #include <linux/input-polldev.h>
+#include <linux/input/sparse-keymap.h>
 #include <linux/interrupt.h>
 #include <linux/jiffies.h>
 #include <linux/kernel.h>
@@ -28,6 +29,7 @@
 #include <linux/module.h>
 #include <linux/preempt.h>
 #include <linux/string.h>
+#include <linux/slab.h>
 #include <linux/types.h>
 #include <linux/platform_device.h>
 #include <linux/leds.h>
@@ -224,19 +226,8 @@ static void bios_set_state(u8 subsys, int enable)
 
 /* Hardware database */
 
-struct key_entry {
-        char type;              /* See KE_* below */
-        u8 code;
-        union {
-                u16 keycode;            /* For KE_KEY */
-                struct {                /* For KE_SW */
-                        u8 code;
-                        u8 value;
-                } sw;
-        };
-};
-
-enum { KE_END, KE_KEY, KE_SW, KE_WIFI, KE_BLUETOOTH };
+#define KE_WIFI         (KE_LAST + 1)
+#define KE_BLUETOOTH    (KE_LAST + 2)
 
 #define FE_MAIL_LED 0x01
 #define FE_WIFI_LED 0x02
@@ -644,10 +635,10 @@ static struct key_entry keymap_prestigio[] __initdata = {
  * a list of buttons and their key codes (reported when loading this module
  * with force=1) and the output of dmidecode to $MODULE_AUTHOR.
  */
-static struct dmi_system_id dmi_ids[] __initdata = {
+static const struct dmi_system_id __initconst dmi_ids[] = {
         {
+                /* Fujitsu-Siemens Amilo Pro V2000 */
                 .callback = dmi_matched,
-                .ident = "Fujitsu-Siemens Amilo Pro V2000",
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "FUJITSU SIEMENS"),
                         DMI_MATCH(DMI_PRODUCT_NAME, "AMILO Pro V2000"),
@@ -655,8 +646,8 @@ static struct dmi_system_id dmi_ids[] __initdata = {
                 .driver_data = keymap_fs_amilo_pro_v2000
         },
         {
+                /* Fujitsu-Siemens Amilo Pro Edition V3505 */
                 .callback = dmi_matched,
-                .ident = "Fujitsu-Siemens Amilo Pro Edition V3505",
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "FUJITSU SIEMENS"),
                         DMI_MATCH(DMI_PRODUCT_NAME, "AMILO Pro Edition V3505"),
@@ -664,8 +655,8 @@ static struct dmi_system_id dmi_ids[] __initdata = {
                 .driver_data = keymap_fs_amilo_pro_v3505
         },
         {
+                /* Fujitsu-Siemens Amilo M7400 */
                 .callback = dmi_matched,
-                .ident = "Fujitsu-Siemens Amilo M7400",
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "FUJITSU SIEMENS"),
                         DMI_MATCH(DMI_PRODUCT_NAME, "AMILO M        "),
@@ -673,8 +664,8 @@ static struct dmi_system_id dmi_ids[] __initdata = {
                 .driver_data = keymap_fs_amilo_pro_v2000
         },
         {
+                /* Maxdata Pro 7000 DX */
                 .callback = dmi_matched,
-                .ident = "Maxdata Pro 7000 DX",
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "MAXDATA"),
                         DMI_MATCH(DMI_PRODUCT_NAME, "Pro 7000"),
@@ -682,8 +673,8 @@ static struct dmi_system_id dmi_ids[] __initdata = {
                 .driver_data = keymap_fs_amilo_pro_v2000
         },
         {
+                /* Fujitsu N3510 */
                 .callback = dmi_matched,
-                .ident = "Fujitsu N3510",
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "FUJITSU"),
                         DMI_MATCH(DMI_PRODUCT_NAME, "N3510"),
@@ -691,8 +682,8 @@ static struct dmi_system_id dmi_ids[] __initdata = {
                 .driver_data = keymap_fujitsu_n3510
         },
         {
+                /* Acer Aspire 1500 */
                 .callback = dmi_matched,
-                .ident = "Acer Aspire 1500",
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "Acer"),
                         DMI_MATCH(DMI_PRODUCT_NAME, "Aspire 1500"),
@@ -700,8 +691,8 @@ static struct dmi_system_id dmi_ids[] __initdata = {
                 .driver_data = keymap_acer_aspire_1500
         },
         {
+                /* Acer Aspire 1600 */
                 .callback = dmi_matched,
-                .ident = "Acer Aspire 1600",
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "Acer"),
                         DMI_MATCH(DMI_PRODUCT_NAME, "Aspire 1600"),
@@ -709,8 +700,8 @@ static struct dmi_system_id dmi_ids[] __initdata = {
                 .driver_data = keymap_acer_aspire_1600
         },
         {
+                /* Acer Aspire 3020 */
                 .callback = dmi_matched,
-                .ident = "Acer Aspire 3020",
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "Acer"),
                         DMI_MATCH(DMI_PRODUCT_NAME, "Aspire 3020"),
@@ -718,8 +709,8 @@ static struct dmi_system_id dmi_ids[] __initdata = {
                 .driver_data = keymap_acer_aspire_5020
         },
         {
+                /* Acer Aspire 5020 */
                 .callback = dmi_matched,
-                .ident = "Acer Aspire 5020",
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "Acer"),
                         DMI_MATCH(DMI_PRODUCT_NAME, "Aspire 5020"),
@@ -727,8 +718,8 @@ static struct dmi_system_id dmi_ids[] __initdata = {
                 .driver_data = keymap_acer_aspire_5020
         },
         {
+                /* Acer TravelMate 2100 */
                 .callback = dmi_matched,
-                .ident = "Acer TravelMate 2100",
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "Acer"),
                         DMI_MATCH(DMI_PRODUCT_NAME, "TravelMate 2100"),
@@ -736,8 +727,8 @@ static struct dmi_system_id dmi_ids[] __initdata = {
                 .driver_data = keymap_acer_aspire_5020
         },
         {
+                /* Acer TravelMate 2410 */
                 .callback = dmi_matched,
-                .ident = "Acer TravelMate 2410",
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "Acer"),
                         DMI_MATCH(DMI_PRODUCT_NAME, "TravelMate 2410"),
@@ -745,8 +736,8 @@ static struct dmi_system_id dmi_ids[] __initdata = {
                 .driver_data = keymap_acer_travelmate_2410
         },
         {
+                /* Acer TravelMate C300 */
                 .callback = dmi_matched,
-                .ident = "Acer TravelMate C300",
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "Acer"),
                         DMI_MATCH(DMI_PRODUCT_NAME, "TravelMate C300"),
@@ -754,8 +745,8 @@ static struct dmi_system_id dmi_ids[] __initdata = {
                 .driver_data = keymap_acer_travelmate_300
         },
         {
+                /* Acer TravelMate C100 */
                 .callback = dmi_matched,
-                .ident = "Acer TravelMate C100",
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "Acer"),
                         DMI_MATCH(DMI_PRODUCT_NAME, "TravelMate C100"),
@@ -763,8 +754,8 @@ static struct dmi_system_id dmi_ids[] __initdata = {
                 .driver_data = keymap_acer_travelmate_300
         },
         {
+                /* Acer TravelMate C110 */
                 .callback = dmi_matched,
-                .ident = "Acer TravelMate C110",
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "Acer"),
                         DMI_MATCH(DMI_PRODUCT_NAME, "TravelMate C110"),
@@ -772,8 +763,8 @@ static struct dmi_system_id dmi_ids[] __initdata = {
                 .driver_data = keymap_acer_travelmate_110
         },
         {
+                /* Acer TravelMate 380 */
                 .callback = dmi_matched,
-                .ident = "Acer TravelMate 380",
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "Acer"),
                         DMI_MATCH(DMI_PRODUCT_NAME, "TravelMate 380"),
@@ -781,8 +772,8 @@ static struct dmi_system_id dmi_ids[] __initdata = {
                 .driver_data = keymap_acer_travelmate_380
         },
         {
+                /* Acer TravelMate 370 */
                 .callback = dmi_matched,
-                .ident = "Acer TravelMate 370",
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "Acer"),
                         DMI_MATCH(DMI_PRODUCT_NAME, "TravelMate 370"),
@@ -790,8 +781,8 @@ static struct dmi_system_id dmi_ids[] __initdata = {
                 .driver_data = keymap_acer_travelmate_380 /* keyboard minus 1 key */
         },
         {
+                /* Acer TravelMate 220 */
                 .callback = dmi_matched,
-                .ident = "Acer TravelMate 220",
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "Acer"),
                         DMI_MATCH(DMI_PRODUCT_NAME, "TravelMate 220"),
@@ -799,8 +790,8 @@ static struct dmi_system_id dmi_ids[] __initdata = {
                 .driver_data = keymap_acer_travelmate_220
         },
         {
+                /* Acer TravelMate 260 */
                 .callback = dmi_matched,
-                .ident = "Acer TravelMate 260",
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "Acer"),
                         DMI_MATCH(DMI_PRODUCT_NAME, "TravelMate 260"),
@@ -808,8 +799,8 @@ static struct dmi_system_id dmi_ids[] __initdata = {
                 .driver_data = keymap_acer_travelmate_220
         },
         {
+                /* Acer TravelMate 230 */
                 .callback = dmi_matched,
-                .ident = "Acer TravelMate 230",
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "Acer"),
                         DMI_MATCH(DMI_PRODUCT_NAME, "TravelMate 230"),
@@ -818,8 +809,8 @@ static struct dmi_system_id dmi_ids[] __initdata = {
                 .driver_data = keymap_acer_travelmate_230
         },
         {
+                /* Acer TravelMate 280 */
                 .callback = dmi_matched,
-                .ident = "Acer TravelMate 280",
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "Acer"),
                         DMI_MATCH(DMI_PRODUCT_NAME, "TravelMate 280"),
@@ -827,8 +818,8 @@ static struct dmi_system_id dmi_ids[] __initdata = {
                 .driver_data = keymap_acer_travelmate_230
         },
         {
+                /* Acer TravelMate 240 */
                 .callback = dmi_matched,
-                .ident = "Acer TravelMate 240",
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "Acer"),
                         DMI_MATCH(DMI_PRODUCT_NAME, "TravelMate 240"),
@@ -836,8 +827,8 @@ static struct dmi_system_id dmi_ids[] __initdata = {
                 .driver_data = keymap_acer_travelmate_240
         },
         {
+                /* Acer TravelMate 250 */
                 .callback = dmi_matched,
-                .ident = "Acer TravelMate 250",
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "Acer"),
                         DMI_MATCH(DMI_PRODUCT_NAME, "TravelMate 250"),
@@ -845,8 +836,8 @@ static struct dmi_system_id dmi_ids[] __initdata = {
                 .driver_data = keymap_acer_travelmate_240
         },
         {
+                /* Acer TravelMate 2424NWXCi */
                 .callback = dmi_matched,
-                .ident = "Acer TravelMate 2424NWXCi",
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "Acer"),
                         DMI_MATCH(DMI_PRODUCT_NAME, "TravelMate 2420"),
@@ -854,8 +845,8 @@ static struct dmi_system_id dmi_ids[] __initdata = {
                 .driver_data = keymap_acer_travelmate_240
         },
         {
+                /* Acer TravelMate 350 */
                 .callback = dmi_matched,
-                .ident = "Acer TravelMate 350",
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "Acer"),
                         DMI_MATCH(DMI_PRODUCT_NAME, "TravelMate 350"),
@@ -863,8 +854,8 @@ static struct dmi_system_id dmi_ids[] __initdata = {
                 .driver_data = keymap_acer_travelmate_350
         },
         {
+                /* Acer TravelMate 360 */
                 .callback = dmi_matched,
-                .ident = "Acer TravelMate 360",
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "Acer"),
                         DMI_MATCH(DMI_PRODUCT_NAME, "TravelMate 360"),
@@ -872,8 +863,8 @@ static struct dmi_system_id dmi_ids[] __initdata = {
                 .driver_data = keymap_acer_travelmate_360
         },
         {
+                /* Acer TravelMate 610 */
                 .callback = dmi_matched,
-                .ident = "Acer TravelMate 610",
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "ACER"),
                         DMI_MATCH(DMI_PRODUCT_NAME, "TravelMate 610"),
@@ -881,8 +872,8 @@ static struct dmi_system_id dmi_ids[] __initdata = {
                 .driver_data = keymap_acer_travelmate_610
         },
         {
+                /* Acer TravelMate 620 */
                 .callback = dmi_matched,
-                .ident = "Acer TravelMate 620",
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "Acer"),
                         DMI_MATCH(DMI_PRODUCT_NAME, "TravelMate 620"),
@@ -890,8 +881,8 @@ static struct dmi_system_id dmi_ids[] __initdata = {
                 .driver_data = keymap_acer_travelmate_630
         },
         {
+                /* Acer TravelMate 630 */
                 .callback = dmi_matched,
-                .ident = "Acer TravelMate 630",
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "Acer"),
                         DMI_MATCH(DMI_PRODUCT_NAME, "TravelMate 630"),
@@ -899,8 +890,8 @@ static struct dmi_system_id dmi_ids[] __initdata = {
                 .driver_data = keymap_acer_travelmate_630
         },
         {
+                /* AOpen 1559AS */
                 .callback = dmi_matched,
-                .ident = "AOpen 1559AS",
                 .matches = {
                         DMI_MATCH(DMI_PRODUCT_NAME, "E2U"),
                         DMI_MATCH(DMI_BOARD_NAME, "E2U"),
@@ -908,8 +899,8 @@ static struct dmi_system_id dmi_ids[] __initdata = {
                 .driver_data = keymap_aopen_1559as
         },
         {
+                /* Medion MD 9783 */
                 .callback = dmi_matched,
-                .ident = "Medion MD 9783",
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "MEDIONNB"),
                         DMI_MATCH(DMI_PRODUCT_NAME, "MD 9783"),
@@ -917,8 +908,8 @@ static struct dmi_system_id dmi_ids[] __initdata = {
                 .driver_data = keymap_wistron_ms2111
         },
         {
+                /* Medion MD 40100 */
                 .callback = dmi_matched,
-                .ident = "Medion MD 40100",
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "MEDIONNB"),
                         DMI_MATCH(DMI_PRODUCT_NAME, "WID2000"),
@@ -926,8 +917,8 @@ static struct dmi_system_id dmi_ids[] __initdata = {
                 .driver_data = keymap_wistron_md40100
         },
         {
+                /* Medion MD 2900 */
                 .callback = dmi_matched,
-                .ident = "Medion MD 2900",
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "MEDIONNB"),
                         DMI_MATCH(DMI_PRODUCT_NAME, "WIM 2000"),
@@ -935,8 +926,8 @@ static struct dmi_system_id dmi_ids[] __initdata = {
                 .driver_data = keymap_wistron_md2900
         },
         {
+                /* Medion MD 42200 */
                 .callback = dmi_matched,
-                .ident = "Medion MD 42200",
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "Medion"),
                         DMI_MATCH(DMI_PRODUCT_NAME, "WIM 2030"),
@@ -944,8 +935,8 @@ static struct dmi_system_id dmi_ids[] __initdata = {
                 .driver_data = keymap_fs_amilo_pro_v2000
         },
         {
+                /* Medion MD 96500 */
                 .callback = dmi_matched,
-                .ident = "Medion MD 96500",
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "MEDIONPC"),
                         DMI_MATCH(DMI_PRODUCT_NAME, "WIM 2040"),
@@ -953,8 +944,8 @@ static struct dmi_system_id dmi_ids[] __initdata = {
                 .driver_data = keymap_wistron_md96500
         },
         {
+                /* Medion MD 95400 */
                 .callback = dmi_matched,
-                .ident = "Medion MD 95400",
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "MEDIONPC"),
                         DMI_MATCH(DMI_PRODUCT_NAME, "WIM 2050"),
@@ -962,8 +953,8 @@ static struct dmi_system_id dmi_ids[] __initdata = {
                 .driver_data = keymap_wistron_md96500
         },
         {
+                /* Fujitsu Siemens Amilo D7820 */
                 .callback = dmi_matched,
-                .ident = "Fujitsu Siemens Amilo D7820",
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "FUJITSU SIEMENS"), /* not sure */
                         DMI_MATCH(DMI_PRODUCT_NAME, "Amilo D"),
@@ -971,8 +962,8 @@ static struct dmi_system_id dmi_ids[] __initdata = {
                 .driver_data = keymap_fs_amilo_d88x0
         },
         {
+                /* Fujitsu Siemens Amilo D88x0 */
                 .callback = dmi_matched,
-                .ident = "Fujitsu Siemens Amilo D88x0",
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "FUJITSU SIEMENS"),
                         DMI_MATCH(DMI_PRODUCT_NAME, "AMILO D"),
@@ -1037,21 +1028,6 @@ static unsigned long jiffies_last_press;
 static bool wifi_enabled;
 static bool bluetooth_enabled;
 
-static void report_key(struct input_dev *dev, unsigned int keycode)
-{
-        input_report_key(dev, keycode, 1);
-        input_sync(dev);
-        input_report_key(dev, keycode, 0);
-        input_sync(dev);
-}
-
-static void report_switch(struct input_dev *dev, unsigned int code, int value)
-{
-        input_report_switch(dev, code, value);
-        input_sync(dev);
-}
-
-
  /* led management */
 static void wistron_mail_led_set(struct led_classdev *led_cdev,
                                 enum led_brightness value)
@@ -1128,43 +1104,13 @@ static inline void wistron_led_resume(void)
                 led_classdev_resume(&wistron_wifi_led);
 }
 
-static struct key_entry *wistron_get_entry_by_scancode(int code)
-{
-        struct key_entry *key;
-
-        for (key = keymap; key->type != KE_END; key++)
-                if (code == key->code)
-                        return key;
-
-        return NULL;
-}
-
-static struct key_entry *wistron_get_entry_by_keycode(int keycode)
-{
-        struct key_entry *key;
-
-        for (key = keymap; key->type != KE_END; key++)
-                if (key->type == KE_KEY && keycode == key->keycode)
-                        return key;
-
-        return NULL;
-}
-
 static void handle_key(u8 code)
 {
-        const struct key_entry *key = wistron_get_entry_by_scancode(code);
+        const struct key_entry *key =
+                sparse_keymap_entry_from_scancode(wistron_idev->input, code);
 
         if (key) {
                 switch (key->type) {
-                case KE_KEY:
-                        report_key(wistron_idev->input, key->keycode);
-                        break;
-
-                case KE_SW:
-                        report_switch(wistron_idev->input,
-                                      key->sw.code, key->sw.value);
-                        break;
-
                 case KE_WIFI:
                         if (have_wifi) {
                                 wifi_enabled = !wifi_enabled;
@@ -1180,7 +1126,9 @@ static void handle_key(u8 code)
                         break;
 
                 default:
-                        BUG();
+                        sparse_keymap_report_entry(wistron_idev->input,
+                                                   key, 1, true);
+                        break;
                 }
                 jiffies_last_press = jiffies;
         } else
@@ -1220,42 +1168,39 @@ static void wistron_poll(struct input_polled_dev *dev)
                 dev->poll_interval = POLL_INTERVAL_DEFAULT;
 }
 
-static int wistron_getkeycode(struct input_dev *dev, int scancode, int *keycode)
+static int __devinit wistron_setup_keymap(struct input_dev *dev,
+                                          struct key_entry *entry)
 {
-        const struct key_entry *key = wistron_get_entry_by_scancode(scancode);
-
-        if (key && key->type == KE_KEY) {
-                *keycode = key->keycode;
-                return 0;
-        }
+        switch (entry->type) {
 
-        return -EINVAL;
-}
+        /* if wifi or bluetooth are not available, create normal keys */
+        case KE_WIFI:
+                if (!have_wifi) {
+                        entry->type = KE_KEY;
+                        entry->keycode = KEY_WLAN;
+                }
+                break;
 
-static int wistron_setkeycode(struct input_dev *dev, int scancode, int keycode)
-{
-        struct key_entry *key;
-        int old_keycode;
-
-        if (keycode < 0 || keycode > KEY_MAX)
-                return -EINVAL;
-
-        key = wistron_get_entry_by_scancode(scancode);
-        if (key && key->type == KE_KEY) {
-                old_keycode = key->keycode;
-                key->keycode = keycode;
-                set_bit(keycode, dev->keybit);
-                if (!wistron_get_entry_by_keycode(old_keycode))
-                        clear_bit(old_keycode, dev->keybit);
-                return 0;
+        case KE_BLUETOOTH:
+                if (!have_bluetooth) {
+                        entry->type = KE_KEY;
+                        entry->keycode = KEY_BLUETOOTH;
+                }
+                break;
+
+        case KE_END:
+                if (entry->code & FE_UNTESTED)
+                        printk(KERN_WARNING "Untested laptop multimedia keys, "
+                                "please report success or failure to "
+                                "eric.piel@tremplin-utc.net\n");
+                break;
         }
 
-        return -EINVAL;
+        return 0;
 }
 
 static int __devinit setup_input_dev(void)
 {
-        struct key_entry *key;
         struct input_dev *input_dev;
         int error;
 
@@ -1263,7 +1208,7 @@ static int __devinit setup_input_dev(void)
         if (!wistron_idev)
                 return -ENOMEM;
 
-        wistron_idev->flush = wistron_flush;
+        wistron_idev->open = wistron_flush;
         wistron_idev->poll = wistron_poll;
         wistron_idev->poll_interval = POLL_INTERVAL_DEFAULT;
 
@@ -1273,56 +1218,21 @@ static int __devinit setup_input_dev(void)
         input_dev->id.bustype = BUS_HOST;
         input_dev->dev.parent = &wistron_device->dev;
 
-        input_dev->getkeycode = wistron_getkeycode;
-        input_dev->setkeycode = wistron_setkeycode;
-
-        for (key = keymap; key->type != KE_END; key++) {
-                switch (key->type) {
-                        case KE_KEY:
-                                set_bit(EV_KEY, input_dev->evbit);
-                                set_bit(key->keycode, input_dev->keybit);
-                                break;
-
-                        case KE_SW:
-                                set_bit(EV_SW, input_dev->evbit);
-                                set_bit(key->sw.code, input_dev->swbit);
-                                break;
-
-                        /* if wifi or bluetooth are not available, create normal keys */
-                        case KE_WIFI:
-                                if (!have_wifi) {
-                                        key->type = KE_KEY;
-                                        key->keycode = KEY_WLAN;
-                                        key--;
-                                }
-                                break;
-
-                        case KE_BLUETOOTH:
-                                if (!have_bluetooth) {
-                                        key->type = KE_KEY;
-                                        key->keycode = KEY_BLUETOOTH;
-                                        key--;
-                                }
-                                break;
-
-                        default:
-                                break;
-                }
-        }
-
-        /* reads information flags on KE_END */
-        if (key->code & FE_UNTESTED)
-                printk(KERN_WARNING "Untested laptop multimedia keys, "
-                        "please report success or failure to eric.piel"
-                        "@tremplin-utc.net\n");
+        error = sparse_keymap_setup(input_dev, keymap, wistron_setup_keymap);
+        if (error)
+                goto err_free_dev;
 
         error = input_register_polled_device(wistron_idev);
-        if (error) {
-                input_free_polled_device(wistron_idev);
-                return error;
-        }
+        if (error)
+                goto err_free_keymap;
 
         return 0;
+
+ err_free_keymap:
+        sparse_keymap_free(input_dev);
+ err_free_dev:
+        input_free_polled_device(wistron_idev);
+        return error;
 }
 
 /* Driver core */
@@ -1371,6 +1281,7 @@ static int __devexit wistron_remove(struct platform_device *dev)
 {
         wistron_led_remove();
         input_unregister_polled_device(wistron_idev);
+        sparse_keymap_free(wistron_idev->input);
         input_free_polled_device(wistron_idev);
         bios_detach();
 
@@ -1418,7 +1329,7 @@ static struct platform_driver wistron_driver = {
         .driver         = {
                 .name   = "wistron-bios",
                 .owner  = THIS_MODULE,
-#if CONFIG_PM
+#ifdef CONFIG_PM
                 .pm     = &wistron_pm_ops,
 #endif
         },
diff --git a/drivers/input/misc/wm831x-on.c b/drivers/input/misc/wm831x-on.c
index ba4f5dd7c60e..c3d7ba5f5b47 100644
--- a/drivers/input/misc/wm831x-on.c
+++ b/drivers/input/misc/wm831x-on.c
@@ -19,6 +19,7 @@
 
 #include <linux/module.h>
 #include <linux/init.h>
+#include <linux/slab.h>
 #include <linux/kernel.h>
 #include <linux/errno.h>
 #include <linux/input.h>
@@ -97,8 +98,9 @@ static int __devinit wm831x_on_probe(struct platform_device *pdev)
         wm831x_on->dev->phys = "wm831x_on/input0";
         wm831x_on->dev->dev.parent = &pdev->dev;
 
-        ret = wm831x_request_irq(wm831x, irq, wm831x_on_irq,
-                                 IRQF_TRIGGER_RISING, "wm831x_on", wm831x_on);
+        ret = request_threaded_irq(irq, NULL, wm831x_on_irq,
+                                   IRQF_TRIGGER_RISING, "wm831x_on",
+                                   wm831x_on);
         if (ret < 0) {
                 dev_err(&pdev->dev, "Unable to request IRQ: %d\n", ret);
                 goto err_input_dev;
@@ -114,7 +116,7 @@ static int __devinit wm831x_on_probe(struct platform_device *pdev)
         return 0;
 
 err_irq:
-        wm831x_free_irq(wm831x, irq, NULL);
+        free_irq(irq, wm831x_on);
 err_input_dev:
         input_free_device(wm831x_on->dev);
 err:
@@ -127,7 +129,7 @@ static int __devexit wm831x_on_remove(struct platform_device *pdev)
         struct wm831x_on *wm831x_on = platform_get_drvdata(pdev);
         int irq = platform_get_irq(pdev, 0);
 
-        wm831x_free_irq(wm831x_on->wm831x, irq, wm831x_on);
+        free_irq(irq, wm831x_on);
         cancel_delayed_work_sync(&wm831x_on->work);
         input_unregister_device(wm831x_on->dev);
         kfree(wm831x_on);
diff --git a/drivers/input/misc/yealink.h b/drivers/input/misc/yealink.h
index 48af0be9cbdf..1e0f52397010 100644
--- a/drivers/input/misc/yealink.h
+++ b/drivers/input/misc/yealink.h
@@ -127,7 +127,7 @@ struct yld_ctl_packet {
  * yld_status struct.
  */
 
-/* LCD, each segment must be driven seperately.
+/* LCD, each segment must be driven separately.
  *
  * Layout:
  *
diff --git a/drivers/input/mouse/Kconfig b/drivers/input/mouse/Kconfig
index 3feeb3af8abd..c714ca2407f8 100644
--- a/drivers/input/mouse/Kconfig
+++ b/drivers/input/mouse/Kconfig
@@ -70,7 +70,7 @@ config MOUSE_PS2_SYNAPTICS
 config MOUSE_PS2_LIFEBOOK
         bool "Fujitsu Lifebook PS/2 mouse protocol extension" if EMBEDDED
         default y
-        depends on MOUSE_PS2 && X86
+        depends on MOUSE_PS2 && X86 && DMI
         help
           Say Y here if you have a Fujitsu B-series Lifebook PS/2
           TouchScreen connected to your system.
diff --git a/drivers/input/mouse/alps.c b/drivers/input/mouse/alps.c
index f36110689aae..99d58764ef03 100644
--- a/drivers/input/mouse/alps.c
+++ b/drivers/input/mouse/alps.c
@@ -5,6 +5,7 @@
  * Copyright (c) 2003-2005 Peter Osterlund <petero2@telia.com>
  * Copyright (c) 2004 Dmitry Torokhov <dtor@mail.ru>
  * Copyright (c) 2005 Vojtech Pavlik <vojtech@suse.cz>
+ * Copyright (c) 2009 Sebastian Kapfer <sebastian_kapfer@gmx.net>
  *
  * ALPS detection, tap switching and status querying info is taken from
  * tpconfig utility (by C. Scott Ananian and Bruce Kall).
@@ -14,6 +15,7 @@
  * the Free Software Foundation.
  */
 
+#include <linux/slab.h>
 #include <linux/input.h>
 #include <linux/serio.h>
 #include <linux/libps2.h>
@@ -28,13 +30,16 @@
 #define dbg(format, arg...) do {} while (0)
 #endif
 
-#define ALPS_DUALPOINT  0x01
-#define ALPS_WHEEL      0x02
-#define ALPS_FW_BK_1    0x04
-#define ALPS_4BTN       0x08
-#define ALPS_OLDPROTO   0x10
-#define ALPS_PASS       0x20
-#define ALPS_FW_BK_2    0x40
+#define ALPS_OLDPROTO           0x01    /* old style input */
+#define ALPS_DUALPOINT          0x02    /* touchpad has trackstick */
+#define ALPS_PASS               0x04    /* device has a pass-through port */
+
+#define ALPS_WHEEL              0x08    /* hardware wheel present */
+#define ALPS_FW_BK_1            0x10    /* front & back buttons present */
+#define ALPS_FW_BK_2            0x20    /* front & back buttons present */
+#define ALPS_FOUR_BUTTONS       0x40    /* 4 direction button present */
+#define ALPS_PS2_INTERLEAVED    0x80    /* 3-byte PS/2 packet interleaved with
+                                           6-byte ALPS packet */
 
 static const struct alps_model_info alps_model_data[] = {
         { { 0x32, 0x02, 0x14 }, 0xf8, 0xf8, ALPS_PASS | ALPS_DUALPOINT }, /* Toshiba Salellite Pro M10 */
@@ -55,8 +60,12 @@ static const struct alps_model_info alps_model_data[] = {
         { { 0x20, 0x02, 0x0e }, 0xf8, 0xf8, ALPS_PASS | ALPS_DUALPOINT }, /* XXX */
         { { 0x22, 0x02, 0x0a }, 0xf8, 0xf8, ALPS_PASS | ALPS_DUALPOINT },
         { { 0x22, 0x02, 0x14 }, 0xff, 0xff, ALPS_PASS | ALPS_DUALPOINT }, /* Dell Latitude D600 */
-        { { 0x62, 0x02, 0x14 }, 0xcf, 0xcf, ALPS_PASS | ALPS_DUALPOINT }, /* Dell Latitude E6500 */
-        { { 0x73, 0x02, 0x50 }, 0xcf, 0xcf, ALPS_FW_BK_1 },               /* Dell Vostro 1400 */
+        /* Dell Latitude E5500, E6400, E6500, Precision M4400 */
+        { { 0x62, 0x02, 0x14 }, 0xcf, 0xcf,
+                ALPS_PASS | ALPS_DUALPOINT | ALPS_PS2_INTERLEAVED },
+        { { 0x73, 0x02, 0x50 }, 0xcf, 0xcf, ALPS_FOUR_BUTTONS },          /* Dell Vostro 1400 */
+        { { 0x52, 0x01, 0x14 }, 0xff, 0xff,
+                ALPS_PASS | ALPS_DUALPOINT | ALPS_PS2_INTERLEAVED },      /* Toshiba Tecra A11-11L */
 };
 
 /*
@@ -66,42 +75,86 @@ static const struct alps_model_info alps_model_data[] = {
  */
 
 /*
- * ALPS abolute Mode - new format
+ * PS/2 packet format
+ *
+ * byte 0:  0    0 YSGN XSGN    1    M    R    L
+ * byte 1: X7   X6   X5   X4   X3   X2   X1   X0
+ * byte 2: Y7   Y6   Y5   Y4   Y3   Y2   Y1   Y0
+ *
+ * Note that the device never signals overflow condition.
+ *
+ * ALPS absolute Mode - new format
  *
  * byte 0:  1    ?    ?    ?    1    ?    ?    ?
  * byte 1:  0   x6   x5   x4   x3   x2   x1   x0
- * byte 2:  0   x10  x9   x8   x7    ?  fin  ges
+ * byte 2:  0  x10   x9   x8   x7    ?  fin  ges
  * byte 3:  0   y9   y8   y7    1    M    R    L
  * byte 4:  0   y6   y5   y4   y3   y2   y1   y0
  * byte 5:  0   z6   z5   z4   z3   z2   z1   z0
  *
+ * Dualpoint device -- interleaved packet format
+ *
+ * byte 0:    1    1    0    0    1    1    1    1
+ * byte 1:    0   x6   x5   x4   x3   x2   x1   x0
+ * byte 2:    0  x10   x9   x8   x7    0  fin  ges
+ * byte 3:    0    0 YSGN XSGN    1    1    1    1
+ * byte 4:   X7   X6   X5   X4   X3   X2   X1   X0
+ * byte 5:   Y7   Y6   Y5   Y4   Y3   Y2   Y1   Y0
+ * byte 6:    0   y9   y8   y7    1    m    r    l
+ * byte 7:    0   y6   y5   y4   y3   y2   y1   y0
+ * byte 8:    0   z6   z5   z4   z3   z2   z1   z0
+ *
+ * CAPITALS = stick, miniscules = touchpad
+ *
  * ?'s can have different meanings on different models,
  * such as wheel rotation, extra buttons, stick buttons
  * on a dualpoint, etc.
  */
 
+static bool alps_is_valid_first_byte(const struct alps_model_info *model,
+                                     unsigned char data)
+{
+        return (data & model->mask0) == model->byte0;
+}
+
+static void alps_report_buttons(struct psmouse *psmouse,
+                                struct input_dev *dev1, struct input_dev *dev2,
+                                int left, int right, int middle)
+{
+        struct input_dev *dev;
+
+        /*
+         * If shared button has already been reported on the
+         * other device (dev2) then this event should be also
+         * sent through that device.
+         */
+        dev = test_bit(BTN_LEFT, dev2->key) ? dev2 : dev1;
+        input_report_key(dev, BTN_LEFT, left);
+
+        dev = test_bit(BTN_RIGHT, dev2->key) ? dev2 : dev1;
+        input_report_key(dev, BTN_RIGHT, right);
+
+        dev = test_bit(BTN_MIDDLE, dev2->key) ? dev2 : dev1;
+        input_report_key(dev, BTN_MIDDLE, middle);
+
+        /*
+         * Sync the _other_ device now, we'll do the first
+         * device later once we report the rest of the events.
+         */
+        input_sync(dev2);
+}
+
 static void alps_process_packet(struct psmouse *psmouse)
 {
         struct alps_data *priv = psmouse->private;
+        const struct alps_model_info *model = priv->i;
         unsigned char *packet = psmouse->packet;
         struct input_dev *dev = psmouse->dev;
         struct input_dev *dev2 = priv->dev2;
         int x, y, z, ges, fin, left, right, middle;
         int back = 0, forward = 0;
 
-        if ((packet[0] & 0xc8) == 0x08) {   /* 3-byte PS/2 packet */
-                input_report_key(dev2, BTN_LEFT,   packet[0] & 1);
-                input_report_key(dev2, BTN_RIGHT,  packet[0] & 2);
-                input_report_key(dev2, BTN_MIDDLE, packet[0] & 4);
-                input_report_rel(dev2, REL_X,
-                        packet[1] ? packet[1] - ((packet[0] << 4) & 0x100) : 0);
-                input_report_rel(dev2, REL_Y,
-                        packet[2] ? ((packet[0] << 3) & 0x100) - packet[2] : 0);
-                input_sync(dev2);
-                return;
-        }
-
-        if (priv->i->flags & ALPS_OLDPROTO) {
+        if (model->flags & ALPS_OLDPROTO) {
                 left = packet[2] & 0x10;
                 right = packet[2] & 0x08;
                 middle = 0;
@@ -117,12 +170,12 @@ static void alps_process_packet(struct psmouse *psmouse)
                 z = packet[5];
         }
 
-        if (priv->i->flags & ALPS_FW_BK_1) {
+        if (model->flags & ALPS_FW_BK_1) {
                 back = packet[0] & 0x10;
                 forward = packet[2] & 4;
         }
 
-        if (priv->i->flags & ALPS_FW_BK_2) {
+        if (model->flags & ALPS_FW_BK_2) {
                 back = packet[3] & 4;
                 forward = packet[2] & 4;
                 if ((middle = forward && back))
@@ -132,25 +185,21 @@ static void alps_process_packet(struct psmouse *psmouse)
         ges = packet[2] & 1;
         fin = packet[2] & 2;
 
-        if ((priv->i->flags & ALPS_DUALPOINT) && z == 127) {
+        if ((model->flags & ALPS_DUALPOINT) && z == 127) {
                 input_report_rel(dev2, REL_X,  (x > 383 ? (x - 768) : x));
                 input_report_rel(dev2, REL_Y, -(y > 255 ? (y - 512) : y));
 
-                input_report_key(dev2, BTN_LEFT, left);
-                input_report_key(dev2, BTN_RIGHT, right);
-                input_report_key(dev2, BTN_MIDDLE, middle);
+                alps_report_buttons(psmouse, dev2, dev, left, right, middle);
 
-                input_sync(dev);
                 input_sync(dev2);
                 return;
         }
 
-        input_report_key(dev, BTN_LEFT, left);
-        input_report_key(dev, BTN_RIGHT, right);
-        input_report_key(dev, BTN_MIDDLE, middle);
+        alps_report_buttons(psmouse, dev, dev2, left, right, middle);
 
         /* Convert hardware tap to a reasonable Z value */
-        if (ges && !fin) z = 40;
+        if (ges && !fin)
+                z = 40;
 
         /*
          * A "tap and drag" operation is reported by the hardware as a transition
@@ -166,8 +215,10 @@ static void alps_process_packet(struct psmouse *psmouse)
         }
         priv->prev_fin = fin;
 
-        if (z > 30) input_report_key(dev, BTN_TOUCH, 1);
-        if (z < 25) input_report_key(dev, BTN_TOUCH, 0);
+        if (z > 30)
+                input_report_key(dev, BTN_TOUCH, 1);
+        if (z < 25)
+                input_report_key(dev, BTN_TOUCH, 0);
 
         if (z > 0) {
                 input_report_abs(dev, ABS_X, x);
@@ -177,36 +228,186 @@ static void alps_process_packet(struct psmouse *psmouse)
         input_report_abs(dev, ABS_PRESSURE, z);
         input_report_key(dev, BTN_TOOL_FINGER, z > 0);
 
-        if (priv->i->flags & ALPS_WHEEL)
+        if (model->flags & ALPS_WHEEL)
                 input_report_rel(dev, REL_WHEEL, ((packet[2] << 1) & 0x08) - ((packet[0] >> 4) & 0x07));
 
-        if (priv->i->flags & (ALPS_FW_BK_1 | ALPS_FW_BK_2)) {
+        if (model->flags & (ALPS_FW_BK_1 | ALPS_FW_BK_2)) {
                 input_report_key(dev, BTN_FORWARD, forward);
                 input_report_key(dev, BTN_BACK, back);
         }
 
+        if (model->flags & ALPS_FOUR_BUTTONS) {
+                input_report_key(dev, BTN_0, packet[2] & 4);
+                input_report_key(dev, BTN_1, packet[0] & 0x10);
+                input_report_key(dev, BTN_2, packet[3] & 4);
+                input_report_key(dev, BTN_3, packet[0] & 0x20);
+        }
+
         input_sync(dev);
 }
 
+static void alps_report_bare_ps2_packet(struct psmouse *psmouse,
+                                        unsigned char packet[],
+                                        bool report_buttons)
+{
+        struct alps_data *priv = psmouse->private;
+        struct input_dev *dev2 = priv->dev2;
+
+        if (report_buttons)
+                alps_report_buttons(psmouse, dev2, psmouse->dev,
+                                packet[0] & 1, packet[0] & 2, packet[0] & 4);
+
+        input_report_rel(dev2, REL_X,
+                packet[1] ? packet[1] - ((packet[0] << 4) & 0x100) : 0);
+        input_report_rel(dev2, REL_Y,
+                packet[2] ? ((packet[0] << 3) & 0x100) - packet[2] : 0);
+
+        input_sync(dev2);
+}
+
+static psmouse_ret_t alps_handle_interleaved_ps2(struct psmouse *psmouse)
+{
+        struct alps_data *priv = psmouse->private;
+
+        if (psmouse->pktcnt < 6)
+                return PSMOUSE_GOOD_DATA;
+
+        if (psmouse->pktcnt == 6) {
+                /*
+                 * Start a timer to flush the packet if it ends up last
+                 * 6-byte packet in the stream. Timer needs to fire
+                 * psmouse core times out itself. 20 ms should be enough
+                 * to decide if we are getting more data or not.
+                 */
+                mod_timer(&priv->timer, jiffies + msecs_to_jiffies(20));
+                return PSMOUSE_GOOD_DATA;
+        }
+
+        del_timer(&priv->timer);
+
+        if (psmouse->packet[6] & 0x80) {
+
+                /*
+                 * Highest bit is set - that means we either had
+                 * complete ALPS packet and this is start of the
+                 * next packet or we got garbage.
+                 */
+
+                if (((psmouse->packet[3] |
+                      psmouse->packet[4] |
+                      psmouse->packet[5]) & 0x80) ||
+                    (!alps_is_valid_first_byte(priv->i, psmouse->packet[6]))) {
+                        dbg("refusing packet %x %x %x %x "
+                            "(suspected interleaved ps/2)\n",
+                            psmouse->packet[3], psmouse->packet[4],
+                            psmouse->packet[5], psmouse->packet[6]);
+                        return PSMOUSE_BAD_DATA;
+                }
+
+                alps_process_packet(psmouse);
+
+                /* Continue with the next packet */
+                psmouse->packet[0] = psmouse->packet[6];
+                psmouse->pktcnt = 1;
+
+        } else {
+
+                /*
+                 * High bit is 0 - that means that we indeed got a PS/2
+                 * packet in the middle of ALPS packet.
+                 *
+                 * There is also possibility that we got 6-byte ALPS
+                 * packet followed  by 3-byte packet from trackpoint. We
+                 * can not distinguish between these 2 scenarios but
+                 * becase the latter is unlikely to happen in course of
+                 * normal operation (user would need to press all
+                 * buttons on the pad and start moving trackpoint
+                 * without touching the pad surface) we assume former.
+                 * Even if we are wrong the wost thing that would happen
+                 * the cursor would jump but we should not get protocol
+                 * desynchronization.
+                 */
+
+                alps_report_bare_ps2_packet(psmouse, &psmouse->packet[3],
+                                            false);
+
+                /*
+                 * Continue with the standard ALPS protocol handling,
+                 * but make sure we won't process it as an interleaved
+                 * packet again, which may happen if all buttons are
+                 * pressed. To avoid this let's reset the 4th bit which
+                 * is normally 1.
+                 */
+                psmouse->packet[3] = psmouse->packet[6] & 0xf7;
+                psmouse->pktcnt = 4;
+        }
+
+        return PSMOUSE_GOOD_DATA;
+}
+
+static void alps_flush_packet(unsigned long data)
+{
+        struct psmouse *psmouse = (struct psmouse *)data;
+
+        serio_pause_rx(psmouse->ps2dev.serio);
+
+        if (psmouse->pktcnt == 6) {
+
+                /*
+                 * We did not any more data in reasonable amount of time.
+                 * Validate the last 3 bytes and process as a standard
+                 * ALPS packet.
+                 */
+                if ((psmouse->packet[3] |
+                     psmouse->packet[4] |
+                     psmouse->packet[5]) & 0x80) {
+                        dbg("refusing packet %x %x %x "
+                            "(suspected interleaved ps/2)\n",
+                            psmouse->packet[3], psmouse->packet[4],
+                            psmouse->packet[5]);
+                } else {
+                        alps_process_packet(psmouse);
+                }
+                psmouse->pktcnt = 0;
+        }
+
+        serio_continue_rx(psmouse->ps2dev.serio);
+}
+
 static psmouse_ret_t alps_process_byte(struct psmouse *psmouse)
 {
         struct alps_data *priv = psmouse->private;
+        const struct alps_model_info *model = priv->i;
 
         if ((psmouse->packet[0] & 0xc8) == 0x08) { /* PS/2 packet */
                 if (psmouse->pktcnt == 3) {
-                        alps_process_packet(psmouse);
+                        alps_report_bare_ps2_packet(psmouse, psmouse->packet,
+                                                    true);
                         return PSMOUSE_FULL_PACKET;
                 }
                 return PSMOUSE_GOOD_DATA;
         }
 
-        if ((psmouse->packet[0] & priv->i->mask0) != priv->i->byte0)
+        /* Check for PS/2 packet stuffed in the middle of ALPS packet. */
+
+        if ((model->flags & ALPS_PS2_INTERLEAVED) &&
+            psmouse->pktcnt >= 4 && (psmouse->packet[3] & 0x0f) == 0x0f) {
+                return alps_handle_interleaved_ps2(psmouse);
+        }
+
+        if (!alps_is_valid_first_byte(model, psmouse->packet[0])) {
+                dbg("refusing packet[0] = %x (mask0 = %x, byte0 = %x)\n",
+                    psmouse->packet[0], model->mask0, model->byte0);
                 return PSMOUSE_BAD_DATA;
+        }
 
         /* Bytes 2 - 6 should have 0 in the highest bit */
         if (psmouse->pktcnt >= 2 && psmouse->pktcnt <= 6 &&
-            (psmouse->packet[psmouse->pktcnt - 1] & 0x80))
+            (psmouse->packet[psmouse->pktcnt - 1] & 0x80)) {
+                dbg("refusing packet[%i] = %x\n",
+                    psmouse->pktcnt - 1, psmouse->packet[psmouse->pktcnt - 1]);
                 return PSMOUSE_BAD_DATA;
+        }
 
         if (psmouse->pktcnt == 6) {
                 alps_process_packet(psmouse);
@@ -393,15 +594,12 @@ static int alps_poll(struct psmouse *psmouse)
         return 0;
 }
 
-static int alps_hw_init(struct psmouse *psmouse, int *version)
+static int alps_hw_init(struct psmouse *psmouse)
 {
         struct alps_data *priv = psmouse->private;
+        const struct alps_model_info *model = priv->i;
 
-        priv->i = alps_get_model(psmouse, version);
-        if (!priv->i)
-                return -1;
-
-        if ((priv->i->flags & ALPS_PASS) &&
+        if ((model->flags & ALPS_PASS) &&
             alps_passthrough_mode(psmouse, true)) {
                 return -1;
         }
@@ -416,7 +614,7 @@ static int alps_hw_init(struct psmouse *psmouse, int *version)
                 return -1;
         }
 
-        if ((priv->i->flags & ALPS_PASS) &&
+        if ((model->flags & ALPS_PASS) &&
             alps_passthrough_mode(psmouse, false)) {
                 return -1;
         }
@@ -432,12 +630,15 @@ static int alps_hw_init(struct psmouse *psmouse, int *version)
 
 static int alps_reconnect(struct psmouse *psmouse)
 {
+        const struct alps_model_info *model;
+
         psmouse_reset(psmouse);
 
-        if (alps_hw_init(psmouse, NULL))
+        model = alps_get_model(psmouse, NULL);
+        if (!model)
                 return -1;
 
-        return 0;
+        return alps_hw_init(psmouse);
 }
 
 static void alps_disconnect(struct psmouse *psmouse)
@@ -445,6 +646,7 @@ static void alps_disconnect(struct psmouse *psmouse)
         struct alps_data *priv = psmouse->private;
 
         psmouse_reset(psmouse);
+        del_timer_sync(&priv->timer);
         input_unregister_device(priv->dev2);
         kfree(priv);
 }
@@ -452,6 +654,7 @@ static void alps_disconnect(struct psmouse *psmouse)
 int alps_init(struct psmouse *psmouse)
 {
         struct alps_data *priv;
+        const struct alps_model_info *model;
         struct input_dev *dev1 = psmouse->dev, *dev2;
         int version;
 
@@ -461,35 +664,63 @@ int alps_init(struct psmouse *psmouse)
                 goto init_fail;
 
         priv->dev2 = dev2;
+        setup_timer(&priv->timer, alps_flush_packet, (unsigned long)psmouse);
+
         psmouse->private = priv;
 
-        if (alps_hw_init(psmouse, &version))
+        model = alps_get_model(psmouse, &version);
+        if (!model)
+                goto init_fail;
+
+        priv->i = model;
+
+        if (alps_hw_init(psmouse))
                 goto init_fail;
 
+        /*
+         * Undo part of setup done for us by psmouse core since touchpad
+         * is not a relative device.
+         */
+        __clear_bit(EV_REL, dev1->evbit);
+        __clear_bit(REL_X, dev1->relbit);
+        __clear_bit(REL_Y, dev1->relbit);
+
+        /*
+         * Now set up our capabilities.
+         */
         dev1->evbit[BIT_WORD(EV_KEY)] |= BIT_MASK(EV_KEY);
         dev1->keybit[BIT_WORD(BTN_TOUCH)] |= BIT_MASK(BTN_TOUCH);
         dev1->keybit[BIT_WORD(BTN_TOOL_FINGER)] |= BIT_MASK(BTN_TOOL_FINGER);
-        dev1->keybit[BIT_WORD(BTN_LEFT)] |= BIT_MASK(BTN_LEFT) |
-                BIT_MASK(BTN_MIDDLE) | BIT_MASK(BTN_RIGHT);
+        dev1->keybit[BIT_WORD(BTN_LEFT)] |=
+                BIT_MASK(BTN_LEFT) | BIT_MASK(BTN_RIGHT);
 
         dev1->evbit[BIT_WORD(EV_ABS)] |= BIT_MASK(EV_ABS);
         input_set_abs_params(dev1, ABS_X, 0, 1023, 0, 0);
         input_set_abs_params(dev1, ABS_Y, 0, 767, 0, 0);
         input_set_abs_params(dev1, ABS_PRESSURE, 0, 127, 0, 0);
 
-        if (priv->i->flags & ALPS_WHEEL) {
+        if (model->flags & ALPS_WHEEL) {
                 dev1->evbit[BIT_WORD(EV_REL)] |= BIT_MASK(EV_REL);
                 dev1->relbit[BIT_WORD(REL_WHEEL)] |= BIT_MASK(REL_WHEEL);
         }
 
-        if (priv->i->flags & (ALPS_FW_BK_1 | ALPS_FW_BK_2)) {
+        if (model->flags & (ALPS_FW_BK_1 | ALPS_FW_BK_2)) {
                 dev1->keybit[BIT_WORD(BTN_FORWARD)] |= BIT_MASK(BTN_FORWARD);
                 dev1->keybit[BIT_WORD(BTN_BACK)] |= BIT_MASK(BTN_BACK);
         }
 
+        if (model->flags & ALPS_FOUR_BUTTONS) {
+                dev1->keybit[BIT_WORD(BTN_0)] |= BIT_MASK(BTN_0);
+                dev1->keybit[BIT_WORD(BTN_1)] |= BIT_MASK(BTN_1);
+                dev1->keybit[BIT_WORD(BTN_2)] |= BIT_MASK(BTN_2);
+                dev1->keybit[BIT_WORD(BTN_3)] |= BIT_MASK(BTN_3);
+        } else {
+                dev1->keybit[BIT_WORD(BTN_MIDDLE)] |= BIT_MASK(BTN_MIDDLE);
+        }
+
         snprintf(priv->phys, sizeof(priv->phys), "%s/input1", psmouse->ps2dev.serio->phys);
         dev2->phys = priv->phys;
-        dev2->name = (priv->i->flags & ALPS_DUALPOINT) ? "DualPoint Stick" : "PS/2 Mouse";
+        dev2->name = (model->flags & ALPS_DUALPOINT) ? "DualPoint Stick" : "PS/2 Mouse";
         dev2->id.bustype = BUS_I8042;
         dev2->id.vendor  = 0x0002;
         dev2->id.product = PSMOUSE_ALPS;
@@ -497,9 +728,9 @@ int alps_init(struct psmouse *psmouse)
         dev2->dev.parent = &psmouse->ps2dev.serio->dev;
 
         dev2->evbit[0] = BIT_MASK(EV_KEY) | BIT_MASK(EV_REL);
-        dev2->relbit[BIT_WORD(REL_X)] |= BIT_MASK(REL_X) | BIT_MASK(REL_Y);
-        dev2->keybit[BIT_WORD(BTN_LEFT)] |= BIT_MASK(BTN_LEFT) |
-                BIT_MASK(BTN_MIDDLE) | BIT_MASK(BTN_RIGHT);
+        dev2->relbit[BIT_WORD(REL_X)] = BIT_MASK(REL_X) | BIT_MASK(REL_Y);
+        dev2->keybit[BIT_WORD(BTN_LEFT)] =
+                BIT_MASK(BTN_LEFT) | BIT_MASK(BTN_MIDDLE) | BIT_MASK(BTN_RIGHT);
 
         if (input_register_device(priv->dev2))
                 goto init_fail;
diff --git a/drivers/input/mouse/alps.h b/drivers/input/mouse/alps.h
index bc87936fee1a..904ed8b3c8be 100644
--- a/drivers/input/mouse/alps.h
+++ b/drivers/input/mouse/alps.h
@@ -23,6 +23,7 @@ struct alps_data {
         char phys[32];                  /* Phys */
         const struct alps_model_info *i;/* Info */
         int prev_fin;                   /* Finger bit from previous packet */
+        struct timer_list timer;
 };
 
 #ifdef CONFIG_MOUSE_PS2_ALPS
diff --git a/drivers/input/mouse/appletouch.c b/drivers/input/mouse/appletouch.c
index 908b5b44052f..53ec7ddd1826 100644
--- a/drivers/input/mouse/appletouch.c
+++ b/drivers/input/mouse/appletouch.c
@@ -205,8 +205,8 @@ struct atp {
         bool                    overflow_warned;
         int                     x_old;          /* last reported x/y, */
         int                     y_old;          /* used for smoothing */
-        signed char             xy_cur[ATP_XSENSORS + ATP_YSENSORS];
-        signed char             xy_old[ATP_XSENSORS + ATP_YSENSORS];
+        u8                      xy_cur[ATP_XSENSORS + ATP_YSENSORS];
+        u8                      xy_old[ATP_XSENSORS + ATP_YSENSORS];
         int                     xy_acc[ATP_XSENSORS + ATP_YSENSORS];
         int                     idlecount;      /* number of empty packets */
         struct work_struct      work;
@@ -531,7 +531,7 @@ static void atp_complete_geyser_1_2(struct urb *urb)
 
         for (i = 0; i < ATP_XSENSORS + ATP_YSENSORS; i++) {
                 /* accumulate the change */
-                signed char change = dev->xy_old[i] - dev->xy_cur[i];
+                int change = dev->xy_old[i] - dev->xy_cur[i];
                 dev->xy_acc[i] -= change;
 
                 /* prevent down drifting */
diff --git a/drivers/input/mouse/bcm5974.c b/drivers/input/mouse/bcm5974.c
index 0d1d33468b43..4f8fe0886b2a 100644
--- a/drivers/input/mouse/bcm5974.c
+++ b/drivers/input/mouse/bcm5974.c
@@ -139,6 +139,7 @@ struct tp_finger {
 /* trackpad finger data size, empirically at least ten fingers */
 #define SIZEOF_FINGER           sizeof(struct tp_finger)
 #define SIZEOF_ALL_FINGERS      (16 * SIZEOF_FINGER)
+#define MAX_FINGER_ORIENTATION  16384
 
 /* device-specific parameters */
 struct bcm5974_param {
@@ -284,6 +285,26 @@ static void setup_events_to_report(struct input_dev *input_dev,
         input_set_abs_params(input_dev, ABS_Y,
                                 0, cfg->y.dim, cfg->y.fuzz, 0);
 
+        /* finger touch area */
+        input_set_abs_params(input_dev, ABS_MT_TOUCH_MAJOR,
+                             cfg->w.devmin, cfg->w.devmax, 0, 0);
+        input_set_abs_params(input_dev, ABS_MT_TOUCH_MINOR,
+                             cfg->w.devmin, cfg->w.devmax, 0, 0);
+        /* finger approach area */
+        input_set_abs_params(input_dev, ABS_MT_WIDTH_MAJOR,
+                             cfg->w.devmin, cfg->w.devmax, 0, 0);
+        input_set_abs_params(input_dev, ABS_MT_WIDTH_MINOR,
+                             cfg->w.devmin, cfg->w.devmax, 0, 0);
+        /* finger orientation */
+        input_set_abs_params(input_dev, ABS_MT_ORIENTATION,
+                             -MAX_FINGER_ORIENTATION,
+                             MAX_FINGER_ORIENTATION, 0, 0);
+        /* finger position */
+        input_set_abs_params(input_dev, ABS_MT_POSITION_X,
+                             cfg->x.devmin, cfg->x.devmax, 0, 0);
+        input_set_abs_params(input_dev, ABS_MT_POSITION_Y,
+                             cfg->y.devmin, cfg->y.devmax, 0, 0);
+
         __set_bit(EV_KEY, input_dev->evbit);
         __set_bit(BTN_TOUCH, input_dev->keybit);
         __set_bit(BTN_TOOL_FINGER, input_dev->keybit);
@@ -310,13 +331,29 @@ static int report_bt_state(struct bcm5974 *dev, int size)
         return 0;
 }
 
+static void report_finger_data(struct input_dev *input,
+                               const struct bcm5974_config *cfg,
+                               const struct tp_finger *f)
+{
+        input_report_abs(input, ABS_MT_TOUCH_MAJOR, raw2int(f->force_major));
+        input_report_abs(input, ABS_MT_TOUCH_MINOR, raw2int(f->force_minor));
+        input_report_abs(input, ABS_MT_WIDTH_MAJOR, raw2int(f->size_major));
+        input_report_abs(input, ABS_MT_WIDTH_MINOR, raw2int(f->size_minor));
+        input_report_abs(input, ABS_MT_ORIENTATION,
+                         MAX_FINGER_ORIENTATION - raw2int(f->orientation));
+        input_report_abs(input, ABS_MT_POSITION_X, raw2int(f->abs_x));
+        input_report_abs(input, ABS_MT_POSITION_Y,
+                         cfg->y.devmin + cfg->y.devmax - raw2int(f->abs_y));
+        input_mt_sync(input);
+}
+
 /* report trackpad data as logical trackpad state */
 static int report_tp_state(struct bcm5974 *dev, int size)
 {
         const struct bcm5974_config *c = &dev->cfg;
         const struct tp_finger *f;
         struct input_dev *input = dev->input;
-        int raw_p, raw_w, raw_x, raw_y, raw_n;
+        int raw_p, raw_w, raw_x, raw_y, raw_n, i;
         int ptest, origin, ibt = 0, nmin = 0, nmax = 0;
         int abs_p = 0, abs_w = 0, abs_x = 0, abs_y = 0;
 
@@ -329,6 +366,11 @@ static int report_tp_state(struct bcm5974 *dev, int size)
 
         /* always track the first finger; when detached, start over */
         if (raw_n) {
+
+                /* report raw trackpad data */
+                for (i = 0; i < raw_n; i++)
+                        report_finger_data(input, c, &f[i]);
+
                 raw_p = raw2int(f->force_major);
                 raw_w = raw2int(f->size_major);
                 raw_x = raw2int(f->abs_x);
diff --git a/drivers/input/mouse/elantech.c b/drivers/input/mouse/elantech.c
index fda35e615abf..a138b5da79f9 100644
--- a/drivers/input/mouse/elantech.c
+++ b/drivers/input/mouse/elantech.c
@@ -11,6 +11,7 @@
  */
 
 #include <linux/delay.h>
+#include <linux/slab.h>
 #include <linux/module.h>
 #include <linux/input.h>
 #include <linux/serio.h>
@@ -420,6 +421,7 @@ static void elantech_set_input_params(struct psmouse *psmouse)
 
         __set_bit(EV_KEY, dev->evbit);
         __set_bit(EV_ABS, dev->evbit);
+        __clear_bit(EV_REL, dev->evbit);
 
         __set_bit(BTN_LEFT, dev->keybit);
         __set_bit(BTN_RIGHT, dev->keybit);
diff --git a/drivers/input/mouse/hgpk.c b/drivers/input/mouse/hgpk.c
index de1e553028b7..08d66d820d2b 100644
--- a/drivers/input/mouse/hgpk.c
+++ b/drivers/input/mouse/hgpk.c
@@ -30,6 +30,7 @@
  */
 
 #define DEBUG
+#include <linux/slab.h>
 #include <linux/input.h>
 #include <linux/serio.h>
 #include <linux/libps2.h>
@@ -68,10 +69,6 @@ module_param(post_interrupt_delay, int, 0644);
 MODULE_PARM_DESC(post_interrupt_delay,
         "delay (ms) before recal after recal interrupt detected");
 
-static int autorecal = 1;
-module_param(autorecal, int, 0644);
-MODULE_PARM_DESC(autorecal, "enable recalibration in the driver");
-
 /*
  * When the touchpad gets ultra-sensitive, one can keep their finger 1/2"
  * above the pad and still have it send packets.  This causes a jump cursor
@@ -427,22 +424,8 @@ static void hgpk_recalib_work(struct work_struct *work)
 
 static int hgpk_register(struct psmouse *psmouse)
 {
-        struct input_dev *dev = psmouse->dev;
         int err;
 
-        /* unset the things that psmouse-base sets which we don't have */
-        __clear_bit(BTN_MIDDLE, dev->keybit);
-
-        /* set the things we do have */
-        __set_bit(EV_KEY, dev->evbit);
-        __set_bit(EV_REL, dev->evbit);
-
-        __set_bit(REL_X, dev->relbit);
-        __set_bit(REL_Y, dev->relbit);
-
-        __set_bit(BTN_LEFT, dev->keybit);
-        __set_bit(BTN_RIGHT, dev->keybit);
-
         /* register handlers */
         psmouse->protocol_handler = hgpk_process_byte;
         psmouse->poll = hgpk_poll;
diff --git a/drivers/input/mouse/lifebook.c b/drivers/input/mouse/lifebook.c
index 82811558ec33..c31ad11df6bb 100644
--- a/drivers/input/mouse/lifebook.c
+++ b/drivers/input/mouse/lifebook.c
@@ -16,6 +16,7 @@
 #include <linux/serio.h>
 #include <linux/libps2.h>
 #include <linux/dmi.h>
+#include <linux/slab.h>
 
 #include "psmouse.h"
 #include "lifebook.h"
@@ -25,11 +26,13 @@ struct lifebook_data {
         char phys[32];
 };
 
+static bool lifebook_present;
+
 static const char *desired_serio_phys;
 
-static int lifebook_set_serio_phys(const struct dmi_system_id *d)
+static int lifebook_limit_serio3(const struct dmi_system_id *d)
 {
-        desired_serio_phys = d->driver_data;
+        desired_serio_phys = "isa0060/serio3";
         return 0;
 }
 
@@ -41,53 +44,58 @@ static int lifebook_set_6byte_proto(const struct dmi_system_id *d)
         return 0;
 }
 
-static const struct dmi_system_id lifebook_dmi_table[] = {
+static const struct dmi_system_id __initconst lifebook_dmi_table[] = {
         {
-                .ident = "FLORA-ie 55mi",
+                /* FLORA-ie 55mi */
                 .matches = {
                         DMI_MATCH(DMI_PRODUCT_NAME, "FLORA-ie 55mi"),
                 },
         },
         {
-                .ident = "LifeBook B",
+                /* LifeBook B */
+                .matches = {
+                        DMI_MATCH(DMI_PRODUCT_NAME, "Lifebook B Series"),
+                },
+        },
+        {
+                /* LifeBook B */
                 .matches = {
                         DMI_MATCH(DMI_PRODUCT_NAME, "LifeBook B Series"),
                 },
         },
         {
-                .ident = "Lifebook B",
+                /* Lifebook B */
                 .matches = {
                         DMI_MATCH(DMI_PRODUCT_NAME, "LIFEBOOK B Series"),
                 },
         },
         {
-                .ident = "Lifebook B-2130",
+                /* Lifebook B-2130 */
                 .matches = {
                         DMI_MATCH(DMI_BOARD_NAME, "ZEPHYR"),
                 },
         },
         {
-                .ident = "Lifebook B213x/B2150",
+                /* Lifebook B213x/B2150 */
                 .matches = {
                         DMI_MATCH(DMI_PRODUCT_NAME, "LifeBook B2131/B2133/B2150"),
                 },
         },
         {
-                .ident = "Zephyr",
+                /* Zephyr */
                 .matches = {
                         DMI_MATCH(DMI_PRODUCT_NAME, "ZEPHYR"),
                 },
         },
         {
-                .ident = "CF-18",
+                /* Panasonic CF-18 */
                 .matches = {
                         DMI_MATCH(DMI_PRODUCT_NAME, "CF-18"),
                 },
-                .callback = lifebook_set_serio_phys,
-                .driver_data = "isa0060/serio3",
+                .callback = lifebook_limit_serio3,
         },
         {
-                .ident = "Panasonic CF-28",
+                /* Panasonic CF-28 */
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "Matsushita"),
                         DMI_MATCH(DMI_PRODUCT_NAME, "CF-28"),
@@ -95,7 +103,7 @@ static const struct dmi_system_id lifebook_dmi_table[] = {
                 .callback = lifebook_set_6byte_proto,
         },
         {
-                .ident = "Panasonic CF-29",
+                /* Panasonic CF-29 */
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "Matsushita"),
                         DMI_MATCH(DMI_PRODUCT_NAME, "CF-29"),
@@ -103,14 +111,14 @@ static const struct dmi_system_id lifebook_dmi_table[] = {
                 .callback = lifebook_set_6byte_proto,
         },
         {
-                .ident = "CF-72",
+                /* Panasonic CF-72 */
                 .matches = {
                         DMI_MATCH(DMI_PRODUCT_NAME, "CF-72"),
                 },
                 .callback = lifebook_set_6byte_proto,
         },
         {
-                .ident = "Lifebook B142",
+                /* Lifebook B142 */
                 .matches = {
                         DMI_MATCH(DMI_PRODUCT_NAME, "LifeBook B142"),
                 },
@@ -118,6 +126,11 @@ static const struct dmi_system_id lifebook_dmi_table[] = {
         { }
 };
 
+void __init lifebook_module_init(void)
+{
+        lifebook_present = dmi_check_system(lifebook_dmi_table);
+}
+
 static psmouse_ret_t lifebook_process_byte(struct psmouse *psmouse)
 {
         struct lifebook_data *priv = psmouse->private;
@@ -198,10 +211,10 @@ static int lifebook_absolute_mode(struct psmouse *psmouse)
                 return -1;
 
         /*
-           Enable absolute output -- ps2_command fails always but if
-           you leave this call out the touchsreen will never send
-           absolute coordinates
-        */
+         * Enable absolute output -- ps2_command fails always but if
+         * you leave this call out the touchsreen will never send
+         * absolute coordinates
+         */
         param = lifebook_use_6byte_proto ? 0x08 : 0x07;
         ps2_command(ps2dev, &param, PSMOUSE_CMD_SETRES);
 
@@ -243,7 +256,7 @@ static void lifebook_disconnect(struct psmouse *psmouse)
 
 int lifebook_detect(struct psmouse *psmouse, bool set_properties)
 {
-        if (!dmi_check_system(lifebook_dmi_table))
+        if (!lifebook_present)
                 return -1;
 
         if (desired_serio_phys &&
@@ -283,8 +296,8 @@ static int lifebook_create_relative_device(struct psmouse *psmouse)
 
         dev2->evbit[0] = BIT_MASK(EV_KEY) | BIT_MASK(EV_REL);
         dev2->relbit[BIT_WORD(REL_X)] = BIT_MASK(REL_X) | BIT_MASK(REL_Y);
-        dev2->keybit[BIT_WORD(BTN_LEFT)] = BIT_MASK(BTN_LEFT) |
-                BIT_MASK(BTN_RIGHT);
+        dev2->keybit[BIT_WORD(BTN_LEFT)] =
+                                BIT_MASK(BTN_LEFT) | BIT_MASK(BTN_RIGHT);
 
         error = input_register_device(priv->dev2);
         if (error)
@@ -309,6 +322,7 @@ int lifebook_init(struct psmouse *psmouse)
 
         dev1->evbit[0] = BIT_MASK(EV_ABS) | BIT_MASK(EV_KEY);
         dev1->relbit[0] = 0;
+        dev1->keybit[BIT_WORD(BTN_MOUSE)] = 0;
         dev1->keybit[BIT_WORD(BTN_TOUCH)] = BIT_MASK(BTN_TOUCH);
         input_set_abs_params(dev1, ABS_X, 0, max_coord, 0, 0);
         input_set_abs_params(dev1, ABS_Y, 0, max_coord, 0, 0);
diff --git a/drivers/input/mouse/lifebook.h b/drivers/input/mouse/lifebook.h
index 407cb226bc0a..4c4326c6f504 100644
--- a/drivers/input/mouse/lifebook.h
+++ b/drivers/input/mouse/lifebook.h
@@ -12,9 +12,13 @@
 #define _LIFEBOOK_H
 
 #ifdef CONFIG_MOUSE_PS2_LIFEBOOK
+void lifebook_module_init(void);
 int lifebook_detect(struct psmouse *psmouse, bool set_properties);
 int lifebook_init(struct psmouse *psmouse);
 #else
+inline void lifebook_module_init(void)
+{
+}
 inline int lifebook_detect(struct psmouse *psmouse, bool set_properties)
 {
         return -ENOSYS;
diff --git a/drivers/input/mouse/logips2pp.c b/drivers/input/mouse/logips2pp.c
index ab5dc5f5fd83..543c240a85f2 100644
--- a/drivers/input/mouse/logips2pp.c
+++ b/drivers/input/mouse/logips2pp.c
@@ -404,8 +404,8 @@ int ps2pp_init(struct psmouse *psmouse, bool set_properties)
                         }
                 }
 
-                if (buttons < 3)
-                        __clear_bit(BTN_MIDDLE, psmouse->dev->keybit);
+                if (buttons >= 3)
+                        __set_bit(BTN_MIDDLE, psmouse->dev->keybit);
 
                 if (model_info)
                         ps2pp_set_model_properties(psmouse, model_info, use_ps2pp);
diff --git a/drivers/input/mouse/psmouse-base.c b/drivers/input/mouse/psmouse-base.c
index 07c53798301a..d8c0c8d6992c 100644
--- a/drivers/input/mouse/psmouse-base.c
+++ b/drivers/input/mouse/psmouse-base.c
@@ -425,6 +425,7 @@ static int genius_detect(struct psmouse *psmouse, bool set_properties)
                 return -1;
 
         if (set_properties) {
+                __set_bit(BTN_MIDDLE, psmouse->dev->keybit);
                 __set_bit(BTN_EXTRA, psmouse->dev->keybit);
                 __set_bit(BTN_SIDE, psmouse->dev->keybit);
                 __set_bit(REL_WHEEL, psmouse->dev->relbit);
@@ -460,8 +461,10 @@ static int intellimouse_detect(struct psmouse *psmouse, bool set_properties)
                 __set_bit(BTN_MIDDLE, psmouse->dev->keybit);
                 __set_bit(REL_WHEEL, psmouse->dev->relbit);
 
-                if (!psmouse->vendor) psmouse->vendor = "Generic";
-                if (!psmouse->name) psmouse->name = "Wheel Mouse";
+                if (!psmouse->vendor)
+                        psmouse->vendor = "Generic";
+                if (!psmouse->name)
+                        psmouse->name = "Wheel Mouse";
                 psmouse->pktsize = 4;
         }
 
@@ -504,8 +507,10 @@ static int im_explorer_detect(struct psmouse *psmouse, bool set_properties)
                 __set_bit(BTN_SIDE, psmouse->dev->keybit);
                 __set_bit(BTN_EXTRA, psmouse->dev->keybit);
 
-                if (!psmouse->vendor) psmouse->vendor = "Generic";
-                if (!psmouse->name) psmouse->name = "Explorer Mouse";
+                if (!psmouse->vendor)
+                        psmouse->vendor = "Generic";
+                if (!psmouse->name)
+                        psmouse->name = "Explorer Mouse";
                 psmouse->pktsize = 4;
         }
 
@@ -536,6 +541,7 @@ static int thinking_detect(struct psmouse *psmouse, bool set_properties)
                 return -1;
 
         if (set_properties) {
+                __set_bit(BTN_MIDDLE, psmouse->dev->keybit);
                 __set_bit(BTN_EXTRA, psmouse->dev->keybit);
 
                 psmouse->vendor = "Kensington";
@@ -551,8 +557,16 @@ static int thinking_detect(struct psmouse *psmouse, bool set_properties)
 static int ps2bare_detect(struct psmouse *psmouse, bool set_properties)
 {
         if (set_properties) {
-                if (!psmouse->vendor) psmouse->vendor = "Generic";
-                if (!psmouse->name) psmouse->name = "Mouse";
+                if (!psmouse->vendor)
+                        psmouse->vendor = "Generic";
+                if (!psmouse->name)
+                        psmouse->name = "Mouse";
+
+/*
+ * We have no way of figuring true number of buttons so let's
+ * assume that the device has 3.
+ */
+                __set_bit(BTN_MIDDLE, psmouse->dev->keybit);
         }
 
         return 0;
@@ -567,6 +581,8 @@ static int cortron_detect(struct psmouse *psmouse, bool set_properties)
         if (set_properties) {
                 psmouse->vendor = "Cortron";
                 psmouse->name = "PS/2 Trackball";
+
+                __set_bit(BTN_MIDDLE, psmouse->dev->keybit);
                 __set_bit(BTN_SIDE, psmouse->dev->keybit);
         }
 
@@ -611,8 +627,15 @@ static int psmouse_extensions(struct psmouse *psmouse,
                 synaptics_hardware = true;
 
                 if (max_proto > PSMOUSE_IMEX) {
-                        if (!set_properties || synaptics_init(psmouse) == 0)
+/*
+ * Try activating protocol, but check if support is enabled first, since
+ * we try detecting Synaptics even when protocol is disabled.
+ */
+                        if (synaptics_supported() &&
+                            (!set_properties || synaptics_init(psmouse) == 0)) {
                                 return PSMOUSE_SYNAPTICS;
+                        }
+
 /*
  * Some Synaptics touchpads can emulate extended protocols (like IMPS/2).
  * Unfortunately Logitech/Genius probes confuse some firmware versions so
@@ -667,19 +690,6 @@ static int psmouse_extensions(struct psmouse *psmouse,
                 max_proto = PSMOUSE_IMEX;
         }
 
-/*
- * Try Finger Sensing Pad
- */
-        if (max_proto > PSMOUSE_IMEX) {
-                if (fsp_detect(psmouse, set_properties) == 0) {
-                        if (!set_properties || fsp_init(psmouse) == 0)
-                                return PSMOUSE_FSP;
-/*
- * Init failed, try basic relative protocols
- */
-                        max_proto = PSMOUSE_IMEX;
-                }
-        }
 
         if (max_proto > PSMOUSE_IMEX) {
                 if (genius_detect(psmouse, set_properties) == 0)
@@ -696,6 +706,21 @@ static int psmouse_extensions(struct psmouse *psmouse,
         }
 
 /*
+ * Try Finger Sensing Pad. We do it here because its probe upsets
+ * Trackpoint devices (causing TP_READ_ID command to time out).
+ */
+        if (max_proto > PSMOUSE_IMEX) {
+                if (fsp_detect(psmouse, set_properties) == 0) {
+                        if (!set_properties || fsp_init(psmouse) == 0)
+                                return PSMOUSE_FSP;
+/*
+ * Init failed, try basic relative protocols
+ */
+                        max_proto = PSMOUSE_IMEX;
+                }
+        }
+
+/*
  * Reset to defaults in case the device got confused by extended
  * protocol probes. Note that we follow up with full reset because
  * some mice put themselves to sleep when they see PSMOUSE_RESET_DIS.
@@ -1116,12 +1141,22 @@ static void psmouse_cleanup(struct serio *serio)
                 psmouse_deactivate(parent);
         }
 
-        psmouse_deactivate(psmouse);
+        psmouse_set_state(psmouse, PSMOUSE_INITIALIZING);
+
+        /*
+         * Disable stream mode so cleanup routine can proceed undisturbed.
+         */
+        if (ps2_command(&psmouse->ps2dev, NULL, PSMOUSE_CMD_DISABLE))
+                printk(KERN_WARNING "psmouse.c: Failed to disable mouse on %s\n",
+                        psmouse->ps2dev.serio->phys);
 
         if (psmouse->cleanup)
                 psmouse->cleanup(psmouse);
 
-        psmouse_reset(psmouse);
+/*
+ * Reset the mouse to defaults (bare PS/2 protocol).
+ */
+        ps2_command(&psmouse->ps2dev, NULL, PSMOUSE_CMD_RESET_DIS);
 
 /*
  * Some boxes, such as HP nx7400, get terribly confused if mouse
@@ -1184,15 +1219,16 @@ static void psmouse_disconnect(struct serio *serio)
         mutex_unlock(&psmouse_mutex);
 }
 
-static int psmouse_switch_protocol(struct psmouse *psmouse, const struct psmouse_protocol *proto)
+static int psmouse_switch_protocol(struct psmouse *psmouse,
+                                   const struct psmouse_protocol *proto)
 {
         struct input_dev *input_dev = psmouse->dev;
 
         input_dev->dev.parent = &psmouse->ps2dev.serio->dev;
 
         input_dev->evbit[0] = BIT_MASK(EV_KEY) | BIT_MASK(EV_REL);
-        input_dev->keybit[BIT_WORD(BTN_MOUSE)] = BIT_MASK(BTN_LEFT) |
-                BIT_MASK(BTN_MIDDLE) | BIT_MASK(BTN_RIGHT);
+        input_dev->keybit[BIT_WORD(BTN_MOUSE)] =
+                                BIT_MASK(BTN_LEFT) | BIT_MASK(BTN_RIGHT);
         input_dev->relbit[0] = BIT_MASK(REL_X) | BIT_MASK(REL_Y);
 
         psmouse->set_rate = psmouse_set_rate;
@@ -1209,8 +1245,7 @@ static int psmouse_switch_protocol(struct psmouse *psmouse, const struct psmouse
                         return -1;
 
                 psmouse->type = proto->type;
-        }
-        else
+        } else
                 psmouse->type = psmouse_extensions(psmouse,
                                                    psmouse_max_proto, true);
 
@@ -1431,24 +1466,10 @@ ssize_t psmouse_attr_show_helper(struct device *dev, struct device_attribute *de
         struct serio *serio = to_serio_port(dev);
         struct psmouse_attribute *attr = to_psmouse_attr(devattr);
         struct psmouse *psmouse;
-        int retval;
-
-        retval = serio_pin_driver(serio);
-        if (retval)
-                return retval;
-
-        if (serio->drv != &psmouse_drv) {
-                retval = -ENODEV;
-                goto out;
-        }
 
         psmouse = serio_get_drvdata(serio);
 
-        retval = attr->show(psmouse, attr->data, buf);
-
-out:
-        serio_unpin_driver(serio);
-        return retval;
+        return attr->show(psmouse, attr->data, buf);
 }
 
 ssize_t psmouse_attr_set_helper(struct device *dev, struct device_attribute *devattr,
@@ -1459,18 +1480,9 @@ ssize_t psmouse_attr_set_helper(struct device *dev, struct device_attribute *dev
         struct psmouse *psmouse, *parent = NULL;
         int retval;
 
-        retval = serio_pin_driver(serio);
-        if (retval)
-                return retval;
-
-        if (serio->drv != &psmouse_drv) {
-                retval = -ENODEV;
-                goto out_unpin;
-        }
-
         retval = mutex_lock_interruptible(&psmouse_mutex);
         if (retval)
-                goto out_unpin;
+                goto out;
 
         psmouse = serio_get_drvdata(serio);
 
@@ -1500,8 +1512,7 @@ ssize_t psmouse_attr_set_helper(struct device *dev, struct device_attribute *dev
 
  out_unlock:
         mutex_unlock(&psmouse_mutex);
- out_unpin:
-        serio_unpin_driver(serio);
+ out:
         return retval;
 }
 
@@ -1563,9 +1574,7 @@ static ssize_t psmouse_attr_set_protocol(struct psmouse *psmouse, void *data, co
                 }
 
                 mutex_unlock(&psmouse_mutex);
-                serio_unpin_driver(serio);
                 serio_unregister_child_port(serio);
-                serio_pin_driver_uninterruptible(serio);
                 mutex_lock(&psmouse_mutex);
 
                 if (serio->drv != &psmouse_drv) {
@@ -1680,6 +1689,9 @@ static int __init psmouse_init(void)
 {
         int err;
 
+        lifebook_module_init();
+        synaptics_module_init();
+
         kpsmoused_wq = create_singlethread_workqueue("kpsmoused");
         if (!kpsmoused_wq) {
                 printk(KERN_ERR "psmouse: failed to create kpsmoused workqueue\n");
diff --git a/drivers/input/mouse/pxa930_trkball.c b/drivers/input/mouse/pxa930_trkball.c
index 1e827ad0afbe..943cfec15665 100644
--- a/drivers/input/mouse/pxa930_trkball.c
+++ b/drivers/input/mouse/pxa930_trkball.c
@@ -18,6 +18,7 @@
 #include <linux/platform_device.h>
 #include <linux/delay.h>
 #include <linux/io.h>
+#include <linux/slab.h>
 
 #include <mach/hardware.h>
 #include <mach/pxa930_trkball.h>
diff --git a/drivers/input/mouse/sentelic.c b/drivers/input/mouse/sentelic.c
index f84cbd97c884..1242775fee19 100644
--- a/drivers/input/mouse/sentelic.c
+++ b/drivers/input/mouse/sentelic.c
@@ -2,7 +2,7 @@
  * Finger Sensing Pad PS/2 mouse driver.
  *
  * Copyright (C) 2005-2007 Asia Vital Components Co., Ltd.
- * Copyright (C) 2005-2009 Tai-hwa Liang, Sentelic Corporation.
+ * Copyright (C) 2005-2010 Tai-hwa Liang, Sentelic Corporation.
  *
  *   This program is free software; you can redistribute it and/or
  *   modify it under the terms of the GNU General Public License
@@ -26,6 +26,7 @@
 #include <linux/libps2.h>
 #include <linux/serio.h>
 #include <linux/jiffies.h>
+#include <linux/slab.h>
 
 #include "psmouse.h"
 #include "sentelic.h"
@@ -658,9 +659,9 @@ static psmouse_ret_t fsp_process_byte(struct psmouse *psmouse)
                         if (packet[3] & BIT(1))
                                 button_status |= 0x0f;  /* wheel up */
                         if (packet[3] & BIT(2))
-                                button_status |= BIT(5);/* horizontal left */
+                                button_status |= BIT(4);/* horizontal left */
                         if (packet[3] & BIT(3))
-                                button_status |= BIT(4);/* horizontal right */
+                                button_status |= BIT(5);/* horizontal right */
                         /* push back to packet queue */
                         if (button_status != 0)
                                 packet[3] = button_status;
@@ -836,6 +837,7 @@ int fsp_init(struct psmouse *psmouse)
         priv->flags |= FSPDRV_FLAG_EN_OPC;
 
         /* Set up various supported input event bits */
+        __set_bit(BTN_MIDDLE, psmouse->dev->keybit);
         __set_bit(BTN_BACK, psmouse->dev->keybit);
         __set_bit(BTN_FORWARD, psmouse->dev->keybit);
         __set_bit(REL_WHEEL, psmouse->dev->relbit);
diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c
index f4a61252bcc9..026df6010161 100644
--- a/drivers/input/mouse/synaptics.c
+++ b/drivers/input/mouse/synaptics.c
@@ -24,9 +24,11 @@
  */
 
 #include <linux/module.h>
+#include <linux/dmi.h>
 #include <linux/input.h>
 #include <linux/serio.h>
 #include <linux/libps2.h>
+#include <linux/slab.h>
 #include "psmouse.h"
 #include "synaptics.h"
 
@@ -629,25 +631,26 @@ static int synaptics_reconnect(struct psmouse *psmouse)
         return 0;
 }
 
-#if defined(__i386__)
-#include <linux/dmi.h>
-static const struct dmi_system_id toshiba_dmi_table[] = {
+static bool impaired_toshiba_kbc;
+
+static const struct dmi_system_id __initconst toshiba_dmi_table[] = {
+#if defined(CONFIG_DMI) && defined(CONFIG_X86)
         {
-                .ident = "Toshiba Satellite",
+                /* Toshiba Satellite */
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "TOSHIBA"),
                         DMI_MATCH(DMI_PRODUCT_NAME, "Satellite"),
                 },
         },
         {
-                .ident = "Toshiba Dynabook",
+                /* Toshiba Dynabook */
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "TOSHIBA"),
                         DMI_MATCH(DMI_PRODUCT_NAME, "dynabook"),
                 },
         },
         {
-                .ident = "Toshiba Portege M300",
+                /* Toshiba Portege M300 */
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "TOSHIBA"),
                         DMI_MATCH(DMI_PRODUCT_NAME, "PORTEGE M300"),
@@ -655,7 +658,7 @@ static const struct dmi_system_id toshiba_dmi_table[] = {
 
         },
         {
-                .ident = "Toshiba Portege M300",
+                /* Toshiba Portege M300 */
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "TOSHIBA"),
                         DMI_MATCH(DMI_PRODUCT_NAME, "Portable PC"),
@@ -664,8 +667,13 @@ static const struct dmi_system_id toshiba_dmi_table[] = {
 
         },
         { }
-};
 #endif
+};
+
+void __init synaptics_module_init(void)
+{
+        impaired_toshiba_kbc = dmi_check_system(toshiba_dmi_table);
+}
 
 int synaptics_init(struct psmouse *psmouse)
 {
@@ -718,18 +726,16 @@ int synaptics_init(struct psmouse *psmouse)
         if (SYN_CAP_PASS_THROUGH(priv->capabilities))
                 synaptics_pt_create(psmouse);
 
-#if defined(__i386__)
         /*
          * Toshiba's KBC seems to have trouble handling data from
          * Synaptics as full rate, switch to lower rate which is roughly
          * thye same as rate of standard PS/2 mouse.
          */
-        if (psmouse->rate >= 80 && dmi_check_system(toshiba_dmi_table)) {
+        if (psmouse->rate >= 80 && impaired_toshiba_kbc) {
                 printk(KERN_INFO "synaptics: Toshiba %s detected, limiting rate to 40pps.\n",
                         dmi_get_system_info(DMI_PRODUCT_NAME));
                 psmouse->rate = 40;
         }
-#endif
 
         return 0;
 
@@ -738,12 +744,26 @@ int synaptics_init(struct psmouse *psmouse)
         return -1;
 }
 
+bool synaptics_supported(void)
+{
+        return true;
+}
+
 #else /* CONFIG_MOUSE_PS2_SYNAPTICS */
 
+void __init synaptics_module_init(void)
+{
+}
+
 int synaptics_init(struct psmouse *psmouse)
 {
         return -ENOSYS;
 }
 
+bool synaptics_supported(void)
+{
+        return false;
+}
+
 #endif /* CONFIG_MOUSE_PS2_SYNAPTICS */
 
diff --git a/drivers/input/mouse/synaptics.h b/drivers/input/mouse/synaptics.h
index 871f6fe377f9..f0f40a331dc8 100644
--- a/drivers/input/mouse/synaptics.h
+++ b/drivers/input/mouse/synaptics.h
@@ -105,8 +105,10 @@ struct synaptics_data {
         int scroll;
 };
 
+void synaptics_module_init(void);
 int synaptics_detect(struct psmouse *psmouse, bool set_properties);
 int synaptics_init(struct psmouse *psmouse);
 void synaptics_reset(struct psmouse *psmouse);
+bool synaptics_supported(void);
 
 #endif /* _SYNAPTICS_H */
diff --git a/drivers/input/mouse/synaptics_i2c.c b/drivers/input/mouse/synaptics_i2c.c
index 7283c78044af..8291e7399ffa 100644
--- a/drivers/input/mouse/synaptics_i2c.c
+++ b/drivers/input/mouse/synaptics_i2c.c
@@ -17,6 +17,7 @@
 #include <linux/input.h>
 #include <linux/delay.h>
 #include <linux/workqueue.h>
+#include <linux/slab.h>
 
 #define DRIVER_NAME             "synaptics_i2c"
 /* maximum product id is 15 characters */
@@ -420,8 +421,8 @@ static void synaptics_i2c_check_params(struct synaptics_i2c *touch)
 }
 
 /* Control the Device polling rate / Work Handler sleep time */
-unsigned long synaptics_i2c_adjust_delay(struct synaptics_i2c *touch,
-                                         bool have_data)
+static unsigned long synaptics_i2c_adjust_delay(struct synaptics_i2c *touch,
+                                                bool have_data)
 {
         unsigned long delay, nodata_count_thres;
 
@@ -520,7 +521,7 @@ static void synaptics_i2c_set_input_params(struct synaptics_i2c *touch)
         __set_bit(BTN_LEFT, input->keybit);
 }
 
-struct synaptics_i2c *synaptics_i2c_touch_create(struct i2c_client *client)
+static struct synaptics_i2c *synaptics_i2c_touch_create(struct i2c_client *client)
 {
         struct synaptics_i2c *touch;
 
diff --git a/drivers/input/mouse/touchkit_ps2.c b/drivers/input/mouse/touchkit_ps2.c
index 0308a0faa94d..88121c59c3cc 100644
--- a/drivers/input/mouse/touchkit_ps2.c
+++ b/drivers/input/mouse/touchkit_ps2.c
@@ -26,7 +26,6 @@
  */
 
 #include <linux/kernel.h>
-#include <linux/slab.h>
 
 #include <linux/input.h>
 #include <linux/serio.h>
@@ -86,7 +85,8 @@ int touchkit_ps2_detect(struct psmouse *psmouse, bool set_properties)
 
         if (set_properties) {
                 dev->evbit[0] = BIT_MASK(EV_KEY) | BIT_MASK(EV_ABS);
-                __set_bit(BTN_TOUCH, dev->keybit);
+                dev->keybit[BIT_WORD(BTN_MOUSE)] = 0;
+                dev->keybit[BIT_WORD(BTN_TOUCH)] = BIT_MASK(BTN_TOUCH);
                 input_set_abs_params(dev, ABS_X, 0, TOUCHKIT_MAX_XC, 0, 0);
                 input_set_abs_params(dev, ABS_Y, 0, TOUCHKIT_MAX_YC, 0, 0);
 
diff --git a/drivers/input/mouse/trackpoint.c b/drivers/input/mouse/trackpoint.c
index e354362f2971..0643e49ca603 100644
--- a/drivers/input/mouse/trackpoint.c
+++ b/drivers/input/mouse/trackpoint.c
@@ -8,6 +8,7 @@
  * Trademarks are the property of their respective owners.
  */
 
+#include <linux/slab.h>
 #include <linux/delay.h>
 #include <linux/serio.h>
 #include <linux/module.h>
@@ -284,7 +285,6 @@ static int trackpoint_reconnect(struct psmouse *psmouse)
 
 int trackpoint_detect(struct psmouse *psmouse, bool set_properties)
 {
-        struct trackpoint_data *priv;
         struct ps2dev *ps2dev = &psmouse->ps2dev;
         unsigned char firmware_id;
         unsigned char button_info;
@@ -301,8 +301,8 @@ int trackpoint_detect(struct psmouse *psmouse, bool set_properties)
                 button_info = 0;
         }
 
-        psmouse->private = priv = kzalloc(sizeof(struct trackpoint_data), GFP_KERNEL);
-        if (!priv)
+        psmouse->private = kzalloc(sizeof(struct trackpoint_data), GFP_KERNEL);
+        if (!psmouse->private)
                 return -1;
 
         psmouse->vendor = "IBM";
@@ -311,7 +311,10 @@ int trackpoint_detect(struct psmouse *psmouse, bool set_properties)
         psmouse->reconnect = trackpoint_reconnect;
         psmouse->disconnect = trackpoint_disconnect;
 
-        trackpoint_defaults(priv);
+        if ((button_info & 0x0f) >= 3)
+                __set_bit(BTN_MIDDLE, psmouse->dev->keybit);
+
+        trackpoint_defaults(psmouse->private);
         trackpoint_sync(psmouse);
 
         error = sysfs_create_group(&ps2dev->serio->dev.kobj, &trackpoint_attr_group);
@@ -319,7 +322,8 @@ int trackpoint_detect(struct psmouse *psmouse, bool set_properties)
                 printk(KERN_ERR
                         "trackpoint.c: failed to create sysfs attributes, error: %d\n",
                         error);
-                kfree(priv);
+                kfree(psmouse->private);
+                psmouse->private = NULL;
                 return -1;
         }
 
diff --git a/drivers/input/mouse/vsxxxaa.c b/drivers/input/mouse/vsxxxaa.c
index 70111443678e..bf2c0c80d6cc 100644
--- a/drivers/input/mouse/vsxxxaa.c
+++ b/drivers/input/mouse/vsxxxaa.c
@@ -86,27 +86,28 @@
 
 #define DRIVER_DESC "Driver for DEC VSXXX-AA and -GA mice and VSXXX-AB tablet"
 
-MODULE_AUTHOR ("Jan-Benedict Glaw <jbglaw@lug-owl.de>");
-MODULE_DESCRIPTION (DRIVER_DESC);
-MODULE_LICENSE ("GPL");
+MODULE_AUTHOR("Jan-Benedict Glaw <jbglaw@lug-owl.de>");
+MODULE_DESCRIPTION(DRIVER_DESC);
+MODULE_LICENSE("GPL");
 
 #undef VSXXXAA_DEBUG
 #ifdef VSXXXAA_DEBUG
-#define DBG(x...) printk (x)
+#define DBG(x...) printk(x)
 #else
 #define DBG(x...) do {} while (0)
 #endif
 
 #define VSXXXAA_INTRO_MASK      0x80
 #define VSXXXAA_INTRO_HEAD      0x80
-#define IS_HDR_BYTE(x)          (((x) & VSXXXAA_INTRO_MASK)     \
-                                        == VSXXXAA_INTRO_HEAD)
+#define IS_HDR_BYTE(x)                  \
+        (((x) & VSXXXAA_INTRO_MASK) == VSXXXAA_INTRO_HEAD)
 
 #define VSXXXAA_PACKET_MASK     0xe0
 #define VSXXXAA_PACKET_REL      0x80
 #define VSXXXAA_PACKET_ABS      0xc0
 #define VSXXXAA_PACKET_POR      0xa0
-#define MATCH_PACKET_TYPE(data, type)   (((data) & VSXXXAA_PACKET_MASK) == (type))
+#define MATCH_PACKET_TYPE(data, type)   \
+        (((data) & VSXXXAA_PACKET_MASK) == (type))
 
 
 
@@ -123,52 +124,50 @@ struct vsxxxaa {
         char phys[32];
 };
 
-static void
-vsxxxaa_drop_bytes (struct vsxxxaa *mouse, int num)
+static void vsxxxaa_drop_bytes(struct vsxxxaa *mouse, int num)
 {
-        if (num >= mouse->count)
+        if (num >= mouse->count) {
                 mouse->count = 0;
-        else {
-                memmove (mouse->buf, mouse->buf + num - 1, BUFLEN - num);
+        } else {
+                memmove(mouse->buf, mouse->buf + num - 1, BUFLEN - num);
                 mouse->count -= num;
         }
 }
 
-static void
-vsxxxaa_queue_byte (struct vsxxxaa *mouse, unsigned char byte)
+static void vsxxxaa_queue_byte(struct vsxxxaa *mouse, unsigned char byte)
 {
         if (mouse->count == BUFLEN) {
-                printk (KERN_ERR "%s on %s: Dropping a byte of full buffer.\n",
-                                mouse->name, mouse->phys);
-                vsxxxaa_drop_bytes (mouse, 1);
+                printk(KERN_ERR "%s on %s: Dropping a byte of full buffer.\n",
+                        mouse->name, mouse->phys);
+                vsxxxaa_drop_bytes(mouse, 1);
         }
-        DBG (KERN_INFO "Queueing byte 0x%02x\n", byte);
+
+        DBG(KERN_INFO "Queueing byte 0x%02x\n", byte);
 
         mouse->buf[mouse->count++] = byte;
 }
 
-static void
-vsxxxaa_detection_done (struct vsxxxaa *mouse)
+static void vsxxxaa_detection_done(struct vsxxxaa *mouse)
 {
         switch (mouse->type) {
-                case 0x02:
-                        strlcpy (mouse->name, "DEC VSXXX-AA/-GA mouse",
-                                 sizeof (mouse->name));
-                        break;
-
-                case 0x04:
-                        strlcpy (mouse->name, "DEC VSXXX-AB digitizer",
-                                 sizeof (mouse->name));
-                        break;
-
-                default:
-                        snprintf (mouse->name, sizeof (mouse->name),
-                                  "unknown DEC pointer device (type = 0x%02x)",
-                                  mouse->type);
-                        break;
+        case 0x02:
+                strlcpy(mouse->name, "DEC VSXXX-AA/-GA mouse",
+                        sizeof(mouse->name));
+                break;
+
+        case 0x04:
+                strlcpy(mouse->name, "DEC VSXXX-AB digitizer",
+                        sizeof(mouse->name));
+                break;
+
+        default:
+                snprintf(mouse->name, sizeof(mouse->name),
+                         "unknown DEC pointer device (type = 0x%02x)",
+                         mouse->type);
+                break;
         }
 
-        printk (KERN_INFO
+        printk(KERN_INFO
                 "Found %s version 0x%02x from country 0x%02x on port %s\n",
                 mouse->name, mouse->version, mouse->country, mouse->phys);
 }
@@ -176,42 +175,38 @@ vsxxxaa_detection_done (struct vsxxxaa *mouse)
 /*
  * Returns number of bytes to be dropped, 0 if packet is okay.
  */
-static int
-vsxxxaa_check_packet (struct vsxxxaa *mouse, int packet_len)
+static int vsxxxaa_check_packet(struct vsxxxaa *mouse, int packet_len)
 {
         int i;
 
         /* First byte must be a header byte */
-        if (!IS_HDR_BYTE (mouse->buf[0])) {
-                DBG ("vsck: len=%d, 1st=0x%02x\n", packet_len, mouse->buf[0]);
+        if (!IS_HDR_BYTE(mouse->buf[0])) {
+                DBG("vsck: len=%d, 1st=0x%02x\n", packet_len, mouse->buf[0]);
                 return 1;
         }
 
         /* Check all following bytes */
-        if (packet_len > 1) {
-                for (i = 1; i < packet_len; i++) {
-                        if (IS_HDR_BYTE (mouse->buf[i])) {
-                                printk (KERN_ERR "Need to drop %d bytes "
-                                                "of a broken packet.\n",
-                                                i - 1);
-                                DBG (KERN_INFO "check: len=%d, b[%d]=0x%02x\n",
-                                                packet_len, i, mouse->buf[i]);
-                                return i - 1;
-                        }
+        for (i = 1; i < packet_len; i++) {
+                if (IS_HDR_BYTE(mouse->buf[i])) {
+                        printk(KERN_ERR
+                                "Need to drop %d bytes of a broken packet.\n",
+                                i - 1);
+                        DBG(KERN_INFO "check: len=%d, b[%d]=0x%02x\n",
+                            packet_len, i, mouse->buf[i]);
+                        return i - 1;
                 }
         }
 
         return 0;
 }
 
-static __inline__ int
-vsxxxaa_smells_like_packet (struct vsxxxaa *mouse, unsigned char type, size_t len)
+static inline int vsxxxaa_smells_like_packet(struct vsxxxaa *mouse,
+                                             unsigned char type, size_t len)
 {
-        return (mouse->count >= len) && MATCH_PACKET_TYPE (mouse->buf[0], type);
+        return mouse->count >= len && MATCH_PACKET_TYPE(mouse->buf[0], type);
 }
 
-static void
-vsxxxaa_handle_REL_packet (struct vsxxxaa *mouse)
+static void vsxxxaa_handle_REL_packet(struct vsxxxaa *mouse)
 {
         struct input_dev *dev = mouse->dev;
         unsigned char *buf = mouse->buf;
@@ -232,43 +227,42 @@ vsxxxaa_handle_REL_packet (struct vsxxxaa *mouse)
          * 0, bit 4 of byte 0 is direction.
          */
         dx = buf[1] & 0x7f;
-        dx *= ((buf[0] >> 4) & 0x01)? 1: -1;
+        dx *= ((buf[0] >> 4) & 0x01) ? 1 : -1;
 
         /*
          * Low 7 bit of byte 2 are abs(dy), bit 7 is
          * 0, bit 3 of byte 0 is direction.
          */
         dy = buf[2] & 0x7f;
-        dy *= ((buf[0] >> 3) & 0x01)? -1: 1;
+        dy *= ((buf[0] >> 3) & 0x01) ? -1 : 1;
 
         /*
          * Get button state. It's the low three bits
          * (for three buttons) of byte 0.
          */
-        left    = (buf[0] & 0x04)? 1: 0;
-        middle  = (buf[0] & 0x02)? 1: 0;
-        right   = (buf[0] & 0x01)? 1: 0;
+        left    = buf[0] & 0x04;
+        middle  = buf[0] & 0x02;
+        right   = buf[0] & 0x01;
 
-        vsxxxaa_drop_bytes (mouse, 3);
+        vsxxxaa_drop_bytes(mouse, 3);
 
-        DBG (KERN_INFO "%s on %s: dx=%d, dy=%d, buttons=%s%s%s\n",
-                        mouse->name, mouse->phys, dx, dy,
-                        left? "L": "l", middle? "M": "m", right? "R": "r");
+        DBG(KERN_INFO "%s on %s: dx=%d, dy=%d, buttons=%s%s%s\n",
+            mouse->name, mouse->phys, dx, dy,
+            left ? "L" : "l", middle ? "M" : "m", right ? "R" : "r");
 
         /*
          * Report what we've found so far...
          */
-        input_report_key (dev, BTN_LEFT, left);
-        input_report_key (dev, BTN_MIDDLE, middle);
-        input_report_key (dev, BTN_RIGHT, right);
-        input_report_key (dev, BTN_TOUCH, 0);
-        input_report_rel (dev, REL_X, dx);
-        input_report_rel (dev, REL_Y, dy);
-        input_sync (dev);
+        input_report_key(dev, BTN_LEFT, left);
+        input_report_key(dev, BTN_MIDDLE, middle);
+        input_report_key(dev, BTN_RIGHT, right);
+        input_report_key(dev, BTN_TOUCH, 0);
+        input_report_rel(dev, REL_X, dx);
+        input_report_rel(dev, REL_Y, dy);
+        input_sync(dev);
 }
 
-static void
-vsxxxaa_handle_ABS_packet (struct vsxxxaa *mouse)
+static void vsxxxaa_handle_ABS_packet(struct vsxxxaa *mouse)
 {
         struct input_dev *dev = mouse->dev;
         unsigned char *buf = mouse->buf;
@@ -296,32 +290,31 @@ vsxxxaa_handle_ABS_packet (struct vsxxxaa *mouse)
         /*
          * Get button state. It's bits <4..1> of byte 0.
          */
-        left    = (buf[0] & 0x02)? 1: 0;
-        middle  = (buf[0] & 0x04)? 1: 0;
-        right   = (buf[0] & 0x08)? 1: 0;
-        touch   = (buf[0] & 0x10)? 1: 0;
+        left    = buf[0] & 0x02;
+        middle  = buf[0] & 0x04;
+        right   = buf[0] & 0x08;
+        touch   = buf[0] & 0x10;
 
-        vsxxxaa_drop_bytes (mouse, 5);
+        vsxxxaa_drop_bytes(mouse, 5);
 
-        DBG (KERN_INFO "%s on %s: x=%d, y=%d, buttons=%s%s%s%s\n",
-                        mouse->name, mouse->phys, x, y,
-                        left? "L": "l", middle? "M": "m",
-                        right? "R": "r", touch? "T": "t");
+        DBG(KERN_INFO "%s on %s: x=%d, y=%d, buttons=%s%s%s%s\n",
+            mouse->name, mouse->phys, x, y,
+            left ? "L" : "l", middle ? "M" : "m",
+            right ? "R" : "r", touch ? "T" : "t");
 
         /*
          * Report what we've found so far...
          */
-        input_report_key (dev, BTN_LEFT, left);
-        input_report_key (dev, BTN_MIDDLE, middle);
-        input_report_key (dev, BTN_RIGHT, right);
-        input_report_key (dev, BTN_TOUCH, touch);
-        input_report_abs (dev, ABS_X, x);
-        input_report_abs (dev, ABS_Y, y);
-        input_sync (dev);
+        input_report_key(dev, BTN_LEFT, left);
+        input_report_key(dev, BTN_MIDDLE, middle);
+        input_report_key(dev, BTN_RIGHT, right);
+        input_report_key(dev, BTN_TOUCH, touch);
+        input_report_abs(dev, ABS_X, x);
+        input_report_abs(dev, ABS_Y, y);
+        input_sync(dev);
 }
 
-static void
-vsxxxaa_handle_POR_packet (struct vsxxxaa *mouse)
+static void vsxxxaa_handle_POR_packet(struct vsxxxaa *mouse)
 {
         struct input_dev *dev = mouse->dev;
         unsigned char *buf = mouse->buf;
@@ -356,24 +349,24 @@ vsxxxaa_handle_POR_packet (struct vsxxxaa *mouse)
          * (for three buttons) of byte 0. Maybe even the bit <3>
          * has some meaning if a tablet is attached.
          */
-        left    = (buf[0] & 0x04)? 1: 0;
-        middle  = (buf[0] & 0x02)? 1: 0;
-        right   = (buf[0] & 0x01)? 1: 0;
+        left    = buf[0] & 0x04;
+        middle  = buf[0] & 0x02;
+        right   = buf[0] & 0x01;
 
-        vsxxxaa_drop_bytes (mouse, 4);
-        vsxxxaa_detection_done (mouse);
+        vsxxxaa_drop_bytes(mouse, 4);
+        vsxxxaa_detection_done(mouse);
 
         if (error <= 0x1f) {
                 /* No (serious) error. Report buttons */
-                input_report_key (dev, BTN_LEFT, left);
-                input_report_key (dev, BTN_MIDDLE, middle);
-                input_report_key (dev, BTN_RIGHT, right);
-                input_report_key (dev, BTN_TOUCH, 0);
-                input_sync (dev);
+                input_report_key(dev, BTN_LEFT, left);
+                input_report_key(dev, BTN_MIDDLE, middle);
+                input_report_key(dev, BTN_RIGHT, right);
+                input_report_key(dev, BTN_TOUCH, 0);
+                input_sync(dev);
 
                 if (error != 0)
-                        printk (KERN_INFO "Your %s on %s reports error=0x%02x\n",
-                                        mouse->name, mouse->phys, error);
+                        printk(KERN_INFO "Your %s on %s reports error=0x%02x\n",
+                                mouse->name, mouse->phys, error);
 
         }
 
@@ -381,18 +374,18 @@ vsxxxaa_handle_POR_packet (struct vsxxxaa *mouse)
          * If the mouse was hot-plugged, we need to force differential mode
          * now... However, give it a second to recover from it's reset.
          */
-        printk (KERN_NOTICE "%s on %s: Forceing standard packet format, "
-                        "incremental streaming mode and 72 samples/sec\n",
-                        mouse->name, mouse->phys);
-        serio_write (mouse->serio, 'S');        /* Standard format */
-        mdelay (50);
-        serio_write (mouse->serio, 'R');        /* Incremental */
-        mdelay (50);
-        serio_write (mouse->serio, 'L');        /* 72 samples/sec */
+        printk(KERN_NOTICE
+                "%s on %s: Forcing standard packet format, "
+                "incremental streaming mode and 72 samples/sec\n",
+                mouse->name, mouse->phys);
+        serio_write(mouse->serio, 'S'); /* Standard format */
+        mdelay(50);
+        serio_write(mouse->serio, 'R'); /* Incremental */
+        mdelay(50);
+        serio_write(mouse->serio, 'L'); /* 72 samples/sec */
 }
 
-static void
-vsxxxaa_parse_buffer (struct vsxxxaa *mouse)
+static void vsxxxaa_parse_buffer(struct vsxxxaa *mouse)
 {
         unsigned char *buf = mouse->buf;
         int stray_bytes;
@@ -409,122 +402,107 @@ vsxxxaa_parse_buffer (struct vsxxxaa *mouse)
                  * activity on the mouse.
                  */
                 while (mouse->count > 0 && !IS_HDR_BYTE(buf[0])) {
-                        printk (KERN_ERR "%s on %s: Dropping a byte to regain "
-                                        "sync with mouse data stream...\n",
-                                        mouse->name, mouse->phys);
-                        vsxxxaa_drop_bytes (mouse, 1);
+                        printk(KERN_ERR "%s on %s: Dropping a byte to regain "
+                                "sync with mouse data stream...\n",
+                                mouse->name, mouse->phys);
+                        vsxxxaa_drop_bytes(mouse, 1);
                 }
 
                 /*
                  * Check for packets we know about.
                  */
 
-                if (vsxxxaa_smells_like_packet (mouse, VSXXXAA_PACKET_REL, 3)) {
+                if (vsxxxaa_smells_like_packet(mouse, VSXXXAA_PACKET_REL, 3)) {
                         /* Check for broken packet */
-                        stray_bytes = vsxxxaa_check_packet (mouse, 3);
-                        if (stray_bytes > 0) {
-                                printk (KERN_ERR "Dropping %d bytes now...\n",
-                                                stray_bytes);
-                                vsxxxaa_drop_bytes (mouse, stray_bytes);
-                                continue;
-                        }
-
-                        vsxxxaa_handle_REL_packet (mouse);
-                        continue; /* More to parse? */
-                }
+                        stray_bytes = vsxxxaa_check_packet(mouse, 3);
+                        if (!stray_bytes)
+                                vsxxxaa_handle_REL_packet(mouse);
 
-                if (vsxxxaa_smells_like_packet (mouse, VSXXXAA_PACKET_ABS, 5)) {
+                } else if (vsxxxaa_smells_like_packet(mouse,
+                                                      VSXXXAA_PACKET_ABS, 5)) {
                         /* Check for broken packet */
-                        stray_bytes = vsxxxaa_check_packet (mouse, 5);
-                        if (stray_bytes > 0) {
-                                printk (KERN_ERR "Dropping %d bytes now...\n",
-                                                stray_bytes);
-                                vsxxxaa_drop_bytes (mouse, stray_bytes);
-                                continue;
-                        }
-
-                        vsxxxaa_handle_ABS_packet (mouse);
-                        continue; /* More to parse? */
-                }
+                        stray_bytes = vsxxxaa_check_packet(mouse, 5);
+                        if (!stray_bytes)
+                                vsxxxaa_handle_ABS_packet(mouse);
 
-                if (vsxxxaa_smells_like_packet (mouse, VSXXXAA_PACKET_POR, 4)) {
+                } else if (vsxxxaa_smells_like_packet(mouse,
+                                                      VSXXXAA_PACKET_POR, 4)) {
                         /* Check for broken packet */
-                        stray_bytes = vsxxxaa_check_packet (mouse, 4);
-                        if (stray_bytes > 0) {
-                                printk (KERN_ERR "Dropping %d bytes now...\n",
-                                                stray_bytes);
-                                vsxxxaa_drop_bytes (mouse, stray_bytes);
-                                continue;
-                        }
-
-                        vsxxxaa_handle_POR_packet (mouse);
-                        continue; /* More to parse? */
+                        stray_bytes = vsxxxaa_check_packet(mouse, 4);
+                        if (!stray_bytes)
+                                vsxxxaa_handle_POR_packet(mouse);
+
+                } else {
+                        break; /* No REL, ABS or POR packet found */
+                }
+
+                if (stray_bytes > 0) {
+                        printk(KERN_ERR "Dropping %d bytes now...\n",
+                                stray_bytes);
+                        vsxxxaa_drop_bytes(mouse, stray_bytes);
                 }
 
-                break; /* No REL, ABS or POR packet found */
         } while (1);
 }
 
-static irqreturn_t
-vsxxxaa_interrupt (struct serio *serio, unsigned char data, unsigned int flags)
+static irqreturn_t vsxxxaa_interrupt(struct serio *serio,
+                                     unsigned char data, unsigned int flags)
 {
-        struct vsxxxaa *mouse = serio_get_drvdata (serio);
+        struct vsxxxaa *mouse = serio_get_drvdata(serio);
 
-        vsxxxaa_queue_byte (mouse, data);
-        vsxxxaa_parse_buffer (mouse);
+        vsxxxaa_queue_byte(mouse, data);
+        vsxxxaa_parse_buffer(mouse);
 
         return IRQ_HANDLED;
 }
 
-static void
-vsxxxaa_disconnect (struct serio *serio)
+static void vsxxxaa_disconnect(struct serio *serio)
 {
-        struct vsxxxaa *mouse = serio_get_drvdata (serio);
+        struct vsxxxaa *mouse = serio_get_drvdata(serio);
 
-        serio_close (serio);
-        serio_set_drvdata (serio, NULL);
-        input_unregister_device (mouse->dev);
-        kfree (mouse);
+        serio_close(serio);
+        serio_set_drvdata(serio, NULL);
+        input_unregister_device(mouse->dev);
+        kfree(mouse);
 }
 
-static int
-vsxxxaa_connect (struct serio *serio, struct serio_driver *drv)
+static int vsxxxaa_connect(struct serio *serio, struct serio_driver *drv)
 {
         struct vsxxxaa *mouse;
         struct input_dev *input_dev;
         int err = -ENOMEM;
 
-        mouse = kzalloc (sizeof (struct vsxxxaa), GFP_KERNEL);
-        input_dev = input_allocate_device ();
+        mouse = kzalloc(sizeof(struct vsxxxaa), GFP_KERNEL);
+        input_dev = input_allocate_device();
         if (!mouse || !input_dev)
                 goto fail1;
 
         mouse->dev = input_dev;
         mouse->serio = serio;
-        strlcat (mouse->name, "DEC VSXXX-AA/-GA mouse or VSXXX-AB digitizer",
-                 sizeof (mouse->name));
-        snprintf (mouse->phys, sizeof (mouse->phys), "%s/input0", serio->phys);
+        strlcat(mouse->name, "DEC VSXXX-AA/-GA mouse or VSXXX-AB digitizer",
+                 sizeof(mouse->name));
+        snprintf(mouse->phys, sizeof(mouse->phys), "%s/input0", serio->phys);
 
         input_dev->name = mouse->name;
         input_dev->phys = mouse->phys;
         input_dev->id.bustype = BUS_RS232;
         input_dev->dev.parent = &serio->dev;
 
-        set_bit (EV_KEY, input_dev->evbit);             /* We have buttons */
-        set_bit (EV_REL, input_dev->evbit);
-        set_bit (EV_ABS, input_dev->evbit);
-        set_bit (BTN_LEFT, input_dev->keybit);          /* We have 3 buttons */
-        set_bit (BTN_MIDDLE, input_dev->keybit);
-        set_bit (BTN_RIGHT, input_dev->keybit);
-        set_bit (BTN_TOUCH, input_dev->keybit);         /* ...and Tablet */
-        set_bit (REL_X, input_dev->relbit);
-        set_bit (REL_Y, input_dev->relbit);
-        input_set_abs_params (input_dev, ABS_X, 0, 1023, 0, 0);
-        input_set_abs_params (input_dev, ABS_Y, 0, 1023, 0, 0);
-
-        serio_set_drvdata (serio, mouse);
-
-        err = serio_open (serio, drv);
+        __set_bit(EV_KEY, input_dev->evbit);            /* We have buttons */
+        __set_bit(EV_REL, input_dev->evbit);
+        __set_bit(EV_ABS, input_dev->evbit);
+        __set_bit(BTN_LEFT, input_dev->keybit);         /* We have 3 buttons */
+        __set_bit(BTN_MIDDLE, input_dev->keybit);
+        __set_bit(BTN_RIGHT, input_dev->keybit);
+        __set_bit(BTN_TOUCH, input_dev->keybit);        /* ...and Tablet */
+        __set_bit(REL_X, input_dev->relbit);
+        __set_bit(REL_Y, input_dev->relbit);
+        input_set_abs_params(input_dev, ABS_X, 0, 1023, 0, 0);
+        input_set_abs_params(input_dev, ABS_Y, 0, 1023, 0, 0);
+
+        serio_set_drvdata(serio, mouse);
+
+        err = serio_open(serio, drv);
         if (err)
                 goto fail2;
 
@@ -532,18 +510,18 @@ vsxxxaa_connect (struct serio *serio, struct serio_driver *drv)
          * Request selftest. Standard packet format and differential
          * mode will be requested after the device ID'ed successfully.
          */
-        serio_write (serio, 'T'); /* Test */
+        serio_write(serio, 'T'); /* Test */
 
-        err = input_register_device (input_dev);
+        err = input_register_device(input_dev);
         if (err)
                 goto fail3;
 
         return 0;
 
- fail3: serio_close (serio);
- fail2: serio_set_drvdata (serio, NULL);
- fail1: input_free_device (input_dev);
-        kfree (mouse);
+ fail3: serio_close(serio);
+ fail2: serio_set_drvdata(serio, NULL);
+ fail1: input_free_device(input_dev);
+        kfree(mouse);
         return err;
 }
 
@@ -570,18 +548,16 @@ static struct serio_driver vsxxxaa_drv = {
         .disconnect     = vsxxxaa_disconnect,
 };
 
-static int __init
-vsxxxaa_init (void)
+static int __init vsxxxaa_init(void)
 {
         return serio_register_driver(&vsxxxaa_drv);
 }
 
-static void __exit
-vsxxxaa_exit (void)
+static void __exit vsxxxaa_exit(void)
 {
         serio_unregister_driver(&vsxxxaa_drv);
 }
 
-module_init (vsxxxaa_init);
-module_exit (vsxxxaa_exit);
+module_init(vsxxxaa_init);
+module_exit(vsxxxaa_exit);
 
diff --git a/drivers/input/mousedev.c b/drivers/input/mousedev.c
index a13d80f7da17..f34b22bce4ff 100644
--- a/drivers/input/mousedev.c
+++ b/drivers/input/mousedev.c
@@ -15,7 +15,6 @@
 
 #include <linux/sched.h>
 #include <linux/slab.h>
-#include <linux/smp_lock.h>
 #include <linux/poll.h>
 #include <linux/module.h>
 #include <linux/init.h>
@@ -542,10 +541,8 @@ static int mousedev_open(struct inode *inode, struct file *file)
         if (i >= MOUSEDEV_MINORS)
                 return -ENODEV;
 
-        lock_kernel();
         error = mutex_lock_interruptible(&mousedev_table_mutex);
         if (error) {
-                unlock_kernel();
                 return error;
         }
         mousedev = mousedev_table[i];
@@ -554,7 +551,6 @@ static int mousedev_open(struct inode *inode, struct file *file)
         mutex_unlock(&mousedev_table_mutex);
 
         if (!mousedev) {
-                unlock_kernel();
                 return -ENODEV;
         }
 
@@ -575,7 +571,6 @@ static int mousedev_open(struct inode *inode, struct file *file)
                 goto err_free_client;
 
         file->private_data = client;
-        unlock_kernel();
         return 0;
 
  err_free_client:
@@ -583,7 +578,6 @@ static int mousedev_open(struct inode *inode, struct file *file)
         kfree(client);
  err_put_mousedev:
         put_device(&mousedev->dev);
-        unlock_kernel();
         return error;
 }
 
diff --git a/drivers/input/serio/Kconfig b/drivers/input/serio/Kconfig
index aa533ceffe34..7e319d65ec57 100644
--- a/drivers/input/serio/Kconfig
+++ b/drivers/input/serio/Kconfig
@@ -201,4 +201,12 @@ config SERIO_XILINX_XPS_PS2
           To compile this driver as a module, choose M here: the
           module will be called xilinx_ps2.
 
+config SERIO_ALTERA_PS2
+        tristate "Altera UP PS/2 controller"
+        help
+          Say Y here if you have Altera University Program PS/2 ports.
+
+          To compile this driver as a module, choose M here: the
+          module will be called altera_ps2.
+
 endif
diff --git a/drivers/input/serio/Makefile b/drivers/input/serio/Makefile
index 9b6c8135955f..bf945f789d05 100644
--- a/drivers/input/serio/Makefile
+++ b/drivers/input/serio/Makefile
@@ -22,3 +22,4 @@ obj-$(CONFIG_SERIO_MACEPS2)	+= maceps2.o
 obj-$(CONFIG_SERIO_LIBPS2)      += libps2.o
 obj-$(CONFIG_SERIO_RAW)         += serio_raw.o
 obj-$(CONFIG_SERIO_XILINX_XPS_PS2)      += xilinx_ps2.o
+obj-$(CONFIG_SERIO_ALTERA_PS2)  += altera_ps2.o
diff --git a/drivers/input/serio/altera_ps2.c b/drivers/input/serio/altera_ps2.c
new file mode 100644
index 000000000000..7998560a1904
--- /dev/null
+++ b/drivers/input/serio/altera_ps2.c
@@ -0,0 +1,204 @@
+/*
+ * Altera University Program PS2 controller driver
+ *
+ * Copyright (C) 2008 Thomas Chou <thomas@wytron.com.tw>
+ *
+ * Based on sa1111ps2.c, which is:
+ * Copyright (C) 2002 Russell King
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ */
+
+#include <linux/module.h>
+#include <linux/init.h>
+#include <linux/input.h>
+#include <linux/serio.h>
+#include <linux/interrupt.h>
+#include <linux/platform_device.h>
+#include <linux/io.h>
+#include <linux/slab.h>
+
+#define DRV_NAME "altera_ps2"
+
+struct ps2if {
+        struct serio *io;
+        struct resource *iomem_res;
+        void __iomem *base;
+        unsigned irq;
+};
+
+/*
+ * Read all bytes waiting in the PS2 port.  There should be
+ * at the most one, but we loop for safety.
+ */
+static irqreturn_t altera_ps2_rxint(int irq, void *dev_id)
+{
+        struct ps2if *ps2if = dev_id;
+        unsigned int status;
+        int handled = IRQ_NONE;
+
+        while ((status = readl(ps2if->base)) & 0xffff0000) {
+                serio_interrupt(ps2if->io, status & 0xff, 0);
+                handled = IRQ_HANDLED;
+        }
+
+        return handled;
+}
+
+/*
+ * Write a byte to the PS2 port.
+ */
+static int altera_ps2_write(struct serio *io, unsigned char val)
+{
+        struct ps2if *ps2if = io->port_data;
+
+        writel(val, ps2if->base);
+        return 0;
+}
+
+static int altera_ps2_open(struct serio *io)
+{
+        struct ps2if *ps2if = io->port_data;
+
+        /* clear fifo */
+        while (readl(ps2if->base) & 0xffff0000)
+                /* empty */;
+
+        writel(1, ps2if->base + 4); /* enable rx irq */
+        return 0;
+}
+
+static void altera_ps2_close(struct serio *io)
+{
+        struct ps2if *ps2if = io->port_data;
+
+        writel(0, ps2if->base); /* disable rx irq */
+}
+
+/*
+ * Add one device to this driver.
+ */
+static int __devinit altera_ps2_probe(struct platform_device *pdev)
+{
+        struct ps2if *ps2if;
+        struct serio *serio;
+        int error, irq;
+
+        ps2if = kzalloc(sizeof(struct ps2if), GFP_KERNEL);
+        serio = kzalloc(sizeof(struct serio), GFP_KERNEL);
+        if (!ps2if || !serio) {
+                error = -ENOMEM;
+                goto err_free_mem;
+        }
+
+        serio->id.type          = SERIO_8042;
+        serio->write            = altera_ps2_write;
+        serio->open             = altera_ps2_open;
+        serio->close            = altera_ps2_close;
+        strlcpy(serio->name, dev_name(&pdev->dev), sizeof(serio->name));
+        strlcpy(serio->phys, dev_name(&pdev->dev), sizeof(serio->phys));
+        serio->port_data        = ps2if;
+        serio->dev.parent       = &pdev->dev;
+        ps2if->io               = serio;
+
+        ps2if->iomem_res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
+        if (ps2if->iomem_res == NULL) {
+                error = -ENOENT;
+                goto err_free_mem;
+        }
+
+
+        irq = platform_get_irq(pdev, 0);
+        if (irq < 0) {
+                error = -ENXIO;
+                goto err_free_mem;
+        }
+        ps2if->irq = irq;
+
+        if (!request_mem_region(ps2if->iomem_res->start,
+                                resource_size(ps2if->iomem_res), pdev->name)) {
+                error = -EBUSY;
+                goto err_free_mem;
+        }
+
+        ps2if->base = ioremap(ps2if->iomem_res->start,
+                              resource_size(ps2if->iomem_res));
+        if (!ps2if->base) {
+                error = -ENOMEM;
+                goto err_free_res;
+        }
+
+        error = request_irq(ps2if->irq, altera_ps2_rxint, 0, pdev->name, ps2if);
+        if (error) {
+                dev_err(&pdev->dev, "could not allocate IRQ %d: %d\n",
+                        ps2if->irq, error);
+                goto err_unmap;
+        }
+
+        dev_info(&pdev->dev, "base %p, irq %d\n", ps2if->base, ps2if->irq);
+
+        serio_register_port(ps2if->io);
+        platform_set_drvdata(pdev, ps2if);
+
+        return 0;
+
+ err_unmap:
+        iounmap(ps2if->base);
+ err_free_res:
+        release_mem_region(ps2if->iomem_res->start,
+                           resource_size(ps2if->iomem_res));
+ err_free_mem:
+        kfree(ps2if);
+        kfree(serio);
+        return error;
+}
+
+/*
+ * Remove one device from this driver.
+ */
+static int __devexit altera_ps2_remove(struct platform_device *pdev)
+{
+        struct ps2if *ps2if = platform_get_drvdata(pdev);
+
+        platform_set_drvdata(pdev, NULL);
+        serio_unregister_port(ps2if->io);
+        free_irq(ps2if->irq, ps2if);
+        iounmap(ps2if->base);
+        release_mem_region(ps2if->iomem_res->start,
+                           resource_size(ps2if->iomem_res));
+        kfree(ps2if);
+
+        return 0;
+}
+
+/*
+ * Our device driver structure
+ */
+static struct platform_driver altera_ps2_driver = {
+        .probe          = altera_ps2_probe,
+        .remove         = __devexit_p(altera_ps2_remove),
+        .driver = {
+                .name   = DRV_NAME,
+                .owner  = THIS_MODULE,
+        },
+};
+
+static int __init altera_ps2_init(void)
+{
+        return platform_driver_register(&altera_ps2_driver);
+}
+
+static void __exit altera_ps2_exit(void)
+{
+        platform_driver_unregister(&altera_ps2_driver);
+}
+
+module_init(altera_ps2_init);
+module_exit(altera_ps2_exit);
+
+MODULE_DESCRIPTION("Altera University Program PS2 controller driver");
+MODULE_AUTHOR("Thomas Chou <thomas@wytron.com.tw>");
+MODULE_LICENSE("GPL");
+MODULE_ALIAS("platform:" DRV_NAME);
diff --git a/drivers/input/serio/ambakmi.c b/drivers/input/serio/ambakmi.c
index 89b394183a75..92563a681d65 100644
--- a/drivers/input/serio/ambakmi.c
+++ b/drivers/input/serio/ambakmi.c
@@ -107,7 +107,7 @@ static void amba_kmi_close(struct serio *io)
         clk_disable(kmi->clk);
 }
 
-static int amba_kmi_probe(struct amba_device *dev, struct amba_id *id)
+static int __devinit amba_kmi_probe(struct amba_device *dev, struct amba_id *id)
 {
         struct amba_kmi_port *kmi;
         struct serio *io;
@@ -134,7 +134,7 @@ static int amba_kmi_probe(struct amba_device *dev, struct amba_id *id)
         io->port_data   = kmi;
         io->dev.parent  = &dev->dev;
 
-        kmi->io         = io;
+        kmi->io         = io;
         kmi->base       = ioremap(dev->res.start, resource_size(&dev->res));
         if (!kmi->base) {
                 ret = -ENOMEM;
@@ -162,7 +162,7 @@ static int amba_kmi_probe(struct amba_device *dev, struct amba_id *id)
         return ret;
 }
 
-static int amba_kmi_remove(struct amba_device *dev)
+static int __devexit amba_kmi_remove(struct amba_device *dev)
 {
         struct amba_kmi_port *kmi = amba_get_drvdata(dev);
 
@@ -197,10 +197,11 @@ static struct amba_id amba_kmi_idtable[] = {
 static struct amba_driver ambakmi_driver = {
         .drv            = {
                 .name   = "kmi-pl050",
+                .owner  = THIS_MODULE,
         },
         .id_table       = amba_kmi_idtable,
         .probe          = amba_kmi_probe,
-        .remove         = amba_kmi_remove,
+        .remove         = __devexit_p(amba_kmi_remove),
         .resume         = amba_kmi_resume,
 };
 
diff --git a/drivers/input/serio/at32psif.c b/drivers/input/serio/at32psif.c
index a6fb7a3dcc46..6ee8f0ddad51 100644
--- a/drivers/input/serio/at32psif.c
+++ b/drivers/input/serio/at32psif.c
@@ -18,6 +18,7 @@
 #include <linux/io.h>
 #include <linux/clk.h>
 #include <linux/platform_device.h>
+#include <linux/slab.h>
 
 /* PSIF register offsets */
 #define PSIF_CR                         0x00
@@ -137,7 +138,7 @@ static int psif_write(struct serio *io, unsigned char val)
         spin_lock_irqsave(&psif->lock, flags);
 
         while (!(psif_readl(psif, SR) & PSIF_BIT(TXEMPTY)) && timeout--)
-                msleep(10);
+                udelay(50);
 
         if (timeout >= 0) {
                 psif_writel(psif, THR, val);
@@ -352,6 +353,7 @@ static struct platform_driver psif_driver = {
         .remove         = __exit_p(psif_remove),
         .driver         = {
                 .name   = "atmel_psif",
+                .owner  = THIS_MODULE,
         },
         .suspend        = psif_suspend,
         .resume         = psif_resume,
diff --git a/drivers/input/serio/ct82c710.c b/drivers/input/serio/ct82c710.c
index d1380fc72cc6..4a3084695c00 100644
--- a/drivers/input/serio/ct82c710.c
+++ b/drivers/input/serio/ct82c710.c
@@ -35,6 +35,7 @@
 #include <linux/errno.h>
 #include <linux/err.h>
 #include <linux/platform_device.h>
+#include <linux/slab.h>
 
 #include <asm/io.h>
 
diff --git a/drivers/input/serio/gscps2.c b/drivers/input/serio/gscps2.c
index bd0f92d9f40f..3c287dd879d3 100644
--- a/drivers/input/serio/gscps2.c
+++ b/drivers/input/serio/gscps2.c
@@ -6,7 +6,7 @@
  * Copyright (c) 2002 Thibaut Varene <varenet@parisc-linux.org>
  *
  * Pieces of code based on linux-2.4's hp_mouse.c & hp_keyb.c
- *      Copyright (c) 1999 Alex deVries <alex@onefishtwo.ca>
+ *      Copyright (c) 1999 Alex deVries <alex@onefishtwo.ca>
  *      Copyright (c) 1999-2000 Philipp Rumpf <prumpf@tux.org>
  *      Copyright (c) 2000 Xavier Debacker <debackex@esiee.fr>
  *      Copyright (c) 2000-2001 Thomas Marteau <marteaut@esiee.fr>
@@ -24,6 +24,7 @@
 
 #include <linux/init.h>
 #include <linux/module.h>
+#include <linux/slab.h>
 #include <linux/serio.h>
 #include <linux/input.h>
 #include <linux/interrupt.h>
@@ -326,7 +327,7 @@ static void gscps2_close(struct serio *port)
  * @return: success/error report
  */
 
-static int __init gscps2_probe(struct parisc_device *dev)
+static int __devinit gscps2_probe(struct parisc_device *dev)
 {
         struct gscps2port *ps2port;
         struct serio *serio;
@@ -443,7 +444,7 @@ static struct parisc_driver parisc_ps2_driver = {
         .name           = "gsc_ps2",
         .id_table       = gscps2_device_tbl,
         .probe          = gscps2_probe,
-        .remove         = gscps2_remove,
+        .remove         = __devexit_p(gscps2_remove),
 };
 
 static int __init gscps2_init(void)
diff --git a/drivers/input/serio/hil_mlc.c b/drivers/input/serio/hil_mlc.c
index 7ba9f2b2c041..c92f4edfee7b 100644
--- a/drivers/input/serio/hil_mlc.c
+++ b/drivers/input/serio/hil_mlc.c
@@ -58,6 +58,7 @@
 #include <linux/module.h>
 #include <linux/init.h>
 #include <linux/interrupt.h>
+#include <linux/slab.h>
 #include <linux/timer.h>
 #include <linux/list.h>
 
@@ -993,10 +994,8 @@ int hil_mlc_unregister(hil_mlc *mlc)
 
 static int __init hil_mlc_init(void)
 {
-        init_timer(&hil_mlcs_kicker);
-        hil_mlcs_kicker.expires = jiffies + HZ;
-        hil_mlcs_kicker.function = &hil_mlcs_timer;
-        add_timer(&hil_mlcs_kicker);
+        setup_timer(&hil_mlcs_kicker, &hil_mlcs_timer, 0);
+        mod_timer(&hil_mlcs_kicker, jiffies + HZ);
 
         tasklet_enable(&hil_mlcs_tasklet);
 
@@ -1005,7 +1004,7 @@ static int __init hil_mlc_init(void)
 
 static void __exit hil_mlc_exit(void)
 {
-        del_timer(&hil_mlcs_kicker);
+        del_timer_sync(&hil_mlcs_kicker);
 
         tasklet_disable(&hil_mlcs_tasklet);
         tasklet_kill(&hil_mlcs_tasklet);
diff --git a/drivers/input/serio/hp_sdc.c b/drivers/input/serio/hp_sdc.c
index 1c9410d1822c..bcc2d30ec245 100644
--- a/drivers/input/serio/hp_sdc.c
+++ b/drivers/input/serio/hp_sdc.c
@@ -955,7 +955,7 @@ static int __init hp_sdc_init_hppa(struct parisc_device *d)
         INIT_DELAYED_WORK(&moduleloader_work, request_module_delayed);
 
         ret = hp_sdc_init();
-        /* after sucessfull initialization give SDC some time to settle
+        /* after successfull initialization give SDC some time to settle
          * and then load the hp_sdc_mlc upper layer driver */
         if (!ret)
                 schedule_delayed_work(&moduleloader_work,
diff --git a/drivers/input/serio/hp_sdc_mlc.c b/drivers/input/serio/hp_sdc_mlc.c
index 820e51673b26..7d2b820ef58d 100644
--- a/drivers/input/serio/hp_sdc_mlc.c
+++ b/drivers/input/serio/hp_sdc_mlc.c
@@ -125,7 +125,7 @@ static void hp_sdc_mlc_isr (int irq, void *dev_id,
                 break;
 
         default:
-                printk(KERN_WARNING PREFIX "Unkown HIL Error status (%x)!\n", data);
+                printk(KERN_WARNING PREFIX "Unknown HIL Error status (%x)!\n", data);
                 break;
         }
 
diff --git a/drivers/input/serio/i8042-x86ia64io.h b/drivers/input/serio/i8042-x86ia64io.h
index 2bcf1ace27c0..ead0494721d0 100644
--- a/drivers/input/serio/i8042-x86ia64io.h
+++ b/drivers/input/serio/i8042-x86ia64io.h
@@ -67,10 +67,12 @@ static inline void i8042_write_command(int val)
 
 #include <linux/dmi.h>
 
-static struct dmi_system_id __initdata i8042_dmi_noloop_table[] = {
+static const struct dmi_system_id __initconst i8042_dmi_noloop_table[] = {
         {
-                /* AUX LOOP command does not raise AUX IRQ */
-                .ident = "Arima-Rioworks HDAMB",
+                /*
+                 * Arima-Rioworks HDAMB -
+                 * AUX LOOP command does not raise AUX IRQ
+                 */
                 .matches = {
                         DMI_MATCH(DMI_BOARD_VENDOR, "RIOWORKS"),
                         DMI_MATCH(DMI_BOARD_NAME, "HDAMB"),
@@ -78,7 +80,7 @@ static struct dmi_system_id __initdata i8042_dmi_noloop_table[] = {
                 },
         },
         {
-                .ident = "ASUS G1S",
+                /* ASUS G1S */
                 .matches = {
                         DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK Computer Inc."),
                         DMI_MATCH(DMI_BOARD_NAME, "G1S"),
@@ -86,8 +88,7 @@ static struct dmi_system_id __initdata i8042_dmi_noloop_table[] = {
                 },
         },
         {
-                /* AUX LOOP command does not raise AUX IRQ */
-                .ident = "ASUS P65UP5",
+                /* ASUS P65UP5 - AUX LOOP command does not raise AUX IRQ */
                 .matches = {
                         DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK Computer INC."),
                         DMI_MATCH(DMI_BOARD_NAME, "P/I-P65UP5"),
@@ -95,7 +96,6 @@ static struct dmi_system_id __initdata i8042_dmi_noloop_table[] = {
                 },
         },
         {
-                .ident = "Compaq Proliant 8500",
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "Compaq"),
                         DMI_MATCH(DMI_PRODUCT_NAME , "ProLiant"),
@@ -103,7 +103,6 @@ static struct dmi_system_id __initdata i8042_dmi_noloop_table[] = {
                 },
         },
         {
-                .ident = "Compaq Proliant DL760",
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "Compaq"),
                         DMI_MATCH(DMI_PRODUCT_NAME , "ProLiant"),
@@ -111,7 +110,7 @@ static struct dmi_system_id __initdata i8042_dmi_noloop_table[] = {
                 },
         },
         {
-                .ident = "OQO Model 01",
+                /* OQO Model 01 */
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "OQO"),
                         DMI_MATCH(DMI_PRODUCT_NAME, "ZEPTO"),
@@ -119,8 +118,7 @@ static struct dmi_system_id __initdata i8042_dmi_noloop_table[] = {
                 },
         },
         {
-                /* AUX LOOP does not work properly */
-                .ident = "ULI EV4873",
+                /* ULI EV4873 - AUX LOOP does not work properly */
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "ULI"),
                         DMI_MATCH(DMI_PRODUCT_NAME, "EV4873"),
@@ -128,7 +126,7 @@ static struct dmi_system_id __initdata i8042_dmi_noloop_table[] = {
                 },
         },
         {
-                .ident = "Microsoft Virtual Machine",
+                /* Microsoft Virtual Machine */
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "Microsoft Corporation"),
                         DMI_MATCH(DMI_PRODUCT_NAME, "Virtual Machine"),
@@ -136,7 +134,7 @@ static struct dmi_system_id __initdata i8042_dmi_noloop_table[] = {
                 },
         },
         {
-                .ident = "Medion MAM 2070",
+                /* Medion MAM 2070 */
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "Notebook"),
                         DMI_MATCH(DMI_PRODUCT_NAME, "MAM 2070"),
@@ -144,7 +142,7 @@ static struct dmi_system_id __initdata i8042_dmi_noloop_table[] = {
                 },
         },
         {
-                .ident = "Blue FB5601",
+                /* Blue FB5601 */
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "blue"),
                         DMI_MATCH(DMI_PRODUCT_NAME, "FB5601"),
@@ -152,7 +150,7 @@ static struct dmi_system_id __initdata i8042_dmi_noloop_table[] = {
                 },
         },
         {
-                .ident = "Gigabyte M912",
+                /* Gigabyte M912 */
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "GIGABYTE"),
                         DMI_MATCH(DMI_PRODUCT_NAME, "M912"),
@@ -160,7 +158,14 @@ static struct dmi_system_id __initdata i8042_dmi_noloop_table[] = {
                 },
         },
         {
-                .ident = "HP DV9700",
+                /* Gigabyte M1022M netbook */
+                .matches = {
+                        DMI_MATCH(DMI_BOARD_VENDOR, "Gigabyte Technology Co.,Ltd."),
+                        DMI_MATCH(DMI_BOARD_NAME, "M1022E"),
+                        DMI_MATCH(DMI_BOARD_VERSION, "1.02"),
+                },
+        },
+        {
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"),
                         DMI_MATCH(DMI_PRODUCT_NAME, "HP Pavilion dv9700"),
@@ -177,72 +182,72 @@ static struct dmi_system_id __initdata i8042_dmi_noloop_table[] = {
  * ... apparently some Toshibas don't like MUX mode either and
  * die horrible death on reboot.
  */
-static struct dmi_system_id __initdata i8042_dmi_nomux_table[] = {
+static const struct dmi_system_id __initconst i8042_dmi_nomux_table[] = {
         {
-                .ident = "Fujitsu Lifebook P7010/P7010D",
+                /* Fujitsu Lifebook P7010/P7010D */
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "FUJITSU"),
                         DMI_MATCH(DMI_PRODUCT_NAME, "P7010"),
                 },
         },
         {
-                .ident = "Fujitsu Lifebook P7010",
+                /* Fujitsu Lifebook P7010 */
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "FUJITSU SIEMENS"),
                         DMI_MATCH(DMI_PRODUCT_NAME, "0000000000"),
                 },
         },
         {
-                .ident = "Fujitsu Lifebook P5020D",
+                /* Fujitsu Lifebook P5020D */
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "FUJITSU"),
                         DMI_MATCH(DMI_PRODUCT_NAME, "LifeBook P Series"),
                 },
         },
         {
-                .ident = "Fujitsu Lifebook S2000",
+                /* Fujitsu Lifebook S2000 */
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "FUJITSU"),
                         DMI_MATCH(DMI_PRODUCT_NAME, "LifeBook S Series"),
                 },
         },
         {
-                .ident = "Fujitsu Lifebook S6230",
+                /* Fujitsu Lifebook S6230 */
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "FUJITSU"),
                         DMI_MATCH(DMI_PRODUCT_NAME, "LifeBook S6230"),
                 },
         },
         {
-                .ident = "Fujitsu T70H",
+                /* Fujitsu T70H */
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "FUJITSU"),
                         DMI_MATCH(DMI_PRODUCT_NAME, "FMVLT70H"),
                 },
         },
         {
-                .ident = "Fujitsu-Siemens Lifebook T3010",
+                /* Fujitsu-Siemens Lifebook T3010 */
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "FUJITSU SIEMENS"),
                         DMI_MATCH(DMI_PRODUCT_NAME, "LIFEBOOK T3010"),
                 },
         },
         {
-                .ident = "Fujitsu-Siemens Lifebook E4010",
+                /* Fujitsu-Siemens Lifebook E4010 */
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "FUJITSU SIEMENS"),
                         DMI_MATCH(DMI_PRODUCT_NAME, "LIFEBOOK E4010"),
                 },
         },
         {
-                .ident = "Fujitsu-Siemens Amilo Pro 2010",
+                /* Fujitsu-Siemens Amilo Pro 2010 */
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "FUJITSU SIEMENS"),
                         DMI_MATCH(DMI_PRODUCT_NAME, "AMILO Pro V2010"),
                 },
         },
         {
-                .ident = "Fujitsu-Siemens Amilo Pro 2030",
+                /* Fujitsu-Siemens Amilo Pro 2030 */
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "FUJITSU SIEMENS"),
                         DMI_MATCH(DMI_PRODUCT_NAME, "AMILO PRO V2030"),
@@ -253,7 +258,7 @@ static struct dmi_system_id __initdata i8042_dmi_nomux_table[] = {
                  * No data is coming from the touchscreen unless KBC
                  * is in legacy mode.
                  */
-                .ident = "Panasonic CF-29",
+                /* Panasonic CF-29 */
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "Matsushita"),
                         DMI_MATCH(DMI_PRODUCT_NAME, "CF-29"),
@@ -261,10 +266,10 @@ static struct dmi_system_id __initdata i8042_dmi_nomux_table[] = {
         },
         {
                 /*
-                 * Errors on MUX ports are reported without raising AUXDATA
+                 * HP Pavilion DV4017EA -
+                 * errors on MUX ports are reported without raising AUXDATA
                  * causing "spurious NAK" messages.
                  */
-                .ident = "HP Pavilion DV4017EA",
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"),
                         DMI_MATCH(DMI_PRODUCT_NAME, "Pavilion dv4000 (EA032EA#ABF)"),
@@ -272,9 +277,9 @@ static struct dmi_system_id __initdata i8042_dmi_nomux_table[] = {
         },
         {
                 /*
-                 * Like DV4017EA does not raise AUXERR for errors on MUX ports.
+                 * HP Pavilion ZT1000 -
+                 * like DV4017EA does not raise AUXERR for errors on MUX ports.
                  */
-                .ident = "HP Pavilion ZT1000",
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"),
                         DMI_MATCH(DMI_PRODUCT_NAME, "HP Pavilion Notebook PC"),
@@ -283,44 +288,41 @@ static struct dmi_system_id __initdata i8042_dmi_nomux_table[] = {
         },
         {
                 /*
-                 * Like DV4017EA does not raise AUXERR for errors on MUX ports.
+                 * HP Pavilion DV4270ca -
+                 * like DV4017EA does not raise AUXERR for errors on MUX ports.
                  */
-                .ident = "HP Pavilion DV4270ca",
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"),
                         DMI_MATCH(DMI_PRODUCT_NAME, "Pavilion dv4000 (EH476UA#ABL)"),
                 },
         },
         {
-                .ident = "Toshiba P10",
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "TOSHIBA"),
                         DMI_MATCH(DMI_PRODUCT_NAME, "Satellite P10"),
                 },
         },
         {
-                .ident = "Toshiba Equium A110",
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "TOSHIBA"),
                         DMI_MATCH(DMI_PRODUCT_NAME, "EQUIUM A110"),
                 },
         },
         {
-                .ident = "Alienware Sentia",
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "ALIENWARE"),
                         DMI_MATCH(DMI_PRODUCT_NAME, "Sentia"),
                 },
         },
         {
-                .ident = "Sharp Actius MM20",
+                /* Sharp Actius MM20 */
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "SHARP"),
                         DMI_MATCH(DMI_PRODUCT_NAME, "PC-MM20 Series"),
                 },
         },
         {
-                .ident = "Sony Vaio FS-115b",
+                /* Sony Vaio FS-115b */
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "Sony Corporation"),
                         DMI_MATCH(DMI_PRODUCT_NAME, "VGN-FS115B"),
@@ -328,73 +330,72 @@ static struct dmi_system_id __initdata i8042_dmi_nomux_table[] = {
         },
         {
                 /*
-                 * Reset and GET ID commands issued via KBD port are
+                 * Sony Vaio FZ-240E -
+                 * reset and GET ID commands issued via KBD port are
                  * sometimes being delivered to AUX3.
                  */
-                .ident = "Sony Vaio FZ-240E",
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "Sony Corporation"),
                         DMI_MATCH(DMI_PRODUCT_NAME, "VGN-FZ240E"),
                 },
         },
         {
-                .ident = "Amoi M636/A737",
+                /* Amoi M636/A737 */
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "Amoi Electronics CO.,LTD."),
                         DMI_MATCH(DMI_PRODUCT_NAME, "M636/A737 platform"),
                 },
         },
         {
-                .ident = "Lenovo 3000 n100",
+                /* Lenovo 3000 n100 */
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
                         DMI_MATCH(DMI_PRODUCT_NAME, "076804U"),
                 },
         },
         {
-                .ident = "Acer Aspire 1360",
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "Acer"),
                         DMI_MATCH(DMI_PRODUCT_NAME, "Aspire 1360"),
                 },
         },
         {
-                .ident = "Gericom Bellagio",
+                /* Gericom Bellagio */
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "Gericom"),
                         DMI_MATCH(DMI_PRODUCT_NAME, "N34AS6"),
                 },
         },
         {
-                .ident = "IBM 2656",
+                /* IBM 2656 */
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "IBM"),
                         DMI_MATCH(DMI_PRODUCT_NAME, "2656"),
                 },
         },
         {
-                .ident = "Dell XPS M1530",
+                /* Dell XPS M1530 */
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
                         DMI_MATCH(DMI_PRODUCT_NAME, "XPS M1530"),
                 },
         },
         {
-                .ident = "Compal HEL80I",
+                /* Compal HEL80I */
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "COMPAL"),
                         DMI_MATCH(DMI_PRODUCT_NAME, "HEL80I"),
                 },
         },
         {
-                .ident = "Dell Vostro 1510",
+                /* Dell Vostro 1510 */
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
                         DMI_MATCH(DMI_PRODUCT_NAME, "Vostro1510"),
                 },
         },
         {
-                .ident = "Acer Aspire 5536",
+                /* Acer Aspire 5536 */
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "Acer"),
                         DMI_MATCH(DMI_PRODUCT_NAME, "Aspire 5536"),
@@ -404,65 +405,72 @@ static struct dmi_system_id __initdata i8042_dmi_nomux_table[] = {
         { }
 };
 
-static struct dmi_system_id __initdata i8042_dmi_reset_table[] = {
+static const struct dmi_system_id __initconst i8042_dmi_reset_table[] = {
         {
-                .ident = "MSI Wind U-100",
+                /* MSI Wind U-100 */
                 .matches = {
                         DMI_MATCH(DMI_BOARD_NAME, "U-100"),
                         DMI_MATCH(DMI_BOARD_VENDOR, "MICRO-STAR INTERNATIONAL CO., LTD"),
                 },
         },
         {
-                .ident = "LG Electronics X110",
+                /* LG Electronics X110 */
                 .matches = {
                         DMI_MATCH(DMI_BOARD_NAME, "X110"),
                         DMI_MATCH(DMI_BOARD_VENDOR, "LG Electronics Inc."),
                 },
         },
         {
-                .ident = "Acer Aspire One 150",
+                /* Acer Aspire One 150 */
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "Acer"),
                         DMI_MATCH(DMI_PRODUCT_NAME, "AOA150"),
                 },
         },
         {
-                .ident = "Advent 4211",
+                /* Advent 4211 */
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "DIXONSXP"),
                         DMI_MATCH(DMI_PRODUCT_NAME, "Advent 4211"),
                 },
         },
         {
-                .ident = "Medion Akoya Mini E1210",
+                /* Medion Akoya Mini E1210 */
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "MEDION"),
                         DMI_MATCH(DMI_PRODUCT_NAME, "E1210"),
                 },
         },
         {
-                .ident = "Mivvy M310",
+                /* Medion Akoya E1222 */
+                .matches = {
+                        DMI_MATCH(DMI_SYS_VENDOR, "MEDION"),
+                        DMI_MATCH(DMI_PRODUCT_NAME, "E122X"),
+                },
+        },
+        {
+                /* Mivvy M310 */
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "VIOOO"),
                         DMI_MATCH(DMI_PRODUCT_NAME, "N10"),
                 },
         },
         {
-                .ident = "Dell Vostro 1320",
+                /* Dell Vostro 1320 */
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
                         DMI_MATCH(DMI_PRODUCT_NAME, "Vostro 1320"),
                 },
         },
         {
-                .ident = "Dell Vostro 1520",
+                /* Dell Vostro 1520 */
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
                         DMI_MATCH(DMI_PRODUCT_NAME, "Vostro 1520"),
                 },
         },
         {
-                .ident = "Dell Vostro 1720",
+                /* Dell Vostro 1720 */
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
                         DMI_MATCH(DMI_PRODUCT_NAME, "Vostro 1720"),
@@ -472,16 +480,16 @@ static struct dmi_system_id __initdata i8042_dmi_reset_table[] = {
 };
 
 #ifdef CONFIG_PNP
-static struct dmi_system_id __initdata i8042_dmi_nopnp_table[] = {
+static const struct dmi_system_id __initconst i8042_dmi_nopnp_table[] = {
         {
-                .ident = "Intel MBO Desktop D845PESV",
+                /* Intel MBO Desktop D845PESV */
                 .matches = {
                         DMI_MATCH(DMI_BOARD_NAME, "D845PESV"),
                         DMI_MATCH(DMI_BOARD_VENDOR, "Intel Corporation"),
                 },
         },
         {
-                .ident = "MSI Wind U-100",
+                /* MSI Wind U-100 */
                 .matches = {
                         DMI_MATCH(DMI_BOARD_NAME, "U-100"),
                         DMI_MATCH(DMI_BOARD_VENDOR, "MICRO-STAR INTERNATIONAL CO., LTD"),
@@ -490,27 +498,23 @@ static struct dmi_system_id __initdata i8042_dmi_nopnp_table[] = {
         { }
 };
 
-static struct dmi_system_id __initdata i8042_dmi_laptop_table[] = {
+static const struct dmi_system_id __initconst i8042_dmi_laptop_table[] = {
         {
-                .ident = "Portable",
                 .matches = {
                         DMI_MATCH(DMI_CHASSIS_TYPE, "8"), /* Portable */
                 },
         },
         {
-                .ident = "Laptop",
                 .matches = {
                         DMI_MATCH(DMI_CHASSIS_TYPE, "9"), /* Laptop */
                 },
         },
         {
-                .ident = "Notebook",
                 .matches = {
                         DMI_MATCH(DMI_CHASSIS_TYPE, "10"), /* Notebook */
                 },
         },
         {
-                .ident = "Sub-Notebook",
                 .matches = {
                         DMI_MATCH(DMI_CHASSIS_TYPE, "14"), /* Sub-Notebook */
                 },
@@ -525,58 +529,65 @@ static struct dmi_system_id __initdata i8042_dmi_laptop_table[] = {
  * Originally, this was just confined to older laptops, but a few Acer laptops
  * have turned up in 2007 that also need this again.
  */
-static struct dmi_system_id __initdata i8042_dmi_dritek_table[] = {
+static const struct dmi_system_id __initconst i8042_dmi_dritek_table[] = {
+        {
+                /* Acer Aspire 5610 */
+                .matches = {
+                        DMI_MATCH(DMI_SYS_VENDOR, "Acer"),
+                        DMI_MATCH(DMI_PRODUCT_NAME, "Aspire 5610"),
+                },
+        },
         {
-                .ident = "Acer Aspire 5630",
+                /* Acer Aspire 5630 */
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "Acer"),
                         DMI_MATCH(DMI_PRODUCT_NAME, "Aspire 5630"),
                 },
         },
         {
-                .ident = "Acer Aspire 5650",
+                /* Acer Aspire 5650 */
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "Acer"),
                         DMI_MATCH(DMI_PRODUCT_NAME, "Aspire 5650"),
                 },
         },
         {
-                .ident = "Acer Aspire 5680",
+                /* Acer Aspire 5680 */
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "Acer"),
                         DMI_MATCH(DMI_PRODUCT_NAME, "Aspire 5680"),
                 },
         },
         {
-                .ident = "Acer Aspire 5720",
+                /* Acer Aspire 5720 */
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "Acer"),
                         DMI_MATCH(DMI_PRODUCT_NAME, "Aspire 5720"),
                 },
         },
         {
-                .ident = "Acer Aspire 9110",
+                /* Acer Aspire 9110 */
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "Acer"),
                         DMI_MATCH(DMI_PRODUCT_NAME, "Aspire 9110"),
                 },
         },
         {
-                .ident = "Acer TravelMate 660",
+                /* Acer TravelMate 660 */
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "Acer"),
                         DMI_MATCH(DMI_PRODUCT_NAME, "TravelMate 660"),
                 },
         },
         {
-                .ident = "Acer TravelMate 2490",
+                /* Acer TravelMate 2490 */
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "Acer"),
                         DMI_MATCH(DMI_PRODUCT_NAME, "TravelMate 2490"),
                 },
         },
         {
-                .ident = "Acer TravelMate 4280",
+                /* Acer TravelMate 4280 */
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "Acer"),
                         DMI_MATCH(DMI_PRODUCT_NAME, "TravelMate 4280"),
@@ -620,6 +631,9 @@ static int i8042_pnp_kbd_probe(struct pnp_dev *dev, const struct pnp_device_id *
                 strlcat(i8042_pnp_kbd_name, pnp_dev_name(dev), sizeof(i8042_pnp_kbd_name));
         }
 
+        /* Keyboard ports are always supposed to be wakeup-enabled */
+        device_set_wakeup_enable(&dev->dev, true);
+
         i8042_pnp_kbd_devices++;
         return 0;
 }
diff --git a/drivers/input/serio/i8042.c b/drivers/input/serio/i8042.c
index 1df02d25aca5..577688b5b951 100644
--- a/drivers/input/serio/i8042.c
+++ b/drivers/input/serio/i8042.c
@@ -21,6 +21,7 @@
 #include <linux/rcupdate.h>
 #include <linux/platform_device.h>
 #include <linux/i8042.h>
+#include <linux/slab.h>
 
 #include <asm/io.h>
 
@@ -126,6 +127,8 @@ static unsigned char i8042_suppress_kbd_ack;
 static struct platform_device *i8042_platform_device;
 
 static irqreturn_t i8042_interrupt(int irq, void *dev_id);
+static bool (*i8042_platform_filter)(unsigned char data, unsigned char str,
+                                     struct serio *serio);
 
 void i8042_lock_chip(void)
 {
@@ -139,6 +142,48 @@ void i8042_unlock_chip(void)
 }
 EXPORT_SYMBOL(i8042_unlock_chip);
 
+int i8042_install_filter(bool (*filter)(unsigned char data, unsigned char str,
+                                        struct serio *serio))
+{
+        unsigned long flags;
+        int ret = 0;
+
+        spin_lock_irqsave(&i8042_lock, flags);
+
+        if (i8042_platform_filter) {
+                ret = -EBUSY;
+                goto out;
+        }
+
+        i8042_platform_filter = filter;
+
+out:
+        spin_unlock_irqrestore(&i8042_lock, flags);
+        return ret;
+}
+EXPORT_SYMBOL(i8042_install_filter);
+
+int i8042_remove_filter(bool (*filter)(unsigned char data, unsigned char str,
+                                       struct serio *port))
+{
+        unsigned long flags;
+        int ret = 0;
+
+        spin_lock_irqsave(&i8042_lock, flags);
+
+        if (i8042_platform_filter != filter) {
+                ret = -EINVAL;
+                goto out;
+        }
+
+        i8042_platform_filter = NULL;
+
+out:
+        spin_unlock_irqrestore(&i8042_lock, flags);
+        return ret;
+}
+EXPORT_SYMBOL(i8042_remove_filter);
+
 /*
  * The i8042_wait_read() and i8042_wait_write functions wait for the i8042 to
  * be ready for reading values from it / writing values to it.
@@ -369,6 +414,31 @@ static void i8042_stop(struct serio *serio)
 }
 
 /*
+ * i8042_filter() filters out unwanted bytes from the input data stream.
+ * It is called from i8042_interrupt and thus is running with interrupts
+ * off and i8042_lock held.
+ */
+static bool i8042_filter(unsigned char data, unsigned char str,
+                         struct serio *serio)
+{
+        if (unlikely(i8042_suppress_kbd_ack)) {
+                if ((~str & I8042_STR_AUXDATA) &&
+                    (data == 0xfa || data == 0xfe)) {
+                        i8042_suppress_kbd_ack--;
+                        dbg("Extra keyboard ACK - filtered out\n");
+                        return true;
+                }
+        }
+
+        if (i8042_platform_filter && i8042_platform_filter(data, str, serio)) {
+                dbg("Filtered out by platform filter\n");
+                return true;
+        }
+
+        return false;
+}
+
+/*
  * i8042_interrupt() is the most important function in this driver -
  * it handles the interrupts from the i8042, and sends incoming bytes
  * to the upper layers.
@@ -377,13 +447,16 @@ static void i8042_stop(struct serio *serio)
 static irqreturn_t i8042_interrupt(int irq, void *dev_id)
 {
         struct i8042_port *port;
+        struct serio *serio;
         unsigned long flags;
         unsigned char str, data;
         unsigned int dfl;
         unsigned int port_no;
+        bool filtered;
         int ret = 1;
 
         spin_lock_irqsave(&i8042_lock, flags);
+
         str = i8042_read_status();
         if (unlikely(~str & I8042_STR_OBF)) {
                 spin_unlock_irqrestore(&i8042_lock, flags);
@@ -391,8 +464,8 @@ static irqreturn_t i8042_interrupt(int irq, void *dev_id)
                 ret = 0;
                 goto out;
         }
+
         data = i8042_read_data();
-        spin_unlock_irqrestore(&i8042_lock, flags);
 
         if (i8042_mux_present && (str & I8042_STR_AUXDATA)) {
                 static unsigned long last_transmit;
@@ -441,21 +514,19 @@ static irqreturn_t i8042_interrupt(int irq, void *dev_id)
         }
 
         port = &i8042_ports[port_no];
+        serio = port->exists ? port->serio : NULL;
 
         dbg("%02x <- i8042 (interrupt, %d, %d%s%s)",
             data, port_no, irq,
             dfl & SERIO_PARITY ? ", bad parity" : "",
             dfl & SERIO_TIMEOUT ? ", timeout" : "");
 
-        if (unlikely(i8042_suppress_kbd_ack))
-                if (port_no == I8042_KBD_PORT_NO &&
-                    (data == 0xfa || data == 0xfe)) {
-                        i8042_suppress_kbd_ack--;
-                        goto out;
-                }
+        filtered = i8042_filter(data, str, serio);
+
+        spin_unlock_irqrestore(&i8042_lock, flags);
 
-        if (likely(port->exists))
-                serio_interrupt(port->serio, data, dfl);
+        if (likely(port->exists && !filtered))
+                serio_interrupt(serio, data, dfl);
 
  out:
         return IRQ_RETVAL(ret);
@@ -1091,9 +1162,17 @@ static int i8042_pm_restore(struct device *dev)
         return 0;
 }
 
+static int i8042_pm_thaw(struct device *dev)
+{
+        i8042_interrupt(0, NULL);
+
+        return 0;
+}
+
 static const struct dev_pm_ops i8042_pm_ops = {
         .suspend        = i8042_pm_reset,
         .resume         = i8042_pm_restore,
+        .thaw           = i8042_pm_thaw,
         .poweroff       = i8042_pm_reset,
         .restore        = i8042_pm_restore,
 };
@@ -1308,6 +1387,8 @@ static int __init i8042_probe(struct platform_device *dev)
 {
         int error;
 
+        i8042_platform_device = dev;
+
         error = i8042_controller_selftest();
         if (error)
                 return error;
@@ -1343,6 +1424,7 @@ static int __init i8042_probe(struct platform_device *dev)
         i8042_free_aux_ports(); /* in case KBD failed but AUX not */
         i8042_free_irqs();
         i8042_controller_reset();
+        i8042_platform_device = NULL;
 
         return error;
 }
@@ -1352,6 +1434,7 @@ static int __devexit i8042_remove(struct platform_device *dev)
         i8042_unregister_ports();
         i8042_free_irqs();
         i8042_controller_reset();
+        i8042_platform_device = NULL;
 
         return 0;
 }
@@ -1370,6 +1453,7 @@ static struct platform_driver i8042_driver = {
 
 static int __init i8042_init(void)
 {
+        struct platform_device *pdev;
         int err;
 
         dbg_init();
@@ -1382,31 +1466,18 @@ static int __init i8042_init(void)
         if (err)
                 goto err_platform_exit;
 
-        i8042_platform_device = platform_device_alloc("i8042", -1);
-        if (!i8042_platform_device) {
-                err = -ENOMEM;
+        pdev = platform_create_bundle(&i8042_driver, i8042_probe, NULL, 0, NULL, 0);
+        if (IS_ERR(pdev)) {
+                err = PTR_ERR(pdev);
                 goto err_platform_exit;
         }
 
-        err = platform_device_add(i8042_platform_device);
-        if (err)
-                goto err_free_device;
-
-        err = platform_driver_probe(&i8042_driver, i8042_probe);
-        if (err)
-                goto err_del_device;
-
         panic_blink = i8042_panic_blink;
 
         return 0;
 
- err_del_device:
-        platform_device_del(i8042_platform_device);
- err_free_device:
-        platform_device_put(i8042_platform_device);
  err_platform_exit:
         i8042_platform_exit();
-
         return err;
 }
 
diff --git a/drivers/input/serio/libps2.c b/drivers/input/serio/libps2.c
index f3876acc3e83..980af94ba9c8 100644
--- a/drivers/input/serio/libps2.c
+++ b/drivers/input/serio/libps2.c
@@ -14,7 +14,6 @@
 #include <linux/delay.h>
 #include <linux/module.h>
 #include <linux/sched.h>
-#include <linux/slab.h>
 #include <linux/interrupt.h>
 #include <linux/input.h>
 #include <linux/serio.h>
diff --git a/drivers/input/serio/parkbd.c b/drivers/input/serio/parkbd.c
index b089977e0ef9..26b45936f9fd 100644
--- a/drivers/input/serio/parkbd.c
+++ b/drivers/input/serio/parkbd.c
@@ -46,6 +46,7 @@
 
 #include <linux/module.h>
 #include <linux/parport.h>
+#include <linux/slab.h>
 #include <linux/init.h>
 #include <linux/serio.h>
 
diff --git a/drivers/input/serio/pcips2.c b/drivers/input/serio/pcips2.c
index 1dacbe0d9348..43494742541c 100644
--- a/drivers/input/serio/pcips2.c
+++ b/drivers/input/serio/pcips2.c
@@ -15,6 +15,7 @@
 #include <linux/ioport.h>
 #include <linux/input.h>
 #include <linux/pci.h>
+#include <linux/slab.h>
 #include <linux/init.h>
 #include <linux/serio.h>
 #include <linux/delay.h>
@@ -186,7 +187,7 @@ static void __devexit pcips2_remove(struct pci_dev *dev)
         pci_disable_device(dev);
 }
 
-static struct pci_device_id pcips2_ids[] = {
+static const struct pci_device_id pcips2_ids[] = {
         {
                 .vendor         = 0x14f2,       /* MOBILITY */
                 .device         = 0x0123,       /* Keyboard */
diff --git a/drivers/input/serio/q40kbd.c b/drivers/input/serio/q40kbd.c
index e36a0901646c..5eb84b3b67fb 100644
--- a/drivers/input/serio/q40kbd.c
+++ b/drivers/input/serio/q40kbd.c
@@ -36,6 +36,7 @@
 #include <linux/err.h>
 #include <linux/bitops.h>
 #include <linux/platform_device.h>
+#include <linux/slab.h>
 
 #include <asm/io.h>
 #include <asm/uaccess.h>
diff --git a/drivers/input/serio/rpckbd.c b/drivers/input/serio/rpckbd.c
index ed045c99f84b..9da6fbcaaa7e 100644
--- a/drivers/input/serio/rpckbd.c
+++ b/drivers/input/serio/rpckbd.c
@@ -34,6 +34,7 @@
 #include <linux/err.h>
 #include <linux/platform_device.h>
 #include <linux/io.h>
+#include <linux/slab.h>
 
 #include <asm/irq.h>
 #include <mach/hardware.h>
diff --git a/drivers/input/serio/sa1111ps2.c b/drivers/input/serio/sa1111ps2.c
index f412c69478a8..d55874e5d1c2 100644
--- a/drivers/input/serio/sa1111ps2.c
+++ b/drivers/input/serio/sa1111ps2.c
@@ -180,8 +180,8 @@ static void __devinit ps2_clear_input(struct ps2if *ps2if)
         }
 }
 
-static inline unsigned int
-ps2_test_one(struct ps2if *ps2if, unsigned int mask)
+static unsigned int __devinit ps2_test_one(struct ps2if *ps2if,
+                                           unsigned int mask)
 {
         unsigned int val;
 
@@ -197,7 +197,7 @@ ps2_test_one(struct ps2if *ps2if, unsigned int mask)
  * Test the keyboard interface.  We basically check to make sure that
  * we can drive each line to the keyboard independently of each other.
  */
-static int __init ps2_test(struct ps2if *ps2if)
+static int __devinit ps2_test(struct ps2if *ps2if)
 {
         unsigned int stat;
         int ret = 0;
@@ -312,7 +312,7 @@ static int __devinit ps2_probe(struct sa1111_dev *dev)
 /*
  * Remove one device from this driver.
  */
-static int ps2_remove(struct sa1111_dev *dev)
+static int __devexit ps2_remove(struct sa1111_dev *dev)
 {
         struct ps2if *ps2if = sa1111_get_drvdata(dev);
 
@@ -335,7 +335,7 @@ static struct sa1111_driver ps2_driver = {
         },
         .devid          = SA1111_DEVID_PS2,
         .probe          = ps2_probe,
-        .remove         = ps2_remove,
+        .remove         = __devexit_p(ps2_remove),
 };
 
 static int __init ps2_init(void)
diff --git a/drivers/input/serio/serio.c b/drivers/input/serio/serio.c
index 0236f0d5fd91..c3b626e9eae7 100644
--- a/drivers/input/serio/serio.c
+++ b/drivers/input/serio/serio.c
@@ -26,6 +26,8 @@
  * Vojtech Pavlik, Simunkova 1594, Prague 8, 182 00 Czech Republic
  */
 
+#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
+
 #include <linux/stddef.h>
 #include <linux/module.h>
 #include <linux/serio.h>
@@ -119,11 +121,10 @@ static int serio_bind_driver(struct serio *serio, struct serio_driver *drv)
 
                 error = device_bind_driver(&serio->dev);
                 if (error) {
-                        printk(KERN_WARNING
-                                "serio: device_bind_driver() failed "
-                                "for %s (%s) and %s, error: %d\n",
-                                serio->phys, serio->name,
-                                drv->description, error);
+                        dev_warn(&serio->dev,
+                                 "device_bind_driver() failed for %s (%s) and %s, error: %d\n",
+                                 serio->phys, serio->name,
+                                 drv->description, error);
                         serio_disconnect_driver(serio);
                         serio->dev.driver = NULL;
                         return error;
@@ -138,9 +139,9 @@ static void serio_find_driver(struct serio *serio)
 
         error = device_attach(&serio->dev);
         if (error < 0)
-                printk(KERN_WARNING
-                        "serio: device_attach() failed for %s (%s), error: %d\n",
-                        serio->phys, serio->name, error);
+                dev_warn(&serio->dev,
+                         "device_attach() failed for %s (%s), error: %d\n",
+                         serio->phys, serio->name, error);
 }
 
 
@@ -194,17 +195,14 @@ static int serio_queue_event(void *object, struct module *owner,
 
         event = kmalloc(sizeof(struct serio_event), GFP_ATOMIC);
         if (!event) {
-                printk(KERN_ERR
-                        "serio: Not enough memory to queue event %d\n",
-                        event_type);
+                pr_err("Not enough memory to queue event %d\n", event_type);
                 retval = -ENOMEM;
                 goto out;
         }
 
         if (!try_module_get(owner)) {
-                printk(KERN_WARNING
-                        "serio: Can't get module reference, dropping event %d\n",
-                        event_type);
+                pr_warning("Can't get module reference, dropping event %d\n",
+                           event_type);
                 kfree(event);
                 retval = -EINVAL;
                 goto out;
@@ -230,14 +228,12 @@ static void serio_free_event(struct serio_event *event)
 
 static void serio_remove_duplicate_events(struct serio_event *event)
 {
-        struct list_head *node, *next;
-        struct serio_event *e;
+        struct serio_event *e, *next;
         unsigned long flags;
 
         spin_lock_irqsave(&serio_event_lock, flags);
 
-        list_for_each_safe(node, next, &serio_event_list) {
-                e = list_entry(node, struct serio_event, node);
+        list_for_each_entry_safe(e, next, &serio_event_list, node) {
                 if (event->object == e->object) {
                         /*
                          * If this event is of different type we should not
@@ -247,7 +243,7 @@ static void serio_remove_duplicate_events(struct serio_event *event)
                         if (event->type != e->type)
                                 break;
 
-                        list_del_init(node);
+                        list_del_init(&e->node);
                         serio_free_event(e);
                 }
         }
@@ -258,23 +254,18 @@ static void serio_remove_duplicate_events(struct serio_event *event)
 
 static struct serio_event *serio_get_event(void)
 {
-        struct serio_event *event;
-        struct list_head *node;
+        struct serio_event *event = NULL;
         unsigned long flags;
 
         spin_lock_irqsave(&serio_event_lock, flags);
 
-        if (list_empty(&serio_event_list)) {
-                spin_unlock_irqrestore(&serio_event_lock, flags);
-                return NULL;
+        if (!list_empty(&serio_event_list)) {
+                event = list_first_entry(&serio_event_list,
+                                         struct serio_event, node);
+                list_del_init(&event->node);
         }
 
-        node = serio_event_list.next;
-        event = list_entry(node, struct serio_event, node);
-        list_del_init(node);
-
         spin_unlock_irqrestore(&serio_event_lock, flags);
-
         return event;
 }
 
@@ -284,38 +275,30 @@ static void serio_handle_event(void)
 
         mutex_lock(&serio_mutex);
 
-        /*
-         * Note that we handle only one event here to give swsusp
-         * a chance to freeze kseriod thread. Serio events should
-         * be pretty rare so we are not concerned about taking
-         * performance hit.
-         */
-        if ((event = serio_get_event())) {
+        while ((event = serio_get_event())) {
 
                 switch (event->type) {
-                        case SERIO_REGISTER_PORT:
-                                serio_add_port(event->object);
-                                break;
 
-                        case SERIO_RECONNECT_PORT:
-                                serio_reconnect_port(event->object);
-                                break;
+                case SERIO_REGISTER_PORT:
+                        serio_add_port(event->object);
+                        break;
 
-                        case SERIO_RESCAN_PORT:
-                                serio_disconnect_port(event->object);
-                                serio_find_driver(event->object);
-                                break;
+                case SERIO_RECONNECT_PORT:
+                        serio_reconnect_port(event->object);
+                        break;
 
-                        case SERIO_RECONNECT_CHAIN:
-                                serio_reconnect_chain(event->object);
-                                break;
+                case SERIO_RESCAN_PORT:
+                        serio_disconnect_port(event->object);
+                        serio_find_driver(event->object);
+                        break;
 
-                        case SERIO_ATTACH_DRIVER:
-                                serio_attach_driver(event->object);
-                                break;
+                case SERIO_RECONNECT_CHAIN:
+                        serio_reconnect_chain(event->object);
+                        break;
 
-                        default:
-                                break;
+                case SERIO_ATTACH_DRIVER:
+                        serio_attach_driver(event->object);
+                        break;
                 }
 
                 serio_remove_duplicate_events(event);
@@ -331,16 +314,14 @@ static void serio_handle_event(void)
  */
 static void serio_remove_pending_events(void *object)
 {
-        struct list_head *node, *next;
-        struct serio_event *event;
+        struct serio_event *event, *next;
         unsigned long flags;
 
         spin_lock_irqsave(&serio_event_lock, flags);
 
-        list_for_each_safe(node, next, &serio_event_list) {
-                event = list_entry(node, struct serio_event, node);
+        list_for_each_entry_safe(event, next, &serio_event_list, node) {
                 if (event->object == object) {
-                        list_del_init(node);
+                        list_del_init(&event->node);
                         serio_free_event(event);
                 }
         }
@@ -380,14 +361,12 @@ static struct serio *serio_get_pending_child(struct serio *parent)
 
 static int serio_thread(void *nothing)
 {
-        set_freezable();
         do {
                 serio_handle_event();
-                wait_event_freezable(serio_wait,
+                wait_event_interruptible(serio_wait,
                         kthread_should_stop() || !list_empty(&serio_event_list));
         } while (!kthread_should_stop());
 
-        printk(KERN_DEBUG "serio: kseriod exiting\n");
         return 0;
 }
 
@@ -452,6 +431,11 @@ static struct attribute_group serio_id_attr_group = {
         .attrs  = serio_device_id_attrs,
 };
 
+static const struct attribute_group *serio_device_attr_groups[] = {
+        &serio_id_attr_group,
+        NULL
+};
+
 static ssize_t serio_rebind_driver(struct device *dev, struct device_attribute *attr, const char *buf, size_t count)
 {
         struct serio *serio = to_serio_port(dev);
@@ -539,6 +523,7 @@ static void serio_init_port(struct serio *serio)
                         (long)atomic_inc_return(&serio_no) - 1);
         serio->dev.bus = &serio_bus;
         serio->dev.release = serio_release_port;
+        serio->dev.groups = serio_device_attr_groups;
         if (serio->parent) {
                 serio->dev.parent = &serio->parent->dev;
                 serio->depth = serio->parent->depth + 1;
@@ -562,21 +547,15 @@ static void serio_add_port(struct serio *serio)
         }
 
         list_add_tail(&serio->node, &serio_list);
+
         if (serio->start)
                 serio->start(serio);
+
         error = device_add(&serio->dev);
         if (error)
-                printk(KERN_ERR
-                        "serio: device_add() failed for %s (%s), error: %d\n",
+                dev_err(&serio->dev,
+                        "device_add() failed for %s (%s), error: %d\n",
                         serio->phys, serio->name, error);
-        else {
-                serio->registered = true;
-                error = sysfs_create_group(&serio->dev.kobj, &serio_id_attr_group);
-                if (error)
-                        printk(KERN_ERR
-                                "serio: sysfs_create_group() failed for %s (%s), error: %d\n",
-                                serio->phys, serio->name, error);
-        }
 }
 
 /*
@@ -603,11 +582,8 @@ static void serio_destroy_port(struct serio *serio)
                 serio->parent = NULL;
         }
 
-        if (serio->registered) {
-                sysfs_remove_group(&serio->dev.kobj, &serio_id_attr_group);
+        if (device_is_registered(&serio->dev))
                 device_del(&serio->dev);
-                serio->registered = false;
-        }
 
         list_del_init(&serio->node);
         serio_remove_pending_events(serio);
@@ -805,9 +781,8 @@ static void serio_attach_driver(struct serio_driver *drv)
 
         error = driver_attach(&drv->driver);
         if (error)
-                printk(KERN_WARNING
-                        "serio: driver_attach() failed for %s with error %d\n",
-                        drv->driver.name, error);
+                pr_warning("driver_attach() failed for %s with error %d\n",
+                           drv->driver.name, error);
 }
 
 int __serio_register_driver(struct serio_driver *drv, struct module *owner, const char *mod_name)
@@ -827,8 +802,7 @@ int __serio_register_driver(struct serio_driver *drv, struct module *owner, cons
 
         error = driver_register(&drv->driver);
         if (error) {
-                printk(KERN_ERR
-                        "serio: driver_register() failed for %s, error: %d\n",
+                pr_err("driver_register() failed for %s, error: %d\n",
                         drv->driver.name, error);
                 return error;
         }
@@ -994,7 +968,7 @@ irqreturn_t serio_interrupt(struct serio *serio,
 
         if (likely(serio->drv)) {
                 ret = serio->drv->interrupt(serio, data, dfl);
-        } else if (!dfl && serio->registered) {
+        } else if (!dfl && device_is_registered(&serio->dev)) {
                 serio_rescan(serio);
                 ret = IRQ_HANDLED;
         }
@@ -1025,7 +999,7 @@ static int __init serio_init(void)
 
         error = bus_register(&serio_bus);
         if (error) {
-                printk(KERN_ERR "serio: failed to register serio bus, error: %d\n", error);
+                pr_err("Failed to register serio bus, error: %d\n", error);
                 return error;
         }
 
@@ -1033,7 +1007,7 @@ static int __init serio_init(void)
         if (IS_ERR(serio_task)) {
                 bus_unregister(&serio_bus);
                 error = PTR_ERR(serio_task);
-                printk(KERN_ERR "serio: Failed to start kseriod, error: %d\n", error);
+                pr_err("Failed to start kseriod, error: %d\n", error);
                 return error;
         }
 
diff --git a/drivers/input/serio/serio_raw.c b/drivers/input/serio/serio_raw.c
index 27fdaaffbb40..998664854440 100644
--- a/drivers/input/serio/serio_raw.c
+++ b/drivers/input/serio/serio_raw.c
@@ -81,12 +81,12 @@ static int serio_raw_open(struct inode *inode, struct file *file)
         struct serio_raw_list *list;
         int retval = 0;
 
-        lock_kernel();
         retval = mutex_lock_interruptible(&serio_raw_mutex);
         if (retval)
-                goto out_bkl;
+                return retval;
 
-        if (!(serio_raw = serio_raw_locate(iminor(inode)))) {
+        serio_raw = serio_raw_locate(iminor(inode));
+        if (!serio_raw) {
                 retval = -ENODEV;
                 goto out;
         }
@@ -96,7 +96,8 @@ static int serio_raw_open(struct inode *inode, struct file *file)
                 goto out;
         }
 
-        if (!(list = kzalloc(sizeof(struct serio_raw_list), GFP_KERNEL))) {
+        list = kzalloc(sizeof(struct serio_raw_list), GFP_KERNEL);
+        if (!list) {
                 retval = -ENOMEM;
                 goto out;
         }
@@ -109,8 +110,6 @@ static int serio_raw_open(struct inode *inode, struct file *file)
 
 out:
         mutex_unlock(&serio_raw_mutex);
-out_bkl:
-        unlock_kernel();
         return retval;
 }
 
diff --git a/drivers/input/serio/xilinx_ps2.c b/drivers/input/serio/xilinx_ps2.c
index ebb22f88c842..f84f8e32e3f1 100644
--- a/drivers/input/serio/xilinx_ps2.c
+++ b/drivers/input/serio/xilinx_ps2.c
@@ -19,6 +19,7 @@
 #include <linux/serio.h>
 #include <linux/interrupt.h>
 #include <linux/errno.h>
+#include <linux/slab.h>
 #include <linux/init.h>
 #include <linux/list.h>
 #include <linux/io.h>
@@ -270,7 +271,7 @@ static int __devinit xps2_of_probe(struct of_device *ofdev,
         drvdata->irq = r_irq.start;
 
         phys_addr = r_mem.start;
-        remap_size = r_mem.end - r_mem.start + 1;
+        remap_size = resource_size(&r_mem);
         if (!request_mem_region(phys_addr, remap_size, DRIVER_NAME)) {
                 dev_err(dev, "Couldn't lock memory region at 0x%08llX\n",
                         (unsigned long long)phys_addr);
@@ -344,7 +345,7 @@ static int __devexit xps2_of_remove(struct of_device *of_dev)
         if (of_address_to_resource(of_dev->node, 0, &r_mem))
                 dev_err(dev, "invalid address\n");
         else
-                release_mem_region(r_mem.start, r_mem.end - r_mem.start + 1);
+                release_mem_region(r_mem.start, resource_size(&r_mem));
 
         kfree(drvdata);
 
@@ -354,7 +355,7 @@ static int __devexit xps2_of_remove(struct of_device *of_dev)
 }
 
 /* Match table for of_platform binding */
-static struct of_device_id xps2_of_match[] __devinitdata = {
+static const struct of_device_id xps2_of_match[] __devinitconst = {
         { .compatible = "xlnx,xps-ps2-1.00.a", },
         { /* end of list */ },
 };
diff --git a/drivers/input/sparse-keymap.c b/drivers/input/sparse-keymap.c
new file mode 100644
index 000000000000..82ae18d29685
--- /dev/null
+++ b/drivers/input/sparse-keymap.c
@@ -0,0 +1,253 @@
+/*
+ * Generic support for sparse keymaps
+ *
+ * Copyright (c) 2009 Dmitry Torokhov
+ *
+ * Derived from wistron button driver:
+ * Copyright (C) 2005 Miloslav Trmac <mitr@volny.cz>
+ * Copyright (C) 2005 Bernhard Rosenkraenzer <bero@arklinux.org>
+ * Copyright (C) 2005 Dmitry Torokhov <dtor@mail.ru>
+ *
+ * This program is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License version 2 as published by
+ * the Free Software Foundation.
+ */
+
+#include <linux/input.h>
+#include <linux/input/sparse-keymap.h>
+#include <linux/slab.h>
+
+MODULE_AUTHOR("Dmitry Torokhov <dtor@mail.ru>");
+MODULE_DESCRIPTION("Generic support for sparse keymaps");
+MODULE_LICENSE("GPL v2");
+MODULE_VERSION("0.1");
+
+/**
+ * sparse_keymap_entry_from_scancode - perform sparse keymap lookup
+ * @dev: Input device using sparse keymap
+ * @code: Scan code
+ *
+ * This function is used to perform &struct key_entry lookup in an
+ * input device using sparse keymap.
+ */
+struct key_entry *sparse_keymap_entry_from_scancode(struct input_dev *dev,
+                                                    unsigned int code)
+{
+        struct key_entry *key;
+
+        for (key = dev->keycode; key->type != KE_END; key++)
+                if (code == key->code)
+                        return key;
+
+        return NULL;
+}
+EXPORT_SYMBOL(sparse_keymap_entry_from_scancode);
+
+/**
+ * sparse_keymap_entry_from_keycode - perform sparse keymap lookup
+ * @dev: Input device using sparse keymap
+ * @keycode: Key code
+ *
+ * This function is used to perform &struct key_entry lookup in an
+ * input device using sparse keymap.
+ */
+struct key_entry *sparse_keymap_entry_from_keycode(struct input_dev *dev,
+                                                   unsigned int keycode)
+{
+        struct key_entry *key;
+
+        for (key = dev->keycode; key->type != KE_END; key++)
+                if (key->type == KE_KEY && keycode == key->keycode)
+                        return key;
+
+        return NULL;
+}
+EXPORT_SYMBOL(sparse_keymap_entry_from_keycode);
+
+static int sparse_keymap_getkeycode(struct input_dev *dev,
+                                    unsigned int scancode,
+                                    unsigned int *keycode)
+{
+        const struct key_entry *key =
+                        sparse_keymap_entry_from_scancode(dev, scancode);
+
+        if (key && key->type == KE_KEY) {
+                *keycode = key->keycode;
+                return 0;
+        }
+
+        return -EINVAL;
+}
+
+static int sparse_keymap_setkeycode(struct input_dev *dev,
+                                    unsigned int scancode,
+                                    unsigned int keycode)
+{
+        struct key_entry *key;
+        int old_keycode;
+
+        if (keycode < 0 || keycode > KEY_MAX)
+                return -EINVAL;
+
+        key = sparse_keymap_entry_from_scancode(dev, scancode);
+        if (key && key->type == KE_KEY) {
+                old_keycode = key->keycode;
+                key->keycode = keycode;
+                set_bit(keycode, dev->keybit);
+                if (!sparse_keymap_entry_from_keycode(dev, old_keycode))
+                        clear_bit(old_keycode, dev->keybit);
+                return 0;
+        }
+
+        return -EINVAL;
+}
+
+/**
+ * sparse_keymap_setup - set up sparse keymap for an input device
+ * @dev: Input device
+ * @keymap: Keymap in form of array of &key_entry structures ending
+ *      with %KE_END type entry
+ * @setup: Function that can be used to adjust keymap entries
+ *      depending on device's deeds, may be %NULL
+ *
+ * The function calculates size and allocates copy of the original
+ * keymap after which sets up input device event bits appropriately.
+ * Before destroying input device allocated keymap should be freed
+ * with a call to sparse_keymap_free().
+ */
+int sparse_keymap_setup(struct input_dev *dev,
+                        const struct key_entry *keymap,
+                        int (*setup)(struct input_dev *, struct key_entry *))
+{
+        size_t map_size = 1; /* to account for the last KE_END entry */
+        const struct key_entry *e;
+        struct key_entry *map, *entry;
+        int i;
+        int error;
+
+        for (e = keymap; e->type != KE_END; e++)
+                map_size++;
+
+        map = kcalloc(map_size, sizeof (struct key_entry), GFP_KERNEL);
+        if (!map)
+                return -ENOMEM;
+
+        memcpy(map, keymap, map_size * sizeof (struct key_entry));
+
+        for (i = 0; i < map_size; i++) {
+                entry = &map[i];
+
+                if (setup) {
+                        error = setup(dev, entry);
+                        if (error)
+                                goto err_out;
+                }
+
+                switch (entry->type) {
+                case KE_KEY:
+                        __set_bit(EV_KEY, dev->evbit);
+                        __set_bit(entry->keycode, dev->keybit);
+                        break;
+
+                case KE_SW:
+                        __set_bit(EV_SW, dev->evbit);
+                        __set_bit(entry->sw.code, dev->swbit);
+                        break;
+                }
+        }
+
+        dev->keycode = map;
+        dev->keycodemax = map_size;
+        dev->getkeycode = sparse_keymap_getkeycode;
+        dev->setkeycode = sparse_keymap_setkeycode;
+
+        return 0;
+
+ err_out:
+        kfree(keymap);
+        return error;
+
+}
+EXPORT_SYMBOL(sparse_keymap_setup);
+
+/**
+ * sparse_keymap_free - free memory allocated for sparse keymap
+ * @dev: Input device using sparse keymap
+ *
+ * This function is used to free memory allocated by sparse keymap
+ * in an input device that was set up by sparse_keymap_setup().
+ */
+void sparse_keymap_free(struct input_dev *dev)
+{
+        kfree(dev->keycode);
+        dev->keycode = NULL;
+        dev->keycodemax = 0;
+        dev->getkeycode = NULL;
+        dev->setkeycode = NULL;
+}
+EXPORT_SYMBOL(sparse_keymap_free);
+
+/**
+ * sparse_keymap_report_entry - report event corresponding to given key entry
+ * @dev: Input device for which event should be reported
+ * @ke: key entry describing event
+ * @value: Value that should be reported (ignored by %KE_SW entries)
+ * @autorelease: Signals whether release event should be emitted for %KE_KEY
+ *      entries right after reporting press event, ignored by all other
+ *      entries
+ *
+ * This function is used to report input event described by given
+ * &struct key_entry.
+ */
+void sparse_keymap_report_entry(struct input_dev *dev, const struct key_entry *ke,
+                                unsigned int value, bool autorelease)
+{
+        switch (ke->type) {
+        case KE_KEY:
+                input_report_key(dev, ke->keycode, value);
+                input_sync(dev);
+                if (value && autorelease) {
+                        input_report_key(dev, ke->keycode, 0);
+                        input_sync(dev);
+                }
+                break;
+
+        case KE_SW:
+                value = ke->sw.value;
+                /* fall through */
+
+        case KE_VSW:
+                input_report_switch(dev, ke->sw.code, value);
+                break;
+        }
+}
+EXPORT_SYMBOL(sparse_keymap_report_entry);
+
+/**
+ * sparse_keymap_report_event - report event corresponding to given scancode
+ * @dev: Input device using sparse keymap
+ * @code: Scan code
+ * @value: Value that should be reported (ignored by %KE_SW entries)
+ * @autorelease: Signals whether release event should be emitted for %KE_KEY
+ *      entries right after reporting press event, ignored by all other
+ *      entries
+ *
+ * This function is used to perform lookup in an input device using sparse
+ * keymap and report corresponding event. Returns %true if lookup was
+ * successful and %false otherwise.
+ */
+bool sparse_keymap_report_event(struct input_dev *dev, unsigned int code,
+                                unsigned int value, bool autorelease)
+{
+        const struct key_entry *ke =
+                sparse_keymap_entry_from_scancode(dev, code);
+
+        if (ke) {
+                sparse_keymap_report_entry(dev, ke, value, autorelease);
+                return true;
+        }
+
+        return false;
+}
+EXPORT_SYMBOL(sparse_keymap_report_event);
+
diff --git a/drivers/input/tablet/aiptek.c b/drivers/input/tablet/aiptek.c
index 7d005a3616d7..4be039d7dcad 100644
--- a/drivers/input/tablet/aiptek.c
+++ b/drivers/input/tablet/aiptek.c
@@ -362,7 +362,7 @@ static const int macroKeyEvents[] = {
 };
 
 /***********************************************************************
- * Map values to strings and back. Every map shoudl have the following
+ * Map values to strings and back. Every map should have the following
  * as its last element: { NULL, AIPTEK_INVALID_VALUE }.
  */
 #define AIPTEK_INVALID_VALUE    -1
diff --git a/drivers/input/tablet/gtco.c b/drivers/input/tablet/gtco.c
index 3d32d3f4e486..866a9ee1af1a 100644
--- a/drivers/input/tablet/gtco.c
+++ b/drivers/input/tablet/gtco.c
@@ -92,7 +92,7 @@ Scott Hill shill@gtcocalcomp.com
 /* DATA STRUCTURES */
 
 /* Device table */
-static struct usb_device_id gtco_usbid_table [] = {
+static const struct usb_device_id gtco_usbid_table[] = {
         { USB_DEVICE(VENDOR_ID_GTCO, PID_400) },
         { USB_DEVICE(VENDOR_ID_GTCO, PID_401) },
         { USB_DEVICE(VENDOR_ID_GTCO, PID_1000) },
diff --git a/drivers/input/tablet/wacom.h b/drivers/input/tablet/wacom.h
index 9114ae1c7488..8fef1b689c69 100644
--- a/drivers/input/tablet/wacom.h
+++ b/drivers/input/tablet/wacom.h
@@ -1,7 +1,7 @@
 /*
  * drivers/input/tablet/wacom.h
  *
- *  USB Wacom Graphire and Wacom Intuos tablet support
+ *  USB Wacom tablet support
  *
  *  Copyright (c) 2000-2004 Vojtech Pavlik      <vojtech@ucw.cz>
  *  Copyright (c) 2000 Andreas Bach Aaen        <abach@stofanet.dk>
@@ -69,6 +69,9 @@
  *      v1.49 (pc) - Added support for USB Tablet PC (0x90, 0x93, and 0x9A)
  *      v1.50 (pc) - Fixed a TabletPC touch bug in 2.6.28
  *      v1.51 (pc) - Added support for Intuos4
+ *      v1.52 (pc) - Query Wacom data upon system resume
+ *                 - add defines for features->type
+ *                 - add new devices (0x9F, 0xE2, and 0XE3)
  */
 
 /*
@@ -82,6 +85,7 @@
 #include <linux/kernel.h>
 #include <linux/slab.h>
 #include <linux/module.h>
+#include <linux/mod_devicetable.h>
 #include <linux/init.h>
 #include <linux/usb/input.h>
 #include <asm/unaligned.h>
@@ -89,9 +93,9 @@
 /*
  * Version Information
  */
-#define DRIVER_VERSION "v1.51"
+#define DRIVER_VERSION "v1.52"
 #define DRIVER_AUTHOR "Vojtech Pavlik <vojtech@ucw.cz>"
-#define DRIVER_DESC "USB Wacom Graphire and Wacom Intuos tablet driver"
+#define DRIVER_DESC "USB Wacom tablet driver"
 #define DRIVER_LICENSE "GPL"
 
 MODULE_AUTHOR(DRIVER_AUTHOR);
@@ -117,6 +121,8 @@ struct wacom_combo {
         struct urb *urb;
 };
 
+extern const struct usb_device_id wacom_ids[];
+
 extern int wacom_wac_irq(struct wacom_wac * wacom_wac, void * wcombo);
 extern void wacom_report_abs(void *wcombo, unsigned int abs_type, int abs_data);
 extern void wacom_report_rel(void *wcombo, unsigned int rel_type, int rel_data);
@@ -133,11 +139,11 @@ extern void input_dev_i4s(struct input_dev *input_dev, struct wacom_wac *wacom_w
 extern void input_dev_i4(struct input_dev *input_dev, struct wacom_wac *wacom_wac);
 extern void input_dev_pl(struct input_dev *input_dev, struct wacom_wac *wacom_wac);
 extern void input_dev_pt(struct input_dev *input_dev, struct wacom_wac *wacom_wac);
+extern void input_dev_tpc(struct input_dev *input_dev, struct wacom_wac *wacom_wac);
+extern void input_dev_tpc2fg(struct input_dev *input_dev, struct wacom_wac *wacom_wac);
 extern void input_dev_mo(struct input_dev *input_dev, struct wacom_wac *wacom_wac);
 extern void input_dev_bee(struct input_dev *input_dev, struct wacom_wac *wacom_wac);
 extern __u16 wacom_le16_to_cpu(unsigned char *data);
 extern __u16 wacom_be16_to_cpu(unsigned char *data);
-extern struct wacom_features *get_wacom_feature(const struct usb_device_id *id);
-extern const struct usb_device_id *get_device_table(void);
 
 #endif
diff --git a/drivers/input/tablet/wacom_sys.c b/drivers/input/tablet/wacom_sys.c
index ea30c983a33e..8b5d2873f0c4 100644
--- a/drivers/input/tablet/wacom_sys.c
+++ b/drivers/input/tablet/wacom_sys.c
@@ -1,7 +1,7 @@
 /*
  * drivers/input/tablet/wacom_sys.c
  *
- *  USB Wacom Graphire and Wacom Intuos tablet support - system specific code
+ *  USB Wacom tablet support - system specific code
  */
 
 /*
@@ -209,8 +209,10 @@ void input_dev_g(struct input_dev *input_dev, struct wacom_wac *wacom_wac)
         input_dev->keybit[BIT_WORD(BTN_MOUSE)] |= BIT_MASK(BTN_LEFT) |
                 BIT_MASK(BTN_RIGHT) | BIT_MASK(BTN_MIDDLE);
         input_dev->keybit[BIT_WORD(BTN_DIGI)] |= BIT_MASK(BTN_TOOL_RUBBER) |
+                BIT_MASK(BTN_TOOL_PEN) | BIT_MASK(BTN_STYLUS) |
                 BIT_MASK(BTN_TOOL_MOUSE) | BIT_MASK(BTN_STYLUS2);
-        input_set_abs_params(input_dev, ABS_DISTANCE, 0, wacom_wac->features->distance_max, 0, 0);
+        input_set_abs_params(input_dev, ABS_DISTANCE,
+                             0, wacom_wac->features.distance_max, 0, 0);
 }
 
 void input_dev_i3s(struct input_dev *input_dev, struct wacom_wac *wacom_wac)
@@ -256,10 +258,12 @@ void input_dev_i(struct input_dev *input_dev, struct wacom_wac *wacom_wac)
                 BIT_MASK(BTN_RIGHT) | BIT_MASK(BTN_MIDDLE) |
                 BIT_MASK(BTN_SIDE) | BIT_MASK(BTN_EXTRA);
         input_dev->keybit[BIT_WORD(BTN_DIGI)] |= BIT_MASK(BTN_TOOL_RUBBER) |
+                BIT_MASK(BTN_TOOL_PEN) | BIT_MASK(BTN_STYLUS) |
                 BIT_MASK(BTN_TOOL_MOUSE) | BIT_MASK(BTN_TOOL_BRUSH) |
                 BIT_MASK(BTN_TOOL_PENCIL) | BIT_MASK(BTN_TOOL_AIRBRUSH) |
                 BIT_MASK(BTN_TOOL_LENS) | BIT_MASK(BTN_STYLUS2);
-        input_set_abs_params(input_dev, ABS_DISTANCE, 0, wacom_wac->features->distance_max, 0, 0);
+        input_set_abs_params(input_dev, ABS_DISTANCE,
+                             0, wacom_wac->features.distance_max, 0, 0);
         input_set_abs_params(input_dev, ABS_WHEEL, 0, 1023, 0, 0);
         input_set_abs_params(input_dev, ABS_TILT_X, 0, 127, 0, 0);
         input_set_abs_params(input_dev, ABS_TILT_Y, 0, 127, 0, 0);
@@ -269,7 +273,8 @@ void input_dev_i(struct input_dev *input_dev, struct wacom_wac *wacom_wac)
 
 void input_dev_pl(struct input_dev *input_dev, struct wacom_wac *wacom_wac)
 {
-        input_dev->keybit[BIT_WORD(BTN_DIGI)] |= BIT_MASK(BTN_STYLUS2);
+        input_dev->keybit[BIT_WORD(BTN_DIGI)] |= BIT_MASK(BTN_TOOL_PEN) |
+                BIT_MASK(BTN_STYLUS) | BIT_MASK(BTN_STYLUS2);
 }
 
 void input_dev_pt(struct input_dev *input_dev, struct wacom_wac *wacom_wac)
@@ -277,12 +282,34 @@ void input_dev_pt(struct input_dev *input_dev, struct wacom_wac *wacom_wac)
         input_dev->keybit[BIT_WORD(BTN_DIGI)] |= BIT_MASK(BTN_TOOL_RUBBER);
 }
 
+void input_dev_tpc(struct input_dev *input_dev, struct wacom_wac *wacom_wac)
+{
+        struct wacom_features *features = &wacom_wac->features;
+
+        if (features->device_type == BTN_TOOL_DOUBLETAP ||
+            features->device_type == BTN_TOOL_TRIPLETAP) {
+                input_set_abs_params(input_dev, ABS_RX, 0, features->x_phy, 0, 0);
+                input_set_abs_params(input_dev, ABS_RY, 0, features->y_phy, 0, 0);
+                __set_bit(BTN_TOOL_DOUBLETAP, input_dev->keybit);
+        }
+}
+
+void input_dev_tpc2fg(struct input_dev *input_dev, struct wacom_wac *wacom_wac)
+{
+        if (wacom_wac->features.device_type == BTN_TOOL_TRIPLETAP) {
+                input_dev->keybit[BIT_WORD(BTN_DIGI)] |= BIT_MASK(BTN_TOOL_TRIPLETAP);
+                input_dev->evbit[0] |= BIT_MASK(EV_MSC);
+                input_dev->mscbit[0] |= BIT_MASK(MSC_SERIAL);
+        }
+}
+
 static int wacom_parse_hid(struct usb_interface *intf, struct hid_descriptor *hid_desc,
-                           struct wacom_wac *wacom_wac)
+                           struct wacom_features *features)
 {
         struct usb_device *dev = interface_to_usbdev(intf);
-        struct wacom_features *features = wacom_wac->features;
-        char limit = 0, result = 0;
+        char limit = 0;
+        /* result has to be defined as int for some devices */
+        int result = 0;
         int i = 0, usage = WCM_UNDEFINED, finger = 0, pen = 0;
         unsigned char *report;
 
@@ -328,13 +355,24 @@ static int wacom_parse_hid(struct usb_interface *intf, struct hid_descriptor *hi
                         case HID_USAGE_X:
                                 if (usage == WCM_DESKTOP) {
                                         if (finger) {
-                                                features->touch_x_max =
-                                                        features->touch_y_max =
-                                                        wacom_le16_to_cpu(&report[i + 3]);
+                                                features->device_type = BTN_TOOL_DOUBLETAP;
+                                                if (features->type == TABLETPC2FG) {
+                                                        /* need to reset back */
+                                                        features->pktlen = WACOM_PKGLEN_TPC2FG;
+                                                        features->device_type = BTN_TOOL_TRIPLETAP;
+                                                }
                                                 features->x_max =
+                                                        wacom_le16_to_cpu(&report[i + 3]);
+                                                features->x_phy =
                                                         wacom_le16_to_cpu(&report[i + 6]);
-                                                i += 7;
+                                                features->unit = report[i + 9];
+                                                features->unitExpo = report[i + 11];
+                                                i += 12;
                                         } else if (pen) {
+                                                /* penabled only accepts exact bytes of data */
+                                                if (features->type == TABLETPC2FG)
+                                                        features->pktlen = WACOM_PKGLEN_GRAPHIRE;
+                                                features->device_type = BTN_TOOL_PEN;
                                                 features->x_max =
                                                         wacom_le16_to_cpu(&report[i + 3]);
                                                 i += 4;
@@ -350,10 +388,35 @@ static int wacom_parse_hid(struct usb_interface *intf, struct hid_descriptor *hi
                                 break;
 
                         case HID_USAGE_Y:
-                                if (usage == WCM_DESKTOP)
-                                        features->y_max =
-                                                wacom_le16_to_cpu(&report[i + 3]);
-                                i += 4;
+                                if (usage == WCM_DESKTOP) {
+                                        if (finger) {
+                                                features->device_type = BTN_TOOL_DOUBLETAP;
+                                                if (features->type == TABLETPC2FG) {
+                                                        /* need to reset back */
+                                                        features->pktlen = WACOM_PKGLEN_TPC2FG;
+                                                        features->device_type = BTN_TOOL_TRIPLETAP;
+                                                        features->y_max =
+                                                                wacom_le16_to_cpu(&report[i + 3]);
+                                                        features->y_phy =
+                                                                wacom_le16_to_cpu(&report[i + 6]);
+                                                        i += 7;
+                                                } else {
+                                                        features->y_max =
+                                                                features->x_max;
+                                                        features->y_phy =
+                                                                wacom_le16_to_cpu(&report[i + 3]);
+                                                        i += 4;
+                                                }
+                                        } else if (pen) {
+                                                /* penabled only accepts exact bytes of data */
+                                                if (features->type == TABLETPC2FG)
+                                                        features->pktlen = WACOM_PKGLEN_GRAPHIRE;
+                                                features->device_type = BTN_TOOL_PEN;
+                                                features->y_max =
+                                                        wacom_le16_to_cpu(&report[i + 3]);
+                                                i += 4;
+                                        }
+                                }
                                 break;
 
                         case HID_USAGE_FINGER:
@@ -376,7 +439,7 @@ static int wacom_parse_hid(struct usb_interface *intf, struct hid_descriptor *hi
                         break;
 
                 case HID_COLLECTION:
-                        /* reset UsagePage ans Finger */
+                        /* reset UsagePage and Finger */
                         finger = usage = 0;
                         break;
                 }
@@ -388,57 +451,123 @@ static int wacom_parse_hid(struct usb_interface *intf, struct hid_descriptor *hi
         return result;
 }
 
-static int wacom_query_tablet_data(struct usb_interface *intf)
+static int wacom_query_tablet_data(struct usb_interface *intf, struct wacom_features *features)
 {
         unsigned char *rep_data;
-        int limit = 0;
-        int error;
+        int limit = 0, report_id = 2;
+        int error = -ENOMEM;
 
         rep_data = kmalloc(2, GFP_KERNEL);
         if (!rep_data)
-                return -ENOMEM;
-
-        do {
-                rep_data[0] = 2;
-                rep_data[1] = 2;
-                error = usb_set_report(intf, WAC_HID_FEATURE_REPORT,
-                                        2, rep_data, 2);
-                if (error >= 0)
-                        error = usb_get_report(intf,
-                                                WAC_HID_FEATURE_REPORT, 2,
-                                                rep_data, 2);
-        } while ((error < 0 || rep_data[1] != 2) && limit++ < 5);
+                return error;
+
+        /* ask to report tablet data if it is 2FGT or not a Tablet PC */
+        if (features->device_type == BTN_TOOL_TRIPLETAP) {
+                do {
+                        rep_data[0] = 3;
+                        rep_data[1] = 4;
+                        report_id = 3;
+                        error = usb_set_report(intf, WAC_HID_FEATURE_REPORT,
+                                report_id, rep_data, 2);
+                        if (error >= 0)
+                                error = usb_get_report(intf,
+                                        WAC_HID_FEATURE_REPORT, report_id,
+                                        rep_data, 3);
+                } while ((error < 0 || rep_data[1] != 4) && limit++ < 5);
+        } else if (features->type != TABLETPC && features->type != TABLETPC2FG) {
+                do {
+                        rep_data[0] = 2;
+                        rep_data[1] = 2;
+                        error = usb_set_report(intf, WAC_HID_FEATURE_REPORT,
+                                report_id, rep_data, 2);
+                        if (error >= 0)
+                                error = usb_get_report(intf,
+                                        WAC_HID_FEATURE_REPORT, report_id,
+                                        rep_data, 2);
+                } while ((error < 0 || rep_data[1] != 2) && limit++ < 5);
+        }
 
         kfree(rep_data);
 
         return error < 0 ? error : 0;
 }
 
+static int wacom_retrieve_hid_descriptor(struct usb_interface *intf,
+                struct wacom_features *features)
+{
+        int error = 0;
+        struct usb_host_interface *interface = intf->cur_altsetting;
+        struct hid_descriptor *hid_desc;
+
+        /* default device to penabled */
+        features->device_type = BTN_TOOL_PEN;
+
+        /* only Tablet PCs need to retrieve the info */
+        if ((features->type != TABLETPC) && (features->type != TABLETPC2FG))
+                goto out;
+
+        if (usb_get_extra_descriptor(interface, HID_DEVICET_HID, &hid_desc)) {
+                if (usb_get_extra_descriptor(&interface->endpoint[0],
+                                HID_DEVICET_REPORT, &hid_desc)) {
+                        printk("wacom: can not retrieve extra class descriptor\n");
+                        error = 1;
+                        goto out;
+                }
+        }
+        error = wacom_parse_hid(intf, hid_desc, features);
+        if (error)
+                goto out;
+
+        /* touch device found but size is not defined. use default */
+        if (features->device_type == BTN_TOOL_DOUBLETAP && !features->x_max) {
+                features->x_max = 1023;
+                features->y_max = 1023;
+        }
+
+ out:
+        return error;
+}
+
 static int wacom_probe(struct usb_interface *intf, const struct usb_device_id *id)
 {
         struct usb_device *dev = interface_to_usbdev(intf);
-        struct usb_host_interface *interface = intf->cur_altsetting;
         struct usb_endpoint_descriptor *endpoint;
         struct wacom *wacom;
         struct wacom_wac *wacom_wac;
         struct wacom_features *features;
         struct input_dev *input_dev;
-        int error = -ENOMEM;
-        struct hid_descriptor *hid_desc;
+        int error;
+
+        if (!id->driver_info)
+                return -EINVAL;
 
         wacom = kzalloc(sizeof(struct wacom), GFP_KERNEL);
         wacom_wac = kzalloc(sizeof(struct wacom_wac), GFP_KERNEL);
         input_dev = input_allocate_device();
-        if (!wacom || !input_dev || !wacom_wac)
+        if (!wacom || !input_dev || !wacom_wac) {
+                error = -ENOMEM;
                 goto fail1;
+        }
 
-        wacom_wac->data = usb_buffer_alloc(dev, 10, GFP_KERNEL, &wacom->data_dma);
-        if (!wacom_wac->data)
+        wacom_wac->features = *((struct wacom_features *)id->driver_info);
+        features = &wacom_wac->features;
+        if (features->pktlen > WACOM_PKGLEN_MAX) {
+                error = -EINVAL;
                 goto fail1;
+        }
+
+        wacom_wac->data = usb_buffer_alloc(dev, WACOM_PKGLEN_MAX,
+                                           GFP_KERNEL, &wacom->data_dma);
+        if (!wacom_wac->data) {
+                error = -ENOMEM;
+                goto fail1;
+        }
 
         wacom->irq = usb_alloc_urb(0, GFP_KERNEL);
-        if (!wacom->irq)
+        if (!wacom->irq) {
+                error = -ENOMEM;
                 goto fail2;
+        }
 
         wacom->usbdev = dev;
         wacom->dev = input_dev;
@@ -447,11 +576,6 @@ static int wacom_probe(struct usb_interface *intf, const struct usb_device_id *i
         usb_make_path(dev, wacom->phys, sizeof(wacom->phys));
         strlcat(wacom->phys, "/input0", sizeof(wacom->phys));
 
-        wacom_wac->features = features = get_wacom_feature(id);
-        BUG_ON(features->pktlen > 10);
-
-        input_dev->name = wacom_wac->features->name;
-        wacom->wacom_wac = wacom_wac;
         usb_to_input_id(dev, &input_dev->id);
 
         input_dev->dev.parent = &intf->dev;
@@ -463,47 +587,37 @@ static int wacom_probe(struct usb_interface *intf, const struct usb_device_id *i
 
         endpoint = &intf->cur_altsetting->endpoint[0].desc;
 
-        /* Initialize touch_x_max and touch_y_max in case it is not defined */
-        if (wacom_wac->features->type == TABLETPC) {
-                features->touch_x_max = 1023;
-                features->touch_y_max = 1023;
-        } else {
-                features->touch_x_max = 0;
-                features->touch_y_max = 0;
-        }
+        /* Retrieve the physical and logical size for OEM devices */
+        error = wacom_retrieve_hid_descriptor(intf, features);
+        if (error)
+                goto fail2;
 
-        /* TabletPC need to retrieve the physical and logical maximum from report descriptor */
-        if (wacom_wac->features->type == TABLETPC) {
-                if (usb_get_extra_descriptor(interface, HID_DEVICET_HID, &hid_desc)) {
-                        if (usb_get_extra_descriptor(&interface->endpoint[0],
-                                                     HID_DEVICET_REPORT, &hid_desc)) {
-                                printk("wacom: can not retrive extra class descriptor\n");
-                                goto fail2;
-                        }
-                }
-                error = wacom_parse_hid(intf, hid_desc, wacom_wac);
-                if (error)
-                        goto fail2;
+        strlcpy(wacom_wac->name, features->name, sizeof(wacom_wac->name));
+
+        if (features->type == TABLETPC || features->type == TABLETPC2FG) {
+                /* Append the device type to the name */
+                strlcat(wacom_wac->name,
+                        features->device_type == BTN_TOOL_PEN ?
+                                " Pen" : " Finger",
+                        sizeof(wacom_wac->name));
         }
 
+        input_dev->name = wacom_wac->name;
+        wacom->wacom_wac = wacom_wac;
+
         input_dev->evbit[0] |= BIT_MASK(EV_KEY) | BIT_MASK(EV_ABS);
-        input_dev->keybit[BIT_WORD(BTN_DIGI)] |= BIT_MASK(BTN_TOOL_PEN) |
-                BIT_MASK(BTN_TOUCH) | BIT_MASK(BTN_STYLUS);
+        input_dev->keybit[BIT_WORD(BTN_DIGI)] |= BIT_MASK(BTN_TOUCH);
+
         input_set_abs_params(input_dev, ABS_X, 0, features->x_max, 4, 0);
         input_set_abs_params(input_dev, ABS_Y, 0, features->y_max, 4, 0);
         input_set_abs_params(input_dev, ABS_PRESSURE, 0, features->pressure_max, 0, 0);
-        if (features->type == TABLETPC) {
-                input_dev->keybit[BIT_WORD(BTN_DIGI)] |= BIT_MASK(BTN_TOOL_DOUBLETAP);
-                input_set_abs_params(input_dev, ABS_RX, 0, features->touch_x_max, 4, 0);
-                input_set_abs_params(input_dev, ABS_RY, 0, features->touch_y_max, 4, 0);
-        }
         input_dev->absbit[BIT_WORD(ABS_MISC)] |= BIT_MASK(ABS_MISC);
 
         wacom_init_input_dev(input_dev, wacom_wac);
 
         usb_fill_int_urb(wacom->irq, dev,
                          usb_rcvintpipe(dev, endpoint->bEndpointAddress),
-                         wacom_wac->data, wacom_wac->features->pktlen,
+                         wacom_wac->data, features->pktlen,
                          wacom_sys_irq, wacom, endpoint->bInterval);
         wacom->irq->transfer_dma = wacom->data_dma;
         wacom->irq->transfer_flags |= URB_NO_TRANSFER_DMA_MAP;
@@ -512,18 +626,14 @@ static int wacom_probe(struct usb_interface *intf, const struct usb_device_id *i
         if (error)
                 goto fail3;
 
-        /*
-         * Ask the tablet to report tablet data if it is not a Tablet PC.
-         * Note that if query fails it is not a hard failure.
-         */
-        if (wacom_wac->features->type != TABLETPC)
-                wacom_query_tablet_data(intf);
+        /* Note that if query fails it is not a hard failure */
+        wacom_query_tablet_data(intf, features);
 
         usb_set_intfdata(intf, wacom);
         return 0;
 
  fail3: usb_free_urb(wacom->irq);
- fail2: usb_buffer_free(dev, 10, wacom_wac->data, wacom->data_dma);
+ fail2: usb_buffer_free(dev, WACOM_PKGLEN_MAX, wacom_wac->data, wacom->data_dma);
  fail1: input_free_device(input_dev);
         kfree(wacom);
         kfree(wacom_wac);
@@ -539,7 +649,7 @@ static void wacom_disconnect(struct usb_interface *intf)
         usb_kill_urb(wacom->irq);
         input_unregister_device(wacom->dev);
         usb_free_urb(wacom->irq);
-        usb_buffer_free(interface_to_usbdev(intf), 10,
+        usb_buffer_free(interface_to_usbdev(intf), WACOM_PKGLEN_MAX,
                         wacom->wacom_wac->data, wacom->data_dma);
         kfree(wacom->wacom_wac);
         kfree(wacom);
@@ -559,12 +669,16 @@ static int wacom_suspend(struct usb_interface *intf, pm_message_t message)
 static int wacom_resume(struct usb_interface *intf)
 {
         struct wacom *wacom = usb_get_intfdata(intf);
+        struct wacom_features *features = &wacom->wacom_wac->features;
         int rv;
 
         mutex_lock(&wacom->lock);
-        if (wacom->open)
+        if (wacom->open) {
                 rv = usb_submit_urb(wacom->irq, GFP_NOIO);
-        else
+                /* switch to wacom mode if needed */
+                if (!wacom_retrieve_hid_descriptor(intf, features))
+                        wacom_query_tablet_data(intf, features);
+        } else
                 rv = 0;
         mutex_unlock(&wacom->lock);
 
@@ -578,6 +692,7 @@ static int wacom_reset_resume(struct usb_interface *intf)
 
 static struct usb_driver wacom_driver = {
         .name =         "wacom",
+        .id_table =     wacom_ids,
         .probe =        wacom_probe,
         .disconnect =   wacom_disconnect,
         .suspend =      wacom_suspend,
@@ -589,7 +704,7 @@ static struct usb_driver wacom_driver = {
 static int __init wacom_init(void)
 {
         int result;
-        wacom_driver.id_table = get_device_table();
+
         result = usb_register(&wacom_driver);
         if (result == 0)
                 printk(KERN_INFO KBUILD_MODNAME ": " DRIVER_VERSION ":"
diff --git a/drivers/input/tablet/wacom_wac.c b/drivers/input/tablet/wacom_wac.c
index c896d6a21b7e..b3ba3437a2eb 100644
--- a/drivers/input/tablet/wacom_wac.c
+++ b/drivers/input/tablet/wacom_wac.c
@@ -1,7 +1,7 @@
 /*
  * drivers/input/tablet/wacom_wac.c
  *
- *  USB Wacom Graphire and Wacom Intuos tablet support - Wacom specific code
+ *  USB Wacom tablet support - Wacom specific code
  *
  */
 
@@ -55,23 +55,23 @@ static int wacom_penpartner_irq(struct wacom_wac *wacom, void *wcombo)
 
 static int wacom_pl_irq(struct wacom_wac *wacom, void *wcombo)
 {
+        struct wacom_features *features = &wacom->features;
         unsigned char *data = wacom->data;
         int prox, pressure;
 
-        if (data[0] != 2) {
+        if (data[0] != WACOM_REPORT_PENABLED) {
                 dbg("wacom_pl_irq: received unknown report #%d", data[0]);
                 return 0;
         }
 
         prox = data[1] & 0x40;
 
-        wacom->id[0] = ERASER_DEVICE_ID;
         if (prox) {
-
+                wacom->id[0] = ERASER_DEVICE_ID;
                 pressure = (signed char)((data[7] << 1) | ((data[4] >> 2) & 1));
-                if (wacom->features->pressure_max > 255)
+                if (features->pressure_max > 255)
                         pressure = (pressure << 1) | ((data[4] >> 6) & 1);
-                pressure += (wacom->features->pressure_max + 1) / 2;
+                pressure += (features->pressure_max + 1) / 2;
 
                 /*
                  * if going from out of proximity into proximity select between the eraser
@@ -128,7 +128,7 @@ static int wacom_ptu_irq(struct wacom_wac *wacom, void *wcombo)
 {
         unsigned char *data = wacom->data;
 
-        if (data[0] != 2) {
+        if (data[0] != WACOM_REPORT_PENABLED) {
                 printk(KERN_INFO "wacom_ptu_irq: received unknown report #%d\n", data[0]);
                 return 0;
         }
@@ -153,18 +153,21 @@ static int wacom_ptu_irq(struct wacom_wac *wacom, void *wcombo)
 
 static int wacom_graphire_irq(struct wacom_wac *wacom, void *wcombo)
 {
+        struct wacom_features *features = &wacom->features;
         unsigned char *data = wacom->data;
-        int x, y, rw;
+        int x, y, prox;
+        int rw = 0;
+        int retval = 0;
 
-        if (data[0] != 2) {
+        if (data[0] != WACOM_REPORT_PENABLED) {
                 dbg("wacom_graphire_irq: received unknown report #%d", data[0]);
-                return 0;
+                goto exit;
         }
 
-        if (data[1] & 0x80) {
-                /* in prox and not a pad data */
-
-                switch ((data[1] >> 5) & 3) {
+        prox = data[1] & 0x80;
+        if (prox || wacom->id[0]) {
+                if (prox) {
+                        switch ((data[1] >> 5) & 3) {
 
                         case 0: /* Pen */
                                 wacom->tool[0] = BTN_TOOL_PEN;
@@ -178,25 +181,13 @@ static int wacom_graphire_irq(struct wacom_wac *wacom, void *wcombo)
 
                         case 2: /* Mouse with wheel */
                                 wacom_report_key(wcombo, BTN_MIDDLE, data[1] & 0x04);
-                                if (wacom->features->type == WACOM_G4 ||
-                                                wacom->features->type == WACOM_MO) {
-                                        rw = data[7] & 0x04 ? (data[7] & 0x03)-4 : (data[7] & 0x03);
-                                        wacom_report_rel(wcombo, REL_WHEEL, -rw);
-                                } else
-                                        wacom_report_rel(wcombo, REL_WHEEL, -(signed char) data[6]);
                                 /* fall through */
 
                         case 3: /* Mouse without wheel */
                                 wacom->tool[0] = BTN_TOOL_MOUSE;
                                 wacom->id[0] = CURSOR_DEVICE_ID;
-                                wacom_report_key(wcombo, BTN_LEFT, data[1] & 0x01);
-                                wacom_report_key(wcombo, BTN_RIGHT, data[1] & 0x02);
-                                if (wacom->features->type == WACOM_G4 ||
-                                                wacom->features->type == WACOM_MO)
-                                        wacom_report_abs(wcombo, ABS_DISTANCE, data[6] & 0x3f);
-                                else
-                                        wacom_report_abs(wcombo, ABS_DISTANCE, data[7] & 0x3f);
                                 break;
+                        }
                 }
                 x = wacom_le16_to_cpu(&data[2]);
                 y = wacom_le16_to_cpu(&data[4]);
@@ -207,32 +198,32 @@ static int wacom_graphire_irq(struct wacom_wac *wacom, void *wcombo)
                         wacom_report_key(wcombo, BTN_TOUCH, data[1] & 0x01);
                         wacom_report_key(wcombo, BTN_STYLUS, data[1] & 0x02);
                         wacom_report_key(wcombo, BTN_STYLUS2, data[1] & 0x04);
-                }
-                wacom_report_abs(wcombo, ABS_MISC, wacom->id[0]); /* report tool id */
-                wacom_report_key(wcombo, wacom->tool[0], 1);
-        } else if (wacom->id[0]) {
-                wacom_report_abs(wcombo, ABS_X, 0);
-                wacom_report_abs(wcombo, ABS_Y, 0);
-                if (wacom->tool[0] == BTN_TOOL_MOUSE) {
-                        wacom_report_key(wcombo, BTN_LEFT, 0);
-                        wacom_report_key(wcombo, BTN_RIGHT, 0);
-                        wacom_report_abs(wcombo, ABS_DISTANCE, 0);
                 } else {
-                        wacom_report_abs(wcombo, ABS_PRESSURE, 0);
-                        wacom_report_key(wcombo, BTN_TOUCH, 0);
-                        wacom_report_key(wcombo, BTN_STYLUS, 0);
-                        wacom_report_key(wcombo, BTN_STYLUS2, 0);
+                        wacom_report_key(wcombo, BTN_LEFT, data[1] & 0x01);
+                        wacom_report_key(wcombo, BTN_RIGHT, data[1] & 0x02);
+                        if (features->type == WACOM_G4 ||
+                                        features->type == WACOM_MO) {
+                                wacom_report_abs(wcombo, ABS_DISTANCE, data[6] & 0x3f);
+                                rw = (signed)(data[7] & 0x04) - (data[7] & 0x03);
+                        } else {
+                                wacom_report_abs(wcombo, ABS_DISTANCE, data[7] & 0x3f);
+                                rw = -(signed)data[6];
+                        }
+                        wacom_report_rel(wcombo, REL_WHEEL, rw);
                 }
-                wacom->id[0] = 0;
-                wacom_report_abs(wcombo, ABS_MISC, 0); /* reset tool id */
-                wacom_report_key(wcombo, wacom->tool[0], 0);
+
+                if (!prox)
+                        wacom->id[0] = 0;
+                wacom_report_abs(wcombo, ABS_MISC, wacom->id[0]); /* report tool id */
+                wacom_report_key(wcombo, wacom->tool[0], prox);
+                wacom_input_sync(wcombo); /* sync last event */
         }
 
         /* send pad data */
-        switch (wacom->features->type) {
+        switch (features->type) {
             case WACOM_G4:
-                if (data[7] & 0xf8) {
-                        wacom_input_sync(wcombo); /* sync last event */
+                prox = data[7] & 0xf8;
+                if (prox || wacom->id[1]) {
                         wacom->id[1] = PAD_DEVICE_ID;
                         wacom_report_key(wcombo, BTN_0, (data[7] & 0x40));
                         wacom_report_key(wcombo, BTN_4, (data[7] & 0x80));
@@ -240,20 +231,16 @@ static int wacom_graphire_irq(struct wacom_wac *wacom, void *wcombo)
                         wacom_report_rel(wcombo, REL_WHEEL, rw);
                         wacom_report_key(wcombo, BTN_TOOL_FINGER, 0xf0);
                         wacom_report_abs(wcombo, ABS_MISC, wacom->id[1]);
-                        wacom_input_event(wcombo, EV_MSC, MSC_SERIAL, 0xf0);
-                } else if (wacom->id[1]) {
-                        wacom_input_sync(wcombo); /* sync last event */
-                        wacom->id[1] = 0;
-                        wacom_report_key(wcombo, BTN_0, (data[7] & 0x40));
-                        wacom_report_key(wcombo, BTN_4, (data[7] & 0x80));
-                        wacom_report_key(wcombo, BTN_TOOL_FINGER, 0);
-                        wacom_report_abs(wcombo, ABS_MISC, 0);
+                        if (!prox)
+                                wacom->id[1] = 0;
+                        wacom_report_abs(wcombo, ABS_MISC, wacom->id[1]);
                         wacom_input_event(wcombo, EV_MSC, MSC_SERIAL, 0xf0);
                 }
+                retval = 1;
                 break;
             case WACOM_MO:
-                if ((data[7] & 0xf8) || (data[8] & 0xff)) {
-                        wacom_input_sync(wcombo); /* sync last event */
+                prox = (data[7] & 0xf8) || data[8];
+                if (prox || wacom->id[1]) {
                         wacom->id[1] = PAD_DEVICE_ID;
                         wacom_report_key(wcombo, BTN_0, (data[7] & 0x08));
                         wacom_report_key(wcombo, BTN_1, (data[7] & 0x20));
@@ -261,32 +248,26 @@ static int wacom_graphire_irq(struct wacom_wac *wacom, void *wcombo)
                         wacom_report_key(wcombo, BTN_5, (data[7] & 0x40));
                         wacom_report_abs(wcombo, ABS_WHEEL, (data[8] & 0x7f));
                         wacom_report_key(wcombo, BTN_TOOL_FINGER, 0xf0);
+                        if (!prox)
+                                wacom->id[1] = 0;
                         wacom_report_abs(wcombo, ABS_MISC, wacom->id[1]);
                         wacom_input_event(wcombo, EV_MSC, MSC_SERIAL, 0xf0);
-                } else if (wacom->id[1]) {
-                        wacom_input_sync(wcombo); /* sync last event */
-                        wacom->id[1] = 0;
-                        wacom_report_key(wcombo, BTN_0, (data[7] & 0x08));
-                        wacom_report_key(wcombo, BTN_1, (data[7] & 0x20));
-                        wacom_report_key(wcombo, BTN_4, (data[7] & 0x10));
-                        wacom_report_key(wcombo, BTN_5, (data[7] & 0x40));
-                        wacom_report_abs(wcombo, ABS_WHEEL, (data[8] & 0x7f));
-                        wacom_report_key(wcombo, BTN_TOOL_FINGER, 0);
-                        wacom_report_abs(wcombo, ABS_MISC, 0);
-                        wacom_input_event(wcombo, EV_MSC, MSC_SERIAL, 0xf0);
                 }
+                retval = 1;
                 break;
         }
-        return 1;
+exit:
+        return retval;
 }
 
 static int wacom_intuos_inout(struct wacom_wac *wacom, void *wcombo)
 {
+        struct wacom_features *features = &wacom->features;
         unsigned char *data = wacom->data;
         int idx = 0;
 
         /* tool number */
-        if (wacom->features->type == INTUOS)
+        if (features->type == INTUOS)
                 idx = data[1] & 0x01;
 
         /* Enter report */
@@ -384,7 +365,7 @@ static int wacom_intuos_inout(struct wacom_wac *wacom, void *wcombo)
                         wacom_report_key(wcombo, BTN_STYLUS2, 0);
                         wacom_report_key(wcombo, BTN_TOUCH, 0);
                         wacom_report_abs(wcombo, ABS_WHEEL, 0);
-                        if (wacom->features->type >= INTUOS3S)
+                        if (features->type >= INTUOS3S)
                                 wacom_report_abs(wcombo, ABS_Z, 0);
                 }
                 wacom_report_key(wcombo, wacom->tool[idx], 0);
@@ -398,13 +379,14 @@ static int wacom_intuos_inout(struct wacom_wac *wacom, void *wcombo)
 
 static void wacom_intuos_general(struct wacom_wac *wacom, void *wcombo)
 {
+        struct wacom_features *features = &wacom->features;
         unsigned char *data = wacom->data;
         unsigned int t;
 
         /* general pen packet */
         if ((data[1] & 0xb8) == 0xa0) {
                 t = (data[6] << 2) | ((data[7] >> 6) & 3);
-                if (wacom->features->type >= INTUOS4S && wacom->features->type <= INTUOS4L)
+                if (features->type >= INTUOS4S && features->type <= INTUOS4L)
                         t = (t << 1) | (data[1] & 1);
                 wacom_report_abs(wcombo, ABS_PRESSURE, t);
                 wacom_report_abs(wcombo, ABS_TILT_X,
@@ -428,26 +410,28 @@ static void wacom_intuos_general(struct wacom_wac *wacom, void *wcombo)
 
 static int wacom_intuos_irq(struct wacom_wac *wacom, void *wcombo)
 {
+        struct wacom_features *features = &wacom->features;
         unsigned char *data = wacom->data;
         unsigned int t;
         int idx = 0, result;
 
-        if (data[0] != 2 && data[0] != 5 && data[0] != 6 && data[0] != 12) {
+        if (data[0] != WACOM_REPORT_PENABLED && data[0] != WACOM_REPORT_INTUOSREAD
+                && data[0] != WACOM_REPORT_INTUOSWRITE && data[0] != WACOM_REPORT_INTUOSPAD) {
                 dbg("wacom_intuos_irq: received unknown report #%d", data[0]);
                 return 0;
         }
 
         /* tool number */
-        if (wacom->features->type == INTUOS)
+        if (features->type == INTUOS)
                 idx = data[1] & 0x01;
 
         /* pad packets. Works as a second tool and is always in prox */
-        if (data[0] == 12) {
+        if (data[0] == WACOM_REPORT_INTUOSPAD) {
                 /* initiate the pad as a device */
                 if (wacom->tool[1] != BTN_TOOL_FINGER)
                         wacom->tool[1] = BTN_TOOL_FINGER;
 
-                if (wacom->features->type >= INTUOS4S && wacom->features->type <= INTUOS4L) {
+                if (features->type >= INTUOS4S && features->type <= INTUOS4L) {
                         wacom_report_key(wcombo, BTN_0, (data[2] & 0x01));
                         wacom_report_key(wcombo, BTN_1, (data[3] & 0x01));
                         wacom_report_key(wcombo, BTN_2, (data[3] & 0x02));
@@ -461,7 +445,7 @@ static int wacom_intuos_irq(struct wacom_wac *wacom, void *wcombo)
                                 /* Out of proximity, clear wheel value. */
                                 wacom_report_abs(wcombo, ABS_WHEEL, 0);
                         }
-                        if (wacom->features->type != INTUOS4S) {
+                        if (features->type != INTUOS4S) {
                                 wacom_report_key(wcombo, BTN_7, (data[3] & 0x40));
                                 wacom_report_key(wcombo, BTN_8, (data[3] & 0x80));
                         }
@@ -509,18 +493,20 @@ static int wacom_intuos_irq(struct wacom_wac *wacom, void *wcombo)
                 return 0;
 
         /* Only large Intuos support Lense Cursor */
-        if ((wacom->tool[idx] == BTN_TOOL_LENS)
-                        && ((wacom->features->type == INTUOS3)
-                        || (wacom->features->type == INTUOS3S)
-                        || (wacom->features->type == INTUOS4)
-                        || (wacom->features->type == INTUOS4S)))
+        if (wacom->tool[idx] == BTN_TOOL_LENS &&
+            (features->type == INTUOS3 ||
+             features->type == INTUOS3S ||
+             features->type == INTUOS4 ||
+             features->type == INTUOS4S)) {
+
                 return 0;
+        }
 
         /* Cintiq doesn't send data when RDY bit isn't set */
-        if ((wacom->features->type == CINTIQ) && !(data[1] & 0x40))
+        if (features->type == CINTIQ && !(data[1] & 0x40))
                  return 0;
 
-        if (wacom->features->type >= INTUOS3S) {
+        if (features->type >= INTUOS3S) {
                 wacom_report_abs(wcombo, ABS_X, (data[2] << 9) | (data[3] << 1) | ((data[9] >> 1) & 1));
                 wacom_report_abs(wcombo, ABS_Y, (data[4] << 9) | (data[5] << 1) | (data[9] & 1));
                 wacom_report_abs(wcombo, ABS_DISTANCE, ((data[9] >> 2) & 0x3f));
@@ -538,7 +524,7 @@ static int wacom_intuos_irq(struct wacom_wac *wacom, void *wcombo)
 
                 if (data[1] & 0x02) {
                         /* Rotation packet */
-                        if (wacom->features->type >= INTUOS3S) {
+                        if (features->type >= INTUOS3S) {
                                 /* I3 marker pen rotation */
                                 t = (data[6] << 3) | ((data[7] >> 5) & 7);
                                 t = (data[7] & 0x20) ? ((t > 900) ? ((t-1) / 2 - 1350) :
@@ -551,7 +537,7 @@ static int wacom_intuos_irq(struct wacom_wac *wacom, void *wcombo)
                                         ((t - 1) / 2) : -t / 2);
                         }
 
-                } else if (!(data[1] & 0x10) && wacom->features->type < INTUOS3S) {
+                } else if (!(data[1] & 0x10) && features->type < INTUOS3S) {
                         /* 4D mouse packet */
                         wacom_report_key(wcombo, BTN_LEFT,   data[8] & 0x01);
                         wacom_report_key(wcombo, BTN_MIDDLE, data[8] & 0x02);
@@ -564,7 +550,7 @@ static int wacom_intuos_irq(struct wacom_wac *wacom, void *wcombo)
 
                 } else if (wacom->tool[idx] == BTN_TOOL_MOUSE) {
                         /* I4 mouse */
-                        if (wacom->features->type >= INTUOS4S && wacom->features->type <= INTUOS4L) {
+                        if (features->type >= INTUOS4S && features->type <= INTUOS4L) {
                                 wacom_report_key(wcombo, BTN_LEFT,   data[6] & 0x01);
                                 wacom_report_key(wcombo, BTN_MIDDLE, data[6] & 0x02);
                                 wacom_report_key(wcombo, BTN_RIGHT,  data[6] & 0x04);
@@ -585,13 +571,13 @@ static int wacom_intuos_irq(struct wacom_wac *wacom, void *wcombo)
                                                  - ((data[8] & 0x02) >> 1));
 
                                 /* I3 2D mouse side buttons */
-                                if (wacom->features->type >= INTUOS3S && wacom->features->type <= INTUOS3L) {
+                                if (features->type >= INTUOS3S && features->type <= INTUOS3L) {
                                         wacom_report_key(wcombo, BTN_SIDE,   data[8] & 0x40);
                                         wacom_report_key(wcombo, BTN_EXTRA,  data[8] & 0x20);
                                 }
                         }
-                } else if ((wacom->features->type < INTUOS3S || wacom->features->type == INTUOS3L ||
-                                wacom->features->type == INTUOS4L) &&
+                } else if ((features->type < INTUOS3S || features->type == INTUOS3L ||
+                                features->type == INTUOS4L) &&
                            wacom->tool[idx] == BTN_TOOL_LENS) {
                         /* Lens cursor packets */
                         wacom_report_key(wcombo, BTN_LEFT,   data[8] & 0x01);
@@ -608,115 +594,181 @@ static int wacom_intuos_irq(struct wacom_wac *wacom, void *wcombo)
         return 1;
 }
 
+
+static void wacom_tpc_finger_in(struct wacom_wac *wacom, void *wcombo, char *data, int idx)
+{
+        wacom_report_abs(wcombo, ABS_X,
+                data[2 + idx * 2] | ((data[3 + idx * 2] & 0x7f) << 8));
+        wacom_report_abs(wcombo, ABS_Y,
+                data[6 + idx * 2] | ((data[7 + idx * 2] & 0x7f) << 8));
+        wacom_report_abs(wcombo, ABS_MISC, wacom->id[0]);
+        wacom_report_key(wcombo, wacom->tool[idx], 1);
+        if (idx)
+                wacom_input_event(wcombo, EV_MSC, MSC_SERIAL, 0xf0);
+        else
+                wacom_report_key(wcombo, BTN_TOUCH, 1);
+}
+
+static void wacom_tpc_touch_out(struct wacom_wac *wacom, void *wcombo, int idx)
+{
+        wacom_report_abs(wcombo, ABS_X, 0);
+        wacom_report_abs(wcombo, ABS_Y, 0);
+        wacom_report_abs(wcombo, ABS_MISC, 0);
+        wacom_report_key(wcombo, wacom->tool[idx], 0);
+        if (idx)
+                wacom_input_event(wcombo, EV_MSC, MSC_SERIAL, 0xf0);
+        else
+                wacom_report_key(wcombo, BTN_TOUCH, 0);
+        return;
+}
+
+static void wacom_tpc_touch_in(struct wacom_wac *wacom, void *wcombo)
+{
+        char *data = wacom->data;
+        struct urb *urb = ((struct wacom_combo *)wcombo)->urb;
+        static int firstFinger = 0;
+        static int secondFinger = 0;
+
+        wacom->tool[0] = BTN_TOOL_DOUBLETAP;
+        wacom->id[0] = TOUCH_DEVICE_ID;
+        wacom->tool[1] = BTN_TOOL_TRIPLETAP;
+
+        if (urb->actual_length != WACOM_PKGLEN_TPC1FG) {
+                switch (data[0]) {
+                        case WACOM_REPORT_TPC1FG:
+                                wacom_report_abs(wcombo, ABS_X, wacom_le16_to_cpu(&data[2]));
+                                wacom_report_abs(wcombo, ABS_Y, wacom_le16_to_cpu(&data[4]));
+                                wacom_report_abs(wcombo, ABS_PRESSURE, wacom_le16_to_cpu(&data[6]));
+                                wacom_report_key(wcombo, BTN_TOUCH, wacom_le16_to_cpu(&data[6]));
+                                wacom_report_abs(wcombo, ABS_MISC, wacom->id[0]);
+                                wacom_report_key(wcombo, wacom->tool[0], 1);
+                                break;
+                        case WACOM_REPORT_TPC2FG:
+                                /* keep this byte to send proper out-prox event */
+                                wacom->id[1] = data[1] & 0x03;
+
+                                if (data[1] & 0x01) {
+                                        wacom_tpc_finger_in(wacom, wcombo, data, 0);
+                                        firstFinger = 1;
+                                } else if (firstFinger) {
+                                        wacom_tpc_touch_out(wacom, wcombo, 0);
+                                }
+
+                                if (data[1] & 0x02) {
+                                        /* sync first finger data */
+                                        if (firstFinger)
+                                                wacom_input_sync(wcombo);
+
+                                        wacom_tpc_finger_in(wacom, wcombo, data, 1);
+                                        secondFinger = 1;
+                                } else if (secondFinger) {
+                                        /* sync first finger data */
+                                        if (firstFinger)
+                                                wacom_input_sync(wcombo);
+
+                                        wacom_tpc_touch_out(wacom, wcombo, 1);
+                                        secondFinger = 0;
+                                }
+                                if (!(data[1] & 0x01))
+                                        firstFinger = 0;
+                                break;
+                }
+        } else {
+                wacom_report_abs(wcombo, ABS_X, wacom_le16_to_cpu(&data[1]));
+                wacom_report_abs(wcombo, ABS_Y, wacom_le16_to_cpu(&data[3]));
+                wacom_report_key(wcombo, BTN_TOUCH, 1);
+                wacom_report_abs(wcombo, ABS_MISC, wacom->id[0]);
+                wacom_report_key(wcombo, wacom->tool[0], 1);
+        }
+        return;
+}
+
 static int wacom_tpc_irq(struct wacom_wac *wacom, void *wcombo)
 {
+        struct wacom_features *features = &wacom->features;
         char *data = wacom->data;
-        int prox = 0, pressure;
+        int prox = 0, pressure, idx = -1;
         static int stylusInProx, touchInProx = 1, touchOut;
         struct urb *urb = ((struct wacom_combo *)wcombo)->urb;
 
         dbg("wacom_tpc_irq: received report #%d", data[0]);
 
-        if (urb->actual_length == 5 || data[0] == 6) { /* Touch data */
-                if (urb->actual_length == 5) {  /* with touch */
-                        prox = data[0] & 0x03;
+        if (urb->actual_length == WACOM_PKGLEN_TPC1FG || /* single touch */
+            data[0] == WACOM_REPORT_TPC1FG ||            /* single touch */
+            data[0] == WACOM_REPORT_TPC2FG) {            /* 2FG touch */
+                if (urb->actual_length == WACOM_PKGLEN_TPC1FG) {  /* with touch */
+                        prox = data[0] & 0x01;
                 } else {  /* with capacity */
-                        prox = data[1] & 0x03;
+                        if (data[0] == WACOM_REPORT_TPC1FG)
+                                /* single touch */
+                                prox = data[1] & 0x01;
+                        else
+                                /* 2FG touch data */
+                                prox = data[1] & 0x03;
                 }
 
                 if (!stylusInProx) { /* stylus not in prox */
                         if (prox) {
                                 if (touchInProx) {
-                                        wacom->tool[1] = BTN_TOOL_DOUBLETAP;
-                                        wacom->id[0] = TOUCH_DEVICE_ID;
-                                        if (urb->actual_length != 5) {
-                                                wacom_report_abs(wcombo, ABS_X, wacom_le16_to_cpu(&data[2]));
-                                                wacom_report_abs(wcombo, ABS_Y, wacom_le16_to_cpu(&data[4]));
-                                                wacom_report_abs(wcombo, ABS_PRESSURE, wacom_le16_to_cpu(&data[6]));
-                                                wacom_report_key(wcombo, BTN_TOUCH, wacom_le16_to_cpu(&data[6]));
-                                        } else {
-                                                wacom_report_abs(wcombo, ABS_X, wacom_le16_to_cpu(&data[1]));
-                                                wacom_report_abs(wcombo, ABS_Y, wacom_le16_to_cpu(&data[3]));
-                                                wacom_report_key(wcombo, BTN_TOUCH, 1);
-                                        }
-                                        wacom_report_abs(wcombo, ABS_MISC, wacom->id[0]);
-                                        wacom_report_key(wcombo, wacom->tool[1], prox & 0x01);
+                                        wacom_tpc_touch_in(wacom, wcombo);
                                         touchOut = 1;
                                         return 1;
                                 }
                         } else {
-                                wacom_report_abs(wcombo, ABS_MISC, wacom->id[0]);
-                                wacom_report_key(wcombo, wacom->tool[1], prox & 0x01);
-                                wacom_report_key(wcombo, BTN_TOUCH, 0);
+                                /* 2FGT out-prox */
+                                if (data[0] == WACOM_REPORT_TPC2FG) {
+                                        idx = (wacom->id[1] & 0x01) - 1;
+                                        if (idx == 0) {
+                                                wacom_tpc_touch_out(wacom, wcombo, idx);
+                                                /* sync first finger event */
+                                                if (wacom->id[1] & 0x02)
+                                                        wacom_input_sync(wcombo);
+                                        }
+                                        idx = (wacom->id[1] & 0x02) - 1;
+                                        if (idx == 1)
+                                                wacom_tpc_touch_out(wacom, wcombo, idx);
+                                } else /* one finger touch */
+                                        wacom_tpc_touch_out(wacom, wcombo, 0);
                                 touchOut = 0;
                                 touchInProx = 1;
                                 return 1;
                         }
                 } else if (touchOut || !prox) { /* force touch out-prox */
-                        wacom_report_abs(wcombo, ABS_MISC, TOUCH_DEVICE_ID);
-                        wacom_report_key(wcombo, wacom->tool[1], 0);
-                        wacom_report_key(wcombo, BTN_TOUCH, 0);
+                        wacom_tpc_touch_out(wacom, wcombo, 0);
                         touchOut = 0;
                         touchInProx = 1;
                         return 1;
                 }
-        } else if (data[0] == 2) { /* Penabled */
+        } else if (data[0] == WACOM_REPORT_PENABLED) { /* Penabled */
                 prox = data[1] & 0x20;
 
                 touchInProx = 0;
 
-                wacom->id[0] = ERASER_DEVICE_ID;
-
-                /*
-                 * if going from out of proximity into proximity select between the eraser
-                 * and the pen based on the state of the stylus2 button, choose eraser if
-                 * pressed else choose pen. if not a proximity change from out to in, send
-                 * an out of proximity for previous tool then a in for new tool.
-                 */
-                if (prox) { /* in prox */
-                        if (!wacom->tool[0]) {
-                                /* Going into proximity select tool */
-                                wacom->tool[1] = (data[1] & 0x08) ? BTN_TOOL_RUBBER : BTN_TOOL_PEN;
-                                if (wacom->tool[1] == BTN_TOOL_PEN)
-                                        wacom->id[0] = STYLUS_DEVICE_ID;
-                        } else if (wacom->tool[1] == BTN_TOOL_RUBBER && !(data[1] & 0x08)) {
-                                /*
-                                 * was entered with stylus2 pressed
-                                 * report out proximity for previous tool
-                                */
-                                wacom_report_abs(wcombo, ABS_MISC, wacom->id[0]);
-                                wacom_report_key(wcombo, wacom->tool[1], 0);
-                                wacom_input_sync(wcombo);
-
-                                /* set new tool */
-                                wacom->tool[1] = BTN_TOOL_PEN;
+                if (!wacom->id[0]) { /* first in prox */
+                        /* Going into proximity select tool */
+                        wacom->tool[0] = (data[1] & 0x0c) ? BTN_TOOL_RUBBER : BTN_TOOL_PEN;
+                        if (wacom->tool[0] == BTN_TOOL_PEN)
                                 wacom->id[0] = STYLUS_DEVICE_ID;
-                                return 0;
-                        }
-                        if (wacom->tool[1] != BTN_TOOL_RUBBER) {
-                                /* Unknown tool selected default to pen tool */
-                                wacom->tool[1] = BTN_TOOL_PEN;
-                                wacom->id[0] = STYLUS_DEVICE_ID;
-                        }
-                        wacom_report_key(wcombo, BTN_STYLUS, data[1] & 0x02);
-                        wacom_report_key(wcombo, BTN_STYLUS2, data[1] & 0x10);
-                        wacom_report_abs(wcombo, ABS_X, wacom_le16_to_cpu(&data[2]));
-                        wacom_report_abs(wcombo, ABS_Y, wacom_le16_to_cpu(&data[4]));
-                        pressure = ((data[7] & 0x01) << 8) | data[6];
-                        if (pressure < 0)
-                                pressure = wacom->features->pressure_max + pressure + 1;
-                        wacom_report_abs(wcombo, ABS_PRESSURE, pressure);
-                        wacom_report_key(wcombo, BTN_TOUCH, pressure);
-                } else {
-                        wacom_report_abs(wcombo, ABS_PRESSURE, 0);
-                        wacom_report_key(wcombo, BTN_STYLUS, 0);
-                        wacom_report_key(wcombo, BTN_STYLUS2, 0);
-                        wacom_report_key(wcombo, BTN_TOUCH, 0);
+                        else
+                                wacom->id[0] = ERASER_DEVICE_ID;
                 }
-                wacom_report_key(wcombo, wacom->tool[1], prox);
+                wacom_report_key(wcombo, BTN_STYLUS, data[1] & 0x02);
+                wacom_report_key(wcombo, BTN_STYLUS2, data[1] & 0x10);
+                wacom_report_abs(wcombo, ABS_X, wacom_le16_to_cpu(&data[2]));
+                wacom_report_abs(wcombo, ABS_Y, wacom_le16_to_cpu(&data[4]));
+                pressure = ((data[7] & 0x01) << 8) | data[6];
+                if (pressure < 0)
+                        pressure = features->pressure_max + pressure + 1;
+                wacom_report_abs(wcombo, ABS_PRESSURE, pressure);
+                wacom_report_key(wcombo, BTN_TOUCH, data[1] & 0x05);
+                if (!prox) { /* out-prox */
+                        wacom->id[0] = 0;
+                        /* pen is out so touch can be enabled now */
+                        touchInProx = 1;
+                }
+                wacom_report_key(wcombo, wacom->tool[0], prox);
                 wacom_report_abs(wcombo, ABS_MISC, wacom->id[0]);
                 stylusInProx = prox;
-                wacom->tool[0] = prox;
                 return 1;
         }
         return 0;
@@ -724,7 +776,7 @@ static int wacom_tpc_irq(struct wacom_wac *wacom, void *wcombo)
 
 int wacom_wac_irq(struct wacom_wac *wacom_wac, void *wcombo)
 {
-        switch (wacom_wac->features->type) {
+        switch (wacom_wac->features.type) {
                 case PENPARTNER:
                         return wacom_penpartner_irq(wacom_wac, wcombo);
 
@@ -751,6 +803,7 @@ int wacom_wac_irq(struct wacom_wac *wacom_wac, void *wcombo)
                         return wacom_intuos_irq(wacom_wac, wcombo);
 
                 case TABLETPC:
+                case TABLETPC2FG:
                         return wacom_tpc_irq(wacom_wac, wcombo);
 
                 default:
@@ -761,7 +814,7 @@ int wacom_wac_irq(struct wacom_wac *wacom_wac, void *wcombo)
 
 void wacom_init_input_dev(struct input_dev *input_dev, struct wacom_wac *wacom_wac)
 {
-        switch (wacom_wac->features->type) {
+        switch (wacom_wac->features.type) {
                 case WACOM_MO:
                         input_dev_mo(input_dev, wacom_wac);
                 case WACOM_G4:
@@ -791,9 +844,17 @@ void wacom_init_input_dev(struct input_dev *input_dev, struct wacom_wac *wacom_w
                         input_dev_i4s(input_dev, wacom_wac);
                         input_dev_i(input_dev, wacom_wac);
                         break;
+                case TABLETPC2FG:
+                        input_dev_tpc2fg(input_dev, wacom_wac);
+                        /* fall through */
+                case TABLETPC:
+                        input_dev_tpc(input_dev, wacom_wac);
+                        if (wacom_wac->features.device_type != BTN_TOOL_PEN)
+                                break;  /* no need to process stylus stuff */
+
+                        /* fall through */
                 case PL:
                 case PTU:
-                case TABLETPC:
                         input_dev_pl(input_dev, wacom_wac);
                         /* fall through */
                 case PENPARTNER:
@@ -803,147 +864,201 @@ void wacom_init_input_dev(struct input_dev *input_dev, struct wacom_wac *wacom_w
         return;
 }
 
-static struct wacom_features wacom_features[] = {
-        { "Wacom Penpartner",    7,   5040,  3780,  255,  0, PENPARTNER },
-        { "Wacom Graphire",      8,  10206,  7422,  511, 63, GRAPHIRE },
-        { "Wacom Graphire2 4x5", 8,  10206,  7422,  511, 63, GRAPHIRE },
-        { "Wacom Graphire2 5x7", 8,  13918, 10206,  511, 63, GRAPHIRE },
-        { "Wacom Graphire3",     8,  10208,  7424,  511, 63, GRAPHIRE },
-        { "Wacom Graphire3 6x8", 8,  16704, 12064,  511, 63, GRAPHIRE },
-        { "Wacom Graphire4 4x5", 8,  10208,  7424,  511, 63, WACOM_G4 },
-        { "Wacom Graphire4 6x8", 8,  16704, 12064,  511, 63, WACOM_G4 },
-        { "Wacom BambooFun 4x5", 9,  14760,  9225,  511, 63, WACOM_MO },
-        { "Wacom BambooFun 6x8", 9,  21648, 13530,  511, 63, WACOM_MO },
-        { "Wacom Bamboo1 Medium",8,  16704, 12064,  511, 63, GRAPHIRE },
-        { "Wacom Volito",        8,   5104,  3712,  511, 63, GRAPHIRE },
-        { "Wacom PenStation2",   8,   3250,  2320,  255, 63, GRAPHIRE },
-        { "Wacom Volito2 4x5",   8,   5104,  3712,  511, 63, GRAPHIRE },
-        { "Wacom Volito2 2x3",   8,   3248,  2320,  511, 63, GRAPHIRE },
-        { "Wacom PenPartner2",   8,   3250,  2320,  511, 63, GRAPHIRE },
-        { "Wacom Bamboo",        9,  14760,  9225,  511, 63, WACOM_MO },
-        { "Wacom Bamboo1",       8,   5104,  3712,  511, 63, GRAPHIRE },
-        { "Wacom Intuos 4x5",   10,  12700, 10600, 1023, 31, INTUOS },
-        { "Wacom Intuos 6x8",   10,  20320, 16240, 1023, 31, INTUOS },
-        { "Wacom Intuos 9x12",  10,  30480, 24060, 1023, 31, INTUOS },
-        { "Wacom Intuos 12x12", 10,  30480, 31680, 1023, 31, INTUOS },
-        { "Wacom Intuos 12x18", 10,  45720, 31680, 1023, 31, INTUOS },
-        { "Wacom PL400",         8,   5408,  4056,  255,  0, PL },
-        { "Wacom PL500",         8,   6144,  4608,  255,  0, PL },
-        { "Wacom PL600",         8,   6126,  4604,  255,  0, PL },
-        { "Wacom PL600SX",       8,   6260,  5016,  255,  0, PL },
-        { "Wacom PL550",         8,   6144,  4608,  511,  0, PL },
-        { "Wacom PL800",         8,   7220,  5780,  511,  0, PL },
-        { "Wacom PL700",         8,   6758,  5406,  511,  0, PL },
-        { "Wacom PL510",         8,   6282,  4762,  511,  0, PL },
-        { "Wacom DTU710",        8,  34080, 27660,  511,  0, PL },
-        { "Wacom DTF521",        8,   6282,  4762,  511,  0, PL },
-        { "Wacom DTF720",        8,   6858,  5506,  511,  0, PL },
-        { "Wacom DTF720a",       8,   6858,  5506,  511,  0, PL },
-        { "Wacom Cintiq Partner",8,  20480, 15360,  511,  0, PTU },
-        { "Wacom Intuos2 4x5",   10, 12700, 10600, 1023, 31, INTUOS },
-        { "Wacom Intuos2 6x8",   10, 20320, 16240, 1023, 31, INTUOS },
-        { "Wacom Intuos2 9x12",  10, 30480, 24060, 1023, 31, INTUOS },
-        { "Wacom Intuos2 12x12", 10, 30480, 31680, 1023, 31, INTUOS },
-        { "Wacom Intuos2 12x18", 10, 45720, 31680, 1023, 31, INTUOS },
-        { "Wacom Intuos3 4x5",   10, 25400, 20320, 1023, 63, INTUOS3S },
-        { "Wacom Intuos3 6x8",   10, 40640, 30480, 1023, 63, INTUOS3 },
-        { "Wacom Intuos3 9x12",  10, 60960, 45720, 1023, 63, INTUOS3 },
-        { "Wacom Intuos3 12x12", 10, 60960, 60960, 1023, 63, INTUOS3L },
-        { "Wacom Intuos3 12x19", 10, 97536, 60960, 1023, 63, INTUOS3L },
-        { "Wacom Intuos3 6x11",  10, 54204, 31750, 1023, 63, INTUOS3 },
-        { "Wacom Intuos3 4x6",   10, 31496, 19685, 1023, 63, INTUOS3S },
-        { "Wacom Intuos4 4x6",   10, 31496, 19685, 2047, 63, INTUOS4S },
-        { "Wacom Intuos4 6x9",   10, 44704, 27940, 2047, 63, INTUOS4 },
-        { "Wacom Intuos4 8x13",  10, 65024, 40640, 2047, 63, INTUOS4L },
-        { "Wacom Intuos4 12x19", 10, 97536, 60960, 2047, 63, INTUOS4L },
-        { "Wacom Cintiq 21UX",   10, 87200, 65600, 1023, 63, CINTIQ },
-        { "Wacom Cintiq 20WSX",  10, 86680, 54180, 1023, 63, WACOM_BEE },
-        { "Wacom Cintiq 12WX",   10, 53020, 33440, 1023, 63, WACOM_BEE },
-        { "Wacom DTU1931",        8, 37832, 30305,  511,  0, PL },
-        { "Wacom ISDv4 90",       8, 26202, 16325,  255,  0, TABLETPC },
-        { "Wacom ISDv4 93",       8, 26202, 16325,  255,  0, TABLETPC },
-        { "Wacom ISDv4 9A",       8, 26202, 16325,  255,  0, TABLETPC },
-        { "Wacom Intuos2 6x8",   10, 20320, 16240, 1023, 31, INTUOS },
+static const struct wacom_features wacom_features_0x00 =
+        { "Wacom Penpartner",     WACOM_PKGLEN_PENPRTN,    5040,  3780,  255,  0, PENPARTNER };
+static const struct wacom_features wacom_features_0x10 =
+        { "Wacom Graphire",       WACOM_PKGLEN_GRAPHIRE,  10206,  7422,  511, 63, GRAPHIRE };
+static const struct wacom_features wacom_features_0x11 =
+        { "Wacom Graphire2 4x5",  WACOM_PKGLEN_GRAPHIRE,  10206,  7422,  511, 63, GRAPHIRE };
+static const struct wacom_features wacom_features_0x12 =
+        { "Wacom Graphire2 5x7",  WACOM_PKGLEN_GRAPHIRE,  13918, 10206,  511, 63, GRAPHIRE };
+static const struct wacom_features wacom_features_0x13 =
+        { "Wacom Graphire3",      WACOM_PKGLEN_GRAPHIRE,  10208,  7424,  511, 63, GRAPHIRE };
+static const struct wacom_features wacom_features_0x14 =
+        { "Wacom Graphire3 6x8",  WACOM_PKGLEN_GRAPHIRE,  16704, 12064,  511, 63, GRAPHIRE };
+static const struct wacom_features wacom_features_0x15 =
+        { "Wacom Graphire4 4x5",  WACOM_PKGLEN_GRAPHIRE,  10208,  7424,  511, 63, WACOM_G4 };
+static const struct wacom_features wacom_features_0x16 =
+        { "Wacom Graphire4 6x8",  WACOM_PKGLEN_GRAPHIRE,  16704, 12064,  511, 63, WACOM_G4 };
+static const struct wacom_features wacom_features_0x17 =
+        { "Wacom BambooFun 4x5",  WACOM_PKGLEN_BBFUN,     14760,  9225,  511, 63, WACOM_MO };
+static const struct wacom_features wacom_features_0x18 =
+        { "Wacom BambooFun 6x8",  WACOM_PKGLEN_BBFUN,     21648, 13530,  511, 63, WACOM_MO };
+static const struct wacom_features wacom_features_0x19 =
+        { "Wacom Bamboo1 Medium", WACOM_PKGLEN_GRAPHIRE,  16704, 12064,  511, 63, GRAPHIRE };
+static const struct wacom_features wacom_features_0x60 =
+        { "Wacom Volito",         WACOM_PKGLEN_GRAPHIRE,   5104,  3712,  511, 63, GRAPHIRE };
+static const struct wacom_features wacom_features_0x61 =
+        { "Wacom PenStation2",    WACOM_PKGLEN_GRAPHIRE,   3250,  2320,  255, 63, GRAPHIRE };
+static const struct wacom_features wacom_features_0x62 =
+        { "Wacom Volito2 4x5",    WACOM_PKGLEN_GRAPHIRE,   5104,  3712,  511, 63, GRAPHIRE };
+static const struct wacom_features wacom_features_0x63 =
+        { "Wacom Volito2 2x3",    WACOM_PKGLEN_GRAPHIRE,   3248,  2320,  511, 63, GRAPHIRE };
+static const struct wacom_features wacom_features_0x64 =
+        { "Wacom PenPartner2",    WACOM_PKGLEN_GRAPHIRE,   3250,  2320,  511, 63, GRAPHIRE };
+static const struct wacom_features wacom_features_0x65 =
+        { "Wacom Bamboo",         WACOM_PKGLEN_BBFUN,     14760,  9225,  511, 63, WACOM_MO };
+static const struct wacom_features wacom_features_0x69 =
+        { "Wacom Bamboo1",        WACOM_PKGLEN_GRAPHIRE,   5104,  3712,  511, 63, GRAPHIRE };
+static const struct wacom_features wacom_features_0x20 =
+        { "Wacom Intuos 4x5",     WACOM_PKGLEN_INTUOS,    12700, 10600, 1023, 31, INTUOS };
+static const struct wacom_features wacom_features_0x21 =
+        { "Wacom Intuos 6x8",     WACOM_PKGLEN_INTUOS,    20320, 16240, 1023, 31, INTUOS };
+static const struct wacom_features wacom_features_0x22 =
+        { "Wacom Intuos 9x12",    WACOM_PKGLEN_INTUOS,    30480, 24060, 1023, 31, INTUOS };
+static const struct wacom_features wacom_features_0x23 =
+        { "Wacom Intuos 12x12",   WACOM_PKGLEN_INTUOS,    30480, 31680, 1023, 31, INTUOS };
+static const struct wacom_features wacom_features_0x24 =
+        { "Wacom Intuos 12x18",   WACOM_PKGLEN_INTUOS,    45720, 31680, 1023, 31, INTUOS };
+static const struct wacom_features wacom_features_0x30 =
+        { "Wacom PL400",          WACOM_PKGLEN_GRAPHIRE,   5408,  4056,  255,  0, PL };
+static const struct wacom_features wacom_features_0x31 =
+        { "Wacom PL500",          WACOM_PKGLEN_GRAPHIRE,   6144,  4608,  255,  0, PL };
+static const struct wacom_features wacom_features_0x32 =
+        { "Wacom PL600",          WACOM_PKGLEN_GRAPHIRE,   6126,  4604,  255,  0, PL };
+static const struct wacom_features wacom_features_0x33 =
+        { "Wacom PL600SX",        WACOM_PKGLEN_GRAPHIRE,   6260,  5016,  255,  0, PL };
+static const struct wacom_features wacom_features_0x34 =
+        { "Wacom PL550",          WACOM_PKGLEN_GRAPHIRE,   6144,  4608,  511,  0, PL };
+static const struct wacom_features wacom_features_0x35 =
+        { "Wacom PL800",          WACOM_PKGLEN_GRAPHIRE,   7220,  5780,  511,  0, PL };
+static const struct wacom_features wacom_features_0x37 =
+        { "Wacom PL700",          WACOM_PKGLEN_GRAPHIRE,   6758,  5406,  511,  0, PL };
+static const struct wacom_features wacom_features_0x38 =
+        { "Wacom PL510",          WACOM_PKGLEN_GRAPHIRE,   6282,  4762,  511,  0, PL };
+static const struct wacom_features wacom_features_0x39 =
+        { "Wacom DTU710",         WACOM_PKGLEN_GRAPHIRE,  34080, 27660,  511,  0, PL };
+static const struct wacom_features wacom_features_0xC4 =
+        { "Wacom DTF521",         WACOM_PKGLEN_GRAPHIRE,   6282,  4762,  511,  0, PL };
+static const struct wacom_features wacom_features_0xC0 =
+        { "Wacom DTF720",         WACOM_PKGLEN_GRAPHIRE,   6858,  5506,  511,  0, PL };
+static const struct wacom_features wacom_features_0xC2 =
+        { "Wacom DTF720a",        WACOM_PKGLEN_GRAPHIRE,   6858,  5506,  511,  0, PL };
+static const struct wacom_features wacom_features_0x03 =
+        { "Wacom Cintiq Partner", WACOM_PKGLEN_GRAPHIRE,  20480, 15360,  511,  0, PTU };
+static const struct wacom_features wacom_features_0x41 =
+        { "Wacom Intuos2 4x5",    WACOM_PKGLEN_INTUOS,    12700, 10600, 1023, 31, INTUOS };
+static const struct wacom_features wacom_features_0x42 =
+        { "Wacom Intuos2 6x8",    WACOM_PKGLEN_INTUOS,    20320, 16240, 1023, 31, INTUOS };
+static const struct wacom_features wacom_features_0x43 =
+        { "Wacom Intuos2 9x12",   WACOM_PKGLEN_INTUOS,    30480, 24060, 1023, 31, INTUOS };
+static const struct wacom_features wacom_features_0x44 =
+        { "Wacom Intuos2 12x12",  WACOM_PKGLEN_INTUOS,    30480, 31680, 1023, 31, INTUOS };
+static const struct wacom_features wacom_features_0x45 =
+        { "Wacom Intuos2 12x18",  WACOM_PKGLEN_INTUOS,    45720, 31680, 1023, 31, INTUOS };
+static const struct wacom_features wacom_features_0xB0 =
+        { "Wacom Intuos3 4x5",    WACOM_PKGLEN_INTUOS,    25400, 20320, 1023, 63, INTUOS3S };
+static const struct wacom_features wacom_features_0xB1 =
+        { "Wacom Intuos3 6x8",    WACOM_PKGLEN_INTUOS,    40640, 30480, 1023, 63, INTUOS3 };
+static const struct wacom_features wacom_features_0xB2 =
+        { "Wacom Intuos3 9x12",   WACOM_PKGLEN_INTUOS,    60960, 45720, 1023, 63, INTUOS3 };
+static const struct wacom_features wacom_features_0xB3 =
+        { "Wacom Intuos3 12x12",  WACOM_PKGLEN_INTUOS,    60960, 60960, 1023, 63, INTUOS3L };
+static const struct wacom_features wacom_features_0xB4 =
+        { "Wacom Intuos3 12x19",  WACOM_PKGLEN_INTUOS,    97536, 60960, 1023, 63, INTUOS3L };
+static const struct wacom_features wacom_features_0xB5 =
+        { "Wacom Intuos3 6x11",   WACOM_PKGLEN_INTUOS,    54204, 31750, 1023, 63, INTUOS3 };
+static const struct wacom_features wacom_features_0xB7 =
+        { "Wacom Intuos3 4x6",    WACOM_PKGLEN_INTUOS,    31496, 19685, 1023, 63, INTUOS3S };
+static const struct wacom_features wacom_features_0xB8 =
+        { "Wacom Intuos4 4x6",    WACOM_PKGLEN_INTUOS,    31496, 19685, 2047, 63, INTUOS4S };
+static const struct wacom_features wacom_features_0xB9 =
+        { "Wacom Intuos4 6x9",    WACOM_PKGLEN_INTUOS,    44704, 27940, 2047, 63, INTUOS4 };
+static const struct wacom_features wacom_features_0xBA =
+        { "Wacom Intuos4 8x13",   WACOM_PKGLEN_INTUOS,    65024, 40640, 2047, 63, INTUOS4L };
+static const struct wacom_features wacom_features_0xBB =
+        { "Wacom Intuos4 12x19",  WACOM_PKGLEN_INTUOS,    97536, 60960, 2047, 63, INTUOS4L };
+static const struct wacom_features wacom_features_0x3F =
+        { "Wacom Cintiq 21UX",    WACOM_PKGLEN_INTUOS,    87200, 65600, 1023, 63, CINTIQ };
+static const struct wacom_features wacom_features_0xC5 =
+        { "Wacom Cintiq 20WSX",   WACOM_PKGLEN_INTUOS,    86680, 54180, 1023, 63, WACOM_BEE };
+static const struct wacom_features wacom_features_0xC6 =
+        { "Wacom Cintiq 12WX",    WACOM_PKGLEN_INTUOS,    53020, 33440, 1023, 63, WACOM_BEE };
+static const struct wacom_features wacom_features_0xC7 =
+        { "Wacom DTU1931",        WACOM_PKGLEN_GRAPHIRE,  37832, 30305,  511,  0, PL };
+static const struct wacom_features wacom_features_0x90 =
+        { "Wacom ISDv4 90",       WACOM_PKGLEN_GRAPHIRE,  26202, 16325,  255,  0, TABLETPC };
+static const struct wacom_features wacom_features_0x93 =
+        { "Wacom ISDv4 93",       WACOM_PKGLEN_GRAPHIRE,  26202, 16325,  255,  0, TABLETPC };
+static const struct wacom_features wacom_features_0x9A =
+        { "Wacom ISDv4 9A",       WACOM_PKGLEN_GRAPHIRE,  26202, 16325,  255,  0, TABLETPC };
+static const struct wacom_features wacom_features_0x9F =
+        { "Wacom ISDv4 9F",       WACOM_PKGLEN_GRAPHIRE,  26202, 16325,  255,  0, TABLETPC };
+static const struct wacom_features wacom_features_0xE2 =
+        { "Wacom ISDv4 E2",       WACOM_PKGLEN_TPC2FG,    26202, 16325,  255,  0, TABLETPC2FG };
+static const struct wacom_features wacom_features_0xE3 =
+        { "Wacom ISDv4 E3",       WACOM_PKGLEN_TPC2FG,    26202, 16325,  255,  0, TABLETPC2FG };
+static const struct wacom_features wacom_features_0x47 =
+        { "Wacom Intuos2 6x8",    WACOM_PKGLEN_INTUOS,    20320, 16240, 1023, 31, INTUOS };
+
+#define USB_DEVICE_WACOM(prod)                                  \
+        USB_DEVICE(USB_VENDOR_ID_WACOM, prod),                  \
+        .driver_info = (kernel_ulong_t)&wacom_features_##prod
+
+const struct usb_device_id wacom_ids[] = {
+        { USB_DEVICE_WACOM(0x00) },
+        { USB_DEVICE_WACOM(0x10) },
+        { USB_DEVICE_WACOM(0x11) },
+        { USB_DEVICE_WACOM(0x12) },
+        { USB_DEVICE_WACOM(0x13) },
+        { USB_DEVICE_WACOM(0x14) },
+        { USB_DEVICE_WACOM(0x15) },
+        { USB_DEVICE_WACOM(0x16) },
+        { USB_DEVICE_WACOM(0x17) },
+        { USB_DEVICE_WACOM(0x18) },
+        { USB_DEVICE_WACOM(0x19) },
+        { USB_DEVICE_WACOM(0x60) },
+        { USB_DEVICE_WACOM(0x61) },
+        { USB_DEVICE_WACOM(0x62) },
+        { USB_DEVICE_WACOM(0x63) },
+        { USB_DEVICE_WACOM(0x64) },
+        { USB_DEVICE_WACOM(0x65) },
+        { USB_DEVICE_WACOM(0x69) },
+        { USB_DEVICE_WACOM(0x20) },
+        { USB_DEVICE_WACOM(0x21) },
+        { USB_DEVICE_WACOM(0x22) },
+        { USB_DEVICE_WACOM(0x23) },
+        { USB_DEVICE_WACOM(0x24) },
+        { USB_DEVICE_WACOM(0x30) },
+        { USB_DEVICE_WACOM(0x31) },
+        { USB_DEVICE_WACOM(0x32) },
+        { USB_DEVICE_WACOM(0x33) },
+        { USB_DEVICE_WACOM(0x34) },
+        { USB_DEVICE_WACOM(0x35) },
+        { USB_DEVICE_WACOM(0x37) },
+        { USB_DEVICE_WACOM(0x38) },
+        { USB_DEVICE_WACOM(0x39) },
+        { USB_DEVICE_WACOM(0xC4) },
+        { USB_DEVICE_WACOM(0xC0) },
+        { USB_DEVICE_WACOM(0xC2) },
+        { USB_DEVICE_WACOM(0x03) },
+        { USB_DEVICE_WACOM(0x41) },
+        { USB_DEVICE_WACOM(0x42) },
+        { USB_DEVICE_WACOM(0x43) },
+        { USB_DEVICE_WACOM(0x44) },
+        { USB_DEVICE_WACOM(0x45) },
+        { USB_DEVICE_WACOM(0xB0) },
+        { USB_DEVICE_WACOM(0xB1) },
+        { USB_DEVICE_WACOM(0xB2) },
+        { USB_DEVICE_WACOM(0xB3) },
+        { USB_DEVICE_WACOM(0xB4) },
+        { USB_DEVICE_WACOM(0xB5) },
+        { USB_DEVICE_WACOM(0xB7) },
+        { USB_DEVICE_WACOM(0xB8) },
+        { USB_DEVICE_WACOM(0xB9) },
+        { USB_DEVICE_WACOM(0xBA) },
+        { USB_DEVICE_WACOM(0xBB) },
+        { USB_DEVICE_WACOM(0x3F) },
+        { USB_DEVICE_WACOM(0xC5) },
+        { USB_DEVICE_WACOM(0xC6) },
+        { USB_DEVICE_WACOM(0xC7) },
+        { USB_DEVICE_WACOM(0x90) },
+        { USB_DEVICE_WACOM(0x93) },
+        { USB_DEVICE_WACOM(0x9A) },
+        { USB_DEVICE_WACOM(0x9F) },
+        { USB_DEVICE_WACOM(0xE2) },
+        { USB_DEVICE_WACOM(0xE3) },
+        { USB_DEVICE_WACOM(0x47) },
         { }
 };
-
-static struct usb_device_id wacom_ids[] = {
-        { USB_DEVICE(USB_VENDOR_ID_WACOM, 0x00) },
-        { USB_DEVICE(USB_VENDOR_ID_WACOM, 0x10) },
-        { USB_DEVICE(USB_VENDOR_ID_WACOM, 0x11) },
-        { USB_DEVICE(USB_VENDOR_ID_WACOM, 0x12) },
-        { USB_DEVICE(USB_VENDOR_ID_WACOM, 0x13) },
-        { USB_DEVICE(USB_VENDOR_ID_WACOM, 0x14) },
-        { USB_DEVICE(USB_VENDOR_ID_WACOM, 0x15) },
-        { USB_DEVICE(USB_VENDOR_ID_WACOM, 0x16) },
-        { USB_DEVICE(USB_VENDOR_ID_WACOM, 0x17) },
-        { USB_DEVICE(USB_VENDOR_ID_WACOM, 0x18) },
-        { USB_DEVICE(USB_VENDOR_ID_WACOM, 0x19) },
-        { USB_DEVICE(USB_VENDOR_ID_WACOM, 0x60) },
-        { USB_DEVICE(USB_VENDOR_ID_WACOM, 0x61) },
-        { USB_DEVICE(USB_VENDOR_ID_WACOM, 0x62) },
-        { USB_DEVICE(USB_VENDOR_ID_WACOM, 0x63) },
-        { USB_DEVICE(USB_VENDOR_ID_WACOM, 0x64) },
-        { USB_DEVICE(USB_VENDOR_ID_WACOM, 0x65) },
-        { USB_DEVICE(USB_VENDOR_ID_WACOM, 0x69) },
-        { USB_DEVICE(USB_VENDOR_ID_WACOM, 0x20) },
-        { USB_DEVICE(USB_VENDOR_ID_WACOM, 0x21) },
-        { USB_DEVICE(USB_VENDOR_ID_WACOM, 0x22) },
-        { USB_DEVICE(USB_VENDOR_ID_WACOM, 0x23) },
-        { USB_DEVICE(USB_VENDOR_ID_WACOM, 0x24) },
-        { USB_DEVICE(USB_VENDOR_ID_WACOM, 0x30) },
-        { USB_DEVICE(USB_VENDOR_ID_WACOM, 0x31) },
-        { USB_DEVICE(USB_VENDOR_ID_WACOM, 0x32) },
-        { USB_DEVICE(USB_VENDOR_ID_WACOM, 0x33) },
-        { USB_DEVICE(USB_VENDOR_ID_WACOM, 0x34) },
-        { USB_DEVICE(USB_VENDOR_ID_WACOM, 0x35) },
-        { USB_DEVICE(USB_VENDOR_ID_WACOM, 0x37) },
-        { USB_DEVICE(USB_VENDOR_ID_WACOM, 0x38) },
-        { USB_DEVICE(USB_VENDOR_ID_WACOM, 0x39) },
-        { USB_DEVICE(USB_VENDOR_ID_WACOM, 0xC4) },
-        { USB_DEVICE(USB_VENDOR_ID_WACOM, 0xC0) },
-        { USB_DEVICE(USB_VENDOR_ID_WACOM, 0xC2) },
-        { USB_DEVICE(USB_VENDOR_ID_WACOM, 0x03) },
-        { USB_DEVICE(USB_VENDOR_ID_WACOM, 0x41) },
-        { USB_DEVICE(USB_VENDOR_ID_WACOM, 0x42) },
-        { USB_DEVICE(USB_VENDOR_ID_WACOM, 0x43) },
-        { USB_DEVICE(USB_VENDOR_ID_WACOM, 0x44) },
-        { USB_DEVICE(USB_VENDOR_ID_WACOM, 0x45) },
-        { USB_DEVICE(USB_VENDOR_ID_WACOM, 0xB0) },
-        { USB_DEVICE(USB_VENDOR_ID_WACOM, 0xB1) },
-        { USB_DEVICE(USB_VENDOR_ID_WACOM, 0xB2) },
-        { USB_DEVICE(USB_VENDOR_ID_WACOM, 0xB3) },
-        { USB_DEVICE(USB_VENDOR_ID_WACOM, 0xB4) },
-        { USB_DEVICE(USB_VENDOR_ID_WACOM, 0xB5) },
-        { USB_DEVICE(USB_VENDOR_ID_WACOM, 0xB7) },
-        { USB_DEVICE(USB_VENDOR_ID_WACOM, 0xB8) },
-        { USB_DEVICE(USB_VENDOR_ID_WACOM, 0xB9) },
-        { USB_DEVICE(USB_VENDOR_ID_WACOM, 0xBA) },
-        { USB_DEVICE(USB_VENDOR_ID_WACOM, 0xBB) },
-        { USB_DEVICE(USB_VENDOR_ID_WACOM, 0x3F) },
-        { USB_DEVICE(USB_VENDOR_ID_WACOM, 0xC5) },
-        { USB_DEVICE(USB_VENDOR_ID_WACOM, 0xC6) },
-        { USB_DEVICE(USB_VENDOR_ID_WACOM, 0xC7) },
-        { USB_DEVICE(USB_VENDOR_ID_WACOM, 0x90) },
-        { USB_DEVICE(USB_VENDOR_ID_WACOM, 0x93) },
-        { USB_DEVICE(USB_VENDOR_ID_WACOM, 0x9A) },
-        { USB_DEVICE(USB_VENDOR_ID_WACOM, 0x47) },
-        { }
-};
-
-const struct usb_device_id *get_device_table(void)
-{
-        const struct usb_device_id *id_table = wacom_ids;
-
-        return id_table;
-}
-
-struct wacom_features * get_wacom_feature(const struct usb_device_id *id)
-{
-        int index = id - wacom_ids;
-        struct wacom_features *wf = &wacom_features[index];
-
-        return wf;
-}
-
 MODULE_DEVICE_TABLE(usb, wacom_ids);
diff --git a/drivers/input/tablet/wacom_wac.h b/drivers/input/tablet/wacom_wac.h
index c10235aba7e5..b50cf04e61a8 100644
--- a/drivers/input/tablet/wacom_wac.h
+++ b/drivers/input/tablet/wacom_wac.h
@@ -9,12 +9,32 @@
 #ifndef WACOM_WAC_H
 #define WACOM_WAC_H
 
+/* maximum packet length for USB devices */
+#define WACOM_PKGLEN_MAX        32
+
+/* packet length for individual models */
+#define WACOM_PKGLEN_PENPRTN     7
+#define WACOM_PKGLEN_GRAPHIRE    8
+#define WACOM_PKGLEN_BBFUN       9
+#define WACOM_PKGLEN_INTUOS     10
+#define WACOM_PKGLEN_TPC1FG      5
+#define WACOM_PKGLEN_TPC2FG     14
+
+/* device IDs */
 #define STYLUS_DEVICE_ID        0x02
 #define TOUCH_DEVICE_ID         0x03
 #define CURSOR_DEVICE_ID        0x06
 #define ERASER_DEVICE_ID        0x0A
 #define PAD_DEVICE_ID           0x0F
 
+/* wacom data packet report IDs */
+#define WACOM_REPORT_PENABLED           2
+#define WACOM_REPORT_INTUOSREAD         5
+#define WACOM_REPORT_INTUOSWRITE        6
+#define WACOM_REPORT_INTUOSPAD          12
+#define WACOM_REPORT_TPC1FG             6
+#define WACOM_REPORT_TPC2FG             13
+
 enum {
         PENPARTNER = 0,
         GRAPHIRE,
@@ -32,27 +52,32 @@ enum {
         WACOM_BEE,
         WACOM_MO,
         TABLETPC,
+        TABLETPC2FG,
         MAX_TYPE
 };
 
 struct wacom_features {
-        char *name;
+        const char *name;
         int pktlen;
         int x_max;
         int y_max;
         int pressure_max;
         int distance_max;
         int type;
-        int touch_x_max;
-        int touch_y_max;
+        int device_type;
+        int x_phy;
+        int y_phy;
+        unsigned char unit;
+        unsigned char unitExpo;
 };
 
 struct wacom_wac {
+        char name[64];
         unsigned char *data;
-        int tool[2];
-        int id[2];
-        __u32 serial[2];
-        struct wacom_features *features;
+        int tool[2];
+        int id[2];
+        __u32 serial[2];
+        struct wacom_features features;
 };
 
 #endif
diff --git a/drivers/input/touchscreen/88pm860x-ts.c b/drivers/input/touchscreen/88pm860x-ts.c
new file mode 100644
index 000000000000..b3aebc2166ba
--- /dev/null
+++ b/drivers/input/touchscreen/88pm860x-ts.c
@@ -0,0 +1,237 @@
+/*
+ * Touchscreen driver for Marvell 88PM860x
+ *
+ * Copyright (C) 2009 Marvell International Ltd.
+ *      Haojian Zhuang <haojian.zhuang@marvell.com>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ */
+#include <linux/kernel.h>
+#include <linux/module.h>
+#include <linux/platform_device.h>
+#include <linux/i2c.h>
+#include <linux/input.h>
+#include <linux/mfd/88pm860x.h>
+#include <linux/slab.h>
+
+#define MEAS_LEN                (8)
+#define ACCURATE_BIT            (12)
+
+/* touch register */
+#define MEAS_EN3                (0x52)
+
+#define MEAS_TSIX_1             (0x8D)
+#define MEAS_TSIX_2             (0x8E)
+#define MEAS_TSIY_1             (0x8F)
+#define MEAS_TSIY_2             (0x90)
+#define MEAS_TSIZ1_1            (0x91)
+#define MEAS_TSIZ1_2            (0x92)
+#define MEAS_TSIZ2_1            (0x93)
+#define MEAS_TSIZ2_2            (0x94)
+
+/* bit definitions of touch */
+#define MEAS_PD_EN              (1 << 3)
+#define MEAS_TSIX_EN            (1 << 4)
+#define MEAS_TSIY_EN            (1 << 5)
+#define MEAS_TSIZ1_EN           (1 << 6)
+#define MEAS_TSIZ2_EN           (1 << 7)
+
+struct pm860x_touch {
+        struct input_dev *idev;
+        struct i2c_client *i2c;
+        struct pm860x_chip *chip;
+        int irq;
+        int res_x;              /* resistor of Xplate */
+};
+
+static irqreturn_t pm860x_touch_handler(int irq, void *data)
+{
+        struct pm860x_touch *touch = data;
+        struct pm860x_chip *chip = touch->chip;
+        unsigned char buf[MEAS_LEN];
+        int x, y, pen_down;
+        int z1, z2, rt = 0;
+        int ret;
+
+        ret = pm860x_bulk_read(touch->i2c, MEAS_TSIX_1, MEAS_LEN, buf);
+        if (ret < 0)
+                goto out;
+
+        pen_down = buf[1] & (1 << 6);
+        x = ((buf[0] & 0xFF) << 4) | (buf[1] & 0x0F);
+        y = ((buf[2] & 0xFF) << 4) | (buf[3] & 0x0F);
+        z1 = ((buf[4] & 0xFF) << 4) | (buf[5] & 0x0F);
+        z2 = ((buf[6] & 0xFF) << 4) | (buf[7] & 0x0F);
+
+        if (pen_down) {
+                if ((x != 0) && (z1 != 0) && (touch->res_x != 0)) {
+                        rt = z2 / z1 - 1;
+                        rt = (rt * touch->res_x * x) >> ACCURATE_BIT;
+                        dev_dbg(chip->dev, "z1:%d, z2:%d, rt:%d\n",
+                                z1, z2, rt);
+                }
+                input_report_abs(touch->idev, ABS_X, x);
+                input_report_abs(touch->idev, ABS_Y, y);
+                input_report_abs(touch->idev, ABS_PRESSURE, rt);
+                input_report_key(touch->idev, BTN_TOUCH, 1);
+                dev_dbg(chip->dev, "pen down at [%d, %d].\n", x, y);
+        } else {
+                input_report_abs(touch->idev, ABS_PRESSURE, 0);
+                input_report_key(touch->idev, BTN_TOUCH, 0);
+                dev_dbg(chip->dev, "pen release\n");
+        }
+        input_sync(touch->idev);
+
+out:
+        return IRQ_HANDLED;
+}
+
+static int pm860x_touch_open(struct input_dev *dev)
+{
+        struct pm860x_touch *touch = input_get_drvdata(dev);
+        int data, ret;
+
+        data = MEAS_PD_EN | MEAS_TSIX_EN | MEAS_TSIY_EN
+                | MEAS_TSIZ1_EN | MEAS_TSIZ2_EN;
+        ret = pm860x_set_bits(touch->i2c, MEAS_EN3, data, data);
+        if (ret < 0)
+                goto out;
+        return 0;
+out:
+        return ret;
+}
+
+static void pm860x_touch_close(struct input_dev *dev)
+{
+        struct pm860x_touch *touch = input_get_drvdata(dev);
+        int data;
+
+        data = MEAS_PD_EN | MEAS_TSIX_EN | MEAS_TSIY_EN
+                | MEAS_TSIZ1_EN | MEAS_TSIZ2_EN;
+        pm860x_set_bits(touch->i2c, MEAS_EN3, data, 0);
+}
+
+static int __devinit pm860x_touch_probe(struct platform_device *pdev)
+{
+        struct pm860x_chip *chip = dev_get_drvdata(pdev->dev.parent);
+        struct pm860x_platform_data *pm860x_pdata =             \
+                                pdev->dev.parent->platform_data;
+        struct pm860x_touch_pdata *pdata = NULL;
+        struct pm860x_touch *touch;
+        int irq, ret;
+
+        irq = platform_get_irq(pdev, 0);
+        if (irq < 0) {
+                dev_err(&pdev->dev, "No IRQ resource!\n");
+                return -EINVAL;
+        }
+
+        if (!pm860x_pdata) {
+                dev_err(&pdev->dev, "platform data is missing\n");
+                return -EINVAL;
+        }
+
+        pdata = pm860x_pdata->touch;
+        if (!pdata) {
+                dev_err(&pdev->dev, "touchscreen data is missing\n");
+                return -EINVAL;
+        }
+
+        touch = kzalloc(sizeof(struct pm860x_touch), GFP_KERNEL);
+        if (touch == NULL)
+                return -ENOMEM;
+        dev_set_drvdata(&pdev->dev, touch);
+
+        touch->idev = input_allocate_device();
+        if (touch->idev == NULL) {
+                dev_err(&pdev->dev, "Failed to allocate input device!\n");
+                ret = -ENOMEM;
+                goto out;
+        }
+
+        touch->idev->name = "88pm860x-touch";
+        touch->idev->phys = "88pm860x/input0";
+        touch->idev->id.bustype = BUS_I2C;
+        touch->idev->dev.parent = &pdev->dev;
+        touch->idev->open = pm860x_touch_open;
+        touch->idev->close = pm860x_touch_close;
+        touch->chip = chip;
+        touch->i2c = (chip->id == CHIP_PM8607) ? chip->client : chip->companion;
+        touch->irq = irq + chip->irq_base;
+        touch->res_x = pdata->res_x;
+        input_set_drvdata(touch->idev, touch);
+
+        ret = request_threaded_irq(touch->irq, NULL, pm860x_touch_handler,
+                                   IRQF_ONESHOT, "touch", touch);
+        if (ret < 0)
+                goto out_irq;
+
+        __set_bit(EV_ABS, touch->idev->evbit);
+        __set_bit(ABS_X, touch->idev->absbit);
+        __set_bit(ABS_Y, touch->idev->absbit);
+        __set_bit(ABS_PRESSURE, touch->idev->absbit);
+        __set_bit(EV_SYN, touch->idev->evbit);
+        __set_bit(EV_KEY, touch->idev->evbit);
+        __set_bit(BTN_TOUCH, touch->idev->keybit);
+
+        input_set_abs_params(touch->idev, ABS_X, 0, 1 << ACCURATE_BIT, 0, 0);
+        input_set_abs_params(touch->idev, ABS_Y, 0, 1 << ACCURATE_BIT, 0, 0);
+        input_set_abs_params(touch->idev, ABS_PRESSURE, 0, 1 << ACCURATE_BIT,
+                                0, 0);
+
+        ret = input_register_device(touch->idev);
+        if (ret < 0) {
+                dev_err(chip->dev, "Failed to register touch!\n");
+                goto out_rg;
+        }
+
+        platform_set_drvdata(pdev, touch);
+        return 0;
+out_rg:
+        free_irq(touch->irq, touch);
+out_irq:
+        input_free_device(touch->idev);
+out:
+        kfree(touch);
+        return ret;
+}
+
+static int __devexit pm860x_touch_remove(struct platform_device *pdev)
+{
+        struct pm860x_touch *touch = platform_get_drvdata(pdev);
+
+        input_unregister_device(touch->idev);
+        free_irq(touch->irq, touch);
+        platform_set_drvdata(pdev, NULL);
+        kfree(touch);
+        return 0;
+}
+
+static struct platform_driver pm860x_touch_driver = {
+        .driver = {
+                .name   = "88pm860x-touch",
+                .owner  = THIS_MODULE,
+        },
+        .probe  = pm860x_touch_probe,
+        .remove = __devexit_p(pm860x_touch_remove),
+};
+
+static int __init pm860x_touch_init(void)
+{
+        return platform_driver_register(&pm860x_touch_driver);
+}
+module_init(pm860x_touch_init);
+
+static void __exit pm860x_touch_exit(void)
+{
+        platform_driver_unregister(&pm860x_touch_driver);
+}
+module_exit(pm860x_touch_exit);
+
+MODULE_DESCRIPTION("Touchscreen driver for Marvell Semiconductor 88PM860x");
+MODULE_AUTHOR("Haojian Zhuang <haojian.zhuang@marvell.com>");
+MODULE_LICENSE("GPL");
+MODULE_ALIAS("platform:88pm860x-touch");
+
diff --git a/drivers/input/touchscreen/Kconfig b/drivers/input/touchscreen/Kconfig
index 8cc453c85ea7..8a8fa4d2d6a8 100644
--- a/drivers/input/touchscreen/Kconfig
+++ b/drivers/input/touchscreen/Kconfig
@@ -11,18 +11,31 @@ menuconfig INPUT_TOUCHSCREEN
 
 if INPUT_TOUCHSCREEN
 
+config TOUCHSCREEN_88PM860X
+        tristate "Marvell 88PM860x touchscreen"
+        depends on MFD_88PM860X
+        help
+          Say Y here if you have a 88PM860x PMIC and want to enable
+          support for the built-in touchscreen.
+
+          If unsure, say N.
+
+          To compile this driver as a module, choose M here: the
+          module will be called 88pm860x-ts.
+
 config TOUCHSCREEN_ADS7846
-        tristate "ADS7846/TSC2046 and ADS7843 based touchscreens"
+        tristate "ADS7846/TSC2046/AD7873 and AD(S)7843 based touchscreens"
         depends on SPI_MASTER
         depends on HWMON = n || HWMON
         help
           Say Y here if you have a touchscreen interface using the
-          ADS7846/TSC2046 or ADS7843 controller, and your board-specific
-          setup code includes that in its table of SPI devices.
+          ADS7846/TSC2046/AD7873 or ADS7843/AD7843 controller,
+          and your board-specific setup code includes that in its
+          table of SPI devices.
 
           If HWMON is selected, and the driver is told the reference voltage
           on your board, you will also get hwmon interfaces for the voltage
-          (and on ads7846/tsc2046, temperature) sensors of this chip.
+          (and on ads7846/tsc2046/ad7873, temperature) sensors of this chip.
 
           If unsure, say N (but it's safe to say "Y").
 
@@ -90,7 +103,6 @@ config TOUCHSCREEN_CORGI
         tristate "SharpSL (Corgi and Spitz series) touchscreen driver (DEPRECATED)"
         depends on PXA_SHARPSL
         select CORGI_SSP_DEPRECATED
-        default y
         help
           Say Y here to enable the driver for the touchscreen on the
           Sharp SL-C7xx and SL-Cxx00 series of PDAs.
@@ -111,6 +123,18 @@ config TOUCHSCREEN_DA9034
           Say Y here to enable the support for the touchscreen found
           on Dialog Semiconductor DA9034 PMIC.
 
+config TOUCHSCREEN_DYNAPRO
+        tristate "Dynapro serial touchscreen"
+        select SERIO
+        help
+          Say Y here if you have a Dynapro serial touchscreen connected to
+          your system.
+
+          If unsure, say N.
+
+          To compile this driver as a module, choose M here: the
+          module will be called dynapro.
+
 config TOUCHSCREEN_EETI
         tristate "EETI touchscreen panel support"
         depends on I2C
@@ -133,6 +157,18 @@ config TOUCHSCREEN_FUJITSU
           To compile this driver as a module, choose M here: the
           module will be called fujitsu-ts.
 
+config TOUCHSCREEN_S3C2410
+        tristate "Samsung S3C2410 touchscreen input driver"
+        depends on ARCH_S3C2410
+        select S3C24XX_ADC
+        help
+          Say Y here if you have the s3c2410 touchscreen.
+
+          If unsure, say N.
+
+          To compile this driver as a module, choose M here: the
+          module will be called s3c2410_ts.
+
 config TOUCHSCREEN_GUNZE
         tristate "Gunze AHL-51S touchscreen"
         select SERIO
@@ -297,7 +333,7 @@ config TOUCHSCREEN_TOUCHWIN
 
 config TOUCHSCREEN_ATMEL_TSADCC
         tristate "Atmel Touchscreen Interface"
-        depends on ARCH_AT91SAM9RL
+        depends on ARCH_AT91SAM9RL || ARCH_AT91SAM9G45
         help
           Say Y here if you have a 4-wire touchscreen connected to the
           ADC Controller on your Atmel SoC (such as the AT91SAM9RL).
@@ -418,6 +454,7 @@ config TOUCHSCREEN_USB_COMPOSITE
           - IdealTEK URTC1000
           - GoTop Super_Q2/GogoPen/PenPower tablets
           - JASTEC USB Touch Controller/DigiTech DTR-02U
+          - Zytronic controllers
 
           Have a look at <http://linux.chapter7.ch/touchkit/> for
           a usage description and the required user-space stuff.
@@ -425,6 +462,18 @@ config TOUCHSCREEN_USB_COMPOSITE
           To compile this driver as a module, choose M here: the
           module will be called usbtouchscreen.
 
+config TOUCHSCREEN_MC13783
+        tristate "Freescale MC13783 touchscreen input driver"
+        depends on MFD_MC13783
+        help
+          Say Y here if you have an Freescale MC13783 PMIC on your
+          board and want to use its touchscreen
+
+          If unsure, say N.
+
+          To compile this driver as a module, choose M here: the
+          module will be called mc13783_ts.
+
 config TOUCHSCREEN_USB_EGALAX
         default y
         bool "eGalax, eTurboTouch CT-410/510/700 device support" if EMBEDDED
@@ -490,6 +539,21 @@ config TOUCHSCREEN_USB_E2I
         bool "e2i Touchscreen controller (e.g. from Mimo 740)"
         depends on TOUCHSCREEN_USB_COMPOSITE
 
+config TOUCHSCREEN_USB_ZYTRONIC
+        default y
+        bool "Zytronic controller" if EMBEDDED
+        depends on TOUCHSCREEN_USB_COMPOSITE
+
+config TOUCHSCREEN_USB_ETT_TC5UH
+        default y
+        bool "ET&T TC5UH touchscreen controler support" if EMBEDDED
+        depends on TOUCHSCREEN_USB_COMPOSITE
+
+config TOUCHSCREEN_USB_NEXIO
+        default y
+        bool "NEXIO/iNexio device support" if EMBEDDED
+        depends on TOUCHSCREEN_USB_COMPOSITE
+
 config TOUCHSCREEN_TOUCHIT213
         tristate "Sahara TouchIT-213 touchscreen"
         select SERIO
diff --git a/drivers/input/touchscreen/Makefile b/drivers/input/touchscreen/Makefile
index 15fa62cffc77..7fef7d5cca23 100644
--- a/drivers/input/touchscreen/Makefile
+++ b/drivers/input/touchscreen/Makefile
@@ -6,17 +6,20 @@
 
 wm97xx-ts-y := wm97xx-core.o
 
+obj-$(CONFIG_TOUCHSCREEN_88PM860X)      += 88pm860x-ts.o
 obj-$(CONFIG_TOUCHSCREEN_AD7877)        += ad7877.o
 obj-$(CONFIG_TOUCHSCREEN_AD7879)        += ad7879.o
 obj-$(CONFIG_TOUCHSCREEN_ADS7846)       += ads7846.o
 obj-$(CONFIG_TOUCHSCREEN_ATMEL_TSADCC)  += atmel_tsadcc.o
 obj-$(CONFIG_TOUCHSCREEN_BITSY)         += h3600_ts_input.o
 obj-$(CONFIG_TOUCHSCREEN_CORGI)         += corgi_ts.o
+obj-$(CONFIG_TOUCHSCREEN_DYNAPRO)       += dynapro.o
 obj-$(CONFIG_TOUCHSCREEN_GUNZE)         += gunze.o
 obj-$(CONFIG_TOUCHSCREEN_EETI)          += eeti_ts.o
 obj-$(CONFIG_TOUCHSCREEN_ELO)           += elo.o
 obj-$(CONFIG_TOUCHSCREEN_FUJITSU)       += fujitsu_ts.o
 obj-$(CONFIG_TOUCHSCREEN_INEXIO)        += inexio.o
+obj-$(CONFIG_TOUCHSCREEN_MC13783)       += mc13783_ts.o
 obj-$(CONFIG_TOUCHSCREEN_MCS5000)       += mcs5000_ts.o
 obj-$(CONFIG_TOUCHSCREEN_MIGOR)         += migor_ts.o
 obj-$(CONFIG_TOUCHSCREEN_MTOUCH)        += mtouch.o
@@ -25,7 +28,9 @@ obj-$(CONFIG_TOUCHSCREEN_HP600)		+= hp680_ts_input.o
 obj-$(CONFIG_TOUCHSCREEN_HP7XX)         += jornada720_ts.o
 obj-$(CONFIG_TOUCHSCREEN_HTCPEN)        += htcpen.o
 obj-$(CONFIG_TOUCHSCREEN_USB_COMPOSITE) += usbtouchscreen.o
+obj-$(CONFIG_TOUCHSCREEN_PCAP)          += pcap_ts.o
 obj-$(CONFIG_TOUCHSCREEN_PENMOUNT)      += penmount.o
+obj-$(CONFIG_TOUCHSCREEN_S3C2410)       += s3c2410_ts.o
 obj-$(CONFIG_TOUCHSCREEN_TOUCHIT213)    += touchit213.o
 obj-$(CONFIG_TOUCHSCREEN_TOUCHRIGHT)    += touchright.o
 obj-$(CONFIG_TOUCHSCREEN_TOUCHWIN)      += touchwin.o
@@ -41,4 +46,3 @@ obj-$(CONFIG_TOUCHSCREEN_WM97XX_ATMEL)	+= atmel-wm97xx.o
 obj-$(CONFIG_TOUCHSCREEN_WM97XX_MAINSTONE)      += mainstone-wm97xx.o
 obj-$(CONFIG_TOUCHSCREEN_WM97XX_ZYLONITE)       += zylonite-wm97xx.o
 obj-$(CONFIG_TOUCHSCREEN_W90X900)       += w90p910_ts.o
-obj-$(CONFIG_TOUCHSCREEN_PCAP)          += pcap_ts.o
diff --git a/drivers/input/touchscreen/ad7877.c b/drivers/input/touchscreen/ad7877.c
index eb83939c705e..e019d53d1ab4 100644
--- a/drivers/input/touchscreen/ad7877.c
+++ b/drivers/input/touchscreen/ad7877.c
@@ -46,7 +46,7 @@
 #include <linux/spi/ad7877.h>
 #include <asm/irq.h>
 
-#define TS_PEN_UP_TIMEOUT       msecs_to_jiffies(50)
+#define TS_PEN_UP_TIMEOUT       msecs_to_jiffies(100)
 
 #define MAX_SPI_FREQ_HZ                 20000000
 #define MAX_12BIT                       ((1<<12)-1)
diff --git a/drivers/input/touchscreen/ad7879.c b/drivers/input/touchscreen/ad7879.c
index c21e6d3a8844..794d070c6900 100644
--- a/drivers/input/touchscreen/ad7879.c
+++ b/drivers/input/touchscreen/ad7879.c
@@ -47,6 +47,7 @@
 #include <linux/workqueue.h>
 #include <linux/spi/spi.h>
 #include <linux/i2c.h>
+#include <linux/gpio.h>
 
 #include <linux/spi/ad7879.h>
 
@@ -132,7 +133,9 @@ struct ad7879 {
         struct input_dev        *input;
         struct work_struct      work;
         struct timer_list       timer;
-
+#ifdef CONFIG_GPIOLIB
+        struct gpio_chip        gc;
+#endif
         struct mutex            mutex;
         unsigned                disabled:1;     /* P: mutex */
 
@@ -150,11 +153,9 @@ struct ad7879 {
         u8                      median;
         u16                     x_plate_ohms;
         u16                     pressure_max;
-        u16                     gpio_init;
         u16                     cmd_crtl1;
         u16                     cmd_crtl2;
         u16                     cmd_crtl3;
-        unsigned                gpio:1;
 };
 
 static int ad7879_read(bus_device *, u8);
@@ -237,24 +238,6 @@ static irqreturn_t ad7879_irq(int irq, void *handle)
 
 static void ad7879_setup(struct ad7879 *ts)
 {
-        ts->cmd_crtl3 = AD7879_YPLUS_BIT |
-                        AD7879_XPLUS_BIT |
-                        AD7879_Z2_BIT |
-                        AD7879_Z1_BIT |
-                        AD7879_TEMPMASK_BIT |
-                        AD7879_AUXVBATMASK_BIT |
-                        AD7879_GPIOALERTMASK_BIT;
-
-        ts->cmd_crtl2 = AD7879_PM(AD7879_PM_DYN) | AD7879_DFR |
-                        AD7879_AVG(ts->averaging) |
-                        AD7879_MFS(ts->median) |
-                        AD7879_FCD(ts->first_conversion_delay) |
-                        ts->gpio_init;
-
-        ts->cmd_crtl1 = AD7879_MODE_INT | AD7879_MODE_SEQ1 |
-                        AD7879_ACQ(ts->acquisition_time) |
-                        AD7879_TMR(ts->pen_down_acc_interval);
-
         ad7879_write(ts->bus, AD7879_REG_CTRL2, ts->cmd_crtl2);
         ad7879_write(ts->bus, AD7879_REG_CTRL3, ts->cmd_crtl3);
         ad7879_write(ts->bus, AD7879_REG_CTRL1, ts->cmd_crtl1);
@@ -324,48 +307,132 @@ static ssize_t ad7879_disable_store(struct device *dev,
 
 static DEVICE_ATTR(disable, 0664, ad7879_disable_show, ad7879_disable_store);
 
-static ssize_t ad7879_gpio_show(struct device *dev,
-                                     struct device_attribute *attr, char *buf)
+static struct attribute *ad7879_attributes[] = {
+        &dev_attr_disable.attr,
+        NULL
+};
+
+static const struct attribute_group ad7879_attr_group = {
+        .attrs = ad7879_attributes,
+};
+
+#ifdef CONFIG_GPIOLIB
+static int ad7879_gpio_direction_input(struct gpio_chip *chip,
+                                        unsigned gpio)
 {
-        struct ad7879 *ts = dev_get_drvdata(dev);
+        struct ad7879 *ts = container_of(chip, struct ad7879, gc);
+        int err;
 
-        return sprintf(buf, "%u\n", ts->gpio);
+        mutex_lock(&ts->mutex);
+        ts->cmd_crtl2 |= AD7879_GPIO_EN | AD7879_GPIODIR | AD7879_GPIOPOL;
+        err = ad7879_write(ts->bus, AD7879_REG_CTRL2, ts->cmd_crtl2);
+        mutex_unlock(&ts->mutex);
+
+        return err;
 }
 
-static ssize_t ad7879_gpio_store(struct device *dev,
-                                     struct device_attribute *attr,
-                                     const char *buf, size_t count)
+static int ad7879_gpio_direction_output(struct gpio_chip *chip,
+                                        unsigned gpio, int level)
 {
-        struct ad7879 *ts = dev_get_drvdata(dev);
-        unsigned long val;
-        int error;
+        struct ad7879 *ts = container_of(chip, struct ad7879, gc);
+        int err;
 
-        error = strict_strtoul(buf, 10, &val);
-        if (error)
-                return error;
+        mutex_lock(&ts->mutex);
+        ts->cmd_crtl2 &= ~AD7879_GPIODIR;
+        ts->cmd_crtl2 |= AD7879_GPIO_EN | AD7879_GPIOPOL;
+        if (level)
+                ts->cmd_crtl2 |= AD7879_GPIO_DATA;
+        else
+                ts->cmd_crtl2 &= ~AD7879_GPIO_DATA;
+
+        err = ad7879_write(ts->bus, AD7879_REG_CTRL2, ts->cmd_crtl2);
+        mutex_unlock(&ts->mutex);
+
+        return err;
+}
+
+static int ad7879_gpio_get_value(struct gpio_chip *chip, unsigned gpio)
+{
+        struct ad7879 *ts = container_of(chip, struct ad7879, gc);
+        u16 val;
 
         mutex_lock(&ts->mutex);
-        ts->gpio = !!val;
-        error = ad7879_write(ts->bus, AD7879_REG_CTRL2,
-                           ts->gpio ?
-                                ts->cmd_crtl2 & ~AD7879_GPIO_DATA :
-                                ts->cmd_crtl2 | AD7879_GPIO_DATA);
+        val = ad7879_read(ts->bus, AD7879_REG_CTRL2);
         mutex_unlock(&ts->mutex);
 
-        return error ? : count;
+        return !!(val & AD7879_GPIO_DATA);
 }
 
-static DEVICE_ATTR(gpio, 0664, ad7879_gpio_show, ad7879_gpio_store);
+static void ad7879_gpio_set_value(struct gpio_chip *chip,
+                                  unsigned gpio, int value)
+{
+        struct ad7879 *ts = container_of(chip, struct ad7879, gc);
 
-static struct attribute *ad7879_attributes[] = {
-        &dev_attr_disable.attr,
-        &dev_attr_gpio.attr,
-        NULL
-};
+        mutex_lock(&ts->mutex);
+        if (value)
+                ts->cmd_crtl2 |= AD7879_GPIO_DATA;
+        else
+                ts->cmd_crtl2 &= ~AD7879_GPIO_DATA;
 
-static const struct attribute_group ad7879_attr_group = {
-        .attrs = ad7879_attributes,
-};
+        ad7879_write(ts->bus, AD7879_REG_CTRL2, ts->cmd_crtl2);
+        mutex_unlock(&ts->mutex);
+}
+
+static int __devinit ad7879_gpio_add(struct device *dev)
+{
+        struct ad7879 *ts = dev_get_drvdata(dev);
+        struct ad7879_platform_data *pdata = dev->platform_data;
+        int ret = 0;
+
+        if (pdata->gpio_export) {
+                ts->gc.direction_input = ad7879_gpio_direction_input;
+                ts->gc.direction_output = ad7879_gpio_direction_output;
+                ts->gc.get = ad7879_gpio_get_value;
+                ts->gc.set = ad7879_gpio_set_value;
+                ts->gc.can_sleep = 1;
+                ts->gc.base = pdata->gpio_base;
+                ts->gc.ngpio = 1;
+                ts->gc.label = "AD7879-GPIO";
+                ts->gc.owner = THIS_MODULE;
+                ts->gc.dev = dev;
+
+                ret = gpiochip_add(&ts->gc);
+                if (ret)
+                        dev_err(dev, "failed to register gpio %d\n",
+                                ts->gc.base);
+        }
+
+        return ret;
+}
+
+/*
+ * We mark ad7879_gpio_remove inline so there is a chance the code
+ * gets discarded when not needed. We can't do __devinit/__devexit
+ * markup since it is used in both probe and remove methods.
+ */
+static inline void ad7879_gpio_remove(struct device *dev)
+{
+        struct ad7879 *ts = dev_get_drvdata(dev);
+        struct ad7879_platform_data *pdata = dev->platform_data;
+        int ret;
+
+        if (pdata->gpio_export) {
+                ret = gpiochip_remove(&ts->gc);
+                if (ret)
+                        dev_err(dev, "failed to remove gpio %d\n",
+                                ts->gc.base);
+        }
+}
+#else
+static inline int ad7879_gpio_add(struct device *dev)
+{
+        return 0;
+}
+
+static inline void ad7879_gpio_remove(struct device *dev)
+{
+}
+#endif
 
 static int __devinit ad7879_construct(bus_device *bus, struct ad7879 *ts)
 {
@@ -403,12 +470,6 @@ static int __devinit ad7879_construct(bus_device *bus, struct ad7879 *ts)
         ts->pen_down_acc_interval = pdata->pen_down_acc_interval;
         ts->median = pdata->median;
 
-        if (pdata->gpio_output)
-                ts->gpio_init = AD7879_GPIO_EN |
-                                (pdata->gpio_default ? 0 : AD7879_GPIO_DATA);
-        else
-                ts->gpio_init = AD7879_GPIO_EN | AD7879_GPIODIR;
-
         snprintf(ts->phys, sizeof(ts->phys), "%s/input0", dev_name(&bus->dev));
 
         input_dev->name = "AD7879 Touchscreen";
@@ -446,6 +507,23 @@ static int __devinit ad7879_construct(bus_device *bus, struct ad7879 *ts)
                 goto err_free_mem;
         }
 
+        ts->cmd_crtl3 = AD7879_YPLUS_BIT |
+                        AD7879_XPLUS_BIT |
+                        AD7879_Z2_BIT |
+                        AD7879_Z1_BIT |
+                        AD7879_TEMPMASK_BIT |
+                        AD7879_AUXVBATMASK_BIT |
+                        AD7879_GPIOALERTMASK_BIT;
+
+        ts->cmd_crtl2 = AD7879_PM(AD7879_PM_DYN) | AD7879_DFR |
+                        AD7879_AVG(ts->averaging) |
+                        AD7879_MFS(ts->median) |
+                        AD7879_FCD(ts->first_conversion_delay);
+
+        ts->cmd_crtl1 = AD7879_MODE_INT | AD7879_MODE_SEQ1 |
+                        AD7879_ACQ(ts->acquisition_time) |
+                        AD7879_TMR(ts->pen_down_acc_interval);
+
         ad7879_setup(ts);
 
         err = request_irq(bus->irq, ad7879_irq,
@@ -460,15 +538,21 @@ static int __devinit ad7879_construct(bus_device *bus, struct ad7879 *ts)
         if (err)
                 goto err_free_irq;
 
-        err = input_register_device(input_dev);
+        err = ad7879_gpio_add(&bus->dev);
         if (err)
                 goto err_remove_attr;
 
+        err = input_register_device(input_dev);
+        if (err)
+                goto err_remove_gpio;
+
         dev_info(&bus->dev, "Rev.%d touchscreen, irq %d\n",
                  revid >> 8, bus->irq);
 
         return 0;
 
+err_remove_gpio:
+        ad7879_gpio_remove(&bus->dev);
 err_remove_attr:
         sysfs_remove_group(&bus->dev.kobj, &ad7879_attr_group);
 err_free_irq:
@@ -481,6 +565,7 @@ err_free_mem:
 
 static int __devexit ad7879_destroy(bus_device *bus, struct ad7879 *ts)
 {
+        ad7879_gpio_remove(&bus->dev);
         ad7879_disable(ts);
         sysfs_remove_group(&ts->bus->dev.kobj, &ad7879_attr_group);
         free_irq(ts->bus->irq, ts);
diff --git a/drivers/input/touchscreen/ads7846.c b/drivers/input/touchscreen/ads7846.c
index 09c810999b92..532279cda0e4 100644
--- a/drivers/input/touchscreen/ads7846.c
+++ b/drivers/input/touchscreen/ads7846.c
@@ -27,15 +27,16 @@
 #include <linux/gpio.h>
 #include <linux/spi/spi.h>
 #include <linux/spi/ads7846.h>
+#include <linux/regulator/consumer.h>
 #include <asm/irq.h>
 
-
 /*
  * This code has been heavily tested on a Nokia 770, and lightly
- * tested on other ads7846 devices (OSK/Mistral, Lubbock).
+ * tested on other ads7846 devices (OSK/Mistral, Lubbock, Spitz).
  * TSC2046 is just newer ads7846 silicon.
  * Support for ads7843 tested on Atmel at91sam926x-EK.
  * Support for ads7845 has only been stubbed in.
+ * Support for Analog Devices AD7873 and AD7843 tested.
  *
  * IRQ handling needs a workaround because of a shortcoming in handling
  * edge triggered IRQs on some platforms like the OMAP1/2. These
@@ -43,7 +44,7 @@
  * have to maintain our own SW IRQ disabled status. This should be
  * removed as soon as the affected platform's IRQ handling is fixed.
  *
- * app note sbaa036 talks in more detail about accurate sampling...
+ * App note sbaa036 talks in more detail about accurate sampling...
  * that ought to help in situations like LCDs inducing noise (which
  * can also be helped by using synch signals) and more generally.
  * This driver tries to utilize the measures described in the app
@@ -86,6 +87,7 @@ struct ads7846 {
         char                    name[32];
 
         struct spi_device       *spi;
+        struct regulator        *reg;
 
 #if defined(CONFIG_HWMON) || defined(CONFIG_HWMON_MODULE)
         struct attribute_group  *attr_group;
@@ -566,10 +568,8 @@ static void ads7846_rx(void *ads)
          * once more the measurement
          */
         if (packet->tc.ignore || Rt > ts->pressure_max) {
-#ifdef VERBOSE
-                pr_debug("%s: ignored %d pressure %d\n",
-                        dev_name(&ts->spi->dev), packet->tc.ignore, Rt);
-#endif
+                dev_vdbg(&ts->spi->dev, "ignored %d pressure %d\n",
+                         packet->tc.ignore, Rt);
                 hrtimer_start(&ts->timer, ktime_set(0, TS_POLL_PERIOD),
                               HRTIMER_MODE_REL);
                 return;
@@ -598,9 +598,7 @@ static void ads7846_rx(void *ads)
                 if (!ts->pendown) {
                         input_report_key(input, BTN_TOUCH, 1);
                         ts->pendown = 1;
-#ifdef VERBOSE
-                        dev_dbg(&ts->spi->dev, "DOWN\n");
-#endif
+                        dev_vdbg(&ts->spi->dev, "DOWN\n");
                 }
 
                 if (ts->swap_xy)
@@ -608,12 +606,10 @@ static void ads7846_rx(void *ads)
 
                 input_report_abs(input, ABS_X, x);
                 input_report_abs(input, ABS_Y, y);
-                input_report_abs(input, ABS_PRESSURE, Rt);
+                input_report_abs(input, ABS_PRESSURE, ts->pressure_max - Rt);
 
                 input_sync(input);
-#ifdef VERBOSE
-                dev_dbg(&ts->spi->dev, "%4d/%4d/%4d\n", x, y, Rt);
-#endif
+                dev_vdbg(&ts->spi->dev, "%4d/%4d/%4d\n", x, y, Rt);
         }
 
         hrtimer_start(&ts->timer, ktime_set(0, TS_POLL_PERIOD),
@@ -723,9 +719,7 @@ static enum hrtimer_restart ads7846_timer(struct hrtimer *handle)
                         input_sync(input);
 
                         ts->pendown = 0;
-#ifdef VERBOSE
-                        dev_dbg(&ts->spi->dev, "UP\n");
-#endif
+                        dev_vdbg(&ts->spi->dev, "UP\n");
                 }
 
                 /* measurement cycle ended */
@@ -797,6 +791,8 @@ static void ads7846_disable(struct ads7846 *ts)
                 }
         }
 
+        regulator_disable(ts->reg);
+
         /* we know the chip's in lowpower mode since we always
          * leave it that way after every request
          */
@@ -808,6 +804,8 @@ static void ads7846_enable(struct ads7846 *ts)
         if (!ts->disabled)
                 return;
 
+        regulator_enable(ts->reg);
+
         ts->disabled = 0;
         ts->irq_disabled = 0;
         enable_irq(ts->spi->irq);
@@ -824,6 +822,9 @@ static int ads7846_suspend(struct spi_device *spi, pm_message_t message)
 
         spin_unlock_irq(&ts->lock);
 
+        if (device_may_wakeup(&ts->spi->dev))
+                enable_irq_wake(ts->spi->irq);
+
         return 0;
 
 }
@@ -832,6 +833,9 @@ static int ads7846_resume(struct spi_device *spi)
 {
         struct ads7846 *ts = dev_get_drvdata(&spi->dev);
 
+        if (device_may_wakeup(&ts->spi->dev))
+                disable_irq_wake(ts->spi->irq);
+
         spin_lock_irq(&ts->lock);
 
         ts->is_suspended = 0;
@@ -987,6 +991,15 @@ static int __devinit ads7846_probe(struct spi_device *spi)
 
         vref = pdata->keep_vref_on;
 
+        if (ts->model == 7873) {
+                /* The AD7873 is almost identical to the ADS7846
+                 * keep VREF off during differential/ratiometric
+                 * conversion modes
+                 */
+                ts->model = 7846;
+                vref = 0;
+        }
+
         /* set up the transfers to read touchscreen state; this assumes we
          * use formula #2 for pressure, not #3.
          */
@@ -1148,6 +1161,19 @@ static int __devinit ads7846_probe(struct spi_device *spi)
 
         ts->last_msg = m;
 
+        ts->reg = regulator_get(&spi->dev, "vcc");
+        if (IS_ERR(ts->reg)) {
+                dev_err(&spi->dev, "unable to get regulator: %ld\n",
+                        PTR_ERR(ts->reg));
+                goto err_free_gpio;
+        }
+
+        err = regulator_enable(ts->reg);
+        if (err) {
+                dev_err(&spi->dev, "unable to enable regulator: %d\n", err);
+                goto err_put_regulator;
+        }
+
         if (request_irq(spi->irq, ads7846_irq, IRQF_TRIGGER_FALLING,
                         spi->dev.driver->name, ts)) {
                 dev_info(&spi->dev,
@@ -1157,7 +1183,7 @@ static int __devinit ads7846_probe(struct spi_device *spi)
                                   spi->dev.driver->name, ts);
                 if (err) {
                         dev_dbg(&spi->dev, "irq %d busy?\n", spi->irq);
-                        goto err_free_gpio;
+                        goto err_disable_regulator;
                 }
         }
 
@@ -1181,6 +1207,8 @@ static int __devinit ads7846_probe(struct spi_device *spi)
         if (err)
                 goto err_remove_attr_group;
 
+        device_init_wakeup(&spi->dev, pdata->wakeup);
+
         return 0;
 
  err_remove_attr_group:
@@ -1189,6 +1217,10 @@ static int __devinit ads7846_probe(struct spi_device *spi)
         ads784x_hwmon_unregister(spi, ts);
  err_free_irq:
         free_irq(spi->irq, ts);
+ err_disable_regulator:
+        regulator_disable(ts->reg);
+ err_put_regulator:
+        regulator_put(ts->reg);
  err_free_gpio:
         if (ts->gpio_pendown != -1)
                 gpio_free(ts->gpio_pendown);
@@ -1206,6 +1238,8 @@ static int __devexit ads7846_remove(struct spi_device *spi)
 {
         struct ads7846          *ts = dev_get_drvdata(&spi->dev);
 
+        device_init_wakeup(&spi->dev, false);
+
         ads784x_hwmon_unregister(spi, ts);
         input_unregister_device(ts->input);
 
@@ -1217,6 +1251,9 @@ static int __devexit ads7846_remove(struct spi_device *spi)
         /* suspend left the IRQ disabled */
         enable_irq(ts->spi->irq);
 
+        regulator_disable(ts->reg);
+        regulator_put(ts->reg);
+
         if (ts->gpio_pendown != -1)
                 gpio_free(ts->gpio_pendown);
 
diff --git a/drivers/input/touchscreen/atmel-wm97xx.c b/drivers/input/touchscreen/atmel-wm97xx.c
index 35377f583e28..fa8e56bd9094 100644
--- a/drivers/input/touchscreen/atmel-wm97xx.c
+++ b/drivers/input/touchscreen/atmel-wm97xx.c
@@ -19,6 +19,7 @@
 #include <linux/timer.h>
 #include <linux/gpio.h>
 #include <linux/io.h>
+#include <linux/slab.h>
 
 #define AC97C_ICA               0x10
 #define AC97C_CBRHR             0x30
@@ -59,7 +60,7 @@
 #define ATMEL_WM97XX_AC97C_IRQ          (29)
 #define ATMEL_WM97XX_GPIO_DEFAULT       (32+16) /* Pin 16 on port B. */
 #else
-#error Unkown CPU, this driver only supports AT32AP700X CPUs.
+#error Unknown CPU, this driver only supports AT32AP700X CPUs.
 #endif
 
 struct continuous {
diff --git a/drivers/input/touchscreen/atmel_tsadcc.c b/drivers/input/touchscreen/atmel_tsadcc.c
index 9c7fce4d74d0..3d9b5166ebe9 100644
--- a/drivers/input/touchscreen/atmel_tsadcc.c
+++ b/drivers/input/touchscreen/atmel_tsadcc.c
@@ -22,6 +22,8 @@
 #include <linux/clk.h>
 #include <linux/platform_device.h>
 #include <linux/io.h>
+#include <mach/board.h>
+#include <mach/cpu.h>
 
 /* Register definitions based on AT91SAM9RL64 preliminary draft datasheet */
 
@@ -36,7 +38,9 @@
 #define   ATMEL_TSADCC_LOWRES   (1    <<  4)    /* Resolution selection */
 #define   ATMEL_TSADCC_SLEEP    (1    <<  5)    /* Sleep mode */
 #define   ATMEL_TSADCC_PENDET   (1    <<  6)    /* Pen Detect selection */
+#define   ATMEL_TSADCC_PRES     (1    <<  7)    /* Pressure Measurement Selection */
 #define   ATMEL_TSADCC_PRESCAL  (0x3f <<  8)    /* Prescalar Rate Selection */
+#define   ATMEL_TSADCC_EPRESCAL (0xff <<  8)    /* Prescalar Rate Selection (Extended) */
 #define   ATMEL_TSADCC_STARTUP  (0x7f << 16)    /* Start Up time */
 #define   ATMEL_TSADCC_SHTIM    (0xf  << 24)    /* Sample & Hold time */
 #define   ATMEL_TSADCC_PENDBC   (0xf  << 28)    /* Pen Detect debouncing time */
@@ -84,7 +88,13 @@
 #define ATMEL_TSADCC_CDR4       0x40    /* Channel Data 4 */
 #define ATMEL_TSADCC_CDR5       0x44    /* Channel Data 5 */
 
-#define ADC_CLOCK       1000000
+#define ATMEL_TSADCC_XPOS       0x50
+#define ATMEL_TSADCC_Z1DAT      0x54
+#define ATMEL_TSADCC_Z2DAT      0x58
+
+#define PRESCALER_VAL(x)        ((x) >> 8)
+
+#define ADC_DEFAULT_CLOCK       100000
 
 struct atmel_tsadcc {
         struct input_dev        *input;
@@ -172,6 +182,7 @@ static int __devinit atmel_tsadcc_probe(struct platform_device *pdev)
         struct atmel_tsadcc     *ts_dev;
         struct input_dev        *input_dev;
         struct resource         *res;
+        struct at91_tsadcc_data *pdata = pdev->dev.platform_data;
         int             err = 0;
         unsigned int    prsc;
         unsigned int    reg;
@@ -242,31 +253,49 @@ static int __devinit atmel_tsadcc_probe(struct platform_device *pdev)
         input_dev->phys = ts_dev->phys;
         input_dev->dev.parent = &pdev->dev;
 
-        input_dev->evbit[0] = BIT_MASK(EV_KEY) | BIT_MASK(EV_ABS);
-        input_dev->keybit[BIT_WORD(BTN_TOUCH)] = BIT_MASK(BTN_TOUCH);
-
+        __set_bit(EV_ABS, input_dev->evbit);
         input_set_abs_params(input_dev, ABS_X, 0, 0x3FF, 0, 0);
         input_set_abs_params(input_dev, ABS_Y, 0, 0x3FF, 0, 0);
 
+        input_set_capability(input_dev, EV_KEY, BTN_TOUCH);
+
         /* clk_enable() always returns 0, no need to check it */
         clk_enable(ts_dev->clk);
 
         prsc = clk_get_rate(ts_dev->clk);
         dev_info(&pdev->dev, "Master clock is set at: %d Hz\n", prsc);
 
-        prsc = prsc / ADC_CLOCK / 2 - 1;
+        if (!pdata)
+                goto err_fail;
+
+        if (!pdata->adc_clock)
+                pdata->adc_clock = ADC_DEFAULT_CLOCK;
+
+        prsc = (prsc / (2 * pdata->adc_clock)) - 1;
+
+        /* saturate if this value is too high */
+        if (cpu_is_at91sam9rl()) {
+                if (prsc > PRESCALER_VAL(ATMEL_TSADCC_PRESCAL))
+                        prsc = PRESCALER_VAL(ATMEL_TSADCC_PRESCAL);
+        } else {
+                if (prsc > PRESCALER_VAL(ATMEL_TSADCC_EPRESCAL))
+                        prsc = PRESCALER_VAL(ATMEL_TSADCC_EPRESCAL);
+        }
+
+        dev_info(&pdev->dev, "Prescaler is set at: %d\n", prsc);
 
         reg = ATMEL_TSADCC_TSAMOD_TS_ONLY_MODE          |
                 ((0x00 << 5) & ATMEL_TSADCC_SLEEP)      |       /* Normal Mode */
                 ((0x01 << 6) & ATMEL_TSADCC_PENDET)     |       /* Enable Pen Detect */
-                ((prsc << 8) & ATMEL_TSADCC_PRESCAL)    |       /* PRESCAL */
-                ((0x13 << 16) & ATMEL_TSADCC_STARTUP)   |       /* STARTUP */
-                ((0x0F << 28) & ATMEL_TSADCC_PENDBC);           /* PENDBC */
+                (prsc << 8)                             |
+                ((0x26 << 16) & ATMEL_TSADCC_STARTUP)   |
+                ((pdata->pendet_debounce << 28) & ATMEL_TSADCC_PENDBC);
 
         atmel_tsadcc_write(ATMEL_TSADCC_CR, ATMEL_TSADCC_SWRST);
         atmel_tsadcc_write(ATMEL_TSADCC_MR, reg);
         atmel_tsadcc_write(ATMEL_TSADCC_TRGR, ATMEL_TSADCC_TRGMOD_NONE);
-        atmel_tsadcc_write(ATMEL_TSADCC_TSR, (0x3 << 24) & ATMEL_TSADCC_TSSHTIM);
+        atmel_tsadcc_write(ATMEL_TSADCC_TSR,
+                (pdata->ts_sample_hold_time << 24) & ATMEL_TSADCC_TSSHTIM);
 
         atmel_tsadcc_read(ATMEL_TSADCC_SR);
         atmel_tsadcc_write(ATMEL_TSADCC_IER, ATMEL_TSADCC_PENCNT);
diff --git a/drivers/input/touchscreen/da9034-ts.c b/drivers/input/touchscreen/da9034-ts.c
index 3ffd4c4b170c..2b72a5923c16 100644
--- a/drivers/input/touchscreen/da9034-ts.c
+++ b/drivers/input/touchscreen/da9034-ts.c
@@ -19,6 +19,7 @@
 #include <linux/input.h>
 #include <linux/workqueue.h>
 #include <linux/mfd/da903x.h>
+#include <linux/slab.h>
 
 #define DA9034_MANUAL_CTRL      0x50
 #define DA9034_LDO_ADC_EN       (1 << 4)
diff --git a/drivers/input/touchscreen/dynapro.c b/drivers/input/touchscreen/dynapro.c
new file mode 100644
index 000000000000..455353908bdf
--- /dev/null
+++ b/drivers/input/touchscreen/dynapro.c
@@ -0,0 +1,206 @@
+/*
+ * Dynapro serial touchscreen driver
+ *
+ * Copyright (c) 2009 Tias Guns
+ * Based on the inexio driver (c) Vojtech Pavlik and Dan Streetman and
+ * Richard Lemon
+ *
+ */
+
+/*
+ * This program is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License version 2 as published by
+ * the Free Software Foundation.
+ */
+
+/*
+ * 2009/09/19 Tias Guns <tias@ulyssis.org>
+ *   Copied inexio.c and edited for Dynapro protocol (from retired Xorg module)
+ */
+
+#include <linux/errno.h>
+#include <linux/kernel.h>
+#include <linux/module.h>
+#include <linux/slab.h>
+#include <linux/input.h>
+#include <linux/serio.h>
+#include <linux/init.h>
+
+#define DRIVER_DESC     "Dynapro serial touchscreen driver"
+
+MODULE_AUTHOR("Tias Guns <tias@ulyssis.org>");
+MODULE_DESCRIPTION(DRIVER_DESC);
+MODULE_LICENSE("GPL");
+
+/*
+ * Definitions & global arrays.
+ */
+
+#define DYNAPRO_FORMAT_TOUCH_BIT 0x40
+#define DYNAPRO_FORMAT_LENGTH 3
+#define DYNAPRO_RESPONSE_BEGIN_BYTE 0x80
+
+#define DYNAPRO_MIN_XC 0
+#define DYNAPRO_MAX_XC 0x3ff
+#define DYNAPRO_MIN_YC 0
+#define DYNAPRO_MAX_YC 0x3ff
+
+#define DYNAPRO_GET_XC(data) (data[1] | ((data[0] & 0x38) << 4))
+#define DYNAPRO_GET_YC(data) (data[2] | ((data[0] & 0x07) << 7))
+#define DYNAPRO_GET_TOUCHED(data) (DYNAPRO_FORMAT_TOUCH_BIT & data[0])
+
+/*
+ * Per-touchscreen data.
+ */
+
+struct dynapro {
+        struct input_dev *dev;
+        struct serio *serio;
+        int idx;
+        unsigned char data[DYNAPRO_FORMAT_LENGTH];
+        char phys[32];
+};
+
+static void dynapro_process_data(struct dynapro *pdynapro)
+{
+        struct input_dev *dev = pdynapro->dev;
+
+        if (DYNAPRO_FORMAT_LENGTH == ++pdynapro->idx) {
+                input_report_abs(dev, ABS_X, DYNAPRO_GET_XC(pdynapro->data));
+                input_report_abs(dev, ABS_Y, DYNAPRO_GET_YC(pdynapro->data));
+                input_report_key(dev, BTN_TOUCH,
+                                 DYNAPRO_GET_TOUCHED(pdynapro->data));
+                input_sync(dev);
+
+                pdynapro->idx = 0;
+        }
+}
+
+static irqreturn_t dynapro_interrupt(struct serio *serio,
+                unsigned char data, unsigned int flags)
+{
+        struct dynapro *pdynapro = serio_get_drvdata(serio);
+
+        pdynapro->data[pdynapro->idx] = data;
+
+        if (DYNAPRO_RESPONSE_BEGIN_BYTE & pdynapro->data[0])
+                dynapro_process_data(pdynapro);
+        else
+                dev_dbg(&serio->dev, "unknown/unsynchronized data: %x\n",
+                        pdynapro->data[0]);
+
+        return IRQ_HANDLED;
+}
+
+static void dynapro_disconnect(struct serio *serio)
+{
+        struct dynapro *pdynapro = serio_get_drvdata(serio);
+
+        input_get_device(pdynapro->dev);
+        input_unregister_device(pdynapro->dev);
+        serio_close(serio);
+        serio_set_drvdata(serio, NULL);
+        input_put_device(pdynapro->dev);
+        kfree(pdynapro);
+}
+
+/*
+ * dynapro_connect() is the routine that is called when someone adds a
+ * new serio device that supports dynapro protocol and registers it as
+ * an input device. This is usually accomplished using inputattach.
+ */
+
+static int dynapro_connect(struct serio *serio, struct serio_driver *drv)
+{
+        struct dynapro *pdynapro;
+        struct input_dev *input_dev;
+        int err;
+
+        pdynapro = kzalloc(sizeof(struct dynapro), GFP_KERNEL);
+        input_dev = input_allocate_device();
+        if (!pdynapro || !input_dev) {
+                err = -ENOMEM;
+                goto fail1;
+        }
+
+        pdynapro->serio = serio;
+        pdynapro->dev = input_dev;
+        snprintf(pdynapro->phys, sizeof(pdynapro->phys),
+                 "%s/input0", serio->phys);
+
+        input_dev->name = "Dynapro Serial TouchScreen";
+        input_dev->phys = pdynapro->phys;
+        input_dev->id.bustype = BUS_RS232;
+        input_dev->id.vendor = SERIO_DYNAPRO;
+        input_dev->id.product = 0;
+        input_dev->id.version = 0x0001;
+        input_dev->dev.parent = &serio->dev;
+        input_dev->evbit[0] = BIT_MASK(EV_KEY) | BIT_MASK(EV_ABS);
+        input_dev->keybit[BIT_WORD(BTN_TOUCH)] = BIT_MASK(BTN_TOUCH);
+        input_set_abs_params(pdynapro->dev, ABS_X,
+                             DYNAPRO_MIN_XC, DYNAPRO_MAX_XC, 0, 0);
+        input_set_abs_params(pdynapro->dev, ABS_Y,
+                             DYNAPRO_MIN_YC, DYNAPRO_MAX_YC, 0, 0);
+
+        serio_set_drvdata(serio, pdynapro);
+
+        err = serio_open(serio, drv);
+        if (err)
+                goto fail2;
+
+        err = input_register_device(pdynapro->dev);
+        if (err)
+                goto fail3;
+
+        return 0;
+
+ fail3: serio_close(serio);
+ fail2: serio_set_drvdata(serio, NULL);
+ fail1: input_free_device(input_dev);
+        kfree(pdynapro);
+        return err;
+}
+
+/*
+ * The serio driver structure.
+ */
+
+static struct serio_device_id dynapro_serio_ids[] = {
+        {
+                .type   = SERIO_RS232,
+                .proto  = SERIO_DYNAPRO,
+                .id     = SERIO_ANY,
+                .extra  = SERIO_ANY,
+        },
+        { 0 }
+};
+
+MODULE_DEVICE_TABLE(serio, dynapro_serio_ids);
+
+static struct serio_driver dynapro_drv = {
+        .driver         = {
+                .name   = "dynapro",
+        },
+        .description    = DRIVER_DESC,
+        .id_table       = dynapro_serio_ids,
+        .interrupt      = dynapro_interrupt,
+        .connect        = dynapro_connect,
+        .disconnect     = dynapro_disconnect,
+};
+
+/*
+ * The functions for inserting/removing us as a module.
+ */
+
+static int __init dynapro_init(void)
+{
+        return serio_register_driver(&dynapro_drv);
+}
+
+static void __exit dynapro_exit(void)
+{
+        serio_unregister_driver(&dynapro_drv);
+}
+
+module_init(dynapro_init);
+module_exit(dynapro_exit);
diff --git a/drivers/input/touchscreen/eeti_ts.c b/drivers/input/touchscreen/eeti_ts.c
index 9029bd3f34e5..204b8a1a601c 100644
--- a/drivers/input/touchscreen/eeti_ts.c
+++ b/drivers/input/touchscreen/eeti_ts.c
@@ -33,6 +33,7 @@
 #include <linux/timer.h>
 #include <linux/gpio.h>
 #include <linux/input/eeti_ts.h>
+#include <linux/slab.h>
 
 static int flip_x;
 module_param(flip_x, bool, 0644);
diff --git a/drivers/input/touchscreen/elo.c b/drivers/input/touchscreen/elo.c
index 8f38c5e55ce6..486d31ba9c09 100644
--- a/drivers/input/touchscreen/elo.c
+++ b/drivers/input/touchscreen/elo.c
@@ -72,45 +72,49 @@ static void elo_process_data_10(struct elo *elo, unsigned char data)
         struct input_dev *dev = elo->dev;
 
         elo->data[elo->idx] = data;
-        switch (elo->idx++) {
-                case 0:
-                        elo->csum = 0xaa;
-                        if (data != ELO10_LEAD_BYTE) {
-                                pr_debug("elo: unsynchronized data: 0x%02x\n", data);
-                                elo->idx = 0;
-                        }
-                        break;
 
-                case 9:
+        switch (elo->idx++) {
+        case 0:
+                elo->csum = 0xaa;
+                if (data != ELO10_LEAD_BYTE) {
+                        dev_dbg(&elo->serio->dev,
+                                "unsynchronized data: 0x%02x\n", data);
                         elo->idx = 0;
-                        if (data != elo->csum) {
-                                pr_debug("elo: bad checksum: 0x%02x, expected 0x%02x\n",
-                                         data, elo->csum);
-                                break;
-                        }
-                        if (elo->data[1] != elo->expected_packet) {
-                                if (elo->data[1] != ELO10_TOUCH_PACKET)
-                                        pr_debug("elo: unexpected packet: 0x%02x\n",
-                                                 elo->data[1]);
-                                break;
-                        }
-                        if (likely(elo->data[1] == ELO10_TOUCH_PACKET)) {
-                                input_report_abs(dev, ABS_X, (elo->data[4] << 8) | elo->data[3]);
-                                input_report_abs(dev, ABS_Y, (elo->data[6] << 8) | elo->data[5]);
-                                if (elo->data[2] & ELO10_PRESSURE)
-                                        input_report_abs(dev, ABS_PRESSURE,
-                                                        (elo->data[8] << 8) | elo->data[7]);
-                                input_report_key(dev, BTN_TOUCH, elo->data[2] & ELO10_TOUCH);
-                                input_sync(dev);
-                        } else if (elo->data[1] == ELO10_ACK_PACKET) {
-                                if (elo->data[2] == '0')
-                                        elo->expected_packet = ELO10_TOUCH_PACKET;
-                                complete(&elo->cmd_done);
-                        } else {
-                                memcpy(elo->response, &elo->data[1], ELO10_PACKET_LEN);
-                                elo->expected_packet = ELO10_ACK_PACKET;
-                        }
+                }
+                break;
+
+        case 9:
+                elo->idx = 0;
+                if (data != elo->csum) {
+                        dev_dbg(&elo->serio->dev,
+                                "bad checksum: 0x%02x, expected 0x%02x\n",
+                                 data, elo->csum);
+                        break;
+                }
+                if (elo->data[1] != elo->expected_packet) {
+                        if (elo->data[1] != ELO10_TOUCH_PACKET)
+                                dev_dbg(&elo->serio->dev,
+                                        "unexpected packet: 0x%02x\n",
+                                         elo->data[1]);
                         break;
+                }
+                if (likely(elo->data[1] == ELO10_TOUCH_PACKET)) {
+                        input_report_abs(dev, ABS_X, (elo->data[4] << 8) | elo->data[3]);
+                        input_report_abs(dev, ABS_Y, (elo->data[6] << 8) | elo->data[5]);
+                        if (elo->data[2] & ELO10_PRESSURE)
+                                input_report_abs(dev, ABS_PRESSURE,
+                                                (elo->data[8] << 8) | elo->data[7]);
+                        input_report_key(dev, BTN_TOUCH, elo->data[2] & ELO10_TOUCH);
+                        input_sync(dev);
+                } else if (elo->data[1] == ELO10_ACK_PACKET) {
+                        if (elo->data[2] == '0')
+                                elo->expected_packet = ELO10_TOUCH_PACKET;
+                        complete(&elo->cmd_done);
+                } else {
+                        memcpy(elo->response, &elo->data[1], ELO10_PACKET_LEN);
+                        elo->expected_packet = ELO10_ACK_PACKET;
+                }
+                break;
         }
         elo->csum += data;
 }
@@ -123,42 +127,53 @@ static void elo_process_data_6(struct elo *elo, unsigned char data)
 
         switch (elo->idx++) {
 
-                case 0: if ((data & 0xc0) != 0xc0) elo->idx = 0; break;
-                case 1: if ((data & 0xc0) != 0x80) elo->idx = 0; break;
-                case 2: if ((data & 0xc0) != 0x40) elo->idx = 0; break;
-
-                case 3:
-                        if (data & 0xc0) {
-                                elo->idx = 0;
-                                break;
-                        }
+        case 0:
+                if ((data & 0xc0) != 0xc0)
+                        elo->idx = 0;
+                break;
 
-                        input_report_abs(dev, ABS_X, ((elo->data[0] & 0x3f) << 6) | (elo->data[1] & 0x3f));
-                        input_report_abs(dev, ABS_Y, ((elo->data[2] & 0x3f) << 6) | (elo->data[3] & 0x3f));
+        case 1:
+                if ((data & 0xc0) != 0x80)
+                        elo->idx = 0;
+                break;
 
-                        if (elo->id == 2) {
-                                input_report_key(dev, BTN_TOUCH, 1);
-                                input_sync(dev);
-                                elo->idx = 0;
-                        }
+        case 2:
+                if ((data & 0xc0) != 0x40)
+                        elo->idx = 0;
+                break;
 
+        case 3:
+                if (data & 0xc0) {
+                        elo->idx = 0;
                         break;
+                }
 
-                case 4:
-                        if (data) {
-                                input_sync(dev);
-                                elo->idx = 0;
-                        }
-                        break;
+                input_report_abs(dev, ABS_X, ((elo->data[0] & 0x3f) << 6) | (elo->data[1] & 0x3f));
+                input_report_abs(dev, ABS_Y, ((elo->data[2] & 0x3f) << 6) | (elo->data[3] & 0x3f));
 
-                case 5:
-                        if ((data & 0xf0) == 0) {
-                                input_report_abs(dev, ABS_PRESSURE, elo->data[5]);
-                                input_report_key(dev, BTN_TOUCH, !!elo->data[5]);
-                        }
+                if (elo->id == 2) {
+                        input_report_key(dev, BTN_TOUCH, 1);
                         input_sync(dev);
                         elo->idx = 0;
-                        break;
+                }
+
+                break;
+
+        case 4:
+                if (data) {
+                        input_sync(dev);
+                        elo->idx = 0;
+                }
+                break;
+
+        case 5:
+                if ((data & 0xf0) == 0) {
+                        input_report_abs(dev, ABS_PRESSURE, elo->data[5]);
+                        input_report_key(dev, BTN_TOUCH, !!elo->data[5]);
+                }
+                input_sync(dev);
+                elo->idx = 0;
+                break;
         }
 }
 
@@ -170,17 +185,17 @@ static void elo_process_data_3(struct elo *elo, unsigned char data)
 
         switch (elo->idx++) {
 
-                case 0:
-                        if ((data & 0x7f) != 0x01)
-                                elo->idx = 0;
-                        break;
-                case 2:
-                        input_report_key(dev, BTN_TOUCH, !(elo->data[1] & 0x80));
-                        input_report_abs(dev, ABS_X, elo->data[1]);
-                        input_report_abs(dev, ABS_Y, elo->data[2]);
-                        input_sync(dev);
+        case 0:
+                if ((data & 0x7f) != 0x01)
                         elo->idx = 0;
-                        break;
+                break;
+        case 2:
+                input_report_key(dev, BTN_TOUCH, !(elo->data[1] & 0x80));
+                input_report_abs(dev, ABS_X, elo->data[1]);
+                input_report_abs(dev, ABS_Y, elo->data[2]);
+                input_sync(dev);
+                elo->idx = 0;
+                break;
         }
 }
 
@@ -189,19 +204,19 @@ static irqreturn_t elo_interrupt(struct serio *serio,
 {
         struct elo *elo = serio_get_drvdata(serio);
 
-        switch(elo->id) {
-                case 0:
-                        elo_process_data_10(elo, data);
-                        break;
-
-                case 1:
-                case 2:
-                        elo_process_data_6(elo, data);
-                        break;
-
-                case 3:
-                        elo_process_data_3(elo, data);
-                        break;
+        switch (elo->id) {
+        case 0:
+                elo_process_data_10(elo, data);
+                break;
+
+        case 1:
+        case 2:
+                elo_process_data_6(elo, data);
+                break;
+
+        case 3:
+                elo_process_data_3(elo, data);
+                break;
         }
 
         return IRQ_HANDLED;
@@ -261,10 +276,10 @@ static int elo_setup_10(struct elo *elo)
         if (packet[3] & ELO10_PRESSURE)
                 input_set_abs_params(dev, ABS_PRESSURE, 0, 255, 0, 0);
 
-        printk(KERN_INFO "elo: %sTouch touchscreen, fw: %02x.%02x, "
-                "features: 0x%02x, controller: 0x%02x\n",
-                elo_types[(packet[1] -'0') & 0x03],
-                packet[5], packet[4], packet[3], packet[7]);
+        dev_info(&elo->serio->dev,
+                 "%sTouch touchscreen, fw: %02x.%02x, features: 0x%02x, controller: 0x%02x\n",
+                 elo_types[(packet[1] -'0') & 0x03],
+                 packet[5], packet[4], packet[3], packet[7]);
 
         return 0;
 }
@@ -330,24 +345,24 @@ static int elo_connect(struct serio *serio, struct serio_driver *drv)
 
         switch (elo->id) {
 
-                case 0: /* 10-byte protocol */
-                        if (elo_setup_10(elo))
-                                goto fail3;
+        case 0: /* 10-byte protocol */
+                if (elo_setup_10(elo))
+                        goto fail3;
 
-                        break;
+                break;
 
-                case 1: /* 6-byte protocol */
-                        input_set_abs_params(input_dev, ABS_PRESSURE, 0, 15, 0, 0);
+        case 1: /* 6-byte protocol */
+                input_set_abs_params(input_dev, ABS_PRESSURE, 0, 15, 0, 0);
 
-                case 2: /* 4-byte protocol */
-                        input_set_abs_params(input_dev, ABS_X, 96, 4000, 0, 0);
-                        input_set_abs_params(input_dev, ABS_Y, 96, 4000, 0, 0);
-                        break;
+        case 2: /* 4-byte protocol */
+                input_set_abs_params(input_dev, ABS_X, 96, 4000, 0, 0);
+                input_set_abs_params(input_dev, ABS_Y, 96, 4000, 0, 0);
+                break;
 
-                case 3: /* 3-byte protocol */
-                        input_set_abs_params(input_dev, ABS_X, 0, 255, 0, 0);
-                        input_set_abs_params(input_dev, ABS_Y, 0, 255, 0, 0);
-                        break;
+        case 3: /* 3-byte protocol */
+                input_set_abs_params(input_dev, ABS_X, 0, 255, 0, 0);
+                input_set_abs_params(input_dev, ABS_Y, 0, 255, 0, 0);
+                break;
         }
 
         err = input_register_device(elo->dev);
diff --git a/drivers/input/touchscreen/jornada720_ts.c b/drivers/input/touchscreen/jornada720_ts.c
index c8b7e8a45c4d..4b0a061811ff 100644
--- a/drivers/input/touchscreen/jornada720_ts.c
+++ b/drivers/input/touchscreen/jornada720_ts.c
@@ -18,6 +18,7 @@
 #include <linux/input.h>
 #include <linux/interrupt.h>
 #include <linux/module.h>
+#include <linux/slab.h>
 
 #include <mach/hardware.h>
 #include <mach/jornada720.h>
diff --git a/drivers/input/touchscreen/mainstone-wm97xx.c b/drivers/input/touchscreen/mainstone-wm97xx.c
index 8fc3b08deb3b..b6b8b1c7ecea 100644
--- a/drivers/input/touchscreen/mainstone-wm97xx.c
+++ b/drivers/input/touchscreen/mainstone-wm97xx.c
@@ -14,7 +14,7 @@
  *
  * Notes:
  *     This is a wm97xx extended touch driver to capture touch
- *     data in a continuous manner on the Intel XScale archictecture
+ *     data in a continuous manner on the Intel XScale architecture
  *
  *  Features:
  *       - codecs supported:- WM9705, WM9712, WM9713
@@ -131,7 +131,7 @@ static int wm97xx_acc_pen_down(struct wm97xx *wm)
         /* When the AC97 queue has been drained we need to allow time
          * to buffer up samples otherwise we end up spinning polling
          * for samples.  The controller can't have a suitably low
-         * threashold set to use the notifications it gives.
+         * threshold set to use the notifications it gives.
          */
         schedule_timeout_uninterruptible(1);
 
@@ -153,6 +153,9 @@ static int wm97xx_acc_pen_down(struct wm97xx *wm)
                 if (pressure)
                         p = MODR;
 
+                dev_dbg(wm->dev, "Raw coordinates: x=%x, y=%x, p=%x\n",
+                        x, y, p);
+
                 /* are samples valid */
                 if ((x & WM97XX_ADCSRC_MASK) != WM97XX_ADCSEL_X ||
                     (y & WM97XX_ADCSRC_MASK) != WM97XX_ADCSEL_Y ||
diff --git a/drivers/input/touchscreen/mc13783_ts.c b/drivers/input/touchscreen/mc13783_ts.c
new file mode 100644
index 000000000000..c5bc62d85bb6
--- /dev/null
+++ b/drivers/input/touchscreen/mc13783_ts.c
@@ -0,0 +1,259 @@
+/*
+ * Driver for the Freescale Semiconductor MC13783 touchscreen.
+ *
+ * Copyright 2004-2007 Freescale Semiconductor, Inc. All Rights Reserved.
+ * Copyright (C) 2009 Sascha Hauer, Pengutronix
+ *
+ * Initial development of this code was funded by
+ * Phytec Messtechnik GmbH, http://www.phytec.de/
+ *
+ * This program is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License version 2 as published by
+ * the Free Software Foundation.
+ */
+#include <linux/platform_device.h>
+#include <linux/mfd/mc13783.h>
+#include <linux/kernel.h>
+#include <linux/module.h>
+#include <linux/input.h>
+#include <linux/sched.h>
+#include <linux/slab.h>
+#include <linux/init.h>
+
+#define MC13783_TS_NAME "mc13783-ts"
+
+#define DEFAULT_SAMPLE_TOLERANCE 300
+
+static unsigned int sample_tolerance = DEFAULT_SAMPLE_TOLERANCE;
+module_param(sample_tolerance, uint, S_IRUGO | S_IWUSR);
+MODULE_PARM_DESC(sample_tolerance,
+                "If the minimal and maximal value read out for one axis (out "
+                "of three) differ by this value (default: "
+                __stringify(DEFAULT_SAMPLE_TOLERANCE) ") or more, the reading "
+                "is supposed to be wrong and is discarded.  Set to 0 to "
+                "disable this check.");
+
+struct mc13783_ts_priv {
+        struct input_dev *idev;
+        struct mc13783 *mc13783;
+        struct delayed_work work;
+        struct workqueue_struct *workq;
+        unsigned int sample[4];
+};
+
+static irqreturn_t mc13783_ts_handler(int irq, void *data)
+{
+        struct mc13783_ts_priv *priv = data;
+
+        mc13783_irq_ack(priv->mc13783, irq);
+
+        /*
+         * Kick off reading coordinates. Note that if work happens already
+         * be queued for future execution (it rearms itself) it will not
+         * be rescheduled for immediate execution here. However the rearm
+         * delay is HZ / 50 which is acceptable.
+         */
+        queue_delayed_work(priv->workq, &priv->work, 0);
+
+        return IRQ_HANDLED;
+}
+
+#define sort3(a0, a1, a2) ({                                            \
+                if (a0 > a1)                                            \
+                        swap(a0, a1);                                   \
+                if (a1 > a2)                                            \
+                        swap(a1, a2);                                   \
+                if (a0 > a1)                                            \
+                        swap(a0, a1);                                   \
+                })
+
+static void mc13783_ts_report_sample(struct mc13783_ts_priv *priv)
+{
+        struct input_dev *idev = priv->idev;
+        int x0, x1, x2, y0, y1, y2;
+        int cr0, cr1;
+
+        /*
+         * the values are 10-bit wide only, but the two least significant
+         * bits are for future 12 bit use and reading yields 0
+         */
+        x0 = priv->sample[0] & 0xfff;
+        x1 = priv->sample[1] & 0xfff;
+        x2 = priv->sample[2] & 0xfff;
+        y0 = priv->sample[3] & 0xfff;
+        y1 = (priv->sample[0] >> 12) & 0xfff;
+        y2 = (priv->sample[1] >> 12) & 0xfff;
+        cr0 = (priv->sample[2] >> 12) & 0xfff;
+        cr1 = (priv->sample[3] >> 12) & 0xfff;
+
+        dev_dbg(&idev->dev,
+                "x: (% 4d,% 4d,% 4d) y: (% 4d, % 4d,% 4d) cr: (% 4d, % 4d)\n",
+                x0, x1, x2, y0, y1, y2, cr0, cr1);
+
+        sort3(x0, x1, x2);
+        sort3(y0, y1, y2);
+
+        cr0 = (cr0 + cr1) / 2;
+
+        if (!cr0 || !sample_tolerance ||
+                        (x2 - x0 < sample_tolerance &&
+                         y2 - y0 < sample_tolerance)) {
+                /* report the median coordinate and average pressure */
+                if (cr0) {
+                        input_report_abs(idev, ABS_X, x1);
+                        input_report_abs(idev, ABS_Y, y1);
+
+                        dev_dbg(&idev->dev, "report (%d, %d, %d)\n",
+                                        x1, y1, 0x1000 - cr0);
+                        queue_delayed_work(priv->workq, &priv->work, HZ / 50);
+                } else
+                        dev_dbg(&idev->dev, "report release\n");
+
+                input_report_abs(idev, ABS_PRESSURE,
+                                cr0 ? 0x1000 - cr0 : cr0);
+                input_report_key(idev, BTN_TOUCH, cr0);
+                input_sync(idev);
+        } else
+                dev_dbg(&idev->dev, "discard event\n");
+}
+
+static void mc13783_ts_work(struct work_struct *work)
+{
+        struct mc13783_ts_priv *priv =
+                container_of(work, struct mc13783_ts_priv, work.work);
+        unsigned int mode = MC13783_ADC_MODE_TS;
+        unsigned int channel = 12;
+
+        if (mc13783_adc_do_conversion(priv->mc13783,
+                                mode, channel, priv->sample) == 0)
+                mc13783_ts_report_sample(priv);
+}
+
+static int mc13783_ts_open(struct input_dev *dev)
+{
+        struct mc13783_ts_priv *priv = input_get_drvdata(dev);
+        int ret;
+
+        mc13783_lock(priv->mc13783);
+
+        mc13783_irq_ack(priv->mc13783, MC13783_IRQ_TS);
+
+        ret = mc13783_irq_request(priv->mc13783, MC13783_IRQ_TS,
+                mc13783_ts_handler, MC13783_TS_NAME, priv);
+        if (ret)
+                goto out;
+
+        ret = mc13783_reg_rmw(priv->mc13783, MC13783_ADC0,
+                        MC13783_ADC0_TSMOD_MASK, MC13783_ADC0_TSMOD0);
+        if (ret)
+                mc13783_irq_free(priv->mc13783, MC13783_IRQ_TS, priv);
+out:
+        mc13783_unlock(priv->mc13783);
+        return ret;
+}
+
+static void mc13783_ts_close(struct input_dev *dev)
+{
+        struct mc13783_ts_priv *priv = input_get_drvdata(dev);
+
+        mc13783_lock(priv->mc13783);
+        mc13783_reg_rmw(priv->mc13783, MC13783_ADC0,
+                        MC13783_ADC0_TSMOD_MASK, 0);
+        mc13783_irq_free(priv->mc13783, MC13783_IRQ_TS, priv);
+        mc13783_unlock(priv->mc13783);
+
+        cancel_delayed_work_sync(&priv->work);
+}
+
+static int __init mc13783_ts_probe(struct platform_device *pdev)
+{
+        struct mc13783_ts_priv *priv;
+        struct input_dev *idev;
+        int ret = -ENOMEM;
+
+        priv = kzalloc(sizeof(*priv), GFP_KERNEL);
+        idev = input_allocate_device();
+        if (!priv || !idev)
+                goto err_free_mem;
+
+        INIT_DELAYED_WORK(&priv->work, mc13783_ts_work);
+        priv->mc13783 = dev_get_drvdata(pdev->dev.parent);
+        priv->idev = idev;
+
+        /*
+         * We need separate workqueue because mc13783_adc_do_conversion
+         * uses keventd and thus would deadlock.
+         */
+        priv->workq = create_singlethread_workqueue("mc13783_ts");
+        if (!priv->workq)
+                goto err_free_mem;
+
+        idev->name = MC13783_TS_NAME;
+        idev->dev.parent = &pdev->dev;
+
+        idev->evbit[0] = BIT_MASK(EV_KEY) | BIT_MASK(EV_ABS);
+        idev->keybit[BIT_WORD(BTN_TOUCH)] = BIT_MASK(BTN_TOUCH);
+        input_set_abs_params(idev, ABS_X, 0, 0xfff, 0, 0);
+        input_set_abs_params(idev, ABS_Y, 0, 0xfff, 0, 0);
+        input_set_abs_params(idev, ABS_PRESSURE, 0, 0xfff, 0, 0);
+
+        idev->open = mc13783_ts_open;
+        idev->close = mc13783_ts_close;
+
+        input_set_drvdata(idev, priv);
+
+        ret = input_register_device(priv->idev);
+        if (ret) {
+                dev_err(&pdev->dev,
+                        "register input device failed with %d\n", ret);
+                goto err_destroy_wq;
+        }
+
+        platform_set_drvdata(pdev, priv);
+        return 0;
+
+err_destroy_wq:
+        destroy_workqueue(priv->workq);
+err_free_mem:
+        input_free_device(idev);
+        kfree(priv);
+        return ret;
+}
+
+static int __devexit mc13783_ts_remove(struct platform_device *pdev)
+{
+        struct mc13783_ts_priv *priv = platform_get_drvdata(pdev);
+
+        platform_set_drvdata(pdev, NULL);
+
+        destroy_workqueue(priv->workq);
+        input_unregister_device(priv->idev);
+        kfree(priv);
+
+        return 0;
+}
+
+static struct platform_driver mc13783_ts_driver = {
+        .remove         = __devexit_p(mc13783_ts_remove),
+        .driver         = {
+                .owner  = THIS_MODULE,
+                .name   = MC13783_TS_NAME,
+        },
+};
+
+static int __init mc13783_ts_init(void)
+{
+        return platform_driver_probe(&mc13783_ts_driver, &mc13783_ts_probe);
+}
+module_init(mc13783_ts_init);
+
+static void __exit mc13783_ts_exit(void)
+{
+        platform_driver_unregister(&mc13783_ts_driver);
+}
+module_exit(mc13783_ts_exit);
+
+MODULE_DESCRIPTION("MC13783 input touchscreen driver");
+MODULE_AUTHOR("Sascha Hauer <s.hauer@pengutronix.de>");
+MODULE_LICENSE("GPL v2");
+MODULE_ALIAS("platform:" MC13783_TS_NAME);
diff --git a/drivers/input/touchscreen/mcs5000_ts.c b/drivers/input/touchscreen/mcs5000_ts.c
index 4c28b89757f9..ce8ab0269f6f 100644
--- a/drivers/input/touchscreen/mcs5000_ts.c
+++ b/drivers/input/touchscreen/mcs5000_ts.c
@@ -20,6 +20,7 @@
 #include <linux/interrupt.h>
 #include <linux/input.h>
 #include <linux/irq.h>
+#include <linux/slab.h>
 
 /* Registers */
 #define MCS5000_TS_STATUS               0x00
diff --git a/drivers/input/touchscreen/migor_ts.c b/drivers/input/touchscreen/migor_ts.c
index 141dd584330e..defe5dd3627c 100644
--- a/drivers/input/touchscreen/migor_ts.c
+++ b/drivers/input/touchscreen/migor_ts.c
@@ -23,6 +23,7 @@
 #include <linux/kernel.h>
 #include <linux/input.h>
 #include <linux/interrupt.h>
+#include <linux/slab.h>
 #include <asm/io.h>
 #include <linux/i2c.h>
 #include <linux/timer.h>
diff --git a/drivers/input/touchscreen/pcap_ts.c b/drivers/input/touchscreen/pcap_ts.c
index 67fcd33595de..ea6ef16e59b4 100644
--- a/drivers/input/touchscreen/pcap_ts.c
+++ b/drivers/input/touchscreen/pcap_ts.c
@@ -14,6 +14,7 @@
 #include <linux/init.h>
 #include <linux/fs.h>
 #include <linux/string.h>
+#include <linux/slab.h>
 #include <linux/pm.h>
 #include <linux/timer.h>
 #include <linux/interrupt.h>
@@ -233,7 +234,7 @@ static int pcap_ts_resume(struct device *dev)
         return 0;
 }
 
-static struct dev_pm_ops pcap_ts_pm_ops = {
+static const struct dev_pm_ops pcap_ts_pm_ops = {
         .suspend        = pcap_ts_suspend,
         .resume         = pcap_ts_resume,
 };
diff --git a/drivers/input/touchscreen/s3c2410_ts.c b/drivers/input/touchscreen/s3c2410_ts.c
new file mode 100644
index 000000000000..98a7d1279486
--- /dev/null
+++ b/drivers/input/touchscreen/s3c2410_ts.c
@@ -0,0 +1,459 @@
+/*
+ * Samsung S3C24XX touchscreen driver
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the term of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
+ *
+ * Copyright 2004 Arnaud Patard <arnaud.patard@rtp-net.org>
+ * Copyright 2008 Ben Dooks <ben-linux@fluff.org>
+ * Copyright 2009 Simtec Electronics <linux@simtec.co.uk>
+ *
+ * Additional work by Herbert Pötzl <herbert@13thfloor.at> and
+ * Harald Welte <laforge@openmoko.org>
+ */
+
+#include <linux/errno.h>
+#include <linux/kernel.h>
+#include <linux/module.h>
+#include <linux/gpio.h>
+#include <linux/input.h>
+#include <linux/init.h>
+#include <linux/delay.h>
+#include <linux/interrupt.h>
+#include <linux/platform_device.h>
+#include <linux/clk.h>
+#include <linux/io.h>
+
+#include <plat/adc.h>
+#include <plat/regs-adc.h>
+
+#include <mach/regs-gpio.h>
+#include <mach/ts.h>
+
+#define TSC_SLEEP  (S3C2410_ADCTSC_PULL_UP_DISABLE | S3C2410_ADCTSC_XY_PST(0))
+
+#define INT_DOWN        (0)
+#define INT_UP          (1 << 8)
+
+#define WAIT4INT        (S3C2410_ADCTSC_YM_SEN | \
+                         S3C2410_ADCTSC_YP_SEN | \
+                         S3C2410_ADCTSC_XP_SEN | \
+                         S3C2410_ADCTSC_XY_PST(3))
+
+#define AUTOPST         (S3C2410_ADCTSC_YM_SEN | \
+                         S3C2410_ADCTSC_YP_SEN | \
+                         S3C2410_ADCTSC_XP_SEN | \
+                         S3C2410_ADCTSC_AUTO_PST | \
+                         S3C2410_ADCTSC_XY_PST(0))
+
+/* Per-touchscreen data. */
+
+/**
+ * struct s3c2410ts - driver touchscreen state.
+ * @client: The ADC client we registered with the core driver.
+ * @dev: The device we are bound to.
+ * @input: The input device we registered with the input subsystem.
+ * @clock: The clock for the adc.
+ * @io: Pointer to the IO base.
+ * @xp: The accumulated X position data.
+ * @yp: The accumulated Y position data.
+ * @irq_tc: The interrupt number for pen up/down interrupt
+ * @count: The number of samples collected.
+ * @shift: The log2 of the maximum count to read in one go.
+ */
+struct s3c2410ts {
+        struct s3c_adc_client *client;
+        struct device *dev;
+        struct input_dev *input;
+        struct clk *clock;
+        void __iomem *io;
+        unsigned long xp;
+        unsigned long yp;
+        int irq_tc;
+        int count;
+        int shift;
+};
+
+static struct s3c2410ts ts;
+
+/**
+ * s3c2410_ts_connect - configure gpio for s3c2410 systems
+ *
+ * Configure the GPIO for the S3C2410 system, where we have external FETs
+ * connected to the device (later systems such as the S3C2440 integrate
+ * these into the device).
+*/
+static inline void s3c2410_ts_connect(void)
+{
+        s3c2410_gpio_cfgpin(S3C2410_GPG(12), S3C2410_GPG12_XMON);
+        s3c2410_gpio_cfgpin(S3C2410_GPG(13), S3C2410_GPG13_nXPON);
+        s3c2410_gpio_cfgpin(S3C2410_GPG(14), S3C2410_GPG14_YMON);
+        s3c2410_gpio_cfgpin(S3C2410_GPG(15), S3C2410_GPG15_nYPON);
+}
+
+/**
+ * get_down - return the down state of the pen
+ * @data0: The data read from ADCDAT0 register.
+ * @data1: The data read from ADCDAT1 register.
+ *
+ * Return non-zero if both readings show that the pen is down.
+ */
+static inline bool get_down(unsigned long data0, unsigned long data1)
+{
+        /* returns true if both data values show stylus down */
+        return (!(data0 & S3C2410_ADCDAT0_UPDOWN) &&
+                !(data1 & S3C2410_ADCDAT0_UPDOWN));
+}
+
+static void touch_timer_fire(unsigned long data)
+{
+        unsigned long data0;
+        unsigned long data1;
+        bool down;
+
+        data0 = readl(ts.io + S3C2410_ADCDAT0);
+        data1 = readl(ts.io + S3C2410_ADCDAT1);
+
+        down = get_down(data0, data1);
+
+        if (down) {
+                if (ts.count == (1 << ts.shift)) {
+                        ts.xp >>= ts.shift;
+                        ts.yp >>= ts.shift;
+
+                        dev_dbg(ts.dev, "%s: X=%lu, Y=%lu, count=%d\n",
+                                __func__, ts.xp, ts.yp, ts.count);
+
+                        input_report_abs(ts.input, ABS_X, ts.xp);
+                        input_report_abs(ts.input, ABS_Y, ts.yp);
+
+                        input_report_key(ts.input, BTN_TOUCH, 1);
+                        input_sync(ts.input);
+
+                        ts.xp = 0;
+                        ts.yp = 0;
+                        ts.count = 0;
+                }
+
+                s3c_adc_start(ts.client, 0, 1 << ts.shift);
+        } else {
+                ts.xp = 0;
+                ts.yp = 0;
+                ts.count = 0;
+
+                input_report_key(ts.input, BTN_TOUCH, 0);
+                input_sync(ts.input);
+
+                writel(WAIT4INT | INT_DOWN, ts.io + S3C2410_ADCTSC);
+        }
+}
+
+static DEFINE_TIMER(touch_timer, touch_timer_fire, 0, 0);
+
+/**
+ * stylus_irq - touchscreen stylus event interrupt
+ * @irq: The interrupt number
+ * @dev_id: The device ID.
+ *
+ * Called when the IRQ_TC is fired for a pen up or down event.
+ */
+static irqreturn_t stylus_irq(int irq, void *dev_id)
+{
+        unsigned long data0;
+        unsigned long data1;
+        bool down;
+
+        data0 = readl(ts.io + S3C2410_ADCDAT0);
+        data1 = readl(ts.io + S3C2410_ADCDAT1);
+
+        down = get_down(data0, data1);
+
+        /* TODO we should never get an interrupt with down set while
+         * the timer is running, but maybe we ought to verify that the
+         * timer isn't running anyways. */
+
+        if (down)
+                s3c_adc_start(ts.client, 0, 1 << ts.shift);
+        else
+                dev_info(ts.dev, "%s: count=%d\n", __func__, ts.count);
+
+        return IRQ_HANDLED;
+}
+
+/**
+ * s3c24xx_ts_conversion - ADC conversion callback
+ * @client: The client that was registered with the ADC core.
+ * @data0: The reading from ADCDAT0.
+ * @data1: The reading from ADCDAT1.
+ * @left: The number of samples left.
+ *
+ * Called when a conversion has finished.
+ */
+static void s3c24xx_ts_conversion(struct s3c_adc_client *client,
+                                  unsigned data0, unsigned data1,
+                                  unsigned *left)
+{
+        dev_dbg(ts.dev, "%s: %d,%d\n", __func__, data0, data1);
+
+        ts.xp += data0;
+        ts.yp += data1;
+
+        ts.count++;
+
+        /* From tests, it seems that it is unlikely to get a pen-up
+         * event during the conversion process which means we can
+         * ignore any pen-up events with less than the requisite
+         * count done.
+         *
+         * In several thousand conversions, no pen-ups where detected
+         * before count completed.
+         */
+}
+
+/**
+ * s3c24xx_ts_select - ADC selection callback.
+ * @client: The client that was registered with the ADC core.
+ * @select: The reason for select.
+ *
+ * Called when the ADC core selects (or deslects) us as a client.
+ */
+static void s3c24xx_ts_select(struct s3c_adc_client *client, unsigned select)
+{
+        if (select) {
+                writel(S3C2410_ADCTSC_PULL_UP_DISABLE | AUTOPST,
+                       ts.io + S3C2410_ADCTSC);
+        } else {
+                mod_timer(&touch_timer, jiffies+1);
+                writel(WAIT4INT | INT_UP, ts.io + S3C2410_ADCTSC);
+        }
+}
+
+/**
+ * s3c2410ts_probe - device core probe entry point
+ * @pdev: The device we are being bound to.
+ *
+ * Initialise, find and allocate any resources we need to run and then
+ * register with the ADC and input systems.
+ */
+static int __devinit s3c2410ts_probe(struct platform_device *pdev)
+{
+        struct s3c2410_ts_mach_info *info;
+        struct device *dev = &pdev->dev;
+        struct input_dev *input_dev;
+        struct resource *res;
+        int ret = -EINVAL;
+
+        /* Initialise input stuff */
+        memset(&ts, 0, sizeof(struct s3c2410ts));
+
+        ts.dev = dev;
+
+        info = pdev->dev.platform_data;
+        if (!info) {
+                dev_err(dev, "no platform data, cannot attach\n");
+                return -EINVAL;
+        }
+
+        dev_dbg(dev, "initialising touchscreen\n");
+
+        ts.clock = clk_get(dev, "adc");
+        if (IS_ERR(ts.clock)) {
+                dev_err(dev, "cannot get adc clock source\n");
+                return -ENOENT;
+        }
+
+        clk_enable(ts.clock);
+        dev_dbg(dev, "got and enabled clocks\n");
+
+        ts.irq_tc = ret = platform_get_irq(pdev, 0);
+        if (ret < 0) {
+                dev_err(dev, "no resource for interrupt\n");
+                goto err_clk;
+        }
+
+        res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
+        if (!res) {
+                dev_err(dev, "no resource for registers\n");
+                ret = -ENOENT;
+                goto err_clk;
+        }
+
+        ts.io = ioremap(res->start, resource_size(res));
+        if (ts.io == NULL) {
+                dev_err(dev, "cannot map registers\n");
+                ret = -ENOMEM;
+                goto err_clk;
+        }
+
+        /* Configure the touchscreen external FETs on the S3C2410 */
+        if (!platform_get_device_id(pdev)->driver_data)
+                s3c2410_ts_connect();
+
+        ts.client = s3c_adc_register(pdev, s3c24xx_ts_select,
+                                     s3c24xx_ts_conversion, 1);
+        if (IS_ERR(ts.client)) {
+                dev_err(dev, "failed to register adc client\n");
+                ret = PTR_ERR(ts.client);
+                goto err_iomap;
+        }
+
+        /* Initialise registers */
+        if ((info->delay & 0xffff) > 0)
+                writel(info->delay & 0xffff, ts.io + S3C2410_ADCDLY);
+
+        writel(WAIT4INT | INT_DOWN, ts.io + S3C2410_ADCTSC);
+
+        input_dev = input_allocate_device();
+        if (!input_dev) {
+                dev_err(dev, "Unable to allocate the input device !!\n");
+                ret = -ENOMEM;
+                goto err_iomap;
+        }
+
+        ts.input = input_dev;
+        ts.input->evbit[0] = BIT_MASK(EV_KEY) | BIT_MASK(EV_ABS);
+        ts.input->keybit[BIT_WORD(BTN_TOUCH)] = BIT_MASK(BTN_TOUCH);
+        input_set_abs_params(ts.input, ABS_X, 0, 0x3FF, 0, 0);
+        input_set_abs_params(ts.input, ABS_Y, 0, 0x3FF, 0, 0);
+
+        ts.input->name = "S3C24XX TouchScreen";
+        ts.input->id.bustype = BUS_HOST;
+        ts.input->id.vendor = 0xDEAD;
+        ts.input->id.product = 0xBEEF;
+        ts.input->id.version = 0x0102;
+
+        ts.shift = info->oversampling_shift;
+
+        ret = request_irq(ts.irq_tc, stylus_irq, IRQF_DISABLED,
+                          "s3c2410_ts_pen", ts.input);
+        if (ret) {
+                dev_err(dev, "cannot get TC interrupt\n");
+                goto err_inputdev;
+        }
+
+        dev_info(dev, "driver attached, registering input device\n");
+
+        /* All went ok, so register to the input system */
+        ret = input_register_device(ts.input);
+        if (ret < 0) {
+                dev_err(dev, "failed to register input device\n");
+                ret = -EIO;
+                goto err_tcirq;
+        }
+
+        return 0;
+
+ err_tcirq:
+        free_irq(ts.irq_tc, ts.input);
+ err_inputdev:
+        input_unregister_device(ts.input);
+ err_iomap:
+        iounmap(ts.io);
+ err_clk:
+        del_timer_sync(&touch_timer);
+        clk_put(ts.clock);
+        return ret;
+}
+
+/**
+ * s3c2410ts_remove - device core removal entry point
+ * @pdev: The device we are being removed from.
+ *
+ * Free up our state ready to be removed.
+ */
+static int __devexit s3c2410ts_remove(struct platform_device *pdev)
+{
+        free_irq(ts.irq_tc, ts.input);
+        del_timer_sync(&touch_timer);
+
+        clk_disable(ts.clock);
+        clk_put(ts.clock);
+
+        input_unregister_device(ts.input);
+        iounmap(ts.io);
+
+        return 0;
+}
+
+#ifdef CONFIG_PM
+static int s3c2410ts_suspend(struct device *dev)
+{
+        writel(TSC_SLEEP, ts.io + S3C2410_ADCTSC);
+        disable_irq(ts.irq_tc);
+        clk_disable(ts.clock);
+
+        return 0;
+}
+
+static int s3c2410ts_resume(struct device *dev)
+{
+        struct platform_device *pdev = to_platform_device(dev);
+        struct s3c2410_ts_mach_info *info = pdev->dev.platform_data;
+
+        clk_enable(ts.clock);
+        enable_irq(ts.irq_tc);
+
+        /* Initialise registers */
+        if ((info->delay & 0xffff) > 0)
+                writel(info->delay & 0xffff, ts.io + S3C2410_ADCDLY);
+
+        writel(WAIT4INT | INT_DOWN, ts.io + S3C2410_ADCTSC);
+
+        return 0;
+}
+
+static struct dev_pm_ops s3c_ts_pmops = {
+        .suspend        = s3c2410ts_suspend,
+        .resume         = s3c2410ts_resume,
+};
+#endif
+
+static struct platform_device_id s3cts_driver_ids[] = {
+        { "s3c2410-ts", 0 },
+        { "s3c2440-ts", 1 },
+        { }
+};
+MODULE_DEVICE_TABLE(platform, s3cts_driver_ids);
+
+static struct platform_driver s3c_ts_driver = {
+        .driver         = {
+                .name   = "s3c24xx-ts",
+                .owner  = THIS_MODULE,
+#ifdef CONFIG_PM
+                .pm     = &s3c_ts_pmops,
+#endif
+        },
+        .id_table       = s3cts_driver_ids,
+        .probe          = s3c2410ts_probe,
+        .remove         = __devexit_p(s3c2410ts_remove),
+};
+
+static int __init s3c2410ts_init(void)
+{
+        return platform_driver_register(&s3c_ts_driver);
+}
+
+static void __exit s3c2410ts_exit(void)
+{
+        platform_driver_unregister(&s3c_ts_driver);
+}
+
+module_init(s3c2410ts_init);
+module_exit(s3c2410ts_exit);
+
+MODULE_AUTHOR("Arnaud Patard <arnaud.patard@rtp-net.org>, "
+              "Ben Dooks <ben@simtec.co.uk>, "
+              "Simtec Electronics <linux@simtec.co.uk>");
+MODULE_DESCRIPTION("S3C24XX Touchscreen driver");
+MODULE_LICENSE("GPL v2");
diff --git a/drivers/input/touchscreen/tsc2007.c b/drivers/input/touchscreen/tsc2007.c
index 7ef0d1420d3c..be23780e8a3e 100644
--- a/drivers/input/touchscreen/tsc2007.c
+++ b/drivers/input/touchscreen/tsc2007.c
@@ -358,7 +358,7 @@ static int __devexit tsc2007_remove(struct i2c_client *client)
         return 0;
 }
 
-static struct i2c_device_id tsc2007_idtable[] = {
+static const struct i2c_device_id tsc2007_idtable[] = {
         { "tsc2007", 0 },
         { }
 };
diff --git a/drivers/input/touchscreen/ucb1400_ts.c b/drivers/input/touchscreen/ucb1400_ts.c
index 095f84b1f56e..028a5363eea1 100644
--- a/drivers/input/touchscreen/ucb1400_ts.c
+++ b/drivers/input/touchscreen/ucb1400_ts.c
@@ -26,7 +26,6 @@
 #include <linux/device.h>
 #include <linux/interrupt.h>
 #include <linux/suspend.h>
-#include <linux/slab.h>
 #include <linux/kthread.h>
 #include <linux/freezer.h>
 #include <linux/ucb1400.h>
@@ -355,10 +354,13 @@ static int ucb1400_ts_probe(struct platform_device *dev)
                 goto err;
         }
 
-        error = ucb1400_ts_detect_irq(ucb);
-        if (error) {
-                printk(KERN_ERR "UCB1400: IRQ probe failed\n");
-                goto err_free_devs;
+        /* Only in case the IRQ line wasn't supplied, try detecting it */
+        if (ucb->irq < 0) {
+                error = ucb1400_ts_detect_irq(ucb);
+                if (error) {
+                        printk(KERN_ERR "UCB1400: IRQ probe failed\n");
+                        goto err_free_devs;
+                }
         }
 
         init_waitqueue_head(&ucb->ts_wait);
diff --git a/drivers/input/touchscreen/usbtouchscreen.c b/drivers/input/touchscreen/usbtouchscreen.c
index 68ece5801a58..99330bbdbac7 100644
--- a/drivers/input/touchscreen/usbtouchscreen.c
+++ b/drivers/input/touchscreen/usbtouchscreen.c
@@ -14,6 +14,8 @@
  *  - General Touch
  *  - GoTop Super_Q2/GogoPen/PenPower tablets
  *  - JASTEC USB touch controller/DigiTech DTR-02U
+ *  - Zytronic capacitive touchscreen
+ *  - NEXIO/iNexio
  *
  * Copyright (C) 2004-2007 by Daniel Ritz <daniel.ritz@gmx.ch>
  * Copyright (C) by Todd E. Johnson (mtouchusb.c)
@@ -73,6 +75,15 @@ struct usbtouch_device_info {
         int min_press, max_press;
         int rept_size;
 
+        /*
+         * Always service the USB devices irq not just when the input device is
+         * open. This is useful when devices have a watchdog which prevents us
+         * from periodically polling the device. Leave this unset unless your
+         * touchscreen device requires it, as it does consume more of the USB
+         * bandwidth.
+         */
+        bool irq_always;
+
         void (*process_pkt) (struct usbtouch_usb *usbtouch, unsigned char *pkt, int len);
 
         /*
@@ -85,6 +96,7 @@ struct usbtouch_device_info {
 
         int  (*read_data)   (struct usbtouch_usb *usbtouch, unsigned char *pkt);
         int  (*init)        (struct usbtouch_usb *usbtouch);
+        void (*exit)        (struct usbtouch_usb *usbtouch);
 };
 
 /* a usbtouch device */
@@ -94,11 +106,12 @@ struct usbtouch_usb {
         unsigned char *buffer;
         int buf_len;
         struct urb *irq;
-        struct usb_device *udev;
+        struct usb_interface *interface;
         struct input_dev *input;
         struct usbtouch_device_info *type;
         char name[128];
         char phys[64];
+        void *priv;
 
         int x, y;
         int touch, press;
@@ -121,6 +134,9 @@ enum {
         DEVTYPE_GOTOP,
         DEVTYPE_JASTEC,
         DEVTYPE_E2I,
+        DEVTYPE_ZYTRONIC,
+        DEVTYPE_TC5UH,
+        DEVTYPE_NEXIO,
 };
 
 #define USB_DEVICE_HID_CLASS(vend, prod) \
@@ -132,7 +148,7 @@ enum {
         .bInterfaceClass = USB_INTERFACE_CLASS_HID, \
         .bInterfaceProtocol = USB_INTERFACE_PROTOCOL_MOUSE
 
-static struct usb_device_id usbtouch_devices[] = {
+static const struct usb_device_id usbtouch_devices[] = {
 #ifdef CONFIG_TOUCHSCREEN_USB_EGALAX
         /* ignore the HID capable devices, handled by usbhid */
         {USB_DEVICE_HID_CLASS(0x0eef, 0x0001), .driver_info = DEVTYPE_IGNORE},
@@ -201,6 +217,23 @@ static struct usb_device_id usbtouch_devices[] = {
 #ifdef CONFIG_TOUCHSCREEN_USB_E2I
         {USB_DEVICE(0x1ac7, 0x0001), .driver_info = DEVTYPE_E2I},
 #endif
+
+#ifdef CONFIG_TOUCHSCREEN_USB_ZYTRONIC
+        {USB_DEVICE(0x14c8, 0x0003), .driver_info = DEVTYPE_ZYTRONIC},
+#endif
+
+#ifdef CONFIG_TOUCHSCREEN_USB_ETT_TC5UH
+        {USB_DEVICE(0x0664, 0x0309), .driver_info = DEVTYPE_TC5UH},
+#endif
+
+#ifdef CONFIG_TOUCHSCREEN_USB_NEXIO
+        /* data interface only */
+        {USB_DEVICE_AND_INTERFACE_INFO(0x10f0, 0x2002, 0x0a, 0x00, 0x00),
+                .driver_info = DEVTYPE_NEXIO},
+        {USB_DEVICE_AND_INTERFACE_INFO(0x1870, 0x0001, 0x0a, 0x00, 0x00),
+                .driver_info = DEVTYPE_NEXIO},
+#endif
+
         {}
 };
 
@@ -213,8 +246,9 @@ static struct usb_device_id usbtouch_devices[] = {
 static int e2i_init(struct usbtouch_usb *usbtouch)
 {
         int ret;
+        struct usb_device *udev = interface_to_usbdev(usbtouch->interface);
 
-        ret = usb_control_msg(usbtouch->udev, usb_rcvctrlpipe(usbtouch->udev, 0),
+        ret = usb_control_msg(udev, usb_rcvctrlpipe(udev, 0),
                               0x01, 0x02, 0x0000, 0x0081,
                               NULL, 0, USB_CTRL_SET_TIMEOUT);
 
@@ -323,8 +357,9 @@ static int mtouch_read_data(struct usbtouch_usb *dev, unsigned char *pkt)
 static int mtouch_init(struct usbtouch_usb *usbtouch)
 {
         int ret, i;
+        struct usb_device *udev = interface_to_usbdev(usbtouch->interface);
 
-        ret = usb_control_msg(usbtouch->udev, usb_rcvctrlpipe(usbtouch->udev, 0),
+        ret = usb_control_msg(udev, usb_rcvctrlpipe(udev, 0),
                               MTOUCHUSB_RESET,
                               USB_DIR_OUT | USB_TYPE_VENDOR | USB_RECIP_DEVICE,
                               1, 0, NULL, 0, USB_CTRL_SET_TIMEOUT);
@@ -335,7 +370,7 @@ static int mtouch_init(struct usbtouch_usb *usbtouch)
         msleep(150);
 
         for (i = 0; i < 3; i++) {
-                ret = usb_control_msg(usbtouch->udev, usb_rcvctrlpipe(usbtouch->udev, 0),
+                ret = usb_control_msg(udev, usb_rcvctrlpipe(udev, 0),
                                       MTOUCHUSB_ASYNC_REPORT,
                                       USB_DIR_OUT | USB_TYPE_VENDOR | USB_RECIP_DEVICE,
                                       1, 1, NULL, 0, USB_CTRL_SET_TIMEOUT);
@@ -468,7 +503,7 @@ static int gunze_read_data(struct usbtouch_usb *dev, unsigned char *pkt)
 
 static int dmc_tsc10_init(struct usbtouch_usb *usbtouch)
 {
-        struct usb_device *dev = usbtouch->udev;
+        struct usb_device *dev = interface_to_usbdev(usbtouch->interface);
         int ret = -ENOMEM;
         unsigned char *buf;
 
@@ -538,6 +573,19 @@ static int irtouch_read_data(struct usbtouch_usb *dev, unsigned char *pkt)
 }
 #endif
 
+/*****************************************************************************
+ * ET&T TC5UH part
+ */
+#ifdef CONFIG_TOUCHSCREEN_USB_ETT_TC5UH
+static int tc5uh_read_data(struct usbtouch_usb *dev, unsigned char *pkt)
+{
+        dev->x = ((pkt[2] & 0x0F) << 8) | pkt[1];
+        dev->y = ((pkt[4] & 0x0F) << 8) | pkt[3];
+        dev->touch = pkt[0] & 0x01;
+
+        return 1;
+}
+#endif
 
 /*****************************************************************************
  * IdealTEK URTC1000 Part
@@ -584,8 +632,8 @@ static int idealtek_read_data(struct usbtouch_usb *dev, unsigned char *pkt)
 #ifdef CONFIG_TOUCHSCREEN_USB_GENERAL_TOUCH
 static int general_touch_read_data(struct usbtouch_usb *dev, unsigned char *pkt)
 {
-        dev->x = ((pkt[2] & 0x0F) << 8) | pkt[1] ;
-        dev->y = ((pkt[4] & 0x0F) << 8) | pkt[3] ;
+        dev->x = (pkt[2] << 8) | pkt[1];
+        dev->y = (pkt[4] << 8) | pkt[3];
         dev->press = pkt[5] & 0xff;
         dev->touch = pkt[0] & 0x01;
 
@@ -621,6 +669,262 @@ static int jastec_read_data(struct usbtouch_usb *dev, unsigned char *pkt)
 }
 #endif
 
+/*****************************************************************************
+ * Zytronic Part
+ */
+#ifdef CONFIG_TOUCHSCREEN_USB_ZYTRONIC
+static int zytronic_read_data(struct usbtouch_usb *dev, unsigned char *pkt)
+{
+        switch (pkt[0]) {
+        case 0x3A: /* command response */
+                dbg("%s: Command response %d", __func__, pkt[1]);
+                break;
+
+        case 0xC0: /* down */
+                dev->x = (pkt[1] & 0x7f) | ((pkt[2] & 0x07) << 7);
+                dev->y = (pkt[3] & 0x7f) | ((pkt[4] & 0x07) << 7);
+                dev->touch = 1;
+                dbg("%s: down %d,%d", __func__, dev->x, dev->y);
+                return 1;
+
+        case 0x80: /* up */
+                dev->x = (pkt[1] & 0x7f) | ((pkt[2] & 0x07) << 7);
+                dev->y = (pkt[3] & 0x7f) | ((pkt[4] & 0x07) << 7);
+                dev->touch = 0;
+                dbg("%s: up %d,%d", __func__, dev->x, dev->y);
+                return 1;
+
+        default:
+                dbg("%s: Unknown return %d", __func__, pkt[0]);
+                break;
+        }
+
+        return 0;
+}
+#endif
+
+/*****************************************************************************
+ * NEXIO Part
+ */
+#ifdef CONFIG_TOUCHSCREEN_USB_NEXIO
+
+#define NEXIO_TIMEOUT   5000
+#define NEXIO_BUFSIZE   1024
+#define NEXIO_THRESHOLD 50
+
+struct nexio_priv {
+        struct urb *ack;
+        unsigned char *ack_buf;
+};
+
+struct nexio_touch_packet {
+        u8      flags;          /* 0xe1 = touch, 0xe1 = release */
+        __be16  data_len;       /* total bytes of touch data */
+        __be16  x_len;          /* bytes for X axis */
+        __be16  y_len;          /* bytes for Y axis */
+        u8      data[];
+} __attribute__ ((packed));
+
+static unsigned char nexio_ack_pkt[2] = { 0xaa, 0x02 };
+static unsigned char nexio_init_pkt[4] = { 0x82, 0x04, 0x0a, 0x0f };
+
+static void nexio_ack_complete(struct urb *urb)
+{
+}
+
+static int nexio_init(struct usbtouch_usb *usbtouch)
+{
+        struct usb_device *dev = interface_to_usbdev(usbtouch->interface);
+        struct usb_host_interface *interface = usbtouch->interface->cur_altsetting;
+        struct nexio_priv *priv;
+        int ret = -ENOMEM;
+        int actual_len, i;
+        unsigned char *buf;
+        char *firmware_ver = NULL, *device_name = NULL;
+        int input_ep = 0, output_ep = 0;
+
+        /* find first input and output endpoint */
+        for (i = 0; i < interface->desc.bNumEndpoints; i++) {
+                if (!input_ep &&
+                    usb_endpoint_dir_in(&interface->endpoint[i].desc))
+                        input_ep = interface->endpoint[i].desc.bEndpointAddress;
+                if (!output_ep &&
+                    usb_endpoint_dir_out(&interface->endpoint[i].desc))
+                        output_ep = interface->endpoint[i].desc.bEndpointAddress;
+        }
+        if (!input_ep || !output_ep)
+                return -ENXIO;
+
+        buf = kmalloc(NEXIO_BUFSIZE, GFP_KERNEL);
+        if (!buf)
+                goto out_buf;
+
+        /* two empty reads */
+        for (i = 0; i < 2; i++) {
+                ret = usb_bulk_msg(dev, usb_rcvbulkpipe(dev, input_ep),
+                                   buf, NEXIO_BUFSIZE, &actual_len,
+                                   NEXIO_TIMEOUT);
+                if (ret < 0)
+                        goto out_buf;
+        }
+
+        /* send init command */
+        memcpy(buf, nexio_init_pkt, sizeof(nexio_init_pkt));
+        ret = usb_bulk_msg(dev, usb_sndbulkpipe(dev, output_ep),
+                           buf, sizeof(nexio_init_pkt), &actual_len,
+                           NEXIO_TIMEOUT);
+        if (ret < 0)
+                goto out_buf;
+
+        /* read replies */
+        for (i = 0; i < 3; i++) {
+                memset(buf, 0, NEXIO_BUFSIZE);
+                ret = usb_bulk_msg(dev, usb_rcvbulkpipe(dev, input_ep),
+                                   buf, NEXIO_BUFSIZE, &actual_len,
+                                   NEXIO_TIMEOUT);
+                if (ret < 0 || actual_len < 1 || buf[1] != actual_len)
+                        continue;
+                switch (buf[0]) {
+                case 0x83:      /* firmware version */
+                        if (!firmware_ver)
+                                firmware_ver = kstrdup(&buf[2], GFP_KERNEL);
+                        break;
+                case 0x84:      /* device name */
+                        if (!device_name)
+                                device_name = kstrdup(&buf[2], GFP_KERNEL);
+                        break;
+                }
+        }
+
+        printk(KERN_INFO "Nexio device: %s, firmware version: %s\n",
+               device_name, firmware_ver);
+
+        kfree(firmware_ver);
+        kfree(device_name);
+
+        /* prepare ACK URB */
+        ret = -ENOMEM;
+
+        usbtouch->priv = kmalloc(sizeof(struct nexio_priv), GFP_KERNEL);
+        if (!usbtouch->priv)
+                goto out_buf;
+
+        priv = usbtouch->priv;
+
+        priv->ack_buf = kmalloc(sizeof(nexio_ack_pkt), GFP_KERNEL);
+        if (!priv->ack_buf)
+                goto err_priv;
+
+        memcpy(priv->ack_buf, nexio_ack_pkt, sizeof(nexio_ack_pkt));
+
+        priv->ack = usb_alloc_urb(0, GFP_KERNEL);
+        if (!priv->ack) {
+                dbg("%s - usb_alloc_urb failed: usbtouch->ack", __func__);
+                goto err_ack_buf;
+        }
+
+        usb_fill_bulk_urb(priv->ack, dev, usb_sndbulkpipe(dev, output_ep),
+                          priv->ack_buf, sizeof(nexio_ack_pkt),
+                          nexio_ack_complete, usbtouch);
+        ret = 0;
+        goto out_buf;
+
+err_ack_buf:
+        kfree(priv->ack_buf);
+err_priv:
+        kfree(priv);
+out_buf:
+        kfree(buf);
+        return ret;
+}
+
+static void nexio_exit(struct usbtouch_usb *usbtouch)
+{
+        struct nexio_priv *priv = usbtouch->priv;
+
+        usb_kill_urb(priv->ack);
+        usb_free_urb(priv->ack);
+        kfree(priv->ack_buf);
+        kfree(priv);
+}
+
+static int nexio_read_data(struct usbtouch_usb *usbtouch, unsigned char *pkt)
+{
+        int x, y, begin_x, begin_y, end_x, end_y, w, h, ret;
+        struct nexio_touch_packet *packet = (void *) pkt;
+        struct nexio_priv *priv = usbtouch->priv;
+
+        /* got touch data? */
+        if ((pkt[0] & 0xe0) != 0xe0)
+                return 0;
+
+        /* send ACK */
+        ret = usb_submit_urb(priv->ack, GFP_ATOMIC);
+
+        if (!usbtouch->type->max_xc) {
+                usbtouch->type->max_xc = 2 * be16_to_cpu(packet->x_len);
+                input_set_abs_params(usbtouch->input, ABS_X, 0,
+                                     2 * be16_to_cpu(packet->x_len), 0, 0);
+                usbtouch->type->max_yc = 2 * be16_to_cpu(packet->y_len);
+                input_set_abs_params(usbtouch->input, ABS_Y, 0,
+                                     2 * be16_to_cpu(packet->y_len), 0, 0);
+        }
+        /*
+         * The device reports state of IR sensors on X and Y axes.
+         * Each byte represents "darkness" percentage (0-100) of one element.
+         * 17" touchscreen reports only 64 x 52 bytes so the resolution is low.
+         * This also means that there's a limited multi-touch capability but
+         * it's disabled (and untested) here as there's no X driver for that.
+         */
+        begin_x = end_x = begin_y = end_y = -1;
+        for (x = 0; x < be16_to_cpu(packet->x_len); x++) {
+                if (begin_x == -1 && packet->data[x] > NEXIO_THRESHOLD) {
+                        begin_x = x;
+                        continue;
+                }
+                if (end_x == -1 && begin_x != -1 && packet->data[x] < NEXIO_THRESHOLD) {
+                        end_x = x - 1;
+                        for (y = be16_to_cpu(packet->x_len);
+                             y < be16_to_cpu(packet->data_len); y++) {
+                                if (begin_y == -1 && packet->data[y] > NEXIO_THRESHOLD) {
+                                        begin_y = y - be16_to_cpu(packet->x_len);
+                                        continue;
+                                }
+                                if (end_y == -1 &&
+                                    begin_y != -1 && packet->data[y] < NEXIO_THRESHOLD) {
+                                        end_y = y - 1 - be16_to_cpu(packet->x_len);
+                                        w = end_x - begin_x;
+                                        h = end_y - begin_y;
+#if 0
+                                        /* multi-touch */
+                                        input_report_abs(usbtouch->input,
+                                                    ABS_MT_TOUCH_MAJOR, max(w,h));
+                                        input_report_abs(usbtouch->input,
+                                                    ABS_MT_TOUCH_MINOR, min(x,h));
+                                        input_report_abs(usbtouch->input,
+                                                    ABS_MT_POSITION_X, 2*begin_x+w);
+                                        input_report_abs(usbtouch->input,
+                                                    ABS_MT_POSITION_Y, 2*begin_y+h);
+                                        input_report_abs(usbtouch->input,
+                                                    ABS_MT_ORIENTATION, w > h);
+                                        input_mt_sync(usbtouch->input);
+#endif
+                                        /* single touch */
+                                        usbtouch->x = 2 * begin_x + w;
+                                        usbtouch->y = 2 * begin_y + h;
+                                        usbtouch->touch = packet->flags & 0x01;
+                                        begin_y = end_y = -1;
+                                        return 1;
+                                }
+                        }
+                        begin_x = end_x = -1;
+                }
+
+        }
+        return 0;
+}
+#endif
+
 
 /*****************************************************************************
  * the different device descriptors
@@ -742,9 +1046,9 @@ static struct usbtouch_device_info usbtouch_dev_info[] = {
 #ifdef CONFIG_TOUCHSCREEN_USB_GENERAL_TOUCH
         [DEVTYPE_GENERAL_TOUCH] = {
                 .min_xc         = 0x0,
-                .max_xc         = 0x0500,
+                .max_xc         = 0x7fff,
                 .min_yc         = 0x0,
-                .max_yc         = 0x0500,
+                .max_yc         = 0x7fff,
                 .rept_size      = 7,
                 .read_data      = general_touch_read_data,
         },
@@ -783,6 +1087,39 @@ static struct usbtouch_device_info usbtouch_dev_info[] = {
                 .read_data      = e2i_read_data,
         },
 #endif
+
+#ifdef CONFIG_TOUCHSCREEN_USB_ZYTRONIC
+        [DEVTYPE_ZYTRONIC] = {
+                .min_xc         = 0x0,
+                .max_xc         = 0x03ff,
+                .min_yc         = 0x0,
+                .max_yc         = 0x03ff,
+                .rept_size      = 5,
+                .read_data      = zytronic_read_data,
+                .irq_always     = true,
+        },
+#endif
+
+#ifdef CONFIG_TOUCHSCREEN_USB_ETT_TC5UH
+        [DEVTYPE_TC5UH] = {
+                .min_xc         = 0x0,
+                .max_xc         = 0x0fff,
+                .min_yc         = 0x0,
+                .max_yc         = 0x0fff,
+                .rept_size      = 5,
+                .read_data      = tc5uh_read_data,
+        },
+#endif
+
+#ifdef CONFIG_TOUCHSCREEN_USB_NEXIO
+        [DEVTYPE_NEXIO] = {
+                .rept_size      = 128,
+                .irq_always     = true,
+                .read_data      = nexio_read_data,
+                .init           = nexio_init,
+                .exit           = nexio_exit,
+        },
+#endif
 };
 
 
@@ -908,6 +1245,7 @@ static void usbtouch_irq(struct urb *urb)
         case -ECONNRESET:
         case -ENOENT:
         case -ESHUTDOWN:
+        case -EPIPE:
                 /* this urb is terminated, clean up */
                 dbg("%s - urb shutting down with status: %d",
                     __func__, urb->status);
@@ -931,10 +1269,12 @@ static int usbtouch_open(struct input_dev *input)
 {
         struct usbtouch_usb *usbtouch = input_get_drvdata(input);
 
-        usbtouch->irq->dev = usbtouch->udev;
+        usbtouch->irq->dev = interface_to_usbdev(usbtouch->interface);
 
-        if (usb_submit_urb(usbtouch->irq, GFP_KERNEL))
-                return -EIO;
+        if (!usbtouch->type->irq_always) {
+                if (usb_submit_urb(usbtouch->irq, GFP_KERNEL))
+                  return -EIO;
+        }
 
         return 0;
 }
@@ -943,7 +1283,8 @@ static void usbtouch_close(struct input_dev *input)
 {
         struct usbtouch_usb *usbtouch = input_get_drvdata(input);
 
-        usb_kill_urb(usbtouch->irq);
+        if (!usbtouch->type->irq_always)
+                usb_kill_urb(usbtouch->irq);
 }
 
 
@@ -955,13 +1296,23 @@ static void usbtouch_free_buffers(struct usb_device *udev,
         kfree(usbtouch->buffer);
 }
 
+static struct usb_endpoint_descriptor *
+usbtouch_get_input_endpoint(struct usb_host_interface *interface)
+{
+        int i;
+
+        for (i = 0; i < interface->desc.bNumEndpoints; i++)
+                if (usb_endpoint_dir_in(&interface->endpoint[i].desc))
+                        return &interface->endpoint[i].desc;
+
+        return NULL;
+}
 
 static int usbtouch_probe(struct usb_interface *intf,
                           const struct usb_device_id *id)
 {
         struct usbtouch_usb *usbtouch;
         struct input_dev *input_dev;
-        struct usb_host_interface *interface;
         struct usb_endpoint_descriptor *endpoint;
         struct usb_device *udev = interface_to_usbdev(intf);
         struct usbtouch_device_info *type;
@@ -971,8 +1322,9 @@ static int usbtouch_probe(struct usb_interface *intf,
         if (id->driver_info == DEVTYPE_IGNORE)
                 return -ENODEV;
 
-        interface = intf->cur_altsetting;
-        endpoint = &interface->endpoint[0].desc;
+        endpoint = usbtouch_get_input_endpoint(intf->cur_altsetting);
+        if (!endpoint)
+                return -ENXIO;
 
         usbtouch = kzalloc(sizeof(struct usbtouch_usb), GFP_KERNEL);
         input_dev = input_allocate_device();
@@ -1001,7 +1353,7 @@ static int usbtouch_probe(struct usb_interface *intf,
                 goto out_free_buffers;
         }
 
-        usbtouch->udev = udev;
+        usbtouch->interface = intf;
         usbtouch->input = input_dev;
 
         if (udev->manufacturer)
@@ -1040,12 +1392,18 @@ static int usbtouch_probe(struct usb_interface *intf,
                 input_set_abs_params(input_dev, ABS_PRESSURE, type->min_press,
                                      type->max_press, 0, 0);
 
-        usb_fill_int_urb(usbtouch->irq, usbtouch->udev,
-                         usb_rcvintpipe(usbtouch->udev, endpoint->bEndpointAddress),
+        if (usb_endpoint_type(endpoint) == USB_ENDPOINT_XFER_INT)
+                usb_fill_int_urb(usbtouch->irq, udev,
+                         usb_rcvintpipe(udev, endpoint->bEndpointAddress),
                          usbtouch->data, type->rept_size,
                          usbtouch_irq, usbtouch, endpoint->bInterval);
+        else
+                usb_fill_bulk_urb(usbtouch->irq, udev,
+                         usb_rcvbulkpipe(udev, endpoint->bEndpointAddress),
+                         usbtouch->data, type->rept_size,
+                         usbtouch_irq, usbtouch);
 
-        usbtouch->irq->dev = usbtouch->udev;
+        usbtouch->irq->dev = udev;
         usbtouch->irq->transfer_dma = usbtouch->data_dma;
         usbtouch->irq->transfer_flags |= URB_NO_TRANSFER_DMA_MAP;
 
@@ -1054,20 +1412,37 @@ static int usbtouch_probe(struct usb_interface *intf,
                 err = type->init(usbtouch);
                 if (err) {
                         dbg("%s - type->init() failed, err: %d", __func__, err);
-                        goto out_free_buffers;
+                        goto out_free_urb;
                 }
         }
 
         err = input_register_device(usbtouch->input);
         if (err) {
                 dbg("%s - input_register_device failed, err: %d", __func__, err);
-                goto out_free_buffers;
+                goto out_do_exit;
         }
 
         usb_set_intfdata(intf, usbtouch);
 
+        if (usbtouch->type->irq_always) {
+                err = usb_submit_urb(usbtouch->irq, GFP_KERNEL);
+                if (err) {
+                        err("%s - usb_submit_urb failed with result: %d",
+                            __func__, err);
+                        goto out_unregister_input;
+                }
+        }
+
         return 0;
 
+out_unregister_input:
+        input_unregister_device(input_dev);
+        input_dev = NULL;
+out_do_exit:
+        if (type->exit)
+                type->exit(usbtouch);
+out_free_urb:
+        usb_free_urb(usbtouch->irq);
 out_free_buffers:
         usbtouch_free_buffers(udev, usbtouch);
 out_free:
@@ -1087,9 +1462,11 @@ static void usbtouch_disconnect(struct usb_interface *intf)
 
         dbg("%s - usbtouch is initialized, cleaning up", __func__);
         usb_set_intfdata(intf, NULL);
-        usb_kill_urb(usbtouch->irq);
+        /* this will stop IO via close */
         input_unregister_device(usbtouch->input);
         usb_free_urb(usbtouch->irq);
+        if (usbtouch->type->exit)
+                usbtouch->type->exit(usbtouch);
         usbtouch_free_buffers(interface_to_usbdev(intf), usbtouch);
         kfree(usbtouch);
 }
diff --git a/drivers/input/touchscreen/w90p910_ts.c b/drivers/input/touchscreen/w90p910_ts.c
index 6ccbdbbf33fe..cc18265be1a8 100644
--- a/drivers/input/touchscreen/w90p910_ts.c
+++ b/drivers/input/touchscreen/w90p910_ts.c
@@ -16,6 +16,7 @@
 #include <linux/clk.h>
 #include <linux/input.h>
 #include <linux/interrupt.h>
+#include <linux/slab.h>
 
 /* ADC controller bit defines */
 #define ADC_DELAY       0xf00
diff --git a/drivers/input/touchscreen/wm97xx-core.c b/drivers/input/touchscreen/wm97xx-core.c
index f944918466e5..5109bf3dd858 100644
--- a/drivers/input/touchscreen/wm97xx-core.c
+++ b/drivers/input/touchscreen/wm97xx-core.c
@@ -48,6 +48,7 @@
 #include <linux/wm97xx.h>
 #include <linux/uaccess.h>
 #include <linux/io.h>
+#include <linux/slab.h>
 
 #define TS_NAME                 "wm97xx"
 #define WM_CORE_VERSION         "1.00"
diff --git a/drivers/input/touchscreen/zylonite-wm97xx.c b/drivers/input/touchscreen/zylonite-wm97xx.c
index 41e4359c277c..048849867643 100644
--- a/drivers/input/touchscreen/zylonite-wm97xx.c
+++ b/drivers/input/touchscreen/zylonite-wm97xx.c
@@ -96,7 +96,7 @@ static int wm97xx_acc_pen_down(struct wm97xx *wm)
         /* When the AC97 queue has been drained we need to allow time
          * to buffer up samples otherwise we end up spinning polling
          * for samples.  The controller can't have a suitably low
-         * threashold set to use the notifications it gives.
+         * threshold set to use the notifications it gives.
          */
         msleep(1);
 
@@ -118,6 +118,9 @@ static int wm97xx_acc_pen_down(struct wm97xx *wm)
                 if (pressure)
                         p = MODR;
 
+                dev_dbg(wm->dev, "Raw coordinates: x=%x, y=%x, p=%x\n",
+                        x, y, p);
+
                 /* are samples valid */
                 if ((x & WM97XX_ADCSRC_MASK) != WM97XX_ADCSEL_X ||
                     (y & WM97XX_ADCSRC_MASK) != WM97XX_ADCSEL_Y ||
diff --git a/drivers/input/xen-kbdfront.c b/drivers/input/xen-kbdfront.c
index b115726dc088..e14081675bb2 100644
--- a/drivers/input/xen-kbdfront.c
+++ b/drivers/input/xen-kbdfront.c
@@ -21,7 +21,11 @@
 #include <linux/errno.h>
 #include <linux/module.h>
 #include <linux/input.h>
+#include <linux/slab.h>
+
 #include <asm/xen/hypervisor.h>
+
+#include <xen/xen.h>
 #include <xen/events.h>
 #include <xen/page.h>
 #include <xen/interface/io/fbif.h>
@@ -318,7 +322,7 @@ InitWait:
         }
 }
 
-static struct xenbus_device_id xenkbd_ids[] = {
+static const struct xenbus_device_id xenkbd_ids[] = {
         { "vkbd" },
         { "" }
 };