3 files changed, 95 insertions, 14 deletions

diff --git a/drivers/input/touchscreen/ads7846.c b/drivers/input/touchscreen/ads7846.c
index 4f702b3ec1a3..434c3df250ca 100644
--- a/drivers/input/touchscreen/ads7846.c
+++ b/drivers/input/touchscreen/ads7846.c
@@ -236,7 +236,12 @@ static void __ads7846_disable(struct ads7846 *ts)
 /* Must be called with ts->lock held */
 static void __ads7846_enable(struct ads7846 *ts)
 {
-        regulator_enable(ts->reg);
+        int error;
+
+        error = regulator_enable(ts->reg);
+        if (error != 0)
+                dev_err(&ts->spi->dev, "Failed to enable supply: %d\n", error);
+
         ads7846_restart(ts);
 }
 
diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c b/drivers/input/touchscreen/atmel_mxt_ts.c
index d04f810cb1dd..59aa24002c7b 100644
--- a/drivers/input/touchscreen/atmel_mxt_ts.c
+++ b/drivers/input/touchscreen/atmel_mxt_ts.c
@@ -176,11 +176,17 @@
 /* Define for MXT_GEN_COMMAND_T6 */
 #define MXT_BOOT_VALUE          0xa5
 #define MXT_BACKUP_VALUE        0x55
-#define MXT_BACKUP_TIME         25      /* msec */
-#define MXT_RESET_TIME          65      /* msec */
+#define MXT_BACKUP_TIME         50      /* msec */
+#define MXT_RESET_TIME          200     /* msec */
 
 #define MXT_FWRESET_TIME        175     /* msec */
 
+/* MXT_SPT_GPIOPWM_T19 field */
+#define MXT_GPIO0_MASK          0x04
+#define MXT_GPIO1_MASK          0x08
+#define MXT_GPIO2_MASK          0x10
+#define MXT_GPIO3_MASK          0x20
+
 /* Command to unlock bootloader */
 #define MXT_UNLOCK_CMD_MSB      0xaa
 #define MXT_UNLOCK_CMD_LSB      0xdc
@@ -212,6 +218,8 @@
 /* Touchscreen absolute values */
 #define MXT_MAX_AREA            0xff
 
+#define MXT_PIXELS_PER_MM       20
+
 struct mxt_info {
         u8 family_id;
         u8 variant_id;
@@ -243,6 +251,8 @@ struct mxt_data {
         const struct mxt_platform_data *pdata;
         struct mxt_object *object_table;
         struct mxt_info info;
+        bool is_tp;
+
         unsigned int irq;
         unsigned int max_x;
         unsigned int max_y;
@@ -251,6 +261,7 @@ struct mxt_data {
         u8 T6_reportid;
         u8 T9_reportid_min;
         u8 T9_reportid_max;
+        u8 T19_reportid;
 };
 
 static bool mxt_object_readable(unsigned int type)
@@ -502,6 +513,21 @@ static int mxt_write_object(struct mxt_data *data,
         return mxt_write_reg(data->client, reg + offset, val);
 }
 
+static void mxt_input_button(struct mxt_data *data, struct mxt_message *message)
+{
+        struct input_dev *input = data->input_dev;
+        bool button;
+        int i;
+
+        /* Active-low switch */
+        for (i = 0; i < MXT_NUM_GPIO; i++) {
+                if (data->pdata->key_map[i] == KEY_RESERVED)
+                        continue;
+                button = !(message->message[0] & MXT_GPIO0_MASK << i);
+                input_report_key(input, data->pdata->key_map[i], button);
+        }
+}
+
 static void mxt_input_touchevent(struct mxt_data *data,
                                       struct mxt_message *message, int id)
 {
@@ -585,6 +611,9 @@ static irqreturn_t mxt_interrupt(int irq, void *dev_id)
                         int id = reportid - data->T9_reportid_min;
                         mxt_input_touchevent(data, &message, id);
                         update_input = true;
+                } else if (message.reportid == data->T19_reportid) {
+                        mxt_input_button(data, &message);
+                        update_input = true;
                 } else {
                         mxt_dump_message(dev, &message);
                 }
@@ -764,6 +793,9 @@ static int mxt_get_object_table(struct mxt_data *data)
                         data->T9_reportid_min = min_id;
                         data->T9_reportid_max = max_id;
                         break;
+                case MXT_SPT_GPIOPWM_T19:
+                        data->T19_reportid = min_id;
+                        break;
                 }
         }
 
@@ -777,7 +809,7 @@ static void mxt_free_object_table(struct mxt_data *data)
         data->T6_reportid = 0;
         data->T9_reportid_min = 0;
         data->T9_reportid_max = 0;
-
+        data->T19_reportid = 0;
 }
 
 static int mxt_initialize(struct mxt_data *data)
@@ -1115,9 +1147,13 @@ static int mxt_probe(struct i2c_client *client,
                 goto err_free_mem;
         }
 
-        input_dev->name = "Atmel maXTouch Touchscreen";
+        data->is_tp = pdata && pdata->is_tp;
+
+        input_dev->name = (data->is_tp) ? "Atmel maXTouch Touchpad" :
+                                          "Atmel maXTouch Touchscreen";
         snprintf(data->phys, sizeof(data->phys), "i2c-%u-%04x/input0",
                  client->adapter->nr, client->addr);
+
         input_dev->phys = data->phys;
 
         input_dev->id.bustype = BUS_I2C;
@@ -1140,6 +1176,29 @@ static int mxt_probe(struct i2c_client *client,
         __set_bit(EV_KEY, input_dev->evbit);
         __set_bit(BTN_TOUCH, input_dev->keybit);
 
+        if (data->is_tp) {
+                int i;
+                __set_bit(INPUT_PROP_POINTER, input_dev->propbit);
+                __set_bit(INPUT_PROP_BUTTONPAD, input_dev->propbit);
+
+                for (i = 0; i < MXT_NUM_GPIO; i++)
+                        if (pdata->key_map[i] != KEY_RESERVED)
+                                __set_bit(pdata->key_map[i], input_dev->keybit);
+
+                __set_bit(BTN_TOOL_FINGER, input_dev->keybit);
+                __set_bit(BTN_TOOL_DOUBLETAP, input_dev->keybit);
+                __set_bit(BTN_TOOL_TRIPLETAP, input_dev->keybit);
+                __set_bit(BTN_TOOL_QUADTAP, input_dev->keybit);
+                __set_bit(BTN_TOOL_QUINTTAP, input_dev->keybit);
+
+                input_abs_set_res(input_dev, ABS_X, MXT_PIXELS_PER_MM);
+                input_abs_set_res(input_dev, ABS_Y, MXT_PIXELS_PER_MM);
+                input_abs_set_res(input_dev, ABS_MT_POSITION_X,
+                                  MXT_PIXELS_PER_MM);
+                input_abs_set_res(input_dev, ABS_MT_POSITION_Y,
+                                  MXT_PIXELS_PER_MM);
+        }
+
         /* For single touch */
         input_set_abs_params(input_dev, ABS_X,
                              0, data->max_x, 0, 0);
@@ -1258,6 +1317,7 @@ static SIMPLE_DEV_PM_OPS(mxt_pm_ops, mxt_suspend, mxt_resume);
 static const struct i2c_device_id mxt_id[] = {
         { "qt602240_ts", 0 },
         { "atmel_mxt_ts", 0 },
+        { "atmel_mxt_tp", 0 },
         { "mXT224", 0 },
         { }
 };
diff --git a/drivers/input/touchscreen/mms114.c b/drivers/input/touchscreen/mms114.c
index 4a29ddf6bf1e..1443532fe6c4 100644
--- a/drivers/input/touchscreen/mms114.c
+++ b/drivers/input/touchscreen/mms114.c
@@ -314,15 +314,27 @@ static int mms114_start(struct mms114_data *data)
         struct i2c_client *client = data->client;
         int error;
 
-        if (data->core_reg)
-                regulator_enable(data->core_reg);
-        if (data->io_reg)
-                regulator_enable(data->io_reg);
+        error = regulator_enable(data->core_reg);
+        if (error) {
+                dev_err(&client->dev, "Failed to enable avdd: %d\n", error);
+                return error;
+        }
+
+        error = regulator_enable(data->io_reg);
+        if (error) {
+                dev_err(&client->dev, "Failed to enable vdd: %d\n", error);
+                regulator_disable(data->core_reg);
+                return error;
+        }
+
         mdelay(MMS114_POWERON_DELAY);
 
         error = mms114_setup_regs(data);
-        if (error < 0)
+        if (error < 0) {
+                regulator_disable(data->io_reg);
+                regulator_disable(data->core_reg);
                 return error;
+        }
 
         if (data->pdata->cfg_pin)
                 data->pdata->cfg_pin(true);
@@ -335,16 +347,20 @@ static int mms114_start(struct mms114_data *data)
 static void mms114_stop(struct mms114_data *data)
 {
         struct i2c_client *client = data->client;
+        int error;
 
         disable_irq(client->irq);
 
         if (data->pdata->cfg_pin)
                 data->pdata->cfg_pin(false);
 
-        if (data->io_reg)
-                regulator_disable(data->io_reg);
-        if (data->core_reg)
-                regulator_disable(data->core_reg);
+        error = regulator_disable(data->io_reg);
+        if (error)
+                dev_warn(&client->dev, "Failed to disable vdd: %d\n", error);
+
+        error = regulator_disable(data->core_reg);
+        if (error)
+                dev_warn(&client->dev, "Failed to disable avdd: %d\n", error);
 }
 
 static int mms114_input_open(struct input_dev *dev)