7 files changed, 122 insertions, 40 deletions

diff --git a/drivers/input/keyboard/amikbd.c b/drivers/input/keyboard/amikbd.c
index 81bf7562aca0..35149ec455a9 100644
--- a/drivers/input/keyboard/amikbd.c
+++ b/drivers/input/keyboard/amikbd.c
@@ -1,6 +1,4 @@
 /*
- * $Id: amikbd.c,v 1.13 2002/02/01 16:02:24 vojtech Exp $
- *
  *  Copyright (c) 2000-2001 Vojtech Pavlik
  *
  *  Based on the work of:
diff --git a/drivers/input/keyboard/atkbd.c b/drivers/input/keyboard/atkbd.c
index af58a6f1e898..b1ce10f50bcf 100644
--- a/drivers/input/keyboard/atkbd.c
+++ b/drivers/input/keyboard/atkbd.c
@@ -68,7 +68,7 @@ MODULE_PARM_DESC(extra, "Enable extra LEDs and keys on IBM RapidAcces, EzKey and
  * are loadable via an userland utility.
  */
 
-static unsigned char atkbd_set2_keycode[512] = {
+static const unsigned short atkbd_set2_keycode[512] = {
 
 #ifdef CONFIG_KEYBOARD_ATKBD_HP_KEYCODES
 
@@ -99,7 +99,7 @@ static unsigned char atkbd_set2_keycode[512] = {
 #endif
 };
 
-static unsigned char atkbd_set3_keycode[512] = {
+static const unsigned short atkbd_set3_keycode[512] = {
 
           0,  0,  0,  0,  0,  0,  0, 59,  1,138,128,129,130, 15, 41, 60,
         131, 29, 42, 86, 58, 16,  2, 61,133, 56, 44, 31, 30, 17,  3, 62,
@@ -115,7 +115,7 @@ static unsigned char atkbd_set3_keycode[512] = {
         148,149,147,140
 };
 
-static unsigned char atkbd_unxlate_table[128] = {
+static const unsigned short atkbd_unxlate_table[128] = {
           0,118, 22, 30, 38, 37, 46, 54, 61, 62, 70, 69, 78, 85,102, 13,
          21, 29, 36, 45, 44, 53, 60, 67, 68, 77, 84, 91, 90, 20, 28, 27,
          35, 43, 52, 51, 59, 66, 75, 76, 82, 14, 18, 93, 26, 34, 33, 42,
@@ -161,7 +161,7 @@ static unsigned char atkbd_unxlate_table[128] = {
 #define ATKBD_SCR_LEFT          249
 #define ATKBD_SCR_RIGHT         248
 
-#define ATKBD_SPECIAL           248
+#define ATKBD_SPECIAL           ATKBD_SCR_RIGHT
 
 #define ATKBD_LED_EVENT_BIT     0
 #define ATKBD_REP_EVENT_BIT     1
@@ -173,7 +173,7 @@ static unsigned char atkbd_unxlate_table[128] = {
 #define ATKBD_XL_HANGEUL        0x10
 #define ATKBD_XL_HANJA          0x20
 
-static struct {
+static const struct {
         unsigned char keycode;
         unsigned char set2;
 } atkbd_scroll_keys[] = {
@@ -200,7 +200,7 @@ struct atkbd {
         char phys[32];
 
         unsigned short id;
-        unsigned char keycode[512];
+        unsigned short keycode[512];
         DECLARE_BITMAP(force_release_mask, 512);
         unsigned char set;
         unsigned char translated;
@@ -357,7 +357,7 @@ static irqreturn_t atkbd_interrupt(struct serio *serio, unsigned char data,
         unsigned int code = data;
         int scroll = 0, hscroll = 0, click = -1;
         int value;
-        unsigned char keycode;
+        unsigned short keycode;
 
 #ifdef ATKBD_DEBUG
         printk(KERN_DEBUG "atkbd.c: Received %02x flags %02x\n", data, flags);
@@ -851,6 +851,23 @@ static void atkbd_latitude_keymap_fixup(struct atkbd *atkbd)
 }
 
 /*
+ * Perform fixup for HP system that doesn't generate release
+ * for its video switch
+ */
+static void atkbd_hp_keymap_fixup(struct atkbd *atkbd)
+{
+        const unsigned int forced_release_keys[] = {
+                0x94,
+        };
+        int i;
+
+        if (atkbd->set == 2)
+                for (i = 0; i < ARRAY_SIZE(forced_release_keys); i++)
+                        __set_bit(forced_release_keys[i],
+                                        atkbd->force_release_mask);
+}
+
+/*
  * atkbd_set_keycode_table() initializes keyboard's keycode table
  * according to the selected scancode set
  */
@@ -961,16 +978,16 @@ static void atkbd_set_device_attrs(struct atkbd *atkbd)
                 input_dev->evbit[0] |= BIT_MASK(EV_REL);
                 input_dev->relbit[0] = BIT_MASK(REL_WHEEL) |
                         BIT_MASK(REL_HWHEEL);
-                set_bit(BTN_MIDDLE, input_dev->keybit);
+                __set_bit(BTN_MIDDLE, input_dev->keybit);
         }
 
         input_dev->keycode = atkbd->keycode;
-        input_dev->keycodesize = sizeof(unsigned char);
+        input_dev->keycodesize = sizeof(unsigned short);
         input_dev->keycodemax = ARRAY_SIZE(atkbd_set2_keycode);
 
         for (i = 0; i < 512; i++)
                 if (atkbd->keycode[i] && atkbd->keycode[i] < ATKBD_SPECIAL)
-                        set_bit(atkbd->keycode[i], input_dev->keybit);
+                        __set_bit(atkbd->keycode[i], input_dev->keybit);
 }
 
 /*
@@ -1452,6 +1469,15 @@ static struct dmi_system_id atkbd_dmi_quirk_table[] __initdata = {
                 .callback = atkbd_setup_fixup,
                 .driver_data = atkbd_latitude_keymap_fixup,
         },
+        {
+                .ident = "HP 2133",
+                .matches = {
+                        DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"),
+                        DMI_MATCH(DMI_PRODUCT_NAME, "HP 2133"),
+                },
+                .callback = atkbd_setup_fixup,
+                .driver_data = atkbd_hp_keymap_fixup,
+        },
         { }
 };
 
diff --git a/drivers/input/keyboard/gpio_keys.c b/drivers/input/keyboard/gpio_keys.c
index bbd00c3fe98c..be58730e636a 100644
--- a/drivers/input/keyboard/gpio_keys.c
+++ b/drivers/input/keyboard/gpio_keys.c
@@ -26,23 +26,54 @@
 
 #include <asm/gpio.h>
 
+struct gpio_button_data {
+        struct gpio_keys_button *button;
+        struct input_dev *input;
+        struct timer_list timer;
+};
+
+struct gpio_keys_drvdata {
+        struct input_dev *input;
+        struct gpio_button_data data[0];
+};
+
+static void gpio_keys_report_event(struct gpio_keys_button *button,
+                                   struct input_dev *input)
+{
+        unsigned int type = button->type ?: EV_KEY;
+        int state = (gpio_get_value(button->gpio) ? 1 : 0) ^ button->active_low;
+
+        input_event(input, type, button->code, !!state);
+        input_sync(input);
+}
+
+static void gpio_check_button(unsigned long _data)
+{
+        struct gpio_button_data *data = (struct gpio_button_data *)_data;
+
+        gpio_keys_report_event(data->button, data->input);
+}
+
 static irqreturn_t gpio_keys_isr(int irq, void *dev_id)
 {
-        int i;
         struct platform_device *pdev = dev_id;
         struct gpio_keys_platform_data *pdata = pdev->dev.platform_data;
-        struct input_dev *input = platform_get_drvdata(pdev);
+        struct gpio_keys_drvdata *ddata = platform_get_drvdata(pdev);
+        int i;
 
         for (i = 0; i < pdata->nbuttons; i++) {
                 struct gpio_keys_button *button = &pdata->buttons[i];
-                int gpio = button->gpio;
 
-                if (irq == gpio_to_irq(gpio)) {
-                        unsigned int type = button->type ?: EV_KEY;
-                        int state = (gpio_get_value(gpio) ? 1 : 0) ^ button->active_low;
+                if (irq == gpio_to_irq(button->gpio)) {
+                        struct gpio_button_data *bdata = &ddata->data[i];
+
+                        if (button->debounce_interval)
+                                mod_timer(&bdata->timer,
+                                          jiffies +
+                                          msecs_to_jiffies(button->debounce_interval));
+                        else
+                                gpio_keys_report_event(button, bdata->input);
 
-                        input_event(input, type, button->code, !!state);
-                        input_sync(input);
                         return IRQ_HANDLED;
                 }
         }
@@ -53,17 +84,21 @@ static irqreturn_t gpio_keys_isr(int irq, void *dev_id)
 static int __devinit gpio_keys_probe(struct platform_device *pdev)
 {
         struct gpio_keys_platform_data *pdata = pdev->dev.platform_data;
+        struct gpio_keys_drvdata *ddata;
         struct input_dev *input;
         int i, error;
         int wakeup = 0;
 
+        ddata = kzalloc(sizeof(struct gpio_keys_drvdata) +
+                        pdata->nbuttons * sizeof(struct gpio_button_data),
+                        GFP_KERNEL);
         input = input_allocate_device();
-        if (!input)
-                return -ENOMEM;
-
-        platform_set_drvdata(pdev, input);
+        if (!ddata || !input) {
+                error = -ENOMEM;
+                goto fail1;
+        }
 
-        input->evbit[0] = BIT_MASK(EV_KEY);
+        platform_set_drvdata(pdev, ddata);
 
         input->name = pdev->name;
         input->phys = "gpio-keys/input0";
@@ -74,16 +109,23 @@ static int __devinit gpio_keys_probe(struct platform_device *pdev)
         input->id.product = 0x0001;
         input->id.version = 0x0100;
 
+        ddata->input = input;
+
         for (i = 0; i < pdata->nbuttons; i++) {
                 struct gpio_keys_button *button = &pdata->buttons[i];
+                struct gpio_button_data *bdata = &ddata->data[i];
                 int irq;
                 unsigned int type = button->type ?: EV_KEY;
 
+                bdata->input = input;
+                setup_timer(&bdata->timer,
+                            gpio_check_button, (unsigned long)bdata);
+
                 error = gpio_request(button->gpio, button->desc ?: "gpio_keys");
                 if (error < 0) {
                         pr_err("gpio-keys: failed to request GPIO %d,"
                                 " error %d\n", button->gpio, error);
-                        goto fail;
+                        goto fail2;
                 }
 
                 error = gpio_direction_input(button->gpio);
@@ -92,7 +134,7 @@ static int __devinit gpio_keys_probe(struct platform_device *pdev)
                                 " direction for GPIO %d, error %d\n",
                                 button->gpio, error);
                         gpio_free(button->gpio);
-                        goto fail;
+                        goto fail2;
                 }
 
                 irq = gpio_to_irq(button->gpio);
@@ -102,7 +144,7 @@ static int __devinit gpio_keys_probe(struct platform_device *pdev)
                                 " for GPIO %d, error %d\n",
                                 button->gpio, error);
                         gpio_free(button->gpio);
-                        goto fail;
+                        goto fail2;
                 }
 
                 error = request_irq(irq, gpio_keys_isr,
@@ -114,7 +156,7 @@ static int __devinit gpio_keys_probe(struct platform_device *pdev)
                         pr_err("gpio-keys: Unable to claim irq %d; error %d\n",
                                 irq, error);
                         gpio_free(button->gpio);
-                        goto fail;
+                        goto fail2;
                 }
 
                 if (button->wakeup)
@@ -127,21 +169,25 @@ static int __devinit gpio_keys_probe(struct platform_device *pdev)
         if (error) {
                 pr_err("gpio-keys: Unable to register input device, "
                         "error: %d\n", error);
-                goto fail;
+                goto fail2;
         }
 
         device_init_wakeup(&pdev->dev, wakeup);
 
         return 0;
 
- fail:
+ fail2:
         while (--i >= 0) {
                 free_irq(gpio_to_irq(pdata->buttons[i].gpio), pdev);
+                if (pdata->buttons[i].debounce_interval)
+                        del_timer_sync(&ddata->data[i].timer);
                 gpio_free(pdata->buttons[i].gpio);
         }
 
         platform_set_drvdata(pdev, NULL);
+ fail1:
         input_free_device(input);
+        kfree(ddata);
 
         return error;
 }
@@ -149,7 +195,8 @@ static int __devinit gpio_keys_probe(struct platform_device *pdev)
 static int __devexit gpio_keys_remove(struct platform_device *pdev)
 {
         struct gpio_keys_platform_data *pdata = pdev->dev.platform_data;
-        struct input_dev *input = platform_get_drvdata(pdev);
+        struct gpio_keys_drvdata *ddata = platform_get_drvdata(pdev);
+        struct input_dev *input = ddata->input;
         int i;
 
         device_init_wakeup(&pdev->dev, 0);
@@ -157,6 +204,8 @@ static int __devexit gpio_keys_remove(struct platform_device *pdev)
         for (i = 0; i < pdata->nbuttons; i++) {
                 int irq = gpio_to_irq(pdata->buttons[i].gpio);
                 free_irq(irq, pdev);
+                if (pdata->buttons[i].debounce_interval)
+                        del_timer_sync(&ddata->data[i].timer);
                 gpio_free(pdata->buttons[i].gpio);
         }
 
diff --git a/drivers/input/keyboard/lkkbd.c b/drivers/input/keyboard/lkkbd.c
index 32e2c2605d95..4730ef35c732 100644
--- a/drivers/input/keyboard/lkkbd.c
+++ b/drivers/input/keyboard/lkkbd.c
@@ -538,11 +538,11 @@ lkkbd_event (struct input_dev *dev, unsigned int type, unsigned int code,
                         switch (code) {
                                 case SND_CLICK:
                                         if (value == 0) {
-                                                DBG ("%s: Deactivating key clicks\n", __FUNCTION__);
+                                                DBG ("%s: Deactivating key clicks\n", __func__);
                                                 lk->serio->write (lk->serio, LK_CMD_DISABLE_KEYCLICK);
                                                 lk->serio->write (lk->serio, LK_CMD_DISABLE_CTRCLICK);
                                         } else {
-                                                DBG ("%s: Activating key clicks\n", __FUNCTION__);
+                                                DBG ("%s: Activating key clicks\n", __func__);
                                                 lk->serio->write (lk->serio, LK_CMD_ENABLE_KEYCLICK);
                                                 lk->serio->write (lk->serio, volume_to_hw (lk->keyclick_volume));
                                                 lk->serio->write (lk->serio, LK_CMD_ENABLE_CTRCLICK);
@@ -560,7 +560,7 @@ lkkbd_event (struct input_dev *dev, unsigned int type, unsigned int code,
 
                 default:
                         printk (KERN_ERR "%s (): Got unknown type %d, code %d, value %d\n",
-                                        __FUNCTION__, type, code, value);
+                                        __func__, type, code, value);
         }
 
         return -1;
diff --git a/drivers/input/keyboard/pxa27x_keypad.c b/drivers/input/keyboard/pxa27x_keypad.c
index 45767e73f071..6f1516f50750 100644
--- a/drivers/input/keyboard/pxa27x_keypad.c
+++ b/drivers/input/keyboard/pxa27x_keypad.c
@@ -105,6 +105,8 @@ struct pxa27x_keypad {
         struct input_dev *input_dev;
         void __iomem *mmio_base;
 
+        int irq;
+
         /* matrix key code map */
         unsigned int matrix_keycodes[MAX_MATRIX_KEY_NUM];
 
@@ -392,6 +394,10 @@ static int pxa27x_keypad_suspend(struct platform_device *pdev, pm_message_t stat
         struct pxa27x_keypad *keypad = platform_get_drvdata(pdev);
 
         clk_disable(keypad->clk);
+
+        if (device_may_wakeup(&pdev->dev))
+                enable_irq_wake(keypad->irq);
+
         return 0;
 }
 
@@ -400,6 +406,9 @@ static int pxa27x_keypad_resume(struct platform_device *pdev)
         struct pxa27x_keypad *keypad = platform_get_drvdata(pdev);
         struct input_dev *input_dev = keypad->input_dev;
 
+        if (device_may_wakeup(&pdev->dev))
+                disable_irq_wake(keypad->irq);
+
         mutex_lock(&input_dev->mutex);
 
         if (input_dev->users) {
@@ -509,6 +518,8 @@ static int __devinit pxa27x_keypad_probe(struct platform_device *pdev)
                 goto failed_free_dev;
         }
 
+        keypad->irq = irq;
+
         /* Register the input device */
         error = input_register_device(input_dev);
         if (error) {
@@ -516,6 +527,8 @@ static int __devinit pxa27x_keypad_probe(struct platform_device *pdev)
                 goto failed_free_irq;
         }
 
+        device_init_wakeup(&pdev->dev, 1);
+
         return 0;
 
 failed_free_irq:
@@ -539,7 +552,7 @@ static int __devexit pxa27x_keypad_remove(struct platform_device *pdev)
         struct pxa27x_keypad *keypad = platform_get_drvdata(pdev);
         struct resource *res;
 
-        free_irq(platform_get_irq(pdev, 0), pdev);
+        free_irq(keypad->irq, pdev);
 
         clk_disable(keypad->clk);
         clk_put(keypad->clk);
diff --git a/drivers/input/keyboard/sunkbd.c b/drivers/input/keyboard/sunkbd.c
index be0f5d19d023..9fce6d1e29b2 100644
--- a/drivers/input/keyboard/sunkbd.c
+++ b/drivers/input/keyboard/sunkbd.c
@@ -1,6 +1,4 @@
 /*
- * $Id: sunkbd.c,v 1.14 2001/09/25 10:12:07 vojtech Exp $
- *
  *  Copyright (c) 1999-2001 Vojtech Pavlik
  */
 
diff --git a/drivers/input/keyboard/xtkbd.c b/drivers/input/keyboard/xtkbd.c
index 152a2c070508..37b01d777a4a 100644
--- a/drivers/input/keyboard/xtkbd.c
+++ b/drivers/input/keyboard/xtkbd.c
@@ -1,6 +1,4 @@
 /*
- * $Id: xtkbd.c,v 1.11 2001/09/25 10:12:07 vojtech Exp $
- *
  *  Copyright (c) 1999-2001 Vojtech Pavlik
  */