3 files changed, 21 insertions, 14 deletions

diff --git a/drivers/iio/frequency/adf4350.c b/drivers/iio/frequency/adf4350.c
index 59fbb3ae40e7..e35bb8f6fe75 100644
--- a/drivers/iio/frequency/adf4350.c
+++ b/drivers/iio/frequency/adf4350.c
@@ -129,7 +129,7 @@ static int adf4350_set_freq(struct adf4350_state *st, unsigned long long freq)
 {
         struct adf4350_platform_data *pdata = st->pdata;
         u64 tmp;
-        u32 div_gcd, prescaler;
+        u32 div_gcd, prescaler, chspc;
         u16 mdiv, r_cnt = 0;
         u8 band_sel_div;
 
@@ -158,14 +158,20 @@ static int adf4350_set_freq(struct adf4350_state *st, unsigned long long freq)
         if (pdata->ref_div_factor)
                 r_cnt = pdata->ref_div_factor - 1;
 
-        do  {
-                r_cnt = adf4350_tune_r_cnt(st, r_cnt);
+        chspc = st->chspc;
 
-                st->r1_mod = st->fpfd / st->chspc;
-                while (st->r1_mod > ADF4350_MAX_MODULUS) {
-                        r_cnt = adf4350_tune_r_cnt(st, r_cnt);
-                        st->r1_mod = st->fpfd / st->chspc;
-                }
+        do  {
+                do {
+                        do {
+                                r_cnt = adf4350_tune_r_cnt(st, r_cnt);
+                                st->r1_mod = st->fpfd / chspc;
+                                if (r_cnt > ADF4350_MAX_R_CNT) {
+                                        /* try higher spacing values */
+                                        chspc++;
+                                        r_cnt = 0;
+                                }
+                        } while ((st->r1_mod > ADF4350_MAX_MODULUS) && r_cnt);
+                } while (r_cnt == 0);
 
                 tmp = freq * (u64)st->r1_mod + (st->fpfd > 1);
                 do_div(tmp, st->fpfd); /* Div round closest (n + d/2)/d */
@@ -194,7 +200,7 @@ static int adf4350_set_freq(struct adf4350_state *st, unsigned long long freq)
         st->regs[ADF4350_REG0] = ADF4350_REG0_INT(st->r0_int) |
                                  ADF4350_REG0_FRACT(st->r0_fract);
 
-        st->regs[ADF4350_REG1] = ADF4350_REG1_PHASE(0) |
+        st->regs[ADF4350_REG1] = ADF4350_REG1_PHASE(1) |
                                  ADF4350_REG1_MOD(st->r1_mod) |
                                  prescaler;
 
diff --git a/drivers/iio/light/adjd_s311.c b/drivers/iio/light/adjd_s311.c
index 1cbb449b319a..9a99f43094f0 100644
--- a/drivers/iio/light/adjd_s311.c
+++ b/drivers/iio/light/adjd_s311.c
@@ -271,9 +271,10 @@ static int adjd_s311_update_scan_mode(struct iio_dev *indio_dev,
         const unsigned long *scan_mask)
 {
         struct adjd_s311_data *data = iio_priv(indio_dev);
-        data->buffer = krealloc(data->buffer, indio_dev->scan_bytes,
-                                GFP_KERNEL);
-        if (!data->buffer)
+
+        kfree(data->buffer);
+        data->buffer = kmalloc(indio_dev->scan_bytes, GFP_KERNEL);
+        if (data->buffer == NULL)
                 return -ENOMEM;
 
         return 0;
diff --git a/drivers/iio/light/lm3533-als.c b/drivers/iio/light/lm3533-als.c
index c3e7bac13123..e45712a921ce 100644
--- a/drivers/iio/light/lm3533-als.c
+++ b/drivers/iio/light/lm3533-als.c
@@ -404,7 +404,7 @@ out:
         return ret;
 }
 
-static int show_thresh_either_en(struct device *dev,
+static ssize_t show_thresh_either_en(struct device *dev,
                                         struct device_attribute *attr,
                                         char *buf)
 {
@@ -424,7 +424,7 @@ static int show_thresh_either_en(struct device *dev,
         return scnprintf(buf, PAGE_SIZE, "%u\n", enable);
 }
 
-static int store_thresh_either_en(struct device *dev,
+static ssize_t store_thresh_either_en(struct device *dev,
                                         struct device_attribute *attr,
                                         const char *buf, size_t len)
 {