1 files changed, 27 insertions, 33 deletions

diff --git a/drivers/iio/industrialio-buffer.c b/drivers/iio/industrialio-buffer.c
index 2710f7245c3b..e9f389b9da69 100644
--- a/drivers/iio/industrialio-buffer.c
+++ b/drivers/iio/industrialio-buffer.c
@@ -31,16 +31,9 @@ static const char * const iio_endian_prefix[] = {
         [IIO_LE] = "le",
 };
 
-static bool iio_buffer_is_active(struct iio_dev *indio_dev,
-                                 struct iio_buffer *buf)
+static bool iio_buffer_is_active(struct iio_buffer *buf)
 {
-        struct list_head *p;
-
-        list_for_each(p, &indio_dev->buffer_list)
-                if (p == &buf->buffer_list)
-                        return true;
-
-        return false;
+        return !list_empty(&buf->buffer_list);
 }
 
 /**
@@ -79,6 +72,7 @@ unsigned int iio_buffer_poll(struct file *filp,
 void iio_buffer_init(struct iio_buffer *buffer)
 {
         INIT_LIST_HEAD(&buffer->demux_list);
+        INIT_LIST_HEAD(&buffer->buffer_list);
         init_waitqueue_head(&buffer->pollq);
 }
 EXPORT_SYMBOL(iio_buffer_init);
@@ -146,7 +140,7 @@ static ssize_t iio_scan_el_store(struct device *dev,
         if (ret < 0)
                 return ret;
         mutex_lock(&indio_dev->mlock);
-        if (iio_buffer_is_active(indio_dev, indio_dev->buffer)) {
+        if (iio_buffer_is_active(indio_dev->buffer)) {
                 ret = -EBUSY;
                 goto error_ret;
         }
@@ -192,7 +186,7 @@ static ssize_t iio_scan_el_ts_store(struct device *dev,
                 return ret;
 
         mutex_lock(&indio_dev->mlock);
-        if (iio_buffer_is_active(indio_dev, indio_dev->buffer)) {
+        if (iio_buffer_is_active(indio_dev->buffer)) {
                 ret = -EBUSY;
                 goto error_ret;
         }
@@ -214,7 +208,7 @@ static int iio_buffer_add_channel_sysfs(struct iio_dev *indio_dev,
                                      &iio_show_scan_index,
                                      NULL,
                                      0,
-                                     0,
+                                     IIO_SEPARATE,
                                      &indio_dev->dev,
                                      &buffer->scan_el_dev_attr_list);
         if (ret)
@@ -249,6 +243,8 @@ static int iio_buffer_add_channel_sysfs(struct iio_dev *indio_dev,
                                              0,
                                              &indio_dev->dev,
                                              &buffer->scan_el_dev_attr_list);
+        if (ret)
+                goto error_ret;
         attrcount++;
         ret = attrcount;
 error_ret:
@@ -396,7 +392,7 @@ ssize_t iio_buffer_write_length(struct device *dev,
                         return len;
 
         mutex_lock(&indio_dev->mlock);
-        if (iio_buffer_is_active(indio_dev, indio_dev->buffer)) {
+        if (iio_buffer_is_active(indio_dev->buffer)) {
                 ret = -EBUSY;
         } else {
                 if (buffer->access->set_length)
@@ -414,13 +410,11 @@ ssize_t iio_buffer_show_enable(struct device *dev,
                                char *buf)
 {
         struct iio_dev *indio_dev = dev_to_iio_dev(dev);
-        return sprintf(buf, "%d\n",
-                       iio_buffer_is_active(indio_dev,
-                                            indio_dev->buffer));
+        return sprintf(buf, "%d\n", iio_buffer_is_active(indio_dev->buffer));
 }
 EXPORT_SYMBOL(iio_buffer_show_enable);
 
-/* note NULL used as error indicator as it doesn't make sense. */
+/* Note NULL used as error indicator as it doesn't make sense. */
 static const unsigned long *iio_scan_mask_match(const unsigned long *av_masks,
                                           unsigned int masklength,
                                           const unsigned long *mask)
@@ -435,8 +429,8 @@ static const unsigned long *iio_scan_mask_match(const unsigned long *av_masks,
         return NULL;
 }
 
-static int iio_compute_scan_bytes(struct iio_dev *indio_dev, const long *mask,
-                                  bool timestamp)
+static int iio_compute_scan_bytes(struct iio_dev *indio_dev,
+                                const unsigned long *mask, bool timestamp)
 {
         const struct iio_chan_spec *ch;
         unsigned bytes = 0;
@@ -509,7 +503,7 @@ int iio_update_buffers(struct iio_dev *indio_dev,
                 indio_dev->active_scan_mask = NULL;
 
         if (remove_buffer)
-                list_del(&remove_buffer->buffer_list);
+                list_del_init(&remove_buffer->buffer_list);
         if (insert_buffer)
                 list_add(&insert_buffer->buffer_list, &indio_dev->buffer_list);
 
@@ -521,7 +515,7 @@ int iio_update_buffers(struct iio_dev *indio_dev,
                 return 0;
         }
 
-        /* What scan mask do we actually have ?*/
+        /* What scan mask do we actually have? */
         compound_mask = kcalloc(BITS_TO_LONGS(indio_dev->masklength),
                                 sizeof(long), GFP_KERNEL);
         if (compound_mask == NULL) {
@@ -546,7 +540,7 @@ int iio_update_buffers(struct iio_dev *indio_dev,
                          * Roll back.
                          * Note can only occur when adding a buffer.
                          */
-                        list_del(&insert_buffer->buffer_list);
+                        list_del_init(&insert_buffer->buffer_list);
                         if (old_mask) {
                                 indio_dev->active_scan_mask = old_mask;
                                 success = -EINVAL;
@@ -594,7 +588,7 @@ int iio_update_buffers(struct iio_dev *indio_dev,
                         goto error_run_postdisable;
                 }
         }
-        /* Definitely possible for devices to support both of these.*/
+        /* Definitely possible for devices to support both of these. */
         if (indio_dev->modes & INDIO_BUFFER_TRIGGERED) {
                 if (!indio_dev->trig) {
                         printk(KERN_INFO "Buffer not started: no trigger\n");
@@ -605,7 +599,7 @@ int iio_update_buffers(struct iio_dev *indio_dev,
                 indio_dev->currentmode = INDIO_BUFFER_TRIGGERED;
         } else if (indio_dev->modes & INDIO_BUFFER_HARDWARE) {
                 indio_dev->currentmode = INDIO_BUFFER_HARDWARE;
-        } else { /* should never be reached */
+        } else { /* Should never be reached */
                 ret = -EINVAL;
                 goto error_run_postdisable;
         }
@@ -637,7 +631,7 @@ error_run_postdisable:
 error_remove_inserted:
 
         if (insert_buffer)
-                list_del(&insert_buffer->buffer_list);
+                list_del_init(&insert_buffer->buffer_list);
         indio_dev->active_scan_mask = old_mask;
         kfree(compound_mask);
 error_ret:
@@ -654,7 +648,6 @@ ssize_t iio_buffer_store_enable(struct device *dev,
         int ret;
         bool requested_state;
         struct iio_dev *indio_dev = dev_to_iio_dev(dev);
-        struct iio_buffer *pbuf = indio_dev->buffer;
         bool inlist;
 
         ret = strtobool(buf, &requested_state);
@@ -664,7 +657,7 @@ ssize_t iio_buffer_store_enable(struct device *dev,
         mutex_lock(&indio_dev->mlock);
 
         /* Find out if it is in the list */
-        inlist = iio_buffer_is_active(indio_dev, pbuf);
+        inlist = iio_buffer_is_active(indio_dev->buffer);
         /* Already in desired state */
         if (inlist == requested_state)
                 goto done;
@@ -729,6 +722,7 @@ static bool iio_validate_scan_mask(struct iio_dev *indio_dev,
 
 /**
  * iio_scan_mask_set() - set particular bit in the scan mask
+ * @indio_dev: the iio device
  * @buffer: the buffer whose scan mask we are interested in
  * @bit: the bit to be set.
  *
@@ -749,7 +743,7 @@ int iio_scan_mask_set(struct iio_dev *indio_dev,
         if (trialmask == NULL)
                 return -ENOMEM;
         if (!indio_dev->masklength) {
-                WARN_ON("trying to set scanmask prior to registering buffer\n");
+                WARN_ON("Trying to set scanmask prior to registering buffer\n");
                 goto err_invalid_mask;
         }
         bitmap_copy(trialmask, buffer->scan_mask, indio_dev->masklength);
@@ -804,8 +798,8 @@ struct iio_demux_table {
         struct list_head l;
 };
 
-static unsigned char *iio_demux(struct iio_buffer *buffer,
-                                 unsigned char *datain)
+static const void *iio_demux(struct iio_buffer *buffer,
+                                 const void *datain)
 {
         struct iio_demux_table *t;
 
@@ -818,9 +812,9 @@ static unsigned char *iio_demux(struct iio_buffer *buffer,
         return buffer->demux_bounce;
 }
 
-static int iio_push_to_buffer(struct iio_buffer *buffer, unsigned char *data)
+static int iio_push_to_buffer(struct iio_buffer *buffer, const void *data)
 {
-        unsigned char *dataout = iio_demux(buffer, data);
+        const void *dataout = iio_demux(buffer, data);
 
         return buffer->access->store_to(buffer, dataout);
 }
@@ -835,7 +829,7 @@ static void iio_buffer_demux_free(struct iio_buffer *buffer)
 }
 
 
-int iio_push_to_buffers(struct iio_dev *indio_dev, unsigned char *data)
+int iio_push_to_buffers(struct iio_dev *indio_dev, const void *data)
 {
         int ret;
         struct iio_buffer *buf;