diff options
Diffstat (limited to 'drivers/ieee1394')
-rw-r--r-- | drivers/ieee1394/dma.c | 2 | ||||
-rw-r--r-- | drivers/ieee1394/eth1394.c | 19 | ||||
-rw-r--r-- | drivers/ieee1394/raw1394.c | 1 | ||||
-rw-r--r-- | drivers/ieee1394/video1394.c | 1 |
4 files changed, 9 insertions, 14 deletions
diff --git a/drivers/ieee1394/dma.c b/drivers/ieee1394/dma.c index 1aba8c13fe8f..8e7e3344c4b3 100644 --- a/drivers/ieee1394/dma.c +++ b/drivers/ieee1394/dma.c | |||
@@ -247,7 +247,7 @@ static int dma_region_pagefault(struct vm_area_struct *vma, | |||
247 | return 0; | 247 | return 0; |
248 | } | 248 | } |
249 | 249 | ||
250 | static struct vm_operations_struct dma_region_vm_ops = { | 250 | static const struct vm_operations_struct dma_region_vm_ops = { |
251 | .fault = dma_region_pagefault, | 251 | .fault = dma_region_pagefault, |
252 | }; | 252 | }; |
253 | 253 | ||
diff --git a/drivers/ieee1394/eth1394.c b/drivers/ieee1394/eth1394.c index f5c586c2bba6..a4e9dcb6d4a9 100644 --- a/drivers/ieee1394/eth1394.c +++ b/drivers/ieee1394/eth1394.c | |||
@@ -169,10 +169,11 @@ static int ether1394_header_cache(const struct neighbour *neigh, | |||
169 | static void ether1394_header_cache_update(struct hh_cache *hh, | 169 | static void ether1394_header_cache_update(struct hh_cache *hh, |
170 | const struct net_device *dev, | 170 | const struct net_device *dev, |
171 | const unsigned char *haddr); | 171 | const unsigned char *haddr); |
172 | static int ether1394_tx(struct sk_buff *skb, struct net_device *dev); | 172 | static netdev_tx_t ether1394_tx(struct sk_buff *skb, |
173 | struct net_device *dev); | ||
173 | static void ether1394_iso(struct hpsb_iso *iso); | 174 | static void ether1394_iso(struct hpsb_iso *iso); |
174 | 175 | ||
175 | static struct ethtool_ops ethtool_ops; | 176 | static const struct ethtool_ops ethtool_ops; |
176 | 177 | ||
177 | static int ether1394_write(struct hpsb_host *host, int srcid, int destid, | 178 | static int ether1394_write(struct hpsb_host *host, int srcid, int destid, |
178 | quadlet_t *data, u64 addr, size_t len, u16 flags); | 179 | quadlet_t *data, u64 addr, size_t len, u16 flags); |
@@ -1300,7 +1301,6 @@ static void ether1394_iso(struct hpsb_iso *iso) | |||
1300 | 1301 | ||
1301 | hpsb_iso_recv_release_packets(iso, i); | 1302 | hpsb_iso_recv_release_packets(iso, i); |
1302 | 1303 | ||
1303 | dev->last_rx = jiffies; | ||
1304 | } | 1304 | } |
1305 | 1305 | ||
1306 | /****************************************** | 1306 | /****************************************** |
@@ -1555,7 +1555,8 @@ static void ether1394_complete_cb(void *__ptask) | |||
1555 | } | 1555 | } |
1556 | 1556 | ||
1557 | /* Transmit a packet (called by kernel) */ | 1557 | /* Transmit a packet (called by kernel) */ |
1558 | static int ether1394_tx(struct sk_buff *skb, struct net_device *dev) | 1558 | static netdev_tx_t ether1394_tx(struct sk_buff *skb, |
1559 | struct net_device *dev) | ||
1559 | { | 1560 | { |
1560 | struct eth1394hdr hdr_buf; | 1561 | struct eth1394hdr hdr_buf; |
1561 | struct eth1394_priv *priv = netdev_priv(dev); | 1562 | struct eth1394_priv *priv = netdev_priv(dev); |
@@ -1694,14 +1695,6 @@ fail: | |||
1694 | dev->stats.tx_errors++; | 1695 | dev->stats.tx_errors++; |
1695 | spin_unlock_irqrestore(&priv->lock, flags); | 1696 | spin_unlock_irqrestore(&priv->lock, flags); |
1696 | 1697 | ||
1697 | /* | ||
1698 | * FIXME: According to a patch from 2003-02-26, "returning non-zero | ||
1699 | * causes serious problems" here, allegedly. Before that patch, | ||
1700 | * -ERRNO was returned which is not appropriate under Linux 2.6. | ||
1701 | * Perhaps more needs to be done? Stop the queue in serious | ||
1702 | * conditions and restart it elsewhere? | ||
1703 | */ | ||
1704 | /* return NETDEV_TX_BUSY; */ | ||
1705 | return NETDEV_TX_OK; | 1698 | return NETDEV_TX_OK; |
1706 | } | 1699 | } |
1707 | 1700 | ||
@@ -1712,7 +1705,7 @@ static void ether1394_get_drvinfo(struct net_device *dev, | |||
1712 | strcpy(info->bus_info, "ieee1394"); /* FIXME provide more detail? */ | 1705 | strcpy(info->bus_info, "ieee1394"); /* FIXME provide more detail? */ |
1713 | } | 1706 | } |
1714 | 1707 | ||
1715 | static struct ethtool_ops ethtool_ops = { | 1708 | static const struct ethtool_ops ethtool_ops = { |
1716 | .get_drvinfo = ether1394_get_drvinfo | 1709 | .get_drvinfo = ether1394_get_drvinfo |
1717 | }; | 1710 | }; |
1718 | 1711 | ||
diff --git a/drivers/ieee1394/raw1394.c b/drivers/ieee1394/raw1394.c index 0bc3d78ce7b1..8aa56ac07e29 100644 --- a/drivers/ieee1394/raw1394.c +++ b/drivers/ieee1394/raw1394.c | |||
@@ -29,6 +29,7 @@ | |||
29 | 29 | ||
30 | #include <linux/kernel.h> | 30 | #include <linux/kernel.h> |
31 | #include <linux/list.h> | 31 | #include <linux/list.h> |
32 | #include <linux/sched.h> | ||
32 | #include <linux/string.h> | 33 | #include <linux/string.h> |
33 | #include <linux/slab.h> | 34 | #include <linux/slab.h> |
34 | #include <linux/fs.h> | 35 | #include <linux/fs.h> |
diff --git a/drivers/ieee1394/video1394.c b/drivers/ieee1394/video1394.c index d287ba79821d..949064a05675 100644 --- a/drivers/ieee1394/video1394.c +++ b/drivers/ieee1394/video1394.c | |||
@@ -30,6 +30,7 @@ | |||
30 | */ | 30 | */ |
31 | #include <linux/kernel.h> | 31 | #include <linux/kernel.h> |
32 | #include <linux/list.h> | 32 | #include <linux/list.h> |
33 | #include <linux/sched.h> | ||
33 | #include <linux/slab.h> | 34 | #include <linux/slab.h> |
34 | #include <linux/interrupt.h> | 35 | #include <linux/interrupt.h> |
35 | #include <linux/wait.h> | 36 | #include <linux/wait.h> |