diff options
Diffstat (limited to 'drivers/ide')
-rw-r--r-- | drivers/ide/ide-atapi.c | 5 | ||||
-rw-r--r-- | drivers/ide/ide-cd.c | 96 |
2 files changed, 6 insertions, 95 deletions
diff --git a/drivers/ide/ide-atapi.c b/drivers/ide/ide-atapi.c index d6a50d67b7db..e96c01260598 100644 --- a/drivers/ide/ide-atapi.c +++ b/drivers/ide/ide-atapi.c | |||
@@ -549,7 +549,10 @@ static ide_startstop_t ide_transfer_pc(ide_drive_t *drive) | |||
549 | } | 549 | } |
550 | 550 | ||
551 | /* Set the interrupt routine */ | 551 | /* Set the interrupt routine */ |
552 | ide_set_handler(drive, ide_pc_intr, timeout, expiry); | 552 | ide_set_handler(drive, |
553 | (dev_is_idecd(drive) ? drive->irq_handler | ||
554 | : ide_pc_intr), | ||
555 | timeout, expiry); | ||
553 | 556 | ||
554 | /* Begin DMA, if necessary */ | 557 | /* Begin DMA, if necessary */ |
555 | if (dev_is_idecd(drive)) { | 558 | if (dev_is_idecd(drive)) { |
diff --git a/drivers/ide/ide-cd.c b/drivers/ide/ide-cd.c index 2cb301dccd21..cae69372cf45 100644 --- a/drivers/ide/ide-cd.c +++ b/drivers/ide/ide-cd.c | |||
@@ -510,99 +510,6 @@ end_request: | |||
510 | return 1; | 510 | return 1; |
511 | } | 511 | } |
512 | 512 | ||
513 | static ide_startstop_t cdrom_transfer_packet_command(ide_drive_t *); | ||
514 | static ide_startstop_t cdrom_newpc_intr(ide_drive_t *); | ||
515 | |||
516 | /* | ||
517 | * Set up the device registers for transferring a packet command on DEV, | ||
518 | * expecting to later transfer XFERLEN bytes. HANDLER is the routine | ||
519 | * which actually transfers the command to the drive. If this is a | ||
520 | * drq_interrupt device, this routine will arrange for HANDLER to be | ||
521 | * called when the interrupt from the drive arrives. Otherwise, HANDLER | ||
522 | * will be called immediately after the drive is prepared for the transfer. | ||
523 | */ | ||
524 | static ide_startstop_t cdrom_start_packet_command(ide_drive_t *drive) | ||
525 | { | ||
526 | ide_hwif_t *hwif = drive->hwif; | ||
527 | struct request *rq = hwif->rq; | ||
528 | int xferlen; | ||
529 | |||
530 | xferlen = ide_cd_get_xferlen(rq); | ||
531 | |||
532 | ide_debug_log(IDE_DBG_PC, "Call %s, xferlen: %d\n", __func__, xferlen); | ||
533 | |||
534 | /* FIXME: for Virtual DMA we must check harder */ | ||
535 | if (drive->dma) | ||
536 | drive->dma = !hwif->dma_ops->dma_setup(drive); | ||
537 | |||
538 | /* set up the controller registers */ | ||
539 | ide_pktcmd_tf_load(drive, IDE_TFLAG_OUT_NSECT | IDE_TFLAG_OUT_LBAL, | ||
540 | xferlen, drive->dma); | ||
541 | |||
542 | if (drive->atapi_flags & IDE_AFLAG_DRQ_INTERRUPT) { | ||
543 | /* waiting for CDB interrupt, not DMA yet. */ | ||
544 | if (drive->dma) | ||
545 | drive->waiting_for_dma = 0; | ||
546 | |||
547 | /* packet command */ | ||
548 | ide_execute_command(drive, ATA_CMD_PACKET, | ||
549 | cdrom_transfer_packet_command, | ||
550 | ATAPI_WAIT_PC, ide_cd_expiry); | ||
551 | return ide_started; | ||
552 | } else { | ||
553 | ide_execute_pkt_cmd(drive); | ||
554 | |||
555 | return cdrom_transfer_packet_command(drive); | ||
556 | } | ||
557 | } | ||
558 | |||
559 | /* | ||
560 | * Send a packet command to DRIVE described by CMD_BUF and CMD_LEN. The device | ||
561 | * registers must have already been prepared by cdrom_start_packet_command. | ||
562 | * HANDLER is the interrupt handler to call when the command completes or | ||
563 | * there's data ready. | ||
564 | */ | ||
565 | #define ATAPI_MIN_CDB_BYTES 12 | ||
566 | static ide_startstop_t cdrom_transfer_packet_command(ide_drive_t *drive) | ||
567 | { | ||
568 | ide_hwif_t *hwif = drive->hwif; | ||
569 | struct request *rq = hwif->rq; | ||
570 | int cmd_len; | ||
571 | ide_startstop_t startstop; | ||
572 | |||
573 | ide_debug_log(IDE_DBG_PC, "Call %s\n", __func__); | ||
574 | |||
575 | /* we must wait for DRQ to get set */ | ||
576 | if (ide_wait_stat(&startstop, drive, ATA_DRQ, ATA_BUSY, WAIT_READY)) { | ||
577 | printk(KERN_ERR "%s: timeout while waiting for DRQ to assert\n", | ||
578 | drive->name); | ||
579 | return startstop; | ||
580 | } | ||
581 | |||
582 | if (drive->atapi_flags & IDE_AFLAG_DRQ_INTERRUPT) { | ||
583 | /* ok, next interrupt will be DMA interrupt */ | ||
584 | if (drive->dma) | ||
585 | drive->waiting_for_dma = 1; | ||
586 | } | ||
587 | |||
588 | /* arm the interrupt handler */ | ||
589 | ide_set_handler(drive, cdrom_newpc_intr, rq->timeout, ide_cd_expiry); | ||
590 | |||
591 | /* ATAPI commands get padded out to 12 bytes minimum */ | ||
592 | cmd_len = COMMAND_SIZE(rq->cmd[0]); | ||
593 | if (cmd_len < ATAPI_MIN_CDB_BYTES) | ||
594 | cmd_len = ATAPI_MIN_CDB_BYTES; | ||
595 | |||
596 | /* start the DMA if need be */ | ||
597 | if (drive->dma) | ||
598 | hwif->dma_ops->dma_start(drive); | ||
599 | |||
600 | /* send the command to the device */ | ||
601 | hwif->tp_ops->output_data(drive, NULL, rq->cmd, cmd_len); | ||
602 | |||
603 | return ide_started; | ||
604 | } | ||
605 | |||
606 | /* | 513 | /* |
607 | * Check the contents of the interrupt reason register from the cdrom | 514 | * Check the contents of the interrupt reason register from the cdrom |
608 | * and attempt to recover if there are problems. Returns 0 if everything's | 515 | * and attempt to recover if there are problems. Returns 0 if everything's |
@@ -1174,7 +1081,7 @@ static ide_startstop_t ide_cd_do_request(ide_drive_t *drive, struct request *rq, | |||
1174 | return ide_stopped; | 1081 | return ide_stopped; |
1175 | } | 1082 | } |
1176 | 1083 | ||
1177 | return cdrom_start_packet_command(drive); | 1084 | return ide_issue_pc(drive); |
1178 | } | 1085 | } |
1179 | 1086 | ||
1180 | /* | 1087 | /* |
@@ -2072,6 +1979,7 @@ static int ide_cd_probe(ide_drive_t *drive) | |||
2072 | } | 1979 | } |
2073 | 1980 | ||
2074 | drive->debug_mask = debug_mask; | 1981 | drive->debug_mask = debug_mask; |
1982 | drive->irq_handler = cdrom_newpc_intr; | ||
2075 | 1983 | ||
2076 | info = kzalloc(sizeof(struct cdrom_info), GFP_KERNEL); | 1984 | info = kzalloc(sizeof(struct cdrom_info), GFP_KERNEL); |
2077 | if (info == NULL) { | 1985 | if (info == NULL) { |