1 files changed, 14 insertions, 57 deletions

diff --git a/drivers/ide/ppc/pmac.c b/drivers/ide/ppc/pmac.c
index c3432da78d52..2e19d6298536 100644
--- a/drivers/ide/ppc/pmac.c
+++ b/drivers/ide/ppc/pmac.c
@@ -430,10 +430,7 @@ pmac_ide_selectproc(ide_drive_t *drive)
         pmac_ide_hwif_t *pmif =
                 (pmac_ide_hwif_t *)dev_get_drvdata(hwif->gendev.parent);
 
-        if (pmif == NULL)
-                return;
-
-        if (drive->select.b.unit & 0x01)
+        if (drive->dn & 1)
                 writel(pmif->timings[1], PMAC_IDE_REG(IDE_TIMING_CONFIG));
         else
                 writel(pmif->timings[0], PMAC_IDE_REG(IDE_TIMING_CONFIG));
@@ -452,10 +449,7 @@ pmac_ide_kauai_selectproc(ide_drive_t *drive)
         pmac_ide_hwif_t *pmif =
                 (pmac_ide_hwif_t *)dev_get_drvdata(hwif->gendev.parent);
 
-        if (pmif == NULL)
-                return;
-
-        if (drive->select.b.unit & 0x01) {
+        if (drive->dn & 1) {
                 writel(pmif->timings[1], PMAC_IDE_REG(IDE_KAUAI_PIO_CONFIG));
                 writel(pmif->timings[3], PMAC_IDE_REG(IDE_KAUAI_ULTRA_CONFIG));
         } else {
@@ -475,9 +469,6 @@ pmac_ide_do_update_timings(ide_drive_t *drive)
         pmac_ide_hwif_t *pmif =
                 (pmac_ide_hwif_t *)dev_get_drvdata(hwif->gendev.parent);
 
-        if (pmif == NULL)
-                return;
-
         if (pmif->kind == controller_sh_ata6 ||
             pmif->kind == controller_un_ata6 ||
             pmif->kind == controller_k2_ata6)
@@ -524,11 +515,8 @@ pmac_ide_set_pio_mode(ide_drive_t *drive, const u8 pio)
         unsigned accessTime, recTime;
         unsigned int cycle_time;
 
-        if (pmif == NULL)
-                return;
-                
         /* which drive is it ? */
-        timings = &pmif->timings[drive->select.b.unit & 0x01];
+        timings = &pmif->timings[drive->dn & 1];
         t = *timings;
 
         cycle_time = ide_pio_cycle_time(drive, pio);
@@ -805,9 +793,9 @@ static void pmac_ide_set_dma_mode(ide_drive_t *drive, const u8 speed)
         ide_hwif_t *hwif = drive->hwif;
         pmac_ide_hwif_t *pmif =
                 (pmac_ide_hwif_t *)dev_get_drvdata(hwif->gendev.parent);
-        int unit = (drive->select.b.unit & 0x01);
         int ret = 0;
         u32 *timings, *timings2, tl[2];
+        u8 unit = drive->dn & 1;
 
         timings = &pmif->timings[unit];
         timings2 = &pmif->timings[unit+2];
@@ -966,11 +954,11 @@ static void pmac_ide_init_dev(ide_drive_t *drive)
         if (pmif->mediabay) {
 #ifdef CONFIG_PMAC_MEDIABAY
                 if (check_media_bay_by_base(pmif->regbase, MB_CD) == 0) {
-                        drive->noprobe = 0;
+                        drive->dev_flags &= ~IDE_DFLAG_NOPROBE;
                         return;
                 }
 #endif
-                drive->noprobe = 1;
+                drive->dev_flags |= IDE_DFLAG_NOPROBE;
         }
 }
 
@@ -1535,18 +1523,6 @@ use_pio_instead:
         return 0; /* revert to PIO for this request */
 }
 
-/* Teardown mappings after DMA has completed.  */
-static void
-pmac_ide_destroy_dmatable (ide_drive_t *drive)
-{
-        ide_hwif_t *hwif = drive->hwif;
-
-        if (hwif->sg_nents) {
-                ide_destroy_dmatable(drive);
-                hwif->sg_nents = 0;
-        }
-}
-
 /*
  * Prepare a DMA transfer. We build the DMA table, adjust the timings for
  * a read on KeyLargo ATA/66 and mark us as waiting for DMA completion
@@ -1558,12 +1534,7 @@ pmac_ide_dma_setup(ide_drive_t *drive)
         pmac_ide_hwif_t *pmif =
                 (pmac_ide_hwif_t *)dev_get_drvdata(hwif->gendev.parent);
         struct request *rq = HWGROUP(drive)->rq;
-        u8 unit = (drive->select.b.unit & 0x01);
-        u8 ata4;
-
-        if (pmif == NULL)
-                return 1;
-        ata4 = (pmif->kind == controller_kl_ata4);      
+        u8 unit = drive->dn & 1, ata4 = (pmif->kind == controller_kl_ata4);
 
         if (!pmac_ide_build_dmatable(drive, rq)) {
                 ide_map_sg(drive, rq);
@@ -1617,17 +1588,15 @@ pmac_ide_dma_end (ide_drive_t *drive)
         ide_hwif_t *hwif = drive->hwif;
         pmac_ide_hwif_t *pmif =
                 (pmac_ide_hwif_t *)dev_get_drvdata(hwif->gendev.parent);
-        volatile struct dbdma_regs __iomem *dma;
+        volatile struct dbdma_regs __iomem *dma = pmif->dma_regs;
         u32 dstat;
-        
-        if (pmif == NULL)
-                return 0;
-        dma = pmif->dma_regs;
 
         drive->waiting_for_dma = 0;
         dstat = readl(&dma->status);
         writel(((RUN|WAKE|DEAD) << 16), &dma->control);
-        pmac_ide_destroy_dmatable(drive);
+
+        ide_destroy_dmatable(drive);
+
         /* verify good dma status. we don't check for ACTIVE beeing 0. We should...
          * in theory, but with ATAPI decices doing buffer underruns, that would
          * cause us to disable DMA, which isn't what we want
@@ -1647,13 +1616,9 @@ pmac_ide_dma_test_irq (ide_drive_t *drive)
         ide_hwif_t *hwif = drive->hwif;
         pmac_ide_hwif_t *pmif =
                 (pmac_ide_hwif_t *)dev_get_drvdata(hwif->gendev.parent);
-        volatile struct dbdma_regs __iomem *dma;
+        volatile struct dbdma_regs __iomem *dma = pmif->dma_regs;
         unsigned long status, timeout;
 
-        if (pmif == NULL)
-                return 0;
-        dma = pmif->dma_regs;
-
         /* We have to things to deal with here:
          * 
          * - The dbdma won't stop if the command was started
@@ -1672,9 +1637,6 @@ pmac_ide_dma_test_irq (ide_drive_t *drive)
         status = readl(&dma->status);
         if (!(status & ACTIVE))
                 return 1;
-        if (!drive->waiting_for_dma)
-                printk(KERN_WARNING "ide%d, ide_dma_test_irq \
-                        called while not waiting\n", HWIF(drive)->index);
 
         /* If dbdma didn't execute the STOP command yet, the
          * active bit is still set. We consider that we aren't
@@ -1709,14 +1671,9 @@ pmac_ide_dma_lost_irq (ide_drive_t *drive)
         ide_hwif_t *hwif = drive->hwif;
         pmac_ide_hwif_t *pmif =
                 (pmac_ide_hwif_t *)dev_get_drvdata(hwif->gendev.parent);
-        volatile struct dbdma_regs __iomem *dma;
-        unsigned long status;
-
-        if (pmif == NULL)
-                return;
-        dma = pmif->dma_regs;
+        volatile struct dbdma_regs __iomem *dma = pmif->dma_regs;
+        unsigned long status = readl(&dma->status);
 
-        status = readl(&dma->status);
         printk(KERN_ERR "ide-pmac lost interrupt, dma status: %lx\n", status);
 }