2 files changed, 14 insertions, 30 deletions

diff --git a/drivers/ide/pci/alim15x3.c b/drivers/ide/pci/alim15x3.c
index c1922f9cfe80..f2129d5e07f2 100644
--- a/drivers/ide/pci/alim15x3.c
+++ b/drivers/ide/pci/alim15x3.c
@@ -39,6 +39,16 @@
 #include <asm/io.h>
 
 /*
+ * Allow UDMA on M1543C-E chipset for WDC disks that ignore CRC checking
+ * (this is DANGEROUS and could result in data corruption).
+ */
+static int wdc_udma;
+
+module_param(wdc_udma, bool, 0);
+MODULE_PARM_DESC(wdc_udma,
+                 "allow UDMA on M1543C-E chipset for WDC disks (DANGEROUS)");
+
+/*
  *      ALi devices are not plug in. Otherwise these static values would
  *      need to go. They ought to go away anyway
  */
@@ -76,11 +86,6 @@ static void ali_set_pio_mode(ide_drive_t *drive, const u8 pio)
                 a_clc = 0;
         c_time = ide_pio_timings[pio].cycle_time;
 
-#if 0
-        if ((r_clc = ((c_time - s_time - a_time) * bus_speed + 999) / 1000) >= 16)
-                r_clc = 0;
-#endif
-
         if (!(r_clc = (c_time * bus_speed + 999) / 1000 - a_clc - s_clc)) {
                 r_clc = 1;
         } else {
@@ -110,16 +115,6 @@ static void ali_set_pio_mode(ide_drive_t *drive, const u8 pio)
         pci_write_config_byte(dev, port, s_clc);
         pci_write_config_byte(dev, port+drive->select.b.unit+2, (a_clc << 4) | r_clc);
         local_irq_restore(flags);
-
-        /*
-         * setup   active  rec
-         * { 70,   165,    365 },   PIO Mode 0
-         * { 50,   125,    208 },   PIO Mode 1
-         * { 30,   100,    110 },   PIO Mode 2
-         * { 30,   80,     70  },   PIO Mode 3 with IORDY
-         * { 25,   70,     25  },   PIO Mode 4 with IORDY  ns
-         * { 20,   50,     30  }    PIO Mode 5 with IORDY (nonstandard)
-         */
 }
 
 /**
@@ -131,9 +126,7 @@ static void ali_set_pio_mode(ide_drive_t *drive, const u8 pio)
  *      The actual rules for the ALi are:
  *              No UDMA on revisions <= 0x20
  *              Disk only for revisions < 0xC2
- *              Not WDC drives for revisions < 0xC2
- *
- *      FIXME: WDC ifdef needs to die
+ *              Not WDC drives on M1543C-E (?)
  */
 
 static u8 ali_udma_filter(ide_drive_t *drive)
@@ -141,10 +134,9 @@ static u8 ali_udma_filter(ide_drive_t *drive)
         if (m5229_revision > 0x20 && m5229_revision < 0xC2) {
                 if (drive->media != ide_disk)
                         return 0;
-#ifndef CONFIG_WDC_ALI15X3
-                if (chip_is_1543c_e && strstr(drive->id->model, "WDC "))
+                if (chip_is_1543c_e && strstr(drive->id->model, "WDC ") &&
+                    wdc_udma == 0)
                         return 0;
-#endif
         }
 
         return drive->hwif->ultra_mask;
@@ -537,17 +529,9 @@ static const struct ide_port_info ali15x3_chipset __devinitdata = {
  
 static int __devinit alim15x3_init_one(struct pci_dev *dev, const struct pci_device_id *id)
 {
-        static struct pci_device_id ati_rs100[] = {
-                { PCI_DEVICE(PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_RS100) },
-                { },
-        };
-
         struct ide_port_info d = ali15x3_chipset;
         u8 rev = dev->revision, idx = id->driver_data;
 
-        if (pci_dev_present(ati_rs100))
-                printk(KERN_WARNING "alim15x3: ATI Radeon IGP Northbridge is not yet fully tested.\n");
-
         /* don't use LBA48 DMA on ALi devices before rev 0xC5 */
         if (rev <= 0xC4)
                 d.host_flags |= IDE_HFLAG_NO_LBA48_DMA;
diff --git a/drivers/ide/pci/cs5520.c b/drivers/ide/pci/cs5520.c
index 17669a434438..992b1cf8db69 100644
--- a/drivers/ide/pci/cs5520.c
+++ b/drivers/ide/pci/cs5520.c
@@ -119,6 +119,7 @@ static const struct ide_dma_ops cs5520_dma_ops = {
         .dma_timeout            = ide_dma_timeout,
 };
 
+/* FIXME: VDMA is disabled because it caused system hangs */
 #define DECLARE_CS_DEV(name_str)                                \
         {                                                       \
                 .name           = name_str,                     \
@@ -126,7 +127,6 @@ static const struct ide_dma_ops cs5520_dma_ops = {
                 .dma_ops        = &cs5520_dma_ops,              \
                 .host_flags     = IDE_HFLAG_ISA_PORTS |         \
                                   IDE_HFLAG_CS5520 |            \
-                                  IDE_HFLAG_VDMA |              \
                                   IDE_HFLAG_NO_ATAPI_DMA |      \
                                   IDE_HFLAG_ABUSE_SET_DMA_MODE, \
                 .pio_mask       = ATA_PIO4,                     \