1 files changed, 29 insertions, 21 deletions

diff --git a/drivers/ide/pci/sc1200.c b/drivers/ide/pci/sc1200.c
index 14c787b5d95f..8efaed16fea3 100644
--- a/drivers/ide/pci/sc1200.c
+++ b/drivers/ide/pci/sc1200.c
@@ -22,6 +22,8 @@
 
 #include <asm/io.h>
 
+#define DRV_NAME "sc1200"
+
 #define SC1200_REV_A    0x00
 #define SC1200_REV_B1   0x01
 #define SC1200_REV_B3   0x02
@@ -234,21 +236,11 @@ static int sc1200_suspend (struct pci_dev *dev, pm_message_t state)
          * we only save state when going from full power to less
          */
         if (state.event == PM_EVENT_ON) {
-                struct sc1200_saved_state *ss;
+                struct ide_host *host = pci_get_drvdata(dev);
+                struct sc1200_saved_state *ss = host->host_priv;
                 unsigned int r;
 
                 /*
-                 * allocate a permanent save area, if not already allocated
-                 */
-                ss = (struct sc1200_saved_state *)pci_get_drvdata(dev);
-                if (ss == NULL) {
-                        ss = kmalloc(sizeof(*ss), GFP_KERNEL);
-                        if (ss == NULL)
-                                return -ENOMEM;
-                        pci_set_drvdata(dev, ss);
-                }
-
-                /*
                  * save timing registers
                  * (this may be unnecessary if BIOS also does it)
                  */
@@ -263,7 +255,8 @@ static int sc1200_suspend (struct pci_dev *dev, pm_message_t state)
 
 static int sc1200_resume (struct pci_dev *dev)
 {
-        struct sc1200_saved_state *ss;
+        struct ide_host *host = pci_get_drvdata(dev);
+        struct sc1200_saved_state *ss = host->host_priv;
         unsigned int r;
         int i;
 
@@ -271,16 +264,12 @@ static int sc1200_resume (struct pci_dev *dev)
         if (i)
                 return i;
 
-        ss = (struct sc1200_saved_state *)pci_get_drvdata(dev);
-
         /*
          * restore timing registers
          * (this may be unnecessary if BIOS also does it)
          */
-        if (ss) {
-                for (r = 0; r < 8; r++)
-                        pci_write_config_dword(dev, 0x40 + r * 4, ss->regs[r]);
-        }
+        for (r = 0; r < 8; r++)
+                pci_write_config_dword(dev, 0x40 + r * 4, ss->regs[r]);
 
         return 0;
 }
@@ -304,7 +293,7 @@ static const struct ide_dma_ops sc1200_dma_ops = {
 };
 
 static const struct ide_port_info sc1200_chipset __devinitdata = {
-        .name           = "SC1200",
+        .name           = DRV_NAME,
         .port_ops       = &sc1200_port_ops,
         .dma_ops        = &sc1200_dma_ops,
         .host_flags     = IDE_HFLAG_SERIALIZE |
@@ -317,7 +306,19 @@ static const struct ide_port_info sc1200_chipset __devinitdata = {
 
 static int __devinit sc1200_init_one(struct pci_dev *dev, const struct pci_device_id *id)
 {
-        return ide_setup_pci_device(dev, &sc1200_chipset);
+        struct sc1200_saved_state *ss = NULL;
+        int rc;
+
+#ifdef CONFIG_PM
+        ss = kmalloc(sizeof(*ss), GFP_KERNEL);
+        if (ss == NULL)
+                return -ENOMEM;
+#endif
+        rc = ide_pci_init_one(dev, &sc1200_chipset, ss);
+        if (rc)
+                kfree(ss);
+
+        return rc;
 }
 
 static const struct pci_device_id sc1200_pci_tbl[] = {
@@ -330,6 +331,7 @@ static struct pci_driver driver = {
         .name           = "SC1200_IDE",
         .id_table       = sc1200_pci_tbl,
         .probe          = sc1200_init_one,
+        .remove         = ide_pci_remove,
 #ifdef CONFIG_PM
         .suspend        = sc1200_suspend,
         .resume         = sc1200_resume,
@@ -341,7 +343,13 @@ static int __init sc1200_ide_init(void)
         return ide_pci_register_driver(&driver);
 }
 
+static void __exit sc1200_ide_exit(void)
+{
+        pci_unregister_driver(&driver);
+}
+
 module_init(sc1200_ide_init);
+module_exit(sc1200_ide_exit);
 
 MODULE_AUTHOR("Mark Lord");
 MODULE_DESCRIPTION("PCI driver module for NS SC1200 IDE");