1 files changed, 89 insertions, 94 deletions

diff --git a/drivers/ide/pci/hpt366.c b/drivers/ide/pci/hpt366.c
index 1f1135ce7cd6..5271b246b88c 100644
--- a/drivers/ide/pci/hpt366.c
+++ b/drivers/ide/pci/hpt366.c
@@ -131,6 +131,8 @@
 #include <asm/uaccess.h>
 #include <asm/io.h>
 
+#define DRV_NAME "hpt366"
+
 /* various tuning parameters */
 #define HPT_RESET_STATE_ENGINE
 #undef  HPT_DELAY_INTERRUPT
@@ -620,7 +622,8 @@ static u8 hpt3xx_udma_filter(ide_drive_t *drive)
 {
         ide_hwif_t *hwif        = HWIF(drive);
         struct pci_dev *dev     = to_pci_dev(hwif->dev);
-        struct hpt_info *info   = pci_get_drvdata(dev);
+        struct ide_host *host   = pci_get_drvdata(dev);
+        struct hpt_info *info   = host->host_priv + (hwif->dev == host->dev[1]);
         u8 mask                 = hwif->ultra_mask;
 
         switch (info->chip_type) {
@@ -660,7 +663,8 @@ static u8 hpt3xx_mdma_filter(ide_drive_t *drive)
 {
         ide_hwif_t *hwif        = HWIF(drive);
         struct pci_dev *dev     = to_pci_dev(hwif->dev);
-        struct hpt_info *info   = pci_get_drvdata(dev);
+        struct ide_host *host   = pci_get_drvdata(dev);
+        struct hpt_info *info   = host->host_priv + (hwif->dev == host->dev[1]);
 
         switch (info->chip_type) {
         case HPT372 :
@@ -694,8 +698,10 @@ static u32 get_speed_setting(u8 speed, struct hpt_info *info)
 
 static void hpt3xx_set_mode(ide_drive_t *drive, const u8 speed)
 {
-        struct pci_dev  *dev    = to_pci_dev(drive->hwif->dev);
-        struct hpt_info *info   = pci_get_drvdata(dev);
+        ide_hwif_t *hwif        = drive->hwif;
+        struct pci_dev *dev     = to_pci_dev(hwif->dev);
+        struct ide_host *host   = pci_get_drvdata(dev);
+        struct hpt_info *info   = host->host_priv + (hwif->dev == host->dev[1]);
         struct hpt_timings *t   = info->timings;
         u8  itr_addr            = 0x40 + (drive->dn * 4);
         u32 old_itr             = 0;
@@ -738,7 +744,8 @@ static void hpt3xx_maskproc(ide_drive_t *drive, int mask)
 {
         ide_hwif_t *hwif        = HWIF(drive);
         struct pci_dev  *dev    = to_pci_dev(hwif->dev);
-        struct hpt_info *info   = pci_get_drvdata(dev);
+        struct ide_host *host   = pci_get_drvdata(dev);
+        struct hpt_info *info   = host->host_priv + (hwif->dev == host->dev[1]);
 
         if (drive->quirk_list) {
                 if (info->chip_type >= HPT370) {
@@ -963,24 +970,16 @@ static int __devinit hpt37x_calibrate_dpll(struct pci_dev *dev, u16 f_low, u16 f
         return 1;
 }
 
-static unsigned int __devinit init_chipset_hpt366(struct pci_dev *dev, const char *name)
+static unsigned int __devinit init_chipset_hpt366(struct pci_dev *dev)
 {
-        struct hpt_info *info   = kmalloc(sizeof(struct hpt_info), GFP_KERNEL);
         unsigned long io_base   = pci_resource_start(dev, 4);
+        struct ide_host *host   = pci_get_drvdata(dev);
+        struct hpt_info *info   = host->host_priv + (&dev->dev == host->dev[1]);
+        const char *name        = DRV_NAME;
         u8 pci_clk,  dpll_clk   = 0;    /* PCI and DPLL clock in MHz */
         u8 chip_type;
         enum ata_clock  clock;
 
-        if (info == NULL) {
-                printk(KERN_ERR "%s: out of memory!\n", name);
-                return -ENOMEM;
-        }
-
-        /*
-         * Copy everything from a static "template" structure
-         * to just allocated per-chip hpt_info structure.
-         */
-        memcpy(info, pci_get_drvdata(dev), sizeof(struct hpt_info));
         chip_type = info->chip_type;
 
         pci_write_config_byte(dev, PCI_CACHE_LINE_SIZE, (L1_CACHE_BYTES / 4));
@@ -1048,8 +1047,8 @@ static unsigned int __devinit init_chipset_hpt366(struct pci_dev *dev, const cha
                 if ((temp & 0xFFFFF000) != 0xABCDE000) {
                         int i;
 
-                        printk(KERN_WARNING "%s: no clock data saved by BIOS\n",
-                               name);
+                        printk(KERN_WARNING "%s %s: no clock data saved by "
+                                "BIOS\n", name, pci_name(dev));
 
                         /* Calculate the average value of f_CNT. */
                         for (temp = i = 0; i < 128; i++) {
@@ -1074,8 +1073,9 @@ static unsigned int __devinit init_chipset_hpt366(struct pci_dev *dev, const cha
                 else
                         pci_clk = 66;
 
-                printk(KERN_INFO "%s: DPLL base: %d MHz, f_CNT: %d, "
-                       "assuming %d MHz PCI\n", name, dpll_clk, f_cnt, pci_clk);
+                printk(KERN_INFO "%s %s: DPLL base: %d MHz, f_CNT: %d, "
+                        "assuming %d MHz PCI\n", name, pci_name(dev),
+                        dpll_clk, f_cnt, pci_clk);
         } else {
                 u32 itr1 = 0;
 
@@ -1141,8 +1141,8 @@ static unsigned int __devinit init_chipset_hpt366(struct pci_dev *dev, const cha
                 }
 
                 if (info->timings->clock_table[clock] == NULL) {
-                        printk(KERN_ERR "%s: unknown bus timing!\n", name);
-                        kfree(info);
+                        printk(KERN_ERR "%s %s: unknown bus timing!\n",
+                                name, pci_name(dev));
                         return -EIO;
                 }
 
@@ -1168,17 +1168,19 @@ static unsigned int __devinit init_chipset_hpt366(struct pci_dev *dev, const cha
                                 f_low += adjust >> 1;
                 }
                 if (adjust == 8) {
-                        printk(KERN_ERR "%s: DPLL did not stabilize!\n", name);
-                        kfree(info);
+                        printk(KERN_ERR "%s %s: DPLL did not stabilize!\n",
+                                name, pci_name(dev));
                         return -EIO;
                 }
 
-                printk("%s: using %d MHz DPLL clock\n", name, dpll_clk);
+                printk(KERN_INFO "%s %s: using %d MHz DPLL clock\n",
+                        name, pci_name(dev), dpll_clk);
         } else {
                 /* Mark the fact that we're not using the DPLL. */
                 dpll_clk = 0;
 
-                printk("%s: using %d MHz PCI clock\n", name, pci_clk);
+                printk(KERN_INFO "%s %s: using %d MHz PCI clock\n",
+                        name, pci_name(dev), pci_clk);
         }
 
         /* Store the clock frequencies. */
@@ -1186,9 +1188,6 @@ static unsigned int __devinit init_chipset_hpt366(struct pci_dev *dev, const cha
         info->pci_clk   = pci_clk;
         info->clock     = clock;
 
-        /* Point to this chip's own instance of the hpt_info structure. */
-        pci_set_drvdata(dev, info);
-
         if (chip_type >= HPT370) {
                 u8  mcr1, mcr4;
 
@@ -1218,7 +1217,8 @@ static unsigned int __devinit init_chipset_hpt366(struct pci_dev *dev, const cha
 static u8 __devinit hpt3xx_cable_detect(ide_hwif_t *hwif)
 {
         struct pci_dev  *dev    = to_pci_dev(hwif->dev);
-        struct hpt_info *info   = pci_get_drvdata(dev);
+        struct ide_host *host   = pci_get_drvdata(dev);
+        struct hpt_info *info   = host->host_priv + (hwif->dev == host->dev[1]);
         u8 chip_type            = info->chip_type;
         u8 scr1 = 0, ata66      = hwif->channel ? 0x01 : 0x02;
 
@@ -1262,7 +1262,8 @@ static u8 __devinit hpt3xx_cable_detect(ide_hwif_t *hwif)
 static void __devinit init_hwif_hpt366(ide_hwif_t *hwif)
 {
         struct pci_dev *dev     = to_pci_dev(hwif->dev);
-        struct hpt_info *info   = pci_get_drvdata(dev);
+        struct ide_host *host   = pci_get_drvdata(dev);
+        struct hpt_info *info   = host->host_priv + (hwif->dev == host->dev[1]);
         int serialize           = HPT_SERIALIZE_IO;
         u8  chip_type           = info->chip_type;
         u8  new_mcr, old_mcr    = 0;
@@ -1364,7 +1365,8 @@ static void __devinit hpt374_init(struct pci_dev *dev, struct pci_dev *dev2)
         if (dev2->irq != dev->irq) {
                 /* FIXME: we need a core pci_set_interrupt() */
                 dev2->irq = dev->irq;
-                printk(KERN_INFO "HPT374: PCI config space interrupt fixed\n");
+                printk(KERN_INFO DRV_NAME " %s: PCI config space interrupt "
+                        "fixed\n", pci_name(dev2));
         }
 }
 
@@ -1399,8 +1401,8 @@ static int __devinit hpt36x_init(struct pci_dev *dev, struct pci_dev *dev2)
         pci_read_config_byte(dev2, PCI_INTERRUPT_PIN, &pin2);
 
         if (pin1 != pin2 && dev->irq == dev2->irq) {
-                printk(KERN_INFO "HPT36x: onboard version of chipset, "
-                                 "pin1=%d pin2=%d\n", pin1, pin2);
+                printk(KERN_INFO DRV_NAME " %s: onboard version of chipset, "
+                        "pin1=%d pin2=%d\n", pci_name(dev), pin1, pin2);
                 return 1;
         }
 
@@ -1455,8 +1457,8 @@ static const struct ide_dma_ops hpt36x_dma_ops = {
 };
 
 static const struct ide_port_info hpt366_chipsets[] __devinitdata = {
-        {       /* 0 */
-                .name           = "HPT36x",
+        {       /* 0: HPT36x */
+                .name           = DRV_NAME,
                 .init_chipset   = init_chipset_hpt366,
                 .init_hwif      = init_hwif_hpt366,
                 .init_dma       = init_dma_hpt366,
@@ -1472,53 +1474,9 @@ static const struct ide_port_info hpt366_chipsets[] __devinitdata = {
                 .host_flags     = IDE_HFLAGS_HPT3XX | IDE_HFLAG_SINGLE,
                 .pio_mask       = ATA_PIO4,
                 .mwdma_mask     = ATA_MWDMA2,
-        },{     /* 1 */
-                .name           = "HPT372A",
-                .init_chipset   = init_chipset_hpt366,
-                .init_hwif      = init_hwif_hpt366,
-                .init_dma       = init_dma_hpt366,
-                .enablebits     = {{0x50,0x04,0x04}, {0x54,0x04,0x04}},
-                .port_ops       = &hpt3xx_port_ops,
-                .dma_ops        = &hpt37x_dma_ops,
-                .host_flags     = IDE_HFLAGS_HPT3XX,
-                .pio_mask       = ATA_PIO4,
-                .mwdma_mask     = ATA_MWDMA2,
-        },{     /* 2 */
-                .name           = "HPT302",
-                .init_chipset   = init_chipset_hpt366,
-                .init_hwif      = init_hwif_hpt366,
-                .init_dma       = init_dma_hpt366,
-                .enablebits     = {{0x50,0x04,0x04}, {0x54,0x04,0x04}},
-                .port_ops       = &hpt3xx_port_ops,
-                .dma_ops        = &hpt37x_dma_ops,
-                .host_flags     = IDE_HFLAGS_HPT3XX,
-                .pio_mask       = ATA_PIO4,
-                .mwdma_mask     = ATA_MWDMA2,
-        },{     /* 3 */
-                .name           = "HPT371",
-                .init_chipset   = init_chipset_hpt366,
-                .init_hwif      = init_hwif_hpt366,
-                .init_dma       = init_dma_hpt366,
-                .enablebits     = {{0x50,0x04,0x04}, {0x54,0x04,0x04}},
-                .port_ops       = &hpt3xx_port_ops,
-                .dma_ops        = &hpt37x_dma_ops,
-                .host_flags     = IDE_HFLAGS_HPT3XX,
-                .pio_mask       = ATA_PIO4,
-                .mwdma_mask     = ATA_MWDMA2,
-        },{     /* 4 */
-                .name           = "HPT374",
-                .init_chipset   = init_chipset_hpt366,
-                .init_hwif      = init_hwif_hpt366,
-                .init_dma       = init_dma_hpt366,
-                .enablebits     = {{0x50,0x04,0x04}, {0x54,0x04,0x04}},
-                .udma_mask      = ATA_UDMA5,
-                .port_ops       = &hpt3xx_port_ops,
-                .dma_ops        = &hpt37x_dma_ops,
-                .host_flags     = IDE_HFLAGS_HPT3XX,
-                .pio_mask       = ATA_PIO4,
-                .mwdma_mask     = ATA_MWDMA2,
-        },{     /* 5 */
-                .name           = "HPT372N",
+        },
+        {       /* 1: HPT3xx */
+                .name           = DRV_NAME,
                 .init_chipset   = init_chipset_hpt366,
                 .init_hwif      = init_hwif_hpt366,
                 .init_dma       = init_dma_hpt366,
@@ -1542,10 +1500,12 @@ static const struct ide_port_info hpt366_chipsets[] __devinitdata = {
 static int __devinit hpt366_init_one(struct pci_dev *dev, const struct pci_device_id *id)
 {
         const struct hpt_info *info = NULL;
+        struct hpt_info *dyn_info;
         struct pci_dev *dev2 = NULL;
         struct ide_port_info d;
         u8 idx = id->driver_data;
         u8 rev = dev->revision;
+        int ret;
 
         if ((idx == 0 || idx == 4) && (PCI_FUNC(dev->devfn) & 1))
                 return -ENODEV;
@@ -1582,24 +1542,35 @@ static int __devinit hpt366_init_one(struct pci_dev *dev, const struct pci_devic
                 break;
         }
 
-        d = hpt366_chipsets[idx];
+        printk(KERN_INFO DRV_NAME ": %s chipset detected\n", info->chip_name);
+
+        d = hpt366_chipsets[min_t(u8, idx, 1)];
 
-        d.name = info->chip_name;
         d.udma_mask = info->udma_mask;
 
         /* fixup ->dma_ops for HPT370/HPT370A */
         if (info == &hpt370 || info == &hpt370a)
                 d.dma_ops = &hpt370_dma_ops;
 
-        pci_set_drvdata(dev, (void *)info);
-
         if (info == &hpt36x || info == &hpt374)
                 dev2 = pci_get_slot(dev->bus, dev->devfn + 1);
 
-        if (dev2) {
-                int ret;
+        dyn_info = kzalloc(sizeof(*dyn_info) * (dev2 ? 2 : 1), GFP_KERNEL);
+        if (dyn_info == NULL) {
+                printk(KERN_ERR "%s %s: out of memory!\n",
+                        d.name, pci_name(dev));
+                pci_dev_put(dev2);
+                return -ENOMEM;
+        }
+
+        /*
+         * Copy everything from a static "template" structure
+         * to just allocated per-chip hpt_info structure.
+         */
+        memcpy(dyn_info, info, sizeof(*dyn_info));
 
-                pci_set_drvdata(dev2, (void *)info);
+        if (dev2) {
+                memcpy(dyn_info + 1, info, sizeof(*dyn_info));
 
                 if (info == &hpt374)
                         hpt374_init(dev, dev2);
@@ -1608,13 +1579,30 @@ static int __devinit hpt366_init_one(struct pci_dev *dev, const struct pci_devic
                                 d.host_flags &= ~IDE_HFLAG_NON_BOOTABLE;
                 }
 
-                ret = ide_setup_pci_devices(dev, dev2, &d);
-                if (ret < 0)
+                ret = ide_pci_init_two(dev, dev2, &d, dyn_info);
+                if (ret < 0) {
                         pci_dev_put(dev2);
+                        kfree(dyn_info);
+                }
                 return ret;
         }
 
-        return ide_setup_pci_device(dev, &d);
+        ret = ide_pci_init_one(dev, &d, dyn_info);
+        if (ret < 0)
+                kfree(dyn_info);
+
+        return ret;
+}
+
+static void __devexit hpt366_remove(struct pci_dev *dev)
+{
+        struct ide_host *host = pci_get_drvdata(dev);
+        struct ide_info *info = host->host_priv;
+        struct pci_dev *dev2 = host->dev[1] ? to_pci_dev(host->dev[1]) : NULL;
+
+        ide_pci_remove(dev);
+        pci_dev_put(dev2);
+        kfree(info);
 }
 
 static const struct pci_device_id hpt366_pci_tbl[] __devinitconst = {
@@ -1632,6 +1620,7 @@ static struct pci_driver driver = {
         .name           = "HPT366_IDE",
         .id_table       = hpt366_pci_tbl,
         .probe          = hpt366_init_one,
+        .remove         = hpt366_remove,
 };
 
 static int __init hpt366_ide_init(void)
@@ -1639,7 +1628,13 @@ static int __init hpt366_ide_init(void)
         return ide_pci_register_driver(&driver);
 }
 
+static void __exit hpt366_ide_exit(void)
+{
+        pci_unregister_driver(&driver);
+}
+
 module_init(hpt366_ide_init);
+module_exit(hpt366_ide_exit);
 
 MODULE_AUTHOR("Andre Hedrick");
 MODULE_DESCRIPTION("PCI driver module for Highpoint HPT366 IDE");