1 files changed, 18 insertions, 96 deletions

diff --git a/drivers/ide/ide-io.c b/drivers/ide/ide-io.c
index 696525342e9a..28057747c1f8 100644
--- a/drivers/ide/ide-io.c
+++ b/drivers/ide/ide-io.c
@@ -358,31 +358,6 @@ void ide_end_drive_cmd (ide_drive_t *drive, u8 stat, u8 err)
 
 EXPORT_SYMBOL(ide_end_drive_cmd);
 
-/**
- *      try_to_flush_leftover_data      -       flush junk
- *      @drive: drive to flush
- *
- *      try_to_flush_leftover_data() is invoked in response to a drive
- *      unexpectedly having its DRQ_STAT bit set.  As an alternative to
- *      resetting the drive, this routine tries to clear the condition
- *      by read a sector's worth of data from the drive.  Of course,
- *      this may not help if the drive is *waiting* for data from *us*.
- */
-static void try_to_flush_leftover_data (ide_drive_t *drive)
-{
-        int i = (drive->mult_count ? drive->mult_count : 1) * SECTOR_WORDS;
-
-        if (drive->media != ide_disk)
-                return;
-        while (i > 0) {
-                u32 buffer[16];
-                u32 wcount = (i > 16) ? 16 : i;
-
-                i -= wcount;
-                drive->hwif->input_data(drive, NULL, buffer, wcount * 4);
-        }
-}
-
 static void ide_kill_rq(ide_drive_t *drive, struct request *rq)
 {
         if (rq->rq_disk) {
@@ -422,8 +397,11 @@ static ide_startstop_t ide_ata_error(ide_drive_t *drive, struct request *rq, u8
         }
 
         if ((stat & DRQ_STAT) && rq_data_dir(rq) == READ &&
-            (hwif->host_flags & IDE_HFLAG_ERROR_STOPS_FIFO) == 0)
-                try_to_flush_leftover_data(drive);
+            (hwif->host_flags & IDE_HFLAG_ERROR_STOPS_FIFO) == 0) {
+                int nsect = drive->mult_count ? drive->mult_count : 1;
+
+                ide_pad_transfer(drive, READ, nsect * SECTOR_SIZE);
+        }
 
         if (rq->errors >= ERROR_MAX || blk_noretry_request(rq)) {
                 ide_kill_rq(drive, rq);
@@ -459,7 +437,7 @@ static ide_startstop_t ide_atapi_error(ide_drive_t *drive, struct request *rq, u
 
         if (ide_read_status(drive) & (BUSY_STAT | DRQ_STAT))
                 /* force an abort */
-                hwif->OUTBSYNC(drive, WIN_IDLEIMMEDIATE,
+                hwif->OUTBSYNC(hwif, WIN_IDLEIMMEDIATE,
                                hwif->io_ports.command_addr);
 
         if (rq->errors >= ERROR_MAX) {
@@ -1539,88 +1517,30 @@ irqreturn_t ide_intr (int irq, void *dev_id)
 }
 
 /**
- *      ide_init_drive_cmd      -       initialize a drive command request
- *      @rq: request object
- *
- *      Initialize a request before we fill it in and send it down to
- *      ide_do_drive_cmd. Commands must be set up by this function. Right
- *      now it doesn't do a lot, but if that changes abusers will have a
- *      nasty surprise.
- */
-
-void ide_init_drive_cmd (struct request *rq)
-{
-        blk_rq_init(NULL, rq);
-}
-
-EXPORT_SYMBOL(ide_init_drive_cmd);
-
-/**
  *      ide_do_drive_cmd        -       issue IDE special command
  *      @drive: device to issue command
  *      @rq: request to issue
- *      @action: action for processing
  *
  *      This function issues a special IDE device request
  *      onto the request queue.
  *
- *      If action is ide_wait, then the rq is queued at the end of the
- *      request queue, and the function sleeps until it has been processed.
- *      This is for use when invoked from an ioctl handler.
- *
- *      If action is ide_preempt, then the rq is queued at the head of
- *      the request queue, displacing the currently-being-processed
- *      request and this function returns immediately without waiting
- *      for the new rq to be completed.  This is VERY DANGEROUS, and is
- *      intended for careful use by the ATAPI tape/cdrom driver code.
- *
- *      If action is ide_end, then the rq is queued at the end of the
- *      request queue, and the function returns immediately without waiting
- *      for the new rq to be completed. This is again intended for careful
- *      use by the ATAPI tape/cdrom driver code.
+ *      the rq is queued at the head of the request queue, displacing
+ *      the currently-being-processed request and this function
+ *      returns immediately without waiting for the new rq to be
+ *      completed.  This is VERY DANGEROUS, and is intended for
+ *      careful use by the ATAPI tape/cdrom driver code.
  */
- 
-int ide_do_drive_cmd (ide_drive_t *drive, struct request *rq, ide_action_t action)
+
+void ide_do_drive_cmd(ide_drive_t *drive, struct request *rq)
 {
         unsigned long flags;
         ide_hwgroup_t *hwgroup = HWGROUP(drive);
-        DECLARE_COMPLETION_ONSTACK(wait);
-        int where = ELEVATOR_INSERT_BACK, err;
-        int must_wait = (action == ide_wait || action == ide_head_wait);
-
-        rq->errors = 0;
-
-        /*
-         * we need to hold an extra reference to request for safe inspection
-         * after completion
-         */
-        if (must_wait) {
-                rq->ref_count++;
-                rq->end_io_data = &wait;
-                rq->end_io = blk_end_sync_rq;
-        }
 
         spin_lock_irqsave(&ide_lock, flags);
-        if (action == ide_preempt)
-                hwgroup->rq = NULL;
-        if (action == ide_preempt || action == ide_head_wait) {
-                where = ELEVATOR_INSERT_FRONT;
-                rq->cmd_flags |= REQ_PREEMPT;
-        }
-        __elv_add_request(drive->queue, rq, where, 0);
-        ide_do_request(hwgroup, IDE_NO_IRQ);
+        hwgroup->rq = NULL;
+        __elv_add_request(drive->queue, rq, ELEVATOR_INSERT_FRONT, 1);
+        __generic_unplug_device(drive->queue);
         spin_unlock_irqrestore(&ide_lock, flags);
-
-        err = 0;
-        if (must_wait) {
-                wait_for_completion(&wait);
-                if (rq->errors)
-                        err = -EIO;
-
-                blk_put_request(rq);
-        }
-
-        return err;
 }
 
 EXPORT_SYMBOL(ide_do_drive_cmd);
@@ -1637,6 +1557,8 @@ void ide_pktcmd_tf_load(ide_drive_t *drive, u32 tf_flags, u16 bcount, u8 dma)
         task.tf.lbah    = (bcount >> 8) & 0xff;
 
         ide_tf_dump(drive->name, &task.tf);
+        ide_set_irq(drive, 1);
+        SELECT_MASK(drive, 0);
         drive->hwif->tf_load(drive, &task);
 }