11 files changed, 44 insertions, 41 deletions

diff --git a/drivers/i2c/algos/i2c-algo-bit.c b/drivers/i2c/algos/i2c-algo-bit.c
index df05df1a0ef6..ab230c033f99 100644
--- a/drivers/i2c/algos/i2c-algo-bit.c
+++ b/drivers/i2c/algos/i2c-algo-bit.c
@@ -372,7 +372,6 @@ static inline int readbytes(struct i2c_adapter *i2c_adap, struct i2c_msg *msg)
 
         while (count > 0) {
                 inval = i2c_inb(i2c_adap);
-/*printk("%#02x ",inval); if ( ! (count % 16) ) printk("\n"); */
                 if (inval>=0) {
                         *temp = inval;
                         rdcount++;
@@ -544,8 +543,7 @@ int i2c_bit_add_bus(struct i2c_adapter *adap)
         adap->timeout = 100;    /* default values, should       */
         adap->retries = 3;      /* be replaced by defines       */
 
-        i2c_add_adapter(adap);
-        return 0;
+        return i2c_add_adapter(adap);
 }
 
 
diff --git a/drivers/i2c/algos/i2c-algo-ite.c b/drivers/i2c/algos/i2c-algo-ite.c
index 2db7bfc85225..70d8eefb5efc 100644
--- a/drivers/i2c/algos/i2c-algo-ite.c
+++ b/drivers/i2c/algos/i2c-algo-ite.c
@@ -742,10 +742,8 @@ int i2c_iic_add_bus(struct i2c_adapter *adap)
         adap->retries = 3;              /* be replaced by defines       */
         adap->flags = 0;
 
-        i2c_add_adapter(adap);
         iic_init(iic_adap);
-
-        return 0;
+        return i2c_add_adapter(adap);
 }
 
 
diff --git a/drivers/i2c/algos/i2c-algo-pca.c b/drivers/i2c/algos/i2c-algo-pca.c
index 82946acab4c7..b88a6fcf7bd0 100644
--- a/drivers/i2c/algos/i2c-algo-pca.c
+++ b/drivers/i2c/algos/i2c-algo-pca.c
@@ -374,10 +374,10 @@ int i2c_pca_add_bus(struct i2c_adapter *adap)
         adap->timeout = 100;            /* default values, should       */
         adap->retries = 3;              /* be replaced by defines       */
 
-        rval = pca_init(pca_adap);
+        if ((rval = pca_init(pca_adap)))
+                return rval;
 
-        if (!rval)
-                i2c_add_adapter(adap);
+        rval = i2c_add_adapter(adap);
 
         return rval;
 }
diff --git a/drivers/i2c/algos/i2c-algo-pcf.c b/drivers/i2c/algos/i2c-algo-pcf.c
index 6e498df1f717..5b24930adb5a 100644
--- a/drivers/i2c/algos/i2c-algo-pcf.c
+++ b/drivers/i2c/algos/i2c-algo-pcf.c
@@ -479,9 +479,11 @@ int i2c_pcf_add_bus(struct i2c_adapter *adap)
         adap->timeout = 100;            /* default values, should       */
         adap->retries = 3;              /* be replaced by defines       */
 
-        rval = pcf_init_8584(pcf_adap);
-        if (!rval)
-                i2c_add_adapter(adap);
+        if ((rval = pcf_init_8584(pcf_adap)))
+                return rval;
+
+        rval = i2c_add_adapter(adap);
+
         return rval;
 }
 
diff --git a/drivers/i2c/algos/i2c-algo-sibyte.c b/drivers/i2c/algos/i2c-algo-sibyte.c
index 3df3f09995c2..32d41c6fac0f 100644
--- a/drivers/i2c/algos/i2c-algo-sibyte.c
+++ b/drivers/i2c/algos/i2c-algo-sibyte.c
@@ -173,9 +173,7 @@ int i2c_sibyte_add_bus(struct i2c_adapter *i2c_adap, int speed)
                 printk("\n");
         }
 
-        i2c_add_adapter(i2c_adap);
-
-        return 0;
+        return i2c_add_adapter(i2c_adap);
 }
 
 
diff --git a/drivers/i2c/busses/i2c-iop3xx.c b/drivers/i2c/busses/i2c-iop3xx.c
index aca7e1668605..48c56939c861 100644
--- a/drivers/i2c/busses/i2c-iop3xx.c
+++ b/drivers/i2c/busses/i2c-iop3xx.c
@@ -21,6 +21,9 @@
  * - Make it work with IXP46x chips
  * - Cleanup function names, coding style, etc
  *
+ * - writing to slave address causes latchup on iop331.
+ *      fix: driver refuses to address self.
+ *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
  * the Free Software Foundation, version 2.
@@ -73,12 +76,6 @@ iop3xx_i2c_reset(struct i2c_algo_iop3xx_data *iop3xx_adap)
 } 
 
 static void 
-iop3xx_i2c_set_slave_addr(struct i2c_algo_iop3xx_data *iop3xx_adap)
-{
-        __raw_writel(MYSAR, iop3xx_adap->ioaddr + SAR_OFFSET);
-}
-
-static void 
 iop3xx_i2c_enable(struct i2c_algo_iop3xx_data *iop3xx_adap)
 {
         u32 cr = IOP3XX_ICR_GCD | IOP3XX_ICR_SCLEN | IOP3XX_ICR_UE;
@@ -248,6 +245,13 @@ iop3xx_i2c_send_target_addr(struct i2c_algo_iop3xx_data *iop3xx_adap,
         int status;
         int rc;
 
+        /* avoid writing to my slave address (hangs on 80331),
+         * forbidden in Intel developer manual
+         */
+        if (msg->addr == MYSAR) {
+                return -EBUSY;
+        }
+
         __raw_writel(iic_cook_addr(msg), iop3xx_adap->ioaddr + DBR_OFFSET);
         
         cr &= ~(IOP3XX_ICR_MSTOP | IOP3XX_ICR_NACK);
@@ -498,7 +502,6 @@ iop3xx_i2c_probe(struct platform_device *pdev)
         spin_lock_init(&adapter_data->lock);
 
         iop3xx_i2c_reset(adapter_data);
-        iop3xx_i2c_set_slave_addr(adapter_data);
         iop3xx_i2c_enable(adapter_data);
 
         platform_set_drvdata(pdev, new_adapter);
diff --git a/drivers/i2c/busses/i2c-iop3xx.h b/drivers/i2c/busses/i2c-iop3xx.h
index e46ebaea7b1e..8485861f6a36 100644
--- a/drivers/i2c/busses/i2c-iop3xx.h
+++ b/drivers/i2c/busses/i2c-iop3xx.h
@@ -80,7 +80,7 @@
 #define IOP3XX_GPOD_I2C0        0x00c0  /* clear these bits to enable ch0 */
 #define IOP3XX_GPOD_I2C1        0x0030  /* clear these bits to enable ch1 */
 
-#define MYSAR                   0x02    /* SWAG a suitable slave address */
+#define MYSAR                   0       /* default slave address */
 
 #define I2C_ERR                 321
 #define I2C_ERR_BERR            (I2C_ERR+0)
diff --git a/drivers/i2c/busses/i2c-powermac.c b/drivers/i2c/busses/i2c-powermac.c
index 2a0b3be7cdd0..53bb43593863 100644
--- a/drivers/i2c/busses/i2c-powermac.c
+++ b/drivers/i2c/busses/i2c-powermac.c
@@ -148,8 +148,6 @@ static int i2c_powermac_master_xfer(	struct i2c_adapter *adap,
         int                     read;
         int                     addrdir;
 
-        if (num != 1)
-                return -EINVAL;
         if (msgs->flags & I2C_M_TEN)
                 return -EINVAL;
         read = (msgs->flags & I2C_M_RD) != 0;
@@ -166,7 +164,7 @@ static int i2c_powermac_master_xfer(	struct i2c_adapter *adap,
         rc = pmac_i2c_xfer(bus, addrdir, 0, 0, msgs->buf, msgs->len);
  bail:
         pmac_i2c_close(bus);
-        return rc < 0 ? rc : msgs->len;
+        return rc < 0 ? rc : 1;
 }
 
 static u32 i2c_powermac_func(struct i2c_adapter * adapter)
diff --git a/drivers/i2c/busses/scx200_acb.c b/drivers/i2c/busses/scx200_acb.c
index 22a3eda04166..ced309ff056f 100644
--- a/drivers/i2c/busses/scx200_acb.c
+++ b/drivers/i2c/busses/scx200_acb.c
@@ -184,21 +184,21 @@ static void scx200_acb_machine(struct scx200_acb_iface *iface, u8 status)
                 break;
 
         case state_read:
-                /* Set ACK if receiving the last byte */
-                if (iface->len == 1)
+                /* Set ACK if _next_ byte will be the last one */
+                if (iface->len == 2)
                         outb(inb(ACBCTL1) | ACBCTL1_ACK, ACBCTL1);
                 else
                         outb(inb(ACBCTL1) & ~ACBCTL1_ACK, ACBCTL1);
 
-                *iface->ptr++ = inb(ACBSDA);
-                --iface->len;
-
-                if (iface->len == 0) {
+                if (iface->len == 1) {
                         iface->result = 0;
                         iface->state = state_idle;
                         outb(inb(ACBCTL1) | ACBCTL1_STOP, ACBCTL1);
                 }
 
+                *iface->ptr++ = inb(ACBSDA);
+                --iface->len;
+
                 break;
 
         case state_write:
@@ -307,8 +307,12 @@ static s32 scx200_acb_smbus_xfer(struct i2c_adapter *adapter,
                 buffer = (u8 *)&cur_word;
                 break;
 
-        case I2C_SMBUS_BLOCK_DATA:
+        case I2C_SMBUS_I2C_BLOCK_DATA:
+                if (rw == I2C_SMBUS_READ)
+                        data->block[0] = I2C_SMBUS_BLOCK_MAX; /* For now */
                 len = data->block[0];
+                if (len == 0 || len > I2C_SMBUS_BLOCK_MAX)
+                        return -EINVAL;
                 buffer = &data->block[1];
                 break;
 
@@ -372,7 +376,7 @@ static u32 scx200_acb_func(struct i2c_adapter *adapter)
 {
         return I2C_FUNC_SMBUS_QUICK | I2C_FUNC_SMBUS_BYTE |
                I2C_FUNC_SMBUS_BYTE_DATA | I2C_FUNC_SMBUS_WORD_DATA |
-               I2C_FUNC_SMBUS_BLOCK_DATA;
+               I2C_FUNC_SMBUS_I2C_BLOCK;
 }
 
 /* For now, we only handle combined mode (smbus) */
diff --git a/drivers/i2c/chips/pca9539.c b/drivers/i2c/chips/pca9539.c
index 54b6e6a4beed..cb22280cdd27 100644
--- a/drivers/i2c/chips/pca9539.c
+++ b/drivers/i2c/chips/pca9539.c
@@ -134,11 +134,13 @@ static int pca9539_detect(struct i2c_adapter *adapter, int address, int kind)
         new_client->driver = &pca9539_driver;
         new_client->flags = 0;
 
-        /* Detection: the pca9539 only has 8 registers (0-7).
-           A read of 7 should succeed, but a read of 8 should fail. */
-        if ((i2c_smbus_read_byte_data(new_client, 7) < 0) ||
-            (i2c_smbus_read_byte_data(new_client, 8) >= 0))
-                goto exit_kfree;
+        if (kind < 0) {
+                /* Detection: the pca9539 only has 8 registers (0-7).
+                   A read of 7 should succeed, but a read of 8 should fail. */
+                if ((i2c_smbus_read_byte_data(new_client, 7) < 0) ||
+                    (i2c_smbus_read_byte_data(new_client, 8) >= 0))
+                        goto exit_kfree;
+        }
 
         strlcpy(new_client->name, "pca9539", I2C_NAME_SIZE);
 
diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c
index a45155f799d4..9cb277d6aa48 100644
--- a/drivers/i2c/i2c-core.c
+++ b/drivers/i2c/i2c-core.c
@@ -756,9 +756,9 @@ int i2c_probe(struct i2c_adapter *adapter,
                                         "parameter for adapter %d, "
                                         "addr 0x%02x\n", adap_id,
                                         address_data->ignore[j + 1]);
+                                ignore = 1;
+                                break;
                         }
-                        ignore = 1;
-                        break;
                 }
                 if (ignore)
                         continue;