1 files changed, 18 insertions, 13 deletions

diff --git a/drivers/i2c/busses/i2c-viapro.c b/drivers/i2c/busses/i2c-viapro.c
index 77b13d027f86..862eb352a2d9 100644
--- a/drivers/i2c/busses/i2c-viapro.c
+++ b/drivers/i2c/busses/i2c-viapro.c
@@ -1,6 +1,4 @@
 /*
-    i2c-viapro.c - Part of lm_sensors, Linux kernel modules for hardware
-              monitoring
     Copyright (c) 1998 - 2002  Frodo Looijaard <frodol@dds.nl>,
     Philip Edelbrock <phil@netroedge.com>, Kyösti Mälkki <kmalkki@cc.hut.fi>,
     Mark D. Studebaker <mdsxyz123@yahoo.com>
@@ -50,6 +48,7 @@
 #include <linux/ioport.h>
 #include <linux/i2c.h>
 #include <linux/init.h>
+#include <linux/acpi.h>
 #include <asm/io.h>
 
 static struct pci_dev *vt596_pdev;
@@ -152,7 +151,7 @@ static int vt596_transaction(u8 size)
                 if ((temp = inb_p(SMBHSTSTS)) & 0x1F) {
                         dev_err(&vt596_adapter.dev, "SMBus reset failed! "
                                 "(0x%02x)\n", temp);
-                        return -1;
+                        return -EBUSY;
                 }
         }
 
@@ -167,24 +166,24 @@ static int vt596_transaction(u8 size)
 
         /* If the SMBus is still busy, we give up */
         if (timeout >= MAX_TIMEOUT) {
-                result = -1;
+                result = -ETIMEDOUT;
                 dev_err(&vt596_adapter.dev, "SMBus timeout!\n");
         }
 
         if (temp & 0x10) {
-                result = -1;
+                result = -EIO;
                 dev_err(&vt596_adapter.dev, "Transaction failed (0x%02x)\n",
                         size);
         }
 
         if (temp & 0x08) {
-                result = -1;
+                result = -EIO;
                 dev_err(&vt596_adapter.dev, "SMBus collision!\n");
         }
 
         if (temp & 0x04) {
                 int read = inb_p(SMBHSTADD) & 0x01;
-                result = -1;
+                result = -ENXIO;
                 /* The quick and receive byte commands are used to probe
                    for chips, so errors are expected, and we don't want
                    to frighten the user. */
@@ -202,12 +201,13 @@ static int vt596_transaction(u8 size)
         return result;
 }
 
-/* Return -1 on error, 0 on success */
+/* Return negative errno on error, 0 on success */
 static s32 vt596_access(struct i2c_adapter *adap, u16 addr,
                 unsigned short flags, char read_write, u8 command,
                 int size, union i2c_smbus_data *data)
 {
         int i;
+        int status;
 
         switch (size) {
         case I2C_SMBUS_QUICK:
@@ -258,8 +258,9 @@ static s32 vt596_access(struct i2c_adapter *adap, u16 addr,
 
         outb_p(((addr & 0x7f) << 1) | read_write, SMBHSTADD);
 
-        if (vt596_transaction(size)) /* Error in transaction */
-                return -1;
+        status = vt596_transaction(size);
+        if (status)
+                return status;
 
         if ((read_write == I2C_SMBUS_WRITE) || (size == VT596_QUICK))
                 return 0;
@@ -285,9 +286,9 @@ static s32 vt596_access(struct i2c_adapter *adap, u16 addr,
         return 0;
 
 exit_unsupported:
-        dev_warn(&vt596_adapter.dev, "Unsupported command invoked! (0x%02x)\n",
+        dev_warn(&vt596_adapter.dev, "Unsupported transaction %d\n",
                  size);
-        return -1;
+        return -EOPNOTSUPP;
 }
 
 static u32 vt596_func(struct i2c_adapter *adapter)
@@ -309,7 +310,7 @@ static const struct i2c_algorithm smbus_algorithm = {
 static struct i2c_adapter vt596_adapter = {
         .owner          = THIS_MODULE,
         .id             = I2C_HW_SMBUS_VIA2,
-        .class          = I2C_CLASS_HWMON,
+        .class          = I2C_CLASS_HWMON | I2C_CLASS_SPD,
         .algo           = &smbus_algorithm,
 };
 
@@ -354,6 +355,10 @@ static int __devinit vt596_probe(struct pci_dev *pdev,
         }
 
 found:
+        error = acpi_check_region(vt596_smba, 8, vt596_driver.name);
+        if (error)
+                return error;
+
         if (!request_region(vt596_smba, 8, vt596_driver.name)) {
                 dev_err(&pdev->dev, "SMBus region 0x%x already in use!\n",
                         vt596_smba);