2 files changed, 27 insertions, 30 deletions

diff --git a/drivers/hwmon/hdaps.c b/drivers/hwmon/hdaps.c
index 3bf05d5d0c82..c81bd4bce1b8 100644
--- a/drivers/hwmon/hdaps.c
+++ b/drivers/hwmon/hdaps.c
@@ -60,9 +60,11 @@
 
 #define HDAPS_POLL_PERIOD       (HZ/20) /* poll for input every 1/20s */
 #define HDAPS_INPUT_FUZZ        4       /* input event threshold */
+#define HDAPS_INPUT_FLAT        4
 
 static struct timer_list hdaps_timer;
 static struct platform_device *pdev;
+static struct input_dev *hdaps_idev;
 static unsigned int hdaps_invert;
 static u8 km_activity;
 static int rest_x;
@@ -310,18 +312,6 @@ static struct platform_driver hdaps_driver = {
         },
 };
 
-/* Input class stuff */
-
-static struct input_dev hdaps_idev = {
-        .name = "hdaps",
-        .evbit = { BIT(EV_ABS) },
-        .absbit = { BIT(ABS_X) | BIT(ABS_Y) },
-        .absmin  = { [ABS_X] = -256, [ABS_Y] = -256 },
-        .absmax  = { [ABS_X] = 256, [ABS_Y] = 256 },
-        .absfuzz = { [ABS_X] = HDAPS_INPUT_FUZZ, [ABS_Y] = HDAPS_INPUT_FUZZ },
-        .absflat = { [ABS_X] = HDAPS_INPUT_FUZZ, [ABS_Y] = HDAPS_INPUT_FUZZ },
-};
-
 /*
  * hdaps_calibrate - Set our "resting" values.  Callers must hold hdaps_sem.
  */
@@ -343,9 +333,9 @@ static void hdaps_mousedev_poll(unsigned long unused)
         if (__hdaps_read_pair(HDAPS_PORT_XPOS, HDAPS_PORT_YPOS, &x, &y))
                 goto out;
 
-        input_report_abs(&hdaps_idev, ABS_X, x - rest_x);
-        input_report_abs(&hdaps_idev, ABS_Y, y - rest_y);
-        input_sync(&hdaps_idev);
+        input_report_abs(hdaps_idev, ABS_X, x - rest_x);
+        input_report_abs(hdaps_idev, ABS_Y, y - rest_y);
+        input_sync(hdaps_idev);
 
         mod_timer(&hdaps_timer, jiffies + HDAPS_POLL_PERIOD);
 
@@ -565,12 +555,25 @@ static int __init hdaps_init(void)
         if (ret)
                 goto out_device;
 
+        hdaps_idev = input_allocate_device();
+        if (!hdaps_idev) {
+                ret = -ENOMEM;
+                goto out_group;
+        }
+
         /* initial calibrate for the input device */
         hdaps_calibrate();
 
         /* initialize the input class */
-        hdaps_idev.dev = &pdev->dev;
-        input_register_device(&hdaps_idev);
+        hdaps_idev->name = "hdaps";
+        hdaps_idev->cdev.dev = &pdev->dev;
+        hdaps_idev->evbit[0] = BIT(EV_ABS);
+        input_set_abs_params(hdaps_idev, ABS_X,
+                        -256, 256, HDAPS_INPUT_FUZZ, HDAPS_INPUT_FLAT);
+        input_set_abs_params(hdaps_idev, ABS_X,
+                        -256, 256, HDAPS_INPUT_FUZZ, HDAPS_INPUT_FLAT);
+
+        input_register_device(hdaps_idev);
 
         /* start up our timer for the input device */
         init_timer(&hdaps_timer);
@@ -581,6 +584,8 @@ static int __init hdaps_init(void)
         printk(KERN_INFO "hdaps: driver successfully loaded.\n");
         return 0;
 
+out_group:
+        sysfs_remove_group(&pdev->dev.kobj, &hdaps_attribute_group);
 out_device:
         platform_device_unregister(pdev);
 out_driver:
@@ -595,7 +600,7 @@ out:
 static void __exit hdaps_exit(void)
 {
         del_timer_sync(&hdaps_timer);
-        input_unregister_device(&hdaps_idev);
+        input_unregister_device(hdaps_idev);
         sysfs_remove_group(&pdev->dev.kobj, &hdaps_attribute_group);
         platform_device_unregister(pdev);
         platform_driver_unregister(&hdaps_driver);
diff --git a/drivers/hwmon/w83627hf.c b/drivers/hwmon/w83627hf.c
index 70ef926c3bd8..4e9a04e1f08e 100644
--- a/drivers/hwmon/w83627hf.c
+++ b/drivers/hwmon/w83627hf.c
@@ -180,11 +180,10 @@ superio_exit(void)
 #define W83781D_REG_BANK 0x4E
 
 #define W83781D_REG_CONFIG 0x40
-#define W83781D_REG_ALARM1 0x41
-#define W83781D_REG_ALARM2 0x42
-#define W83781D_REG_ALARM3 0x450
+#define W83781D_REG_ALARM1 0x459
+#define W83781D_REG_ALARM2 0x45A
+#define W83781D_REG_ALARM3 0x45B
 
-#define W83781D_REG_IRQ 0x4C
 #define W83781D_REG_BEEP_CONFIG 0x4D
 #define W83781D_REG_BEEP_INTS1 0x56
 #define W83781D_REG_BEEP_INTS2 0x57
@@ -1370,13 +1369,6 @@ static void w83627hf_init_client(struct i2c_client *client)
                                         W83781D_REG_TEMP3_CONFIG, tmp & 0xfe);
                         }
                 }
-
-                /* enable comparator mode for temp2 and temp3 so
-                   alarm indication will work correctly */
-                i = w83627hf_read_value(client, W83781D_REG_IRQ);
-                if (!(i & 0x40))
-                        w83627hf_write_value(client, W83781D_REG_IRQ,
-                                            i | 0x40);
         }
 
         /* Start monitoring */
@@ -1400,7 +1392,7 @@ static struct w83627hf_data *w83627hf_update_device(struct device *dev)
                         /* skip missing sensors */
                         if (((data->type == w83697hf) && (i == 1)) ||
                             ((data->type == w83627thf || data->type == w83637hf)
-                            && (i == 4 || i == 5)))
+                            && (i == 5 || i == 6)))
                                 continue;
                         data->in[i] =
                             w83627hf_read_value(client, W83781D_REG_IN(i));