1 files changed, 32 insertions, 37 deletions

diff --git a/drivers/hwmon/tmp401.c b/drivers/hwmon/tmp401.c
index 7b34f2cd08bb..d14a1af9f550 100644
--- a/drivers/hwmon/tmp401.c
+++ b/drivers/hwmon/tmp401.c
@@ -42,8 +42,7 @@
 /* Addresses to scan */
 static const unsigned short normal_i2c[] = { 0x4c, I2C_CLIENT_END };
 
-/* Insmod parameters */
-I2C_CLIENT_INSMOD_2(tmp401, tmp411);
+enum chips { tmp401, tmp411 };
 
 /*
  * The TMP401 registers, note some registers have different addresses for
@@ -98,7 +97,7 @@ static const u8 TMP411_TEMP_HIGHEST_LSB[2]		= { 0x33, 0x37 };
 
 static int tmp401_probe(struct i2c_client *client,
                         const struct i2c_device_id *id);
-static int tmp401_detect(struct i2c_client *client, int kind,
+static int tmp401_detect(struct i2c_client *client,
                          struct i2c_board_info *info);
 static int tmp401_remove(struct i2c_client *client);
 static struct tmp401_data *tmp401_update_device(struct device *dev);
@@ -123,7 +122,7 @@ static struct i2c_driver tmp401_driver = {
         .remove         = tmp401_remove,
         .id_table       = tmp401_id,
         .detect         = tmp401_detect,
-        .address_data   = &addr_data,
+        .address_list   = normal_i2c,
 };
 
 /*
@@ -135,7 +134,7 @@ struct tmp401_data {
         struct mutex update_lock;
         char valid; /* zero until following fields are valid */
         unsigned long last_updated; /* in jiffies */
-        int kind;
+        enum chips kind;
 
         /* register values */
         u8 status;
@@ -488,47 +487,44 @@ static void tmp401_init_client(struct i2c_client *client)
                 i2c_smbus_write_byte_data(client, TMP401_CONFIG_WRITE, config);
 }
 
-static int tmp401_detect(struct i2c_client *client, int kind,
+static int tmp401_detect(struct i2c_client *client,
                          struct i2c_board_info *info)
 {
+        enum chips kind;
         struct i2c_adapter *adapter = client->adapter;
+        u8 reg;
 
         if (!i2c_check_functionality(adapter, I2C_FUNC_SMBUS_BYTE_DATA))
                 return -ENODEV;
 
         /* Detect and identify the chip */
-        if (kind <= 0) {
-                u8 reg;
-
-                reg = i2c_smbus_read_byte_data(client,
-                                               TMP401_MANUFACTURER_ID_REG);
-                if (reg != TMP401_MANUFACTURER_ID)
-                        return -ENODEV;
-
-                reg = i2c_smbus_read_byte_data(client, TMP401_DEVICE_ID_REG);
-
-                switch (reg) {
-                case TMP401_DEVICE_ID:
-                        kind = tmp401;
-                        break;
-                case TMP411_DEVICE_ID:
-                        kind = tmp411;
-                        break;
-                default:
-                        return -ENODEV;
-                }
+        reg = i2c_smbus_read_byte_data(client, TMP401_MANUFACTURER_ID_REG);
+        if (reg != TMP401_MANUFACTURER_ID)
+                return -ENODEV;
 
-                reg = i2c_smbus_read_byte_data(client, TMP401_CONFIG_READ);
-                if (reg & 0x1b)
-                        return -ENODEV;
+        reg = i2c_smbus_read_byte_data(client, TMP401_DEVICE_ID_REG);
 
-                reg = i2c_smbus_read_byte_data(client,
-                                               TMP401_CONVERSION_RATE_READ);
-                /* Datasheet says: 0x1-0x6 */
-                if (reg > 15)
-                        return -ENODEV;
+        switch (reg) {
+        case TMP401_DEVICE_ID:
+                kind = tmp401;
+                break;
+        case TMP411_DEVICE_ID:
+                kind = tmp411;
+                break;
+        default:
+                return -ENODEV;
         }
-        strlcpy(info->type, tmp401_id[kind - 1].name, I2C_NAME_SIZE);
+
+        reg = i2c_smbus_read_byte_data(client, TMP401_CONFIG_READ);
+        if (reg & 0x1b)
+                return -ENODEV;
+
+        reg = i2c_smbus_read_byte_data(client, TMP401_CONVERSION_RATE_READ);
+        /* Datasheet says: 0x1-0x6 */
+        if (reg > 15)
+                return -ENODEV;
+
+        strlcpy(info->type, tmp401_id[kind].name, I2C_NAME_SIZE);
 
         return 0;
 }
@@ -576,8 +572,7 @@ static int tmp401_probe(struct i2c_client *client,
                 goto exit_remove;
         }
 
-        dev_info(&client->dev, "Detected TI %s chip\n",
-                 names[data->kind - 1]);
+        dev_info(&client->dev, "Detected TI %s chip\n", names[data->kind]);
 
         return 0;