1 files changed, 17 insertions, 24 deletions

diff --git a/drivers/hwmon/adt7462.c b/drivers/hwmon/adt7462.c
index 1852f27bac51..2af0c7b6b4e4 100644
--- a/drivers/hwmon/adt7462.c
+++ b/drivers/hwmon/adt7462.c
@@ -28,13 +28,11 @@
 #include <linux/mutex.h>
 #include <linux/delay.h>
 #include <linux/log2.h>
+#include <linux/slab.h>
 
 /* Addresses to scan */
 static const unsigned short normal_i2c[] = { 0x58, 0x5C, I2C_CLIENT_END };
 
-/* Insmod parameters */
-I2C_CLIENT_INSMOD_1(adt7462);
-
 /* ADT7462 registers */
 #define ADT7462_REG_DEVICE                      0x3D
 #define ADT7462_REG_VENDOR                      0x3E
@@ -97,7 +95,7 @@ I2C_CLIENT_INSMOD_1(adt7462);
 #define         ADT7462_PIN24_SHIFT             6
 #define         ADT7462_PIN26_VOLT_INPUT        0x08
 #define         ADT7462_PIN25_VOLT_INPUT        0x20
-#define         ADT7462_PIN28_SHIFT             6       /* cfg3 */
+#define         ADT7462_PIN28_SHIFT             4       /* cfg3 */
 #define         ADT7462_PIN28_VOLT              0x5
 
 #define ADT7462_REG_ALARM1                      0xB8
@@ -182,7 +180,7 @@ I2C_CLIENT_INSMOD_1(adt7462);
  *
  * Some, but not all, of these voltages have low/high limits.
  */
-#define ADT7462_VOLT_COUNT      12
+#define ADT7462_VOLT_COUNT      13
 
 #define ADT7462_VENDOR          0x41
 #define ADT7462_DEVICE          0x62
@@ -237,12 +235,12 @@ struct adt7462_data {
 
 static int adt7462_probe(struct i2c_client *client,
                          const struct i2c_device_id *id);
-static int adt7462_detect(struct i2c_client *client, int kind,
+static int adt7462_detect(struct i2c_client *client,
                           struct i2c_board_info *info);
 static int adt7462_remove(struct i2c_client *client);
 
 static const struct i2c_device_id adt7462_id[] = {
-        { "adt7462", adt7462 },
+        { "adt7462", 0 },
         { }
 };
 MODULE_DEVICE_TABLE(i2c, adt7462_id);
@@ -256,7 +254,7 @@ static struct i2c_driver adt7462_driver = {
         .remove         = adt7462_remove,
         .id_table       = adt7462_id,
         .detect         = adt7462_detect,
-        .address_data   = &addr_data,
+        .address_list   = normal_i2c,
 };
 
 /*
@@ -1902,31 +1900,26 @@ static struct attribute *adt7462_attr[] =
 };
 
 /* Return 0 if detection is successful, -ENODEV otherwise */
-static int adt7462_detect(struct i2c_client *client, int kind,
+static int adt7462_detect(struct i2c_client *client,
                           struct i2c_board_info *info)
 {
         struct i2c_adapter *adapter = client->adapter;
+        int vendor, device, revision;
 
         if (!i2c_check_functionality(adapter, I2C_FUNC_SMBUS_BYTE_DATA))
                 return -ENODEV;
 
-        if (kind <= 0) {
-                int vendor, device, revision;
-
-                vendor = i2c_smbus_read_byte_data(client, ADT7462_REG_VENDOR);
-                if (vendor != ADT7462_VENDOR)
-                        return -ENODEV;
+        vendor = i2c_smbus_read_byte_data(client, ADT7462_REG_VENDOR);
+        if (vendor != ADT7462_VENDOR)
+                return -ENODEV;
 
-                device = i2c_smbus_read_byte_data(client, ADT7462_REG_DEVICE);
-                if (device != ADT7462_DEVICE)
-                        return -ENODEV;
+        device = i2c_smbus_read_byte_data(client, ADT7462_REG_DEVICE);
+        if (device != ADT7462_DEVICE)
+                return -ENODEV;
 
-                revision = i2c_smbus_read_byte_data(client,
-                                                    ADT7462_REG_REVISION);
-                if (revision != ADT7462_REVISION)
-                        return -ENODEV;
-        } else
-                dev_dbg(&adapter->dev, "detection forced\n");
+        revision = i2c_smbus_read_byte_data(client, ADT7462_REG_REVISION);
+        if (revision != ADT7462_REVISION)
+                return -ENODEV;
 
         strlcpy(info->type, "adt7462", I2C_NAME_SIZE);