4 files changed, 84 insertions, 22 deletions

diff --git a/drivers/hid/usbhid/hid-core.c b/drivers/hid/usbhid/hid-core.c
index 56d06cd8075b..ca3751fd4473 100644
--- a/drivers/hid/usbhid/hid-core.c
+++ b/drivers/hid/usbhid/hid-core.c
@@ -807,16 +807,36 @@ static int usbhid_output_raw_report(struct hid_device *hid, __u8 *buf, size_t co
         struct usb_host_interface *interface = intf->cur_altsetting;
         int ret;
 
-        ret = usb_control_msg(dev, usb_sndctrlpipe(dev, 0),
-                HID_REQ_SET_REPORT,
-                USB_DIR_OUT | USB_TYPE_CLASS | USB_RECIP_INTERFACE,
-                ((report_type + 1) << 8) | *buf,
-                interface->desc.bInterfaceNumber, buf + 1, count - 1,
-                USB_CTRL_SET_TIMEOUT);
-
-        /* count also the report id */
-        if (ret > 0)
-                ret++;
+        if (usbhid->urbout) {
+                int actual_length;
+                int skipped_report_id = 0;
+                if (buf[0] == 0x0) {
+                        /* Don't send the Report ID */
+                        buf++;
+                        count--;
+                        skipped_report_id = 1;
+                }
+                ret = usb_interrupt_msg(dev, usbhid->urbout->pipe,
+                        buf, count, &actual_length,
+                        USB_CTRL_SET_TIMEOUT);
+                /* return the number of bytes transferred */
+                if (ret == 0) {
+                        ret = actual_length;
+                        /* count also the report id */
+                        if (skipped_report_id)
+                                ret++;
+                }
+        } else {
+                ret = usb_control_msg(dev, usb_sndctrlpipe(dev, 0),
+                        HID_REQ_SET_REPORT,
+                        USB_DIR_OUT | USB_TYPE_CLASS | USB_RECIP_INTERFACE,
+                        ((report_type + 1) << 8) | *buf,
+                        interface->desc.bInterfaceNumber, buf + 1, count - 1,
+                        USB_CTRL_SET_TIMEOUT);
+                /* count also the report id */
+                if (ret > 0)
+                        ret++;
+        }
 
         return ret;
 }
@@ -999,13 +1019,6 @@ static int usbhid_start(struct hid_device *hid)
                 }
         }
 
-        init_waitqueue_head(&usbhid->wait);
-        INIT_WORK(&usbhid->reset_work, hid_reset);
-        INIT_WORK(&usbhid->restart_work, __usbhid_restart_queues);
-        setup_timer(&usbhid->io_retry, hid_retry_timeout, (unsigned long) hid);
-
-        spin_lock_init(&usbhid->lock);
-
         usbhid->urbctrl = usb_alloc_urb(0, GFP_KERNEL);
         if (!usbhid->urbctrl) {
                 ret = -ENOMEM;
@@ -1026,12 +1039,15 @@ static int usbhid_start(struct hid_device *hid)
         /* Some keyboards don't work until their LEDs have been set.
          * Since BIOSes do set the LEDs, it must be safe for any device
          * that supports the keyboard boot protocol.
+         * In addition, enable remote wakeup by default for all keyboard
+         * devices supporting the boot protocol.
          */
         if (interface->desc.bInterfaceSubClass == USB_INTERFACE_SUBCLASS_BOOT &&
                         interface->desc.bInterfaceProtocol ==
-                                USB_INTERFACE_PROTOCOL_KEYBOARD)
+                                USB_INTERFACE_PROTOCOL_KEYBOARD) {
                 usbhid_set_leds(hid);
-
+                device_set_wakeup_enable(&dev->dev, 1);
+        }
         return 0;
 
 fail:
@@ -1140,6 +1156,7 @@ static int usbhid_probe(struct usb_interface *intf, const struct usb_device_id *
         hid->vendor = le16_to_cpu(dev->descriptor.idVendor);
         hid->product = le16_to_cpu(dev->descriptor.idProduct);
         hid->name[0] = 0;
+        hid->quirks = usbhid_lookup_quirk(hid->vendor, hid->product);
         if (intf->cur_altsetting->desc.bInterfaceProtocol ==
                         USB_INTERFACE_PROTOCOL_MOUSE)
                 hid->type = HID_TYPE_USBMOUSE;
@@ -1179,6 +1196,12 @@ static int usbhid_probe(struct usb_interface *intf, const struct usb_device_id *
         usbhid->intf = intf;
         usbhid->ifnum = interface->desc.bInterfaceNumber;
 
+        init_waitqueue_head(&usbhid->wait);
+        INIT_WORK(&usbhid->reset_work, hid_reset);
+        INIT_WORK(&usbhid->restart_work, __usbhid_restart_queues);
+        setup_timer(&usbhid->io_retry, hid_retry_timeout, (unsigned long) hid);
+        spin_lock_init(&usbhid->lock);
+
         ret = hid_add_device(hid);
         if (ret) {
                 if (ret != -ENODEV)
@@ -1290,6 +1313,11 @@ static int hid_suspend(struct usb_interface *intf, pm_message_t message)
                 {
                         set_bit(HID_REPORTED_IDLE, &usbhid->iofl);
                         spin_unlock_irq(&usbhid->lock);
+                        if (hid->driver && hid->driver->suspend) {
+                                status = hid->driver->suspend(hid, message);
+                                if (status < 0)
+                                        return status;
+                        }
                 } else {
                         usbhid_mark_busy(usbhid);
                         spin_unlock_irq(&usbhid->lock);
@@ -1297,6 +1325,11 @@ static int hid_suspend(struct usb_interface *intf, pm_message_t message)
                 }
 
         } else {
+                if (hid->driver && hid->driver->suspend) {
+                        status = hid->driver->suspend(hid, message);
+                        if (status < 0)
+                                return status;
+                }
                 spin_lock_irq(&usbhid->lock);
                 set_bit(HID_REPORTED_IDLE, &usbhid->iofl);
                 spin_unlock_irq(&usbhid->lock);
@@ -1351,6 +1384,11 @@ static int hid_resume(struct usb_interface *intf)
                 hid_io_error(hid);
         usbhid_restart_queues(usbhid);
 
+        if (status >= 0 && hid->driver && hid->driver->resume) {
+                int ret = hid->driver->resume(hid);
+                if (ret < 0)
+                        status = ret;
+        }
         dev_dbg(&intf->dev, "resume status %d\n", status);
         return 0;
 }
@@ -1359,9 +1397,16 @@ static int hid_reset_resume(struct usb_interface *intf)
 {
         struct hid_device *hid = usb_get_intfdata(intf);
         struct usbhid_device *usbhid = hid->driver_data;
+        int status;
 
         clear_bit(HID_REPORTED_IDLE, &usbhid->iofl);
-        return hid_post_reset(intf);
+        status = hid_post_reset(intf);
+        if (status >= 0 && hid->driver && hid->driver->reset_resume) {
+                int ret = hid->driver->reset_resume(hid);
+                if (ret < 0)
+                        status = ret;
+        }
+        return status;
 }
 
 #endif /* CONFIG_PM */
diff --git a/drivers/hid/usbhid/hid-quirks.c b/drivers/hid/usbhid/hid-quirks.c
index 1152f9b5fd44..5ff8d327f33a 100644
--- a/drivers/hid/usbhid/hid-quirks.c
+++ b/drivers/hid/usbhid/hid-quirks.c
@@ -33,6 +33,7 @@ static const struct hid_blacklist {
         { USB_VENDOR_ID_AASHIMA, USB_DEVICE_ID_AASHIMA_PREDATOR, HID_QUIRK_BADPAD },
         { USB_VENDOR_ID_ALPS, USB_DEVICE_ID_IBM_GAMEPAD, HID_QUIRK_BADPAD },
         { USB_VENDOR_ID_CHIC, USB_DEVICE_ID_CHIC_GAMEPAD, HID_QUIRK_BADPAD },
+        { USB_VENDOR_ID_DWAV, USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH, HID_QUIRK_MULTI_INPUT },
         { USB_VENDOR_ID_HAPP, USB_DEVICE_ID_UGCI_DRIVING, HID_QUIRK_BADPAD | HID_QUIRK_MULTI_INPUT },
         { USB_VENDOR_ID_HAPP, USB_DEVICE_ID_UGCI_FLYING, HID_QUIRK_BADPAD | HID_QUIRK_MULTI_INPUT },
         { USB_VENDOR_ID_HAPP, USB_DEVICE_ID_UGCI_FIGHTING, HID_QUIRK_BADPAD | HID_QUIRK_MULTI_INPUT },
diff --git a/drivers/hid/usbhid/hiddev.c b/drivers/hid/usbhid/hiddev.c
index 433602aed468..c24d2fa3e3b6 100644
--- a/drivers/hid/usbhid/hiddev.c
+++ b/drivers/hid/usbhid/hiddev.c
@@ -267,6 +267,7 @@ static int hiddev_open(struct inode *inode, struct file *file)
         struct hiddev_list *list;
         int res, i;
 
+        /* See comment in hiddev_connect() for BKL explanation */
         lock_kernel();
         i = iminor(inode) - HIDDEV_MINOR_BASE;
 
@@ -894,8 +895,22 @@ int hiddev_connect(struct hid_device *hid, unsigned int force)
         hiddev->hid = hid;
         hiddev->exist = 1;
 
-        /* when lock_kernel() usage is fixed in usb_open(),
-         * we could also fix it here */
+        /*
+         * BKL here is used to avoid race after usb_register_dev().
+         * Once the device node has been created, open() could happen on it.
+         * The code below will then fail, as hiddev_table hasn't been
+         * updated.
+         *
+         * The obvious fix -- introducing mutex to guard hiddev_table[]
+         * doesn't work, as usb_open() and usb_register_dev() both take
+         * minor_rwsem, thus we'll have ABBA deadlock.
+         *
+         * Before BKL pushdown, usb_open() had been acquiring it in right
+         * order, so _open() was safe to use it to protect from this race.
+         * Now the order is different, but AB-BA deadlock still doesn't occur
+         * as BKL is dropped on schedule() (i.e. while sleeping on
+         * minor_rwsem). Fugly.
+         */
         lock_kernel();
         retval = usb_register_dev(usbhid->intf, &hiddev_class);
         if (retval) {
diff --git a/drivers/hid/usbhid/usbkbd.c b/drivers/hid/usbhid/usbkbd.c
index f843443ba5c3..b2fd0b00de92 100644
--- a/drivers/hid/usbhid/usbkbd.c
+++ b/drivers/hid/usbhid/usbkbd.c
@@ -313,6 +313,7 @@ static int usb_kbd_probe(struct usb_interface *iface,
                 goto fail2;
 
         usb_set_intfdata(iface, kbd);
+        device_set_wakeup_enable(&dev->dev, 1);
         return 0;
 
 fail2: