2 files changed, 7 insertions, 6 deletions

diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index 662ed923d9eb..50de0f5750d8 100644
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -661,7 +661,7 @@ int gpio_export(unsigned gpio, bool direction_may_change)
 
                 dev = device_create(&gpio_class, desc->chip->dev, MKDEV(0, 0),
                                 desc, ioname ? ioname : "gpio%d", gpio);
-                if (dev) {
+                if (!IS_ERR(dev)) {
                         if (direction_may_change)
                                 status = sysfs_create_group(&dev->kobj,
                                                 &gpio_attr_group);
@@ -679,7 +679,7 @@ int gpio_export(unsigned gpio, bool direction_may_change)
                         if (status != 0)
                                 device_unregister(dev);
                 } else
-                        status = -ENODEV;
+                        status = PTR_ERR(dev);
                 if (status == 0)
                         set_bit(FLAG_EXPORT, &desc->flags);
         }
@@ -800,11 +800,11 @@ static int gpiochip_export(struct gpio_chip *chip)
         mutex_lock(&sysfs_lock);
         dev = device_create(&gpio_class, chip->dev, MKDEV(0, 0), chip,
                                 "gpiochip%d", chip->base);
-        if (dev) {
+        if (!IS_ERR(dev)) {
                 status = sysfs_create_group(&dev->kobj,
                                 &gpiochip_attr_group);
         } else
-                status = -ENODEV;
+                status = PTR_ERR(dev);
         chip->exported = (status == 0);
         mutex_unlock(&sysfs_lock);
 
diff --git a/drivers/gpio/twl4030-gpio.c b/drivers/gpio/twl4030-gpio.c
index afad14792141..49384a7c5492 100644
--- a/drivers/gpio/twl4030-gpio.c
+++ b/drivers/gpio/twl4030-gpio.c
@@ -460,7 +460,8 @@ no_irqs:
         return ret;
 }
 
-static int __devexit gpio_twl4030_remove(struct platform_device *pdev)
+/* Cannot use __devexit as gpio_twl4030_probe() calls us */
+static int gpio_twl4030_remove(struct platform_device *pdev)
 {
         struct twl4030_gpio_platform_data *pdata = pdev->dev.platform_data;
         int status;
@@ -493,7 +494,7 @@ static struct platform_driver gpio_twl4030_driver = {
         .driver.name    = "twl4030_gpio",
         .driver.owner   = THIS_MODULE,
         .probe          = gpio_twl4030_probe,
-        .remove         = __devexit_p(gpio_twl4030_remove),
+        .remove         = gpio_twl4030_remove,
 };
 
 static int __init gpio_twl4030_init(void)