2 files changed, 29 insertions, 8 deletions

diff --git a/drivers/gpio/langwell_gpio.c b/drivers/gpio/langwell_gpio.c
index d81cc748e77f..54d70a47afc1 100644
--- a/drivers/gpio/langwell_gpio.c
+++ b/drivers/gpio/langwell_gpio.c
@@ -187,7 +187,7 @@ MODULE_DEVICE_TABLE(pci, lnw_gpio_ids);
 
 static void lnw_irq_handler(unsigned irq, struct irq_desc *desc)
 {
-        struct lnw_gpio *lnw = (struct lnw_gpio *)get_irq_data(irq);
+        struct lnw_gpio *lnw = get_irq_data(irq);
         u32 base, gpio;
         void __iomem *gedr;
         u32 gedr_v;
@@ -206,7 +206,12 @@ static void lnw_irq_handler(unsigned irq, struct irq_desc *desc)
                 /* clear the edge detect status bit */
                 writel(gedr_v, gedr);
         }
-        desc->chip->eoi(irq);
+
+        if (desc->chip->irq_eoi)
+                desc->chip->irq_eoi(irq_get_irq_data(irq));
+        else
+                dev_warn(lnw->chip.dev, "missing EOI handler for irq %d\n", irq);
+
 }
 
 static int __devinit lnw_gpio_probe(struct pci_dev *pdev,
diff --git a/drivers/gpio/pca953x.c b/drivers/gpio/pca953x.c
index a261972f603d..b473429eee75 100644
--- a/drivers/gpio/pca953x.c
+++ b/drivers/gpio/pca953x.c
@@ -60,6 +60,7 @@ struct pca953x_chip {
         unsigned gpio_start;
         uint16_t reg_output;
         uint16_t reg_direction;
+        struct mutex i2c_lock;
 
 #ifdef CONFIG_GPIO_PCA953X_IRQ
         struct mutex irq_lock;
@@ -119,13 +120,17 @@ static int pca953x_gpio_direction_input(struct gpio_chip *gc, unsigned off)
 
         chip = container_of(gc, struct pca953x_chip, gpio_chip);
 
+        mutex_lock(&chip->i2c_lock);
         reg_val = chip->reg_direction | (1u << off);
         ret = pca953x_write_reg(chip, PCA953X_DIRECTION, reg_val);
         if (ret)
-                return ret;
+                goto exit;
 
         chip->reg_direction = reg_val;
-        return 0;
+        ret = 0;
+exit:
+        mutex_unlock(&chip->i2c_lock);
+        return ret;
 }
 
 static int pca953x_gpio_direction_output(struct gpio_chip *gc,
@@ -137,6 +142,7 @@ static int pca953x_gpio_direction_output(struct gpio_chip *gc,
 
         chip = container_of(gc, struct pca953x_chip, gpio_chip);
 
+        mutex_lock(&chip->i2c_lock);
         /* set output level */
         if (val)
                 reg_val = chip->reg_output | (1u << off);
@@ -145,7 +151,7 @@ static int pca953x_gpio_direction_output(struct gpio_chip *gc,
 
         ret = pca953x_write_reg(chip, PCA953X_OUTPUT, reg_val);
         if (ret)
-                return ret;
+                goto exit;
 
         chip->reg_output = reg_val;
 
@@ -153,10 +159,13 @@ static int pca953x_gpio_direction_output(struct gpio_chip *gc,
         reg_val = chip->reg_direction & ~(1u << off);
         ret = pca953x_write_reg(chip, PCA953X_DIRECTION, reg_val);
         if (ret)
-                return ret;
+                goto exit;
 
         chip->reg_direction = reg_val;
-        return 0;
+        ret = 0;
+exit:
+        mutex_unlock(&chip->i2c_lock);
+        return ret;
 }
 
 static int pca953x_gpio_get_value(struct gpio_chip *gc, unsigned off)
@@ -167,7 +176,9 @@ static int pca953x_gpio_get_value(struct gpio_chip *gc, unsigned off)
 
         chip = container_of(gc, struct pca953x_chip, gpio_chip);
 
+        mutex_lock(&chip->i2c_lock);
         ret = pca953x_read_reg(chip, PCA953X_INPUT, &reg_val);
+        mutex_unlock(&chip->i2c_lock);
         if (ret < 0) {
                 /* NOTE:  diagnostic already emitted; that's all we should
                  * do unless gpio_*_value_cansleep() calls become different
@@ -187,6 +198,7 @@ static void pca953x_gpio_set_value(struct gpio_chip *gc, unsigned off, int val)
 
         chip = container_of(gc, struct pca953x_chip, gpio_chip);
 
+        mutex_lock(&chip->i2c_lock);
         if (val)
                 reg_val = chip->reg_output | (1u << off);
         else
@@ -194,9 +206,11 @@ static void pca953x_gpio_set_value(struct gpio_chip *gc, unsigned off, int val)
 
         ret = pca953x_write_reg(chip, PCA953X_OUTPUT, reg_val);
         if (ret)
-                return;
+                goto exit;
 
         chip->reg_output = reg_val;
+exit:
+        mutex_unlock(&chip->i2c_lock);
 }
 
 static void pca953x_setup_gpio(struct pca953x_chip *chip, int gpios)
@@ -517,6 +531,8 @@ static int __devinit pca953x_probe(struct i2c_client *client,
 
         chip->names = pdata->names;
 
+        mutex_init(&chip->i2c_lock);
+
         /* initialize cached registers from their original values.
          * we can't share this chip with another i2c master.
          */