1 files changed, 6 insertions, 5 deletions

diff --git a/drivers/firmware/efivars.c b/drivers/firmware/efivars.c
index 0287ff65963b..33b17c6a46fb 100644
--- a/drivers/firmware/efivars.c
+++ b/drivers/firmware/efivars.c
@@ -352,7 +352,7 @@ static ssize_t efivar_attr_show(struct kobject *kobj, struct attribute *attr,
 {
         struct efivar_entry *var = to_efivar_entry(kobj);
         struct efivar_attribute *efivar_attr = to_efivar_attr(attr);
-        ssize_t ret = 0;
+        ssize_t ret = -EIO;
 
         if (!capable(CAP_SYS_ADMIN))
                 return -EACCES;
@@ -368,7 +368,7 @@ static ssize_t efivar_attr_store(struct kobject *kobj, struct attribute *attr,
 {
         struct efivar_entry *var = to_efivar_entry(kobj);
         struct efivar_attribute *efivar_attr = to_efivar_attr(attr);
-        ssize_t ret = 0;
+        ssize_t ret = -EIO;
 
         if (!capable(CAP_SYS_ADMIN))
                 return -EACCES;
@@ -618,8 +618,8 @@ efivar_create_sysfs_entry(unsigned long variable_name_size,
         new_efivar = kmalloc(sizeof(struct efivar_entry), GFP_KERNEL);
 
         if (!short_name || !new_efivar)  {
-                if (short_name)        kfree(short_name);
-                if (new_efivar)        kfree(new_efivar);
+                kfree(short_name);
+                kfree(new_efivar);
                 return 1;
         }
         memset(short_name, 0, short_name_size+1);
@@ -644,7 +644,8 @@ efivar_create_sysfs_entry(unsigned long variable_name_size,
         kobj_set_kset_s(new_efivar, vars_subsys);
         kobject_register(&new_efivar->kobj);
 
-        kfree(short_name); short_name = NULL;
+        kfree(short_name);
+        short_name = NULL;
 
         spin_lock(&efivars_lock);
         list_add(&new_efivar->list, &efivar_list);