aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/firewire/fw-transaction.c
diff options
context:
space:
mode:
Diffstat (limited to 'drivers/firewire/fw-transaction.c')
-rw-r--r--drivers/firewire/fw-transaction.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/firewire/fw-transaction.c b/drivers/firewire/fw-transaction.c
index 4c1275f9a3b4..439a3e3ee2f0 100644
--- a/drivers/firewire/fw-transaction.c
+++ b/drivers/firewire/fw-transaction.c
@@ -56,7 +56,7 @@
56#define header_get_extended_tcode(q) (((q) >> 0) & 0xffff) 56#define header_get_extended_tcode(q) (((q) >> 0) & 0xffff)
57 57
58#define phy_config_gap_count(gap_count) (((gap_count) << 16) | (1 << 22)) 58#define phy_config_gap_count(gap_count) (((gap_count) << 16) | (1 << 22))
59#define phy_config_root_id(node_id) (((node_id) << 24) | (1 << 23)) 59#define phy_config_root_id(node_id) ((((node_id) & 0x3f) << 24) | (1 << 23))
60#define phy_identifier(id) ((id) << 30) 60#define phy_identifier(id) ((id) << 30)
61 61
62static void 62static void
@@ -123,7 +123,7 @@ fw_fill_packet(struct fw_packet *packet, int tcode, int tlabel,
123 header_retry(RETRY_X) | 123 header_retry(RETRY_X) |
124 header_tlabel(tlabel) | 124 header_tlabel(tlabel) |
125 header_tcode(tcode) | 125 header_tcode(tcode) |
126 header_destination(node_id | LOCAL_BUS); 126 header_destination(node_id);
127 packet->header[1] = 127 packet->header[1] =
128 header_offset_high(offset >> 32) | header_source(0); 128 header_offset_high(offset >> 32) | header_source(0);
129 packet->header[2] = 129 packet->header[2] =
@@ -190,7 +190,7 @@ fw_fill_packet(struct fw_packet *packet, int tcode, int tlabel,
190 * @param tcode the tcode for this transaction. Do not use 190 * @param tcode the tcode for this transaction. Do not use
191 * TCODE_LOCK_REQUEST directly, insted use TCODE_LOCK_MASK_SWAP 191 * TCODE_LOCK_REQUEST directly, insted use TCODE_LOCK_MASK_SWAP
192 * etc. to specify tcode and ext_tcode. 192 * etc. to specify tcode and ext_tcode.
193 * @param node_id the node_id of the destination node 193 * @param node_id the destination node ID (bus ID and PHY ID concatenated)
194 * @param generation the generation for which node_id is valid 194 * @param generation the generation for which node_id is valid
195 * @param speed the speed to use for sending the request 195 * @param speed the speed to use for sending the request
196 * @param offset the 48 bit offset on the destination node 196 * @param offset the 48 bit offset on the destination node