diff options
Diffstat (limited to 'drivers/edac')
-rw-r--r-- | drivers/edac/amd64_edac.c | 66 |
1 files changed, 45 insertions, 21 deletions
diff --git a/drivers/edac/amd64_edac.c b/drivers/edac/amd64_edac.c index f943ad89849f..4e551e63b6dc 100644 --- a/drivers/edac/amd64_edac.c +++ b/drivers/edac/amd64_edac.c | |||
@@ -2741,30 +2741,53 @@ static void amd64_restore_ecc_error_reporting(struct amd64_pvt *pvt) | |||
2741 | wrmsr_on_cpus(cpumask, K8_MSR_MCGCTL, msrs); | 2741 | wrmsr_on_cpus(cpumask, K8_MSR_MCGCTL, msrs); |
2742 | } | 2742 | } |
2743 | 2743 | ||
2744 | static void check_mcg_ctl(void *ret) | 2744 | /* get all cores on this DCT */ |
2745 | static void get_cpus_on_this_dct_cpumask(cpumask_t *mask, int nid) | ||
2745 | { | 2746 | { |
2746 | u64 msr_val = 0; | 2747 | int cpu; |
2747 | u8 nbe; | ||
2748 | 2748 | ||
2749 | rdmsrl(MSR_IA32_MCG_CTL, msr_val); | 2749 | for_each_online_cpu(cpu) |
2750 | nbe = msr_val & K8_MSR_MCGCTL_NBE; | 2750 | if (amd_get_nb_id(cpu) == nid) |
2751 | 2751 | cpumask_set_cpu(cpu, mask); | |
2752 | debugf0("core: %u, MCG_CTL: 0x%llx, NB MSR is %s\n", | ||
2753 | raw_smp_processor_id(), msr_val, | ||
2754 | (nbe ? "enabled" : "disabled")); | ||
2755 | |||
2756 | if (!nbe) | ||
2757 | *(int *)ret = 0; | ||
2758 | } | 2752 | } |
2759 | 2753 | ||
2760 | /* check MCG_CTL on all the cpus on this node */ | 2754 | /* check MCG_CTL on all the cpus on this node */ |
2761 | static int mcg_ctl_enabled_on_node(const struct cpumask *mask) | 2755 | static bool amd64_nb_mce_bank_enabled_on_node(int nid) |
2762 | { | 2756 | { |
2763 | int ret = 1; | 2757 | cpumask_t mask; |
2764 | preempt_disable(); | 2758 | struct msr *msrs; |
2765 | smp_call_function_many(mask, check_mcg_ctl, &ret, 1); | 2759 | int cpu, nbe, idx = 0; |
2766 | preempt_enable(); | 2760 | bool ret = false; |
2761 | |||
2762 | cpumask_clear(&mask); | ||
2763 | |||
2764 | get_cpus_on_this_dct_cpumask(&mask, nid); | ||
2765 | |||
2766 | msrs = kzalloc(sizeof(struct msr) * cpumask_weight(&mask), GFP_KERNEL); | ||
2767 | if (!msrs) { | ||
2768 | amd64_printk(KERN_WARNING, "%s: error allocating msrs\n", | ||
2769 | __func__); | ||
2770 | return false; | ||
2771 | } | ||
2772 | |||
2773 | rdmsr_on_cpus(&mask, MSR_IA32_MCG_CTL, msrs); | ||
2774 | |||
2775 | for_each_cpu(cpu, &mask) { | ||
2776 | nbe = msrs[idx].l & K8_MSR_MCGCTL_NBE; | ||
2777 | |||
2778 | debugf0("core: %u, MCG_CTL: 0x%llx, NB MSR is %s\n", | ||
2779 | cpu, msrs[idx].q, | ||
2780 | (nbe ? "enabled" : "disabled")); | ||
2781 | |||
2782 | if (!nbe) | ||
2783 | goto out; | ||
2784 | |||
2785 | idx++; | ||
2786 | } | ||
2787 | ret = true; | ||
2767 | 2788 | ||
2789 | out: | ||
2790 | kfree(msrs); | ||
2768 | return ret; | 2791 | return ret; |
2769 | } | 2792 | } |
2770 | 2793 | ||
@@ -2783,7 +2806,8 @@ static int amd64_check_ecc_enabled(struct amd64_pvt *pvt) | |||
2783 | { | 2806 | { |
2784 | u32 value; | 2807 | u32 value; |
2785 | int err = 0; | 2808 | int err = 0; |
2786 | u8 ecc_enabled = 0, mcg_ctl_en = 0; | 2809 | u8 ecc_enabled = 0; |
2810 | bool nb_mce_en = false; | ||
2787 | 2811 | ||
2788 | err = pci_read_config_dword(pvt->misc_f3_ctl, K8_NBCFG, &value); | 2812 | err = pci_read_config_dword(pvt->misc_f3_ctl, K8_NBCFG, &value); |
2789 | if (err) | 2813 | if (err) |
@@ -2797,13 +2821,13 @@ static int amd64_check_ecc_enabled(struct amd64_pvt *pvt) | |||
2797 | else | 2821 | else |
2798 | amd64_printk(KERN_INFO, "ECC is enabled by BIOS.\n"); | 2822 | amd64_printk(KERN_INFO, "ECC is enabled by BIOS.\n"); |
2799 | 2823 | ||
2800 | mcg_ctl_en = mcg_ctl_enabled_on_node(cpumask_of_node(pvt->mc_node_id)); | 2824 | nb_mce_en = amd64_nb_mce_bank_enabled_on_node(pvt->mc_node_id); |
2801 | if (!mcg_ctl_en) | 2825 | if (!nb_mce_en) |
2802 | amd64_printk(KERN_WARNING, "NB MCE bank disabled, set MSR " | 2826 | amd64_printk(KERN_WARNING, "NB MCE bank disabled, set MSR " |
2803 | "0x%08x[4] on node %d to enable.\n", | 2827 | "0x%08x[4] on node %d to enable.\n", |
2804 | MSR_IA32_MCG_CTL, pvt->mc_node_id); | 2828 | MSR_IA32_MCG_CTL, pvt->mc_node_id); |
2805 | 2829 | ||
2806 | if (!ecc_enabled || !mcg_ctl_en) { | 2830 | if (!ecc_enabled || !nb_mce_en) { |
2807 | if (!ecc_enable_override) { | 2831 | if (!ecc_enable_override) { |
2808 | amd64_printk(KERN_WARNING, "%s", ecc_warning); | 2832 | amd64_printk(KERN_WARNING, "%s", ecc_warning); |
2809 | return -ENODEV; | 2833 | return -ENODEV; |