diff options
Diffstat (limited to 'drivers/edac/edac_pci_sysfs.c')
-rw-r--r-- | drivers/edac/edac_pci_sysfs.c | 48 |
1 files changed, 24 insertions, 24 deletions
diff --git a/drivers/edac/edac_pci_sysfs.c b/drivers/edac/edac_pci_sysfs.c index 6678216a7cbc..e164c555a337 100644 --- a/drivers/edac/edac_pci_sysfs.c +++ b/drivers/edac/edac_pci_sysfs.c | |||
@@ -78,7 +78,7 @@ static void edac_pci_instance_release(struct kobject *kobj) | |||
78 | { | 78 | { |
79 | struct edac_pci_ctl_info *pci; | 79 | struct edac_pci_ctl_info *pci; |
80 | 80 | ||
81 | debugf0("\n"); | 81 | edac_dbg(0, "\n"); |
82 | 82 | ||
83 | /* Form pointer to containing struct, the pci control struct */ | 83 | /* Form pointer to containing struct, the pci control struct */ |
84 | pci = to_instance(kobj); | 84 | pci = to_instance(kobj); |
@@ -161,7 +161,7 @@ static int edac_pci_create_instance_kobj(struct edac_pci_ctl_info *pci, int idx) | |||
161 | struct kobject *main_kobj; | 161 | struct kobject *main_kobj; |
162 | int err; | 162 | int err; |
163 | 163 | ||
164 | debugf0("\n"); | 164 | edac_dbg(0, "\n"); |
165 | 165 | ||
166 | /* First bump the ref count on the top main kobj, which will | 166 | /* First bump the ref count on the top main kobj, which will |
167 | * track the number of PCI instances we have, and thus nest | 167 | * track the number of PCI instances we have, and thus nest |
@@ -177,14 +177,13 @@ static int edac_pci_create_instance_kobj(struct edac_pci_ctl_info *pci, int idx) | |||
177 | err = kobject_init_and_add(&pci->kobj, &ktype_pci_instance, | 177 | err = kobject_init_and_add(&pci->kobj, &ktype_pci_instance, |
178 | edac_pci_top_main_kobj, "pci%d", idx); | 178 | edac_pci_top_main_kobj, "pci%d", idx); |
179 | if (err != 0) { | 179 | if (err != 0) { |
180 | debugf2("failed to register instance pci%d\n", | 180 | edac_dbg(2, "failed to register instance pci%d\n", idx); |
181 | idx); | ||
182 | kobject_put(edac_pci_top_main_kobj); | 181 | kobject_put(edac_pci_top_main_kobj); |
183 | goto error_out; | 182 | goto error_out; |
184 | } | 183 | } |
185 | 184 | ||
186 | kobject_uevent(&pci->kobj, KOBJ_ADD); | 185 | kobject_uevent(&pci->kobj, KOBJ_ADD); |
187 | debugf1("Register instance 'pci%d' kobject\n", idx); | 186 | edac_dbg(1, "Register instance 'pci%d' kobject\n", idx); |
188 | 187 | ||
189 | return 0; | 188 | return 0; |
190 | 189 | ||
@@ -201,7 +200,7 @@ error_out: | |||
201 | static void edac_pci_unregister_sysfs_instance_kobj( | 200 | static void edac_pci_unregister_sysfs_instance_kobj( |
202 | struct edac_pci_ctl_info *pci) | 201 | struct edac_pci_ctl_info *pci) |
203 | { | 202 | { |
204 | debugf0("\n"); | 203 | edac_dbg(0, "\n"); |
205 | 204 | ||
206 | /* Unregister the instance kobject and allow its release | 205 | /* Unregister the instance kobject and allow its release |
207 | * function release the main reference count and then | 206 | * function release the main reference count and then |
@@ -317,7 +316,7 @@ static struct edac_pci_dev_attribute *edac_pci_attr[] = { | |||
317 | */ | 316 | */ |
318 | static void edac_pci_release_main_kobj(struct kobject *kobj) | 317 | static void edac_pci_release_main_kobj(struct kobject *kobj) |
319 | { | 318 | { |
320 | debugf0("here to module_put(THIS_MODULE)\n"); | 319 | edac_dbg(0, "here to module_put(THIS_MODULE)\n"); |
321 | 320 | ||
322 | kfree(kobj); | 321 | kfree(kobj); |
323 | 322 | ||
@@ -345,7 +344,7 @@ static int edac_pci_main_kobj_setup(void) | |||
345 | int err; | 344 | int err; |
346 | struct bus_type *edac_subsys; | 345 | struct bus_type *edac_subsys; |
347 | 346 | ||
348 | debugf0("\n"); | 347 | edac_dbg(0, "\n"); |
349 | 348 | ||
350 | /* check and count if we have already created the main kobject */ | 349 | /* check and count if we have already created the main kobject */ |
351 | if (atomic_inc_return(&edac_pci_sysfs_refcount) != 1) | 350 | if (atomic_inc_return(&edac_pci_sysfs_refcount) != 1) |
@@ -356,7 +355,7 @@ static int edac_pci_main_kobj_setup(void) | |||
356 | */ | 355 | */ |
357 | edac_subsys = edac_get_sysfs_subsys(); | 356 | edac_subsys = edac_get_sysfs_subsys(); |
358 | if (edac_subsys == NULL) { | 357 | if (edac_subsys == NULL) { |
359 | debugf1("no edac_subsys\n"); | 358 | edac_dbg(1, "no edac_subsys\n"); |
360 | err = -ENODEV; | 359 | err = -ENODEV; |
361 | goto decrement_count_fail; | 360 | goto decrement_count_fail; |
362 | } | 361 | } |
@@ -366,14 +365,14 @@ static int edac_pci_main_kobj_setup(void) | |||
366 | * level main kobj for EDAC PCI | 365 | * level main kobj for EDAC PCI |
367 | */ | 366 | */ |
368 | if (!try_module_get(THIS_MODULE)) { | 367 | if (!try_module_get(THIS_MODULE)) { |
369 | debugf1("try_module_get() failed\n"); | 368 | edac_dbg(1, "try_module_get() failed\n"); |
370 | err = -ENODEV; | 369 | err = -ENODEV; |
371 | goto mod_get_fail; | 370 | goto mod_get_fail; |
372 | } | 371 | } |
373 | 372 | ||
374 | edac_pci_top_main_kobj = kzalloc(sizeof(struct kobject), GFP_KERNEL); | 373 | edac_pci_top_main_kobj = kzalloc(sizeof(struct kobject), GFP_KERNEL); |
375 | if (!edac_pci_top_main_kobj) { | 374 | if (!edac_pci_top_main_kobj) { |
376 | debugf1("Failed to allocate\n"); | 375 | edac_dbg(1, "Failed to allocate\n"); |
377 | err = -ENOMEM; | 376 | err = -ENOMEM; |
378 | goto kzalloc_fail; | 377 | goto kzalloc_fail; |
379 | } | 378 | } |
@@ -383,7 +382,7 @@ static int edac_pci_main_kobj_setup(void) | |||
383 | &ktype_edac_pci_main_kobj, | 382 | &ktype_edac_pci_main_kobj, |
384 | &edac_subsys->dev_root->kobj, "pci"); | 383 | &edac_subsys->dev_root->kobj, "pci"); |
385 | if (err) { | 384 | if (err) { |
386 | debugf1("Failed to register '.../edac/pci'\n"); | 385 | edac_dbg(1, "Failed to register '.../edac/pci'\n"); |
387 | goto kobject_init_and_add_fail; | 386 | goto kobject_init_and_add_fail; |
388 | } | 387 | } |
389 | 388 | ||
@@ -392,7 +391,7 @@ static int edac_pci_main_kobj_setup(void) | |||
392 | * must be used, for resources to be cleaned up properly | 391 | * must be used, for resources to be cleaned up properly |
393 | */ | 392 | */ |
394 | kobject_uevent(edac_pci_top_main_kobj, KOBJ_ADD); | 393 | kobject_uevent(edac_pci_top_main_kobj, KOBJ_ADD); |
395 | debugf1("Registered '.../edac/pci' kobject\n"); | 394 | edac_dbg(1, "Registered '.../edac/pci' kobject\n"); |
396 | 395 | ||
397 | return 0; | 396 | return 0; |
398 | 397 | ||
@@ -421,14 +420,14 @@ decrement_count_fail: | |||
421 | */ | 420 | */ |
422 | static void edac_pci_main_kobj_teardown(void) | 421 | static void edac_pci_main_kobj_teardown(void) |
423 | { | 422 | { |
424 | debugf0("\n"); | 423 | edac_dbg(0, "\n"); |
425 | 424 | ||
426 | /* Decrement the count and only if no more controller instances | 425 | /* Decrement the count and only if no more controller instances |
427 | * are connected perform the unregisteration of the top level | 426 | * are connected perform the unregisteration of the top level |
428 | * main kobj | 427 | * main kobj |
429 | */ | 428 | */ |
430 | if (atomic_dec_return(&edac_pci_sysfs_refcount) == 0) { | 429 | if (atomic_dec_return(&edac_pci_sysfs_refcount) == 0) { |
431 | debugf0("called kobject_put on main kobj\n"); | 430 | edac_dbg(0, "called kobject_put on main kobj\n"); |
432 | kobject_put(edac_pci_top_main_kobj); | 431 | kobject_put(edac_pci_top_main_kobj); |
433 | } | 432 | } |
434 | edac_put_sysfs_subsys(); | 433 | edac_put_sysfs_subsys(); |
@@ -445,7 +444,7 @@ int edac_pci_create_sysfs(struct edac_pci_ctl_info *pci) | |||
445 | int err; | 444 | int err; |
446 | struct kobject *edac_kobj = &pci->kobj; | 445 | struct kobject *edac_kobj = &pci->kobj; |
447 | 446 | ||
448 | debugf0("idx=%d\n", pci->pci_idx); | 447 | edac_dbg(0, "idx=%d\n", pci->pci_idx); |
449 | 448 | ||
450 | /* create the top main EDAC PCI kobject, IF needed */ | 449 | /* create the top main EDAC PCI kobject, IF needed */ |
451 | err = edac_pci_main_kobj_setup(); | 450 | err = edac_pci_main_kobj_setup(); |
@@ -459,8 +458,7 @@ int edac_pci_create_sysfs(struct edac_pci_ctl_info *pci) | |||
459 | 458 | ||
460 | err = sysfs_create_link(edac_kobj, &pci->dev->kobj, EDAC_PCI_SYMLINK); | 459 | err = sysfs_create_link(edac_kobj, &pci->dev->kobj, EDAC_PCI_SYMLINK); |
461 | if (err) { | 460 | if (err) { |
462 | debugf0("sysfs_create_link() returned err= %d\n", | 461 | edac_dbg(0, "sysfs_create_link() returned err= %d\n", err); |
463 | err); | ||
464 | goto symlink_fail; | 462 | goto symlink_fail; |
465 | } | 463 | } |
466 | 464 | ||
@@ -483,7 +481,7 @@ unregister_cleanup: | |||
483 | */ | 481 | */ |
484 | void edac_pci_remove_sysfs(struct edac_pci_ctl_info *pci) | 482 | void edac_pci_remove_sysfs(struct edac_pci_ctl_info *pci) |
485 | { | 483 | { |
486 | debugf0("index=%d\n", pci->pci_idx); | 484 | edac_dbg(0, "index=%d\n", pci->pci_idx); |
487 | 485 | ||
488 | /* Remove the symlink */ | 486 | /* Remove the symlink */ |
489 | sysfs_remove_link(&pci->kobj, EDAC_PCI_SYMLINK); | 487 | sysfs_remove_link(&pci->kobj, EDAC_PCI_SYMLINK); |
@@ -495,7 +493,7 @@ void edac_pci_remove_sysfs(struct edac_pci_ctl_info *pci) | |||
495 | * if this 'pci' is the last instance. | 493 | * if this 'pci' is the last instance. |
496 | * If it is, the main kobject will be unregistered as a result | 494 | * If it is, the main kobject will be unregistered as a result |
497 | */ | 495 | */ |
498 | debugf0("calling edac_pci_main_kobj_teardown()\n"); | 496 | edac_dbg(0, "calling edac_pci_main_kobj_teardown()\n"); |
499 | edac_pci_main_kobj_teardown(); | 497 | edac_pci_main_kobj_teardown(); |
500 | } | 498 | } |
501 | 499 | ||
@@ -571,7 +569,7 @@ static void edac_pci_dev_parity_test(struct pci_dev *dev) | |||
571 | 569 | ||
572 | local_irq_restore(flags); | 570 | local_irq_restore(flags); |
573 | 571 | ||
574 | debugf4("PCI STATUS= 0x%04x %s\n", status, dev_name(&dev->dev)); | 572 | edac_dbg(4, "PCI STATUS= 0x%04x %s\n", status, dev_name(&dev->dev)); |
575 | 573 | ||
576 | /* check the status reg for errors on boards NOT marked as broken | 574 | /* check the status reg for errors on boards NOT marked as broken |
577 | * if broken, we cannot trust any of the status bits | 575 | * if broken, we cannot trust any of the status bits |
@@ -602,13 +600,15 @@ static void edac_pci_dev_parity_test(struct pci_dev *dev) | |||
602 | } | 600 | } |
603 | 601 | ||
604 | 602 | ||
605 | debugf4("PCI HEADER TYPE= 0x%02x %s\n", header_type, dev_name(&dev->dev)); | 603 | edac_dbg(4, "PCI HEADER TYPE= 0x%02x %s\n", |
604 | header_type, dev_name(&dev->dev)); | ||
606 | 605 | ||
607 | if ((header_type & 0x7F) == PCI_HEADER_TYPE_BRIDGE) { | 606 | if ((header_type & 0x7F) == PCI_HEADER_TYPE_BRIDGE) { |
608 | /* On bridges, need to examine secondary status register */ | 607 | /* On bridges, need to examine secondary status register */ |
609 | status = get_pci_parity_status(dev, 1); | 608 | status = get_pci_parity_status(dev, 1); |
610 | 609 | ||
611 | debugf4("PCI SEC_STATUS= 0x%04x %s\n", status, dev_name(&dev->dev)); | 610 | edac_dbg(4, "PCI SEC_STATUS= 0x%04x %s\n", |
611 | status, dev_name(&dev->dev)); | ||
612 | 612 | ||
613 | /* check the secondary status reg for errors, | 613 | /* check the secondary status reg for errors, |
614 | * on NOT broken boards | 614 | * on NOT broken boards |
@@ -670,7 +670,7 @@ void edac_pci_do_parity_check(void) | |||
670 | { | 670 | { |
671 | int before_count; | 671 | int before_count; |
672 | 672 | ||
673 | debugf3("\n"); | 673 | edac_dbg(3, "\n"); |
674 | 674 | ||
675 | /* if policy has PCI check off, leave now */ | 675 | /* if policy has PCI check off, leave now */ |
676 | if (!check_pci_errors) | 676 | if (!check_pci_errors) |