1 files changed, 23 insertions, 22 deletions

diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c
index 2cd36b9297f3..bcb9a6d0ae11 100644
--- a/drivers/cpufreq/intel_pstate.c
+++ b/drivers/cpufreq/intel_pstate.c
@@ -99,8 +99,7 @@ struct cpudata {
         u64     prev_aperf;
         u64     prev_mperf;
         unsigned long long prev_tsc;
-        int     sample_ptr;
-        struct sample samples[SAMPLE_COUNT];
+        struct sample sample;
 };
 
 static struct cpudata **all_cpu_data;
@@ -154,7 +153,7 @@ static inline void pid_reset(struct _pid *pid, int setpoint, int busy,
         pid->setpoint = setpoint;
         pid->deadband  = deadband;
         pid->integral  = int_tofp(integral);
-        pid->last_err  = setpoint - busy;
+        pid->last_err  = int_tofp(setpoint) - int_tofp(busy);
 }
 
 static inline void pid_p_gain_set(struct _pid *pid, int percent)
@@ -447,7 +446,7 @@ static void core_set_pstate(struct cpudata *cpudata, int pstate)
         if (limits.no_turbo)
                 val |= (u64)1 << 32;
 
-        wrmsrl(MSR_IA32_PERF_CTL, val);
+        wrmsrl_on_cpu(cpudata->cpu, MSR_IA32_PERF_CTL, val);
 }
 
 static struct cpu_defaults core_params = {
@@ -586,15 +585,14 @@ static inline void intel_pstate_sample(struct cpudata *cpu)
         mperf = mperf >> FRAC_BITS;
         tsc = tsc >> FRAC_BITS;
 
-        cpu->sample_ptr = (cpu->sample_ptr + 1) % SAMPLE_COUNT;
-        cpu->samples[cpu->sample_ptr].aperf = aperf;
-        cpu->samples[cpu->sample_ptr].mperf = mperf;
-        cpu->samples[cpu->sample_ptr].tsc = tsc;
-        cpu->samples[cpu->sample_ptr].aperf -= cpu->prev_aperf;
-        cpu->samples[cpu->sample_ptr].mperf -= cpu->prev_mperf;
-        cpu->samples[cpu->sample_ptr].tsc -= cpu->prev_tsc;
+        cpu->sample.aperf = aperf;
+        cpu->sample.mperf = mperf;
+        cpu->sample.tsc = tsc;
+        cpu->sample.aperf -= cpu->prev_aperf;
+        cpu->sample.mperf -= cpu->prev_mperf;
+        cpu->sample.tsc -= cpu->prev_tsc;
 
-        intel_pstate_calc_busy(cpu, &cpu->samples[cpu->sample_ptr]);
+        intel_pstate_calc_busy(cpu, &cpu->sample);
 
         cpu->prev_aperf = aperf;
         cpu->prev_mperf = mperf;
@@ -614,7 +612,7 @@ static inline int32_t intel_pstate_get_scaled_busy(struct cpudata *cpu)
 {
         int32_t core_busy, max_pstate, current_pstate;
 
-        core_busy = cpu->samples[cpu->sample_ptr].core_pct_busy;
+        core_busy = cpu->sample.core_pct_busy;
         max_pstate = int_tofp(cpu->pstate.max_pstate);
         current_pstate = int_tofp(cpu->pstate.current_pstate);
         core_busy = mul_fp(core_busy, div_fp(max_pstate, current_pstate));
@@ -648,7 +646,7 @@ static void intel_pstate_timer_func(unsigned long __data)
 
         intel_pstate_sample(cpu);
 
-        sample = &cpu->samples[cpu->sample_ptr];
+        sample = &cpu->sample;
 
         intel_pstate_adjust_busy_pstate(cpu);
 
@@ -729,7 +727,7 @@ static unsigned int intel_pstate_get(unsigned int cpu_num)
         cpu = all_cpu_data[cpu_num];
         if (!cpu)
                 return 0;
-        sample = &cpu->samples[cpu->sample_ptr];
+        sample = &cpu->sample;
         return sample->freq;
 }
 
@@ -773,14 +771,17 @@ static int intel_pstate_verify_policy(struct cpufreq_policy *policy)
         return 0;
 }
 
-static int intel_pstate_cpu_exit(struct cpufreq_policy *policy)
+static void intel_pstate_stop_cpu(struct cpufreq_policy *policy)
 {
-        int cpu = policy->cpu;
+        int cpu_num = policy->cpu;
+        struct cpudata *cpu = all_cpu_data[cpu_num];
 
-        del_timer(&all_cpu_data[cpu]->timer);
-        kfree(all_cpu_data[cpu]);
-        all_cpu_data[cpu] = NULL;
-        return 0;
+        pr_info("intel_pstate CPU %d exiting\n", cpu_num);
+
+        del_timer(&all_cpu_data[cpu_num]->timer);
+        intel_pstate_set_pstate(cpu, cpu->pstate.min_pstate);
+        kfree(all_cpu_data[cpu_num]);
+        all_cpu_data[cpu_num] = NULL;
 }
 
 static int intel_pstate_cpu_init(struct cpufreq_policy *policy)
@@ -818,7 +819,7 @@ static struct cpufreq_driver intel_pstate_driver = {
         .setpolicy      = intel_pstate_set_policy,
         .get            = intel_pstate_get,
         .init           = intel_pstate_cpu_init,
-        .exit           = intel_pstate_cpu_exit,
+        .stop_cpu       = intel_pstate_stop_cpu,
         .name           = "intel_pstate",
 };