5 files changed, 27 insertions, 27 deletions

diff --git a/drivers/char/n_tty.c b/drivers/char/n_tty.c
index 94a5d5020abc..ff47907ff1bf 100644
--- a/drivers/char/n_tty.c
+++ b/drivers/char/n_tty.c
@@ -1331,9 +1331,6 @@ handle_newline:
 
 static void n_tty_write_wakeup(struct tty_struct *tty)
 {
-        /* Write out any echoed characters that are still pending */
-        process_echoes(tty);
-
         if (tty->fasync && test_and_clear_bit(TTY_DO_WRITE_WAKEUP, &tty->flags))
                 kill_fasync(&tty->fasync, SIGIO, POLL_OUT);
 }
diff --git a/drivers/char/nozomi.c b/drivers/char/nozomi.c
index 574f1c79b6e6..280b41c507a7 100644
--- a/drivers/char/nozomi.c
+++ b/drivers/char/nozomi.c
@@ -828,7 +828,7 @@ static int receive_data(enum port_type index, struct nozomi *dc)
         struct port *port = &dc->port[index];
         void __iomem *addr = port->dl_addr[port->toggle_dl];
         struct tty_struct *tty = tty_port_tty_get(&port->port);
-        int i;
+        int i, ret;
 
         if (unlikely(!tty)) {
                 DBG1("tty not open for port: %d?", index);
@@ -844,12 +844,14 @@ static int receive_data(enum port_type index, struct nozomi *dc)
 
                 /* disable interrupt in downlink... */
                 disable_transmit_dl(index, dc);
-                return 0;
+                ret = 0;
+                goto put;
         }
 
         if (unlikely(size == 0)) {
                 dev_err(&dc->pdev->dev, "size == 0?\n");
-                return 1;
+                ret = 1;
+                goto put;
         }
 
         tty_buffer_request_room(tty, size);
@@ -871,8 +873,10 @@ static int receive_data(enum port_type index, struct nozomi *dc)
         }
 
         set_bit(index, &dc->flip);
+        ret = 1;
+put:
         tty_kref_put(tty);
-        return 1;
+        return ret;
 }
 
 /* Debug for interrupts */
diff --git a/drivers/char/tty_ldisc.c b/drivers/char/tty_ldisc.c
index 0ef0dc97ba20..acd76b767d4c 100644
--- a/drivers/char/tty_ldisc.c
+++ b/drivers/char/tty_ldisc.c
@@ -790,17 +790,20 @@ void tty_ldisc_hangup(struct tty_struct *tty)
          * N_TTY.
          */
         if (tty->driver->flags & TTY_DRIVER_RESET_TERMIOS) {
-                /* Avoid racing set_ldisc */
+                /* Avoid racing set_ldisc or tty_ldisc_release */
                 mutex_lock(&tty->ldisc_mutex);
-                /* Switch back to N_TTY */
-                tty_ldisc_halt(tty);
-                tty_ldisc_wait_idle(tty);
-                tty_ldisc_reinit(tty);
-                /* At this point we have a closed ldisc and we want to
-                   reopen it. We could defer this to the next open but
-                   it means auditing a lot of other paths so this is a FIXME */
-                WARN_ON(tty_ldisc_open(tty, tty->ldisc));
-                tty_ldisc_enable(tty);
+                if (tty->ldisc) {       /* Not yet closed */
+                        /* Switch back to N_TTY */
+                        tty_ldisc_halt(tty);
+                        tty_ldisc_wait_idle(tty);
+                        tty_ldisc_reinit(tty);
+                        /* At this point we have a closed ldisc and we want to
+                           reopen it. We could defer this to the next open but
+                           it means auditing a lot of other paths so this is
+                           a FIXME */
+                        WARN_ON(tty_ldisc_open(tty, tty->ldisc));
+                        tty_ldisc_enable(tty);
+                }
                 mutex_unlock(&tty->ldisc_mutex);
                 tty_reset_termios(tty);
         }
@@ -865,6 +868,7 @@ void tty_ldisc_release(struct tty_struct *tty, struct tty_struct *o_tty)
 
         tty_ldisc_wait_idle(tty);
 
+        mutex_lock(&tty->ldisc_mutex);
         /*
          * Now kill off the ldisc
          */
@@ -875,6 +879,7 @@ void tty_ldisc_release(struct tty_struct *tty, struct tty_struct *o_tty)
 
         /* Ensure the next open requests the N_TTY ldisc */
         tty_set_termios_ldisc(tty, N_TTY);
+        mutex_unlock(&tty->ldisc_mutex);
 
         /* This will need doing differently if we need to lock */
         if (o_tty)
diff --git a/drivers/char/tty_port.c b/drivers/char/tty_port.c
index 4e862a75f7ff..9769b1149f76 100644
--- a/drivers/char/tty_port.c
+++ b/drivers/char/tty_port.c
@@ -267,7 +267,7 @@ int tty_port_block_til_ready(struct tty_port *port,
         if (retval == 0)
                 port->flags |= ASYNC_NORMAL_ACTIVE;
         spin_unlock_irqrestore(&port->lock, flags);
-        return 0;
+        return retval;
         
 }
 EXPORT_SYMBOL(tty_port_block_til_ready);
diff --git a/drivers/char/vt.c b/drivers/char/vt.c
index 7947bd1b4cf7..404f4c1ee431 100644
--- a/drivers/char/vt.c
+++ b/drivers/char/vt.c
@@ -770,14 +770,12 @@ int vc_allocate(unsigned int currcons)	/* return 0 on success */
             visual_init(vc, currcons, 1);
             if (!*vc->vc_uni_pagedir_loc)
                 con_set_default_unimap(vc);
-            if (!vc->vc_kmalloced)
-                vc->vc_screenbuf = kmalloc(vc->vc_screenbuf_size, GFP_KERNEL);
+            vc->vc_screenbuf = kmalloc(vc->vc_screenbuf_size, GFP_KERNEL);
             if (!vc->vc_screenbuf) {
                 kfree(vc);
                 vc_cons[currcons].d = NULL;
                 return -ENOMEM;
             }
-            vc->vc_kmalloced = 1;
             vc_init(vc, vc->vc_rows, vc->vc_cols, 1);
             vcs_make_sysfs(currcons);
             atomic_notifier_call_chain(&vt_notifier_list, VT_ALLOCATE, &param);
@@ -913,10 +911,8 @@ static int vc_do_resize(struct tty_struct *tty, struct vc_data *vc,
         if (new_scr_end > new_origin)
                 scr_memsetw((void *)new_origin, vc->vc_video_erase_char,
                             new_scr_end - new_origin);
-        if (vc->vc_kmalloced)
-                kfree(vc->vc_screenbuf);
+        kfree(vc->vc_screenbuf);
         vc->vc_screenbuf = newscreen;
-        vc->vc_kmalloced = 1;
         vc->vc_screenbuf_size = new_screen_size;
         set_origin(vc);
 
@@ -995,8 +991,7 @@ void vc_deallocate(unsigned int currcons)
                 vc->vc_sw->con_deinit(vc);
                 put_pid(vc->vt_pid);
                 module_put(vc->vc_sw->owner);
-                if (vc->vc_kmalloced)
-                        kfree(vc->vc_screenbuf);
+                kfree(vc->vc_screenbuf);
                 if (currcons >= MIN_NR_CONSOLES)
                         kfree(vc);
                 vc_cons[currcons].d = NULL;
@@ -2881,7 +2876,6 @@ static int __init con_init(void)
                 INIT_WORK(&vc_cons[currcons].SAK_work, vc_SAK);
                 visual_init(vc, currcons, 1);
                 vc->vc_screenbuf = kzalloc(vc->vc_screenbuf_size, GFP_NOWAIT);
-                vc->vc_kmalloced = 0;
                 vc_init(vc, vc->vc_rows, vc->vc_cols,
                         currcons || !vc->vc_sw->con_save_screen);
         }