aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/char/tty_ldisc.c
diff options
context:
space:
mode:
Diffstat (limited to 'drivers/char/tty_ldisc.c')
-rw-r--r--drivers/char/tty_ldisc.c12
1 files changed, 9 insertions, 3 deletions
diff --git a/drivers/char/tty_ldisc.c b/drivers/char/tty_ldisc.c
index d914e77f7f01..3f653f7d849f 100644
--- a/drivers/char/tty_ldisc.c
+++ b/drivers/char/tty_ldisc.c
@@ -445,8 +445,14 @@ static void tty_set_termios_ldisc(struct tty_struct *tty, int num)
445static int tty_ldisc_open(struct tty_struct *tty, struct tty_ldisc *ld) 445static int tty_ldisc_open(struct tty_struct *tty, struct tty_ldisc *ld)
446{ 446{
447 WARN_ON(test_and_set_bit(TTY_LDISC_OPEN, &tty->flags)); 447 WARN_ON(test_and_set_bit(TTY_LDISC_OPEN, &tty->flags));
448 if (ld->ops->open) 448 if (ld->ops->open) {
449 return ld->ops->open(tty); 449 int ret;
450 /* BKL here locks verus a hangup event */
451 lock_kernel();
452 ret = ld->ops->open(tty);
453 unlock_kernel();
454 return ret;
455 }
450 return 0; 456 return 0;
451} 457}
452 458
@@ -566,6 +572,7 @@ int tty_set_ldisc(struct tty_struct *tty, int ldisc)
566 return 0; 572 return 0;
567 } 573 }
568 574
575 unlock_kernel();
569 /* 576 /*
570 * Problem: What do we do if this blocks ? 577 * Problem: What do we do if this blocks ?
571 * We could deadlock here 578 * We could deadlock here
@@ -573,7 +580,6 @@ int tty_set_ldisc(struct tty_struct *tty, int ldisc)
573 580
574 tty_wait_until_sent(tty, 0); 581 tty_wait_until_sent(tty, 0);
575 582
576 unlock_kernel();
577 mutex_lock(&tty->ldisc_mutex); 583 mutex_lock(&tty->ldisc_mutex);
578 584
579 /* 585 /*