1 files changed, 8 insertions, 4 deletions

diff --git a/drivers/char/tpm/tpm.c b/drivers/char/tpm/tpm.c
index 5c843c9bf819..854475c54f0e 100644
--- a/drivers/char/tpm/tpm.c
+++ b/drivers/char/tpm/tpm.c
@@ -233,10 +233,10 @@ ssize_t tpm_show_pubek(struct device *dev, struct device_attribute *attr,
                     data[15], data[16], data[17], data[22], data[23],
                     data[24], data[25], data[26], data[27], data[28],
                     data[29], data[30], data[31], data[32], data[33],
-                    be32_to_cpu(*((__be32 *) (data + 32))));
+                    be32_to_cpu(*((__be32 *) (data + 34))));
 
         for (i = 0; i < 256; i++) {
-                str += sprintf(str, "%02X ", data[i + 39]);
+                str += sprintf(str, "%02X ", data[i + 38]);
                 if ((i + 1) % 16 == 0)
                         str += sprintf(str, "\n");
         }
@@ -464,6 +464,7 @@ void __devexit tpm_remove(struct pci_dev *pci_dev)
 
         pci_set_drvdata(pci_dev, NULL);
         misc_deregister(&chip->vendor->miscdev);
+        kfree(&chip->vendor->miscdev.name);
 
         sysfs_remove_group(&pci_dev->dev.kobj, chip->vendor->attr_group);
 
@@ -526,7 +527,9 @@ EXPORT_SYMBOL_GPL(tpm_pm_resume);
 int tpm_register_hardware(struct pci_dev *pci_dev,
                           struct tpm_vendor_specific *entry)
 {
-        char devname[7];
+#define DEVNAME_SIZE 7
+
+        char *devname;
         struct tpm_chip *chip;
         int i, j;
 
@@ -569,7 +572,8 @@ dev_num_search_complete:
         else
                 chip->vendor->miscdev.minor = MISC_DYNAMIC_MINOR;
 
-        snprintf(devname, sizeof(devname), "%s%d", "tpm", chip->dev_num);
+        devname = kmalloc(DEVNAME_SIZE, GFP_KERNEL);
+        scnprintf(devname, DEVNAME_SIZE, "%s%d", "tpm", chip->dev_num);
         chip->vendor->miscdev.name = devname;
 
         chip->vendor->miscdev.dev = &(pci_dev->dev);