1 files changed, 76 insertions, 26 deletions

diff --git a/drivers/char/tpm/tpm.c b/drivers/char/tpm/tpm.c
index 7beb0e25f1e1..caf8012ef47c 100644
--- a/drivers/char/tpm/tpm.c
+++ b/drivers/char/tpm/tpm.c
@@ -534,6 +534,7 @@ void tpm_get_timeouts(struct tpm_chip *chip)
         struct duration_t *duration_cap;
         ssize_t rc;
         u32 timeout;
+        unsigned int scale = 1;
 
         tpm_cmd.header.in = tpm_getcap_header;
         tpm_cmd.params.getcap_in.cap = TPM_CAP_PROP;
@@ -545,24 +546,30 @@ void tpm_get_timeouts(struct tpm_chip *chip)
         if (rc)
                 goto duration;
 
-        if (be32_to_cpu(tpm_cmd.header.out.length)
-            != 4 * sizeof(u32))
-                goto duration;
+        if (be32_to_cpu(tpm_cmd.header.out.return_code) != 0 ||
+            be32_to_cpu(tpm_cmd.header.out.length)
+            != sizeof(tpm_cmd.header.out) + sizeof(u32) + 4 * sizeof(u32))
+                return;
 
         timeout_cap = &tpm_cmd.params.getcap_out.cap.timeout;
         /* Don't overwrite default if value is 0 */
         timeout = be32_to_cpu(timeout_cap->a);
+        if (timeout && timeout < 1000) {
+                /* timeouts in msec rather usec */
+                scale = 1000;
+                chip->vendor.timeout_adjusted = true;
+        }
         if (timeout)
-                chip->vendor.timeout_a = usecs_to_jiffies(timeout);
+                chip->vendor.timeout_a = usecs_to_jiffies(timeout * scale);
         timeout = be32_to_cpu(timeout_cap->b);
         if (timeout)
-                chip->vendor.timeout_b = usecs_to_jiffies(timeout);
+                chip->vendor.timeout_b = usecs_to_jiffies(timeout * scale);
         timeout = be32_to_cpu(timeout_cap->c);
         if (timeout)
-                chip->vendor.timeout_c = usecs_to_jiffies(timeout);
+                chip->vendor.timeout_c = usecs_to_jiffies(timeout * scale);
         timeout = be32_to_cpu(timeout_cap->d);
         if (timeout)
-                chip->vendor.timeout_d = usecs_to_jiffies(timeout);
+                chip->vendor.timeout_d = usecs_to_jiffies(timeout * scale);
 
 duration:
         tpm_cmd.header.in = tpm_getcap_header;
@@ -575,23 +582,31 @@ duration:
         if (rc)
                 return;
 
-        if (be32_to_cpu(tpm_cmd.header.out.return_code)
-            != 3 * sizeof(u32))
+        if (be32_to_cpu(tpm_cmd.header.out.return_code) != 0 ||
+            be32_to_cpu(tpm_cmd.header.out.length)
+            != sizeof(tpm_cmd.header.out) + sizeof(u32) + 3 * sizeof(u32))
                 return;
+
         duration_cap = &tpm_cmd.params.getcap_out.cap.duration;
         chip->vendor.duration[TPM_SHORT] =
             usecs_to_jiffies(be32_to_cpu(duration_cap->tpm_short));
+        chip->vendor.duration[TPM_MEDIUM] =
+            usecs_to_jiffies(be32_to_cpu(duration_cap->tpm_medium));
+        chip->vendor.duration[TPM_LONG] =
+            usecs_to_jiffies(be32_to_cpu(duration_cap->tpm_long));
+
         /* The Broadcom BCM0102 chipset in a Dell Latitude D820 gets the above
          * value wrong and apparently reports msecs rather than usecs. So we
          * fix up the resulting too-small TPM_SHORT value to make things work.
+         * We also scale the TPM_MEDIUM and -_LONG values by 1000.
          */
-        if (chip->vendor.duration[TPM_SHORT] < (HZ/100))
+        if (chip->vendor.duration[TPM_SHORT] < (HZ / 100)) {
                 chip->vendor.duration[TPM_SHORT] = HZ;
-
-        chip->vendor.duration[TPM_MEDIUM] =
-            usecs_to_jiffies(be32_to_cpu(duration_cap->tpm_medium));
-        chip->vendor.duration[TPM_LONG] =
-            usecs_to_jiffies(be32_to_cpu(duration_cap->tpm_long));
+                chip->vendor.duration[TPM_MEDIUM] *= 1000;
+                chip->vendor.duration[TPM_LONG] *= 1000;
+                chip->vendor.duration_adjusted = true;
+                dev_info(chip->dev, "Adjusting TPM timeout parameters.");
+        }
 }
 EXPORT_SYMBOL_GPL(tpm_get_timeouts);
 
@@ -600,7 +615,7 @@ void tpm_continue_selftest(struct tpm_chip *chip)
         u8 data[] = {
                 0, 193,                 /* TPM_TAG_RQU_COMMAND */
                 0, 0, 0, 10,            /* length */
-                0, 0, 0, 83,            /* TPM_ORD_GetCapability */
+                0, 0, 0, 83,            /* TPM_ORD_ContinueSelfTest */
         };
 
         tpm_transmit(chip, data, sizeof(data));
@@ -863,18 +878,24 @@ ssize_t tpm_show_pubek(struct device *dev, struct device_attribute *attr,
         data = tpm_cmd.params.readpubek_out_buffer;
         str +=
             sprintf(str,
-                    "Algorithm: %02X %02X %02X %02X\nEncscheme: %02X %02X\n"
-                    "Sigscheme: %02X %02X\nParameters: %02X %02X %02X %02X"
-                    " %02X %02X %02X %02X %02X %02X %02X %02X\n"
-                    "Modulus length: %d\nModulus: \n",
-                    data[10], data[11], data[12], data[13], data[14],
-                    data[15], data[16], data[17], data[22], data[23],
-                    data[24], data[25], data[26], data[27], data[28],
-                    data[29], data[30], data[31], data[32], data[33],
-                    be32_to_cpu(*((__be32 *) (data + 34))));
+                    "Algorithm: %02X %02X %02X %02X\n"
+                    "Encscheme: %02X %02X\n"
+                    "Sigscheme: %02X %02X\n"
+                    "Parameters: %02X %02X %02X %02X "
+                    "%02X %02X %02X %02X "
+                    "%02X %02X %02X %02X\n"
+                    "Modulus length: %d\n"
+                    "Modulus:\n",
+                    data[0], data[1], data[2], data[3],
+                    data[4], data[5],
+                    data[6], data[7],
+                    data[12], data[13], data[14], data[15],
+                    data[16], data[17], data[18], data[19],
+                    data[20], data[21], data[22], data[23],
+                    be32_to_cpu(*((__be32 *) (data + 24))));
 
         for (i = 0; i < 256; i++) {
-                str += sprintf(str, "%02X ", data[i + 38]);
+                str += sprintf(str, "%02X ", data[i + 28]);
                 if ((i + 1) % 16 == 0)
                         str += sprintf(str, "\n");
         }
@@ -937,6 +958,35 @@ ssize_t tpm_show_caps_1_2(struct device * dev,
 }
 EXPORT_SYMBOL_GPL(tpm_show_caps_1_2);
 
+ssize_t tpm_show_durations(struct device *dev, struct device_attribute *attr,
+                          char *buf)
+{
+        struct tpm_chip *chip = dev_get_drvdata(dev);
+
+        return sprintf(buf, "%d %d %d [%s]\n",
+                       jiffies_to_usecs(chip->vendor.duration[TPM_SHORT]),
+                       jiffies_to_usecs(chip->vendor.duration[TPM_MEDIUM]),
+                       jiffies_to_usecs(chip->vendor.duration[TPM_LONG]),
+                       chip->vendor.duration_adjusted
+                       ? "adjusted" : "original");
+}
+EXPORT_SYMBOL_GPL(tpm_show_durations);
+
+ssize_t tpm_show_timeouts(struct device *dev, struct device_attribute *attr,
+                          char *buf)
+{
+        struct tpm_chip *chip = dev_get_drvdata(dev);
+
+        return sprintf(buf, "%d %d %d %d [%s]\n",
+                       jiffies_to_usecs(chip->vendor.timeout_a),
+                       jiffies_to_usecs(chip->vendor.timeout_b),
+                       jiffies_to_usecs(chip->vendor.timeout_c),
+                       jiffies_to_usecs(chip->vendor.timeout_d),
+                       chip->vendor.timeout_adjusted
+                       ? "adjusted" : "original");
+}
+EXPORT_SYMBOL_GPL(tpm_show_timeouts);
+
 ssize_t tpm_store_cancel(struct device *dev, struct device_attribute *attr,
                         const char *buf, size_t count)
 {