aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/char/pc8736x_gpio.c
diff options
context:
space:
mode:
Diffstat (limited to 'drivers/char/pc8736x_gpio.c')
-rw-r--r--drivers/char/pc8736x_gpio.c8
1 files changed, 4 insertions, 4 deletions
diff --git a/drivers/char/pc8736x_gpio.c b/drivers/char/pc8736x_gpio.c
index b8183d508332..72dcf222f141 100644
--- a/drivers/char/pc8736x_gpio.c
+++ b/drivers/char/pc8736x_gpio.c
@@ -16,6 +16,7 @@
16#include <linux/kernel.h> 16#include <linux/kernel.h>
17#include <linux/init.h> 17#include <linux/init.h>
18#include <linux/ioport.h> 18#include <linux/ioport.h>
19#include <linux/mutex.h>
19#include <linux/nsc_gpio.h> 20#include <linux/nsc_gpio.h>
20#include <linux/platform_device.h> 21#include <linux/platform_device.h>
21#include <asm/uaccess.h> 22#include <asm/uaccess.h>
@@ -31,7 +32,7 @@ static int major; /* default to dynamic major */
31module_param(major, int, 0); 32module_param(major, int, 0);
32MODULE_PARM_DESC(major, "Major device number"); 33MODULE_PARM_DESC(major, "Major device number");
33 34
34static DEFINE_SPINLOCK(pc8736x_gpio_config_lock); 35static DEFINE_MUTEX(pc8736x_gpio_config_lock);
35static unsigned pc8736x_gpio_base; 36static unsigned pc8736x_gpio_base;
36static u8 pc8736x_gpio_shadow[4]; 37static u8 pc8736x_gpio_shadow[4];
37 38
@@ -119,9 +120,8 @@ static inline u32 pc8736x_gpio_configure_fn(unsigned index, u32 mask, u32 bits,
119 u32 func_slct) 120 u32 func_slct)
120{ 121{
121 u32 config, new_config; 122 u32 config, new_config;
122 unsigned long flags;
123 123
124 spin_lock_irqsave(&pc8736x_gpio_config_lock, flags); 124 mutex_lock(&pc8736x_gpio_config_lock);
125 125
126 device_select(SIO_GPIO_UNIT); 126 device_select(SIO_GPIO_UNIT);
127 select_pin(index); 127 select_pin(index);
@@ -133,7 +133,7 @@ static inline u32 pc8736x_gpio_configure_fn(unsigned index, u32 mask, u32 bits,
133 new_config = (config & mask) | bits; 133 new_config = (config & mask) | bits;
134 superio_outb(func_slct, new_config); 134 superio_outb(func_slct, new_config);
135 135
136 spin_unlock_irqrestore(&pc8736x_gpio_config_lock, flags); 136 mutex_unlock(&pc8736x_gpio_config_lock);
137 137
138 return config; 138 return config;
139} 139}