aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/char/drm/via_dma.c
diff options
context:
space:
mode:
Diffstat (limited to 'drivers/char/drm/via_dma.c')
-rw-r--r--drivers/char/drm/via_dma.c40
1 files changed, 20 insertions, 20 deletions
diff --git a/drivers/char/drm/via_dma.c b/drivers/char/drm/via_dma.c
index 7ff2b623c2d4..2d0035f83a7b 100644
--- a/drivers/char/drm/via_dma.c
+++ b/drivers/char/drm/via_dma.c
@@ -175,24 +175,24 @@ static int via_initialize(struct drm_device * dev,
175{ 175{
176 if (!dev_priv || !dev_priv->mmio) { 176 if (!dev_priv || !dev_priv->mmio) {
177 DRM_ERROR("via_dma_init called before via_map_init\n"); 177 DRM_ERROR("via_dma_init called before via_map_init\n");
178 return DRM_ERR(EFAULT); 178 return -EFAULT;
179 } 179 }
180 180
181 if (dev_priv->ring.virtual_start != NULL) { 181 if (dev_priv->ring.virtual_start != NULL) {
182 DRM_ERROR("%s called again without calling cleanup\n", 182 DRM_ERROR("%s called again without calling cleanup\n",
183 __FUNCTION__); 183 __FUNCTION__);
184 return DRM_ERR(EFAULT); 184 return -EFAULT;
185 } 185 }
186 186
187 if (!dev->agp || !dev->agp->base) { 187 if (!dev->agp || !dev->agp->base) {
188 DRM_ERROR("%s called with no agp memory available\n", 188 DRM_ERROR("%s called with no agp memory available\n",
189 __FUNCTION__); 189 __FUNCTION__);
190 return DRM_ERR(EFAULT); 190 return -EFAULT;
191 } 191 }
192 192
193 if (dev_priv->chipset == VIA_DX9_0) { 193 if (dev_priv->chipset == VIA_DX9_0) {
194 DRM_ERROR("AGP DMA is not supported on this chip\n"); 194 DRM_ERROR("AGP DMA is not supported on this chip\n");
195 return DRM_ERR(EINVAL); 195 return -EINVAL;
196 } 196 }
197 197
198 dev_priv->ring.map.offset = dev->agp->base + init->offset; 198 dev_priv->ring.map.offset = dev->agp->base + init->offset;
@@ -207,7 +207,7 @@ static int via_initialize(struct drm_device * dev,
207 via_dma_cleanup(dev); 207 via_dma_cleanup(dev);
208 DRM_ERROR("can not ioremap virtual address for" 208 DRM_ERROR("can not ioremap virtual address for"
209 " ring buffer\n"); 209 " ring buffer\n");
210 return DRM_ERR(ENOMEM); 210 return -ENOMEM;
211 } 211 }
212 212
213 dev_priv->ring.virtual_start = dev_priv->ring.map.handle; 213 dev_priv->ring.virtual_start = dev_priv->ring.map.handle;
@@ -240,22 +240,22 @@ static int via_dma_init(DRM_IOCTL_ARGS)
240 switch (init.func) { 240 switch (init.func) {
241 case VIA_INIT_DMA: 241 case VIA_INIT_DMA:
242 if (!DRM_SUSER(DRM_CURPROC)) 242 if (!DRM_SUSER(DRM_CURPROC))
243 retcode = DRM_ERR(EPERM); 243 retcode = -EPERM;
244 else 244 else
245 retcode = via_initialize(dev, dev_priv, &init); 245 retcode = via_initialize(dev, dev_priv, &init);
246 break; 246 break;
247 case VIA_CLEANUP_DMA: 247 case VIA_CLEANUP_DMA:
248 if (!DRM_SUSER(DRM_CURPROC)) 248 if (!DRM_SUSER(DRM_CURPROC))
249 retcode = DRM_ERR(EPERM); 249 retcode = -EPERM;
250 else 250 else
251 retcode = via_dma_cleanup(dev); 251 retcode = via_dma_cleanup(dev);
252 break; 252 break;
253 case VIA_DMA_INITIALIZED: 253 case VIA_DMA_INITIALIZED:
254 retcode = (dev_priv->ring.virtual_start != NULL) ? 254 retcode = (dev_priv->ring.virtual_start != NULL) ?
255 0 : DRM_ERR(EFAULT); 255 0 : -EFAULT;
256 break; 256 break;
257 default: 257 default:
258 retcode = DRM_ERR(EINVAL); 258 retcode = -EINVAL;
259 break; 259 break;
260 } 260 }
261 261
@@ -273,15 +273,15 @@ static int via_dispatch_cmdbuffer(struct drm_device * dev, drm_via_cmdbuffer_t *
273 if (dev_priv->ring.virtual_start == NULL) { 273 if (dev_priv->ring.virtual_start == NULL) {
274 DRM_ERROR("%s called without initializing AGP ring buffer.\n", 274 DRM_ERROR("%s called without initializing AGP ring buffer.\n",
275 __FUNCTION__); 275 __FUNCTION__);
276 return DRM_ERR(EFAULT); 276 return -EFAULT;
277 } 277 }
278 278
279 if (cmd->size > VIA_PCI_BUF_SIZE) { 279 if (cmd->size > VIA_PCI_BUF_SIZE) {
280 return DRM_ERR(ENOMEM); 280 return -ENOMEM;
281 } 281 }
282 282
283 if (DRM_COPY_FROM_USER(dev_priv->pci_buf, cmd->buf, cmd->size)) 283 if (DRM_COPY_FROM_USER(dev_priv->pci_buf, cmd->buf, cmd->size))
284 return DRM_ERR(EFAULT); 284 return -EFAULT;
285 285
286 /* 286 /*
287 * Running this function on AGP memory is dead slow. Therefore 287 * Running this function on AGP memory is dead slow. Therefore
@@ -297,7 +297,7 @@ static int via_dispatch_cmdbuffer(struct drm_device * dev, drm_via_cmdbuffer_t *
297 297
298 vb = via_check_dma(dev_priv, (cmd->size < 0x100) ? 0x102 : cmd->size); 298 vb = via_check_dma(dev_priv, (cmd->size < 0x100) ? 0x102 : cmd->size);
299 if (vb == NULL) { 299 if (vb == NULL) {
300 return DRM_ERR(EAGAIN); 300 return -EAGAIN;
301 } 301 }
302 302
303 memcpy(vb, dev_priv->pci_buf, cmd->size); 303 memcpy(vb, dev_priv->pci_buf, cmd->size);
@@ -321,7 +321,7 @@ int via_driver_dma_quiescent(struct drm_device * dev)
321 drm_via_private_t *dev_priv = dev->dev_private; 321 drm_via_private_t *dev_priv = dev->dev_private;
322 322
323 if (!via_wait_idle(dev_priv)) { 323 if (!via_wait_idle(dev_priv)) {
324 return DRM_ERR(EBUSY); 324 return -EBUSY;
325 } 325 }
326 return 0; 326 return 0;
327} 327}
@@ -363,10 +363,10 @@ static int via_dispatch_pci_cmdbuffer(struct drm_device * dev,
363 int ret; 363 int ret;
364 364
365 if (cmd->size > VIA_PCI_BUF_SIZE) { 365 if (cmd->size > VIA_PCI_BUF_SIZE) {
366 return DRM_ERR(ENOMEM); 366 return -ENOMEM;
367 } 367 }
368 if (DRM_COPY_FROM_USER(dev_priv->pci_buf, cmd->buf, cmd->size)) 368 if (DRM_COPY_FROM_USER(dev_priv->pci_buf, cmd->buf, cmd->size))
369 return DRM_ERR(EFAULT); 369 return -EFAULT;
370 370
371 if ((ret = 371 if ((ret =
372 via_verify_command_stream((uint32_t *) dev_priv->pci_buf, 372 via_verify_command_stream((uint32_t *) dev_priv->pci_buf,
@@ -669,7 +669,7 @@ static int via_cmdbuf_size(DRM_IOCTL_ARGS)
669 if (dev_priv->ring.virtual_start == NULL) { 669 if (dev_priv->ring.virtual_start == NULL) {
670 DRM_ERROR("%s called without initializing AGP ring buffer.\n", 670 DRM_ERROR("%s called without initializing AGP ring buffer.\n",
671 __FUNCTION__); 671 __FUNCTION__);
672 return DRM_ERR(EFAULT); 672 return -EFAULT;
673 } 673 }
674 674
675 DRM_COPY_FROM_USER_IOCTL(d_siz, (drm_via_cmdbuf_size_t __user *) data, 675 DRM_COPY_FROM_USER_IOCTL(d_siz, (drm_via_cmdbuf_size_t __user *) data,
@@ -687,7 +687,7 @@ static int via_cmdbuf_size(DRM_IOCTL_ARGS)
687 } 687 }
688 if (!count) { 688 if (!count) {
689 DRM_ERROR("VIA_CMDBUF_SPACE timed out.\n"); 689 DRM_ERROR("VIA_CMDBUF_SPACE timed out.\n");
690 ret = DRM_ERR(EAGAIN); 690 ret = -EAGAIN;
691 } 691 }
692 break; 692 break;
693 case VIA_CMDBUF_LAG: 693 case VIA_CMDBUF_LAG:
@@ -699,11 +699,11 @@ static int via_cmdbuf_size(DRM_IOCTL_ARGS)
699 } 699 }
700 if (!count) { 700 if (!count) {
701 DRM_ERROR("VIA_CMDBUF_LAG timed out.\n"); 701 DRM_ERROR("VIA_CMDBUF_LAG timed out.\n");
702 ret = DRM_ERR(EAGAIN); 702 ret = -EAGAIN;
703 } 703 }
704 break; 704 break;
705 default: 705 default:
706 ret = DRM_ERR(EFAULT); 706 ret = -EFAULT;
707 } 707 }
708 d_siz.size = tmp_size; 708 d_siz.size = tmp_size;
709 709