2 files changed, 14 insertions, 14 deletions

diff --git a/drivers/bluetooth/hci_bcsp.c b/drivers/bluetooth/hci_bcsp.c
index 4d37bb312ee3..7938062c1cc7 100644
--- a/drivers/bluetooth/hci_bcsp.c
+++ b/drivers/bluetooth/hci_bcsp.c
@@ -352,14 +352,14 @@ static int bcsp_flush(struct hci_uart *hu)
 /* Remove ack'ed packets */
 static void bcsp_pkt_cull(struct bcsp_struct *bcsp)
 {
+        struct sk_buff *skb, *tmp;
         unsigned long flags;
-        struct sk_buff *skb;
         int i, pkts_to_be_removed;
         u8 seqno;
 
         spin_lock_irqsave(&bcsp->unack.lock, flags);
 
-        pkts_to_be_removed = bcsp->unack.qlen;
+        pkts_to_be_removed = skb_queue_len(&bcsp->unack);
         seqno = bcsp->msgq_txseq;
 
         while (pkts_to_be_removed) {
@@ -373,19 +373,19 @@ static void bcsp_pkt_cull(struct bcsp_struct *bcsp)
                 BT_ERR("Peer acked invalid packet");
 
         BT_DBG("Removing %u pkts out of %u, up to seqno %u",
-                pkts_to_be_removed, bcsp->unack.qlen, (seqno - 1) & 0x07);
+               pkts_to_be_removed, skb_queue_len(&bcsp->unack),
+               (seqno - 1) & 0x07);
 
-        for (i = 0, skb = ((struct sk_buff *) &bcsp->unack)->next; i < pkts_to_be_removed
-                        && skb != (struct sk_buff *) &bcsp->unack; i++) {
-                struct sk_buff *nskb;
+        i = 0;
+        skb_queue_walk_safe(&bcsp->unack, skb, tmp) {
+                if (i++ >= pkts_to_be_removed)
+                        break;
 
-                nskb = skb->next;
                 __skb_unlink(skb, &bcsp->unack);
                 kfree_skb(skb);
-                skb = nskb;
         }
 
-        if (bcsp->unack.qlen == 0)
+        if (skb_queue_empty(&bcsp->unack))
                 del_timer(&bcsp->tbcsp);
 
         spin_unlock_irqrestore(&bcsp->unack.lock, flags);
diff --git a/drivers/bluetooth/hci_usb.h b/drivers/bluetooth/hci_usb.h
index 1790cc8e431e..8e659914523f 100644
--- a/drivers/bluetooth/hci_usb.h
+++ b/drivers/bluetooth/hci_usb.h
@@ -70,8 +70,8 @@ static inline void _urb_queue_head(struct _urb_queue *q, struct _urb *_urb)
 {
         unsigned long flags;
         spin_lock_irqsave(&q->lock, flags);
-        /* _urb_unlink needs to know which spinlock to use, thus mb(). */
-        _urb->queue = q; mb(); list_add(&_urb->list, &q->head);
+        /* _urb_unlink needs to know which spinlock to use, thus smp_mb(). */
+        _urb->queue = q; smp_mb(); list_add(&_urb->list, &q->head);
         spin_unlock_irqrestore(&q->lock, flags);
 }
 
@@ -79,8 +79,8 @@ static inline void _urb_queue_tail(struct _urb_queue *q, struct _urb *_urb)
 {
         unsigned long flags;
         spin_lock_irqsave(&q->lock, flags);
-        /* _urb_unlink needs to know which spinlock to use, thus mb(). */
-        _urb->queue = q; mb(); list_add_tail(&_urb->list, &q->head);
+        /* _urb_unlink needs to know which spinlock to use, thus smp_mb(). */
+        _urb->queue = q; smp_mb(); list_add_tail(&_urb->list, &q->head);
         spin_unlock_irqrestore(&q->lock, flags);
 }
 
@@ -89,7 +89,7 @@ static inline void _urb_unlink(struct _urb *_urb)
         struct _urb_queue *q;
         unsigned long flags;
 
-        mb();
+        smp_mb();
         q = _urb->queue;
         /* If q is NULL, it will die at easy-to-debug NULL pointer dereference.
            No need to BUG(). */