4 files changed, 30 insertions, 33 deletions

diff --git a/drivers/block/amiflop.c b/drivers/block/amiflop.c
index 4b1d4ac960f1..8df436ff7068 100644
--- a/drivers/block/amiflop.c
+++ b/drivers/block/amiflop.c
@@ -156,7 +156,7 @@ static volatile int fdc_busy = -1;
 static volatile int fdc_nested;
 static DECLARE_WAIT_QUEUE_HEAD(fdc_wait);
  
-static DECLARE_WAIT_QUEUE_HEAD(motor_wait);
+static DECLARE_COMPLETION(motor_on_completion);
 
 static volatile int selected = -1;      /* currently selected drive */
 
@@ -184,8 +184,7 @@ static unsigned char mfmencode[16]={
 static unsigned char mfmdecode[128];
 
 /* floppy internal millisecond timer stuff */
-static volatile int ms_busy = -1;
-static DECLARE_WAIT_QUEUE_HEAD(ms_wait);
+static DECLARE_COMPLETION(ms_wait_completion);
 #define MS_TICKS ((amiga_eclock+50)/1000)
 
 /*
@@ -211,8 +210,7 @@ static int fd_device[4] = { 0, 0, 0, 0 };
 
 static irqreturn_t ms_isr(int irq, void *dummy)
 {
-        ms_busy = -1;
-        wake_up(&ms_wait);
+        complete(&ms_wait_completion);
         return IRQ_HANDLED;
 }
 
@@ -220,19 +218,17 @@ static irqreturn_t ms_isr(int irq, void *dummy)
    A more generic routine would do a schedule a la timer.device */
 static void ms_delay(int ms)
 {
-        unsigned long flags;
         int ticks;
+        static DEFINE_MUTEX(mutex);
+
         if (ms > 0) {
-                local_irq_save(flags);
-                while (ms_busy == 0)
-                        sleep_on(&ms_wait);
-                ms_busy = 0;
-                local_irq_restore(flags);
+                mutex_lock(&mutex);
                 ticks = MS_TICKS*ms-1;
                 ciaa.tblo=ticks%256;
                 ciaa.tbhi=ticks/256;
                 ciaa.crb=0x19; /*count eclock, force load, one-shoot, start */
-                sleep_on(&ms_wait);
+                wait_for_completion(&ms_wait_completion);
+                mutex_unlock(&mutex);
         }
 }
 
@@ -254,8 +250,7 @@ static void get_fdc(int drive)
         printk("get_fdc: drive %d  fdc_busy %d  fdc_nested %d\n",drive,fdc_busy,fdc_nested);
 #endif
         local_irq_save(flags);
-        while (!try_fdc(drive))
-                sleep_on(&fdc_wait);
+        wait_event(fdc_wait, try_fdc(drive));
         fdc_busy = drive;
         fdc_nested++;
         local_irq_restore(flags);
@@ -330,7 +325,7 @@ static void fd_deselect (int drive)
 static void motor_on_callback(unsigned long nr)
 {
         if (!(ciaa.pra & DSKRDY) || --on_attempts == 0) {
-                wake_up (&motor_wait);
+                complete_all(&motor_on_completion);
         } else {
                 motor_on_timer.expires = jiffies + HZ/10;
                 add_timer(&motor_on_timer);
@@ -347,11 +342,12 @@ static int fd_motor_on(int nr)
                 unit[nr].motor = 1;
                 fd_select(nr);
 
+                INIT_COMPLETION(motor_on_completion);
                 motor_on_timer.data = nr;
                 mod_timer(&motor_on_timer, jiffies + HZ/2);
 
                 on_attempts = 10;
-                sleep_on (&motor_wait);
+                wait_for_completion(&motor_on_completion);
                 fd_deselect(nr);
         }
 
@@ -582,8 +578,7 @@ static void raw_read(int drive)
 {
         drive&=3;
         get_fdc(drive);
-        while (block_flag)
-                sleep_on(&wait_fd_block);
+        wait_event(wait_fd_block, !block_flag);
         fd_select(drive);
         /* setup adkcon bits correctly */
         custom.adkcon = ADK_MSBSYNC;
@@ -598,8 +593,7 @@ static void raw_read(int drive)
 
         block_flag = 1;
 
-        while (block_flag)
-                sleep_on (&wait_fd_block);
+        wait_event(wait_fd_block, !block_flag);
 
         custom.dsklen = 0;
         fd_deselect(drive);
@@ -616,8 +610,7 @@ static int raw_write(int drive)
                 rel_fdc();
                 return 0;
         }
-        while (block_flag)
-                sleep_on(&wait_fd_block);
+        wait_event(wait_fd_block, !block_flag);
         fd_select(drive);
         /* clear adkcon bits */
         custom.adkcon = ADK_PRECOMP1|ADK_PRECOMP0|ADK_WORDSYNC|ADK_MSBSYNC;
@@ -1294,8 +1287,7 @@ static int non_int_flush_track (unsigned long nr)
                         writepending = 0;
                         return 0;
                 }
-                while (block_flag == 2)
-                        sleep_on (&wait_fd_block);
+                wait_event(wait_fd_block, block_flag != 2);
         }
         else {
                 local_irq_restore(flags);
diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c
index 7bcc1d8bc967..34f80fa6fed1 100644
--- a/drivers/block/nbd.c
+++ b/drivers/block/nbd.c
@@ -406,6 +406,7 @@ static int nbd_do_it(struct nbd_device *lo)
         ret = sysfs_create_file(&disk_to_dev(lo->disk)->kobj, &pid_attr.attr);
         if (ret) {
                 printk(KERN_ERR "nbd: sysfs_create_file failed!");
+                lo->pid = 0;
                 return ret;
         }
 
@@ -413,6 +414,7 @@ static int nbd_do_it(struct nbd_device *lo)
                 nbd_end_request(req);
 
         sysfs_remove_file(&disk_to_dev(lo->disk)->kobj, &pid_attr.attr);
+        lo->pid = 0;
         return 0;
 }
 
@@ -648,6 +650,8 @@ static int nbd_ioctl(struct block_device *bdev, fmode_t mode,
                 set_capacity(lo->disk, lo->bytesize >> 9);
                 return 0;
         case NBD_DO_IT:
+                if (lo->pid)
+                        return -EBUSY;
                 if (!lo->file)
                         return -EINVAL;
                 thread = kthread_create(nbd_thread, lo, lo->disk->disk_name);
diff --git a/drivers/block/ps3disk.c b/drivers/block/ps3disk.c
index 936466f62afd..bccc42bb9212 100644
--- a/drivers/block/ps3disk.c
+++ b/drivers/block/ps3disk.c
@@ -141,7 +141,7 @@ static int ps3disk_submit_request_sg(struct ps3_storage_device *dev,
 
         start_sector = req->sector * priv->blocking_factor;
         sectors = req->nr_sectors * priv->blocking_factor;
-        dev_dbg(&dev->sbd.core, "%s:%u: %s %lu sectors starting at %lu\n",
+        dev_dbg(&dev->sbd.core, "%s:%u: %s %llu sectors starting at %llu\n",
                 __func__, __LINE__, op, sectors, start_sector);
 
         if (write) {
@@ -178,7 +178,7 @@ static int ps3disk_submit_flush_request(struct ps3_storage_device *dev,
                                               LV1_STORAGE_ATA_HDDOUT, 0, 0, 0,
                                               0, &dev->tag);
         if (res) {
-                dev_err(&dev->sbd.core, "%s:%u: sync cache failed 0x%lx\n",
+                dev_err(&dev->sbd.core, "%s:%u: sync cache failed 0x%llx\n",
                         __func__, __LINE__, res);
                 end_request(req, 0);
                 return 0;
@@ -238,11 +238,11 @@ static irqreturn_t ps3disk_interrupt(int irq, void *data)
 
         if (tag != dev->tag)
                 dev_err(&dev->sbd.core,
-                        "%s:%u: tag mismatch, got %lx, expected %lx\n",
+                        "%s:%u: tag mismatch, got %llx, expected %llx\n",
                         __func__, __LINE__, tag, dev->tag);
 
         if (res) {
-                dev_err(&dev->sbd.core, "%s:%u: res=%d status=0x%lx\n",
+                dev_err(&dev->sbd.core, "%s:%u: res=%d status=0x%llx\n",
                         __func__, __LINE__, res, status);
                 return IRQ_HANDLED;
         }
@@ -269,7 +269,7 @@ static irqreturn_t ps3disk_interrupt(int irq, void *data)
                 op = read ? "read" : "write";
         }
         if (status) {
-                dev_dbg(&dev->sbd.core, "%s:%u: %s failed 0x%lx\n", __func__,
+                dev_dbg(&dev->sbd.core, "%s:%u: %s failed 0x%llx\n", __func__,
                         __LINE__, op, status);
                 error = -EIO;
         } else {
@@ -297,7 +297,7 @@ static int ps3disk_sync_cache(struct ps3_storage_device *dev)
 
         res = ps3stor_send_command(dev, LV1_STORAGE_ATA_HDDOUT, 0, 0, 0, 0);
         if (res) {
-                dev_err(&dev->sbd.core, "%s:%u: sync cache failed 0x%lx\n",
+                dev_err(&dev->sbd.core, "%s:%u: sync cache failed 0x%llx\n",
                         __func__, __LINE__, res);
                 return -EIO;
         }
@@ -388,7 +388,7 @@ static int ps3disk_identify(struct ps3_storage_device *dev)
                                    sizeof(ata_cmnd), ata_cmnd.buffer,
                                    ata_cmnd.arglen);
         if (res) {
-                dev_err(&dev->sbd.core, "%s:%u: identify disk failed 0x%lx\n",
+                dev_err(&dev->sbd.core, "%s:%u: identify disk failed 0x%llx\n",
                         __func__, __LINE__, res);
                 return -EIO;
         }
@@ -426,7 +426,7 @@ static int __devinit ps3disk_probe(struct ps3_system_bus_device *_dev)
 
         if (dev->blk_size < 512) {
                 dev_err(&dev->sbd.core,
-                        "%s:%u: cannot handle block size %lu\n", __func__,
+                        "%s:%u: cannot handle block size %llu\n", __func__,
                         __LINE__, dev->blk_size);
                 return -EINVAL;
         }
@@ -512,7 +512,7 @@ static int __devinit ps3disk_probe(struct ps3_system_bus_device *_dev)
                      dev->regions[dev->region_idx].size*priv->blocking_factor);
 
         dev_info(&dev->sbd.core,
-                 "%s is a %s (%lu MiB total, %lu MiB for OtherOS)\n",
+                 "%s is a %s (%llu MiB total, %lu MiB for OtherOS)\n",
                  gendisk->disk_name, priv->model, priv->raw_capacity >> 11,
                  get_capacity(gendisk) >> 11);
 
diff --git a/drivers/block/xsysace.c b/drivers/block/xsysace.c
index 29e1dfafb7c6..381d686fc1a3 100644
--- a/drivers/block/xsysace.c
+++ b/drivers/block/xsysace.c
@@ -1206,6 +1206,7 @@ static struct of_device_id ace_of_match[] __devinitdata = {
         { .compatible = "xlnx,opb-sysace-1.00.b", },
         { .compatible = "xlnx,opb-sysace-1.00.c", },
         { .compatible = "xlnx,xps-sysace-1.00.a", },
+        { .compatible = "xlnx,sysace", },
         {},
 };
 MODULE_DEVICE_TABLE(of, ace_of_match);