1 files changed, 11 insertions, 13 deletions

diff --git a/drivers/block/DAC960.c b/drivers/block/DAC960.c
index 9bdea2a5cf0e..45bcda544880 100644
--- a/drivers/block/DAC960.c
+++ b/drivers/block/DAC960.c
@@ -41,6 +41,7 @@
 #include <linux/timer.h>
 #include <linux/pci.h>
 #include <linux/init.h>
+#include <linux/jiffies.h>
 #include <linux/random.h>
 #include <asm/io.h>
 #include <asm/uaccess.h>
@@ -311,11 +312,10 @@ static boolean DAC960_CreateAuxiliaryStructures(DAC960_Controller_T *Controller)
                 CommandsRemaining = CommandAllocationGroupSize;
           CommandGroupByteCount =
                 CommandsRemaining * CommandAllocationLength;
-          AllocationPointer = kmalloc(CommandGroupByteCount, GFP_ATOMIC);
+          AllocationPointer = kzalloc(CommandGroupByteCount, GFP_ATOMIC);
           if (AllocationPointer == NULL)
                 return DAC960_Failure(Controller,
                                         "AUXILIARY STRUCTURE CREATION");
-          memset(AllocationPointer, 0, CommandGroupByteCount);
          }
       Command = (DAC960_Command_T *) AllocationPointer;
       AllocationPointer += CommandAllocationLength;
@@ -2709,14 +2709,12 @@ DAC960_DetectController(struct pci_dev *PCI_Device,
   void __iomem *BaseAddress;
   int i;
 
-  Controller = (DAC960_Controller_T *)
-        kmalloc(sizeof(DAC960_Controller_T), GFP_ATOMIC);
+  Controller = kzalloc(sizeof(DAC960_Controller_T), GFP_ATOMIC);
   if (Controller == NULL) {
         DAC960_Error("Unable to allocate Controller structure for "
                        "Controller at\n", NULL);
         return NULL;
   }
-  memset(Controller, 0, sizeof(DAC960_Controller_T));
   Controller->ControllerNumber = DAC960_ControllerCount;
   DAC960_Controllers[DAC960_ControllerCount++] = Controller;
   Controller->Bus = PCI_Device->bus->number;
@@ -3657,8 +3655,8 @@ static void DAC960_V1_ProcessCompletedCommand(DAC960_Command_T *Command)
               (NewEnquiry->EventLogSequenceNumber !=
                OldEnquiry->EventLogSequenceNumber) ||
               Controller->MonitoringTimerCount == 0 ||
-              (jiffies - Controller->SecondaryMonitoringTime
-               >= DAC960_SecondaryMonitoringInterval))
+              time_after_eq(jiffies, Controller->SecondaryMonitoringTime
+               + DAC960_SecondaryMonitoringInterval))
             {
               Controller->V1.NeedLogicalDriveInformation = true;
               Controller->V1.NewEventLogSequenceNumber =
@@ -5643,8 +5641,8 @@ static void DAC960_MonitoringTimerFunction(unsigned long TimerData)
       unsigned int StatusChangeCounter =
         Controller->V2.HealthStatusBuffer->StatusChangeCounter;
       boolean ForceMonitoringCommand = false;
-      if (jiffies - Controller->SecondaryMonitoringTime
-          > DAC960_SecondaryMonitoringInterval)
+      if (time_after(jiffies, Controller->SecondaryMonitoringTime
+          + DAC960_SecondaryMonitoringInterval))
         {
           int LogicalDriveNumber;
           for (LogicalDriveNumber = 0;
@@ -5672,8 +5670,8 @@ static void DAC960_MonitoringTimerFunction(unsigned long TimerData)
            ControllerInfo->ConsistencyChecksActive +
            ControllerInfo->RebuildsActive +
            ControllerInfo->OnlineExpansionsActive == 0 ||
-           jiffies - Controller->PrimaryMonitoringTime
-           < DAC960_MonitoringTimerInterval) &&
+           time_before(jiffies, Controller->PrimaryMonitoringTime
+           + DAC960_MonitoringTimerInterval)) &&
           !ForceMonitoringCommand)
         {
           Controller->MonitoringTimer.expires =
@@ -5810,8 +5808,8 @@ static void DAC960_Message(DAC960_MessageLevel_T MessageLevel,
       Controller->ProgressBufferLength = Length;
       if (Controller->EphemeralProgressMessage)
         {
-          if (jiffies - Controller->LastProgressReportTime
-              >= DAC960_ProgressReportingInterval)
+          if (time_after_eq(jiffies, Controller->LastProgressReportTime
+              + DAC960_ProgressReportingInterval))
             {
               printk("%sDAC960#%d: %s", DAC960_MessageLevelMap[MessageLevel],
                      Controller->ControllerNumber, Buffer);