5 files changed, 19 insertions, 43 deletions

diff --git a/drivers/base/Kconfig b/drivers/base/Kconfig
index 8fa8deab6449..4b7b4522b64f 100644
--- a/drivers/base/Kconfig
+++ b/drivers/base/Kconfig
@@ -1,10 +1,10 @@
 menu "Generic Driver Options"
 
-config UEVENT_HELPER_PATH
-        string "path to uevent helper"
-        default ""
+config UEVENT_HELPER
+        bool "Support for uevent helper"
+        default y
         help
-          Path to uevent helper program forked by the kernel for
+          The uevent helper program is forked by the kernel for
           every uevent.
           Before the switch to the netlink-based uevent source, this was
           used to hook hotplug scripts into kernel device events. It
@@ -15,8 +15,13 @@ config UEVENT_HELPER_PATH
           that it creates a high system load, or on smaller systems
           it is known to create out-of-memory situations during bootup.
 
-          To disable user space helper program execution at early boot
-          time specify an empty string here. This setting can be altered
+config UEVENT_HELPER_PATH
+        string "path to uevent helper"
+        depends on UEVENT_HELPER
+        default ""
+        help
+          To disable user space helper program execution at by default
+          specify an empty string here. This setting can still be altered
           via /proc/sys/kernel/hotplug or via /sys/kernel/uevent_helper
           later at runtime.
 
diff --git a/drivers/base/base.h b/drivers/base/base.h
index 24f424249d9b..251c5d30f963 100644
--- a/drivers/base/base.h
+++ b/drivers/base/base.h
@@ -63,8 +63,6 @@ struct driver_private {
  *      binding of drivers which were unable to get all the resources needed by
  *      the device; typically because it depends on another driver getting
  *      probed first.
- * @driver_data - private pointer for driver specific info.  Will turn into a
- * list soon.
  * @device - pointer back to the struct class that this structure is
  * associated with.
  *
@@ -76,7 +74,6 @@ struct device_private {
         struct klist_node knode_driver;
         struct klist_node knode_bus;
         struct list_head deferred_probe;
-        void *driver_data;
         struct device *device;
 };
 #define to_device_private_parent(obj)   \
diff --git a/drivers/base/dd.c b/drivers/base/dd.c
index 62ec61e8f84a..e4ffbcf2f519 100644
--- a/drivers/base/dd.c
+++ b/drivers/base/dd.c
@@ -587,29 +587,3 @@ void driver_detach(struct device_driver *drv)
                 put_device(dev);
         }
 }
-
-/*
- * These exports can't be _GPL due to .h files using this within them, and it
- * might break something that was previously working...
- */
-void *dev_get_drvdata(const struct device *dev)
-{
-        if (dev && dev->p)
-                return dev->p->driver_data;
-        return NULL;
-}
-EXPORT_SYMBOL(dev_get_drvdata);
-
-int dev_set_drvdata(struct device *dev, void *data)
-{
-        int error;
-
-        if (!dev->p) {
-                error = device_private_init(dev);
-                if (error)
-                        return error;
-        }
-        dev->p->driver_data = data;
-        return 0;
-}
-EXPORT_SYMBOL(dev_set_drvdata);
diff --git a/drivers/base/dma-coherent.c b/drivers/base/dma-coherent.c
index bc256b641027..7d6e84a51424 100644
--- a/drivers/base/dma-coherent.c
+++ b/drivers/base/dma-coherent.c
@@ -10,13 +10,13 @@
 struct dma_coherent_mem {
         void            *virt_base;
         dma_addr_t      device_base;
-        phys_addr_t     pfn_base;
+        unsigned long   pfn_base;
         int             size;
         int             flags;
         unsigned long   *bitmap;
 };
 
-int dma_declare_coherent_memory(struct device *dev, dma_addr_t bus_addr,
+int dma_declare_coherent_memory(struct device *dev, phys_addr_t phys_addr,
                                 dma_addr_t device_addr, size_t size, int flags)
 {
         void __iomem *mem_base = NULL;
@@ -32,7 +32,7 @@ int dma_declare_coherent_memory(struct device *dev, dma_addr_t bus_addr,
 
         /* FIXME: this routine just ignores DMA_MEMORY_INCLUDES_CHILDREN */
 
-        mem_base = ioremap(bus_addr, size);
+        mem_base = ioremap(phys_addr, size);
         if (!mem_base)
                 goto out;
 
@@ -45,7 +45,7 @@ int dma_declare_coherent_memory(struct device *dev, dma_addr_t bus_addr,
 
         dev->dma_mem->virt_base = mem_base;
         dev->dma_mem->device_base = device_addr;
-        dev->dma_mem->pfn_base = PFN_DOWN(bus_addr);
+        dev->dma_mem->pfn_base = PFN_DOWN(phys_addr);
         dev->dma_mem->size = pages;
         dev->dma_mem->flags = flags;
 
@@ -208,7 +208,7 @@ int dma_mmap_from_coherent(struct device *dev, struct vm_area_struct *vma,
 
                 *ret = -ENXIO;
                 if (off < count && user_count <= count - off) {
-                        unsigned pfn = mem->pfn_base + start + off;
+                        unsigned long pfn = mem->pfn_base + start + off;
                         *ret = remap_pfn_range(vma, vma->vm_start, pfn,
                                                user_count << PAGE_SHIFT,
                                                vma->vm_page_prot);
diff --git a/drivers/base/dma-mapping.c b/drivers/base/dma-mapping.c
index 0ce39a33b3c2..6cd08e145bfa 100644
--- a/drivers/base/dma-mapping.c
+++ b/drivers/base/dma-mapping.c
@@ -175,7 +175,7 @@ static void dmam_coherent_decl_release(struct device *dev, void *res)
 /**
  * dmam_declare_coherent_memory - Managed dma_declare_coherent_memory()
  * @dev: Device to declare coherent memory for
- * @bus_addr: Bus address of coherent memory to be declared
+ * @phys_addr: Physical address of coherent memory to be declared
  * @device_addr: Device address of coherent memory to be declared
  * @size: Size of coherent memory to be declared
  * @flags: Flags
@@ -185,7 +185,7 @@ static void dmam_coherent_decl_release(struct device *dev, void *res)
  * RETURNS:
  * 0 on success, -errno on failure.
  */
-int dmam_declare_coherent_memory(struct device *dev, dma_addr_t bus_addr,
+int dmam_declare_coherent_memory(struct device *dev, phys_addr_t phys_addr,
                                  dma_addr_t device_addr, size_t size, int flags)
 {
         void *res;
@@ -195,7 +195,7 @@ int dmam_declare_coherent_memory(struct device *dev, dma_addr_t bus_addr,
         if (!res)
                 return -ENOMEM;
 
-        rc = dma_declare_coherent_memory(dev, bus_addr, device_addr, size,
+        rc = dma_declare_coherent_memory(dev, phys_addr, device_addr, size,
                                          flags);
         if (rc == 0)
                 devres_add(dev, res);