diff options
Diffstat (limited to 'drivers/base')
-rw-r--r-- | drivers/base/cpu.c | 2 | ||||
-rw-r--r-- | drivers/base/firmware_class.c | 2 | ||||
-rw-r--r-- | drivers/base/power/main.c | 9 | ||||
-rw-r--r-- | drivers/base/power/qos.c | 10 | ||||
-rw-r--r-- | drivers/base/regmap/regmap.c | 2 |
5 files changed, 12 insertions, 13 deletions
diff --git a/drivers/base/cpu.c b/drivers/base/cpu.c index 63452943abd1..fb10728f6372 100644 --- a/drivers/base/cpu.c +++ b/drivers/base/cpu.c | |||
@@ -224,7 +224,7 @@ static void cpu_device_release(struct device *dev) | |||
224 | * by the cpu device. | 224 | * by the cpu device. |
225 | * | 225 | * |
226 | * Never copy this way of doing things, or you too will be made fun of | 226 | * Never copy this way of doing things, or you too will be made fun of |
227 | * on the linux-kerenl list, you have been warned. | 227 | * on the linux-kernel list, you have been warned. |
228 | */ | 228 | */ |
229 | } | 229 | } |
230 | 230 | ||
diff --git a/drivers/base/firmware_class.c b/drivers/base/firmware_class.c index d81460309182..b392b353be39 100644 --- a/drivers/base/firmware_class.c +++ b/drivers/base/firmware_class.c | |||
@@ -305,7 +305,7 @@ static bool fw_read_file_contents(struct file *file, struct firmware_buf *fw_buf | |||
305 | char *buf; | 305 | char *buf; |
306 | 306 | ||
307 | size = fw_file_size(file); | 307 | size = fw_file_size(file); |
308 | if (size < 0) | 308 | if (size <= 0) |
309 | return false; | 309 | return false; |
310 | buf = vmalloc(size); | 310 | buf = vmalloc(size); |
311 | if (!buf) | 311 | if (!buf) |
diff --git a/drivers/base/power/main.c b/drivers/base/power/main.c index a3c1404c7933..2b7f77d3fcb0 100644 --- a/drivers/base/power/main.c +++ b/drivers/base/power/main.c | |||
@@ -513,6 +513,8 @@ static int device_resume_early(struct device *dev, pm_message_t state) | |||
513 | 513 | ||
514 | Out: | 514 | Out: |
515 | TRACE_RESUME(error); | 515 | TRACE_RESUME(error); |
516 | |||
517 | pm_runtime_enable(dev); | ||
516 | return error; | 518 | return error; |
517 | } | 519 | } |
518 | 520 | ||
@@ -589,8 +591,6 @@ static int device_resume(struct device *dev, pm_message_t state, bool async) | |||
589 | if (!dev->power.is_suspended) | 591 | if (!dev->power.is_suspended) |
590 | goto Unlock; | 592 | goto Unlock; |
591 | 593 | ||
592 | pm_runtime_enable(dev); | ||
593 | |||
594 | if (dev->pm_domain) { | 594 | if (dev->pm_domain) { |
595 | info = "power domain "; | 595 | info = "power domain "; |
596 | callback = pm_op(&dev->pm_domain->ops, state); | 596 | callback = pm_op(&dev->pm_domain->ops, state); |
@@ -930,6 +930,8 @@ static int device_suspend_late(struct device *dev, pm_message_t state) | |||
930 | pm_callback_t callback = NULL; | 930 | pm_callback_t callback = NULL; |
931 | char *info = NULL; | 931 | char *info = NULL; |
932 | 932 | ||
933 | __pm_runtime_disable(dev, false); | ||
934 | |||
933 | if (dev->power.syscore) | 935 | if (dev->power.syscore) |
934 | return 0; | 936 | return 0; |
935 | 937 | ||
@@ -1133,11 +1135,8 @@ static int __device_suspend(struct device *dev, pm_message_t state, bool async) | |||
1133 | 1135 | ||
1134 | Complete: | 1136 | Complete: |
1135 | complete_all(&dev->power.completion); | 1137 | complete_all(&dev->power.completion); |
1136 | |||
1137 | if (error) | 1138 | if (error) |
1138 | async_error = error; | 1139 | async_error = error; |
1139 | else if (dev->power.is_suspended) | ||
1140 | __pm_runtime_disable(dev, false); | ||
1141 | 1140 | ||
1142 | return error; | 1141 | return error; |
1143 | } | 1142 | } |
diff --git a/drivers/base/power/qos.c b/drivers/base/power/qos.c index ff46387f5308..d21349544ce5 100644 --- a/drivers/base/power/qos.c +++ b/drivers/base/power/qos.c | |||
@@ -542,19 +542,19 @@ int dev_pm_qos_add_ancestor_request(struct device *dev, | |||
542 | struct dev_pm_qos_request *req, s32 value) | 542 | struct dev_pm_qos_request *req, s32 value) |
543 | { | 543 | { |
544 | struct device *ancestor = dev->parent; | 544 | struct device *ancestor = dev->parent; |
545 | int error = -ENODEV; | 545 | int ret = -ENODEV; |
546 | 546 | ||
547 | while (ancestor && !ancestor->power.ignore_children) | 547 | while (ancestor && !ancestor->power.ignore_children) |
548 | ancestor = ancestor->parent; | 548 | ancestor = ancestor->parent; |
549 | 549 | ||
550 | if (ancestor) | 550 | if (ancestor) |
551 | error = dev_pm_qos_add_request(ancestor, req, | 551 | ret = dev_pm_qos_add_request(ancestor, req, |
552 | DEV_PM_QOS_LATENCY, value); | 552 | DEV_PM_QOS_LATENCY, value); |
553 | 553 | ||
554 | if (error < 0) | 554 | if (ret < 0) |
555 | req->dev = NULL; | 555 | req->dev = NULL; |
556 | 556 | ||
557 | return error; | 557 | return ret; |
558 | } | 558 | } |
559 | EXPORT_SYMBOL_GPL(dev_pm_qos_add_ancestor_request); | 559 | EXPORT_SYMBOL_GPL(dev_pm_qos_add_ancestor_request); |
560 | 560 | ||
diff --git a/drivers/base/regmap/regmap.c b/drivers/base/regmap/regmap.c index 42d5cb0f503f..f00b059c057a 100644 --- a/drivers/base/regmap/regmap.c +++ b/drivers/base/regmap/regmap.c | |||
@@ -1106,7 +1106,7 @@ EXPORT_SYMBOL_GPL(regmap_raw_write); | |||
1106 | * @val_count: Number of registers to write | 1106 | * @val_count: Number of registers to write |
1107 | * | 1107 | * |
1108 | * This function is intended to be used for writing a large block of | 1108 | * This function is intended to be used for writing a large block of |
1109 | * data to be device either in single transfer or multiple transfer. | 1109 | * data to the device either in single transfer or multiple transfer. |
1110 | * | 1110 | * |
1111 | * A value of zero will be returned on success, a negative errno will | 1111 | * A value of zero will be returned on success, a negative errno will |
1112 | * be returned in error cases. | 1112 | * be returned in error cases. |