3 files changed, 7 insertions, 13 deletions

diff --git a/drivers/base/power/clock_ops.c b/drivers/base/power/clock_ops.c
index 869d7ff2227f..eb78e9640c4a 100644
--- a/drivers/base/power/clock_ops.c
+++ b/drivers/base/power/clock_ops.c
@@ -169,8 +169,7 @@ void pm_clk_init(struct device *dev)
  */
 int pm_clk_create(struct device *dev)
 {
-        int ret = dev_pm_get_subsys_data(dev);
-        return ret < 0 ? ret : 0;
+        return dev_pm_get_subsys_data(dev);
 }
 
 /**
diff --git a/drivers/base/power/common.c b/drivers/base/power/common.c
index a14085cc613f..39c32529b833 100644
--- a/drivers/base/power/common.c
+++ b/drivers/base/power/common.c
@@ -24,7 +24,6 @@
 int dev_pm_get_subsys_data(struct device *dev)
 {
         struct pm_subsys_data *psd;
-        int ret = 0;
 
         psd = kzalloc(sizeof(*psd), GFP_KERNEL);
         if (!psd)
@@ -40,7 +39,6 @@ int dev_pm_get_subsys_data(struct device *dev)
                 dev->power.subsys_data = psd;
                 pm_clk_init(dev);
                 psd = NULL;
-                ret = 1;
         }
 
         spin_unlock_irq(&dev->power.lock);
@@ -48,7 +46,7 @@ int dev_pm_get_subsys_data(struct device *dev)
         /* kfree() verifies that its argument is nonzero. */
         kfree(psd);
 
-        return ret;
+        return 0;
 }
 EXPORT_SYMBOL_GPL(dev_pm_get_subsys_data);
 
diff --git a/drivers/base/power/runtime.c b/drivers/base/power/runtime.c
index 59894873a3b3..7d9c1cb1c39a 100644
--- a/drivers/base/power/runtime.c
+++ b/drivers/base/power/runtime.c
@@ -147,6 +147,8 @@ static int rpm_check_suspend_allowed(struct device *dev)
             || (dev->power.request_pending
                         && dev->power.request == RPM_REQ_RESUME))
                 retval = -EAGAIN;
+        else if (__dev_pm_qos_read_value(dev) < 0)
+                retval = -EPERM;
         else if (dev->power.runtime_status == RPM_SUSPENDED)
                 retval = 1;
 
@@ -388,7 +390,6 @@ static int rpm_suspend(struct device *dev, int rpmflags)
                 goto repeat;
         }
 
-        dev->power.deferred_resume = false;
         if (dev->power.no_callbacks)
                 goto no_callback;       /* Assume success. */
 
@@ -403,12 +404,6 @@ static int rpm_suspend(struct device *dev, int rpmflags)
                 goto out;
         }
 
-        if (__dev_pm_qos_read_value(dev) < 0) {
-                /* Negative PM QoS constraint means "never suspend". */
-                retval = -EPERM;
-                goto out;
-        }
-
         __update_runtime_status(dev, RPM_SUSPENDING);
 
         if (dev->pm_domain)
@@ -440,6 +435,7 @@ static int rpm_suspend(struct device *dev, int rpmflags)
         wake_up_all(&dev->power.wait_queue);
 
         if (dev->power.deferred_resume) {
+                dev->power.deferred_resume = false;
                 rpm_resume(dev, 0);
                 retval = -EAGAIN;
                 goto out;
@@ -584,6 +580,7 @@ static int rpm_resume(struct device *dev, int rpmflags)
                     || dev->parent->power.runtime_status == RPM_ACTIVE) {
                         atomic_inc(&dev->parent->power.child_count);
                         spin_unlock(&dev->parent->power.lock);
+                        retval = 1;
                         goto no_callback;       /* Assume success. */
                 }
                 spin_unlock(&dev->parent->power.lock);
@@ -664,7 +661,7 @@ static int rpm_resume(struct device *dev, int rpmflags)
         }
         wake_up_all(&dev->power.wait_queue);
 
-        if (!retval)
+        if (retval >= 0)
                 rpm_idle(dev, RPM_ASYNC);
 
  out: