1 files changed, 13 insertions, 20 deletions

diff --git a/drivers/base/memory.c b/drivers/base/memory.c
index 7ae413fdd5fc..8ce6de5a7e28 100644
--- a/drivers/base/memory.c
+++ b/drivers/base/memory.c
@@ -20,6 +20,7 @@
 #include <linux/kobject.h>
 #include <linux/memory_hotplug.h>
 #include <linux/mm.h>
+#include <linux/mutex.h>
 #include <asm/atomic.h>
 #include <asm/uaccess.h>
 
@@ -61,8 +62,8 @@ void unregister_memory_notifier(struct notifier_block *nb)
 /*
  * register_memory - Setup a sysfs device for a memory block
  */
-int register_memory(struct memory_block *memory, struct mem_section *section,
-                struct node *root)
+static
+int register_memory(struct memory_block *memory, struct mem_section *section)
 {
         int error;
 
@@ -70,26 +71,18 @@ int register_memory(struct memory_block *memory, struct mem_section *section,
         memory->sysdev.id = __section_nr(section);
 
         error = sysdev_register(&memory->sysdev);
-
-        if (root && !error)
-                error = sysfs_create_link(&root->sysdev.kobj,
-                                          &memory->sysdev.kobj,
-                                          kobject_name(&memory->sysdev.kobj));
-
         return error;
 }
 
 static void
-unregister_memory(struct memory_block *memory, struct mem_section *section,
-                struct node *root)
+unregister_memory(struct memory_block *memory, struct mem_section *section)
 {
         BUG_ON(memory->sysdev.cls != &memory_sysdev_class);
         BUG_ON(memory->sysdev.id != __section_nr(section));
 
+        /* drop the ref. we got in remove_memory_block() */
+        kobject_put(&memory->sysdev.kobj);
         sysdev_unregister(&memory->sysdev);
-        if (root)
-                sysfs_remove_link(&root->sysdev.kobj,
-                                  kobject_name(&memory->sysdev.kobj));
 }
 
 /*
@@ -193,7 +186,7 @@ memory_block_action(struct memory_block *mem, unsigned long action)
                         break;
                 default:
                         printk(KERN_WARNING "%s(%p, %ld) unknown action: %ld\n",
-                                        __FUNCTION__, mem, action, action);
+                                        __func__, mem, action, action);
                         WARN_ON(1);
                         ret = -EINVAL;
         }
@@ -205,7 +198,7 @@ static int memory_block_change_state(struct memory_block *mem,
                 unsigned long to_state, unsigned long from_state_req)
 {
         int ret = 0;
-        down(&mem->state_sem);
+        mutex_lock(&mem->state_mutex);
 
         if (mem->state != from_state_req) {
                 ret = -EINVAL;
@@ -217,7 +210,7 @@ static int memory_block_change_state(struct memory_block *mem,
                 mem->state = to_state;
 
 out:
-        up(&mem->state_sem);
+        mutex_unlock(&mem->state_mutex);
         return ret;
 }
 
@@ -341,10 +334,10 @@ static int add_memory_block(unsigned long node_id, struct mem_section *section,
 
         mem->phys_index = __section_nr(section);
         mem->state = state;
-        init_MUTEX(&mem->state_sem);
+        mutex_init(&mem->state_mutex);
         mem->phys_device = phys_device;
 
-        ret = register_memory(mem, section, NULL);
+        ret = register_memory(mem, section);
         if (!ret)
                 ret = mem_create_simple_file(mem, phys_index);
         if (!ret)
@@ -395,7 +388,7 @@ int remove_memory_block(unsigned long node_id, struct mem_section *section,
         mem_remove_simple_file(mem, phys_index);
         mem_remove_simple_file(mem, state);
         mem_remove_simple_file(mem, phys_device);
-        unregister_memory(mem, section, NULL);
+        unregister_memory(mem, section);
 
         return 0;
 }
@@ -451,6 +444,6 @@ int __init memory_dev_init(void)
                 ret = err;
 out:
         if (ret)
-                printk(KERN_ERR "%s() failed: %d\n", __FUNCTION__, ret);
+                printk(KERN_ERR "%s() failed: %d\n", __func__, ret);
         return ret;
 }